gsd-pi 2.71.0-dev.e17e0ce → 2.72.0-dev.593fa74

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (169) hide show
  1. package/README.md +34 -1
  2. package/dist/cli.js +17 -0
  3. package/dist/mcp-server.js +37 -14
  4. package/dist/resources/agents/debugger.md +58 -0
  5. package/dist/resources/agents/doc-writer.md +43 -0
  6. package/dist/resources/agents/git-ops.md +56 -0
  7. package/dist/resources/agents/javascript-pro.md +46 -271
  8. package/dist/resources/agents/planner.md +55 -0
  9. package/dist/resources/agents/refactorer.md +47 -0
  10. package/dist/resources/agents/reviewer.md +48 -0
  11. package/dist/resources/agents/security.md +59 -0
  12. package/dist/resources/agents/tester.md +50 -0
  13. package/dist/resources/agents/typescript-pro.md +41 -235
  14. package/dist/resources/extensions/claude-code-cli/partial-builder.js +40 -12
  15. package/dist/resources/extensions/claude-code-cli/stream-adapter.js +103 -6
  16. package/dist/resources/extensions/gsd/auto/phases.js +4 -0
  17. package/dist/resources/extensions/gsd/auto-prompts.js +88 -33
  18. package/dist/resources/extensions/gsd/auto-start.js +24 -4
  19. package/dist/resources/extensions/gsd/auto.js +4 -0
  20. package/dist/resources/extensions/gsd/bootstrap/db-tools.js +3 -3
  21. package/dist/resources/extensions/gsd/bootstrap/register-shortcuts.js +2 -5
  22. package/dist/resources/extensions/gsd/doctor-providers.js +23 -0
  23. package/dist/resources/extensions/gsd/error-classifier.js +4 -1
  24. package/dist/resources/extensions/gsd/gate-registry.js +208 -0
  25. package/dist/resources/extensions/gsd/gsd-db.js +41 -0
  26. package/dist/resources/extensions/gsd/milestone-validation-gates.js +11 -12
  27. package/dist/resources/extensions/gsd/notification-overlay.js +26 -12
  28. package/dist/resources/extensions/gsd/notification-store.js +5 -4
  29. package/dist/resources/extensions/gsd/prompt-validation.js +126 -0
  30. package/dist/resources/extensions/gsd/prompts/complete-slice.md +3 -1
  31. package/dist/resources/extensions/gsd/prompts/execute-task.md +2 -0
  32. package/dist/resources/extensions/gsd/prompts/validate-milestone.md +2 -0
  33. package/dist/resources/extensions/gsd/shortcut-defs.js +7 -1
  34. package/dist/resources/extensions/gsd/state.js +9 -2
  35. package/dist/resources/extensions/gsd/tools/complete-slice.js +52 -1
  36. package/dist/resources/extensions/gsd/tools/complete-task.js +51 -1
  37. package/dist/resources/extensions/gsd/tools/workflow-tool-executors.js +4 -1
  38. package/dist/resources/extensions/ollama/index.js +13 -5
  39. package/dist/resources/extensions/shared/gsd-phase-state.js +35 -0
  40. package/dist/resources/extensions/subagent/agents.js +8 -0
  41. package/dist/resources/extensions/subagent/index.js +17 -0
  42. package/dist/startup-model-validation.d.ts +0 -1
  43. package/dist/startup-model-validation.js +6 -2
  44. package/dist/web/standalone/.next/BUILD_ID +1 -1
  45. package/dist/web/standalone/.next/app-path-routes-manifest.json +13 -13
  46. package/dist/web/standalone/.next/build-manifest.json +2 -2
  47. package/dist/web/standalone/.next/prerender-manifest.json +3 -3
  48. package/dist/web/standalone/.next/server/app/_global-error.html +1 -1
  49. package/dist/web/standalone/.next/server/app/_global-error.rsc +1 -1
  50. package/dist/web/standalone/.next/server/app/_global-error.segments/_full.segment.rsc +1 -1
  51. package/dist/web/standalone/.next/server/app/_global-error.segments/_global-error/__PAGE__.segment.rsc +1 -1
  52. package/dist/web/standalone/.next/server/app/_global-error.segments/_global-error.segment.rsc +1 -1
  53. package/dist/web/standalone/.next/server/app/_global-error.segments/_head.segment.rsc +1 -1
  54. package/dist/web/standalone/.next/server/app/_global-error.segments/_index.segment.rsc +1 -1
  55. package/dist/web/standalone/.next/server/app/_global-error.segments/_tree.segment.rsc +1 -1
  56. package/dist/web/standalone/.next/server/app/_not-found.html +1 -1
  57. package/dist/web/standalone/.next/server/app/_not-found.rsc +1 -1
  58. package/dist/web/standalone/.next/server/app/_not-found.segments/_full.segment.rsc +1 -1
  59. package/dist/web/standalone/.next/server/app/_not-found.segments/_head.segment.rsc +1 -1
  60. package/dist/web/standalone/.next/server/app/_not-found.segments/_index.segment.rsc +1 -1
  61. package/dist/web/standalone/.next/server/app/_not-found.segments/_not-found/__PAGE__.segment.rsc +1 -1
  62. package/dist/web/standalone/.next/server/app/_not-found.segments/_not-found.segment.rsc +1 -1
  63. package/dist/web/standalone/.next/server/app/_not-found.segments/_tree.segment.rsc +1 -1
  64. package/dist/web/standalone/.next/server/app/index.html +1 -1
  65. package/dist/web/standalone/.next/server/app/index.rsc +1 -1
  66. package/dist/web/standalone/.next/server/app/index.segments/__PAGE__.segment.rsc +1 -1
  67. package/dist/web/standalone/.next/server/app/index.segments/_full.segment.rsc +1 -1
  68. package/dist/web/standalone/.next/server/app/index.segments/_head.segment.rsc +1 -1
  69. package/dist/web/standalone/.next/server/app/index.segments/_index.segment.rsc +1 -1
  70. package/dist/web/standalone/.next/server/app/index.segments/_tree.segment.rsc +1 -1
  71. package/dist/web/standalone/.next/server/app-paths-manifest.json +13 -13
  72. package/dist/web/standalone/.next/server/middleware-build-manifest.js +1 -1
  73. package/dist/web/standalone/.next/server/pages/404.html +1 -1
  74. package/dist/web/standalone/.next/server/pages/500.html +1 -1
  75. package/dist/web/standalone/.next/server/server-reference-manifest.json +1 -1
  76. package/package.json +1 -1
  77. package/packages/mcp-server/dist/server.d.ts +12 -1
  78. package/packages/mcp-server/dist/server.d.ts.map +1 -1
  79. package/packages/mcp-server/dist/server.js +90 -42
  80. package/packages/mcp-server/dist/server.js.map +1 -1
  81. package/packages/mcp-server/dist/workflow-tools.js +1 -1
  82. package/packages/mcp-server/dist/workflow-tools.js.map +1 -1
  83. package/packages/mcp-server/src/server.ts +110 -38
  84. package/packages/mcp-server/src/workflow-tools.ts +1 -1
  85. package/packages/pi-coding-agent/dist/core/model-resolver.test.d.ts +8 -0
  86. package/packages/pi-coding-agent/dist/core/model-resolver.test.d.ts.map +1 -0
  87. package/packages/pi-coding-agent/dist/core/model-resolver.test.js +75 -0
  88. package/packages/pi-coding-agent/dist/core/model-resolver.test.js.map +1 -0
  89. package/packages/pi-coding-agent/dist/core/retry-handler.d.ts +5 -0
  90. package/packages/pi-coding-agent/dist/core/retry-handler.d.ts.map +1 -1
  91. package/packages/pi-coding-agent/dist/core/retry-handler.js +55 -1
  92. package/packages/pi-coding-agent/dist/core/retry-handler.js.map +1 -1
  93. package/packages/pi-coding-agent/dist/core/retry-handler.test.js +57 -0
  94. package/packages/pi-coding-agent/dist/core/retry-handler.test.js.map +1 -1
  95. package/packages/pi-coding-agent/dist/modes/interactive/components/__tests__/tool-execution.test.js +36 -0
  96. package/packages/pi-coding-agent/dist/modes/interactive/components/__tests__/tool-execution.test.js.map +1 -1
  97. package/packages/pi-coding-agent/dist/modes/interactive/components/model-selector.d.ts.map +1 -1
  98. package/packages/pi-coding-agent/dist/modes/interactive/components/model-selector.js +9 -2
  99. package/packages/pi-coding-agent/dist/modes/interactive/components/model-selector.js.map +1 -1
  100. package/packages/pi-coding-agent/dist/modes/interactive/components/tool-execution.d.ts.map +1 -1
  101. package/packages/pi-coding-agent/dist/modes/interactive/components/tool-execution.js +87 -12
  102. package/packages/pi-coding-agent/dist/modes/interactive/components/tool-execution.js.map +1 -1
  103. package/packages/pi-coding-agent/dist/modes/interactive/controllers/model-controller.d.ts.map +1 -1
  104. package/packages/pi-coding-agent/dist/modes/interactive/controllers/model-controller.js +6 -1
  105. package/packages/pi-coding-agent/dist/modes/interactive/controllers/model-controller.js.map +1 -1
  106. package/packages/pi-coding-agent/package.json +1 -1
  107. package/packages/pi-coding-agent/src/core/model-resolver.test.ts +85 -0
  108. package/packages/pi-coding-agent/src/core/retry-handler.test.ts +83 -0
  109. package/packages/pi-coding-agent/src/core/retry-handler.ts +60 -1
  110. package/packages/pi-coding-agent/src/modes/interactive/components/__tests__/tool-execution.test.ts +72 -0
  111. package/packages/pi-coding-agent/src/modes/interactive/components/model-selector.ts +15 -6
  112. package/packages/pi-coding-agent/src/modes/interactive/components/tool-execution.ts +84 -12
  113. package/packages/pi-coding-agent/src/modes/interactive/controllers/model-controller.ts +6 -1
  114. package/pkg/package.json +1 -1
  115. package/src/resources/agents/debugger.md +58 -0
  116. package/src/resources/agents/doc-writer.md +43 -0
  117. package/src/resources/agents/git-ops.md +56 -0
  118. package/src/resources/agents/javascript-pro.md +46 -271
  119. package/src/resources/agents/planner.md +55 -0
  120. package/src/resources/agents/refactorer.md +47 -0
  121. package/src/resources/agents/reviewer.md +48 -0
  122. package/src/resources/agents/security.md +59 -0
  123. package/src/resources/agents/tester.md +50 -0
  124. package/src/resources/agents/typescript-pro.md +41 -235
  125. package/src/resources/extensions/claude-code-cli/partial-builder.ts +45 -12
  126. package/src/resources/extensions/claude-code-cli/stream-adapter.ts +109 -3
  127. package/src/resources/extensions/claude-code-cli/tests/partial-builder.test.ts +91 -2
  128. package/src/resources/extensions/claude-code-cli/tests/stream-adapter.test.ts +133 -2
  129. package/src/resources/extensions/gsd/auto/phases.ts +4 -0
  130. package/src/resources/extensions/gsd/auto-prompts.ts +111 -33
  131. package/src/resources/extensions/gsd/auto-start.ts +31 -4
  132. package/src/resources/extensions/gsd/auto.ts +4 -0
  133. package/src/resources/extensions/gsd/bootstrap/db-tools.ts +3 -3
  134. package/src/resources/extensions/gsd/bootstrap/register-shortcuts.ts +2 -5
  135. package/src/resources/extensions/gsd/doctor-providers.ts +24 -0
  136. package/src/resources/extensions/gsd/error-classifier.ts +4 -1
  137. package/src/resources/extensions/gsd/gate-registry.ts +251 -0
  138. package/src/resources/extensions/gsd/gsd-db.ts +51 -0
  139. package/src/resources/extensions/gsd/milestone-validation-gates.ts +11 -13
  140. package/src/resources/extensions/gsd/notification-overlay.ts +27 -11
  141. package/src/resources/extensions/gsd/notification-store.ts +5 -4
  142. package/src/resources/extensions/gsd/prompt-validation.ts +157 -0
  143. package/src/resources/extensions/gsd/prompts/complete-slice.md +3 -1
  144. package/src/resources/extensions/gsd/prompts/execute-task.md +2 -0
  145. package/src/resources/extensions/gsd/prompts/validate-milestone.md +2 -0
  146. package/src/resources/extensions/gsd/shortcut-defs.ts +8 -1
  147. package/src/resources/extensions/gsd/state.ts +13 -2
  148. package/src/resources/extensions/gsd/tests/auto-start-model-capture.test.ts +14 -0
  149. package/src/resources/extensions/gsd/tests/complete-slice-gate-closure.test.ts +167 -0
  150. package/src/resources/extensions/gsd/tests/doctor-providers.test.ts +36 -0
  151. package/src/resources/extensions/gsd/tests/format-shortcut.test.ts +16 -0
  152. package/src/resources/extensions/gsd/tests/gate-dispatch.test.ts +27 -0
  153. package/src/resources/extensions/gsd/tests/gate-registry.test.ts +140 -0
  154. package/src/resources/extensions/gsd/tests/prompt-system-gate-coverage.test.ts +208 -0
  155. package/src/resources/extensions/gsd/tests/provider-errors.test.ts +9 -0
  156. package/src/resources/extensions/gsd/tests/register-shortcuts.test.ts +3 -2
  157. package/src/resources/extensions/gsd/tools/complete-slice.ts +63 -0
  158. package/src/resources/extensions/gsd/tools/complete-task.ts +63 -0
  159. package/src/resources/extensions/gsd/tools/workflow-tool-executors.ts +4 -1
  160. package/src/resources/extensions/gsd/types.ts +26 -0
  161. package/src/resources/extensions/ollama/index.ts +13 -3
  162. package/src/resources/extensions/ollama/ollama-status-indicator.test.ts +28 -0
  163. package/src/resources/extensions/shared/gsd-phase-state.ts +42 -0
  164. package/src/resources/extensions/shared/tests/gsd-phase-state.test.ts +48 -0
  165. package/src/resources/extensions/subagent/agents.ts +10 -0
  166. package/src/resources/extensions/subagent/index.ts +18 -0
  167. package/src/resources/extensions/subagent/tests/agents-conflicts.test.ts +33 -0
  168. /package/dist/web/standalone/.next/static/{cYPZv_bAhZk2ms-Pz6vsY → h8B07q4xc-ujHRD7esO6O}/_buildManifest.js +0 -0
  169. /package/dist/web/standalone/.next/static/{cYPZv_bAhZk2ms-Pz6vsY → h8B07q4xc-ujHRD7esO6O}/_ssgManifest.js +0 -0
@@ -0,0 +1,208 @@
1
+ /**
2
+ * Prompt-system gate coverage tests.
3
+ *
4
+ * These tests pin the invariants the plan file documents:
5
+ * 1. Every pending slice-scoped gate is routed to exactly one owner turn.
6
+ * Q8 (owned by complete-slice) MUST NOT leak into gate-evaluate and
7
+ * get silently dropped the way it used to before the registry landed.
8
+ * 2. getPendingGatesForTurn filters by the registry's owner turn, not
9
+ * just the DB scope column.
10
+ * 3. Output validators recognize artifacts that contain the required
11
+ * gate section headings, and flag ones that don't.
12
+ * 4. Prompt output produced by the validators reflects MV01-MV04.
13
+ *
14
+ * They also assert the VALIDATION.md renderer still produces headings
15
+ * matching the registry's promptSection strings, so future renderer
16
+ * edits that drift from the registry fail the suite loudly.
17
+ */
18
+
19
+ import { describe, test, beforeEach, afterEach } from "node:test";
20
+ import assert from "node:assert/strict";
21
+ import { mkdtempSync, rmSync } from "node:fs";
22
+ import { join } from "node:path";
23
+ import { tmpdir } from "node:os";
24
+
25
+ import {
26
+ openDatabase,
27
+ closeDatabase,
28
+ insertMilestone,
29
+ insertSlice,
30
+ insertTask,
31
+ insertGateRow,
32
+ getPendingGates,
33
+ getPendingGatesForTurn,
34
+ } from "../gsd-db.ts";
35
+ import {
36
+ GATE_REGISTRY,
37
+ getGatesForTurn,
38
+ type OwnerTurn,
39
+ } from "../gate-registry.ts";
40
+ import {
41
+ validateSliceSummaryOutput,
42
+ validateTaskSummaryOutput,
43
+ validateMilestoneValidationOutput,
44
+ validateGateSections,
45
+ } from "../prompt-validation.ts";
46
+
47
+ function setupTestDb(): string {
48
+ const tmpDir = mkdtempSync(join(tmpdir(), "prompt-gate-coverage-"));
49
+ const dbPath = join(tmpDir, "gsd.db");
50
+ openDatabase(dbPath);
51
+ insertMilestone({ id: "M001", title: "Test", status: "active" });
52
+ insertSlice({
53
+ milestoneId: "M001",
54
+ id: "S01",
55
+ title: "Test Slice",
56
+ status: "pending",
57
+ risk: "medium",
58
+ depends: [],
59
+ });
60
+ insertTask({
61
+ id: "T01",
62
+ sliceId: "S01",
63
+ milestoneId: "M001",
64
+ title: "Test Task",
65
+ status: "pending",
66
+ });
67
+ return tmpDir;
68
+ }
69
+
70
+ describe("getPendingGatesForTurn routes by owner turn, not scope column", () => {
71
+ let tmpDir: string;
72
+ beforeEach(() => {
73
+ tmpDir = setupTestDb();
74
+ });
75
+ afterEach(() => {
76
+ closeDatabase();
77
+ rmSync(tmpDir, { recursive: true, force: true });
78
+ });
79
+
80
+ test("Q8 stored as scope:'slice' is owned by complete-slice, not gate-evaluate", () => {
81
+ // Seed the three slice-scoped gates plan-slice writes today.
82
+ insertGateRow({ milestoneId: "M001", sliceId: "S01", gateId: "Q3", scope: "slice" });
83
+ insertGateRow({ milestoneId: "M001", sliceId: "S01", gateId: "Q4", scope: "slice" });
84
+ insertGateRow({ milestoneId: "M001", sliceId: "S01", gateId: "Q8", scope: "slice" });
85
+
86
+ // getPendingGates(..., "slice") returns all three (unchanged).
87
+ const allSlicePending = getPendingGates("M001", "S01", "slice");
88
+ assert.equal(allSlicePending.length, 3);
89
+
90
+ // But the turn-aware helper routes them correctly.
91
+ const gateEval = getPendingGatesForTurn("M001", "S01", "gate-evaluate");
92
+ assert.deepEqual(gateEval.map((g) => g.gate_id).sort(), ["Q3", "Q4"]);
93
+
94
+ const completeSlice = getPendingGatesForTurn("M001", "S01", "complete-slice");
95
+ assert.deepEqual(completeSlice.map((g) => g.gate_id), ["Q8"]);
96
+ });
97
+
98
+ test("task-scoped gates are scoped to the requested task id", () => {
99
+ insertGateRow({ milestoneId: "M001", sliceId: "S01", gateId: "Q5", scope: "task", taskId: "T01" });
100
+ insertGateRow({ milestoneId: "M001", sliceId: "S01", gateId: "Q6", scope: "task", taskId: "T01" });
101
+ insertGateRow({ milestoneId: "M001", sliceId: "S01", gateId: "Q5", scope: "task", taskId: "T02" });
102
+
103
+ const t1 = getPendingGatesForTurn("M001", "S01", "execute-task", "T01");
104
+ assert.equal(t1.length, 2);
105
+ assert.ok(t1.every((g) => g.gate_id === "Q5" || g.gate_id === "Q6"));
106
+
107
+ const t2 = getPendingGatesForTurn("M001", "S01", "execute-task", "T02");
108
+ assert.equal(t2.length, 1);
109
+ assert.equal(t2[0].gate_id, "Q5");
110
+ });
111
+ });
112
+
113
+ describe("per-turn output validators", () => {
114
+ test("validateSliceSummaryOutput flags missing Operational Readiness", () => {
115
+ const md = `# S01: Test Slice\n\n## What Happened\nstuff\n\n## Verification\nstuff\n`;
116
+ const result = validateSliceSummaryOutput(md);
117
+ assert.equal(result.valid, false);
118
+ assert.ok(result.missing.some((m) => m.includes("Q8")));
119
+ assert.ok(result.missing.some((m) => m.includes("Operational Readiness")));
120
+ });
121
+
122
+ test("validateSliceSummaryOutput passes when Operational Readiness heading is present", () => {
123
+ const md = `# S01\n\n## Operational Readiness\n- Health: /health\n- Failure: alert\n`;
124
+ const result = validateSliceSummaryOutput(md);
125
+ assert.equal(result.valid, true);
126
+ assert.equal(result.missing.length, 0);
127
+ });
128
+
129
+ test("validateMilestoneValidationOutput requires all four MV headings", () => {
130
+ // Missing Requirement Coverage.
131
+ const md = [
132
+ "# Milestone Validation: M001",
133
+ "## Success Criteria Checklist",
134
+ "ok",
135
+ "## Slice Delivery Audit",
136
+ "ok",
137
+ "## Cross-Slice Integration",
138
+ "ok",
139
+ ].join("\n\n");
140
+ const result = validateMilestoneValidationOutput(md);
141
+ assert.equal(result.valid, false);
142
+ assert.ok(result.missing.some((m) => m.includes("MV04")));
143
+ });
144
+
145
+ test("validateMilestoneValidationOutput passes for a complete VALIDATION.md", () => {
146
+ const md = [
147
+ "# Milestone Validation: M001",
148
+ "## Success Criteria Checklist",
149
+ "ok",
150
+ "## Slice Delivery Audit",
151
+ "ok",
152
+ "## Cross-Slice Integration",
153
+ "ok",
154
+ "## Requirement Coverage",
155
+ "ok",
156
+ ].join("\n\n");
157
+ const result = validateMilestoneValidationOutput(md);
158
+ assert.equal(result.valid, true, `unexpected missing: ${result.missing.join(", ")}`);
159
+ });
160
+
161
+ test("validateTaskSummaryOutput flags missing task-gate sections", () => {
162
+ const md = `# T01\n\n## What Happened\nstuff\n\n## Verification\nstuff\n`;
163
+ const result = validateTaskSummaryOutput(md);
164
+ assert.equal(result.valid, false);
165
+ const idsInMissing = result.missing.join(" ");
166
+ assert.ok(idsInMissing.includes("Q5"));
167
+ assert.ok(idsInMissing.includes("Q6"));
168
+ assert.ok(idsInMissing.includes("Q7"));
169
+ });
170
+
171
+ test("validateGateSections returns empty missing when gate bucket is empty", () => {
172
+ // Build a phoney owner turn that owns nothing (simulate by validating
173
+ // against a real turn against an artifact containing every section).
174
+ const fullMd = getGatesForTurn("validate-milestone")
175
+ .map((g) => `## ${g.promptSection}\n\nstuff`)
176
+ .join("\n\n");
177
+ const result = validateGateSections(fullMd, "validate-milestone");
178
+ assert.equal(result.valid, true);
179
+ });
180
+ });
181
+
182
+ describe("registry / renderer parity", () => {
183
+ test("MV promptSections match the validate-milestone renderer H2 headings", () => {
184
+ // Mirror the string literals from tools/validate-milestone.ts
185
+ // renderValidationMarkdown() so a rename there flips this test red.
186
+ const expectedHeadings = [
187
+ "Success Criteria Checklist",
188
+ "Slice Delivery Audit",
189
+ "Cross-Slice Integration",
190
+ "Requirement Coverage",
191
+ ];
192
+ const registryHeadings = getGatesForTurn("validate-milestone").map((g) => g.promptSection);
193
+ assert.deepEqual(registryHeadings.sort(), [...expectedHeadings].sort());
194
+ });
195
+
196
+ test("Q8 promptSection matches the complete-slice renderer H2 heading", () => {
197
+ // Mirror the slice-summary H2 introduced in tools/complete-slice.ts.
198
+ assert.equal(GATE_REGISTRY.Q8.promptSection, "Operational Readiness");
199
+ });
200
+
201
+ test("registry owner turns cover every turn gate-registry.ts declares", () => {
202
+ const ownerTurns = new Set<OwnerTurn>(Object.values(GATE_REGISTRY).map((g) => g.ownerTurn));
203
+ assert.ok(ownerTurns.has("gate-evaluate"));
204
+ assert.ok(ownerTurns.has("execute-task"));
205
+ assert.ok(ownerTurns.has("complete-slice"));
206
+ assert.ok(ownerTurns.has("validate-milestone"));
207
+ });
208
+ });
@@ -32,6 +32,15 @@ test("classifyError detects rate limit from message", () => {
32
32
  assert.equal(result.kind, "rate-limit");
33
33
  });
34
34
 
35
+ test("classifyError treats OpenRouter affordability errors as transient rate-limit class", () => {
36
+ const result = classifyError(
37
+ "402 This request requires more credits, or fewer max_tokens. You requested up to 32000 tokens, but can only afford 329.",
38
+ );
39
+ assert.ok(isTransient(result));
40
+ assert.equal(result.kind, "rate-limit");
41
+ assert.ok("retryAfterMs" in result && result.retryAfterMs > 0);
42
+ });
43
+
35
44
  test("classifyError extracts reset delay from message", () => {
36
45
  const result = classifyError("rate limit exceeded, reset in 45s");
37
46
  assert.equal(result.kind, "rate-limit");
@@ -69,14 +69,15 @@ test("dashboard shortcut resolves the project root instead of the current worktr
69
69
 
70
70
  assert.ok(customCalls > 0, "shortcut opens the dashboard overlay when project root is resolved");
71
71
  assert.equal(notices.length, 0, "shortcut does not fall back to the missing-.gsd warning");
72
- assert.equal(shortcuts.length, 6, "all GSD shortcuts are still registered");
72
+ assert.equal(shortcuts.length, 5, "all GSD shortcuts are still registered");
73
73
  const keys = shortcuts.map((shortcut) => shortcut.key);
74
74
  assert.ok(keys.includes("ctrl+alt+g"), "primary dashboard shortcut is registered");
75
75
  assert.ok(keys.includes("ctrl+shift+g"), "fallback dashboard shortcut is registered");
76
76
  assert.ok(keys.includes("ctrl+alt+n"), "primary notifications shortcut is registered");
77
77
  assert.ok(keys.includes("ctrl+shift+n"), "fallback notifications shortcut is registered");
78
78
  assert.ok(keys.includes("ctrl+alt+p"), "primary parallel shortcut is registered");
79
- assert.ok(keys.includes("ctrl+shift+p"), "fallback parallel shortcut is registered");
79
+ // No Ctrl+Shift+P fallback conflicts with cycleModelBackward (shift+ctrl+p)
80
+ assert.ok(!keys.includes("ctrl+shift+p"), "parallel fallback must not be registered (conflicts with cycleModelBackward)");
80
81
  });
81
82
 
82
83
  test("parallel shortcut passes resolved project root into overlay", async (t) => {
@@ -21,7 +21,10 @@ import {
21
21
  getMilestone,
22
22
  updateSliceStatus,
23
23
  setSliceSummaryMd,
24
+ saveGateResult,
25
+ getPendingGatesForTurn,
24
26
  } from "../gsd-db.js";
27
+ import { getGatesForTurn } from "../gate-registry.js";
25
28
  import { resolveSliceFile, resolveSlicePath, clearPathCache } from "../paths.js";
26
29
  import { checkOwnership, sliceUnitKey } from "../unit-ownership.js";
27
30
  import { saveFile, clearParseCache } from "../files.js";
@@ -39,6 +42,23 @@ export interface CompleteSliceResult {
39
42
  uatPath: string;
40
43
  }
41
44
 
45
+ /**
46
+ * Map a complete-slice-owned gate id to the CompleteSliceParams field
47
+ * whose presence drives `pass` vs. `omitted`. Keep this in lockstep with
48
+ * the gates declared in gate-registry.ts under ownerTurn "complete-slice".
49
+ */
50
+ function sliceGateFieldForId(
51
+ id: string,
52
+ params: CompleteSliceParams,
53
+ ): string | undefined {
54
+ switch (id) {
55
+ case "Q8":
56
+ return params.operationalReadiness;
57
+ default:
58
+ return undefined;
59
+ }
60
+ }
61
+
42
62
  /**
43
63
  * Render slice summary markdown matching the template format.
44
64
  * YAML frontmatter uses snake_case keys for parseSummary() compatibility.
@@ -169,6 +189,10 @@ ${reqSurfaced}
169
189
 
170
190
  ${reqInvalidated}
171
191
 
192
+ ## Operational Readiness
193
+
194
+ ${params.operationalReadiness?.trim() || "None."}
195
+
172
196
  ## Deviations
173
197
 
174
198
  ${params.deviations || "None."}
@@ -330,6 +354,45 @@ export async function handleCompleteSlice(
330
354
  // Store rendered markdown in DB for D004 recovery
331
355
  setSliceSummaryMd(params.milestoneId, params.sliceId, summaryMd, uatMd);
332
356
 
357
+ // ── Close gates owned by complete-slice (Q8) ───────────────────────────
358
+ // Each owned gate maps to a specific summary section via the registry.
359
+ // If the caller populated the corresponding field, record `pass`; if the
360
+ // field is empty, record `omitted`. Without this loop, Q8 would stay
361
+ // pending forever and block future state derivation (see gate-registry).
362
+ try {
363
+ const pendingGates = getPendingGatesForTurn(
364
+ params.milestoneId,
365
+ params.sliceId,
366
+ "complete-slice",
367
+ );
368
+ if (pendingGates.length > 0) {
369
+ const ownedDefs = new Map(getGatesForTurn("complete-slice").map((g) => [g.id, g] as const));
370
+ for (const row of pendingGates) {
371
+ const def = ownedDefs.get(row.gate_id);
372
+ if (!def) continue;
373
+ // Map gate id → param field it maps to. Keep the map local so
374
+ // adding a new complete-slice gate is a single place change.
375
+ const field = sliceGateFieldForId(def.id, params);
376
+ const hasContent = typeof field === "string" && field.trim().length > 0;
377
+ saveGateResult({
378
+ milestoneId: params.milestoneId,
379
+ sliceId: params.sliceId,
380
+ gateId: def.id,
381
+ verdict: hasContent ? "pass" : "omitted",
382
+ rationale: hasContent
383
+ ? `${def.promptSection} section populated in slice summary`
384
+ : `${def.promptSection} section left empty — recorded as omitted`,
385
+ findings: hasContent ? (field as string).trim() : "",
386
+ });
387
+ }
388
+ }
389
+ } catch (gateErr) {
390
+ logWarning(
391
+ "tool",
392
+ `complete-slice gate close warning for ${params.milestoneId}/${params.sliceId}: ${(gateErr as Error).message}`,
393
+ );
394
+ }
395
+
333
396
  // Invalidate all caches
334
397
  invalidateStateCache();
335
398
  clearPathCache();
@@ -24,7 +24,10 @@ import {
24
24
  updateTaskStatus,
25
25
  setTaskSummaryMd,
26
26
  deleteVerificationEvidence,
27
+ saveGateResult,
28
+ getPendingGatesForTurn,
27
29
  } from "../gsd-db.js";
30
+ import { getGatesForTurn } from "../gate-registry.js";
28
31
  import { resolveSliceFile, resolveTasksDir, clearPathCache } from "../paths.js";
29
32
  import { checkOwnership, taskUnitKey } from "../unit-ownership.js";
30
33
  import { saveFile, clearParseCache } from "../files.js";
@@ -44,6 +47,27 @@ export interface CompleteTaskResult {
44
47
 
45
48
  import type { TaskRow } from "../gsd-db.js";
46
49
 
50
+ /**
51
+ * Map an execute-task-owned gate id to the CompleteTaskParams field whose
52
+ * presence drives `pass` vs. `omitted`. Keep in lockstep with the gates
53
+ * declared in gate-registry.ts under ownerTurn "execute-task".
54
+ */
55
+ function taskGateFieldForId(
56
+ id: string,
57
+ params: CompleteTaskParams,
58
+ ): string | undefined {
59
+ switch (id) {
60
+ case "Q5":
61
+ return params.failureModes;
62
+ case "Q6":
63
+ return params.loadProfile;
64
+ case "Q7":
65
+ return params.negativeTests;
66
+ default:
67
+ return undefined;
68
+ }
69
+ }
70
+
47
71
  /**
48
72
  * Normalize a list parameter that may arrive as a string (newline-delimited
49
73
  * bullet list from the LLM) into a string array (#3361).
@@ -236,6 +260,45 @@ export async function handleCompleteTask(
236
260
  // Store rendered markdown in DB for D004 recovery
237
261
  setTaskSummaryMd(params.milestoneId, params.sliceId, params.taskId, summaryMd);
238
262
 
263
+ // ── Close gates owned by execute-task (Q5/Q6/Q7) for this task ────────
264
+ // Each gate id maps to a specific params field via taskGateFieldForId.
265
+ // When the model populates the field, record `pass`; when it's empty,
266
+ // record `omitted`. Task-scoped rows are filtered by taskId so a single
267
+ // task's completion doesn't touch sibling tasks' gate rows.
268
+ try {
269
+ const pendingGates = getPendingGatesForTurn(
270
+ params.milestoneId,
271
+ params.sliceId,
272
+ "execute-task",
273
+ params.taskId,
274
+ );
275
+ if (pendingGates.length > 0) {
276
+ const ownedDefs = new Map(getGatesForTurn("execute-task").map((g) => [g.id, g] as const));
277
+ for (const row of pendingGates) {
278
+ const def = ownedDefs.get(row.gate_id);
279
+ if (!def) continue;
280
+ const field = taskGateFieldForId(def.id, params);
281
+ const hasContent = typeof field === "string" && field.trim().length > 0;
282
+ saveGateResult({
283
+ milestoneId: params.milestoneId,
284
+ sliceId: params.sliceId,
285
+ taskId: params.taskId,
286
+ gateId: def.id,
287
+ verdict: hasContent ? "pass" : "omitted",
288
+ rationale: hasContent
289
+ ? `${def.promptSection} section populated in task summary`
290
+ : `${def.promptSection} section left empty — recorded as omitted`,
291
+ findings: hasContent ? (field as string).trim() : "",
292
+ });
293
+ }
294
+ }
295
+ } catch (gateErr) {
296
+ logWarning(
297
+ "tool",
298
+ `complete-task gate close warning for ${params.milestoneId}/${params.sliceId}/${params.taskId}: ${(gateErr as Error).message}`,
299
+ );
300
+ }
301
+
239
302
  // Invalidate all caches
240
303
  invalidateStateCache();
241
304
  clearPathCache();
@@ -8,6 +8,7 @@ import {
8
8
  _getAdapter,
9
9
  saveGateResult,
10
10
  } from "../gsd-db.js";
11
+ import { GATE_REGISTRY } from "../gate-registry.js";
11
12
  import { saveArtifactToDb } from "../db-writer.js";
12
13
  import type { CompleteMilestoneParams } from "./complete-milestone.js";
13
14
  import { handleCompleteMilestone } from "./complete-milestone.js";
@@ -427,7 +428,9 @@ export async function executeSaveGateResult(
427
428
  };
428
429
  }
429
430
 
430
- const validGates = ["Q3", "Q4", "Q5", "Q6", "Q7", "Q8"];
431
+ // Source of truth: gate-registry.ts. Every declared GateId is accepted,
432
+ // so adding a new gate in one place automatically flows through here.
433
+ const validGates = Object.keys(GATE_REGISTRY);
431
434
  if (!validGates.includes(params.gateId)) {
432
435
  return {
433
436
  content: [{ type: "text", text: `Error: Invalid gateId "${params.gateId}". Must be one of: ${validGates.join(", ")}` }],
@@ -536,6 +536,24 @@ export interface CompleteTaskParams {
536
536
  verdict: string;
537
537
  durationMs: number;
538
538
  }>;
539
+ /**
540
+ * Q5 failure-modes section content (what breaks when dependencies fail).
541
+ * Populated → `pass`; omitted/empty → `omitted`.
542
+ * @optional
543
+ */
544
+ failureModes?: string;
545
+ /**
546
+ * Q6 load-profile section content (10x breakpoint + protection).
547
+ * Populated → `pass`; omitted/empty → `omitted`.
548
+ * @optional
549
+ */
550
+ loadProfile?: string;
551
+ /**
552
+ * Q7 negative-tests section content (malformed inputs, error paths,
553
+ * boundaries). Populated → `pass`; omitted/empty → `omitted`.
554
+ * @optional
555
+ */
556
+ negativeTests?: string;
539
557
  /** Optional caller-provided identity for audit trail */
540
558
  actorName?: string;
541
559
  /** Optional caller-provided reason this action was triggered */
@@ -584,6 +602,14 @@ export interface CompleteSliceParams {
584
602
  affects?: string[];
585
603
  /** @optional — defaults to [] when omitted */
586
604
  drillDownPaths?: string[];
605
+ /**
606
+ * Q8 operational readiness section content (health signal, failure signal,
607
+ * recovery, monitoring gaps). When populated, the complete-slice handler
608
+ * records Q8 as `pass`; when omitted or empty, Q8 is recorded as `omitted`.
609
+ * See gate-registry.ts.
610
+ * @optional
611
+ */
612
+ operationalReadiness?: string;
587
613
  /** Optional caller-provided identity for audit trail */
588
614
  actorName?: string;
589
615
  /** Optional caller-provided reason this action was triggered */
@@ -57,7 +57,15 @@ async function probeAndRegister(pi: ExtensionAPI): Promise<boolean> {
57
57
  }
58
58
 
59
59
  const models = await discoverModels();
60
- if (models.length === 0) return true; // Running but no models pulled
60
+ if (models.length === 0) {
61
+ // No local models means there's nothing usable to register in GSD.
62
+ // Keep the footer/status clean instead of advertising Ollama availability.
63
+ if (providerRegistered) {
64
+ pi.unregisterProvider("ollama");
65
+ providerRegistered = false;
66
+ }
67
+ return false;
68
+ }
61
69
 
62
70
  const baseUrl = client.getOllamaHost();
63
71
 
@@ -115,9 +123,11 @@ export default function ollama(pi: ExtensionAPI) {
115
123
  } else {
116
124
  probeAndRegister(pi)
117
125
  .then((found) => {
118
- if (found) ctx.ui.setStatus("ollama", "Ollama");
126
+ ctx.ui.setStatus("ollama", found ? "Ollama" : undefined);
119
127
  })
120
- .catch(() => {});
128
+ .catch(() => {
129
+ ctx.ui.setStatus("ollama", undefined);
130
+ });
121
131
  }
122
132
  });
123
133
 
@@ -0,0 +1,28 @@
1
+ /**
2
+ * Regression test: don't show an Ollama footer status unless Ollama is
3
+ * actually usable (running with at least one discovered model).
4
+ */
5
+ import { test } from "node:test";
6
+ import assert from "node:assert/strict";
7
+ import { readFileSync } from "node:fs";
8
+ import { join, dirname } from "node:path";
9
+ import { fileURLToPath } from "node:url";
10
+
11
+ const __dirname = dirname(fileURLToPath(import.meta.url));
12
+ const src = readFileSync(join(__dirname, "index.ts"), "utf-8");
13
+
14
+ test("probeAndRegister returns false when no Ollama models are discovered", () => {
15
+ assert.match(
16
+ src,
17
+ /if \(models\.length === 0\)[\s\S]*return false;/,
18
+ "running-without-models should not be treated as available",
19
+ );
20
+ });
21
+
22
+ test("interactive session clears ollama footer status when unavailable", () => {
23
+ assert.match(
24
+ src,
25
+ /ctx\.ui\.setStatus\("ollama", found \? "Ollama" : undefined\)/,
26
+ "status should be cleared when probeAndRegister reports unavailable",
27
+ );
28
+ });
@@ -0,0 +1,42 @@
1
+ /**
2
+ * GSD Phase State — cross-extension coordination
3
+ * Copyright (c) 2026 Jeremy McSpadden <jeremy@fluxlabs.net>
4
+ *
5
+ * Lightweight module-level state that GSD auto-mode writes to and the
6
+ * subagent tool reads from. Both extensions run in the same process so
7
+ * a module variable is sufficient — no file I/O needed.
8
+ */
9
+
10
+ let _active = false;
11
+ let _currentPhase: string | null = null;
12
+
13
+ /** Mark GSD auto-mode as active. */
14
+ export function activateGSD(): void {
15
+ _active = true;
16
+ }
17
+
18
+ /** Mark GSD auto-mode as inactive and clear the current phase. */
19
+ export function deactivateGSD(): void {
20
+ _active = false;
21
+ _currentPhase = null;
22
+ }
23
+
24
+ /** Set the currently dispatched GSD phase (e.g. "plan-milestone"). */
25
+ export function setCurrentPhase(phase: string): void {
26
+ _currentPhase = phase;
27
+ }
28
+
29
+ /** Clear the current phase (unit completed or aborted). */
30
+ export function clearCurrentPhase(): void {
31
+ _currentPhase = null;
32
+ }
33
+
34
+ /** Returns true if GSD auto-mode is currently active. */
35
+ export function isGSDActive(): boolean {
36
+ return _active;
37
+ }
38
+
39
+ /** Returns the current GSD phase, or null if none is active. */
40
+ export function getCurrentPhase(): string | null {
41
+ return _active ? _currentPhase : null;
42
+ }
@@ -0,0 +1,48 @@
1
+ import { describe, it, beforeEach } from "node:test";
2
+ import assert from "node:assert/strict";
3
+ import {
4
+ activateGSD,
5
+ deactivateGSD,
6
+ setCurrentPhase,
7
+ clearCurrentPhase,
8
+ isGSDActive,
9
+ getCurrentPhase,
10
+ } from "../gsd-phase-state.js";
11
+
12
+ describe("gsd-phase-state", () => {
13
+ beforeEach(() => {
14
+ deactivateGSD();
15
+ });
16
+
17
+ it("tracks active/inactive state", () => {
18
+ assert.equal(isGSDActive(), false);
19
+ activateGSD();
20
+ assert.equal(isGSDActive(), true);
21
+ deactivateGSD();
22
+ assert.equal(isGSDActive(), false);
23
+ });
24
+
25
+ it("tracks the current phase when active", () => {
26
+ activateGSD();
27
+ assert.equal(getCurrentPhase(), null);
28
+ setCurrentPhase("plan-milestone");
29
+ assert.equal(getCurrentPhase(), "plan-milestone");
30
+ clearCurrentPhase();
31
+ assert.equal(getCurrentPhase(), null);
32
+ });
33
+
34
+ it("returns null phase when inactive even if phase was set", () => {
35
+ activateGSD();
36
+ setCurrentPhase("plan-milestone");
37
+ deactivateGSD();
38
+ assert.equal(getCurrentPhase(), null);
39
+ });
40
+
41
+ it("deactivation clears the current phase", () => {
42
+ activateGSD();
43
+ setCurrentPhase("execute-task");
44
+ deactivateGSD();
45
+ activateGSD();
46
+ assert.equal(getCurrentPhase(), null);
47
+ });
48
+ });
@@ -15,6 +15,7 @@ export interface AgentConfig {
15
15
  description: string;
16
16
  tools?: string[];
17
17
  model?: string;
18
+ conflictsWith?: string[];
18
19
  systemPrompt: string;
19
20
  source: "user" | "project";
20
21
  filePath: string;
@@ -30,6 +31,13 @@ interface AgentFrontmatter extends Record<string, unknown> {
30
31
  description?: string;
31
32
  tools?: string | string[];
32
33
  model?: string;
34
+ conflicts_with?: string;
35
+ }
36
+
37
+ export function parseConflictsWith(value: string | undefined): string[] | undefined {
38
+ if (typeof value !== "string") return undefined;
39
+ const conflicts = value.split(",").map((s) => s.trim()).filter(Boolean);
40
+ return conflicts.length > 0 ? conflicts : undefined;
33
41
  }
34
42
 
35
43
  function parseAgentTools(value: string | string[] | undefined): string[] | undefined {
@@ -85,12 +93,14 @@ function loadAgentsFromDir(dir: string, source: "user" | "project"): AgentConfig
85
93
  }
86
94
 
87
95
  const tools = parseAgentTools(frontmatter.tools);
96
+ const conflictsWith = parseConflictsWith(frontmatter.conflicts_with);
88
97
 
89
98
  agents.push({
90
99
  name: frontmatter.name,
91
100
  description: frontmatter.description,
92
101
  tools: tools && tools.length > 0 ? tools : undefined,
93
102
  model: frontmatter.model,
103
+ conflictsWith,
94
104
  systemPrompt: body,
95
105
  source,
96
106
  filePath,