gsd-pi 2.70.1 → 2.71.0-dev.4c35d99

package/src/resources/extensions/gsd/workflow-mcp.ts

@@ -379,7 +379,7 @@ export function getWorkflowTransportSupportError(
   const providerLabel = `"${provider}"`;
 
   if (!launch) {
-    return `Provider ${providerLabel} cannot run ${surface}${unitLabel}: the GSD workflow MCP server is not configured or discoverable. Configure GSD_WORKFLOW_MCP_COMMAND, build packages/mcp-server/dist/cli.js, or install gsd-mcp-server on PATH.`;
+    return `Provider ${providerLabel} cannot run ${surface}${unitLabel}: the GSD workflow MCP server is not configured or discoverable. Detected Claude Code model but no workflow MCP. Please run /gsd mcp init . from your project root. You can also configure GSD_WORKFLOW_MCP_COMMAND, build packages/mcp-server/dist/cli.js, or install gsd-mcp-server on PATH.`;
   }
 
   const missing = [...new Set(requiredTools)].filter((tool) => !MCP_WORKFLOW_TOOL_SURFACE.has(tool));

package/src/resources/extensions/ollama/index.ts

@@ -57,7 +57,15 @@ async function probeAndRegister(pi: ExtensionAPI): Promise<boolean> {
 	}
 
 	const models = await discoverModels();
-	if (models.length === 0) return true; // Running but no models pulled
+	if (models.length === 0) {
+		// No local models means there's nothing usable to register in GSD.
+		// Keep the footer/status clean instead of advertising Ollama availability.
+		if (providerRegistered) {
+			pi.unregisterProvider("ollama");
+			providerRegistered = false;
+		}
+		return false;
+	}
 
 	const baseUrl = client.getOllamaHost();
 
@@ -115,9 +123,11 @@ export default function ollama(pi: ExtensionAPI) {
 		} else {
 			probeAndRegister(pi)
 				.then((found) => {
-					if (found) ctx.ui.setStatus("ollama", "Ollama");
+					ctx.ui.setStatus("ollama", found ? "Ollama" : undefined);
 				})
-				.catch(() => {});
+				.catch(() => {
+					ctx.ui.setStatus("ollama", undefined);
+				});
 		}
 	});
 

package/src/resources/extensions/ollama/ollama-status-indicator.test.ts

@@ -0,0 +1,28 @@
+/**
+ * Regression test: don't show an Ollama footer status unless Ollama is
+ * actually usable (running with at least one discovered model).
+ */
+import { test } from "node:test";
+import assert from "node:assert/strict";
+import { readFileSync } from "node:fs";
+import { join, dirname } from "node:path";
+import { fileURLToPath } from "node:url";
+
+const __dirname = dirname(fileURLToPath(import.meta.url));
+const src = readFileSync(join(__dirname, "index.ts"), "utf-8");
+
+test("probeAndRegister returns false when no Ollama models are discovered", () => {
+	assert.match(
+		src,
+		/if \(models\.length === 0\)[\s\S]*return false;/,
+		"running-without-models should not be treated as available",
+	);
+});
+
+test("interactive session clears ollama footer status when unavailable", () => {
+	assert.match(
+		src,
+		/ctx\.ui\.setStatus\("ollama", found \? "Ollama" : undefined\)/,
+		"status should be cleared when probeAndRegister reports unavailable",
+	);
+});

package/src/resources/extensions/shared/gsd-phase-state.ts

@@ -0,0 +1,42 @@
+/**
+ * GSD Phase State — cross-extension coordination
+ * Copyright (c) 2026 Jeremy McSpadden <jeremy@fluxlabs.net>
+ *
+ * Lightweight module-level state that GSD auto-mode writes to and the
+ * subagent tool reads from. Both extensions run in the same process so
+ * a module variable is sufficient — no file I/O needed.
+ */
+
+let _active = false;
+let _currentPhase: string | null = null;
+
+/** Mark GSD auto-mode as active. */
+export function activateGSD(): void {
+	_active = true;
+}
+
+/** Mark GSD auto-mode as inactive and clear the current phase. */
+export function deactivateGSD(): void {
+	_active = false;
+	_currentPhase = null;
+}
+
+/** Set the currently dispatched GSD phase (e.g. "plan-milestone"). */
+export function setCurrentPhase(phase: string): void {
+	_currentPhase = phase;
+}
+
+/** Clear the current phase (unit completed or aborted). */
+export function clearCurrentPhase(): void {
+	_currentPhase = null;
+}
+
+/** Returns true if GSD auto-mode is currently active. */
+export function isGSDActive(): boolean {
+	return _active;
+}
+
+/** Returns the current GSD phase, or null if none is active. */
+export function getCurrentPhase(): string | null {
+	return _active ? _currentPhase : null;
+}

package/src/resources/extensions/shared/tests/gsd-phase-state.test.ts

@@ -0,0 +1,48 @@
+import { describe, it, beforeEach } from "node:test";
+import assert from "node:assert/strict";
+import {
+	activateGSD,
+	deactivateGSD,
+	setCurrentPhase,
+	clearCurrentPhase,
+	isGSDActive,
+	getCurrentPhase,
+} from "../gsd-phase-state.js";
+
+describe("gsd-phase-state", () => {
+	beforeEach(() => {
+		deactivateGSD();
+	});
+
+	it("tracks active/inactive state", () => {
+		assert.equal(isGSDActive(), false);
+		activateGSD();
+		assert.equal(isGSDActive(), true);
+		deactivateGSD();
+		assert.equal(isGSDActive(), false);
+	});
+
+	it("tracks the current phase when active", () => {
+		activateGSD();
+		assert.equal(getCurrentPhase(), null);
+		setCurrentPhase("plan-milestone");
+		assert.equal(getCurrentPhase(), "plan-milestone");
+		clearCurrentPhase();
+		assert.equal(getCurrentPhase(), null);
+	});
+
+	it("returns null phase when inactive even if phase was set", () => {
+		activateGSD();
+		setCurrentPhase("plan-milestone");
+		deactivateGSD();
+		assert.equal(getCurrentPhase(), null);
+	});
+
+	it("deactivation clears the current phase", () => {
+		activateGSD();
+		setCurrentPhase("execute-task");
+		deactivateGSD();
+		activateGSD();
+		assert.equal(getCurrentPhase(), null);
+	});
+});

package/src/resources/extensions/subagent/agents.ts

@@ -15,6 +15,7 @@ export interface AgentConfig {
 	description: string;
 	tools?: string[];
 	model?: string;
+	conflictsWith?: string[];
 	systemPrompt: string;
 	source: "user" | "project";
 	filePath: string;
@@ -30,6 +31,13 @@ interface AgentFrontmatter extends Record<string, unknown> {
 	description?: string;
 	tools?: string | string[];
 	model?: string;
+	conflicts_with?: string;
+}
+
+export function parseConflictsWith(value: string | undefined): string[] | undefined {
+	if (typeof value !== "string") return undefined;
+	const conflicts = value.split(",").map((s) => s.trim()).filter(Boolean);
+	return conflicts.length > 0 ? conflicts : undefined;
 }
 
 function parseAgentTools(value: string | string[] | undefined): string[] | undefined {
@@ -85,12 +93,14 @@ function loadAgentsFromDir(dir: string, source: "user" | "project"): AgentConfig
 		}
 
 		const tools = parseAgentTools(frontmatter.tools);
+		const conflictsWith = parseConflictsWith(frontmatter.conflicts_with);
 
 		agents.push({
 			name: frontmatter.name,
 			description: frontmatter.description,
 			tools: tools && tools.length > 0 ? tools : undefined,
 			model: frontmatter.model,
+			conflictsWith,
 			systemPrompt: body,
 			source,
 			filePath,

package/src/resources/extensions/subagent/index.ts

@@ -24,6 +24,7 @@ import { type ExtensionAPI, getMarkdownTheme } from "@gsd/pi-coding-agent";
 import { Container, Markdown, Spacer, Text } from "@gsd/pi-tui";
 import { Type } from "@sinclair/typebox";
 import { formatTokenCount } from "../shared/mod.js";
+import { getCurrentPhase } from "../shared/gsd-phase-state.js";
 import { type AgentConfig, type AgentScope, discoverAgents } from "./agents.js";
 import {
 	type IsolationEnvironment,
@@ -352,6 +353,23 @@ async function runSingleAgent(
 		};
 	}
 
+	// GSD phase guard: block agents that conflict with the active GSD phase
+	if (agent.conflictsWith && agent.conflictsWith.length > 0) {
+		const activePhase = getCurrentPhase();
+		if (activePhase && agent.conflictsWith.includes(activePhase)) {
+			return {
+				agent: agentName,
+				agentSource: agent.source,
+				task,
+				exitCode: 1,
+				messages: [],
+				stderr: `Agent "${agentName}" is blocked: it conflicts with the active GSD phase "${activePhase}". Use the built-in GSD workflow instead.`,
+				usage: { input: 0, output: 0, cacheRead: 0, cacheWrite: 0, cost: 0, contextTokens: 0, turns: 0 },
+				step,
+			};
+		}
+	}
+
 	let tmpPromptDir: string | null = null;
 	let tmpPromptPath: string | null = null;
 

package/src/resources/extensions/subagent/tests/agents-conflicts.test.ts

@@ -0,0 +1,33 @@
+import { describe, it } from "node:test";
+import assert from "node:assert/strict";
+import { parseConflictsWith } from "../agents.js";
+
+describe("parseConflictsWith", () => {
+	it("parses comma-separated conflict list", () => {
+		const result = parseConflictsWith("plan-milestone, plan-slice, research-milestone");
+		assert.deepEqual(result, ["plan-milestone", "plan-slice", "research-milestone"]);
+	});
+
+	it("returns undefined for undefined input", () => {
+		assert.equal(parseConflictsWith(undefined), undefined);
+	});
+
+	it("returns undefined for empty string", () => {
+		assert.equal(parseConflictsWith(""), undefined);
+	});
+
+	it("handles single value without commas", () => {
+		const result = parseConflictsWith("plan-milestone");
+		assert.deepEqual(result, ["plan-milestone"]);
+	});
+
+	it("trims whitespace from values", () => {
+		const result = parseConflictsWith("  plan-milestone ,  plan-slice  ");
+		assert.deepEqual(result, ["plan-milestone", "plan-slice"]);
+	});
+
+	it("filters out empty entries from trailing commas", () => {
+		const result = parseConflictsWith("plan-milestone,,plan-slice,");
+		assert.deepEqual(result, ["plan-milestone", "plan-slice"]);
+	});
+});

package/src/resources/skills/create-skill/SKILL.md

@@ -78,6 +78,8 @@ Based on the user's message, route directly to the appropriate workflow:
 **If user intent is unclear, ask minimal clarifying questions:**
 - "Create a MIDI skill" → "Task-execution skill (does MIDI tasks) or domain expertise (complete MIDI knowledge base)?"
 - "Work on my skill" → "Which skill? What do you want to do with it?"
+- Ask one clarifying question round at a time, then wait for the user's actual response before asking another.
+- Never fabricate or simulate user responses while clarifying (for example, fake `[User]` markers or imagined answers).
 
 Then proceed directly to the workflow.
 </routing>