gsd-pi 2.68.1-dev.362687a → 2.68.1-dev.abc8f2b

package/src/resources/extensions/gsd/tests/adversarial-review-fixes.test.ts

@@ -1,223 +0,0 @@
-/**
- * Tests for adversarial review fixes from PR #3602.
- *
- * These tests verify the fixes for:
- * 1. Cross-session state leak in lastPreparationResult (HIGH)
- * 2. Invalid regex anchor \z in prompt-validation.ts (HIGH)
- * 3. Consecutive error counter in agent-loop.ts (MEDIUM) — UPSTREAM CODE, NOT MODIFIED
- */
-
-import { describe, test, beforeEach, afterEach } from "node:test";
-import assert from "node:assert/strict";
-import { mkdirSync, writeFileSync, rmSync } from "node:fs";
-import { join } from "node:path";
-import { tmpdir } from "node:os";
-
-import { getLastPreparationResult, clearPreparationResult } from "../guided-flow.ts";
-import { validateEnhancedContext } from "../prompt-validation.ts";
-
-// ─── Test Helpers ───────────────────────────────────────────────────────────────
-
-function makeTempDir(prefix: string): string {
-  const dir = join(
-    tmpdir(),
-    `gsd-adversarial-test-${prefix}-${Date.now()}-${Math.random().toString(36).slice(2, 8)}`,
-  );
-  mkdirSync(dir, { recursive: true });
-  return dir;
-}
-
-function cleanup(dir: string): void {
-  try {
-    rmSync(dir, { recursive: true, force: true });
-  } catch {
-    // best-effort
-  }
-}
-
-// ─── Fix 1: Cross-session state leak in lastPreparationResult ────────────────────
-
-describe("Fix #1 — Cross-session state leak (lastPreparationResult)", () => {
-  beforeEach(() => {
-    clearPreparationResult();
-  });
-
-  afterEach(() => {
-    clearPreparationResult();
-  });
-
-  test("clearPreparationResult sets lastPreparationResult to null", () => {
-    // First, verify the getter returns null after clear
-    clearPreparationResult();
-    const result = getLastPreparationResult();
-    assert.equal(result, null, "lastPreparationResult should be null after clear");
-  });
-
-  test("getLastPreparationResult returns null initially", () => {
-    clearPreparationResult();
-    const result = getLastPreparationResult();
-    assert.equal(result, null, "should return null when no preparation has run");
-  });
-
-  // Note: The actual test that prepareAndBuildDiscussPrompt clears the result
-  // on entry requires mocking ExtensionCommandContext which is complex.
-  // The fix is verified by code inspection and integration tests.
-  // The key behavior is:
-  // 1. lastPreparationResult = null at the start of prepareAndBuildDiscussPrompt
-  // 2. If preparation throws, lastPreparationResult stays null
-  // 3. If discuss_preparation is false, lastPreparationResult stays null
-});
-
-// ─── Fix 2: Invalid regex anchor \z in prompt-validation.ts ──────────────────────
-
-describe("Fix #2 — Invalid regex anchor (prompt-validation.ts)", () => {
-  test("validates content with Architectural Decisions at end of file", () => {
-    // This was the bug: \z is PCRE/Ruby, not JS. JS treated it as literal 'z'.
-    // The section extraction would fail when Architectural Decisions was the
-    // last section (no subsequent ## heading).
-    const contentWithDecisionsAtEnd = `
-# M001: Test Milestone
-
-## Why This Milestone
-
-This is why.
-
-## Acceptance Criteria
-
-- Criterion 1
-
-## Architectural Decisions
-
-### Decision 1
-
-**Decision:** Use TypeScript
-**Rationale:** Type safety
-`;
-
-    const result = validateEnhancedContext(contentWithDecisionsAtEnd);
-    assert.equal(result.valid, true, "should validate content with decisions at end");
-    assert.equal(result.missing.length, 0, "should have no missing sections");
-  });
-
-  test("validates content with Architectural Decisions followed by another section", () => {
-    const contentWithDecisionsInMiddle = `
-# M001: Test Milestone
-
-## Why This Milestone
-
-This is why.
-
-## Architectural Decisions
-
-### Decision 1
-
-**Decision:** Use TypeScript
-
-## Acceptance Criteria
-
-- Criterion 1
-`;
-
-    const result = validateEnhancedContext(contentWithDecisionsInMiddle);
-    assert.equal(result.valid, true, "should validate content with decisions in middle");
-  });
-
-  test("detects missing decision entry when section is empty", () => {
-    const contentEmptyDecisions = `
-# M001: Test Milestone
-
-## Why This Milestone
-
-This is why.
-
-## Architectural Decisions
-
-(No decisions yet)
-
-## Acceptance Criteria
-
-- Criterion 1
-`;
-
-    const result = validateEnhancedContext(contentEmptyDecisions);
-    assert.equal(result.valid, false, "should fail when decisions section has no entries");
-    assert.ok(
-      result.missing.some((m) => m.includes("decision entry")),
-      "should report missing decision entry",
-    );
-  });
-
-  test("accepts inline **Decision format", () => {
-    const contentInlineDecision = `
-## Why This Milestone
-
-Test
-
-## Architectural Decisions
-
-**Decision:** Use React
-
-## Acceptance Criteria
-
-- Criterion 1
-`;
-
-    const result = validateEnhancedContext(contentInlineDecision);
-    assert.equal(result.valid, true, "should accept **Decision format");
-  });
-
-  test("accepts ### subsection format", () => {
-    const contentSubsectionDecision = `
-## Why This Milestone
-
-Test
-
-## Architectural Decisions
-
-### Database Choice
-
-We chose SQLite.
-
-## Acceptance Criteria
-
-- Criterion 1
-`;
-
-    const result = validateEnhancedContext(contentSubsectionDecision);
-    assert.equal(result.valid, true, "should accept ### subsection format");
-  });
-
-  test("handles edge case: Architectural Decisions heading without space before content", () => {
-    const contentNoSpace = `## Why This Milestone
-Test
-## Architectural Decisions
-### Decision 1
-Content here
-## Acceptance Criteria
-- Done`;
-
-    const result = validateEnhancedContext(contentNoSpace);
-    assert.equal(result.valid, true, "should handle content without extra spacing");
-  });
-});
-
-// ─── Fix 3: Consecutive error counter (agent-loop.ts) ────────────────────────────
-
-describe("Fix #3 — Consecutive error counter (UPSTREAM)", () => {
-  test("NOTE: agent-loop.ts is upstream code that was not modified", () => {
-    // This finding from the adversarial review relates to upstream behavior
-    // in packages/pi-agent-core/src/agent-loop.ts.
-    //
-    // The consecutiveAllToolErrorTurns counter logic was added in PR #3301
-    // and refined in PR #3618 by upstream contributors. These PRs fix
-    // issues with:
-    // - Schema overload detection counting bash exit codes as failures
-    // - The counter not resetting properly on successful turns
-    //
-    // Since this is upstream code (part of pi-agent-core, not gsd extension),
-    // we do not modify it here. The fix should be coordinated with upstream.
-    //
-    // See: packages/pi-agent-core/src/agent-loop.ts lines 191, 298-325
-    assert.ok(true, "Documented as upstream behavior — no changes made");
-  });
-});

package/src/resources/extensions/gsd/tests/integration/test-isolation.ts

@@ -1,53 +0,0 @@
-/**
- * Test isolation utilities for integration tests.
- *
- * Integration tests often call `mergeMilestoneToMain` and other functions that
- * load preferences. If the user's global ~/.gsd/preferences.md has
- * `git.main_branch: master`, tests fail because test repos use `main`.
- *
- * These utilities isolate tests from the user's global environment.
- */
-
-import { mkdtempSync, rmSync, realpathSync } from "node:fs";
-import { tmpdir } from "node:os";
-import { join } from "node:path";
-
-import { _resetServiceCache } from "../../worktree.ts";
-import { _clearGsdRootCache } from "../../paths.ts";
-
-let originalHome: string | undefined;
-let fakeHome: string | null = null;
-
-/**
- * Isolate the test environment from user's global preferences.
- * Creates a fake HOME directory so loadEffectiveGSDPreferences() returns
- * empty global preferences instead of the user's ~/.gsd/preferences.md.
- *
- * Call this in a test.before() hook.
- */
-export function isolateFromGlobalPreferences(): void {
-  originalHome = process.env.HOME;
-  fakeHome = realpathSync(mkdtempSync(join(tmpdir(), "gsd-test-home-")));
-  process.env.HOME = fakeHome;
-  _clearGsdRootCache();
-  _resetServiceCache();
-}
-
-/**
- * Restore the original HOME and clean up the fake home directory.
- *
- * Call this in a test.after() hook.
- */
-export function restoreGlobalPreferences(): void {
-  if (originalHome !== undefined) {
-    process.env.HOME = originalHome;
-  } else {
-    delete process.env.HOME;
-  }
-  _clearGsdRootCache();
-  _resetServiceCache();
-  if (fakeHome) {
-    rmSync(fakeHome, { recursive: true, force: true });
-    fakeHome = null;
-  }
-}