gsd-pi 2.65.0 → 2.66.0

package/dist/resources/extensions/gsd/notification-overlay.js

@@ -1,6 +1,6 @@
 // GSD Extension — Notification History Overlay
 // Scrollable panel showing all persisted notifications with severity filtering.
-// Toggled with Ctrl+Alt+N or opened from /gsd notifications.
+// Toggled with Ctrl+Alt+N (⌃⌥N on macOS) or opened from /gsd notifications.
 import { truncateToWidth, visibleWidth, matchesKey, Key } from "@gsd/pi-tui";
 import { readNotifications, markAllRead, clearNotifications, } from "./notification-store.js";
 import { padRight, joinColumns } from "../shared/mod.js";

package/dist/resources/extensions/gsd/notification-widget.js

@@ -3,6 +3,7 @@
 // the most recent notification message. Refreshes every 5 seconds.
 // Widget key: "gsd-notifications", placement: "belowEditor"
 import { getUnreadCount, readNotifications } from "./notification-store.js";
+import { formatShortcut } from "./files.js";
 // ─── Pure rendering ──���────────────────────────���─────────────────────────
 export function buildNotificationWidgetLines() {
     const unread = getUnreadCount();
@@ -18,7 +19,7 @@ export function buildNotificationWidgetLines() {
     const truncated = latest.message.length > msgMax
         ? latest.message.slice(0, msgMax - 1) + "…"
         : latest.message;
-    return [`  ${icon} [${badge}]  ${truncated}  (Ctrl+Alt+N to view)`];
+    return [`  ${icon} [${badge}]  ${truncated}  (${formatShortcut("Ctrl+Alt+N")} to view)`];
 }
 // ─── Widget init ────────────────────────────────────────────────────────
 const REFRESH_INTERVAL_MS = 5_000;

package/dist/resources/extensions/gsd/parallel-monitor-overlay.js

@@ -2,7 +2,7 @@
  * GSD Parallel Monitor Overlay
  *
  * Full-screen TUI overlay showing real-time parallel worker progress.
- * Opened via `/gsd parallel watch` or Ctrl+Alt+P.
+ * Opened via `/gsd parallel watch` or Ctrl+Alt+P (⌃⌥P on macOS).
  * Reads the same data sources as `scripts/parallel-monitor.mjs` but
  * renders as a native pi-tui overlay with theme integration.
  */

package/dist/resources/extensions/gsd/parallel-orchestrator.js

@@ -440,19 +440,25 @@ export function spawnWorker(basePath, milestoneId) {
         return false;
     let child;
     try {
+        const workerEnv = {
+            ...process.env,
+            GSD_MILESTONE_LOCK: milestoneId,
+            // Pass the real project root so workers don't need to re-derive it.
+            // Without this, process.cwd() resolves symlinks and the worktree
+            // path heuristic can match the user-level ~/.gsd instead of the
+            // project .gsd, causing writes to ~ and corrupting user config.
+            GSD_PROJECT_ROOT: basePath,
+            // Prevent workers from spawning their own parallel sessions
+            GSD_PARALLEL_WORKER: "1",
+        };
+        // Apply worker model override if configured, so workers use a cheaper
+        // model (e.g. Haiku) rather than inheriting the coordinator's model.
+        if (state.config.worker_model) {
+            workerEnv.GSD_WORKER_MODEL = state.config.worker_model;
+        }
         child = spawn(process.execPath, [binPath, "headless", "--json", "auto"], {
             cwd: worker.worktreePath,
-            env: {
-                ...process.env,
-                GSD_MILESTONE_LOCK: milestoneId,
-                // Pass the real project root so workers don't need to re-derive it.
-                // Without this, process.cwd() resolves symlinks and the worktree
-                // path heuristic can match the user-level ~/.gsd instead of the
-                // project .gsd, causing writes to ~ and corrupting user config.
-                GSD_PROJECT_ROOT: basePath,
-                // Prevent workers from spawning their own parallel sessions
-                GSD_PARALLEL_WORKER: "1",
-            },
+            env: workerEnv,
             stdio: ["ignore", "pipe", "pipe"],
             detached: false,
         });

package/dist/resources/extensions/gsd/pre-execution-checks.js

@@ -197,8 +197,9 @@ export async function checkPackageExistence(tasks, _basePath) {
 export function normalizeFilePath(filePath) {
     if (!filePath)
         return filePath;
+    let normalized = extractPathFromAnnotation(filePath);
     // Normalize path separators to forward slashes
-    let normalized = filePath.replace(/\\/g, "/");
+    normalized = normalized.replace(/\\/g, "/");
     // Remove leading ./
     while (normalized.startsWith("./")) {
         normalized = normalized.slice(2);
@@ -211,6 +212,21 @@ export function normalizeFilePath(filePath) {
     }
     return normalized;
 }
+function extractPathFromAnnotation(raw) {
+    const trimmed = raw.trim();
+    if (!trimmed)
+        return trimmed;
+    const backtickMatch = trimmed.match(/^`([^`]+)`(?:\s+[—–-]\s+.*)?$/);
+    if (backtickMatch) {
+        return backtickMatch[1].trim();
+    }
+    const annotatedMatch = trimmed.match(/^(.+?)\s+[—–-]\s+.+$/);
+    if (annotatedMatch) {
+        return annotatedMatch[1].trim();
+    }
+    // Fall back to the original behavior for already-plain paths.
+    return trimmed.replace(/`/g, "");
+}
 /**
  * Build a set of files that will be created by tasks up to (but not including) taskIndex.
  * All paths are normalized for consistent comparison.
@@ -225,10 +241,13 @@ function getExpectedOutputsUpTo(tasks, taskIndex) {
     return outputs;
 }
 /**
- * Check that all files referenced in task.files and task.inputs either:
+ * Check that all files referenced in task.inputs either:
  *   1. Exist on disk, OR
  *   2. Are in a prior task's expected_output
  *
+ * task.files ("files likely touched") is excluded — it intentionally includes
+ * files the task will create, so they don't need to pre-exist (#3626).
+ *
  * All paths are normalized before comparison to ensure ./src/a.ts matches src/a.ts.
  */
 export function checkFilePathConsistency(tasks, basePath) {
@@ -236,7 +255,7 @@ export function checkFilePathConsistency(tasks, basePath) {
     for (let i = 0; i < tasks.length; i++) {
         const task = tasks[i];
         const priorOutputs = getExpectedOutputsUpTo(tasks, i);
-        const filesToCheck = [...task.files, ...task.inputs];
+        const filesToCheck = [...task.inputs];
         for (const file of filesToCheck) {
             // Skip empty strings
             if (!file.trim())
@@ -281,10 +300,12 @@ export function checkTaskOrdering(tasks, _basePath) {
             }
         }
     }
-    // Check each task's inputs against file creators
+    // Check each task's inputs against file creators.
+    // Only check task.inputs — task.files ("files likely touched") intentionally
+    // includes files the task will create, so they don't indicate read-before-create (#3677).
     for (let i = 0; i < tasks.length; i++) {
         const task = tasks[i];
-        const filesToCheck = [...task.files, ...task.inputs];
+        const filesToCheck = [...task.inputs];
         for (const file of filesToCheck) {
             const normalizedFile = normalizeFilePath(file);
             const creator = fileCreators.get(normalizedFile);

package/dist/resources/extensions/gsd/preferences-types.js

@@ -80,6 +80,9 @@ export const KNOWN_PREFERENCE_KEYS = new Set([
     "enhanced_verification_pre",
     "enhanced_verification_post",
     "enhanced_verification_strict",
+    "discuss_preparation",
+    "discuss_web_research",
+    "discuss_depth",
 ]);
 /** Canonical list of all dispatch unit types. */
 export const KNOWN_UNIT_TYPES = [

package/dist/resources/extensions/gsd/preferences-validation.js

@@ -542,6 +542,14 @@ export function validatePreferences(preferences) {
                 errors.push("parallel.auto_merge must be one of: auto, confirm, manual");
             }
         }
+        if (p.worker_model !== undefined) {
+            if (typeof p.worker_model === "string" && p.worker_model.length > 0) {
+                parallel.worker_model = p.worker_model;
+            }
+            else {
+                errors.push("parallel.worker_model must be a non-empty string");
+            }
+        }
         if (Object.keys(parallel).length > 0) {
             validated.parallel = parallel;
         }
@@ -574,7 +582,15 @@ export function validatePreferences(preferences) {
                     errors.push('reactive_execution.isolation_mode must be "same-tree"');
                 }
             }
-            const knownReKeys = new Set(["enabled", "max_parallel", "isolation_mode"]);
+            if (re.subagent_model !== undefined) {
+                if (typeof re.subagent_model === "string" && re.subagent_model.length > 0) {
+                    validRe.subagent_model = re.subagent_model;
+                }
+                else {
+                    errors.push("reactive_execution.subagent_model must be a non-empty string");
+                }
+            }
+            const knownReKeys = new Set(["enabled", "max_parallel", "isolation_mode", "subagent_model"]);
             for (const key of Object.keys(re)) {
                 if (!knownReKeys.has(key)) {
                     warnings.push(`unknown reactive_execution key "${key}" — ignored`);
@@ -972,5 +988,33 @@ export function validatePreferences(preferences) {
             errors.push("enhanced_verification_strict must be a boolean");
         }
     }
+    // ─── Discuss Preparation ────────────────────────────────────────────
+    if (preferences.discuss_preparation !== undefined) {
+        if (typeof preferences.discuss_preparation === "boolean") {
+            validated.discuss_preparation = preferences.discuss_preparation;
+        }
+        else {
+            errors.push("discuss_preparation must be a boolean");
+        }
+    }
+    // ─── Discuss Web Research ───────────────────────────────────────────
+    if (preferences.discuss_web_research !== undefined) {
+        if (typeof preferences.discuss_web_research === "boolean") {
+            validated.discuss_web_research = preferences.discuss_web_research;
+        }
+        else {
+            errors.push("discuss_web_research must be a boolean");
+        }
+    }
+    // ─── Discuss Depth ──────────────────────────────────────────────────
+    if (preferences.discuss_depth !== undefined) {
+        const validDepths = new Set(["quick", "standard", "thorough"]);
+        if (typeof preferences.discuss_depth === "string" && validDepths.has(preferences.discuss_depth)) {
+            validated.discuss_depth = preferences.discuss_depth;
+        }
+        else {
+            errors.push(`discuss_depth must be one of: quick, standard, thorough`);
+        }
+    }
     return { preferences: validated, errors, warnings };
 }

package/dist/resources/extensions/gsd/preferences.js

@@ -127,9 +127,10 @@ function loadPreferencesFile(path, scope) {
     };
 }
 let _warnedUnrecognizedFormat = false;
-/** @internal Reset the warn-once flag — exported for testing only. */
+/** @internal Reset the warn-once flags — exported for testing only. */
 export function _resetParseWarningFlag() {
     _warnedUnrecognizedFormat = false;
+    _warnedFrontmatterParse = false;
 }
 /** @internal Exported for testing only */
 export function parsePreferencesMarkdown(content) {
@@ -156,6 +157,7 @@ export function parsePreferencesMarkdown(content) {
     }
     return null;
 }
+let _warnedFrontmatterParse = false;
 function parseFrontmatterBlock(frontmatter) {
     try {
         const parsed = parseYaml(frontmatter);
@@ -165,7 +167,11 @@ function parseFrontmatterBlock(frontmatter) {
         return parsed;
     }
     catch (e) {
-        logWarning("guided", `YAML parse error in frontmatter block: ${e.message}`);
+        // Warn at most once per session to avoid flooding TUI (#3376)
+        if (!_warnedFrontmatterParse) {
+            _warnedFrontmatterParse = true;
+            logWarning("guided", `YAML parse error in preferences frontmatter (suppressing further): ${e.message}`);
+        }
         return {};
     }
 }
@@ -449,5 +455,6 @@ export function resolveParallelConfig(prefs) {
         budget_ceiling: prefs?.parallel?.budget_ceiling,
         merge_strategy: prefs?.parallel?.merge_strategy ?? "per-milestone",
         auto_merge: prefs?.parallel?.auto_merge ?? "confirm",
+        worker_model: prefs?.parallel?.worker_model,
     };
 }