gsd-pi 2.65.0-dev.5c8557b → 2.65.0-dev.d0517ff

package/src/resources/extensions/gsd/tests/project-root-cwd-crash.test.ts

@@ -0,0 +1,53 @@
+/**
+ * Regression test for #3598 — projectRoot ENOENT crash on deleted cwd
+ *
+ * When the working directory is deleted (e.g. worktree teardown), process.cwd()
+ * throws ENOENT. The fix wraps process.cwd() in a try/catch and falls back to
+ * process.env.HOME.
+ *
+ * Also verifies #3589 — nativeBranchExists validation for prefs.main_branch
+ * in auto-worktree.ts to prevent merge failures with stale preferences.
+ *
+ * Structural verification test — reads source to confirm the guards exist.
+ */
+
+import { describe, test } from 'node:test';
+import assert from 'node:assert/strict';
+import { readFileSync } from 'node:fs';
+import { fileURLToPath } from 'node:url';
+import { dirname, join } from 'node:path';
+
+const __filename = fileURLToPath(import.meta.url);
+const __dirname = dirname(__filename);
+
+const contextSource = readFileSync(join(__dirname, '..', 'commands', 'context.ts'), 'utf-8');
+const worktreeSource = readFileSync(join(__dirname, '..', 'auto-worktree.ts'), 'utf-8');
+
+describe('projectRoot cwd crash guard (#3598)', () => {
+  test('projectRoot wraps process.cwd() in try/catch', () => {
+    assert.match(contextSource, /try\s*\{[\s\S]*?process\.cwd\(\)/,
+      'process.cwd() should be inside a try block');
+  });
+
+  test('catch block falls back to process.env.HOME', () => {
+    assert.match(contextSource, /catch[\s\S]*?process\.env\.HOME/,
+      'catch block should fall back to process.env.HOME');
+  });
+
+  test('projectRoot function is exported', () => {
+    assert.match(contextSource, /export function projectRoot\(\)/,
+      'projectRoot should be an exported function');
+  });
+});
+
+describe('main_branch nativeBranchExists validation (#3589)', () => {
+  test('prefs.main_branch is validated with nativeBranchExists', () => {
+    assert.match(worktreeSource, /nativeBranchExists\(.*prefs\.main_branch\)/,
+      'nativeBranchExists should validate prefs.main_branch');
+  });
+
+  test('validatedPrefBranch falls back to undefined when branch missing', () => {
+    assert.match(worktreeSource, /validatedPrefBranch[\s\S]*?:\s*undefined/,
+      'validatedPrefBranch should fall back to undefined');
+  });
+});

package/src/resources/extensions/gsd/tests/projection-no-plan-overwrite.test.ts

@@ -0,0 +1,83 @@
+/**
+ * Regression test for #3651 — renderAllProjections must NOT call renderPlanProjection
+ *
+ * renderAllProjections previously called renderPlanProjection inside the slice
+ * loop, which overwrote the authoritative PLAN.md (produced by markdown-renderer.js
+ * in plan-slice/replan-slice tools) with a simplified projection that was missing
+ * key sections (Must-Haves, Verification, Files Likely Touched) and corrupted
+ * multi-line task descriptions.
+ *
+ * The fix removes the renderPlanProjection call from the renderAllProjections
+ * loop. The renderIfMissing recovery path is preserved.
+ */
+
+import { describe, it } from 'node:test'
+import assert from 'node:assert/strict'
+import { readFileSync } from 'node:fs'
+import { resolve } from 'node:path'
+
+// Use process.cwd() based resolution instead of import.meta.url
+// to avoid tsx test runner path resolution issues
+const src = readFileSync(
+  resolve(process.cwd(), 'src', 'resources', 'extensions', 'gsd', 'workflow-projections.ts'),
+  'utf-8',
+)
+
+describe('renderAllProjections must not overwrite PLAN.md (#3651)', () => {
+  it('renderAllProjections function body does NOT invoke renderPlanProjection', () => {
+    // Extract the renderAllProjections function body
+    const fnStart = src.indexOf('export async function renderAllProjections(')
+    assert.ok(fnStart !== -1, 'renderAllProjections function must exist')
+
+    // Find the for-loop over sliceRows inside renderAllProjections
+    const loopStart = src.indexOf('for (const slice of sliceRows)', fnStart)
+    assert.ok(loopStart !== -1, 'slice loop must exist in renderAllProjections')
+
+    // Find the closing of renderAllProjections (next section marker)
+    const fnEnd = src.indexOf('\n// ─── ', fnStart + 1)
+    assert.ok(fnEnd !== -1, 'section delimiter after renderAllProjections must exist')
+
+    const fnBody = src.slice(loopStart, fnEnd)
+
+    // The fix: renderPlanProjection must NOT appear as a function call.
+    // Strip comment lines before checking (comments may mention the function name).
+    const codeOnly = fnBody
+      .split('\n')
+      .filter(line => !line.trim().startsWith('//'))
+      .join('\n')
+
+    const hasPlanCall = /renderPlanProjection\s*\(/.test(codeOnly)
+    assert.equal(
+      hasPlanCall,
+      false,
+      'renderPlanProjection must not be called inside the renderAllProjections slice loop — ' +
+        'authoritative PLAN.md is rendered only by plan-slice/replan-slice tools',
+    )
+  })
+
+  it('renderPlanProjection is still defined (available for regenerateIfMissing)', () => {
+    assert.ok(
+      src.includes('function renderPlanProjection('),
+      'renderPlanProjection function definition must still exist for on-demand recovery',
+    )
+  })
+
+  it('renderAllProjections still renders ROADMAP, SUMMARY, and STATE projections', () => {
+    const fnStart = src.indexOf('export async function renderAllProjections(')
+    const fnEnd = src.indexOf('\n// ─── ', fnStart + 1)
+    const fnBody = src.slice(fnStart, fnEnd)
+
+    assert.ok(
+      fnBody.includes('renderRoadmapProjection('),
+      'renderRoadmapProjection must still be called',
+    )
+    assert.ok(
+      fnBody.includes('renderSummaryProjection('),
+      'renderSummaryProjection must still be called',
+    )
+    assert.ok(
+      fnBody.includes('renderStateProjection('),
+      'renderStateProjection must still be called',
+    )
+  })
+})