gsd-pi 2.65.0-dev.5c8557b → 2.65.0-dev.6cc5110

package/dist/resources/extensions/gsd/config-overlay.js

@@ -0,0 +1,312 @@
+/**
+ * GSD Configuration Overlay
+ *
+ * Read-only TUI overlay showing the effective GSD configuration:
+ * token profile, model assignments, dynamic routing, git settings,
+ * budget, workflow toggles, and preference file sources.
+ * Opened via `/gsd show-config` or `/gsd config`.
+ */
+import { matchesKey, Key, truncateToWidth } from "@gsd/pi-tui";
+import { loadEffectiveGSDPreferences, loadGlobalGSDPreferences, loadProjectGSDPreferences, getGlobalGSDPreferencesPath, getProjectGSDPreferencesPath, resolveDynamicRoutingConfig, resolveEffectiveProfile, resolveModelWithFallbacksForUnit, resolveAutoSupervisorConfig, } from "./preferences.js";
+function collectConfigSections() {
+    const sections = [];
+    const globalPrefs = loadGlobalGSDPreferences();
+    const projectPrefs = loadProjectGSDPreferences();
+    const effective = loadEffectiveGSDPreferences();
+    const prefs = effective?.preferences;
+    // ─── Sources ─────────────────────────────────────────────────────────
+    sections.push({
+        title: "Sources",
+        rows: [
+            { label: "Global", value: globalPrefs ? globalPrefs.path : `(none) ${getGlobalGSDPreferencesPath()}` },
+            { label: "Project", value: projectPrefs ? projectPrefs.path : `(none) ${getProjectGSDPreferencesPath()}` },
+        ],
+    });
+    // ─── Profile ─────────────────────────────────────────────────────────
+    const profile = resolveEffectiveProfile();
+    const profileRows = [
+        { label: "Token profile", value: `${profile}${!prefs?.token_profile ? " (default)" : ""}`, accent: true },
+    ];
+    if (prefs?.mode)
+        profileRows.push({ label: "Workflow mode", value: prefs.mode });
+    sections.push({ title: "Profile", rows: profileRows });
+    // ─── Models ──────────────────────────────────────────────────────────
+    const unitTypes = [
+        ["research", "research-milestone"],
+        ["planning", "plan-milestone"],
+        ["discuss", "discuss-milestone"],
+        ["execution", "execute-task"],
+        ["completion", "complete-slice"],
+        ["validation", "run-uat"],
+    ];
+    const modelRows = [];
+    for (const [label, unitType] of unitTypes) {
+        const resolved = resolveModelWithFallbacksForUnit(unitType);
+        if (resolved) {
+            let val = resolved.primary;
+            if (resolved.fallbacks.length > 0) {
+                val += ` \u2192 ${resolved.fallbacks.join(" \u2192 ")}`;
+            }
+            modelRows.push({ label, value: val });
+        }
+        else {
+            modelRows.push({ label, value: "(inherit)" });
+        }
+    }
+    // subagent is a direct config key
+    const models = prefs?.models;
+    const subVal = models?.subagent;
+    if (subVal) {
+        const model = typeof subVal === "string" ? subVal : subVal?.model ?? "?";
+        modelRows.push({ label: "subagent", value: model });
+    }
+    else {
+        modelRows.push({ label: "subagent", value: "(inherit)" });
+    }
+    sections.push({ title: "Models", rows: modelRows });
+    // ─── Dynamic Routing ─────────────────────────────────────────────────
+    const routing = resolveDynamicRoutingConfig();
+    const routingRows = [
+        { label: "Enabled", value: routing.enabled ? "yes" : "no", accent: routing.enabled },
+    ];
+    if (routing.enabled) {
+        routingRows.push({ label: "Escalate on fail", value: routing.escalate_on_failure !== false ? "yes" : "no" });
+        routingRows.push({ label: "Budget pressure", value: routing.budget_pressure !== false ? "yes" : "no" });
+        routingRows.push({ label: "Cross-provider", value: routing.cross_provider !== false ? "yes" : "no" });
+        if (routing.tier_models) {
+            const tm = routing.tier_models;
+            if (tm.light)
+                routingRows.push({ label: "[L] light", value: tm.light });
+            if (tm.standard)
+                routingRows.push({ label: "[S] standard", value: tm.standard });
+            if (tm.heavy)
+                routingRows.push({ label: "[H] heavy", value: tm.heavy });
+        }
+    }
+    sections.push({ title: "Dynamic Routing", rows: routingRows });
+    // ─── Git ─────────────────────────────────────────────────────────────
+    if (prefs?.git) {
+        const g = prefs.git;
+        const gitRows = [];
+        if (g.isolation !== undefined)
+            gitRows.push({ label: "Isolation", value: String(g.isolation) });
+        if (g.auto_push !== undefined)
+            gitRows.push({ label: "Auto push", value: String(g.auto_push) });
+        if (g.push_branches !== undefined)
+            gitRows.push({ label: "Push branches", value: String(g.push_branches) });
+        if (g.merge_strategy)
+            gitRows.push({ label: "Merge strategy", value: g.merge_strategy });
+        if (g.main_branch)
+            gitRows.push({ label: "Main branch", value: g.main_branch });
+        if (g.remote)
+            gitRows.push({ label: "Remote", value: g.remote });
+        if (gitRows.length > 0)
+            sections.push({ title: "Git", rows: gitRows });
+    }
+    // ─── Budget ──────────────────────────────────────────────────────────
+    if (prefs?.budget_ceiling !== undefined || prefs?.budget_enforcement) {
+        const budgetRows = [];
+        if (prefs.budget_ceiling !== undefined)
+            budgetRows.push({ label: "Ceiling", value: `$${prefs.budget_ceiling}` });
+        if (prefs.budget_enforcement)
+            budgetRows.push({ label: "Enforcement", value: String(prefs.budget_enforcement) });
+        sections.push({ title: "Budget", rows: budgetRows });
+    }
+    // ─── Auto Supervisor ─────────────────────────────────────────────────
+    if (prefs?.auto_supervisor) {
+        const sup = resolveAutoSupervisorConfig();
+        const supRows = [];
+        if (sup.model)
+            supRows.push({ label: "Model", value: sup.model });
+        supRows.push({ label: "Soft timeout", value: `${sup.soft_timeout_minutes}m` });
+        supRows.push({ label: "Idle timeout", value: `${sup.idle_timeout_minutes}m` });
+        supRows.push({ label: "Hard timeout", value: `${sup.hard_timeout_minutes}m` });
+        sections.push({ title: "Auto Supervisor", rows: supRows });
+    }
+    // ─── Toggles ─────────────────────────────────────────────────────────
+    const toggleRows = [];
+    if (prefs?.phases) {
+        const p = prefs.phases;
+        if (p.skip_research)
+            toggleRows.push({ label: "skip_research", value: "on" });
+        if (p.skip_reassess)
+            toggleRows.push({ label: "skip_reassess", value: "on" });
+        if (p.skip_slice_research)
+            toggleRows.push({ label: "skip_slice_research", value: "on" });
+        if (p.skip_milestone_validation)
+            toggleRows.push({ label: "skip_milestone_validation", value: "on" });
+        if (p.require_slice_discussion)
+            toggleRows.push({ label: "require_slice_discussion", value: "on" });
+    }
+    if (prefs?.uat_dispatch)
+        toggleRows.push({ label: "uat_dispatch", value: "on" });
+    if (prefs?.auto_visualize)
+        toggleRows.push({ label: "auto_visualize", value: "on" });
+    if (prefs?.auto_report === false)
+        toggleRows.push({ label: "auto_report", value: "off" });
+    if (prefs?.show_token_cost)
+        toggleRows.push({ label: "show_token_cost", value: "on" });
+    if (prefs?.forensics_dedup)
+        toggleRows.push({ label: "forensics_dedup", value: "on" });
+    if (prefs?.unique_milestone_ids)
+        toggleRows.push({ label: "unique_milestone_ids", value: "on" });
+    if (prefs?.service_tier)
+        toggleRows.push({ label: "service_tier", value: prefs.service_tier });
+    if (prefs?.search_provider && prefs.search_provider !== "auto")
+        toggleRows.push({ label: "search_provider", value: prefs.search_provider });
+    if (prefs?.context_selection)
+        toggleRows.push({ label: "context_selection", value: prefs.context_selection });
+    if (prefs?.widget_mode && prefs.widget_mode !== "full")
+        toggleRows.push({ label: "widget_mode", value: prefs.widget_mode });
+    if (prefs?.experimental?.rtk)
+        toggleRows.push({ label: "experimental.rtk", value: "on" });
+    if (toggleRows.length > 0)
+        sections.push({ title: "Toggles", rows: toggleRows });
+    // ─── Parallel ────────────────────────────────────────────────────────
+    if (prefs?.parallel) {
+        const pc = prefs.parallel;
+        const parallelRows = [];
+        if (pc.max_workers !== undefined)
+            parallelRows.push({ label: "Max workers", value: String(pc.max_workers) });
+        if (pc.merge_strategy)
+            parallelRows.push({ label: "Merge strategy", value: pc.merge_strategy });
+        if (pc.auto_merge)
+            parallelRows.push({ label: "Auto merge", value: pc.auto_merge });
+        if (parallelRows.length > 0)
+            sections.push({ title: "Parallel", rows: parallelRows });
+    }
+    // ─── Hooks ───────────────────────────────────────────────────────────
+    const postHooks = prefs?.post_unit_hooks?.filter(h => h.enabled !== false) ?? [];
+    const preHooks = prefs?.pre_dispatch_hooks?.filter(h => h.enabled !== false) ?? [];
+    if (postHooks.length > 0 || preHooks.length > 0) {
+        const hookRows = [];
+        if (preHooks.length > 0)
+            hookRows.push({ label: "Pre-dispatch", value: `${preHooks.length} active` });
+        if (postHooks.length > 0)
+            hookRows.push({ label: "Post-unit", value: `${postHooks.length} active` });
+        sections.push({ title: "Hooks", rows: hookRows });
+    }
+    // ─── Warnings ────────────────────────────────────────────────────────
+    const warnings = [
+        ...(globalPrefs?.warnings ?? []),
+        ...(projectPrefs?.warnings ?? []),
+    ];
+    if (warnings.length > 0) {
+        sections.push({
+            title: "Warnings",
+            rows: warnings.map(w => ({ label: "\u26a0", value: w })),
+        });
+    }
+    return sections;
+}
+// ─── Plain Text Formatter (headless/RPC fallback) ─────────────────────────
+export function formatConfigText() {
+    const sections = collectConfigSections();
+    const lines = ["GSD Configuration\n"];
+    let maxLabel = 0;
+    for (const section of sections) {
+        for (const row of section.rows) {
+            if (row.label.length > maxLabel)
+                maxLabel = row.label.length;
+        }
+    }
+    const pad = Math.min(maxLabel + 2, 24);
+    for (const section of sections) {
+        lines.push("");
+        lines.push(section.title.toUpperCase());
+        for (const row of section.rows) {
+            lines.push(`  ${row.label.padEnd(pad)}${row.value}`);
+        }
+    }
+    return lines.join("\n");
+}
+// ─── Overlay Class ────────────────────────────────────────────────────────
+export class GSDConfigOverlay {
+    tui;
+    theme;
+    onClose;
+    sections;
+    cachedLines;
+    scrollOffset = 0;
+    disposed = false;
+    constructor(tui, theme, onClose) {
+        this.tui = tui;
+        this.theme = theme;
+        this.onClose = onClose;
+        this.sections = collectConfigSections();
+    }
+    invalidate() {
+        this.cachedLines = undefined;
+    }
+    dispose() {
+        this.disposed = true;
+    }
+    handleInput(data) {
+        if (matchesKey(data, Key.escape) || data === "q") {
+            this.dispose();
+            this.onClose();
+            return;
+        }
+        if (matchesKey(data, Key.down) || data === "j") {
+            this.scrollOffset++;
+            this.cachedLines = undefined;
+            this.tui.requestRender();
+            return;
+        }
+        if (matchesKey(data, Key.up) || data === "k") {
+            this.scrollOffset = Math.max(0, this.scrollOffset - 1);
+            this.cachedLines = undefined;
+            this.tui.requestRender();
+            return;
+        }
+        if (matchesKey(data, Key.pageDown)) {
+            this.scrollOffset += 10;
+            this.cachedLines = undefined;
+            this.tui.requestRender();
+            return;
+        }
+        if (matchesKey(data, Key.pageUp)) {
+            this.scrollOffset = Math.max(0, this.scrollOffset - 10);
+            this.cachedLines = undefined;
+            this.tui.requestRender();
+            return;
+        }
+    }
+    render(width) {
+        if (this.cachedLines)
+            return this.cachedLines;
+        const t = this.theme;
+        const w = Math.max(width, 50);
+        const allLines = [];
+        // Header
+        allLines.push(t.bold(t.fg("accent", " GSD Configuration ")));
+        allLines.push(t.fg("muted", "\u2500".repeat(w)));
+        // Find max label width for alignment
+        let maxLabel = 0;
+        for (const section of this.sections) {
+            for (const row of section.rows) {
+                if (row.label.length > maxLabel)
+                    maxLabel = row.label.length;
+            }
+        }
+        const labelPad = Math.min(maxLabel + 2, 24);
+        for (const section of this.sections) {
+            allLines.push("");
+            allLines.push(t.bold(t.fg("accent", `  ${section.title}`)));
+            for (const row of section.rows) {
+                const label = t.fg("muted", `    ${row.label.padEnd(labelPad)}`);
+                const value = row.accent ? t.bold(row.value) : row.value;
+                allLines.push(truncateToWidth(`${label}${value}`, w));
+            }
+        }
+        allLines.push("");
+        allLines.push(t.fg("muted", `  ${"\u2500".repeat(w - 4)}`));
+        allLines.push(t.fg("muted", "  esc/q close  \u2502  \u2191\u2193/jk scroll  \u2502  /gsd prefs to edit"));
+        // Apply scroll
+        const maxScroll = Math.max(0, allLines.length - 20);
+        this.scrollOffset = Math.min(this.scrollOffset, maxScroll);
+        const visible = allLines.slice(this.scrollOffset);
+        this.cachedLines = visible;
+        return visible;
+    }
+}

package/dist/resources/extensions/gsd/db-writer.js

@@ -300,8 +300,13 @@ export async function saveRequirementToDb(fields, basePath) {
         }
         catch (diskErr) {
             logError('manifest', 'disk write failed, rolling back DB row', { fn: 'saveRequirementToDb', error: String(diskErr.message) });
-            const rollbackAdapter = db._getAdapter();
-            rollbackAdapter?.prepare('DELETE FROM requirements WHERE id = :id').run({ ':id': id });
+            try {
+                const rollbackAdapter = db._getAdapter();
+                rollbackAdapter?.prepare('DELETE FROM requirements WHERE id = :id').run({ ':id': id });
+            }
+            catch (rollbackErr) {
+                logError('manifest', 'SPLIT BRAIN: disk write failed AND DB rollback failed — DB has orphaned row', { fn: 'saveRequirementToDb', id, error: String(rollbackErr.message) });
+            }
             throw diskErr;
         }
         invalidateStateCache();
@@ -399,7 +404,12 @@ export async function saveDecisionToDb(fields, basePath) {
         }
         catch (diskErr) {
             logError('manifest', 'disk write failed, rolling back DB row', { fn: 'saveDecisionToDb', error: String(diskErr.message) });
-            adapter?.prepare('DELETE FROM decisions WHERE id = :id').run({ ':id': id });
+            try {
+                adapter?.prepare('DELETE FROM decisions WHERE id = :id').run({ ':id': id });
+            }
+            catch (rollbackErr) {
+                logError('manifest', 'SPLIT BRAIN: disk write failed AND DB rollback failed — DB has orphaned row', { fn: 'saveDecisionToDb', id, error: String(rollbackErr.message) });
+            }
             throw diskErr;
         }
         // #2661: When a decision defers a slice, update the slice status in the DB

package/dist/resources/extensions/gsd/detection.js

@@ -945,7 +945,7 @@ function resolveVersionCatalogAccessors(basePath, versionCatalogFiles, settingsF
     }
     return accessors;
 }
-function scanProjectFiles(basePath) {
+export function scanProjectFiles(basePath) {
     const files = [];
     const queue = [{ path: basePath, depth: 0 }];
     while (queue.length > 0 && files.length < MAX_RECURSIVE_SCAN_FILES) {

package/dist/resources/extensions/gsd/dispatch-guard.js

@@ -4,6 +4,7 @@ import { findMilestoneIds } from "./guided-flow.js";
 import { parseUnitId } from "./unit-id.js";
 import { isDbAvailable, getMilestoneSlices } from "./gsd-db.js";
 import { parseRoadmap } from "./parsers-legacy.js";
+import { isClosedStatus } from "./status-guards.js";
 import { readFileSync } from "node:fs";
 const SLICE_DISPATCH_TYPES = new Set([
     "research-slice",
@@ -46,7 +47,7 @@ export function getPriorSliceCompletionBlocker(base, _mainBranch, unitType, unit
             if (rows.length > 0) {
                 slices = rows.map((r) => ({
                     id: r.id,
-                    done: r.status === "complete",
+                    done: isClosedStatus(r.status),
                     depends: r.depends ?? [],
                 }));
             }

package/dist/resources/extensions/gsd/docs/preferences-reference.md

@@ -211,6 +211,7 @@ Setting `prefer_skills: []` does **not** disable skill discovery — it just mea
   - `budget_ceiling`: number — optional per-parallel-run budget ceiling.
   - `merge_strategy`: `"per-slice"` or `"per-milestone"` — when to merge worktree results back. Default: `"per-milestone"`.
   - `auto_merge`: `"auto"`, `"confirm"`, or `"manual"` — merge behavior after completion. `"auto"` merges immediately; `"confirm"` asks first; `"manual"` leaves branches for you. Default: `"confirm"`.
+  - `worker_model`: string — optional model override for parallel milestone workers. When set, workers use this model (e.g. `"claude-haiku-4-5"`) instead of inheriting the coordinator's model. Useful for cost savings on execution-heavy milestones.
 
 - `verification_commands`: string[] — shell commands to run as verification after task execution (e.g., `["npm test", "npm run lint"]`). Commands run in order; if any fails, the task is marked as needing fixes.
 

package/dist/resources/extensions/gsd/doctor.js

@@ -75,7 +75,8 @@ function validatePreferenceShape(preferences) {
     }
     return issues;
 }
-function buildStateMarkdown(state) {
+/** Build STATE.md content from derived state. Exported for guided-flow pre-dispatch rebuild (#3475). */
+export function buildStateMarkdown(state) {
     const lines = [];
     lines.push("# GSD State", "");
     const activeMilestone = state.activeMilestone

package/dist/resources/extensions/gsd/gitignore.js

@@ -39,6 +39,7 @@ const BASELINE_PATTERNS = [
     // ── GSD state directory (symlink to external storage) ──
     ".gsd",
     ".gsd-id",
+    ".bg-shell/",
     // ── OS junk ──
     ".DS_Store",
     "Thumbs.db",

package/dist/resources/extensions/gsd/gsd-db.js

@@ -357,6 +357,7 @@ function initSchema(db, fileBacked) {
         db.exec("CREATE INDEX IF NOT EXISTS idx_milestones_status ON milestones(status)");
         db.exec("CREATE INDEX IF NOT EXISTS idx_quality_gates_pending ON quality_gates(milestone_id, slice_id, status)");
         db.exec("CREATE INDEX IF NOT EXISTS idx_verification_evidence_task ON verification_evidence(milestone_id, slice_id, task_id)");
+        db.exec("CREATE UNIQUE INDEX IF NOT EXISTS idx_verification_evidence_dedup ON verification_evidence(task_id, slice_id, milestone_id, command, verdict)");
         // v14 index — slice dependency lookups
         db.exec("CREATE INDEX IF NOT EXISTS idx_slice_deps_target ON slice_dependencies(milestone_id, depends_on_slice_id)");
         db.exec(`CREATE VIEW IF NOT EXISTS active_decisions AS SELECT * FROM decisions WHERE superseded_by IS NULL`);
@@ -644,6 +645,7 @@ function migrateSchema(db) {
             db.exec("CREATE INDEX IF NOT EXISTS idx_milestones_status ON milestones(status)");
             db.exec("CREATE INDEX IF NOT EXISTS idx_quality_gates_pending ON quality_gates(milestone_id, slice_id, status)");
             db.exec("CREATE INDEX IF NOT EXISTS idx_verification_evidence_task ON verification_evidence(milestone_id, slice_id, task_id)");
+            db.exec("CREATE UNIQUE INDEX IF NOT EXISTS idx_verification_evidence_dedup ON verification_evidence(task_id, slice_id, milestone_id, command, verdict)");
             db.prepare("INSERT INTO schema_version (version, applied_at) VALUES (:version, :applied_at)").run({
                 ":version": 13,
                 ":applied_at": new Date().toISOString(),
@@ -1007,7 +1009,9 @@ export function insertMilestone(m) {
     )`).run({
         ":id": m.id,
         ":title": m.title ?? "",
-        ":status": m.status ?? "active",
+        // Default to "queued" — never auto-create milestones as "active" (#3380).
+        // Callers that need "active" must pass it explicitly.
+        ":status": m.status ?? "queued",
         ":depends_on": JSON.stringify(m.depends_on ?? []),
         ":created_at": new Date().toISOString(),
         ":vision": m.planning?.vision ?? "",
@@ -1198,6 +1202,11 @@ export function updateTaskStatus(milestoneId, sliceId, taskId, status, completed
         ":id": taskId,
     });
 }
+export function setTaskBlockerDiscovered(milestoneId, sliceId, taskId, discovered) {
+    if (!currentDb)
+        return;
+    currentDb.prepare(`UPDATE tasks SET blocker_discovered = :discovered WHERE milestone_id = :mid AND slice_id = :sid AND id = :tid`).run({ ":discovered": discovered ? 1 : 0, ":mid": milestoneId, ":sid": sliceId, ":tid": taskId });
+}
 export function upsertTaskPlanning(milestoneId, sliceId, taskId, planning) {
     if (!currentDb)
         throw new GSDError(GSD_STALE_STATE, "gsd-db: No database open");
@@ -1323,7 +1332,7 @@ export function getSliceTasks(milestoneId, sliceId) {
 export function insertVerificationEvidence(e) {
     if (!currentDb)
         throw new GSDError(GSD_STALE_STATE, "gsd-db: No database open");
-    currentDb.prepare(`INSERT INTO verification_evidence (task_id, slice_id, milestone_id, command, exit_code, verdict, duration_ms, created_at)
+    currentDb.prepare(`INSERT OR IGNORE INTO verification_evidence (task_id, slice_id, milestone_id, command, exit_code, verdict, duration_ms, created_at)
      VALUES (:task_id, :slice_id, :milestone_id, :command, :exit_code, :verdict, :duration_ms, :created_at)`).run({
         ":task_id": e.taskId,
         ":slice_id": e.sliceId,