gsd-pi 2.64.0 → 2.65.0-dev.16e10d7

package/src/resources/extensions/gsd/preferences-validation.ts

@@ -530,6 +530,14 @@ export function validatePreferences(preferences: GSDPreferences): {
       }
     }
 
+    if (p.worker_model !== undefined) {
+      if (typeof p.worker_model === "string" && p.worker_model.length > 0) {
+        parallel.worker_model = p.worker_model;
+      } else {
+        errors.push("parallel.worker_model must be a non-empty string");
+      }
+    }
+
     if (Object.keys(parallel).length > 0) {
       validated.parallel = parallel as unknown as import("./types.js").ParallelConfig;
     }
@@ -561,7 +569,15 @@ export function validatePreferences(preferences: GSDPreferences): {
         }
       }
 
-      const knownReKeys = new Set(["enabled", "max_parallel", "isolation_mode"]);
+      if (re.subagent_model !== undefined) {
+        if (typeof re.subagent_model === "string" && re.subagent_model.length > 0) {
+          validRe.subagent_model = re.subagent_model;
+        } else {
+          errors.push("reactive_execution.subagent_model must be a non-empty string");
+        }
+      }
+
+      const knownReKeys = new Set(["enabled", "max_parallel", "isolation_mode", "subagent_model"]);
       for (const key of Object.keys(re)) {
         if (!knownReKeys.has(key)) {
           warnings.push(`unknown reactive_execution key "${key}" — ignored`);
@@ -902,5 +918,66 @@ export function validatePreferences(preferences: GSDPreferences): {
     }
   }
 
+  // ─── Enhanced Verification ──────────────────────────────────────────────────
+  if (preferences.enhanced_verification !== undefined) {
+    if (typeof preferences.enhanced_verification === "boolean") {
+      validated.enhanced_verification = preferences.enhanced_verification;
+    } else {
+      errors.push("enhanced_verification must be a boolean");
+    }
+  }
+
+  if (preferences.enhanced_verification_pre !== undefined) {
+    if (typeof preferences.enhanced_verification_pre === "boolean") {
+      validated.enhanced_verification_pre = preferences.enhanced_verification_pre;
+    } else {
+      errors.push("enhanced_verification_pre must be a boolean");
+    }
+  }
+
+  if (preferences.enhanced_verification_post !== undefined) {
+    if (typeof preferences.enhanced_verification_post === "boolean") {
+      validated.enhanced_verification_post = preferences.enhanced_verification_post;
+    } else {
+      errors.push("enhanced_verification_post must be a boolean");
+    }
+  }
+
+  if (preferences.enhanced_verification_strict !== undefined) {
+    if (typeof preferences.enhanced_verification_strict === "boolean") {
+      validated.enhanced_verification_strict = preferences.enhanced_verification_strict;
+    } else {
+      errors.push("enhanced_verification_strict must be a boolean");
+    }
+  }
+
+  // ─── Discuss Preparation ────────────────────────────────────────────
+  if (preferences.discuss_preparation !== undefined) {
+    if (typeof preferences.discuss_preparation === "boolean") {
+      validated.discuss_preparation = preferences.discuss_preparation;
+    } else {
+      errors.push("discuss_preparation must be a boolean");
+    }
+  }
+
+  // ─── Discuss Web Research ───────────────────────────────────────────
+  if (preferences.discuss_web_research !== undefined) {
+    if (typeof preferences.discuss_web_research === "boolean") {
+      validated.discuss_web_research = preferences.discuss_web_research;
+    } else {
+      errors.push("discuss_web_research must be a boolean");
+    }
+  }
+
+  // ─── Discuss Depth ──────────────────────────────────────────────────
+  if (preferences.discuss_depth !== undefined) {
+    const validDepths = new Set(["quick", "standard", "thorough"]);
+    if (typeof preferences.discuss_depth === "string" && validDepths.has(preferences.discuss_depth)) {
+      validated.discuss_depth = preferences.discuss_depth as GSDPreferences["discuss_depth"];
+    } else {
+      errors.push(`discuss_depth must be one of: quick, standard, thorough`);
+    }
+  }
+
   return { preferences: validated, errors, warnings };
 }

package/src/resources/extensions/gsd/preferences.ts

@@ -201,9 +201,10 @@ function loadPreferencesFile(path: string, scope: "global" | "project"): LoadedG
 
 let _warnedUnrecognizedFormat = false;
 
-/** @internal Reset the warn-once flag — exported for testing only. */
+/** @internal Reset the warn-once flags — exported for testing only. */
 export function _resetParseWarningFlag(): void {
   _warnedUnrecognizedFormat = false;
+  _warnedFrontmatterParse = false;
 }
 
 /** @internal Exported for testing only */
@@ -235,6 +236,7 @@ export function parsePreferencesMarkdown(content: string): GSDPreferences | null
   return null;
 }
 
+let _warnedFrontmatterParse = false;
 function parseFrontmatterBlock(frontmatter: string): GSDPreferences {
   try {
     const parsed = parseYaml(frontmatter);
@@ -243,7 +245,11 @@ function parseFrontmatterBlock(frontmatter: string): GSDPreferences {
     }
     return parsed as GSDPreferences;
   } catch (e) {
-    logWarning("guided", `YAML parse error in frontmatter block: ${(e as Error).message}`);
+    // Warn at most once per session to avoid flooding TUI (#3376)
+    if (!_warnedFrontmatterParse) {
+      _warnedFrontmatterParse = true;
+      logWarning("guided", `YAML parse error in preferences frontmatter (suppressing further): ${(e as Error).message}`);
+    }
     return {} as GSDPreferences;
   }
 }
@@ -367,6 +373,10 @@ function mergePreferences(base: GSDPreferences, override: GSDPreferences): GSDPr
     verification_commands: mergeStringLists(base.verification_commands, override.verification_commands),
     verification_auto_fix: override.verification_auto_fix ?? base.verification_auto_fix,
     verification_max_retries: override.verification_max_retries ?? base.verification_max_retries,
+    enhanced_verification: override.enhanced_verification ?? base.enhanced_verification,
+    enhanced_verification_pre: override.enhanced_verification_pre ?? base.enhanced_verification_pre,
+    enhanced_verification_post: override.enhanced_verification_post ?? base.enhanced_verification_post,
+    enhanced_verification_strict: override.enhanced_verification_strict ?? base.enhanced_verification_strict,
     search_provider: override.search_provider ?? base.search_provider,
     context_selection: override.context_selection ?? base.context_selection,
     auto_visualize: override.auto_visualize ?? base.auto_visualize,
@@ -555,5 +565,6 @@ export function resolveParallelConfig(prefs: GSDPreferences | undefined): import
     budget_ceiling: prefs?.parallel?.budget_ceiling,
     merge_strategy: prefs?.parallel?.merge_strategy ?? "per-milestone",
     auto_merge: prefs?.parallel?.auto_merge ?? "confirm",
+    worker_model: prefs?.parallel?.worker_model,
   };
 }