gsd-pi 2.63.0 → 2.64.0-dev.9c14bd0

package/dist/resources/extensions/gsd/guided-flow.js

@@ -33,6 +33,7 @@ import { debugLog } from "./debug-logger.js";
 import { findMilestoneIds, nextMilestoneId, reserveMilestoneId, getReservedMilestoneIds, clearReservedMilestoneIds } from "./milestone-ids.js";
 import { parkMilestone, discardMilestone } from "./milestone-actions.js";
 import { selectAndApplyModel } from "./auto-model-selection.js";
+import { DISCUSS_TOOLS_ALLOWLIST } from "./constants.js";
 // ─── Re-exports (preserve public API for existing importers) ────────────────
 export { MILESTONE_ID_RE, generateMilestoneSuffix, nextMilestoneId, extractMilestoneSeq, parseMilestoneId, milestoneIdSort, maxMilestoneNum, findMilestoneIds, reserveMilestoneId, claimReservedId, getReservedMilestoneIds, clearReservedMilestoneIds, } from "./milestone-ids.js";
 export { showQueue, handleQueueReorder, showQueueAdd, buildExistingMilestonesContext, } from "./guided-flow-queue.js";
@@ -242,6 +243,24 @@ async function dispatchWorkflow(pi, note, customType = "gsd-run", ctx, unitType)
             });
         }
     }
+    // Scope tools for discuss flows (#2949).
+    // Providers with grammar-based constrained decoding (xAI/Grok) return
+    // "Grammar is too complex" when the combined tool schema is too large.
+    // Discuss flows only need a small subset of GSD tools — strip the heavy
+    // planning/execution/completion tools to keep the grammar within limits.
+    if (unitType?.startsWith("discuss-")) {
+        const currentTools = pi.getActiveTools();
+        // Keep all non-GSD tools (builtins, other extensions) and only the
+        // GSD tools on the discuss allowlist.
+        const scopedTools = currentTools.filter((t) => !t.startsWith("gsd_") || DISCUSS_TOOLS_ALLOWLIST.includes(t));
+        pi.setActiveTools(scopedTools);
+        debugLog("discuss-tool-scoping", {
+            unitType,
+            before: currentTools.length,
+            after: scopedTools.length,
+            removed: currentTools.length - scopedTools.length,
+        });
+    }
     const workflowPath = process.env.GSD_WORKFLOW_PATH ?? join(process.env.HOME ?? "~", ".gsd", "agent", "GSD-WORKFLOW.md");
     const workflow = readFileSync(workflowPath, "utf-8");
     pi.sendMessage({

package/dist/resources/extensions/gsd/metrics.js

@@ -412,7 +412,33 @@ export function loadLedgerFromDisk(base) {
     return loadJsonFileOrNull(metricsPath(base), isMetricsLedger);
 }
 function loadLedger(base) {
-    return loadJsonFile(metricsPath(base), isMetricsLedger, defaultLedger);
+    const raw = loadJsonFile(metricsPath(base), isMetricsLedger, defaultLedger);
+    const before = raw.units.length;
+    raw.units = deduplicateUnits(raw.units);
+    if (raw.units.length < before) {
+        // Persist the cleaned ledger so duplicates don't re-accumulate
+        saveLedger(base, raw);
+    }
+    return raw;
+}
+/**
+ * Collapse duplicate entries with the same (type, id, startedAt) triple.
+ * Keeps the entry with the highest finishedAt (the most complete snapshot).
+ *
+ * This is a defensive measure against idle-watchdog race conditions that can
+ * produce duplicate entries on disk despite the in-memory idempotency guard
+ * in snapshotUnitMetrics(). See #1943.
+ */
+function deduplicateUnits(units) {
+    const map = new Map();
+    for (const u of units) {
+        const key = `${u.type}\0${u.id}\0${u.startedAt}`;
+        const existing = map.get(key);
+        if (!existing || u.finishedAt > existing.finishedAt) {
+            map.set(key, u);
+        }
+    }
+    return Array.from(map.values());
 }
 function saveLedger(base, data) {
     saveJsonFile(metricsPath(base), data);

package/dist/resources/extensions/gsd/native-git-bridge.js

@@ -569,10 +569,12 @@ export function nativeAddAllWithExclusions(basePath, exclusions) {
             return;
         }
         // When .gsd is a symlink, git rejects `:!.gsd/...` pathspecs with
-        // "beyond a symbolic link". Fall back to plain `git add -A` which
-        // respects .gitignore (where .gsd/ is listed by default).
+        // "beyond a symbolic link". Fall back to `git add -u` which only
+        // stages changes to already-tracked files — O(tracked) not O(filesystem).
+        // Using `git add -A` here would traverse the entire working tree,
+        // hanging indefinitely on repos with large untracked data dirs. (#1977)
         if (stderr.includes("beyond a symbolic link")) {
-            nativeAddAll(basePath);
+            gitFileExec(basePath, ["add", "-u"]);
             return;
         }
         throw new GSDError(GSD_GIT_ERROR, `git add -A with exclusions failed in ${basePath}: ${getErrorMessage(err)}`);

package/dist/resources/extensions/gsd/post-execution-checks.js

@@ -0,0 +1,407 @@
+/**
+ * Post-Execution Checks — Validate task output after execution completes.
+ *
+ * Runs these checks against a completed task's output:
+ *   1. Import resolution — verify relative imports in key_files resolve to existing files
+ *   2. Cross-task signatures — detect hallucination cascades (function exists in task output
+ *      but doesn't match prior tasks' actual code)
+ *   3. Pattern consistency — warn on async style drift, naming convention inconsistencies
+ *
+ * Design principles:
+ *   - Pure functions taking (taskRow, priorTasks, basePath) for testability
+ *   - Import checks are blocking failures; pattern checks are warnings
+ *   - No AST parsers — uses regex heuristics
+ */
+import { existsSync, readFileSync } from "node:fs";
+import { resolve, dirname, extname } from "node:path";
+// ─── Import Resolution Check ─────────────────────────────────────────────────
+/**
+ * Extract relative import paths from TypeScript/JavaScript source code.
+ * Returns array of { importPath, lineNum } for relative imports.
+ */
+export function extractRelativeImports(source) {
+    const imports = [];
+    const lines = source.split("\n");
+    // Match:
+    //   import ... from './path'
+    //   import ... from "../path"
+    //   import './path'
+    //   require('./path')
+    //   require("../path")
+    const importPattern = /(?:import\s+(?:.*?\s+from\s+)?|require\s*\(\s*)(['"])(\.\.?\/[^'"]+)\1/g;
+    // Track if we're inside a block comment
+    let inBlockComment = false;
+    for (let i = 0; i < lines.length; i++) {
+        const line = lines[i];
+        // Handle block comment boundaries
+        if (inBlockComment) {
+            if (line.includes("*/")) {
+                inBlockComment = false;
+            }
+            continue;
+        }
+        // Check for block comment start (that doesn't end on same line)
+        const blockStart = line.indexOf("/*");
+        const blockEnd = line.indexOf("*/");
+        if (blockStart !== -1 && (blockEnd === -1 || blockEnd < blockStart)) {
+            inBlockComment = true;
+            continue;
+        }
+        // Skip single-line comments (// at start or after whitespace)
+        const trimmed = line.trimStart();
+        if (trimmed.startsWith("//")) {
+            continue;
+        }
+        // Skip JSDoc-style lines (e.g., " * import ...")
+        if (trimmed.startsWith("*")) {
+            continue;
+        }
+        let match;
+        // Reset lastIndex for each line
+        importPattern.lastIndex = 0;
+        while ((match = importPattern.exec(line)) !== null) {
+            // Check if this match is after a // comment marker on the same line
+            const beforeMatch = line.substring(0, match.index);
+            if (beforeMatch.includes("//")) {
+                continue;
+            }
+            imports.push({
+                importPath: match[2],
+                lineNum: i + 1,
+            });
+        }
+    }
+    return imports;
+}
+/**
+ * Check if a relative import resolves to an existing file.
+ * Handles .ts, .tsx, .js, .jsx extensions and index files.
+ * Also handles TypeScript ESM convention where imports use .js but resolve to .ts.
+ */
+export function resolveImportPath(importPath, sourceFile, basePath) {
+    const sourceDir = dirname(resolve(basePath, sourceFile));
+    const extensions = [".ts", ".tsx", ".js", ".jsx", ".mjs", ".cjs"];
+    // Handle TypeScript ESM convention: .js imports resolve to .ts files
+    // e.g., import './types.js' -> ./types.ts
+    let normalizedPath = importPath;
+    if (importPath.endsWith(".js")) {
+        normalizedPath = importPath.slice(0, -3);
+    }
+    else if (importPath.endsWith(".jsx")) {
+        normalizedPath = importPath.slice(0, -4);
+    }
+    else if (importPath.endsWith(".mjs")) {
+        normalizedPath = importPath.slice(0, -4);
+    }
+    else if (importPath.endsWith(".cjs")) {
+        normalizedPath = importPath.slice(0, -4);
+    }
+    // Try the normalized path with common extensions first
+    for (const ext of extensions) {
+        const fullPath = resolve(sourceDir, normalizedPath + ext);
+        if (existsSync(fullPath)) {
+            return { exists: true, resolvedPath: fullPath };
+        }
+    }
+    // Try as a directory with index file
+    for (const ext of extensions) {
+        const indexPath = resolve(sourceDir, normalizedPath, `index${ext}`);
+        if (existsSync(indexPath)) {
+            return { exists: true, resolvedPath: indexPath };
+        }
+    }
+    // Check if path already has extension (for .json, etc.)
+    const hasExt = [".ts", ".tsx", ".js", ".jsx", ".mjs", ".cjs", ".json"].some((ext) => importPath.endsWith(ext));
+    if (hasExt) {
+        const fullPath = resolve(sourceDir, importPath);
+        if (existsSync(fullPath)) {
+            return { exists: true, resolvedPath: fullPath };
+        }
+    }
+    return { exists: false, resolvedPath: null };
+}
+/**
+ * Check that all relative imports in the task's key_files resolve to existing files.
+ * Reads modified files from task.key_files, extracts import statements via regex,
+ * verifies relative imports resolve to existing files.
+ */
+export function checkImportResolution(taskRow, _priorTasks, basePath) {
+    const results = [];
+    // Get files from key_files
+    const filesToCheck = taskRow.key_files.filter((f) => {
+        const ext = extname(f);
+        return [".ts", ".tsx", ".js", ".jsx", ".mjs", ".cjs"].includes(ext);
+    });
+    for (const file of filesToCheck) {
+        const absolutePath = resolve(basePath, file);
+        // Skip if file doesn't exist (might have been deleted or renamed)
+        if (!existsSync(absolutePath)) {
+            continue;
+        }
+        let source;
+        try {
+            source = readFileSync(absolutePath, "utf-8");
+        }
+        catch {
+            continue;
+        }
+        const imports = extractRelativeImports(source);
+        for (const { importPath, lineNum } of imports) {
+            const resolution = resolveImportPath(importPath, file, basePath);
+            if (!resolution.exists) {
+                results.push({
+                    category: "import",
+                    target: `${file}:${lineNum}`,
+                    passed: false,
+                    message: `Import '${importPath}' in ${file}:${lineNum} does not resolve to an existing file`,
+                    blocking: true,
+                });
+            }
+        }
+    }
+    return results;
+}
+/**
+ * Extract function signatures from TypeScript/JavaScript source code.
+ */
+function extractFunctionSignatures(source, fileName) {
+    const signatures = [];
+    const lines = source.split("\n");
+    // Match function declarations and exports
+    // Patterns:
+    //   function name(params): ReturnType
+    //   export function name(params): ReturnType
+    //   export async function name(params): Promise<ReturnType>
+    //   const name = (params): ReturnType =>
+    //   export const name = (params): ReturnType =>
+    const funcPattern = /(?:export\s+)?(?:async\s+)?(?:function\s+|const\s+)(\w+)(?:\s*=\s*)?\s*\(([^)]*)\)(?:\s*:\s*([^{=>\n]+))?/g;
+    for (let i = 0; i < lines.length; i++) {
+        const line = lines[i];
+        funcPattern.lastIndex = 0;
+        let match;
+        while ((match = funcPattern.exec(line)) !== null) {
+            const [, name, params, returnType] = match;
+            signatures.push({
+                name,
+                params: normalizeParams(params),
+                returnType: normalizeType(returnType || "void"),
+                file: fileName,
+                lineNum: i + 1,
+            });
+        }
+    }
+    return signatures;
+}
+/**
+ * Normalize parameter list for comparison.
+ */
+function normalizeParams(params) {
+    return params
+        .replace(/\/\*[\s\S]*?\*\//g, "") // Remove block comments
+        .replace(/\/\/[^\n]*/g, "") // Remove line comments
+        .replace(/\s*=\s*[^,)]+/g, "") // Remove default values
+        .replace(/\s+/g, " ") // Normalize whitespace
+        .trim();
+}
+/**
+ * Normalize type for comparison.
+ */
+function normalizeType(type) {
+    return type.replace(/\s+/g, " ").trim();
+}
+/**
+ * Compare function signatures in current task's output against prior tasks' key_files
+ * to catch hallucination cascades — when a task references functions that don't exist
+ * or have different signatures than what was actually created.
+ */
+export function checkCrossTaskSignatures(taskRow, priorTasks, basePath) {
+    const results = [];
+    // Build map of functions from prior tasks' key_files
+    const priorSignatures = new Map();
+    for (const task of priorTasks) {
+        for (const file of task.key_files) {
+            const ext = extname(file);
+            if (![".ts", ".tsx", ".js", ".jsx", ".mjs", ".cjs"].includes(ext))
+                continue;
+            const absolutePath = resolve(basePath, file);
+            if (!existsSync(absolutePath))
+                continue;
+            try {
+                const source = readFileSync(absolutePath, "utf-8");
+                const sigs = extractFunctionSignatures(source, file);
+                for (const sig of sigs) {
+                    const existing = priorSignatures.get(sig.name) || [];
+                    existing.push(sig);
+                    priorSignatures.set(sig.name, existing);
+                }
+            }
+            catch {
+                // Skip unreadable files
+            }
+        }
+    }
+    // Extract function calls/references from current task's key_files
+    // and check they match prior definitions
+    for (const file of taskRow.key_files) {
+        const ext = extname(file);
+        if (![".ts", ".tsx", ".js", ".jsx", ".mjs", ".cjs"].includes(ext))
+            continue;
+        const absolutePath = resolve(basePath, file);
+        if (!existsSync(absolutePath))
+            continue;
+        try {
+            const source = readFileSync(absolutePath, "utf-8");
+            const currentSigs = extractFunctionSignatures(source, file);
+            // Check each function in current task against prior definitions
+            for (const currentSig of currentSigs) {
+                const priorDefs = priorSignatures.get(currentSig.name);
+                // If this function was defined in a prior task, check for signature drift
+                if (priorDefs && priorDefs.length > 0) {
+                    const priorDef = priorDefs[0]; // Use first definition
+                    // Check parameter mismatch
+                    if (currentSig.params !== priorDef.params) {
+                        results.push({
+                            category: "signature",
+                            target: currentSig.name,
+                            passed: false,
+                            message: `Function '${currentSig.name}' in ${file}:${currentSig.lineNum} has parameters '${currentSig.params}' but prior definition in ${priorDef.file}:${priorDef.lineNum} has '${priorDef.params}'`,
+                            blocking: false, // Warn only — may be intentional override
+                        });
+                    }
+                    // Check return type mismatch
+                    if (currentSig.returnType !== priorDef.returnType) {
+                        results.push({
+                            category: "signature",
+                            target: currentSig.name,
+                            passed: false,
+                            message: `Function '${currentSig.name}' in ${file}:${currentSig.lineNum} returns '${currentSig.returnType}' but prior definition in ${priorDef.file}:${priorDef.lineNum} returns '${priorDef.returnType}'`,
+                            blocking: false, // Warn only — may be intentional override
+                        });
+                    }
+                }
+            }
+        }
+        catch {
+            // Skip unreadable files
+        }
+    }
+    return results;
+}
+// ─── Pattern Consistency Check ───────────────────────────────────────────────
+/**
+ * Detect async style drift (mixing async/await with .then()) and
+ * naming convention inconsistencies within a task's key_files.
+ * Warn only — these are style issues, not correctness issues.
+ */
+export function checkPatternConsistency(taskRow, _priorTasks, basePath) {
+    const results = [];
+    for (const file of taskRow.key_files) {
+        const ext = extname(file);
+        if (![".ts", ".tsx", ".js", ".jsx", ".mjs", ".cjs"].includes(ext))
+            continue;
+        const absolutePath = resolve(basePath, file);
+        if (!existsSync(absolutePath))
+            continue;
+        try {
+            const source = readFileSync(absolutePath, "utf-8");
+            // Check for async style drift
+            const asyncStyleResult = checkAsyncStyleDrift(source, file);
+            if (asyncStyleResult) {
+                results.push(asyncStyleResult);
+            }
+            // Check for naming convention inconsistencies
+            const namingResults = checkNamingConsistency(source, file);
+            results.push(...namingResults);
+        }
+        catch {
+            // Skip unreadable files
+        }
+    }
+    return results;
+}
+/**
+ * Detect async style drift within a single file.
+ * Returns a warning if both async/await AND .then() promise chaining are used.
+ */
+function checkAsyncStyleDrift(source, fileName) {
+    // Check for async/await usage
+    const hasAsyncAwait = /\basync\b[\s\S]*?\bawait\b/.test(source);
+    // Check for .then() promise chaining (excluding comments)
+    // Filter out common false positives like Array.prototype.then doesn't exist
+    const hasThenChaining = /\.\s*then\s*\(/.test(source);
+    // If both patterns are present, flag as style drift
+    if (hasAsyncAwait && hasThenChaining) {
+        return {
+            category: "pattern",
+            target: fileName,
+            passed: true, // Warning only
+            message: `File ${fileName} mixes async/await with .then() promise chaining — consider using consistent async style`,
+            blocking: false,
+        };
+    }
+    return null;
+}
+/**
+ * Check for naming convention inconsistencies within a file.
+ * Detects mixing of camelCase and snake_case for similar identifier types.
+ */
+function checkNamingConsistency(source, fileName) {
+    const results = [];
+    // Extract function names
+    const functionNames = [];
+    const funcPattern = /(?:function\s+|const\s+|let\s+|var\s+)(\w+)(?:\s*=\s*(?:async\s*)?\(|\s*\()/g;
+    let match;
+    while ((match = funcPattern.exec(source)) !== null) {
+        functionNames.push(match[1]);
+    }
+    // Check for mixed naming conventions in functions
+    const camelCaseFuncs = functionNames.filter((n) => /^[a-z][a-zA-Z0-9]*$/.test(n) && /[A-Z]/.test(n));
+    const snakeCaseFuncs = functionNames.filter((n) => /^[a-z][a-z0-9]*(_[a-z0-9]+)+$/.test(n));
+    if (camelCaseFuncs.length > 0 && snakeCaseFuncs.length > 0) {
+        results.push({
+            category: "pattern",
+            target: fileName,
+            passed: true, // Warning only
+            message: `File ${fileName} mixes camelCase (${camelCaseFuncs.slice(0, 2).join(", ")}) and snake_case (${snakeCaseFuncs.slice(0, 2).join(", ")}) function names`,
+            blocking: false,
+        });
+    }
+    return results;
+}
+// ─── Main Entry Point ────────────────────────────────────────────────────────
+/**
+ * Run all post-execution checks against a completed task.
+ *
+ * @param taskRow - The completed task row
+ * @param priorTasks - Array of TaskRow from prior completed tasks in the slice
+ * @param basePath - Base path for resolving file references
+ * @returns PostExecutionResult with status, checks, and duration
+ */
+export function runPostExecutionChecks(taskRow, priorTasks, basePath) {
+    const startTime = Date.now();
+    const allChecks = [];
+    // Run all checks
+    const importChecks = checkImportResolution(taskRow, priorTasks, basePath);
+    const signatureChecks = checkCrossTaskSignatures(taskRow, priorTasks, basePath);
+    const patternChecks = checkPatternConsistency(taskRow, priorTasks, basePath);
+    allChecks.push(...importChecks, ...signatureChecks, ...patternChecks);
+    const durationMs = Date.now() - startTime;
+    // Determine overall status
+    const hasBlockingFailure = allChecks.some((c) => !c.passed && c.blocking);
+    const hasNonBlockingIssue = allChecks.some((c) => (!c.passed && !c.blocking) || (c.passed && c.category === "pattern"));
+    let status;
+    if (hasBlockingFailure) {
+        status = "fail";
+    }
+    else if (hasNonBlockingIssue) {
+        status = "warn";
+    }
+    else {
+        status = "pass";
+    }
+    return {
+        status,
+        checks: allChecks,
+        durationMs,
+    };
+}