gsd-pi 2.63.0-dev.d04bbc5 → 2.64.0-dev.9c14bd0

package/dist/resources/extensions/gsd/auto-dashboard.js

@@ -472,11 +472,11 @@ export function updateProgressWidget(ctx, unitType, unitId, state, accessors, ti
                     : "";
                 lines.push(rightAlign(headerLeft, headerRight, width));
                 // Worktree/branch right-aligned below header
-                if (worktreeName && cachedBranch) {
-                    lines.push(rightAlign("", theme.fg("dim", `${worktreeName} (${cachedBranch})`), width));
-                }
-                else if (cachedBranch) {
-                    lines.push(rightAlign("", theme.fg("dim", cachedBranch), width));
+                const branchLabel = worktreeName && cachedBranch
+                    ? `${worktreeName} (${cachedBranch})`
+                    : cachedBranch ?? "";
+                if (branchLabel) {
+                    lines.push(rightAlign("", theme.fg("dim", branchLabel), width));
                 }
                 // Show health signal details when degraded (yellow/red)
                 if (score.level !== "green" && score.signals.length > 0 && widgetMode !== "min") {

package/dist/resources/extensions/gsd/auto-post-unit.js

@@ -14,7 +14,7 @@ import { deriveState } from "./state.js";
 import { logWarning, logError } from "./workflow-logger.js";
 import { loadFile, parseSummary, resolveAllOverrides } from "./files.js";
 import { loadPrompt } from "./prompt-loader.js";
-import { resolveSliceFile, resolveTaskFile, resolveMilestoneFile, resolveTasksDir, buildTaskFileName, } from "./paths.js";
+import { resolveSliceFile, resolveSlicePath, resolveTaskFile, resolveMilestoneFile, resolveTasksDir, buildTaskFileName, } from "./paths.js";
 import { invalidateAllCaches } from "./cache.js";
 import { parseUnitId } from "./unit-id.js";
 import { closeoutUnit } from "./auto-unit-closeout.js";
@@ -36,6 +36,10 @@ import { validateFileChanges } from "./safety/file-change-validator.js";
 import { validateContent } from "./safety/content-validator.js";
 import { resolveSafetyHarnessConfig } from "./safety/safety-harness.js";
 import { resolveExpectedArtifactPath as resolveArtifactForContent } from "./auto-artifact-paths.js";
+import { loadEffectiveGSDPreferences } from "./preferences.js";
+import { getSliceTasks } from "./gsd-db.js";
+import { runPreExecutionChecks } from "./pre-execution-checks.js";
+import { writePreExecutionEvidence } from "./verification-evidence.js";
 /** Maximum verification retry attempts before escalating to blocker placeholder (#2653). */
 const MAX_VERIFICATION_RETRIES = 3;
 /** Enqueue a sidecar item (hook, triage, or quick-task) for the main loop to
@@ -634,6 +638,99 @@ export async function postUnitPostVerification(pctx) {
             debugLog("postUnit", { phase: "capture-protection-error", error: String(e) });
         }
     }
+    // ── Pre-execution checks (after plan-slice completes) ──
+    if (s.currentUnit &&
+        s.currentUnit.type === "plan-slice") {
+        let preExecPauseNeeded = false;
+        await runSafely("postUnitPostVerification", "pre-execution-checks", async () => {
+            try {
+                // Check preferences — respect enhanced_verification and enhanced_verification_pre
+                const prefs = loadEffectiveGSDPreferences()?.preferences;
+                const enhancedEnabled = prefs?.enhanced_verification !== false; // default true
+                const preEnabled = prefs?.enhanced_verification_pre !== false; // default true
+                if (!enhancedEnabled || !preEnabled) {
+                    debugLog("postUnitPostVerification", {
+                        phase: "pre-execution-checks",
+                        skipped: true,
+                        reason: "disabled by preferences",
+                    });
+                    return;
+                }
+                // Parse the unit ID to get milestone/slice IDs
+                const { milestone: mid, slice: sid } = parseUnitId(s.currentUnit.id);
+                if (!mid || !sid) {
+                    debugLog("postUnitPostVerification", {
+                        phase: "pre-execution-checks",
+                        skipped: true,
+                        reason: "could not parse milestone/slice from unit ID",
+                    });
+                    return;
+                }
+                // Get tasks for this slice from DB
+                const tasks = getSliceTasks(mid, sid);
+                if (tasks.length === 0) {
+                    debugLog("postUnitPostVerification", {
+                        phase: "pre-execution-checks",
+                        skipped: true,
+                        reason: "no tasks found for slice",
+                    });
+                    return;
+                }
+                // Run pre-execution checks
+                const result = await runPreExecutionChecks(tasks, s.basePath);
+                // Log summary to stderr in existing verification output format
+                const emoji = result.status === "pass" ? "✅" : result.status === "warn" ? "⚠️" : "❌";
+                process.stderr.write(`gsd-pre-exec: ${emoji} Pre-execution checks ${result.status} for ${mid}/${sid} (${result.durationMs}ms)\n`);
+                // Log individual check results
+                for (const check of result.checks) {
+                    const checkEmoji = check.passed ? "✓" : check.blocking ? "✗" : "⚠";
+                    process.stderr.write(`gsd-pre-exec:   ${checkEmoji} [${check.category}] ${check.target}: ${check.message}\n`);
+                }
+                // Write evidence JSON to slice artifacts directory
+                const slicePath = resolveSlicePath(s.basePath, mid, sid);
+                if (slicePath) {
+                    writePreExecutionEvidence(result, slicePath, mid, sid);
+                }
+                // Notify UI
+                if (result.status === "fail") {
+                    const blockingCount = result.checks.filter(c => !c.passed && c.blocking).length;
+                    ctx.ui.notify(`Pre-execution checks failed: ${blockingCount} blocking issue${blockingCount === 1 ? "" : "s"} found`, "error");
+                    preExecPauseNeeded = true;
+                }
+                else if (result.status === "warn") {
+                    ctx.ui.notify(`Pre-execution checks passed with warnings`, "warning");
+                    // Strict mode: treat warnings as blocking
+                    if (prefs?.enhanced_verification_strict === true) {
+                        preExecPauseNeeded = true;
+                    }
+                }
+                debugLog("postUnitPostVerification", {
+                    phase: "pre-execution-checks",
+                    status: result.status,
+                    checkCount: result.checks.length,
+                    durationMs: result.durationMs,
+                });
+            }
+            catch (preExecError) {
+                // Fail-closed: if runPreExecutionChecks throws, pause auto-mode instead of silently continuing
+                const errorMessage = preExecError instanceof Error ? preExecError.message : String(preExecError);
+                debugLog("postUnitPostVerification", {
+                    phase: "pre-execution-checks",
+                    error: errorMessage,
+                    failClosed: true,
+                });
+                logError("engine", `gsd-pre-exec: Pre-execution checks threw an error: ${errorMessage}`);
+                ctx.ui.notify(`Pre-execution checks error: ${errorMessage} — pausing for human review`, "error");
+                preExecPauseNeeded = true;
+            }
+        });
+        // Check for blocking failures after runSafely completes
+        if (preExecPauseNeeded) {
+            debugLog("postUnitPostVerification", { phase: "pre-execution-checks", pausing: true, reason: "blocking failures detected" });
+            await pauseAuto(ctx, pi);
+            return "stopped";
+        }
+    }
     // ── Triage check ──
     if (!s.stepMode &&
         s.currentUnit &&

package/dist/resources/extensions/gsd/auto-verification.js

@@ -9,13 +9,15 @@
  * value instead of calling return/pauseAuto directly — the caller
  * checks the result and handles control flow.
  */
+import { mkdirSync, writeFileSync } from "node:fs";
 import { resolveSlicePath } from "./paths.js";
 import { parseUnitId } from "./unit-id.js";
-import { isDbAvailable, getTask } from "./gsd-db.js";
+import { isDbAvailable, getTask, getSliceTasks } from "./gsd-db.js";
 import { loadEffectiveGSDPreferences } from "./preferences.js";
 import { runVerificationGate, formatFailureContext, captureRuntimeErrors, runDependencyAudit, } from "./verification-gate.js";
 import { writeVerificationJSON } from "./verification-evidence.js";
 import { logWarning } from "./workflow-logger.js";
+import { runPostExecutionChecks } from "./post-execution-checks.js";
 import { join } from "node:path";
 function isInfraVerificationFailure(stderr) {
     return /\b(ENOENT|ENOTFOUND|ETIMEDOUT|ECONNRESET|EAI_AGAIN|spawn\s+\S+\s+ENOENT|command not found)\b/i.test(stderr);
@@ -128,12 +130,104 @@ export async function runPostUnitVerification(vctx, pauseAuto) {
                 : "Verification failed due to infrastructure/runtime environment issues — treating as advisory.", "warning");
             return "continue";
         }
+        // ── Post-execution checks (run after main verification passes for execute-task units) ──
+        let postExecChecks;
+        let postExecBlockingFailure = false;
+        if (result.passed && mid && sid && tid) {
+            // Check preferences — respect enhanced_verification and enhanced_verification_post
+            const enhancedEnabled = prefs?.enhanced_verification !== false; // default true
+            const postEnabled = prefs?.enhanced_verification_post !== false; // default true
+            if (enhancedEnabled && postEnabled && isDbAvailable()) {
+                try {
+                    // Get the completed task from DB
+                    const taskRow = getTask(mid, sid, tid);
+                    if (taskRow && taskRow.key_files && taskRow.key_files.length > 0) {
+                        // Get all tasks in the slice
+                        const allTasks = getSliceTasks(mid, sid);
+                        // Filter to prior completed tasks (status = 'complete' or 'done', before current task)
+                        const priorTasks = allTasks.filter((t) => (t.status === "complete" || t.status === "done") &&
+                            t.id !== tid &&
+                            t.sequence < taskRow.sequence);
+                        // Run post-execution checks
+                        const postExecResult = runPostExecutionChecks(taskRow, priorTasks, s.basePath);
+                        // Store checks for evidence JSON
+                        postExecChecks = postExecResult.checks;
+                        // Log summary to stderr with gsd-post-exec: prefix
+                        const emoji = postExecResult.status === "pass"
+                            ? "✅"
+                            : postExecResult.status === "warn"
+                                ? "⚠️"
+                                : "❌";
+                        process.stderr.write(`gsd-post-exec: ${emoji} Post-execution checks ${postExecResult.status} for ${mid}/${sid}/${tid} (${postExecResult.durationMs}ms)\n`);
+                        // Log individual check results
+                        for (const check of postExecResult.checks) {
+                            const checkEmoji = check.passed
+                                ? "✓"
+                                : check.blocking
+                                    ? "✗"
+                                    : "⚠";
+                            process.stderr.write(`gsd-post-exec:   ${checkEmoji} [${check.category}] ${check.target}: ${check.message}\n`);
+                        }
+                        // Check for blocking failures
+                        if (postExecResult.status === "fail") {
+                            postExecBlockingFailure = true;
+                            const blockingCount = postExecResult.checks.filter((c) => !c.passed && c.blocking).length;
+                            ctx.ui.notify(`Post-execution checks failed: ${blockingCount} blocking issue${blockingCount === 1 ? "" : "s"} found`, "error");
+                        }
+                        else if (postExecResult.status === "warn") {
+                            ctx.ui.notify(`Post-execution checks passed with warnings`, "warning");
+                            // Strict mode: treat warnings as blocking
+                            if (prefs?.enhanced_verification_strict === true) {
+                                postExecBlockingFailure = true;
+                            }
+                        }
+                    }
+                }
+                catch (postExecErr) {
+                    // Post-execution check errors are non-fatal — log and continue
+                    logWarning("engine", `gsd-post-exec: error — ${postExecErr.message}`);
+                }
+            }
+        }
+        // Re-write verification evidence JSON with post-execution checks
+        if (postExecChecks && postExecChecks.length > 0 && mid && sid && tid) {
+            try {
+                const sDir = resolveSlicePath(s.basePath, mid, sid);
+                if (sDir) {
+                    const tasksDir = join(sDir, "tasks");
+                    // Add postExecutionChecks to the result for the JSON write
+                    const resultWithPostExec = {
+                        ...result,
+                        // Mark as failed if there was a blocking post-exec failure
+                        passed: result.passed && !postExecBlockingFailure,
+                    };
+                    // Manually write with postExecutionChecks field
+                    writeVerificationJSONWithPostExec(resultWithPostExec, tasksDir, tid, s.currentUnit.id, postExecChecks, postExecBlockingFailure ? attempt + 1 : undefined, postExecBlockingFailure ? maxRetries : undefined);
+                }
+            }
+            catch (evidenceErr) {
+                logWarning("engine", `verification-evidence: post-exec write error — ${evidenceErr.message}`);
+            }
+        }
+        // Update result.passed based on post-execution checks
+        if (postExecBlockingFailure) {
+            result.passed = false;
+        }
         // ── Auto-fix retry logic ──
         if (result.passed) {
             s.verificationRetryCount.delete(s.currentUnit.id);
             s.pendingVerificationRetry = null;
             return "continue";
         }
+        else if (postExecBlockingFailure) {
+            // Post-execution failures are cross-task consistency issues — retrying the same task won't fix them.
+            // Skip retry and pause immediately for human review.
+            s.verificationRetryCount.delete(s.currentUnit.id);
+            s.pendingVerificationRetry = null;
+            ctx.ui.notify(`Post-execution checks failed — cross-task consistency issue detected, pausing for human review`, "error");
+            await pauseAuto(ctx, pi);
+            return "pause";
+        }
         else if (autoFixEnabled && attempt + 1 <= maxRetries) {
             const nextAttempt = attempt + 1;
             s.verificationRetryCount.set(s.currentUnit.id, nextAttempt);
@@ -173,3 +267,46 @@ export async function runPostUnitVerification(vctx, pauseAuto) {
         return "continue";
     }
 }
+/**
+ * Write verification evidence JSON with post-execution checks included.
+ * This is a variant of writeVerificationJSON that adds the postExecutionChecks field.
+ */
+function writeVerificationJSONWithPostExec(result, tasksDir, taskId, unitId, postExecutionChecks, retryAttempt, maxRetries) {
+    mkdirSync(tasksDir, { recursive: true });
+    const evidence = {
+        schemaVersion: 1,
+        taskId,
+        unitId: unitId ?? taskId,
+        timestamp: result.timestamp,
+        passed: result.passed,
+        discoverySource: result.discoverySource,
+        checks: result.checks.map((check) => ({
+            command: check.command,
+            exitCode: check.exitCode,
+            durationMs: check.durationMs,
+            verdict: check.exitCode === 0 ? "pass" : "fail",
+        })),
+        ...(retryAttempt !== undefined ? { retryAttempt } : {}),
+        ...(maxRetries !== undefined ? { maxRetries } : {}),
+        postExecutionChecks,
+    };
+    if (result.runtimeErrors && result.runtimeErrors.length > 0) {
+        evidence.runtimeErrors = result.runtimeErrors.map(e => ({
+            source: e.source,
+            severity: e.severity,
+            message: e.message,
+            blocking: e.blocking,
+        }));
+    }
+    if (result.auditWarnings && result.auditWarnings.length > 0) {
+        evidence.auditWarnings = result.auditWarnings.map(w => ({
+            name: w.name,
+            severity: w.severity,
+            title: w.title,
+            url: w.url,
+            fixAvailable: w.fixAvailable,
+        }));
+    }
+    const filePath = join(tasksDir, `${taskId}-VERIFY.json`);
+    writeFileSync(filePath, JSON.stringify(evidence, null, 2) + "\n", "utf-8");
+}

package/dist/resources/extensions/gsd/auto.js

@@ -643,6 +643,7 @@ export async function pauseAuto(ctx, _pi, _errorContext) {
             sessionFile: s.pausedSessionFile,
             activeEngineId: s.activeEngineId,
             activeRunDir: s.activeRunDir,
+            autoStartTime: s.autoStartTime,
         };
         const runtimeDir = join(gsdRoot(s.originalBasePath || s.basePath), "runtime");
         mkdirSync(runtimeDir, { recursive: true });
@@ -842,6 +843,7 @@ export async function startAuto(ctx, pi, base, verboseMode, options) {
                     s.activeRunDir = meta.activeRunDir ?? null;
                     s.originalBasePath = meta.originalBasePath || base;
                     s.stepMode = meta.stepMode ?? requestedStepMode;
+                    s.autoStartTime = meta.autoStartTime || Date.now();
                     s.paused = true;
                     try {
                         unlinkSync(pausedPath);
@@ -869,6 +871,7 @@ export async function startAuto(ctx, pi, base, verboseMode, options) {
                         s.currentMilestoneId = meta.milestoneId;
                         s.originalBasePath = meta.originalBasePath || base;
                         s.stepMode = meta.stepMode ?? requestedStepMode;
+                        s.autoStartTime = meta.autoStartTime || Date.now();
                         s.paused = true;
                         // Clean up the persisted file — we're consuming it
                         try {
@@ -900,6 +903,8 @@ export async function startAuto(ctx, pi, base, verboseMode, options) {
         s.cmdCtx = ctx;
         s.basePath = base;
         setLogBasePath(base);
+        if (!s.autoStartTime || s.autoStartTime <= 0)
+            s.autoStartTime = Date.now();
         s.unitDispatchCount.clear();
         s.unitLifetimeDispatches.clear();
         if (!getLedger())