gsd-pi 2.59.0 → 2.60.0-dev.2580e65

package/src/resources/extensions/gsd/workflow-migration.ts

@@ -7,6 +7,7 @@ import { existsSync, readdirSync, readFileSync } from "node:fs";
 import { join } from "node:path";
 import { _getAdapter, transaction } from "./gsd-db.js";
 import { parseRoadmap, parsePlan } from "./parsers-legacy.js";
+import { logWarning } from "./workflow-logger.js";
 
 // ─── needsAutoMigration ───────────────────────────────────────────────────
 
@@ -23,8 +24,8 @@ export function needsAutoMigration(basePath: string): boolean {
   try {
     const row = db.prepare("SELECT COUNT(*) as cnt FROM milestones").get();
     if (row && (row["cnt"] as number) > 0) return false;
-  } catch {
-    // Table might not exist yet — that's fine, we can still migrate
+  } catch (e) {
+    logWarning("migration", `DB probe failed: ${(e as Error).message}`);
     return false;
   }
 
@@ -71,7 +72,7 @@ export function migrateFromMarkdown(basePath: string): void {
       .filter(e => e.isDirectory())
       .map(e => e.name);
   } catch {
-    process.stderr.write("workflow-migration: failed to read milestones directory\n");
+    logWarning("migration", "failed to read milestones directory");
     return;
   }
 
@@ -141,7 +142,7 @@ export function migrateFromMarkdown(basePath: string): void {
           risk: s.risk || "low",
         }));
       } catch (err) {
-        process.stderr.write(`workflow-migration: failed to parse ROADMAP.md for ${mId}: ${(err as Error).message}\n`);
+        logWarning("migration", `failed to parse ROADMAP.md for ${mId}: ${(err as Error).message}`);
         // Still add milestone with ID as title
         milestoneInserts.push({ id: mId, title: mId, status: milestoneStatus });
       }
@@ -191,7 +192,7 @@ export function migrateFromMarkdown(basePath: string): void {
             });
           }
         } catch (err) {
-          process.stderr.write(`workflow-migration: failed to parse ${slice.id}-PLAN.md for ${mId}: ${(err as Error).message}\n`);
+          logWarning("migration", `failed to parse ${slice.id}-PLAN.md for ${mId}: ${(err as Error).message}`);
         }
       }
     }
@@ -206,8 +207,8 @@ export function migrateFromMarkdown(basePath: string): void {
           process.stderr.write(`workflow-migration: orphaned summary file ${summaryFile} in ${mId} (slice not found in ROADMAP.md), skipping\n`);
         }
       }
-    } catch {
-      // Non-fatal
+    } catch (e) {
+      logWarning("migration", `Orphaned summary check failed for ${mId}: ${(e as Error).message}`);
     }
   }
 
@@ -308,17 +309,18 @@ export function validateMigration(basePath: string): { discrepancies: string[] }
                 const planContent = readFileSync(planPath, "utf-8");
                 const plan = parsePlan(planContent);
                 mdTaskCount += plan.tasks.length;
-              } catch {
-                // Skip unreadable plan
+              } catch (e) {
+                logWarning("migration", `Failed to read plan ${slice.id}-PLAN.md: ${(e as Error).message}`);
               }
             }
           }
-        } catch {
-          // Skip unreadable roadmap
+        } catch (e) {
+          logWarning("migration", `Failed to read roadmap for ${mId}: ${(e as Error).message}`);
         }
       }
     }
-  } catch {
+  } catch (e) {
+    logWarning("migration", `Validation failed to read markdown: ${(e as Error).message}`);
     return { discrepancies: ["Failed to read markdown for validation"] };
   }
 

package/src/resources/extensions/gsd/workflow-projections.ts

@@ -423,7 +423,7 @@ export function regenerateIfMissing(
           renderSummaryProjection(basePath, milestoneId, sliceId, task.id);
           regenerated++;
         } catch (err) {
-          console.error(`[projections] regenerateIfMissing SUMMARY failed for ${task.id}:`, err);
+          logWarning("projection", `regenerateIfMissing SUMMARY failed for ${task.id}: ${(err as Error).message}`);
         }
       }
     }
@@ -452,7 +452,7 @@ export function regenerateIfMissing(
     }
     return true;
   } catch (err) {
-    console.error(`[projections] regenerateIfMissing ${fileType} failed:`, err);
+    logWarning("projection", `regenerateIfMissing ${fileType} failed: ${(err as Error).message}`);
     return false;
   }
 }

package/src/resources/extensions/gsd/workflow-reconcile.ts

@@ -455,8 +455,8 @@ function parseEventBlock(block: string): WorkflowEvent[] {
           if (paramsMatch) {
             try {
               params = JSON.parse(paramsMatch[1]!) as Record<string, unknown>;
-            } catch {
-              // Keep empty params on parse error
+            } catch (e) {
+              logWarning("reconcile", `tool call params parse failed: ${(e as Error).message}`);
             }
             i++; // consume params line
           }

package/src/resources/extensions/gsd/worktree-manager.ts

@@ -95,8 +95,8 @@ export function resolveGitDir(basePath: string): string {
     if (content.startsWith("gitdir: ")) {
       return resolve(basePath, content.slice(8));
     }
-  } catch {
-    // Not a file or unreadable — fall through to default
+  } catch (e) {
+    logWarning("worktree", `.git file read failed: ${(e as Error).message}`);
   }
   return join(basePath, ".git");
 }
@@ -308,8 +308,9 @@ export function findNestedGitDirs(rootPath: string): string[] {
     let entries: string[];
     try {
       entries = readdirSync(dir);
-    } catch {
-      return; // Permission denied, broken symlink, etc.
+    } catch (e) {
+      logWarning("worktree", `readdirSync failed: ${(e as Error).message}`);
+      return;
     }
 
     for (const entry of entries) {
@@ -321,7 +322,8 @@ export function findNestedGitDirs(rootPath: string): string[] {
       let stat;
       try {
         stat = lstatSync(fullPath);
-      } catch {
+      } catch (e) {
+        logWarning("worktree", `lstatSync failed for ${fullPath}: ${(e as Error).message}`);
         continue;
       }
       if (!stat.isDirectory()) continue;
@@ -337,8 +339,8 @@ export function findNestedGitDirs(rootPath: string): string[] {
           // Don't recurse into the nested repo — we found what we need
           continue;
         }
-      } catch {
-        // No .git here — continue scanning
+      } catch (e) {
+        logWarning("worktree", `existsSync/.git check failed for ${fullPath}: ${(e as Error).message}`);
       }
 
       walk(fullPath, depth + 1);
@@ -374,7 +376,7 @@ export function removeWorktree(
     if (entry?.path) {
       wtPath = entry.path;
     }
-  } catch { /* fall back to computed path */ }
+  } catch (e) { logWarning("worktree", `nativeWorktreeList parse failed: ${(e as Error).message}`); }
 
   const resolvedWtPath = existsSync(wtPath) ? realpathSync(wtPath) : wtPath;
 
@@ -388,7 +390,7 @@ export function removeWorktree(
   if (!existsSync(wtPath)) {
     nativeWorktreePrune(basePath);
     if (deleteBranch) {
-      try { nativeBranchDelete(basePath, branch, true); } catch { /* branch may not exist */ }
+      try { nativeBranchDelete(basePath, branch, true); } catch (e) { logWarning("worktree", `nativeBranchDelete failed: ${(e as Error).message}`); }
     }
     return;
   }
@@ -422,8 +424,8 @@ export function removeWorktree(
           logWarning("reconcile", `Submodule changes detected — stash failed, changes may be lost during force removal`, { worktree: name, path: resolvedWtPath });
         }
       }
-    } catch {
-      // submodule status failed — proceed with normal removal
+    } catch (e) {
+      logWarning("worktree", `submodule status check failed: ${(e as Error).message}`);
     }
   }
 
@@ -454,11 +456,11 @@ export function removeWorktree(
   // Remove worktree: try non-force first when submodules have changes,
   // falling back to force only after submodule state has been preserved.
   const useForce = hasSubmoduleChanges ? false : force;
-  try { nativeWorktreeRemove(basePath, resolvedWtPath, useForce); } catch { /* may fail */ }
+  try { nativeWorktreeRemove(basePath, resolvedWtPath, useForce); } catch (e) { logWarning("worktree", `nativeWorktreeRemove failed: ${(e as Error).message}`); }
 
   // If the directory is still there (e.g. locked), try harder with force
   if (existsSync(resolvedWtPath)) {
-    try { nativeWorktreeRemove(basePath, resolvedWtPath, true); } catch { /* may fail */ }
+    try { nativeWorktreeRemove(basePath, resolvedWtPath, true); } catch (e) { logWarning("worktree", `nativeWorktreeRemove (force) failed: ${(e as Error).message}`); }
   }
 
   // (#2821) If the worktree directory STILL exists after both native removal
@@ -488,7 +490,7 @@ export function removeWorktree(
   nativeWorktreePrune(basePath);
 
   if (deleteBranch) {
-    try { nativeBranchDelete(basePath, branch, true); } catch { /* branch may not exist */ }
+    try { nativeBranchDelete(basePath, branch, true); } catch (e) { logWarning("worktree", `final branch delete failed: ${(e as Error).message}`); }
   }
 }
 

package/src/resources/extensions/shared/interview-ui.ts

@@ -298,7 +298,9 @@ export async function showInterviewRound(
 			// Auto-open the notes field when "None of the above" is selected
 			// so the user can immediately provide a free-text explanation
 			// instead of being trapped in a re-asking loop (bug #2715).
-			if (!isMultiSelect(currentIdx) && states[currentIdx].cursorIndex === noneOrDoneIdx(currentIdx)) {
+			// Only auto-open if the user hasn't already provided notes —
+			// otherwise Enter from notes mode loops back here endlessly.
+			if (!isMultiSelect(currentIdx) && states[currentIdx].cursorIndex === noneOrDoneIdx(currentIdx) && !states[currentIdx].notes) {
 				states[currentIdx].notesVisible = true;
 				focusNotes = true;
 				loadStateToEditor();

package/src/resources/extensions/shared/tests/interview-notes-loop.test.ts

@@ -0,0 +1,144 @@
+// GSD2 — Regression test for interview-ui "None of the above" notes loop
+// Copyright (c) 2026 Jeremy McSpadden <jeremy@fluxlabs.net>
+
+/**
+ * Regression test for bug #3502:
+ *
+ * Selecting "None of the above" opens the notes field, but pressing Enter
+ * after typing a note called goNextOrSubmit() which saw the cursor still
+ * on the "None of the above" slot and re-opened notes — trapping the user
+ * in an infinite loop.
+ *
+ * The fix adds a `!states[currentIdx].notes` guard so auto-open only fires
+ * when notes are still empty.
+ */
+
+import { describe, it } from "node:test";
+import assert from "node:assert/strict";
+import { showInterviewRound, type Question, type RoundResult } from "../interview-ui.js";
+
+// Raw terminal sequences that matchesKey() recognises
+const ENTER = "\r";
+const DOWN = "\x1b[B";
+const TAB = "\t";
+
+/**
+ * Drive showInterviewRound with a scripted sequence of key inputs.
+ * We mock ctx.ui.custom() to capture the widget, feed it inputs, and
+ * resolve when done() is called.
+ */
+function runWithInputs(
+	questions: Question[],
+	inputs: string[],
+): Promise<RoundResult> {
+	return new Promise((resolve, reject) => {
+		const timeout = setTimeout(() => reject(new Error("Timed out — likely stuck in infinite loop")), 3000);
+
+		const mockCtx = {
+			ui: {
+				custom: (factory: any) => {
+					const mockTui = {
+						requestRender: () => {},
+					};
+					const mockTheme = {
+						// Minimal theme stubs — render output is not asserted
+						fg: (_c: string, t: string) => t,
+						bold: (t: string) => t,
+						dim: (t: string) => t,
+						italic: (t: string) => t,
+						strikethrough: (t: string) => t,
+						accent: (t: string) => t,
+						success: (t: string) => t,
+						warning: (t: string) => t,
+						error: (t: string) => t,
+						info: (t: string) => t,
+						muted: (t: string) => t,
+						dimmed: (t: string) => t,
+					};
+					const mockKb = {};
+
+					const widget = factory(mockTui, mockTheme, mockKb, (result: RoundResult) => {
+						clearTimeout(timeout);
+						resolve(result);
+					});
+
+					// Feed each input sequentially
+					for (const input of inputs) {
+						widget.handleInput(input);
+					}
+				},
+			},
+		};
+
+		showInterviewRound(questions, {}, mockCtx as any).catch(reject);
+	});
+}
+
+describe("interview-ui notes loop regression (#3502)", () => {
+	const questions: Question[] = [
+		{
+			id: "q1",
+			header: "Project Type",
+			question: "What type of project?",
+			options: [
+				{ label: "Web App", description: "Frontend or full-stack" },
+				{ label: "CLI Tool", description: "Command-line utility" },
+			],
+		},
+	];
+
+	it("does not loop when Enter is pressed after typing a note on 'None of the above'", async () => {
+		// With 2 options, "None of the above" is index 2 (0-based)
+		// Cursor starts at 0, so press Down twice to reach it
+		const result = await runWithInputs(questions, [
+			DOWN,        // cursor → index 1 (CLI Tool)
+			DOWN,        // cursor → index 2 (None of the above)
+			ENTER,       // commit → auto-opens notes field
+			"u", "n", "s", "u", "r", "e",  // type "unsure"
+			ENTER,       // should advance to review, NOT reopen notes
+			ENTER,       // submit from review screen
+		]);
+
+		// If we get here, the loop did not occur (timeout would have fired)
+		assert.ok(result, "should return a result");
+		assert.equal(result.endInterview, false);
+
+		const answer = result.answers.q1;
+		assert.ok(answer, "answer for q1 should exist");
+		assert.equal(answer.notes, "unsure", "notes should contain typed text");
+		assert.equal(answer.selected, "None of the above");
+	});
+
+	it("still auto-opens notes when selecting 'None of the above' with no prior notes", async () => {
+		// Press Down twice to "None of the above", Enter to select
+		// Then immediately Enter again (empty notes) — this should re-open notes
+		// because the guard only skips when notes are non-empty.
+		// Type something on second open, then Enter to proceed.
+		const result = await runWithInputs(questions, [
+			DOWN,        // cursor → 1
+			DOWN,        // cursor → 2 (None of the above)
+			ENTER,       // commit → auto-opens notes
+			ENTER,       // empty notes → goNextOrSubmit → should re-open notes (empty guard)
+			"o", "k",    // type "ok"
+			ENTER,       // now notes = "ok" → should advance to review
+			ENTER,       // submit
+		]);
+
+		assert.ok(result, "should return a result");
+		const answer = result.answers.q1;
+		assert.ok(answer, "answer for q1 should exist");
+		assert.equal(answer.notes, "ok");
+	});
+
+	it("normal option selection is unaffected", async () => {
+		const result = await runWithInputs(questions, [
+			ENTER,       // select first option (Web App) and advance to review
+			ENTER,       // submit from review screen
+		]);
+
+		assert.ok(result, "should return a result");
+		const answer = result.answers.q1;
+		assert.ok(answer, "answer for q1 should exist");
+		assert.equal(answer.selected, "Web App");
+	});
+});

package/src/resources/skills/btw/SKILL.md

@@ -0,0 +1,42 @@
+---
+name: btw
+description: Ask a quick side question about your current work without derailing the main task. Answers from existing conversation context only — no tool calls, no file reads, single concise response. Use when you need a fast answer from what is already in this session.
+---
+
+<objective>
+Answer a quick side question using only what is already present in the current conversation context. Do not read files, run commands, search, or use any tools. Give a single, concise response and return focus to the main work.
+</objective>
+
+<behavior>
+**This is a side question, not a task.**
+
+- Answer only from information already in the conversation (files read, decisions made, code seen, context established)
+- Do NOT use any tools — no Read, no Bash, no Grep, no Search
+- If the answer requires reading something new, say so briefly and suggest the user ask as a normal prompt instead
+- Keep the response short and direct — one to a few sentences unless the question genuinely needs more
+- Do not summarize the main work, ask follow-up questions, or offer to do anything else
+- After answering, stop — do not prompt for next steps
+</behavior>
+
+<quick_start>
+Parse the argument after `/btw` as the question. Answer it directly from context.
+
+If no argument is provided, ask: "What did you want to know?"
+
+If the question cannot be answered from current context (requires reading a file, running a command, or information not yet in the session), respond with:
+"I'd need to [read X / run Y / look up Z] to answer that — ask it as a normal prompt when you're ready."
+</quick_start>
+
+<examples>
+**Good uses of /btw:**
+- `/btw what was the name of that config file again?` → answers from files already read in session
+- `/btw which branch are we on?` → answers from git context already established
+- `/btw did we already handle the null case in that function?` → answers from code already reviewed
+- `/btw what model does this use?` → answers from code or config already in context
+
+**Not a good fit for /btw (suggest normal prompt):**
+- Questions requiring reading a file not yet seen
+- Questions requiring running a command
+- Questions needing a multi-step answer or follow-up
+- Starting a new task or changing direction
+</examples>

package/dist/web/standalone/.next/static/chunks/app/page-62be3b5fa91e4c8f.js

@@ -1 +0,0 @@
-(self.webpackChunk_N_E=self.webpackChunk_N_E||[]).push([[8974],{5214:(e,t,n)=>{"use strict";Object.defineProperty(t,"__esModule",{value:!0}),Object.defineProperty(t,"workAsyncStorage",{enumerable:!0,get:function(){return r.workAsyncStorageInstance}});let r=n(17828)},15726:(e,t,n)=>{Promise.resolve().then(n.bind(n,66919))},17828:(e,t,n)=>{"use strict";Object.defineProperty(t,"__esModule",{value:!0}),Object.defineProperty(t,"workAsyncStorageInstance",{enumerable:!0,get:function(){return r}});let r=(0,n(64054).createAsyncLocalStorage)()},21957:(e,t,n)=>{"use strict";function r({moduleIds:e}){return null}Object.defineProperty(t,"__esModule",{value:!0}),Object.defineProperty(t,"PreloadChunks",{enumerable:!0,get:function(){return r}}),n(95155),n(47650),n(5214),n(2451),n(53887)},37206:(e,t,n)=>{"use strict";n.d(t,{default:()=>u.a});var r=n(75707),u=n.n(r)},41112:(e,t,n)=>{"use strict";function r({reason:e,children:t}){return t}Object.defineProperty(t,"__esModule",{value:!0}),Object.defineProperty(t,"BailoutToCSR",{enumerable:!0,get:function(){return r}}),n(1980)},64054:(e,t)=>{"use strict";Object.defineProperty(t,"__esModule",{value:!0});var n={bindSnapshot:function(){return s},createAsyncLocalStorage:function(){return a},createSnapshot:function(){return i}};for(var r in n)Object.defineProperty(t,r,{enumerable:!0,get:n[r]});let u=Object.defineProperty(Error("Invariant: AsyncLocalStorage accessed in runtime where it is not available"),"__NEXT_ERROR_CODE",{value:"E504",enumerable:!1,configurable:!0});class l{disable(){throw u}getStore(){}run(){throw u}exit(){throw u}enterWith(){throw u}static bind(e){return e}}let o="u">typeof globalThis&&globalThis.AsyncLocalStorage;function a(){return o?new o:new l}function s(e){return o?o.bind(e):l.bind(e)}function i(){return o?o.snapshot():function(e,...t){return e(...t)}}},66919:(e,t,n)=>{"use strict";n.r(t),n.d(t,{default:()=>l});var r=n(95155);let u=(0,n(37206).default)(()=>Promise.all([n.e(1838),n.e(6079),n.e(4986),n.e(2008),n.e(6502)]).then(n.bind(n,46502)).then(e=>e.GSDAppShell),{loadableGenerated:{webpack:()=>[46502]},ssr:!1,loading:()=>(0,r.jsx)("div",{className:"flex h-screen items-center justify-center bg-background text-sm text-muted-foreground",children:"Loading workspace…"})});function l(){return(0,r.jsx)(u,{})}},68635:(e,t,n)=>{"use strict";Object.defineProperty(t,"__esModule",{value:!0}),Object.defineProperty(t,"default",{enumerable:!0,get:function(){return s}});let r=n(95155),u=n(12115),l=n(41112);function o(e){return{default:e&&"default"in e?e.default:e}}n(21957);let a={loader:()=>Promise.resolve(o(()=>null)),loading:null,ssr:!0},s=function(e){let t={...a,...e},n=(0,u.lazy)(()=>t.loader().then(o)),s=t.loading;function i(e){let o=s?(0,r.jsx)(s,{isLoading:!0,pastDelay:!0,error:null}):null,a=!t.ssr||!!t.loading,i=a?u.Suspense:u.Fragment,c=t.ssr?(0,r.jsxs)(r.Fragment,{children:[null,(0,r.jsx)(n,{...e})]}):(0,r.jsx)(l.BailoutToCSR,{reason:"next/dynamic",children:(0,r.jsx)(n,{...e})});return(0,r.jsx)(i,{...a?{fallback:o}:{},children:c})}return i.displayName="LoadableComponent",i}},75707:(e,t,n)=>{"use strict";Object.defineProperty(t,"__esModule",{value:!0}),Object.defineProperty(t,"default",{enumerable:!0,get:function(){return u}});let r=n(73623)._(n(68635));function u(e,t){let n={};"function"==typeof e&&(n.loader=e);let u={...n,...t};return(0,r.default)({...u,modules:u.loadableGenerated?.modules})}("function"==typeof t.default||"object"==typeof t.default&&null!==t.default)&&void 0===t.default.__esModule&&(Object.defineProperty(t.default,"__esModule",{value:!0}),Object.assign(t.default,t),e.exports=t.default)}},e=>{e.O(0,[8441,3794,7358],()=>e(e.s=15726)),_N_E=e.O()}]);

package/dist/web/standalone/.next/static/chunks/main-app-d3d4c336195465f9.js

@@ -1 +0,0 @@
-(self.webpackChunk_N_E=self.webpackChunk_N_E||[]).push([[7358],{2852:(e,s,n)=>{Promise.resolve().then(n.t.bind(n,27123,23)),Promise.resolve().then(n.t.bind(n,61304,23)),Promise.resolve().then(n.t.bind(n,78616,23)),Promise.resolve().then(n.t.bind(n,64777,23)),Promise.resolve().then(n.t.bind(n,57121,23)),Promise.resolve().then(n.t.bind(n,74581,23)),Promise.resolve().then(n.t.bind(n,90484,23)),Promise.resolve().then(n.bind(n,86869))},19393:()=>{}},e=>{var s=s=>e(e.s=s);e.O(0,[8441,3794],()=>(s(83861),s(2852))),_N_E=e.O()}]);

package/dist/web/standalone/.next/static/chunks/next/dist/client/components/builtin/global-error-ab5a8926e07ec673.js

@@ -1 +0,0 @@
-(self.webpackChunk_N_E=self.webpackChunk_N_E||[]).push([[9337],{52560:(e,s,_)=>{Promise.resolve().then(_.t.bind(_,27123,23))}},e=>{e.O(0,[8441,3794,7358],()=>e(e.s=52560)),_N_E=e.O()}]);