gsd-pi 2.58.0-dev.d63175c → 2.58.0-dev.e002a57

package/src/resources/extensions/ollama/tests/model-capabilities.test.ts

@@ -0,0 +1,162 @@
+// GSD2 — Tests for Ollama model capability detection
+import { describe, it } from "node:test";
+import assert from "node:assert/strict";
+import {
+	getModelCapabilities,
+	estimateContextFromParams,
+	humanizeModelName,
+	formatModelSize,
+} from "../model-capabilities.js";
+
+// ─── getModelCapabilities ────────────────────────────────────────────────────
+
+describe("getModelCapabilities", () => {
+	it("returns reasoning for deepseek-r1 models", () => {
+		const caps = getModelCapabilities("deepseek-r1:8b");
+		assert.equal(caps.reasoning, true);
+		assert.equal(caps.contextWindow, 131072);
+	});
+
+	it("returns reasoning for qwq models", () => {
+		const caps = getModelCapabilities("qwq:32b");
+		assert.equal(caps.reasoning, true);
+	});
+
+	it("returns vision for llava models", () => {
+		const caps = getModelCapabilities("llava:7b");
+		assert.deepEqual(caps.input, ["text", "image"]);
+	});
+
+	it("returns vision for llama3.2-vision models", () => {
+		const caps = getModelCapabilities("llama3.2-vision:11b");
+		assert.deepEqual(caps.input, ["text", "image"]);
+	});
+
+	it("returns correct context for llama3.1", () => {
+		const caps = getModelCapabilities("llama3.1:8b");
+		assert.equal(caps.contextWindow, 131072);
+	});
+
+	it("returns correct context for llama3 (no .1)", () => {
+		const caps = getModelCapabilities("llama3:8b");
+		assert.equal(caps.contextWindow, 8192);
+	});
+
+	it("returns correct context for llama2", () => {
+		const caps = getModelCapabilities("llama2:7b");
+		assert.equal(caps.contextWindow, 4096);
+	});
+
+	it("returns correct context for qwen2.5-coder", () => {
+		const caps = getModelCapabilities("qwen2.5-coder:7b");
+		assert.equal(caps.contextWindow, 131072);
+		assert.equal(caps.maxTokens, 32768);
+	});
+
+	it("returns correct context for codestral", () => {
+		const caps = getModelCapabilities("codestral:22b");
+		assert.equal(caps.contextWindow, 262144);
+	});
+
+	it("returns correct context for mistral-nemo", () => {
+		const caps = getModelCapabilities("mistral-nemo:12b");
+		assert.equal(caps.contextWindow, 131072);
+	});
+
+	it("returns correct context for gemma3", () => {
+		const caps = getModelCapabilities("gemma3:9b");
+		assert.equal(caps.contextWindow, 131072);
+	});
+
+	it("returns empty object for unknown models", () => {
+		const caps = getModelCapabilities("totally-unknown-model:3b");
+		assert.deepEqual(caps, {});
+	});
+
+	it("strips tag before matching", () => {
+		const caps = getModelCapabilities("llama3.1:70b-instruct-q4_0");
+		assert.equal(caps.contextWindow, 131072);
+	});
+
+	it("matches case-insensitively", () => {
+		const caps = getModelCapabilities("Llama3.1:8B");
+		assert.equal(caps.contextWindow, 131072);
+	});
+});
+
+// ─── estimateContextFromParams ───────────────────────────────────────────────
+
+describe("estimateContextFromParams", () => {
+	it("estimates 8192 for small models", () => {
+		assert.equal(estimateContextFromParams("1.5B"), 8192);
+	});
+
+	it("estimates 16384 for 7B models", () => {
+		assert.equal(estimateContextFromParams("7B"), 16384);
+	});
+
+	it("estimates 32768 for 13B models", () => {
+		assert.equal(estimateContextFromParams("13B"), 32768);
+	});
+
+	it("estimates 65536 for 34B models", () => {
+		assert.equal(estimateContextFromParams("34B"), 65536);
+	});
+
+	it("estimates 131072 for 70B+ models", () => {
+		assert.equal(estimateContextFromParams("70B"), 131072);
+	});
+
+	it("handles decimal sizes", () => {
+		assert.equal(estimateContextFromParams("7.5B"), 16384);
+	});
+
+	it("handles M (millions)", () => {
+		assert.equal(estimateContextFromParams("500M"), 8192);
+	});
+
+	it("returns 8192 for unparseable input", () => {
+		assert.equal(estimateContextFromParams("unknown"), 8192);
+	});
+
+	it("returns 8192 for empty string", () => {
+		assert.equal(estimateContextFromParams(""), 8192);
+	});
+});
+
+// ─── humanizeModelName ───────────────────────────────────────────────────────
+
+describe("humanizeModelName", () => {
+	it("capitalizes and adds tag", () => {
+		assert.equal(humanizeModelName("llama3.1:8b"), "Llama 3.1 8B");
+	});
+
+	it("handles latest tag", () => {
+		assert.equal(humanizeModelName("llama3.1:latest"), "Llama 3.1");
+	});
+
+	it("handles no tag", () => {
+		assert.equal(humanizeModelName("llama3.1"), "Llama 3.1");
+	});
+
+	it("handles hyphenated names", () => {
+		const result = humanizeModelName("deepseek-r1:8b");
+		assert.ok(result.includes("8B"));
+	});
+});
+
+// ─── formatModelSize ─────────────────────────────────────────────────────────
+
+describe("formatModelSize", () => {
+	it("formats GB", () => {
+		assert.equal(formatModelSize(4_700_000_000), "4.7 GB");
+	});
+
+	it("formats MB", () => {
+		assert.equal(formatModelSize(500_000_000), "500.0 MB");
+	});
+
+	it("formats KB", () => {
+		assert.equal(formatModelSize(500_000), "500 KB");
+	});
+});

package/src/resources/extensions/ollama/tests/ollama-client.test.ts

@@ -0,0 +1,38 @@
+// GSD2 — Tests for Ollama HTTP client
+import { describe, it, beforeEach, afterEach } from "node:test";
+import assert from "node:assert/strict";
+import { getOllamaHost } from "../ollama-client.js";
+
+// ─── getOllamaHost ──────────────────────────────────────────────────────────
+
+describe("getOllamaHost", () => {
+	const originalHost = process.env.OLLAMA_HOST;
+
+	afterEach(() => {
+		if (originalHost === undefined) {
+			delete process.env.OLLAMA_HOST;
+		} else {
+			process.env.OLLAMA_HOST = originalHost;
+		}
+	});
+
+	it("returns default when OLLAMA_HOST is not set", () => {
+		delete process.env.OLLAMA_HOST;
+		assert.equal(getOllamaHost(), "http://localhost:11434");
+	});
+
+	it("returns OLLAMA_HOST when set with scheme", () => {
+		process.env.OLLAMA_HOST = "http://myhost:12345";
+		assert.equal(getOllamaHost(), "http://myhost:12345");
+	});
+
+	it("adds http:// when OLLAMA_HOST has no scheme", () => {
+		process.env.OLLAMA_HOST = "myhost:12345";
+		assert.equal(getOllamaHost(), "http://myhost:12345");
+	});
+
+	it("preserves https:// scheme", () => {
+		process.env.OLLAMA_HOST = "https://secure-ollama.example.com";
+		assert.equal(getOllamaHost(), "https://secure-ollama.example.com");
+	});
+});

package/src/resources/extensions/ollama/tests/ollama-discovery.test.ts

@@ -0,0 +1,28 @@
+// GSD2 — Tests for Ollama model discovery and enrichment
+import { describe, it, afterEach } from "node:test";
+import assert from "node:assert/strict";
+import { getOllamaOpenAIBaseUrl } from "../ollama-discovery.js";
+
+// ─── getOllamaOpenAIBaseUrl ─────────────────────────────────────────────────
+
+describe("getOllamaOpenAIBaseUrl", () => {
+	const originalHost = process.env.OLLAMA_HOST;
+
+	afterEach(() => {
+		if (originalHost === undefined) {
+			delete process.env.OLLAMA_HOST;
+		} else {
+			process.env.OLLAMA_HOST = originalHost;
+		}
+	});
+
+	it("returns default OpenAI-compat URL", () => {
+		delete process.env.OLLAMA_HOST;
+		assert.equal(getOllamaOpenAIBaseUrl(), "http://localhost:11434/v1");
+	});
+
+	it("appends /v1 to custom OLLAMA_HOST", () => {
+		process.env.OLLAMA_HOST = "http://remote:9999";
+		assert.equal(getOllamaOpenAIBaseUrl(), "http://remote:9999/v1");
+	});
+});

package/src/resources/extensions/ollama/types.ts

@@ -0,0 +1,130 @@
+// GSD2 — Ollama API response types
+
+/**
+ * Type definitions for the Ollama REST API.
+ * Reference: https://github.com/ollama/ollama/blob/main/docs/api.md
+ */
+
+// ─── /api/tags ──────────────────────────────────────────────────────────────
+
+export interface OllamaModelDetails {
+	parent_model: string;
+	format: string;
+	family: string;
+	families: string[] | null;
+	parameter_size: string;
+	quantization_level: string;
+}
+
+export interface OllamaModelInfo {
+	name: string;
+	model: string;
+	modified_at: string;
+	size: number;
+	digest: string;
+	details: OllamaModelDetails;
+}
+
+export interface OllamaTagsResponse {
+	models: OllamaModelInfo[];
+}
+
+// ─── /api/show ──────────────────────────────────────────────────────────────
+
+export interface OllamaShowResponse {
+	modelfile: string;
+	parameters: string;
+	template: string;
+	details: OllamaModelDetails;
+	model_info: Record<string, unknown>;
+}
+
+// ─── /api/ps ────────────────────────────────────────────────────────────────
+
+export interface OllamaRunningModel {
+	name: string;
+	model: string;
+	size: number;
+	digest: string;
+	details: OllamaModelDetails;
+	expires_at: string;
+	size_vram: number;
+}
+
+export interface OllamaPsResponse {
+	models: OllamaRunningModel[];
+}
+
+// ─── /api/pull ──────────────────────────────────────────────────────────────
+
+export interface OllamaPullProgress {
+	status: string;
+	digest?: string;
+	total?: number;
+	completed?: number;
+}
+
+// ─── /api/version ───────────────────────────────────────────────────────────
+
+export interface OllamaVersionResponse {
+	version: string;
+}
+
+// ─── /api/chat ──────────────────────────────────────────────────────────────
+
+export interface OllamaChatMessage {
+	role: "system" | "user" | "assistant" | "tool";
+	content: string;
+	images?: string[];
+	tool_calls?: OllamaToolCall[];
+}
+
+export interface OllamaToolCall {
+	function: {
+		name: string;
+		arguments: Record<string, unknown>;
+	};
+}
+
+export interface OllamaTool {
+	type: "function";
+	function: {
+		name: string;
+		description: string;
+		parameters: {
+			type: "object";
+			required?: string[];
+			properties: Record<string, unknown>;
+		};
+	};
+}
+
+export interface OllamaChatRequest {
+	model: string;
+	messages: OllamaChatMessage[];
+	stream?: boolean;
+	tools?: OllamaTool[];
+	options?: {
+		num_ctx?: number;
+		num_predict?: number;
+		temperature?: number;
+		top_p?: number;
+		top_k?: number;
+		stop?: string[];
+	};
+	keep_alive?: string;
+}
+
+export interface OllamaChatResponse {
+	model: string;
+	created_at: string;
+	message: OllamaChatMessage;
+	done: boolean;
+	done_reason?: string;
+	total_duration?: number;
+	load_duration?: number;
+	prompt_eval_count?: number;
+	prompt_eval_duration?: number;
+	eval_count?: number;
+	eval_duration?: number;
+}

package/src/resources/extensions/search-the-web/extension-manifest.json

@@ -8,6 +8,6 @@
   "provides": {
     "tools": ["search-the-web", "fetch_page", "search_and_read", "web_search"],
     "commands": ["search-provider"],
-    "hooks": ["model_select", "before_provider_request"]
+    "hooks": ["session_start", "model_select", "before_provider_request"]
   }
 }

package/src/resources/extensions/search-the-web/url-utils.ts

@@ -21,11 +21,30 @@ const PRIVATE_IP_PATTERNS = [
   /^fe80:/i,
 ];
 
+/**
+ * Hostnames exempted from SSRF blocking. Set via setFetchAllowedUrls()
+ * from global settings.json or GSD_FETCH_ALLOWED_URLS env var.
+ */
+let fetchAllowedHostnames: Set<string> = new Set();
+
+/**
+ * Replace the fetch URL allowlist (hostnames exempted from SSRF checks).
+ */
+export function setFetchAllowedUrls(hostnames: string[]): void {
+  fetchAllowedHostnames = new Set(hostnames.map((h) => h.toLowerCase()));
+}
+
+/** Get the currently active fetch URL allowlist. */
+export function getFetchAllowedUrls(): readonly string[] {
+  return [...fetchAllowedHostnames];
+}
+
 export function isBlockedUrl(url: string): boolean {
   try {
     const parsed = new URL(url);
     if (parsed.protocol !== "https:" && parsed.protocol !== "http:") return true;
     const hostname = parsed.hostname.toLowerCase();
+    if (fetchAllowedHostnames.has(hostname)) return false;
     if (BLOCKED_HOSTNAMES.has(hostname)) return true;
     for (const pattern of PRIVATE_IP_PATTERNS) {
       if (pattern.test(hostname)) return true;

package/src/resources/extensions/shared/interview-ui.ts

@@ -105,7 +105,7 @@ export interface WrapUpOptions {
 // ─── Constants ────────────────────────────────────────────────────────────────
 
 const OTHER_OPTION_LABEL = "None of the above";
-const OTHER_OPTION_DESCRIPTION = "Press TAB to add optional notes.";
+const OTHER_OPTION_DESCRIPTION = "Select to type your own answer.";
 
 // ─── Wrap-up screen ───────────────────────────────────────────────────────────
 
@@ -295,6 +295,17 @@ export async function showInterviewRound(
 				states[currentIdx].committedIndex = states[currentIdx].cursorIndex;
 			}
 
+			// Auto-open the notes field when "None of the above" is selected
+			// so the user can immediately provide a free-text explanation
+			// instead of being trapped in a re-asking loop (bug #2715).
+			if (!isMultiSelect(currentIdx) && states[currentIdx].cursorIndex === noneOrDoneIdx(currentIdx)) {
+				states[currentIdx].notesVisible = true;
+				focusNotes = true;
+				loadStateToEditor();
+				refresh();
+				return;
+			}
+
 			if (isMultiQuestion && currentIdx < questions.length - 1) {
 				let next = currentIdx + 1;
 				for (let i = 0; i < questions.length; i++) {

package/src/resources/extensions/shared/tests/ask-user-freetext.test.ts

@@ -0,0 +1,156 @@
+/**
+ * Tests for ask-user-questions free-text input behavior.
+ *
+ * Bug #2715: The ask-user-questions UI lacks free-text input and can trap
+ * users in a loop when the agent needs an explanation rather than a fixed
+ * choice.
+ *
+ * These tests exercise the RPC fallback path (ctx.ui.select) in
+ * ask-user-questions.ts to ensure that selecting "None of the above"
+ * triggers a follow-up free-text input prompt via ctx.ui.input().
+ */
+
+import { describe, it } from "node:test";
+import assert from "node:assert/strict";
+
+// The ask-user-questions extension registers a tool via pi.registerTool().
+// We capture that registration and call execute() directly with a mock context.
+import AskUserQuestions from "../../ask-user-questions.js";
+
+interface CapturedTool {
+	name: string;
+	execute: (...args: any[]) => Promise<any>;
+}
+
+function captureTool(): CapturedTool {
+	let captured: CapturedTool | null = null;
+	const fakePi = {
+		registerTool(tool: any) {
+			captured = { name: tool.name, execute: tool.execute };
+		},
+	};
+	AskUserQuestions(fakePi as any);
+	if (!captured) throw new Error("No tool registered");
+	return captured;
+}
+
+function makeQuestion(id: string, options: string[]) {
+	return {
+		id,
+		header: id,
+		question: `Pick for ${id}`,
+		options: options.map((label) => ({ label, description: `Desc for ${label}` })),
+	};
+}
+
+function makeMockCtx(opts: {
+	selectReturns: (string | string[] | undefined)[];
+	inputReturns?: (string | undefined)[];
+}) {
+	let selectCallIdx = 0;
+	let inputCallIdx = 0;
+	const selectCalls: { title: string; options: string[] }[] = [];
+	const inputCalls: { title: string; placeholder?: string }[] = [];
+
+	return {
+		ctx: {
+			hasUI: true,
+			ui: {
+				custom: () => undefined, // force RPC fallback
+				select: async (title: string, options: string[], selectOpts?: any) => {
+					selectCalls.push({ title, options });
+					return opts.selectReturns[selectCallIdx++];
+				},
+				input: async (title: string, placeholder?: string) => {
+					inputCalls.push({ title, placeholder });
+					return (opts.inputReturns ?? [])[inputCallIdx++];
+				},
+			},
+		},
+		selectCalls,
+		inputCalls,
+	};
+}
+
+describe("ask-user-questions RPC fallback free-text", () => {
+	it("prompts for free-text input when user selects 'None of the above'", async () => {
+		const tool = captureTool();
+		const { ctx, selectCalls, inputCalls } = makeMockCtx({
+			selectReturns: ["None of the above"],
+			inputReturns: ["I need to explain my reasoning"],
+		});
+
+		const params = {
+			questions: [makeQuestion("q1", ["Option A", "Option B"])],
+		};
+
+		const result = await tool.execute("call-1", params, undefined, undefined, ctx);
+
+		// The select should have been called with "None of the above" appended
+		assert.equal(selectCalls.length, 1);
+		assert.ok(
+			selectCalls[0].options.includes("None of the above"),
+			"select options should include 'None of the above'",
+		);
+
+		// A follow-up input() call should have been made to collect free text
+		assert.equal(inputCalls.length, 1, "should call ctx.ui.input() for free-text after 'None of the above'");
+
+		// The result should include the user's free-text note
+		const text = result.content[0]?.text;
+		assert.ok(text, "result should have text content");
+		const parsed = JSON.parse(text);
+		assert.ok(
+			parsed.answers.q1,
+			"answer for q1 should exist",
+		);
+		const q1Answers = parsed.answers.q1.answers;
+		assert.ok(
+			q1Answers.some((a: string) => a.includes("I need to explain my reasoning")),
+			"answer should include the free-text explanation",
+		);
+	});
+
+	it("does NOT prompt for free-text when user selects a normal option", async () => {
+		const tool = captureTool();
+		const { ctx, inputCalls } = makeMockCtx({
+			selectReturns: ["Option A"],
+		});
+
+		const params = {
+			questions: [makeQuestion("q1", ["Option A", "Option B"])],
+		};
+
+		const result = await tool.execute("call-2", params, undefined, undefined, ctx);
+
+		// No input() call should have been made
+		assert.equal(inputCalls.length, 0, "should NOT call ctx.ui.input() for a normal option");
+
+		const text = result.content[0]?.text;
+		const parsed = JSON.parse(text);
+		assert.deepStrictEqual(parsed.answers.q1.answers, ["Option A"]);
+	});
+
+	it("handles cancelled free-text input gracefully", async () => {
+		const tool = captureTool();
+		const { ctx, inputCalls } = makeMockCtx({
+			selectReturns: ["None of the above"],
+			inputReturns: [undefined], // user cancelled the input
+		});
+
+		const params = {
+			questions: [makeQuestion("q1", ["Option A", "Option B"])],
+		};
+
+		const result = await tool.execute("call-3", params, undefined, undefined, ctx);
+
+		// Input should still have been called
+		assert.equal(inputCalls.length, 1, "should call ctx.ui.input() even if user cancels");
+
+		// Result should still contain "None of the above" without a note
+		const text = result.content[0]?.text;
+		assert.ok(text, "result should have text content");
+		const parsed = JSON.parse(text);
+		assert.deepStrictEqual(parsed.answers.q1.answers, ["None of the above"]);
+	});
+});

package/src/resources/skills/create-gsd-extension/SKILL.md

@@ -7,9 +7,11 @@ description: Create, debug, and iterate on GSD extensions (TypeScript modules th
 
 **Extensions are TypeScript modules** that hook into GSD's runtime (built on pi). They export a default function receiving `ExtensionAPI` and use it to subscribe to events, register tools/commands/shortcuts, and interact with the session.
 
-**GSD extension paths:**
-- Global extensions: `~/.gsd/agent/extensions/*.ts` or `~/.gsd/agent/extensions/*/index.ts`
-- Project-local extensions: `.gsd/extensions/*.ts` or `.gsd/extensions/*/index.ts`
+**GSD extension paths (community/user-installed extensions):**
+- Global: `~/.pi/agent/extensions/*.ts` or `~/.pi/agent/extensions/*/index.ts`
+- Project-local: `.gsd/extensions/*.ts` or `.gsd/extensions/*/index.ts`
+
+Note: `~/.gsd/agent/extensions/` is reserved for bundled extensions synced from the gsd-pi package. Community extensions placed there are silently ignored by the loader.
 
 **The three primitives:**
 1. **Events** — Listen and react (`pi.on("event", handler)`). Can block tool calls, modify messages, inject context.

package/src/resources/skills/create-gsd-extension/references/key-rules-gotchas.md

@@ -26,11 +26,12 @@ Non-negotiable rules and common gotchas when building GSD extensions.
 </common_patterns>
 
 <gsd_paths>
-**GSD extension paths:**
-- Global: `~/.gsd/agent/extensions/*.ts`
-- Global (subdir): `~/.gsd/agent/extensions/*/index.ts`
+**GSD extension paths (community/user-installed extensions):**
+- Global: `~/.pi/agent/extensions/*.ts`
+- Global (subdir): `~/.pi/agent/extensions/*/index.ts`
 - Project-local: `.gsd/extensions/*.ts`
 - Project-local (subdir): `.gsd/extensions/*/index.ts`
 
-The upstream pi docs reference `~/.pi` paths — GSD uses `~/.gsd` everywhere instead.
+Note: `~/.gsd/agent/extensions/` is reserved for bundled extensions synced from the gsd-pi package.
+Community extensions placed there are silently ignored by the loader.
 </gsd_paths>

package/src/resources/skills/create-gsd-extension/workflows/add-capability.md

@@ -14,7 +14,7 @@ Read the reference file for the specific capability being added:
 ## Step 1: Identify the Extension
 
 Locate the existing extension file. Check:
-- `~/.gsd/agent/extensions/` (global)
+- `~/.pi/agent/extensions/` (global community extensions)
 - `.gsd/extensions/` (project-local)
 
 Read the current extension code to understand its structure.
@@ -28,7 +28,7 @@ If the extension needs new imports, add them at the top of the file.
 ## Step 3: Handle Structural Changes
 
 **Single file → Directory**: If the extension is outgrowing a single file:
-1. Create `~/.gsd/agent/extensions/my-extension/`
+1. Create `~/.pi/agent/extensions/my-extension/`
 2. Move the file to `index.ts`
 3. Extract helpers to separate files
 

package/src/resources/skills/create-gsd-extension/workflows/create-extension.md

@@ -12,7 +12,7 @@
 ## Step 1: Determine Scope and Placement
 
 Ask the user:
-- **Global** (`~/.gsd/agent/extensions/`) — Available in all GSD sessions
+- **Global** (`~/.pi/agent/extensions/`) — Available in all GSD sessions
 - **Project-local** (`.gsd/extensions/`) — Available only in this project
 
 ## Step 2: Determine Extension Capabilities
@@ -36,12 +36,12 @@ Identify what the extension needs from the user's description:
 
 **Single file** — for small extensions (1-2 tools/commands, simple hooks):
 ```
-~/.gsd/agent/extensions/my-extension.ts
+~/.pi/agent/extensions/my-extension.ts
 ```
 
 **Directory with index.ts** — for multi-file extensions:
 ```
-~/.gsd/agent/extensions/my-extension/
+~/.pi/agent/extensions/my-extension/
 ├── index.ts
 ├── tools.ts
 └── utils.ts
@@ -49,7 +49,7 @@ Identify what the extension needs from the user's description:
 
 **Package with dependencies** — when npm packages are needed:
 ```
-~/.gsd/agent/extensions/my-extension/
+~/.pi/agent/extensions/my-extension/
 ├── package.json
 ├── src/index.ts
 └── node_modules/