gsd-pi 2.57.0-dev.f22a903 → 2.57.0

package/src/resources/extensions/gsd/preferences.ts

@@ -22,7 +22,6 @@ import { normalizeStringArray } from "../shared/format-utils.js";
 import { resolveProfileDefaults as _resolveProfileDefaults } from "./preferences-models.js";
 
 import {
-  KNOWN_PREFERENCE_KEYS,
   MODE_DEFAULTS,
   type WorkflowMode,
   type GSDPreferences,
@@ -251,7 +250,7 @@ function parseFrontmatterBlock(frontmatter: string): GSDPreferences {
  *   - planner: sonnet
  */
 function parseHeadingListFormat(content: string): GSDPreferences {
-  const result: Record<string, string[]> = {};
+  const result: Record<string, Record<string, string>> = {};
   let currentSection: string | null = null;
 
   for (const rawLine of content.split('\n')) {
@@ -259,44 +258,27 @@ function parseHeadingListFormat(content: string): GSDPreferences {
     const headingMatch = line.match(/^##\s+(.+)$/);
     if (headingMatch) {
       currentSection = headingMatch[1].trim().toLowerCase().replace(/\s+/g, '_');
-      if (!result[currentSection]) result[currentSection] = [];
       continue;
     }
-    if (currentSection && line.trim() && !line.trimStart().startsWith('#')) {
-      result[currentSection].push(line);
+    if (currentSection) {
+      const itemMatch = line.match(/^-\s+([^:]+):\s*(.*)$/);
+      if (itemMatch) {
+        if (!result[currentSection]) result[currentSection] = {};
+        const value = itemMatch[2].trim();
+        // Coerce "true"/"false" strings and numbers
+        result[currentSection][itemMatch[1].trim()] = value;
+      }
     }
   }
 
+  // Convert string values to appropriate types via YAML parser for each section
   const typed: Record<string, unknown> = {};
-  for (const [section, lines] of Object.entries(result)) {
-    if (lines.length === 0) continue;
-
-    const usesLegacyListItems = lines.every((line) => /^\s*-\s+[^:]+:\s*.*$/.test(line));
-    const yamlBlock = usesLegacyListItems
-      ? lines.map((line) => line.replace(/^\s*-\s+/, '')).join('\n')
-      : lines.join('\n');
-
+  for (const [section, entries] of Object.entries(result)) {
+    const yamlLines = Object.entries(entries).map(([k, v]) => `${k}: ${v}`).join('\n');
     try {
-      const parsed = parseYaml(yamlBlock);
-      if (typeof parsed !== 'object' || parsed === null) continue;
-
-      let targetSection = section;
-      let value: unknown = parsed;
-
-      if (!Array.isArray(parsed)) {
-        const keys = Object.keys(parsed);
-        if (keys.length === 1) {
-          const [onlyKey] = keys;
-          if (onlyKey === section || (!KNOWN_PREFERENCE_KEYS.has(section) && KNOWN_PREFERENCE_KEYS.has(onlyKey))) {
-            targetSection = onlyKey;
-            value = (parsed as Record<string, unknown>)[onlyKey];
-          }
-        }
-      }
-
-      typed[targetSection] = value;
+      typed[section] = parseYaml(yamlLines);
     } catch {
-      /* malformed section — skip */
+      typed[section] = entries;
     }
   }
 

package/src/resources/extensions/gsd/prompts/validate-milestone.md

@@ -26,7 +26,7 @@ All relevant context has been preloaded below — the roadmap, all slice summari
 4. Check **requirement coverage** — are all active requirements addressed by at least one slice?
 5. If **Verification Classes** are provided in the inlined context above, check each non-empty class:
    - For each verification class (Contract, Integration, Operational, UAT), determine whether slice summaries, UAT results, or observable behavior provide evidence that this verification tier was addressed.
-   - Document the compliance status of each class in a dedicated verification classes section.
+   - Document the compliance status of each class in your verdict rationale.
    - If `Operational` verification is non-empty and no evidence of operational verification exists, flag this explicitly — it means planned operational checks (migrations, deployments, runtime verification) were not proven.
    - A milestone with unaddressed verification classes may still pass if the gaps are minor, but the gaps MUST be documented in the Deferred Work Inventory.
 6. Determine a verdict:
@@ -36,7 +36,7 @@ All relevant context has been preloaded below — the roadmap, all slice summari
 
 ## Persist Validation
 
-**Persist validation results through `gsd_validate_milestone`.** Call it with: `milestoneId`, `verdict`, `remediationRound`, `successCriteriaChecklist`, `sliceDeliveryAudit`, `crossSliceIntegration`, `requirementCoverage`, `verificationClasses` (when non-empty), `verdictRationale`, and `remediationPlan` (if verdict is `needs-remediation`). The tool writes the validation to the DB and renders VALIDATION.md to disk.
+**Persist validation results through `gsd_validate_milestone`.** Call it with: `milestoneId`, `verdict`, `remediationRound`, `successCriteriaChecklist`, `sliceDeliveryAudit`, `crossSliceIntegration`, `requirementCoverage`, `verdictRationale`, and `remediationPlan` (if verdict is `needs-remediation`). The tool writes the validation to the DB and renders VALIDATION.md to disk.
 
 If verdict is `needs-remediation`:
 - After calling `gsd_validate_milestone`, use `gsd_reassess_roadmap` to add remediation slices. Pass `milestoneId`, a synthetic `completedSliceId` (e.g. "VALIDATION"), `verdict: "roadmap-adjusted"`, `assessment` text, and `sliceChanges` with the new slices in the `added` array. The tool persists the changes to the DB and re-renders ROADMAP.md.

package/src/resources/extensions/gsd/tests/dispatch-guard.test.ts

@@ -216,50 +216,3 @@ test("dispatch guard works without git repo", (t) => {
 
   assert.equal(getPriorSliceCompletionBlocker(repo, "main", "plan-slice", "M001/S02"), null);
 });
-
-test("dispatch guard skips cross-milestone check when GSD_MILESTONE_LOCK is set (#2797)", (t) => {
-  const repo = setupRepo();
-  t.after(() => {
-    delete process.env.GSD_MILESTONE_LOCK;
-    teardownRepo(repo);
-  });
-
-  mkdirSync(join(repo, ".gsd", "milestones", "M010"), { recursive: true });
-  mkdirSync(join(repo, ".gsd", "milestones", "M011"), { recursive: true });
-  mkdirSync(join(repo, ".gsd", "milestones", "M012"), { recursive: true });
-
-  // M010 and M011 have incomplete slices
-  insertMilestone({ id: "M010", title: "Analytics" });
-  insertSlice({ id: "S01", milestoneId: "M010", title: "Data Quality", status: "pending", depends: [], sequence: 1 });
-
-  insertMilestone({ id: "M011", title: "Builder Onboarding" });
-  insertSlice({ id: "S01", milestoneId: "M011", title: "Schema", status: "pending", depends: [], sequence: 1 });
-
-  insertMilestone({ id: "M012", title: "Shared Components" });
-  insertSlice({ id: "S01", milestoneId: "M012", title: "Foundation", status: "pending", depends: [], sequence: 1 });
-  insertSlice({ id: "S02", milestoneId: "M012", title: "Migrate Pages", status: "pending", depends: ["S01"], sequence: 2 });
-
-  writeFileSync(join(repo, ".gsd", "milestones", "M010", "M010-ROADMAP.md"), "# M010\n");
-  writeFileSync(join(repo, ".gsd", "milestones", "M011", "M011-ROADMAP.md"), "# M011\n");
-  writeFileSync(join(repo, ".gsd", "milestones", "M012", "M012-ROADMAP.md"), "# M012\n");
-
-  // Without lock: M012 blocked by M010's incomplete S01
-  delete process.env.GSD_MILESTONE_LOCK;
-  assert.match(
-    getPriorSliceCompletionBlocker(repo, "main", "execute-task", "M012/S01/T01") ?? "",
-    /earlier slice M010\/S01 is not complete/,
-  );
-
-  // With lock: M012 only checks its own intra-milestone deps — S01 has none, so unblocked
-  process.env.GSD_MILESTONE_LOCK = "M012";
-  assert.equal(
-    getPriorSliceCompletionBlocker(repo, "main", "execute-task", "M012/S01/T01"),
-    null,
-  );
-
-  // With lock: M012/S02 still blocked by M012/S01 (intra-milestone dep preserved)
-  assert.equal(
-    getPriorSliceCompletionBlocker(repo, "main", "execute-task", "M012/S02/T01"),
-    "Cannot dispatch execute-task M012/S02/T01: dependency slice M012/S01 is not complete.",
-  );
-});

package/src/resources/extensions/gsd/tests/parallel-worker-monitoring.test.ts

@@ -131,15 +131,14 @@ describe("parallel-worker-monitoring", () => {
     assert.ok(!(5.01 < ceiling), "5.01 is over ceiling");
   });
 
-  it("worker spawn args use headless --json auto (#2792)", () => {
-    // Verify the spawn command uses headless mode (not --print which exits
-    // before auto-mode can run). See #2792.
-    const expectedArgs = ["headless", "--json", "auto"];
-    assert.ok(expectedArgs.includes("headless"), "args include headless");
-    assert.ok(expectedArgs.includes("--json"), "args include --json");
-    assert.ok(expectedArgs.includes("auto"), "args include auto");
-    assert.ok(expectedArgs.indexOf("headless") < expectedArgs.indexOf("auto"),
-      "headless comes before auto");
+  it("worker spawn args include --mode json", () => {
+    // Verify the spawn command includes JSON mode for NDJSON output.
+    // We can't easily test the actual spawn, but we verify the args pattern.
+    const expectedArgs = ["--mode", "json", "--print", "/gsd auto"];
+    assert.ok(expectedArgs.includes("--mode"), "args include --mode");
+    assert.ok(expectedArgs.includes("json"), "args include json");
+    assert.ok(expectedArgs.indexOf("--mode") < expectedArgs.indexOf("json"),
+      "--mode comes before json");
   });
 
   it("refreshWorkerStatuses restores persisted workers from disk", () => {

package/src/resources/extensions/gsd/tests/preferences.test.ts

@@ -352,40 +352,6 @@ test("handles empty models config", () => {
   assert.equal(prefs!.models, undefined);
 });
 
-test("parses raw YAML blocks under headings", () => {
-  const content = `## Parallel
-enabled: true
-max_workers: 3
-`;
-  const prefs = parsePreferencesMarkdown(content);
-  assert.notEqual(prefs, null);
-  assert.equal(prefs!.parallel?.enabled, true);
-  assert.equal(prefs!.parallel?.max_workers, 3);
-});
-
-test("unwraps nested top-level preference key under descriptive headings", () => {
-  const content = `## Parallel Orchestration
-parallel:
-  enabled: true
-  max_workers: 3
-`;
-  const prefs = parsePreferencesMarkdown(content);
-  assert.notEqual(prefs, null);
-  assert.equal(prefs!.parallel?.enabled, true);
-  assert.equal(prefs!.parallel?.max_workers, 3);
-});
-
-test("preserves legacy heading list format", () => {
-  const content = `## Git
-- isolation: branch
-- auto_push: true
-`;
-  const prefs = parsePreferencesMarkdown(content);
-  assert.notEqual(prefs, null);
-  assert.equal(prefs!.git?.isolation, "branch");
-  assert.equal(prefs!.git?.auto_push, true);
-});
-
 // ── Warn-once for unrecognized format (#2373) ────────────────────────────────
 
 test("unrecognized format warning is emitted at most once (#2373)", () => {

package/src/resources/extensions/gsd/tests/prompt-contracts.test.ts

@@ -181,13 +181,6 @@ test("reassess-roadmap prompt references gsd_reassess_roadmap tool", () => {
   assert.match(prompt, /gsd_reassess_roadmap/);
 });
 
-test("validate-milestone prompt persists verification classes through gsd_validate_milestone", () => {
-  const prompt = readPrompt("validate-milestone");
-  assert.match(prompt, /verification classes section/i);
-  assert.match(prompt, /verificationClasses/);
-  assert.match(prompt, /gsd_validate_milestone/);
-});
-
 // ─── Prompt migration: replan-slice → gsd_replan_slice ────────────────
 
 test("replan-slice prompt names gsd_replan_slice as the tool to use", () => {

package/src/resources/extensions/gsd/tests/validate-milestone-write-order.test.ts

@@ -1,6 +1,6 @@
 import { describe, it, afterEach } from "node:test";
 import assert from "node:assert/strict";
-import { mkdirSync, existsSync, readFileSync, rmSync, writeFileSync } from "node:fs";
+import { mkdirSync, existsSync, rmSync, writeFileSync } from "node:fs";
 import { join } from "node:path";
 import { tmpdir } from "node:os";
 import { randomUUID } from "node:crypto";
@@ -24,7 +24,6 @@ const VALID_PARAMS = {
   sliceDeliveryAudit: "| S01 | delivered |",
   crossSliceIntegration: "No issues",
   requirementCoverage: "All covered",
-  verificationClasses: "- Contract: covered\n- Integration: covered\n- Operational: gap noted",
   verdictRationale: "Everything checks out",
 };
 
@@ -60,27 +59,6 @@ describe("handleValidateMilestone write ordering (#2725)", () => {
     // Disk file exists
     const filePath = join(base, ".gsd", "milestones", "M001", "M001-VALIDATION.md");
     assert.ok(existsSync(filePath), "VALIDATION.md should exist on disk");
-    const validationMd = readFileSync(filePath, "utf-8");
-    assert.match(validationMd, /## Verification Class Compliance/);
-    assert.match(validationMd, /- Contract: covered/);
-    assert.match(validationMd, /## Verdict Rationale/);
-  });
-
-  it("omits verification class section when no verification classes are supplied", async () => {
-    base = makeTmpBase();
-    const dbPath = join(base, ".gsd", "gsd.db");
-    openDatabase(dbPath);
-    insertMilestone({ id: "M001" });
-
-    const result = await handleValidateMilestone(
-      { ...VALID_PARAMS, verificationClasses: undefined },
-      base,
-    );
-    assert.ok(!("error" in result), `unexpected error: ${"error" in result ? result.error : ""}`);
-
-    const filePath = join(base, ".gsd", "milestones", "M001", "M001-VALIDATION.md");
-    const validationMd = readFileSync(filePath, "utf-8");
-    assert.doesNotMatch(validationMd, /## Verification Class Compliance/);
   });
 
   it("rolls back DB row when disk write fails", async () => {

package/src/resources/extensions/gsd/tests/validation-gate-patterns.test.ts

@@ -23,9 +23,9 @@ import assert from "node:assert/strict";
 function hasOperationalEvidence(validationContent: string): boolean {
   const structuredMatch =
     validationContent.includes("Operational") &&
-    (validationContent.includes("MET") || validationContent.includes("N/A") || validationContent.includes("SATISFIED"));
+    (validationContent.includes("MET") || validationContent.includes("N/A"));
   const proseMatch =
-    /[Oo]perational[\s\S]{0,500}?(?:✅|pass|verified|confirmed|met|complete|true|yes|addressed|covered|satisfied|partially|n\/a|not[\s-]+applicable)/i.test(
+    /[Oo]perational[\s:][^\n]*(?:pass|verified|confirmed|met|complete|true|yes|addressed|covered|n\/a|not\s+applicable)/i.test(
       validationContent,
     );
   return structuredMatch || proseMatch;
@@ -104,48 +104,6 @@ test('prose: "Operational: complete" passes', () => {
   assert.ok(hasOperationalEvidence(content));
 });
 
-// ─── Issue #2862: checkmark emoji ────────────────────────────────────────────
-
-test('prose: "Operational: ✅" checkmark emoji passes (issue #2862)', () => {
-  const content = `- **Operational:** ✅ DECISIONS.md documents D009-D013`;
-  assert.ok(hasOperationalEvidence(content));
-});
-
-// ─── Issue #2866: multi-line, "satisfied", markdown bold ─────────────────────
-
-test('multi-line: verdict on next line after Operational heading passes (issue #2866)', () => {
-  const content = `### Operational Verification
-All endpoints responsive. Health checks pass.`;
-  assert.ok(hasOperationalEvidence(content));
-});
-
-test('prose: "PARTIALLY SATISFIED" passes (issue #2866)', () => {
-  const content = `Operational class: ⚠️ PARTIALLY SATISFIED`;
-  assert.ok(hasOperationalEvidence(content));
-});
-
-test('prose: "FULLY SATISFIED" passes (issue #2866)', () => {
-  const content = `**Operational**: FULLY SATISFIED — all monitoring in place.`;
-  assert.ok(hasOperationalEvidence(content));
-});
-
-test('structured: Operational + SATISFIED passes (issue #2866)', () => {
-  const content = `| Criteria       | Status    |
-| Operational    | SATISFIED |`;
-  assert.ok(hasOperationalEvidence(content));
-});
-
-test('table with markdown bold: **Operational** passes (issue #2866)', () => {
-  const content = `| **Operational** | ⚠️ Partially satisfied — monitoring gap noted |`;
-  assert.ok(hasOperationalEvidence(content));
-});
-
-test('multi-line: Operational label and "confirmed" separated by line break passes (issue #2866)', () => {
-  const content = `## Operational
-Smoke tests confirmed all services healthy after deploy.`;
-  assert.ok(hasOperationalEvidence(content));
-});
-
 // ─── Rejection cases ─────────────────────────────────────────────────────────
 
 test("no operational evidence: unrelated content fails", () => {

package/src/resources/extensions/gsd/tools/validate-milestone.ts

@@ -25,7 +25,6 @@ export interface ValidateMilestoneParams {
   sliceDeliveryAudit: string;
   crossSliceIntegration: string;
   requirementCoverage: string;
-  verificationClasses?: string;
   verdictRationale: string;
   remediationPlan?: string;
 }
@@ -56,10 +55,6 @@ ${params.crossSliceIntegration}
 ## Requirement Coverage
 ${params.requirementCoverage}
 
-${params.verificationClasses ? `## Verification Class Compliance
-${params.verificationClasses}
-
-` : ""}
 ## Verdict Rationale
 ${params.verdictRationale}
 `;