gsd-pi 2.54.0 → 2.55.0-dev.9ec7cdf

package/src/resources/extensions/gsd/tests/worktree-preferences-sync.test.ts

@@ -1,11 +1,12 @@
 /**
  * worktree-preferences-sync.test.ts — Regression test for #2684.
  *
- * Verifies that preferences.md is seeded into auto-mode worktrees:
+ * Verifies that canonical PREFERENCES.md is seeded into auto-mode worktrees,
+ * while legacy lowercase preferences.md remains supported:
  *
- *   1. copyPlanningArtifacts() copies preferences.md on initial worktree creation
- *   2. syncGsdStateToWorktree() forward-syncs preferences.md (additive only)
- *   3. syncWorktreeStateBack() does NOT overwrite project root preferences.md
+ *   1. syncGsdStateToWorktree() forward-syncs PREFERENCES.md (additive only)
+ *   2. syncGsdStateToWorktree() still accepts legacy lowercase preferences.md
+ *   3. syncWorktreeStateBack() does NOT overwrite project root PREFERENCES.md
  */
 
 import test from "node:test";
@@ -15,6 +16,7 @@ import {
   mkdirSync,
   mkdtempSync,
   readFileSync,
+  readdirSync,
   rmSync,
   writeFileSync,
 } from "node:fs";
@@ -56,35 +58,58 @@ const PREFS_CONTENT = [
   '  - use: "frontend-design"',
 ].join("\n");
 
-test("#2684: syncGsdStateToWorktree forward-syncs preferences.md when missing from worktree", (t) => {
+test("#2684: syncGsdStateToWorktree forward-syncs PREFERENCES.md when missing from worktree", (t) => {
   const mainBase = makeTempDir("main");
   const wtBase = makeTempDir("wt");
   t.after(() => cleanup(mainBase, wtBase));
 
-  // Project root has preferences.md
-  writeFile(mainBase, ".gsd/preferences.md", PREFS_CONTENT);
+  // Project root has canonical PREFERENCES.md
+  writeFile(mainBase, ".gsd/PREFERENCES.md", PREFS_CONTENT);
 
-  // Worktree has .gsd/ but no preferences.md
+  // Worktree has .gsd/ but no preferences file
   mkdirSync(join(wtBase, ".gsd"), { recursive: true });
 
   const result = syncGsdStateToWorktree(mainBase, wtBase);
 
   assert.ok(
-    existsSync(join(wtBase, ".gsd", "preferences.md")),
-    "preferences.md should be copied to worktree",
+    existsSync(join(wtBase, ".gsd", "PREFERENCES.md")),
+    "PREFERENCES.md should be copied to worktree",
   );
   assert.equal(
-    readFileSync(join(wtBase, ".gsd", "preferences.md"), "utf-8"),
+    readFileSync(join(wtBase, ".gsd", "PREFERENCES.md"), "utf-8"),
     PREFS_CONTENT,
-    "preferences.md content should match source",
+    "PREFERENCES.md content should match source",
+  );
+  assert.ok(
+    result.synced.includes("PREFERENCES.md"),
+    "PREFERENCES.md should appear in synced list",
+  );
+});
+
+test("syncGsdStateToWorktree still accepts legacy lowercase preferences.md", (t) => {
+  const mainBase = makeTempDir("main");
+  const wtBase = makeTempDir("wt");
+  t.after(() => cleanup(mainBase, wtBase));
+
+  writeFile(mainBase, ".gsd/preferences.md", PREFS_CONTENT);
+  mkdirSync(join(wtBase, ".gsd"), { recursive: true });
+
+  const result = syncGsdStateToWorktree(mainBase, wtBase);
+
+  const copiedEntries = readdirSync(join(wtBase, ".gsd"))
+    .filter((name) => name === "PREFERENCES.md" || name === "preferences.md");
+
+  assert.ok(
+    copiedEntries.length === 1,
+    `expected exactly one preferences file in worktree, got ${copiedEntries.join(", ") || "(none)"}`,
   );
   assert.ok(
-    result.synced.includes("preferences.md"),
-    "preferences.md should appear in synced list",
+    result.synced.includes("preferences.md") || result.synced.includes("PREFERENCES.md"),
+    "legacy source should still appear in synced list",
   );
 });
 
-test("#2684: syncGsdStateToWorktree does NOT overwrite existing worktree preferences.md", (t) => {
+test("#2684: syncGsdStateToWorktree does NOT overwrite existing worktree preferences file", (t) => {
   const mainBase = makeTempDir("main");
   const wtBase = makeTempDir("wt");
   t.after(() => cleanup(mainBase, wtBase));
@@ -92,19 +117,19 @@ test("#2684: syncGsdStateToWorktree does NOT overwrite existing worktree prefere
   const rootPrefs = "# Root preferences\nold: true";
   const wtPrefs = "# Worktree preferences\nmodified: true";
 
-  writeFile(mainBase, ".gsd/preferences.md", rootPrefs);
-  writeFile(wtBase, ".gsd/preferences.md", wtPrefs);
+  writeFile(mainBase, ".gsd/PREFERENCES.md", rootPrefs);
+  writeFile(wtBase, ".gsd/PREFERENCES.md", wtPrefs);
 
   syncGsdStateToWorktree(mainBase, wtBase);
 
   assert.equal(
-    readFileSync(join(wtBase, ".gsd", "preferences.md"), "utf-8"),
+    readFileSync(join(wtBase, ".gsd", "PREFERENCES.md"), "utf-8"),
     wtPrefs,
-    "existing worktree preferences.md must not be overwritten",
+    "existing worktree PREFERENCES.md must not be overwritten",
   );
 });
 
-test("#2684: syncWorktreeStateBack does NOT overwrite project root preferences.md", (t) => {
+test("#2684: syncWorktreeStateBack does NOT overwrite project root PREFERENCES.md", (t) => {
   const mainBase = makeTempDir("main");
   const wtBase = makeTempDir("wt");
   const mid = "M001";
@@ -113,8 +138,8 @@ test("#2684: syncWorktreeStateBack does NOT overwrite project root preferences.m
   const rootPrefs = "# Root preferences\nauthoritative: true";
   const wtPrefs = "# Worktree preferences\nstale-copy: true";
 
-  writeFile(mainBase, ".gsd/preferences.md", rootPrefs);
-  writeFile(wtBase, ".gsd/preferences.md", wtPrefs);
+  writeFile(mainBase, ".gsd/PREFERENCES.md", rootPrefs);
+  writeFile(wtBase, ".gsd/PREFERENCES.md", wtPrefs);
 
   // Worktree needs at least a milestone dir for the function to proceed
   mkdirSync(join(wtBase, ".gsd", "milestones", mid), { recursive: true });
@@ -123,8 +148,8 @@ test("#2684: syncWorktreeStateBack does NOT overwrite project root preferences.m
   syncWorktreeStateBack(mainBase, wtBase, mid);
 
   assert.equal(
-    readFileSync(join(mainBase, ".gsd", "preferences.md"), "utf-8"),
+    readFileSync(join(mainBase, ".gsd", "PREFERENCES.md"), "utf-8"),
     rootPrefs,
-    "project root preferences.md must NOT be overwritten by worktree copy",
+    "project root PREFERENCES.md must NOT be overwritten by worktree copy",
   );
 });

package/src/resources/extensions/gsd/visualizer-overlay.ts

@@ -14,7 +14,10 @@ import {
   renderHealthView,
   type ProgressFilter,
 } from "./visualizer-views.js";
+import { writeFileSync, mkdirSync } from "node:fs";
+import { join } from "node:path";
 import { writeExportFile } from "./export.js";
+import { gsdRoot } from "./paths.js";
 import { stripAnsi } from "../shared/mod.js";
 
 const TAB_COUNT = 10;
@@ -350,9 +353,6 @@ export class GSDVisualizerOverlay {
       // Capture current active tab's rendered lines as snapshot
       const snapshotLines = this.renderTabContent(this.activeTab, 80);
       const timestamp = new Date().toISOString().replace(/[:.]/g, "-").slice(0, 19);
-      const { writeFileSync, mkdirSync } = require("node:fs");
-      const { join } = require("node:path");
-      const { gsdRoot } = require("./paths.js");
       const exportDir = gsdRoot(this.basePath);
       mkdirSync(exportDir, { recursive: true });
       const outPath = join(exportDir, `snapshot-${timestamp}.txt`);

package/src/resources/extensions/shared/format-utils.ts

@@ -11,7 +11,7 @@
 
 /** Format a millisecond duration as a compact human-readable string. */
 export function formatDuration(ms: number): string {
-  if (ms < 1000) return `${ms}ms`;
+  if (ms > 0 && ms < 1000) return `${ms}ms`;
   const s = Math.floor(ms / 1000);
   if (s < 60) return `${s}s`;
   const m = Math.floor(s / 60);

package/src/resources/extensions/subagent/worker-registry.ts

@@ -54,9 +54,10 @@ export function updateWorker(id: string, status: "completed" | "failed"): void {
   if (entry) {
     entry.status = status;
     // Remove after a brief display window (5 seconds)
+    // unref() so the timer doesn't keep the process alive in test environments
     setTimeout(() => {
       activeWorkers.delete(id);
-    }, 5000);
+    }, 5000).unref();
   }
 }