gsd-pi 2.49.0 → 2.50.0-dev.d210a87

package/src/resources/extensions/gsd/tests/complete-task.test.ts

@@ -109,9 +109,9 @@ console.log('\n=== complete-task: schema v5 migration ===');
 
   const adapter = _getAdapter()!;
 
-  // Verify schema version is current (v11 after state machine migration)
+  // Verify schema version is current (v12 after quality gates table)
   const versionRow = adapter.prepare('SELECT MAX(version) as v FROM schema_version').get();
-  assertEq(versionRow?.['v'], 11, 'schema version should be 11');
+  assertEq(versionRow?.['v'], 12, 'schema version should be 12');
 
   // Verify all 4 new tables exist
   const tables = adapter.prepare(

package/src/resources/extensions/gsd/tests/completed-units-metrics-sync.test.ts

@@ -48,35 +48,32 @@ test("#2313: completed-units.json should not be blindly wiped to [] on milestone
 // ─── Bug 2: metrics.json should be in the sync file lists ──────────────────
 
 test("#2313: syncStateToProjectRoot should sync metrics.json", () => {
-  const syncSrcPath = join(import.meta.dirname, "..", "auto-worktree-sync.ts");
+  const syncSrcPath = join(import.meta.dirname, "..", "auto-worktree.ts");
   const syncSrc = readFileSync(syncSrcPath, "utf-8");
 
   // syncStateToProjectRoot should copy metrics.json from worktree to project root
   assert.ok(
     syncSrc.includes("metrics.json"),
-    "auto-worktree-sync.ts should reference metrics.json for sync",
+    "auto-worktree.ts should reference metrics.json for sync",
   );
 });
 
-test("#2313: syncWorktreeStateBack should include metrics.json in root files list", () => {
+test("#2313: syncWorktreeStateBack should include metrics.json in ROOT_STATE_FILES", () => {
   const autoWorktreeSrcPath = join(import.meta.dirname, "..", "auto-worktree.ts");
   const autoWorktreeSrc = readFileSync(autoWorktreeSrcPath, "utf-8");
 
-  // Find the rootFiles array in syncWorktreeStateBack
-  const syncBackIdx = autoWorktreeSrc.indexOf("syncWorktreeStateBack");
-  assert.ok(syncBackIdx !== -1, "syncWorktreeStateBack exists");
+  // Find the ROOT_STATE_FILES constant (single source of truth for both sync directions)
+  const constIdx = autoWorktreeSrc.indexOf("ROOT_STATE_FILES");
+  assert.ok(constIdx !== -1, "ROOT_STATE_FILES constant exists");
 
-  const rootFilesIdx = autoWorktreeSrc.indexOf("rootFiles", syncBackIdx);
-  assert.ok(rootFilesIdx !== -1, "rootFiles list exists in syncWorktreeStateBack");
-
-  // Get the rootFiles array content
-  const arrayStart = autoWorktreeSrc.indexOf("[", rootFilesIdx);
+  // Get the array content
+  const arrayStart = autoWorktreeSrc.indexOf("[", constIdx);
   const arrayEnd = autoWorktreeSrc.indexOf("]", arrayStart);
   const rootFilesBlock = autoWorktreeSrc.slice(arrayStart, arrayEnd);
 
   assert.ok(
     rootFilesBlock.includes("metrics.json"),
-    "metrics.json should be in syncWorktreeStateBack rootFiles list",
+    "metrics.json should be in ROOT_STATE_FILES list",
   );
 });
 

package/src/resources/extensions/gsd/tests/crash-recovery.test.ts

@@ -68,8 +68,10 @@ test("clearLock is safe when no lock exists", (t) => {
 
 // ─── isLockProcessAlive ──────────────────────────────────────────────────
 
-test("isLockProcessAlive returns true for current process (different pid)", () => {
-  // Our own PID is explicitly excluded (recycled PID guard)
+test("#2470: isLockProcessAlive returns true for own PID (we hold the lock)", () => {
+  // Own PID means we ARE the lock holder — alive, not stale. (#2470)
+  // Callers that need recycled-PID detection (e.g. startAuto) already
+  // guard with `crashLock.pid !== process.pid` before calling us.
   const lock: LockData = {
     pid: process.pid,
     startedAt: new Date().toISOString(),
@@ -77,7 +79,7 @@ test("isLockProcessAlive returns true for current process (different pid)", () =
     unitId: "M001/S01/T01",
     unitStartedAt: new Date().toISOString(),
   };
-  assert.equal(isLockProcessAlive(lock), false, "own PID should return false");
+  assert.equal(isLockProcessAlive(lock), true, "own PID should return true — we are alive");
 });
 
 test("isLockProcessAlive returns false for dead PID", () => {

package/src/resources/extensions/gsd/tests/custom-verification.test.ts

@@ -15,6 +15,7 @@ import { tmpdir } from "node:os";
 import { stringify } from "yaml";
 import { runCustomVerification } from "../custom-verification.ts";
 import type { WorkflowDefinition } from "../definition-loader.ts";
+import { createFakeRtk } from "../../../../tests/rtk-test-utils.ts";
 
 /** Create a temp run directory with the given definition and optional files. */
 function makeTempRun(
@@ -225,6 +226,38 @@ describe("shell-command policy", () => {
     const result = runCustomVerification(runDir, "step-1");
     assert.equal(result, "retry");
   });
+
+  it("rewrites shell-command verification through RTK when available", () => {
+    const fake = createFakeRtk({
+      "echo raw": "echo rewritten",
+    });
+    const previous = process.env.GSD_RTK_PATH;
+    process.env.GSD_RTK_PATH = fake.path;
+
+    try {
+      const def = makeDef([
+        {
+          id: "step-1",
+          name: "Build artifact",
+          prompt: "Build the artifact",
+          requires: [],
+          produces: ["artifact.txt"],
+          verify: {
+            policy: "shell-command",
+            command: "echo raw",
+          },
+        },
+      ]);
+
+      const runDir = makeTempRun(def);
+      const result = runCustomVerification(runDir, "step-1");
+      assert.equal(result, "continue");
+    } finally {
+      if (previous === undefined) delete process.env.GSD_RTK_PATH;
+      else process.env.GSD_RTK_PATH = previous;
+      fake.cleanup();
+    }
+  });
 });
 
 // ─── prompt-verify tests ────────────────────────────────────────────────

package/src/resources/extensions/gsd/tests/derive-state-db.test.ts

@@ -769,9 +769,10 @@ describe('derive-state-db', async () => {
       const elapsed = performance.now() - start;
 
       console.log(`  deriveStateFromDb() took ${elapsed.toFixed(3)}ms`);
-      // Use 10ms threshold — catches real regressions without flaking on
-      // CI runners under load (1ms threshold failed at 1.050ms on GitHub Actions)
-      assert.ok(elapsed < 10, `perf-db: deriveStateFromDb() <10ms (got ${elapsed.toFixed(3)}ms)`);
+      // Use 25ms threshold — catches real regressions without flaking on
+      // slower CI runners (Windows agents measured at ~12ms under load;
+      // the 10ms threshold was too tight for those environments).
+      assert.ok(elapsed < 25, `perf-db: deriveStateFromDb() <25ms (got ${elapsed.toFixed(3)}ms)`);
 
       closeDatabase();
     } finally {