gsd-pi 2.47.0 → 2.48.0-dev.2e7390c

package/src/resources/extensions/gsd/tests/stale-milestone-id-reservation.test.ts

@@ -0,0 +1,79 @@
+/**
+ * Regression test for #2488: Stale milestone ID reservations inflate next ID
+ * after cancelled /gsd sessions.
+ *
+ * The module-level `reservedMilestoneIds` Set persists across /gsd invocations
+ * within the same Node process. Without clearReservedMilestoneIds() at session
+ * start, each cancelled session permanently bumps the counter by 1.
+ */
+import { describe, test, beforeEach } from "node:test";
+import assert from "node:assert/strict";
+
+import {
+  nextMilestoneId,
+  reserveMilestoneId,
+  getReservedMilestoneIds,
+  clearReservedMilestoneIds,
+} from "../milestone-ids.ts";
+
+describe("stale milestone ID reservation cleanup (#2488)", () => {
+  beforeEach(() => {
+    clearReservedMilestoneIds();
+  });
+
+  test("without cleanup, cancelled sessions inflate the next ID", () => {
+    const diskIds = ["M001", "M002", "M003"];
+
+    // Session 1: user starts /gsd, ID is previewed and reserved, then cancelled
+    const allIds1 = [...new Set([...diskIds, ...getReservedMilestoneIds()])];
+    const preview1 = nextMilestoneId(allIds1);
+    reserveMilestoneId(preview1);
+    assert.equal(preview1, "M004");
+
+    // Session 2: user starts /gsd again — stale reservation still in Set
+    // WITHOUT clearing, the next ID skips M004 (reserved) and goes to M005
+    const allIds2 = [...new Set([...diskIds, ...getReservedMilestoneIds()])];
+    const preview2 = nextMilestoneId(allIds2);
+    assert.equal(preview2, "M005", "without cleanup, ID inflates to M005");
+  });
+
+  test("with cleanup at session start, next ID is correct", () => {
+    const diskIds = ["M001", "M002", "M003"];
+
+    // Session 1: user starts /gsd, ID is previewed and reserved, then cancelled
+    const allIds1 = [...new Set([...diskIds, ...getReservedMilestoneIds()])];
+    const preview1 = nextMilestoneId(allIds1);
+    reserveMilestoneId(preview1);
+    assert.equal(preview1, "M004");
+
+    // Session 2: clear stale reservations first (the fix)
+    clearReservedMilestoneIds();
+
+    // Now the next ID correctly returns M004 again
+    const allIds2 = [...new Set([...diskIds, ...getReservedMilestoneIds()])];
+    const preview2 = nextMilestoneId(allIds2);
+    assert.equal(preview2, "M004", "after cleanup, ID is correctly M004");
+  });
+
+  test("multiple cancelled sessions compound the inflation without cleanup", () => {
+    const diskIds = ["M001", "M002", "M003"];
+
+    // 3 cancelled sessions without cleanup
+    for (let i = 0; i < 3; i++) {
+      const allIds = [...new Set([...diskIds, ...getReservedMilestoneIds()])];
+      const preview = nextMilestoneId(allIds);
+      reserveMilestoneId(preview);
+    }
+
+    // Without cleanup, we're now at M007 instead of M004
+    const allIds = [...new Set([...diskIds, ...getReservedMilestoneIds()])];
+    const next = nextMilestoneId(allIds);
+    assert.equal(next, "M007", "3 cancelled sessions inflate ID by 3");
+
+    // With cleanup, we're back to M004
+    clearReservedMilestoneIds();
+    const allIdsClean = [...new Set([...diskIds, ...getReservedMilestoneIds()])];
+    const nextClean = nextMilestoneId(allIdsClean);
+    assert.equal(nextClean, "M004", "cleanup restores correct next ID");
+  });
+});

package/dist/web/standalone/.next/static/chunks/app/page-12dd5ece0df4badc.js

@@ -1 +0,0 @@
-(self.webpackChunk_N_E=self.webpackChunk_N_E||[]).push([[8974],{5214:(e,t,n)=>{"use strict";Object.defineProperty(t,"__esModule",{value:!0}),Object.defineProperty(t,"workAsyncStorage",{enumerable:!0,get:function(){return r.workAsyncStorageInstance}});let r=n(17828)},15726:(e,t,n)=>{Promise.resolve().then(n.bind(n,66919))},17828:(e,t,n)=>{"use strict";Object.defineProperty(t,"__esModule",{value:!0}),Object.defineProperty(t,"workAsyncStorageInstance",{enumerable:!0,get:function(){return r}});let r=(0,n(64054).createAsyncLocalStorage)()},21957:(e,t,n)=>{"use strict";function r({moduleIds:e}){return null}Object.defineProperty(t,"__esModule",{value:!0}),Object.defineProperty(t,"PreloadChunks",{enumerable:!0,get:function(){return r}}),n(95155),n(47650),n(5214),n(2451),n(53887)},37206:(e,t,n)=>{"use strict";n.d(t,{default:()=>u.a});var r=n(75707),u=n.n(r)},41112:(e,t,n)=>{"use strict";function r({reason:e,children:t}){return t}Object.defineProperty(t,"__esModule",{value:!0}),Object.defineProperty(t,"BailoutToCSR",{enumerable:!0,get:function(){return r}}),n(1980)},64054:(e,t)=>{"use strict";Object.defineProperty(t,"__esModule",{value:!0});var n={bindSnapshot:function(){return s},createAsyncLocalStorage:function(){return a},createSnapshot:function(){return i}};for(var r in n)Object.defineProperty(t,r,{enumerable:!0,get:n[r]});let u=Object.defineProperty(Error("Invariant: AsyncLocalStorage accessed in runtime where it is not available"),"__NEXT_ERROR_CODE",{value:"E504",enumerable:!1,configurable:!0});class l{disable(){throw u}getStore(){}run(){throw u}exit(){throw u}enterWith(){throw u}static bind(e){return e}}let o="u">typeof globalThis&&globalThis.AsyncLocalStorage;function a(){return o?new o:new l}function s(e){return o?o.bind(e):l.bind(e)}function i(){return o?o.snapshot():function(e,...t){return e(...t)}}},66919:(e,t,n)=>{"use strict";n.r(t),n.d(t,{default:()=>l});var r=n(95155);let u=(0,n(37206).default)(()=>Promise.all([n.e(1838),n.e(6079),n.e(4986),n.e(485),n.e(4024)]).then(n.bind(n,4024)).then(e=>e.GSDAppShell),{loadableGenerated:{webpack:()=>[4024]},ssr:!1,loading:()=>(0,r.jsx)("div",{className:"flex h-screen items-center justify-center bg-background text-sm text-muted-foreground",children:"Loading workspace…"})});function l(){return(0,r.jsx)(u,{})}},68635:(e,t,n)=>{"use strict";Object.defineProperty(t,"__esModule",{value:!0}),Object.defineProperty(t,"default",{enumerable:!0,get:function(){return s}});let r=n(95155),u=n(12115),l=n(41112);function o(e){return{default:e&&"default"in e?e.default:e}}n(21957);let a={loader:()=>Promise.resolve(o(()=>null)),loading:null,ssr:!0},s=function(e){let t={...a,...e},n=(0,u.lazy)(()=>t.loader().then(o)),s=t.loading;function i(e){let o=s?(0,r.jsx)(s,{isLoading:!0,pastDelay:!0,error:null}):null,a=!t.ssr||!!t.loading,i=a?u.Suspense:u.Fragment,c=t.ssr?(0,r.jsxs)(r.Fragment,{children:[null,(0,r.jsx)(n,{...e})]}):(0,r.jsx)(l.BailoutToCSR,{reason:"next/dynamic",children:(0,r.jsx)(n,{...e})});return(0,r.jsx)(i,{...a?{fallback:o}:{},children:c})}return i.displayName="LoadableComponent",i}},75707:(e,t,n)=>{"use strict";Object.defineProperty(t,"__esModule",{value:!0}),Object.defineProperty(t,"default",{enumerable:!0,get:function(){return u}});let r=n(73623)._(n(68635));function u(e,t){let n={};"function"==typeof e&&(n.loader=e);let u={...n,...t};return(0,r.default)({...u,modules:u.loadableGenerated?.modules})}("function"==typeof t.default||"object"==typeof t.default&&null!==t.default)&&void 0===t.default.__esModule&&(Object.defineProperty(t.default,"__esModule",{value:!0}),Object.assign(t.default,t),e.exports=t.default)}},e=>{e.O(0,[8441,3794,7358],()=>e(e.s=15726)),_N_E=e.O()}]);

package/dist/web/standalone/.next/static/chunks/main-app-d3d4c336195465f9.js

@@ -1 +0,0 @@
-(self.webpackChunk_N_E=self.webpackChunk_N_E||[]).push([[7358],{2852:(e,s,n)=>{Promise.resolve().then(n.t.bind(n,27123,23)),Promise.resolve().then(n.t.bind(n,61304,23)),Promise.resolve().then(n.t.bind(n,78616,23)),Promise.resolve().then(n.t.bind(n,64777,23)),Promise.resolve().then(n.t.bind(n,57121,23)),Promise.resolve().then(n.t.bind(n,74581,23)),Promise.resolve().then(n.t.bind(n,90484,23)),Promise.resolve().then(n.bind(n,86869))},19393:()=>{}},e=>{var s=s=>e(e.s=s);e.O(0,[8441,3794],()=>(s(83861),s(2852))),_N_E=e.O()}]);

package/dist/web/standalone/.next/static/chunks/next/dist/client/components/builtin/global-error-ab5a8926e07ec673.js

@@ -1 +0,0 @@
-(self.webpackChunk_N_E=self.webpackChunk_N_E||[]).push([[9337],{52560:(e,s,_)=>{Promise.resolve().then(_.t.bind(_,27123,23))}},e=>{e.O(0,[8441,3794,7358],()=>e(e.s=52560)),_N_E=e.O()}]);