gsd-pi 2.45.0 → 2.46.0

package/packages/pi-coding-agent/dist/core/lifecycle-hooks.test.js

@@ -0,0 +1,185 @@
+import assert from "node:assert/strict";
+import { mkdtempSync, mkdirSync, rmSync, writeFileSync, existsSync } from "node:fs";
+import { homedir, tmpdir } from "node:os";
+import { join, resolve } from "node:path";
+import { describe, it } from "node:test";
+import { readManifestRuntimeDeps, collectRuntimeDependencies, verifyRuntimeDependencies, resolveLocalSourcePath, } from "./lifecycle-hooks.js";
+function tmpDir(prefix, t) {
+    const dir = mkdtempSync(join(tmpdir(), `pi-lh-${prefix}-`));
+    t.after(() => rmSync(dir, { recursive: true, force: true }));
+    return dir;
+}
+// ─── readManifestRuntimeDeps ──────────────────────────────────────────────────
+describe("readManifestRuntimeDeps", () => {
+    it("returns empty array when manifest file is missing", (t) => {
+        const dir = tmpDir("no-manifest", t);
+        assert.deepEqual(readManifestRuntimeDeps(dir), []);
+    });
+    it("returns empty array for malformed JSON", (t) => {
+        const dir = tmpDir("bad-json", t);
+        writeFileSync(join(dir, "extension-manifest.json"), "not json{{{", "utf-8");
+        assert.deepEqual(readManifestRuntimeDeps(dir), []);
+    });
+    it("returns runtime deps from valid manifest", (t) => {
+        const dir = tmpDir("valid", t);
+        writeFileSync(join(dir, "extension-manifest.json"), JSON.stringify({
+            dependencies: { runtime: ["claude", "node"] },
+        }), "utf-8");
+        assert.deepEqual(readManifestRuntimeDeps(dir), ["claude", "node"]);
+    });
+    it("returns empty array when dependencies exists but runtime is missing", (t) => {
+        const dir = tmpDir("no-runtime", t);
+        writeFileSync(join(dir, "extension-manifest.json"), JSON.stringify({
+            dependencies: {},
+        }), "utf-8");
+        assert.deepEqual(readManifestRuntimeDeps(dir), []);
+    });
+    it("returns empty array when runtime is empty", (t) => {
+        const dir = tmpDir("empty-runtime", t);
+        writeFileSync(join(dir, "extension-manifest.json"), JSON.stringify({
+            dependencies: { runtime: [] },
+        }), "utf-8");
+        assert.deepEqual(readManifestRuntimeDeps(dir), []);
+    });
+    it("filters out non-string entries in runtime array", (t) => {
+        const dir = tmpDir("mixed-types", t);
+        writeFileSync(join(dir, "extension-manifest.json"), JSON.stringify({
+            dependencies: { runtime: [123, null, "node", false, "python"] },
+        }), "utf-8");
+        assert.deepEqual(readManifestRuntimeDeps(dir), ["node", "python"]);
+    });
+    it("returns empty array when no dependencies field at all", (t) => {
+        const dir = tmpDir("no-deps-field", t);
+        writeFileSync(join(dir, "extension-manifest.json"), JSON.stringify({
+            id: "test",
+            name: "Test",
+        }), "utf-8");
+        assert.deepEqual(readManifestRuntimeDeps(dir), []);
+    });
+});
+// ─── collectRuntimeDependencies ───────────────────────────────────────────────
+describe("collectRuntimeDependencies", () => {
+    it("aggregates deps from installedPath manifest", (t) => {
+        const dir = tmpDir("collect-installed", t);
+        writeFileSync(join(dir, "extension-manifest.json"), JSON.stringify({
+            dependencies: { runtime: ["claude"] },
+        }), "utf-8");
+        assert.deepEqual(collectRuntimeDependencies(dir, []), ["claude"]);
+    });
+    it("aggregates deps from entry path directory manifests", (t) => {
+        const root = tmpDir("collect-entry", t);
+        const installedDir = join(root, "installed");
+        const entryDir = join(root, "entry");
+        mkdirSync(installedDir, { recursive: true });
+        mkdirSync(entryDir, { recursive: true });
+        writeFileSync(join(entryDir, "extension-manifest.json"), JSON.stringify({
+            dependencies: { runtime: ["python"] },
+        }), "utf-8");
+        const deps = collectRuntimeDependencies(installedDir, [join(entryDir, "index.ts")]);
+        assert.deepEqual(deps, ["python"]);
+    });
+    it("deduplicates across multiple directories", (t) => {
+        const root = tmpDir("collect-dedup", t);
+        const dir1 = join(root, "dir1");
+        const dir2 = join(root, "dir2");
+        mkdirSync(dir1, { recursive: true });
+        mkdirSync(dir2, { recursive: true });
+        writeFileSync(join(dir1, "extension-manifest.json"), JSON.stringify({
+            dependencies: { runtime: ["node", "python"] },
+        }), "utf-8");
+        writeFileSync(join(dir2, "extension-manifest.json"), JSON.stringify({
+            dependencies: { runtime: ["python", "claude"] },
+        }), "utf-8");
+        const deps = collectRuntimeDependencies(dir1, [join(dir2, "index.ts")]);
+        assert.equal(deps.length, 3);
+        assert.ok(deps.includes("node"));
+        assert.ok(deps.includes("python"));
+        assert.ok(deps.includes("claude"));
+    });
+    it("returns empty when no directories have manifests", (t) => {
+        const dir = tmpDir("collect-empty", t);
+        assert.deepEqual(collectRuntimeDependencies(dir, []), []);
+    });
+});
+// ─── verifyRuntimeDependencies ────────────────────────────────────────────────
+describe("verifyRuntimeDependencies", () => {
+    it("does not throw for empty deps array", () => {
+        assert.doesNotThrow(() => verifyRuntimeDependencies([], "test-source", "pi"));
+    });
+    it("does not throw when all deps are present", () => {
+        assert.doesNotThrow(() => verifyRuntimeDependencies(["node"], "test-source", "pi"));
+    });
+    it("throws for missing dep with 'Missing runtime dependencies' message", () => {
+        assert.throws(() => verifyRuntimeDependencies(["__nonexistent_dep_for_test__"], "test-source", "pi"), (err) => {
+            assert.ok(err.message.includes("Missing runtime dependencies"));
+            assert.ok(err.message.includes("__nonexistent_dep_for_test__"));
+            return true;
+        });
+    });
+    it("lists all missing deps in error message", () => {
+        assert.throws(() => verifyRuntimeDependencies(["__missing_1__", "__missing_2__"], "test-source", "pi"), (err) => {
+            assert.ok(err.message.includes("__missing_1__"));
+            assert.ok(err.message.includes("__missing_2__"));
+            return true;
+        });
+    });
+    it("includes appName and source in error for retry hint", () => {
+        assert.throws(() => verifyRuntimeDependencies(["__missing__"], "github:user/repo", "gsd"), (err) => {
+            assert.ok(err.message.includes("gsd"));
+            assert.ok(err.message.includes("github:user/repo"));
+            return true;
+        });
+    });
+});
+// ─── resolveLocalSourcePath ───────────────────────────────────────────────────
+describe("resolveLocalSourcePath", () => {
+    it("returns undefined for empty string", () => {
+        assert.equal(resolveLocalSourcePath("", "/tmp"), undefined);
+    });
+    it("returns undefined for npm: source", () => {
+        assert.equal(resolveLocalSourcePath("npm:@foo/bar", "/tmp"), undefined);
+    });
+    it("returns undefined for git URL", () => {
+        assert.equal(resolveLocalSourcePath("git:github.com/user/repo", "/tmp"), undefined);
+    });
+    it("returns undefined for https git URL", () => {
+        assert.equal(resolveLocalSourcePath("https://github.com/user/repo", "/tmp"), undefined);
+    });
+    it("resolves ~ to homedir", () => {
+        const result = resolveLocalSourcePath("~", "/tmp");
+        if (existsSync(homedir())) {
+            assert.equal(result, homedir());
+        }
+        else {
+            assert.equal(result, undefined);
+        }
+    });
+    it("resolves ~/path relative to homedir", () => {
+        const result = resolveLocalSourcePath("~/", "/tmp");
+        if (existsSync(homedir())) {
+            assert.equal(result, homedir());
+        }
+        else {
+            assert.equal(result, undefined);
+        }
+    });
+    it("resolves relative path that exists", (t) => {
+        const dir = tmpDir("resolve-rel", t);
+        const sub = join(dir, "myext");
+        mkdirSync(sub, { recursive: true });
+        const result = resolveLocalSourcePath("myext", dir);
+        assert.equal(result, resolve(dir, "myext"));
+    });
+    it("returns undefined for relative path that does not exist", (t) => {
+        const dir = tmpDir("resolve-noexist", t);
+        assert.equal(resolveLocalSourcePath("nonexistent", dir), undefined);
+    });
+    it("resolves absolute path that exists", (t) => {
+        const dir = tmpDir("resolve-abs", t);
+        assert.equal(resolveLocalSourcePath(dir, "/irrelevant"), dir);
+    });
+    it("returns undefined for absolute path that does not exist", () => {
+        assert.equal(resolveLocalSourcePath("/tmp/__nonexistent_path_for_test__", "/tmp"), undefined);
+    });
+});
+//# sourceMappingURL=lifecycle-hooks.test.js.map

package/packages/pi-coding-agent/dist/core/lifecycle-hooks.test.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"lifecycle-hooks.test.js","sourceRoot":"","sources":["../../src/core/lifecycle-hooks.test.ts"],"names":[],"mappings":"AAAA,OAAO,MAAM,MAAM,oBAAoB,CAAC;AACxC,OAAO,EAAE,WAAW,EAAE,SAAS,EAAE,MAAM,EAAE,aAAa,EAAE,UAAU,EAAE,MAAM,SAAS,CAAC;AACpF,OAAO,EAAE,OAAO,EAAE,MAAM,EAAE,MAAM,SAAS,CAAC;AAC1C,OAAO,EAAE,IAAI,EAAE,OAAO,EAAE,MAAM,WAAW,CAAC;AAC1C,OAAO,EAAE,QAAQ,EAAE,EAAE,EAAE,MAAM,WAAW,CAAC;AACzC,OAAO,EACN,uBAAuB,EACvB,0BAA0B,EAC1B,yBAAyB,EACzB,sBAAsB,GACtB,MAAM,sBAAsB,CAAC;AAE9B,SAAS,MAAM,CAAC,MAAc,EAAE,CAAsC;IACrE,MAAM,GAAG,GAAG,WAAW,CAAC,IAAI,CAAC,MAAM,EAAE,EAAE,SAAS,MAAM,GAAG,CAAC,CAAC,CAAC;IAC5D,CAAC,CAAC,KAAK,CAAC,GAAG,EAAE,CAAC,MAAM,CAAC,GAAG,EAAE,EAAE,SAAS,EAAE,IAAI,EAAE,KAAK,EAAE,IAAI,EAAE,CAAC,CAAC,CAAC;IAC7D,OAAO,GAAG,CAAC;AACZ,CAAC;AAED,iFAAiF;AAEjF,QAAQ,CAAC,yBAAyB,EAAE,GAAG,EAAE;IACxC,EAAE,CAAC,mDAAmD,EAAE,CAAC,CAAC,EAAE,EAAE;QAC7D,MAAM,GAAG,GAAG,MAAM,CAAC,aAAa,EAAE,CAAC,CAAC,CAAC;QACrC,MAAM,CAAC,SAAS,CAAC,uBAAuB,CAAC,GAAG,CAAC,EAAE,EAAE,CAAC,CAAC;IACpD,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,wCAAwC,EAAE,CAAC,CAAC,EAAE,EAAE;QAClD,MAAM,GAAG,GAAG,MAAM,CAAC,UAAU,EAAE,CAAC,CAAC,CAAC;QAClC,aAAa,CAAC,IAAI,CAAC,GAAG,EAAE,yBAAyB,CAAC,EAAE,aAAa,EAAE,OAAO,CAAC,CAAC;QAC5E,MAAM,CAAC,SAAS,CAAC,uBAAuB,CAAC,GAAG,CAAC,EAAE,EAAE,CAAC,CAAC;IACpD,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,0CAA0C,EAAE,CAAC,CAAC,EAAE,EAAE;QACpD,MAAM,GAAG,GAAG,MAAM,CAAC,OAAO,EAAE,CAAC,CAAC,CAAC;QAC/B,aAAa,CAAC,IAAI,CAAC,GAAG,EAAE,yBAAyB,CAAC,EAAE,IAAI,CAAC,SAAS,CAAC;YAClE,YAAY,EAAE,EAAE,OAAO,EAAE,CAAC,QAAQ,EAAE,MAAM,CAAC,EAAE;SAC7C,CAAC,EAAE,OAAO,CAAC,CAAC;QACb,MAAM,CAAC,SAAS,CAAC,uBAAuB,CAAC,GAAG,CAAC,EAAE,CAAC,QAAQ,EAAE,MAAM,CAAC,CAAC,CAAC;IACpE,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,qEAAqE,EAAE,CAAC,CAAC,EAAE,EAAE;QAC/E,MAAM,GAAG,GAAG,MAAM,CAAC,YAAY,EAAE,CAAC,CAAC,CAAC;QACpC,aAAa,CAAC,IAAI,CAAC,GAAG,EAAE,yBAAyB,CAAC,EAAE,IAAI,CAAC,SAAS,CAAC;YAClE,YAAY,EAAE,EAAE;SAChB,CAAC,EAAE,OAAO,CAAC,CAAC;QACb,MAAM,CAAC,SAAS,CAAC,uBAAuB,CAAC,GAAG,CAAC,EAAE,EAAE,CAAC,CAAC;IACpD,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,2CAA2C,EAAE,CAAC,CAAC,EAAE,EAAE;QACrD,MAAM,GAAG,GAAG,MAAM,CAAC,eAAe,EAAE,CAAC,CAAC,CAAC;QACvC,aAAa,CAAC,IAAI,CAAC,GAAG,EAAE,yBAAyB,CAAC,EAAE,IAAI,CAAC,SAAS,CAAC;YAClE,YAAY,EAAE,EAAE,OAAO,EAAE,EAAE,EAAE;SAC7B,CAAC,EAAE,OAAO,CAAC,CAAC;QACb,MAAM,CAAC,SAAS,CAAC,uBAAuB,CAAC,GAAG,CAAC,EAAE,EAAE,CAAC,CAAC;IACpD,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,iDAAiD,EAAE,CAAC,CAAC,EAAE,EAAE;QAC3D,MAAM,GAAG,GAAG,MAAM,CAAC,aAAa,EAAE,CAAC,CAAC,CAAC;QACrC,aAAa,CAAC,IAAI,CAAC,GAAG,EAAE,yBAAyB,CAAC,EAAE,IAAI,CAAC,SAAS,CAAC;YAClE,YAAY,EAAE,EAAE,OAAO,EAAE,CAAC,GAAG,EAAE,IAAI,EAAE,MAAM,EAAE,KAAK,EAAE,QAAQ,CAAC,EAAE;SAC/D,CAAC,EAAE,OAAO,CAAC,CAAC;QACb,MAAM,CAAC,SAAS,CAAC,uBAAuB,CAAC,GAAG,CAAC,EAAE,CAAC,MAAM,EAAE,QAAQ,CAAC,CAAC,CAAC;IACpE,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,uDAAuD,EAAE,CAAC,CAAC,EAAE,EAAE;QACjE,MAAM,GAAG,GAAG,MAAM,CAAC,eAAe,EAAE,CAAC,CAAC,CAAC;QACvC,aAAa,CAAC,IAAI,CAAC,GAAG,EAAE,yBAAyB,CAAC,EAAE,IAAI,CAAC,SAAS,CAAC;YAClE,EAAE,EAAE,MAAM;YACV,IAAI,EAAE,MAAM;SACZ,CAAC,EAAE,OAAO,CAAC,CAAC;QACb,MAAM,CAAC,SAAS,CAAC,uBAAuB,CAAC,GAAG,CAAC,EAAE,EAAE,CAAC,CAAC;IACpD,CAAC,CAAC,CAAC;AACJ,CAAC,CAAC,CAAC;AAEH,iFAAiF;AAEjF,QAAQ,CAAC,4BAA4B,EAAE,GAAG,EAAE;IAC3C,EAAE,CAAC,6CAA6C,EAAE,CAAC,CAAC,EAAE,EAAE;QACvD,MAAM,GAAG,GAAG,MAAM,CAAC,mBAAmB,EAAE,CAAC,CAAC,CAAC;QAC3C,aAAa,CAAC,IAAI,CAAC,GAAG,EAAE,yBAAyB,CAAC,EAAE,IAAI,CAAC,SAAS,CAAC;YAClE,YAAY,EAAE,EAAE,OAAO,EAAE,CAAC,QAAQ,CAAC,EAAE;SACrC,CAAC,EAAE,OAAO,CAAC,CAAC;QACb,MAAM,CAAC,SAAS,CAAC,0BAA0B,CAAC,GAAG,EAAE,EAAE,CAAC,EAAE,CAAC,QAAQ,CAAC,CAAC,CAAC;IACnE,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,qDAAqD,EAAE,CAAC,CAAC,EAAE,EAAE;QAC/D,MAAM,IAAI,GAAG,MAAM,CAAC,eAAe,EAAE,CAAC,CAAC,CAAC;QACxC,MAAM,YAAY,GAAG,IAAI,CAAC,IAAI,EAAE,WAAW,CAAC,CAAC;QAC7C,MAAM,QAAQ,GAAG,IAAI,CAAC,IAAI,EAAE,OAAO,CAAC,CAAC;QACrC,SAAS,CAAC,YAAY,EAAE,EAAE,SAAS,EAAE,IAAI,EAAE,CAAC,CAAC;QAC7C,SAAS,CAAC,QAAQ,EAAE,EAAE,SAAS,EAAE,IAAI,EAAE,CAAC,CAAC;QACzC,aAAa,CAAC,IAAI,CAAC,QAAQ,EAAE,yBAAyB,CAAC,EAAE,IAAI,CAAC,SAAS,CAAC;YACvE,YAAY,EAAE,EAAE,OAAO,EAAE,CAAC,QAAQ,CAAC,EAAE;SACrC,CAAC,EAAE,OAAO,CAAC,CAAC;QACb,MAAM,IAAI,GAAG,0BAA0B,CAAC,YAAY,EAAE,CAAC,IAAI,CAAC,QAAQ,EAAE,UAAU,CAAC,CAAC,CAAC,CAAC;QACpF,MAAM,CAAC,SAAS,CAAC,IAAI,EAAE,CAAC,QAAQ,CAAC,CAAC,CAAC;IACpC,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,0CAA0C,EAAE,CAAC,CAAC,EAAE,EAAE;QACpD,MAAM,IAAI,GAAG,MAAM,CAAC,eAAe,EAAE,CAAC,CAAC,CAAC;QACxC,MAAM,IAAI,GAAG,IAAI,CAAC,IAAI,EAAE,MAAM,CAAC,CAAC;QAChC,MAAM,IAAI,GAAG,IAAI,CAAC,IAAI,EAAE,MAAM,CAAC,CAAC;QAChC,SAAS,CAAC,IAAI,EAAE,EAAE,SAAS,EAAE,IAAI,EAAE,CAAC,CAAC;QACrC,SAAS,CAAC,IAAI,EAAE,EAAE,SAAS,EAAE,IAAI,EAAE,CAAC,CAAC;QACrC,aAAa,CAAC,IAAI,CAAC,IAAI,EAAE,yBAAyB,CAAC,EAAE,IAAI,CAAC,SAAS,CAAC;YACnE,YAAY,EAAE,EAAE,OAAO,EAAE,CAAC,MAAM,EAAE,QAAQ,CAAC,EAAE;SAC7C,CAAC,EAAE,OAAO,CAAC,CAAC;QACb,aAAa,CAAC,IAAI,CAAC,IAAI,EAAE,yBAAyB,CAAC,EAAE,IAAI,CAAC,SAAS,CAAC;YACnE,YAAY,EAAE,EAAE,OAAO,EAAE,CAAC,QAAQ,EAAE,QAAQ,CAAC,EAAE;SAC/C,CAAC,EAAE,OAAO,CAAC,CAAC;QACb,MAAM,IAAI,GAAG,0BAA0B,CAAC,IAAI,EAAE,CAAC,IAAI,CAAC,IAAI,EAAE,UAAU,CAAC,CAAC,CAAC,CAAC;QACxE,MAAM,CAAC,KAAK,CAAC,IAAI,CAAC,MAAM,EAAE,CAAC,CAAC,CAAC;QAC7B,MAAM,CAAC,EAAE,CAAC,IAAI,CAAC,QAAQ,CAAC,MAAM,CAAC,CAAC,CAAC;QACjC,MAAM,CAAC,EAAE,CAAC,IAAI,CAAC,QAAQ,CAAC,QAAQ,CAAC,CAAC,CAAC;QACnC,MAAM,CAAC,EAAE,CAAC,IAAI,CAAC,QAAQ,CAAC,QAAQ,CAAC,CAAC,CAAC;IACpC,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,kDAAkD,EAAE,CAAC,CAAC,EAAE,EAAE;QAC5D,MAAM,GAAG,GAAG,MAAM,CAAC,eAAe,EAAE,CAAC,CAAC,CAAC;QACvC,MAAM,CAAC,SAAS,CAAC,0BAA0B,CAAC,GAAG,EAAE,EAAE,CAAC,EAAE,EAAE,CAAC,CAAC;IAC3D,CAAC,CAAC,CAAC;AACJ,CAAC,CAAC,CAAC;AAEH,iFAAiF;AAEjF,QAAQ,CAAC,2BAA2B,EAAE,GAAG,EAAE;IAC1C,EAAE,CAAC,qCAAqC,EAAE,GAAG,EAAE;QAC9C,MAAM,CAAC,YAAY,CAAC,GAAG,EAAE,CAAC,yBAAyB,CAAC,EAAE,EAAE,aAAa,EAAE,IAAI,CAAC,CAAC,CAAC;IAC/E,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,0CAA0C,EAAE,GAAG,EAAE;QACnD,MAAM,CAAC,YAAY,CAAC,GAAG,EAAE,CAAC,yBAAyB,CAAC,CAAC,MAAM,CAAC,EAAE,aAAa,EAAE,IAAI,CAAC,CAAC,CAAC;IACrF,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,oEAAoE,EAAE,GAAG,EAAE;QAC7E,MAAM,CAAC,MAAM,CACZ,GAAG,EAAE,CAAC,yBAAyB,CAAC,CAAC,8BAA8B,CAAC,EAAE,aAAa,EAAE,IAAI,CAAC,EACtF,CAAC,GAAU,EAAE,EAAE;YACd,MAAM,CAAC,EAAE,CAAC,GAAG,CAAC,OAAO,CAAC,QAAQ,CAAC,8BAA8B,CAAC,CAAC,CAAC;YAChE,MAAM,CAAC,EAAE,CAAC,GAAG,CAAC,OAAO,CAAC,QAAQ,CAAC,8BAA8B,CAAC,CAAC,CAAC;YAChE,OAAO,IAAI,CAAC;QACb,CAAC,CACD,CAAC;IACH,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,yCAAyC,EAAE,GAAG,EAAE;QAClD,MAAM,CAAC,MAAM,CACZ,GAAG,EAAE,CAAC,yBAAyB,CAAC,CAAC,eAAe,EAAE,eAAe,CAAC,EAAE,aAAa,EAAE,IAAI,CAAC,EACxF,CAAC,GAAU,EAAE,EAAE;YACd,MAAM,CAAC,EAAE,CAAC,GAAG,CAAC,OAAO,CAAC,QAAQ,CAAC,eAAe,CAAC,CAAC,CAAC;YACjD,MAAM,CAAC,EAAE,CAAC,GAAG,CAAC,OAAO,CAAC,QAAQ,CAAC,eAAe,CAAC,CAAC,CAAC;YACjD,OAAO,IAAI,CAAC;QACb,CAAC,CACD,CAAC;IACH,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,qDAAqD,EAAE,GAAG,EAAE;QAC9D,MAAM,CAAC,MAAM,CACZ,GAAG,EAAE,CAAC,yBAAyB,CAAC,CAAC,aAAa,CAAC,EAAE,kBAAkB,EAAE,KAAK,CAAC,EAC3E,CAAC,GAAU,EAAE,EAAE;YACd,MAAM,CAAC,EAAE,CAAC,GAAG,CAAC,OAAO,CAAC,QAAQ,CAAC,KAAK,CAAC,CAAC,CAAC;YACvC,MAAM,CAAC,EAAE,CAAC,GAAG,CAAC,OAAO,CAAC,QAAQ,CAAC,kBAAkB,CAAC,CAAC,CAAC;YACpD,OAAO,IAAI,CAAC;QACb,CAAC,CACD,CAAC;IACH,CAAC,CAAC,CAAC;AACJ,CAAC,CAAC,CAAC;AAEH,iFAAiF;AAEjF,QAAQ,CAAC,wBAAwB,EAAE,GAAG,EAAE;IACvC,EAAE,CAAC,oCAAoC,EAAE,GAAG,EAAE;QAC7C,MAAM,CAAC,KAAK,CAAC,sBAAsB,CAAC,EAAE,EAAE,MAAM,CAAC,EAAE,SAAS,CAAC,CAAC;IAC7D,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,mCAAmC,EAAE,GAAG,EAAE;QAC5C,MAAM,CAAC,KAAK,CAAC,sBAAsB,CAAC,cAAc,EAAE,MAAM,CAAC,EAAE,SAAS,CAAC,CAAC;IACzE,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,+BAA+B,EAAE,GAAG,EAAE;QACxC,MAAM,CAAC,KAAK,CAAC,sBAAsB,CAAC,0BAA0B,EAAE,MAAM,CAAC,EAAE,SAAS,CAAC,CAAC;IACrF,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,qCAAqC,EAAE,GAAG,EAAE;QAC9C,MAAM,CAAC,KAAK,CAAC,sBAAsB,CAAC,8BAA8B,EAAE,MAAM,CAAC,EAAE,SAAS,CAAC,CAAC;IACzF,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,uBAAuB,EAAE,GAAG,EAAE;QAChC,MAAM,MAAM,GAAG,sBAAsB,CAAC,GAAG,EAAE,MAAM,CAAC,CAAC;QACnD,IAAI,UAAU,CAAC,OAAO,EAAE,CAAC,EAAE,CAAC;YAC3B,MAAM,CAAC,KAAK,CAAC,MAAM,EAAE,OAAO,EAAE,CAAC,CAAC;QACjC,CAAC;aAAM,CAAC;YACP,MAAM,CAAC,KAAK,CAAC,MAAM,EAAE,SAAS,CAAC,CAAC;QACjC,CAAC;IACF,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,qCAAqC,EAAE,GAAG,EAAE;QAC9C,MAAM,MAAM,GAAG,sBAAsB,CAAC,IAAI,EAAE,MAAM,CAAC,CAAC;QACpD,IAAI,UAAU,CAAC,OAAO,EAAE,CAAC,EAAE,CAAC;YAC3B,MAAM,CAAC,KAAK,CAAC,MAAM,EAAE,OAAO,EAAE,CAAC,CAAC;QACjC,CAAC;aAAM,CAAC;YACP,MAAM,CAAC,KAAK,CAAC,MAAM,EAAE,SAAS,CAAC,CAAC;QACjC,CAAC;IACF,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,oCAAoC,EAAE,CAAC,CAAC,EAAE,EAAE;QAC9C,MAAM,GAAG,GAAG,MAAM,CAAC,aAAa,EAAE,CAAC,CAAC,CAAC;QACrC,MAAM,GAAG,GAAG,IAAI,CAAC,GAAG,EAAE,OAAO,CAAC,CAAC;QAC/B,SAAS,CAAC,GAAG,EAAE,EAAE,SAAS,EAAE,IAAI,EAAE,CAAC,CAAC;QACpC,MAAM,MAAM,GAAG,sBAAsB,CAAC,OAAO,EAAE,GAAG,CAAC,CAAC;QACpD,MAAM,CAAC,KAAK,CAAC,MAAM,EAAE,OAAO,CAAC,GAAG,EAAE,OAAO,CAAC,CAAC,CAAC;IAC7C,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,yDAAyD,EAAE,CAAC,CAAC,EAAE,EAAE;QACnE,MAAM,GAAG,GAAG,MAAM,CAAC,iBAAiB,EAAE,CAAC,CAAC,CAAC;QACzC,MAAM,CAAC,KAAK,CAAC,sBAAsB,CAAC,aAAa,EAAE,GAAG,CAAC,EAAE,SAAS,CAAC,CAAC;IACrE,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,oCAAoC,EAAE,CAAC,CAAC,EAAE,EAAE;QAC9C,MAAM,GAAG,GAAG,MAAM,CAAC,aAAa,EAAE,CAAC,CAAC,CAAC;QACrC,MAAM,CAAC,KAAK,CAAC,sBAAsB,CAAC,GAAG,EAAE,aAAa,CAAC,EAAE,GAAG,CAAC,CAAC;IAC/D,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,yDAAyD,EAAE,GAAG,EAAE;QAClE,MAAM,CAAC,KAAK,CAAC,sBAAsB,CAAC,oCAAoC,EAAE,MAAM,CAAC,EAAE,SAAS,CAAC,CAAC;IAC/F,CAAC,CAAC,CAAC;AACJ,CAAC,CAAC,CAAC","sourcesContent":["import assert from \"node:assert/strict\";\nimport { mkdtempSync, mkdirSync, rmSync, writeFileSync, existsSync } from \"node:fs\";\nimport { homedir, tmpdir } from \"node:os\";\nimport { join, resolve } from \"node:path\";\nimport { describe, it } from \"node:test\";\nimport {\n\treadManifestRuntimeDeps,\n\tcollectRuntimeDependencies,\n\tverifyRuntimeDependencies,\n\tresolveLocalSourcePath,\n} from \"./lifecycle-hooks.js\";\n\nfunction tmpDir(prefix: string, t: { after: (fn: () => void) => void }): string {\n\tconst dir = mkdtempSync(join(tmpdir(), `pi-lh-${prefix}-`));\n\tt.after(() => rmSync(dir, { recursive: true, force: true }));\n\treturn dir;\n}\n\n// ─── readManifestRuntimeDeps ──────────────────────────────────────────────────\n\ndescribe(\"readManifestRuntimeDeps\", () => {\n\tit(\"returns empty array when manifest file is missing\", (t) => {\n\t\tconst dir = tmpDir(\"no-manifest\", t);\n\t\tassert.deepEqual(readManifestRuntimeDeps(dir), []);\n\t});\n\n\tit(\"returns empty array for malformed JSON\", (t) => {\n\t\tconst dir = tmpDir(\"bad-json\", t);\n\t\twriteFileSync(join(dir, \"extension-manifest.json\"), \"not json{{{\", \"utf-8\");\n\t\tassert.deepEqual(readManifestRuntimeDeps(dir), []);\n\t});\n\n\tit(\"returns runtime deps from valid manifest\", (t) => {\n\t\tconst dir = tmpDir(\"valid\", t);\n\t\twriteFileSync(join(dir, \"extension-manifest.json\"), JSON.stringify({\n\t\t\tdependencies: { runtime: [\"claude\", \"node\"] },\n\t\t}), \"utf-8\");\n\t\tassert.deepEqual(readManifestRuntimeDeps(dir), [\"claude\", \"node\"]);\n\t});\n\n\tit(\"returns empty array when dependencies exists but runtime is missing\", (t) => {\n\t\tconst dir = tmpDir(\"no-runtime\", t);\n\t\twriteFileSync(join(dir, \"extension-manifest.json\"), JSON.stringify({\n\t\t\tdependencies: {},\n\t\t}), \"utf-8\");\n\t\tassert.deepEqual(readManifestRuntimeDeps(dir), []);\n\t});\n\n\tit(\"returns empty array when runtime is empty\", (t) => {\n\t\tconst dir = tmpDir(\"empty-runtime\", t);\n\t\twriteFileSync(join(dir, \"extension-manifest.json\"), JSON.stringify({\n\t\t\tdependencies: { runtime: [] },\n\t\t}), \"utf-8\");\n\t\tassert.deepEqual(readManifestRuntimeDeps(dir), []);\n\t});\n\n\tit(\"filters out non-string entries in runtime array\", (t) => {\n\t\tconst dir = tmpDir(\"mixed-types\", t);\n\t\twriteFileSync(join(dir, \"extension-manifest.json\"), JSON.stringify({\n\t\t\tdependencies: { runtime: [123, null, \"node\", false, \"python\"] },\n\t\t}), \"utf-8\");\n\t\tassert.deepEqual(readManifestRuntimeDeps(dir), [\"node\", \"python\"]);\n\t});\n\n\tit(\"returns empty array when no dependencies field at all\", (t) => {\n\t\tconst dir = tmpDir(\"no-deps-field\", t);\n\t\twriteFileSync(join(dir, \"extension-manifest.json\"), JSON.stringify({\n\t\t\tid: \"test\",\n\t\t\tname: \"Test\",\n\t\t}), \"utf-8\");\n\t\tassert.deepEqual(readManifestRuntimeDeps(dir), []);\n\t});\n});\n\n// ─── collectRuntimeDependencies ───────────────────────────────────────────────\n\ndescribe(\"collectRuntimeDependencies\", () => {\n\tit(\"aggregates deps from installedPath manifest\", (t) => {\n\t\tconst dir = tmpDir(\"collect-installed\", t);\n\t\twriteFileSync(join(dir, \"extension-manifest.json\"), JSON.stringify({\n\t\t\tdependencies: { runtime: [\"claude\"] },\n\t\t}), \"utf-8\");\n\t\tassert.deepEqual(collectRuntimeDependencies(dir, []), [\"claude\"]);\n\t});\n\n\tit(\"aggregates deps from entry path directory manifests\", (t) => {\n\t\tconst root = tmpDir(\"collect-entry\", t);\n\t\tconst installedDir = join(root, \"installed\");\n\t\tconst entryDir = join(root, \"entry\");\n\t\tmkdirSync(installedDir, { recursive: true });\n\t\tmkdirSync(entryDir, { recursive: true });\n\t\twriteFileSync(join(entryDir, \"extension-manifest.json\"), JSON.stringify({\n\t\t\tdependencies: { runtime: [\"python\"] },\n\t\t}), \"utf-8\");\n\t\tconst deps = collectRuntimeDependencies(installedDir, [join(entryDir, \"index.ts\")]);\n\t\tassert.deepEqual(deps, [\"python\"]);\n\t});\n\n\tit(\"deduplicates across multiple directories\", (t) => {\n\t\tconst root = tmpDir(\"collect-dedup\", t);\n\t\tconst dir1 = join(root, \"dir1\");\n\t\tconst dir2 = join(root, \"dir2\");\n\t\tmkdirSync(dir1, { recursive: true });\n\t\tmkdirSync(dir2, { recursive: true });\n\t\twriteFileSync(join(dir1, \"extension-manifest.json\"), JSON.stringify({\n\t\t\tdependencies: { runtime: [\"node\", \"python\"] },\n\t\t}), \"utf-8\");\n\t\twriteFileSync(join(dir2, \"extension-manifest.json\"), JSON.stringify({\n\t\t\tdependencies: { runtime: [\"python\", \"claude\"] },\n\t\t}), \"utf-8\");\n\t\tconst deps = collectRuntimeDependencies(dir1, [join(dir2, \"index.ts\")]);\n\t\tassert.equal(deps.length, 3);\n\t\tassert.ok(deps.includes(\"node\"));\n\t\tassert.ok(deps.includes(\"python\"));\n\t\tassert.ok(deps.includes(\"claude\"));\n\t});\n\n\tit(\"returns empty when no directories have manifests\", (t) => {\n\t\tconst dir = tmpDir(\"collect-empty\", t);\n\t\tassert.deepEqual(collectRuntimeDependencies(dir, []), []);\n\t});\n});\n\n// ─── verifyRuntimeDependencies ────────────────────────────────────────────────\n\ndescribe(\"verifyRuntimeDependencies\", () => {\n\tit(\"does not throw for empty deps array\", () => {\n\t\tassert.doesNotThrow(() => verifyRuntimeDependencies([], \"test-source\", \"pi\"));\n\t});\n\n\tit(\"does not throw when all deps are present\", () => {\n\t\tassert.doesNotThrow(() => verifyRuntimeDependencies([\"node\"], \"test-source\", \"pi\"));\n\t});\n\n\tit(\"throws for missing dep with 'Missing runtime dependencies' message\", () => {\n\t\tassert.throws(\n\t\t\t() => verifyRuntimeDependencies([\"__nonexistent_dep_for_test__\"], \"test-source\", \"pi\"),\n\t\t\t(err: Error) => {\n\t\t\t\tassert.ok(err.message.includes(\"Missing runtime dependencies\"));\n\t\t\t\tassert.ok(err.message.includes(\"__nonexistent_dep_for_test__\"));\n\t\t\t\treturn true;\n\t\t\t},\n\t\t);\n\t});\n\n\tit(\"lists all missing deps in error message\", () => {\n\t\tassert.throws(\n\t\t\t() => verifyRuntimeDependencies([\"__missing_1__\", \"__missing_2__\"], \"test-source\", \"pi\"),\n\t\t\t(err: Error) => {\n\t\t\t\tassert.ok(err.message.includes(\"__missing_1__\"));\n\t\t\t\tassert.ok(err.message.includes(\"__missing_2__\"));\n\t\t\t\treturn true;\n\t\t\t},\n\t\t);\n\t});\n\n\tit(\"includes appName and source in error for retry hint\", () => {\n\t\tassert.throws(\n\t\t\t() => verifyRuntimeDependencies([\"__missing__\"], \"github:user/repo\", \"gsd\"),\n\t\t\t(err: Error) => {\n\t\t\t\tassert.ok(err.message.includes(\"gsd\"));\n\t\t\t\tassert.ok(err.message.includes(\"github:user/repo\"));\n\t\t\t\treturn true;\n\t\t\t},\n\t\t);\n\t});\n});\n\n// ─── resolveLocalSourcePath ───────────────────────────────────────────────────\n\ndescribe(\"resolveLocalSourcePath\", () => {\n\tit(\"returns undefined for empty string\", () => {\n\t\tassert.equal(resolveLocalSourcePath(\"\", \"/tmp\"), undefined);\n\t});\n\n\tit(\"returns undefined for npm: source\", () => {\n\t\tassert.equal(resolveLocalSourcePath(\"npm:@foo/bar\", \"/tmp\"), undefined);\n\t});\n\n\tit(\"returns undefined for git URL\", () => {\n\t\tassert.equal(resolveLocalSourcePath(\"git:github.com/user/repo\", \"/tmp\"), undefined);\n\t});\n\n\tit(\"returns undefined for https git URL\", () => {\n\t\tassert.equal(resolveLocalSourcePath(\"https://github.com/user/repo\", \"/tmp\"), undefined);\n\t});\n\n\tit(\"resolves ~ to homedir\", () => {\n\t\tconst result = resolveLocalSourcePath(\"~\", \"/tmp\");\n\t\tif (existsSync(homedir())) {\n\t\t\tassert.equal(result, homedir());\n\t\t} else {\n\t\t\tassert.equal(result, undefined);\n\t\t}\n\t});\n\n\tit(\"resolves ~/path relative to homedir\", () => {\n\t\tconst result = resolveLocalSourcePath(\"~/\", \"/tmp\");\n\t\tif (existsSync(homedir())) {\n\t\t\tassert.equal(result, homedir());\n\t\t} else {\n\t\t\tassert.equal(result, undefined);\n\t\t}\n\t});\n\n\tit(\"resolves relative path that exists\", (t) => {\n\t\tconst dir = tmpDir(\"resolve-rel\", t);\n\t\tconst sub = join(dir, \"myext\");\n\t\tmkdirSync(sub, { recursive: true });\n\t\tconst result = resolveLocalSourcePath(\"myext\", dir);\n\t\tassert.equal(result, resolve(dir, \"myext\"));\n\t});\n\n\tit(\"returns undefined for relative path that does not exist\", (t) => {\n\t\tconst dir = tmpDir(\"resolve-noexist\", t);\n\t\tassert.equal(resolveLocalSourcePath(\"nonexistent\", dir), undefined);\n\t});\n\n\tit(\"resolves absolute path that exists\", (t) => {\n\t\tconst dir = tmpDir(\"resolve-abs\", t);\n\t\tassert.equal(resolveLocalSourcePath(dir, \"/irrelevant\"), dir);\n\t});\n\n\tit(\"returns undefined for absolute path that does not exist\", () => {\n\t\tassert.equal(resolveLocalSourcePath(\"/tmp/__nonexistent_path_for_test__\", \"/tmp\"), undefined);\n\t});\n});\n"]}

package/packages/pi-coding-agent/dist/core/model-registry-auth-mode.test.js

@@ -1,5 +1,6 @@
 import assert from "node:assert/strict";
 import { describe, it } from "node:test";
+import { getApiProvider } from "@gsd/pi-ai";
 import { ModelRegistry } from "./model-registry.js";
 function createRegistry(hasAuthFn) {
     const authStorage = {
@@ -12,11 +13,11 @@ function createRegistry(hasAuthFn) {
     };
     return new ModelRegistry(authStorage, undefined);
 }
-function createProviderModel(id) {
+function createProviderModel(id, api) {
     return {
         id,
         name: id,
-        api: "openai-completions",
+        api: (api ?? "openai-completions"),
         reasoning: false,
         input: ["text"],
         cost: { input: 0, output: 0, cacheRead: 0, cacheWrite: 0 },
@@ -27,31 +28,79 @@ function createProviderModel(id) {
 function findModel(registry, provider, id) {
     return registry.getAvailable().find((m) => m.provider === provider && m.id === id);
 }
+function makeModel(provider, id, api) {
+    return {
+        id,
+        name: id,
+        api: api,
+        provider,
+        baseUrl: `${provider}:`,
+        reasoning: false,
+        input: ["text"],
+        cost: { input: 0, output: 0, cacheRead: 0, cacheWrite: 0 },
+        contextWindow: 128000,
+        maxTokens: 16384,
+    };
+}
+function makeContext() {
+    return {
+        systemPrompt: "test",
+        messages: [{ role: "user", content: "hello", timestamp: Date.now() }],
+    };
+}
+/** No-op streamSimple for tests that need one to pass validation but don't inspect it. */
+const noopStreamSimple = (_model, _context, _options) => {
+    return {
+        [Symbol.asyncIterator]() { return { next: async () => ({ value: undefined, done: true }) }; },
+        result: () => Promise.resolve({ role: "assistant", content: [], api: "test", provider: "test", model: "test", usage: { input: 0, output: 0, cacheRead: 0, cacheWrite: 0, totalTokens: 0, cost: { input: 0, output: 0, cacheRead: 0, cacheWrite: 0, total: 0 } }, stopReason: "stop", timestamp: Date.now() }),
+        push: () => { },
+        end: () => { },
+    };
+};
+/** Create a spy streamSimple that captures the options it receives and returns a stub stream. */
+function createStreamSpy() {
+    let capturedOptions;
+    const streamSimple = (_model, _context, options) => {
+        capturedOptions = options;
+        // Return a minimal stub that satisfies AssistantMessageEventStream
+        return {
+            [Symbol.asyncIterator]() { return { next: async () => ({ value: undefined, done: true }) }; },
+            result: () => Promise.resolve({ role: "assistant", content: [], api: "test", provider: "test", model: "test", usage: { input: 0, output: 0, cacheRead: 0, cacheWrite: 0, totalTokens: 0, cost: { input: 0, output: 0, cacheRead: 0, cacheWrite: 0, total: 0 } }, stopReason: "stop", timestamp: Date.now() }),
+            push: () => { },
+            end: () => { },
+        };
+    };
+    return { streamSimple, getCapturedOptions: () => capturedOptions };
+}
 // ─── Registration ─────────────────────────────────────────────────────────────
 describe("ModelRegistry authMode — registration", () => {
-    it("registers externalCli provider without apiKey/oauth", () => {
+    it("registers externalCli provider with streamSimple and without apiKey/oauth", () => {
         const registry = createRegistry();
+        const spy = createStreamSpy();
         assert.doesNotThrow(() => {
             registry.registerProvider("cli-provider", {
                 authMode: "externalCli",
                 baseUrl: "https://cli.local",
                 api: "openai-completions",
+                streamSimple: spy.streamSimple,
                 models: [createProviderModel("cli-model")],
             });
         });
     });
-    it("registers none provider without apiKey/oauth", () => {
+    it("registers none provider with streamSimple and without apiKey/oauth", () => {
         const registry = createRegistry();
+        const spy = createStreamSpy();
         assert.doesNotThrow(() => {
             registry.registerProvider("none-provider", {
                 authMode: "none",
                 baseUrl: "http://localhost:11434",
                 api: "openai-completions",
+                streamSimple: spy.streamSimple,
                 models: [createProviderModel("local-model")],
             });
         });
     });
-    it("rejects apiKey provider without apiKey or oauth", () => {
+    it("rejects apiKey provider without apiKey or oauth — message mentions authMode", () => {
         const registry = createRegistry();
         assert.throws(() => {
             registry.registerProvider("apikey-provider", {
@@ -60,6 +109,10 @@ describe("ModelRegistry authMode — registration", () => {
                 api: "openai-completions",
                 models: [createProviderModel("model")],
             });
+        }, (err) => {
+            assert.ok(err.message.includes("authMode"), "error message must mention authMode");
+            assert.ok(err.message.includes("externalCli"), "error message must suggest externalCli");
+            return true;
         });
     });
     it("rejects provider with no authMode and no apiKey/oauth (defaults to apiKey)", () => {
@@ -70,6 +123,75 @@ describe("ModelRegistry authMode — registration", () => {
                 api: "openai-completions",
                 models: [createProviderModel("model")],
             });
+        }, (err) => {
+            assert.ok(err.message.includes("authMode"), "error message must mention authMode");
+            return true;
+        });
+    });
+    it("rejects externalCli provider without streamSimple", () => {
+        const registry = createRegistry();
+        assert.throws(() => {
+            registry.registerProvider("cli-no-stream", {
+                authMode: "externalCli",
+                baseUrl: "https://cli.local",
+                api: "openai-completions",
+                models: [createProviderModel("model")],
+            });
+        }, (err) => {
+            assert.ok(err.message.includes("streamSimple"), "error message must mention streamSimple");
+            assert.ok(err.message.includes("externalCli"), "error message must mention authMode");
+            return true;
+        });
+    });
+    it("rejects none provider without streamSimple", () => {
+        const registry = createRegistry();
+        assert.throws(() => {
+            registry.registerProvider("none-no-stream", {
+                authMode: "none",
+                baseUrl: "http://localhost:11434",
+                api: "openai-completions",
+                models: [createProviderModel("model")],
+            });
+        }, (err) => {
+            assert.ok(err.message.includes("streamSimple"), "error message must mention streamSimple");
+            assert.ok(err.message.includes("none"), "error message must mention authMode");
+            return true;
+        });
+    });
+    it("rejects externalCli provider that also sets apiKey", () => {
+        const registry = createRegistry();
+        const spy = createStreamSpy();
+        assert.throws(() => {
+            registry.registerProvider("cli-with-key", {
+                authMode: "externalCli",
+                baseUrl: "https://cli.local",
+                api: "openai-completions",
+                apiKey: "SHOULD_NOT_EXIST",
+                streamSimple: spy.streamSimple,
+                models: [createProviderModel("model")],
+            });
+        }, (err) => {
+            assert.ok(err.message.includes("apiKey"), "error message must mention apiKey");
+            assert.ok(err.message.includes("externalCli"), "error message must mention authMode");
+            return true;
+        });
+    });
+    it("rejects none provider that also sets apiKey", () => {
+        const registry = createRegistry();
+        const spy = createStreamSpy();
+        assert.throws(() => {
+            registry.registerProvider("none-with-key", {
+                authMode: "none",
+                baseUrl: "http://localhost:11434",
+                api: "openai-completions",
+                apiKey: "SHOULD_NOT_EXIST",
+                streamSimple: spy.streamSimple,
+                models: [createProviderModel("model")],
+            });
+        }, (err) => {
+            assert.ok(err.message.includes("apiKey"), "error message must mention apiKey");
+            assert.ok(err.message.includes("none"), "error message must mention authMode");
+            return true;
         });
     });
 });
@@ -85,6 +207,7 @@ describe("ModelRegistry authMode — getProviderAuthMode", () => {
             authMode: "externalCli",
             baseUrl: "https://cli.local",
             api: "openai-completions",
+            streamSimple: noopStreamSimple,
             models: [createProviderModel("m")],
         });
         assert.equal(registry.getProviderAuthMode("cli"), "externalCli");
@@ -95,6 +218,7 @@ describe("ModelRegistry authMode — getProviderAuthMode", () => {
             authMode: "none",
             baseUrl: "http://localhost:11434",
             api: "openai-completions",
+            streamSimple: noopStreamSimple,
             models: [createProviderModel("m")],
         });
         assert.equal(registry.getProviderAuthMode("local"), "none");
@@ -108,6 +232,7 @@ describe("ModelRegistry authMode — isProviderRequestReady", () => {
             authMode: "externalCli",
             baseUrl: "https://cli.local",
             api: "openai-completions",
+            streamSimple: noopStreamSimple,
             models: [createProviderModel("m")],
         });
         assert.equal(registry.isProviderRequestReady("cli"), true);
@@ -118,6 +243,7 @@ describe("ModelRegistry authMode — isProviderRequestReady", () => {
             authMode: "none",
             baseUrl: "http://localhost:11434",
             api: "openai-completions",
+            streamSimple: noopStreamSimple,
             models: [createProviderModel("m")],
         });
         assert.equal(registry.isProviderRequestReady("local"), true);
@@ -139,6 +265,7 @@ describe("ModelRegistry authMode — isReady callback", () => {
             authMode: "externalCli",
             baseUrl: "https://cli.local",
             api: "openai-completions",
+            streamSimple: noopStreamSimple,
             isReady: () => false,
             models: [createProviderModel("m")],
         });
@@ -161,6 +288,7 @@ describe("ModelRegistry authMode — isReady callback", () => {
             authMode: "externalCli",
             baseUrl: "https://cli.local",
             api: "openai-completions",
+            streamSimple: noopStreamSimple,
             isReady: () => true,
             models: [createProviderModel("m")],
         });
@@ -172,6 +300,7 @@ describe("ModelRegistry authMode — isReady callback", () => {
             authMode: "externalCli",
             baseUrl: "https://cli.local",
             api: "openai-completions",
+            streamSimple: noopStreamSimple,
             models: [createProviderModel("m")],
         });
         // externalCli without isReady → true (default)
@@ -186,6 +315,7 @@ describe("ModelRegistry authMode — getAvailable", () => {
             authMode: "externalCli",
             baseUrl: "https://cli.local",
             api: "openai-completions",
+            streamSimple: noopStreamSimple,
             models: [createProviderModel("cli-model")],
         });
         assert.ok(findModel(registry, "cli", "cli-model"));
@@ -196,6 +326,7 @@ describe("ModelRegistry authMode — getAvailable", () => {
             authMode: "none",
             baseUrl: "http://localhost:11434",
             api: "openai-completions",
+            streamSimple: noopStreamSimple,
             models: [createProviderModel("local-model")],
         });
         assert.ok(findModel(registry, "local", "local-model"));
@@ -206,6 +337,7 @@ describe("ModelRegistry authMode — getAvailable", () => {
             authMode: "externalCli",
             baseUrl: "https://cli.local",
             api: "openai-completions",
+            streamSimple: noopStreamSimple,
             isReady: () => false,
             models: [createProviderModel("m")],
         });
@@ -213,10 +345,7 @@ describe("ModelRegistry authMode — getAvailable", () => {
     });
     it("excludes apiKey models without stored auth", () => {
         const registry = createRegistry(() => false);
-        // Built-in providers have no registeredProviders entry, so authMode defaults to apiKey
-        // getAvailable filters by isProviderRequestReady → hasAuth → false
         const available = registry.getAvailable();
-        // No models should be available since hasAuth returns false for everything
         assert.equal(available.length, 0);
     });
 });
@@ -228,6 +357,7 @@ describe("ModelRegistry authMode — getApiKey", () => {
             authMode: "externalCli",
             baseUrl: "https://cli.local",
             api: "openai-completions",
+            streamSimple: noopStreamSimple,
             models: [createProviderModel("m")],
         });
         const model = registry.getAll().find((m) => m.provider === "cli");
@@ -239,6 +369,7 @@ describe("ModelRegistry authMode — getApiKey", () => {
             authMode: "none",
             baseUrl: "http://localhost:11434",
             api: "openai-completions",
+            streamSimple: noopStreamSimple,
             models: [createProviderModel("m")],
         });
         const model = registry.getAll().find((m) => m.provider === "local");
@@ -246,10 +377,108 @@ describe("ModelRegistry authMode — getApiKey", () => {
     });
     it("delegates to authStorage for apiKey provider", async () => {
         const registry = createRegistry();
-        // authStorage.getApiKey returns undefined (no key configured)
-        // For apiKey providers this is an expected "no key" response, not early exit
         const key = await registry.getApiKeyForProvider("anthropic");
         assert.equal(key, undefined);
     });
 });
+// ─── streamSimple apiKey stripping ────────────────────────────────────────────
+describe("ModelRegistry authMode — streamSimple apiKey boundary", () => {
+    it("strips apiKey from options for externalCli provider", () => {
+        const registry = createRegistry();
+        const spy = createStreamSpy();
+        const apiType = `ext-cli-strip-${Date.now()}`;
+        registry.registerProvider("cli-strip", {
+            authMode: "externalCli",
+            baseUrl: "https://cli.local",
+            api: apiType,
+            streamSimple: spy.streamSimple,
+            models: [createProviderModel("m", apiType)],
+        });
+        const provider = getApiProvider(apiType);
+        assert.ok(provider, "provider must be registered in api registry");
+        provider.streamSimple(makeModel("cli-strip", "m", apiType), makeContext(), { apiKey: "should-be-stripped", maxTokens: 1024 });
+        const captured = spy.getCapturedOptions();
+        assert.ok(captured, "streamSimple must have been called");
+        assert.equal("apiKey" in captured, false, "apiKey must not exist in options for externalCli provider");
+        assert.equal(captured.maxTokens, 1024, "other options must pass through");
+    });
+    it("strips apiKey from options for none provider", () => {
+        const registry = createRegistry();
+        const spy = createStreamSpy();
+        const apiType = `none-strip-${Date.now()}`;
+        registry.registerProvider("none-strip", {
+            authMode: "none",
+            baseUrl: "http://localhost:11434",
+            api: apiType,
+            streamSimple: spy.streamSimple,
+            models: [createProviderModel("m", apiType)],
+        });
+        const provider = getApiProvider(apiType);
+        assert.ok(provider, "provider must be registered in api registry");
+        provider.streamSimple(makeModel("none-strip", "m", apiType), makeContext(), { apiKey: "should-be-stripped", maxTokens: 2048 });
+        const captured = spy.getCapturedOptions();
+        assert.ok(captured, "streamSimple must have been called");
+        assert.equal("apiKey" in captured, false, "apiKey must not exist in options for none provider");
+        assert.equal(captured.maxTokens, 2048, "other options must pass through");
+    });
+    it("preserves apiKey in options for apiKey provider", () => {
+        const registry = createRegistry();
+        const spy = createStreamSpy();
+        const apiType = `apikey-preserve-${Date.now()}`;
+        registry.registerProvider("apikey-preserve", {
+            apiKey: "MY_KEY",
+            baseUrl: "https://api.local",
+            api: apiType,
+            streamSimple: spy.streamSimple,
+            models: [createProviderModel("m", apiType)],
+        });
+        const provider = getApiProvider(apiType);
+        assert.ok(provider, "provider must be registered in api registry");
+        provider.streamSimple(makeModel("apikey-preserve", "m", apiType), makeContext(), { apiKey: "sk-real-key", maxTokens: 4096 });
+        const captured = spy.getCapturedOptions();
+        assert.ok(captured, "streamSimple must have been called");
+        assert.equal(captured.apiKey, "sk-real-key", "apiKey must be preserved for apiKey provider");
+        assert.equal(captured.maxTokens, 4096, "other options must pass through");
+    });
+    it("handles undefined options for externalCli provider", () => {
+        const registry = createRegistry();
+        const spy = createStreamSpy();
+        const apiType = `ext-cli-undef-${Date.now()}`;
+        registry.registerProvider("cli-undef", {
+            authMode: "externalCli",
+            baseUrl: "https://cli.local",
+            api: apiType,
+            streamSimple: spy.streamSimple,
+            models: [createProviderModel("m", apiType)],
+        });
+        const provider = getApiProvider(apiType);
+        assert.ok(provider, "provider must be registered in api registry");
+        provider.streamSimple(makeModel("cli-undef", "m", apiType), makeContext(), undefined);
+        const captured = spy.getCapturedOptions();
+        assert.ok(captured !== undefined, "streamSimple must have been called");
+        assert.equal("apiKey" in captured, false, "apiKey must not exist even when options is undefined");
+    });
+    it("strips apiKey but preserves signal and other fields for externalCli", () => {
+        const registry = createRegistry();
+        const spy = createStreamSpy();
+        const apiType = `ext-cli-fields-${Date.now()}`;
+        const abortController = new AbortController();
+        registry.registerProvider("cli-fields", {
+            authMode: "externalCli",
+            baseUrl: "https://cli.local",
+            api: apiType,
+            streamSimple: spy.streamSimple,
+            models: [createProviderModel("m", apiType)],
+        });
+        const provider = getApiProvider(apiType);
+        assert.ok(provider, "provider must be registered in api registry");
+        provider.streamSimple(makeModel("cli-fields", "m", apiType), makeContext(), { apiKey: "strip-me", maxTokens: 8192, signal: abortController.signal, reasoning: "high" });
+        const captured = spy.getCapturedOptions();
+        assert.ok(captured, "streamSimple must have been called");
+        assert.equal("apiKey" in captured, false, "apiKey must be stripped");
+        assert.equal(captured.maxTokens, 8192, "maxTokens must pass through");
+        assert.equal(captured.signal, abortController.signal, "signal must pass through");
+        assert.equal(captured.reasoning, "high", "reasoning must pass through");
+    });
+});
 //# sourceMappingURL=model-registry-auth-mode.test.js.map