gsd-pi 2.45.0-dev.6b9da3e → 2.45.0-dev.fdcf73c

package/packages/pi-coding-agent/src/core/package-commands.test.ts

@@ -1,5 +1,5 @@
 import assert from "node:assert/strict";
-import { mkdtempSync, mkdirSync, readFileSync, rmSync, writeFileSync } from "node:fs";
+import { existsSync, mkdtempSync, mkdirSync, readFileSync, rmSync, writeFileSync } from "node:fs";
 import { tmpdir } from "node:os";
 import { join } from "node:path";
 import { Writable } from "node:stream";
@@ -25,216 +25,238 @@ function writePackage(root: string, files: Record<string, string>): void {
 	}
 }
 
+function createTestDirs(prefix: string, t: { after: (fn: () => void) => void }) {
+	const root = mkdtempSync(join(tmpdir(), `pi-lifecycle-${prefix}-`));
+	t.after(() => rmSync(root, { recursive: true, force: true }));
+	const cwd = join(root, "cwd");
+	const agentDir = join(root, "agent");
+	const extensionDir = join(root, `ext-${prefix}`);
+	mkdirSync(cwd, { recursive: true });
+	mkdirSync(agentDir, { recursive: true });
+	mkdirSync(extensionDir, { recursive: true });
+	return { root, cwd, agentDir, extensionDir };
+}
+
 describe("runPackageCommand lifecycle hooks", () => {
-	it("executes registered beforeInstall and afterInstall handlers for local packages", async () => {
-		const root = mkdtempSync(join(tmpdir(), "pi-lifecycle-install-"));
-		const cwd = join(root, "cwd");
-		const agentDir = join(root, "agent");
-		const extensionDir = join(root, "ext-registered");
-		mkdirSync(cwd, { recursive: true });
-		mkdirSync(agentDir, { recursive: true });
-		mkdirSync(extensionDir, { recursive: true });
-
-		try {
-			writePackage(extensionDir, {
-				"package.json": JSON.stringify({
-					name: "ext-registered",
-					type: "module",
-					pi: { extensions: ["./index.js"] },
-				}),
-				"index.js": `
-					import { writeFileSync } from "node:fs";
-					import { join } from "node:path";
-					export default function (pi) {
-						pi.registerBeforeInstall((ctx) => {
-							writeFileSync(join(ctx.installedPath, "before-install-ran.txt"), "ok", "utf-8");
-						});
-						pi.registerAfterInstall((ctx) => {
-							writeFileSync(join(ctx.installedPath, "after-install-ran.txt"), "ok", "utf-8");
-						});
-					}
-				`,
-			});
-
-			const stdout = createCaptureStream();
-			const stderr = createCaptureStream();
-			const result = await runPackageCommand({
-				appName: "pi",
-				args: ["install", extensionDir],
-				cwd,
-				agentDir,
-				stdout: stdout.stream,
-				stderr: stderr.stream,
-			});
-
-			assert.equal(result.handled, true);
-			assert.equal(result.exitCode, 0);
-			assert.equal(readFileSync(join(extensionDir, "before-install-ran.txt"), "utf-8"), "ok");
-			assert.equal(readFileSync(join(extensionDir, "after-install-ran.txt"), "utf-8"), "ok");
-			assert.ok(stdout.getOutput().includes(`Installed ${extensionDir}`));
-		} finally {
-			rmSync(root, { recursive: true, force: true });
-		}
+	it("executes registered beforeInstall and afterInstall handlers for local packages", async (t) => {
+		const { cwd, agentDir, extensionDir } = createTestDirs("install", t);
+
+		writePackage(extensionDir, {
+			"package.json": JSON.stringify({
+				name: "ext-registered",
+				type: "module",
+				pi: { extensions: ["./index.js"] },
+			}),
+			"index.js": [
+				'import { writeFileSync } from "node:fs";',
+				'import { join } from "node:path";',
+				"export default function (pi) {",
+				"  pi.registerBeforeInstall((ctx) => {",
+				'    writeFileSync(join(ctx.installedPath, "before-install-ran.txt"), "ok", "utf-8");',
+				"  });",
+				"  pi.registerAfterInstall((ctx) => {",
+				'    writeFileSync(join(ctx.installedPath, "after-install-ran.txt"), "ok", "utf-8");',
+				"  });",
+				"}",
+			].join("\n"),
+		});
+
+		const stdout = createCaptureStream();
+		const stderr = createCaptureStream();
+		const result = await runPackageCommand({
+			appName: "pi",
+			args: ["install", extensionDir],
+			cwd,
+			agentDir,
+			stdout: stdout.stream,
+			stderr: stderr.stream,
+		});
+
+		assert.equal(result.handled, true);
+		assert.equal(result.exitCode, 0);
+		assert.equal(readFileSync(join(extensionDir, "before-install-ran.txt"), "utf-8"), "ok");
+		assert.equal(readFileSync(join(extensionDir, "after-install-ran.txt"), "utf-8"), "ok");
+		assert.ok(stdout.getOutput().includes(`Installed ${extensionDir}`));
 	});
 
-	it("runs legacy named lifecycle hooks when no registered hooks exist", async () => {
-		const root = mkdtempSync(join(tmpdir(), "pi-lifecycle-legacy-"));
-		const cwd = join(root, "cwd");
-		const agentDir = join(root, "agent");
-		const extensionDir = join(root, "ext-legacy");
-		mkdirSync(cwd, { recursive: true });
-		mkdirSync(agentDir, { recursive: true });
-		mkdirSync(extensionDir, { recursive: true });
-
-		try {
-			writePackage(extensionDir, {
-				"package.json": JSON.stringify({
-					name: "ext-legacy",
-					type: "module",
-					pi: { extensions: ["./index.js"] },
-				}),
-				"index.js": `
-					import { writeFileSync } from "node:fs";
-					import { join } from "node:path";
-					export default function () {}
-					export async function beforeInstall(ctx) {
-						writeFileSync(join(ctx.installedPath, "legacy-before-install.txt"), "ok", "utf-8");
-					}
-					export async function afterInstall(ctx) {
-						writeFileSync(join(ctx.installedPath, "legacy-after-install.txt"), "ok", "utf-8");
-					}
-					export async function beforeRemove(ctx) {
-						writeFileSync(join(ctx.installedPath, "legacy-before-remove.txt"), "ok", "utf-8");
-					}
-					export async function afterRemove(ctx) {
-						writeFileSync(join(ctx.installedPath, "legacy-after-remove.txt"), "ok", "utf-8");
-					}
-				`,
-			});
-
-			const stdout = createCaptureStream();
-			const stderr = createCaptureStream();
-			const installResult = await runPackageCommand({
-				appName: "pi",
-				args: ["install", extensionDir],
-				cwd,
-				agentDir,
-				stdout: stdout.stream,
-				stderr: stderr.stream,
-			});
-
-			assert.equal(installResult.handled, true);
-			assert.equal(installResult.exitCode, 0);
-			assert.equal(readFileSync(join(extensionDir, "legacy-before-install.txt"), "utf-8"), "ok");
-			assert.equal(readFileSync(join(extensionDir, "legacy-after-install.txt"), "utf-8"), "ok");
-
-			const removeResult = await runPackageCommand({
-				appName: "pi",
-				args: ["remove", extensionDir],
-				cwd,
-				agentDir,
-				stdout: stdout.stream,
-				stderr: stderr.stream,
-			});
-
-			assert.equal(removeResult.handled, true);
-			assert.equal(removeResult.exitCode, 0);
-			assert.equal(readFileSync(join(extensionDir, "legacy-before-remove.txt"), "utf-8"), "ok");
-			assert.equal(readFileSync(join(extensionDir, "legacy-after-remove.txt"), "utf-8"), "ok");
-		} finally {
-			rmSync(root, { recursive: true, force: true });
-		}
+	it("runs legacy named lifecycle hooks when no registered hooks exist", async (t) => {
+		const { cwd, agentDir, extensionDir } = createTestDirs("legacy", t);
+
+		writePackage(extensionDir, {
+			"package.json": JSON.stringify({
+				name: "ext-legacy",
+				type: "module",
+				pi: { extensions: ["./index.js"] },
+			}),
+			"index.js": [
+				'import { writeFileSync } from "node:fs";',
+				'import { join } from "node:path";',
+				"export default function () {}",
+				"export async function beforeInstall(ctx) {",
+				'  writeFileSync(join(ctx.installedPath, "legacy-before-install.txt"), "ok", "utf-8");',
+				"}",
+				"export async function afterInstall(ctx) {",
+				'  writeFileSync(join(ctx.installedPath, "legacy-after-install.txt"), "ok", "utf-8");',
+				"}",
+				"export async function beforeRemove(ctx) {",
+				'  writeFileSync(join(ctx.installedPath, "legacy-before-remove.txt"), "ok", "utf-8");',
+				"}",
+				"export async function afterRemove(ctx) {",
+				'  writeFileSync(join(ctx.installedPath, "legacy-after-remove.txt"), "ok", "utf-8");',
+				"}",
+			].join("\n"),
+		});
+
+		const stdout = createCaptureStream();
+		const stderr = createCaptureStream();
+		const installResult = await runPackageCommand({
+			appName: "pi",
+			args: ["install", extensionDir],
+			cwd,
+			agentDir,
+			stdout: stdout.stream,
+			stderr: stderr.stream,
+		});
+
+		assert.equal(installResult.handled, true);
+		assert.equal(installResult.exitCode, 0);
+		assert.equal(readFileSync(join(extensionDir, "legacy-before-install.txt"), "utf-8"), "ok");
+		assert.equal(readFileSync(join(extensionDir, "legacy-after-install.txt"), "utf-8"), "ok");
+
+		const removeResult = await runPackageCommand({
+			appName: "pi",
+			args: ["remove", extensionDir],
+			cwd,
+			agentDir,
+			stdout: stdout.stream,
+			stderr: stderr.stream,
+		});
+
+		assert.equal(removeResult.handled, true);
+		assert.equal(removeResult.exitCode, 0);
+		assert.equal(readFileSync(join(extensionDir, "legacy-before-remove.txt"), "utf-8"), "ok");
+		assert.equal(readFileSync(join(extensionDir, "legacy-after-remove.txt"), "utf-8"), "ok");
 	});
 
-	it("skips lifecycle phases with no hooks declared", async () => {
-		const root = mkdtempSync(join(tmpdir(), "pi-lifecycle-skip-"));
-		const cwd = join(root, "cwd");
-		const agentDir = join(root, "agent");
-		const extensionDir = join(root, "ext-empty");
-		mkdirSync(cwd, { recursive: true });
-		mkdirSync(agentDir, { recursive: true });
-		mkdirSync(extensionDir, { recursive: true });
-
-		try {
-			writePackage(extensionDir, {
-				"package.json": JSON.stringify({
-					name: "ext-empty",
-					type: "module",
-					pi: { extensions: ["./index.js"] },
-				}),
-				"index.js": `export default function () {}`,
-			});
-
-			const stdout = createCaptureStream();
-			const stderr = createCaptureStream();
-			const installResult = await runPackageCommand({
-				appName: "pi",
-				args: ["install", extensionDir],
-				cwd,
-				agentDir,
-				stdout: stdout.stream,
-				stderr: stderr.stream,
-			});
-			assert.equal(installResult.handled, true);
-			assert.equal(installResult.exitCode, 0);
-
-			const removeResult = await runPackageCommand({
-				appName: "pi",
-				args: ["remove", extensionDir],
-				cwd,
-				agentDir,
-				stdout: stdout.stream,
-				stderr: stderr.stream,
-			});
-			assert.equal(removeResult.handled, true);
-			assert.equal(removeResult.exitCode, 0);
-			assert.equal(stderr.getOutput().includes("Hook failed"), false);
-		} finally {
-			rmSync(root, { recursive: true, force: true });
-		}
+	it("skips lifecycle phases with no hooks declared", async (t) => {
+		const { cwd, agentDir, extensionDir } = createTestDirs("skip", t);
+
+		writePackage(extensionDir, {
+			"package.json": JSON.stringify({
+				name: "ext-empty",
+				type: "module",
+				pi: { extensions: ["./index.js"] },
+			}),
+			"index.js": "export default function () {}",
+		});
+
+		const stdout = createCaptureStream();
+		const stderr = createCaptureStream();
+		const installResult = await runPackageCommand({
+			appName: "pi",
+			args: ["install", extensionDir],
+			cwd,
+			agentDir,
+			stdout: stdout.stream,
+			stderr: stderr.stream,
+		});
+		assert.equal(installResult.handled, true);
+		assert.equal(installResult.exitCode, 0);
+
+		const removeResult = await runPackageCommand({
+			appName: "pi",
+			args: ["remove", extensionDir],
+			cwd,
+			agentDir,
+			stdout: stdout.stream,
+			stderr: stderr.stream,
+		});
+		assert.equal(removeResult.handled, true);
+		assert.equal(removeResult.exitCode, 0);
+		assert.equal(stderr.getOutput().includes("Hook failed"), false);
+	});
+
+	it("fails install when manifest runtime dependency is missing", async (t) => {
+		const { cwd, agentDir, extensionDir } = createTestDirs("deps", t);
+
+		writePackage(extensionDir, {
+			"package.json": JSON.stringify({
+				name: "ext-runtime-deps",
+				type: "module",
+				pi: { extensions: ["./index.js"] },
+			}),
+			"index.js": "export default function () {}",
+			"extension-manifest.json": JSON.stringify({
+				id: "ext-runtime-deps",
+				name: "Runtime Dep Test",
+				version: "1.0.0",
+				dependencies: { runtime: ["__definitely_missing_command_for_test__"] },
+			}),
+		});
+
+		const stdout = createCaptureStream();
+		const stderr = createCaptureStream();
+		const result = await runPackageCommand({
+			appName: "pi",
+			args: ["install", extensionDir],
+			cwd,
+			agentDir,
+			stdout: stdout.stream,
+			stderr: stderr.stream,
+		});
+
+		assert.equal(result.handled, true);
+		assert.equal(result.exitCode, 1);
+		assert.ok(stderr.getOutput().includes("Missing runtime dependencies"));
 	});
 
-	it("fails install when manifest runtime dependency is missing", async () => {
-		const root = mkdtempSync(join(tmpdir(), "pi-lifecycle-deps-"));
-		const cwd = join(root, "cwd");
-		const agentDir = join(root, "agent");
-		const extensionDir = join(root, "ext-runtime-deps");
-		mkdirSync(cwd, { recursive: true });
-		mkdirSync(agentDir, { recursive: true });
-		mkdirSync(extensionDir, { recursive: true });
-
-		try {
-			writePackage(extensionDir, {
-				"package.json": JSON.stringify({
-					name: "ext-runtime-deps",
-					type: "module",
-					pi: { extensions: ["./index.js"] },
-				}),
-				"index.js": `export default function () {}`,
-				"extension-manifest.json": JSON.stringify({
-					id: "ext-runtime-deps",
-					name: "Runtime Dep Test",
-					version: "1.0.0",
-					dependencies: { runtime: ["__definitely_missing_command_for_test__"] },
-				}),
-			});
-
-			const stdout = createCaptureStream();
-			const stderr = createCaptureStream();
-			const result = await runPackageCommand({
-				appName: "pi",
-				args: ["install", extensionDir],
-				cwd,
-				agentDir,
-				stdout: stdout.stream,
-				stderr: stderr.stream,
-			});
-
-			assert.equal(result.handled, true);
-			assert.equal(result.exitCode, 1);
-			assert.ok(stderr.getOutput().includes("Missing runtime dependencies"));
-		} finally {
-			rmSync(root, { recursive: true, force: true });
-		}
+	it("afterRemove hook receives installedPath even when directory is deleted", async (t) => {
+		const { cwd, agentDir, extensionDir } = createTestDirs("after-remove", t);
+
+		writePackage(extensionDir, {
+			"package.json": JSON.stringify({
+				name: "ext-after-remove",
+				type: "module",
+				pi: { extensions: ["./index.js"] },
+			}),
+			"index.js": [
+				'import { writeFileSync, existsSync } from "node:fs";',
+				'import { join } from "node:path";',
+				"export default function () {}",
+				"export async function afterRemove(ctx) {",
+				'  const marker = join(ctx.cwd, "after-remove-marker.json");',
+				"  writeFileSync(marker, JSON.stringify({",
+				"    receivedPath: ctx.installedPath,",
+				"    pathExisted: existsSync(ctx.installedPath),",
+				'  }), "utf-8");',
+				"}",
+			].join("\n"),
+		});
+
+		const stdout = createCaptureStream();
+		const stderr = createCaptureStream();
+
+		await runPackageCommand({
+			appName: "pi",
+			args: ["install", extensionDir],
+			cwd,
+			agentDir,
+			stdout: stdout.stream,
+			stderr: stderr.stream,
+		});
+
+		await runPackageCommand({
+			appName: "pi",
+			args: ["remove", extensionDir],
+			cwd,
+			agentDir,
+			stdout: stdout.stream,
+			stderr: stderr.stream,
+		});
+
+		const markerPath = join(cwd, "after-remove-marker.json");
+		assert.ok(existsSync(markerPath), "afterRemove hook must have executed and written marker");
+		const marker = JSON.parse(readFileSync(markerPath, "utf-8"));
+		assert.equal(typeof marker.receivedPath, "string", "hook must receive installedPath as string");
 	});
 });

package/src/resources/extensions/gsd/auto/phases.ts

@@ -30,6 +30,7 @@ import { PROJECT_FILES } from "../detection.js";
 import { MergeConflictError } from "../git-service.js";
 import { join } from "node:path";
 import { existsSync, cpSync } from "node:fs";
+import { logWarning, logError } from "../workflow-logger.js";
 
 // ─── generateMilestoneReport ──────────────────────────────────────────────────
 
@@ -164,8 +165,8 @@ export async function runPreDispatch(
       debugLog("autoLoop", { phase: "exit", reason: "health-gate-failed" });
       return { action: "break", reason: "health-gate-failed" };
     }
-  } catch {
-    // Non-fatal
+  } catch (e) {
+    logWarning("engine", "Pre-dispatch health gate threw unexpectedly", { error: String(e) });
   }
 
   // Sync project root artifacts into worktree
@@ -247,7 +248,8 @@ export async function runPreDispatch(
         await deps.stopAuto(ctx, pi, `Merge conflict on milestone ${s.currentMilestoneId}`);
         return { action: "break", reason: "merge-conflict" };
       }
-      // Non-conflict errors — log and continue
+      // Non-conflict merge errors — log and continue
+      logWarning("engine", "Milestone merge failed with non-conflict error", { milestone: s.currentMilestoneId!, error: String(mergeErr) });
     }
 
     // PR creation (auto_pr) is handled inside mergeMilestoneToMain (#2302)
@@ -290,7 +292,9 @@ export async function runPreDispatch(
         cpSync(completedKeysPath, archivePath);
       }
       atomicWriteSync(completedKeysPath, JSON.stringify([], null, 2));
-    } catch { /* non-fatal */ }
+    } catch (e) {
+      logWarning("engine", "Failed to archive completed-units on milestone transition", { error: String(e) });
+    }
 
     // Rebuild STATE.md immediately so it reflects the new active milestone.
     // This bypasses the 30-second throttle in the normal rebuild path —
@@ -298,8 +302,8 @@ export async function runPreDispatch(
     // immediate write.
     try {
       await deps.rebuildState(s.basePath);
-    } catch {
-      // Non-fatal — STATE.md will be rebuilt on the next regular cycle
+    } catch (e) {
+      logWarning("engine", "STATE.md rebuild failed after milestone transition", { error: String(e) });
     }
   }
 
@@ -919,8 +923,8 @@ export async function runUnitPhase(
         (decisionsContent?.length ?? 0) +
         (requirementsContent?.length ?? 0) +
         (projectContent?.length ?? 0);
-    } catch {
-      // Non-fatal
+    } catch (e) {
+      logWarning("engine", "Baseline char count measurement failed", { error: String(e) });
     }
   }
 
@@ -930,9 +934,7 @@ export async function runUnitPhase(
   } catch (reorderErr) {
     const msg =
       reorderErr instanceof Error ? reorderErr.message : String(reorderErr);
-    process.stderr.write(
-      `[gsd] prompt reorder failed (non-fatal): ${msg}\n`,
-    );
+    logWarning("engine", "Prompt reorder failed", { error: msg });
   }
 
   // Select and apply model (with tier escalation on retry — normal units only)
@@ -1135,7 +1137,9 @@ export async function runUnitPhase(
       const completedKeysPath = join(gsdRoot(s.basePath), "completed-units.json");
       const keys = s.completedUnits.map((u) => `${u.type}/${u.id}`);
       atomicWriteSync(completedKeysPath, JSON.stringify(keys, null, 2));
-    } catch { /* non-fatal: disk flush failure */ }
+    } catch (e) {
+      logWarning("engine", "Failed to flush completed-units to disk", { error: String(e) });
+    }
 
     deps.clearUnitRuntimeRecord(s.basePath, unitType, unitId);
     s.unitDispatchCount.delete(`${unitType}/${unitId}`);

package/src/resources/extensions/gsd/auto/run-unit.ts

@@ -11,6 +11,7 @@ import { NEW_SESSION_TIMEOUT_MS } from "./session.js";
 import type { UnitResult } from "./types.js";
 import { _setCurrentResolve, _setSessionSwitchInFlight } from "./resolve.js";
 import { debugLog } from "../debug-logger.js";
+import { logWarning, logError } from "../workflow-logger.js";
 
 /**
  * Execute a single unit: create a new session, send the prompt, and await
@@ -85,7 +86,9 @@ export async function runUnit(
     if (process.cwd() !== s.basePath) {
       process.chdir(s.basePath);
     }
-  } catch { /* non-fatal — chdir may fail if dir was removed */ }
+  } catch (e) {
+    logWarning("engine", "Failed to chdir to basePath before dispatch", { basePath: s.basePath, error: String(e) });
+  }
 
   // ── Send the prompt ──
   debugLog("runUnit", { phase: "send-message", unitType, unitId });
@@ -115,8 +118,8 @@ export async function runUnit(
     if (typeof cmdCtxAny?.clearQueue === "function") {
       (cmdCtxAny.clearQueue as () => unknown)();
     }
-  } catch {
-    // Non-fatal — clearQueue may not be available in all contexts
+  } catch (e) {
+    logWarning("engine", "clearQueue failed after unit completion", { error: String(e) });
   }
 
   return result;

package/src/resources/extensions/gsd/auto-worktree.ts

@@ -42,6 +42,7 @@ import {
 } from "./worktree.js";
 import { MergeConflictError, readIntegrationBranch, RUNTIME_EXCLUSION_PATHS } from "./git-service.js";
 import { debugLog } from "./debug-logger.js";
+import { logWarning } from "./workflow-logger.js";
 import { loadEffectiveGSDPreferences } from "./preferences.js";
 import {
   nativeGetCurrentBranch,
@@ -700,7 +701,7 @@ export function createAutoWorktree(
   const hookError = runWorktreePostCreateHook(basePath, info.path);
   if (hookError) {
     // Non-fatal — log but don't prevent worktree usage
-    console.error(`[GSD] ${hookError}`);
+    logWarning("reconcile", hookError, { worktree: info.name });
   }
 
   const previousCwd = process.cwd();
@@ -793,10 +794,12 @@ export function teardownAutoWorktree(
   // backslashes (#1436), leaving ~1 GB+ orphaned directories.
   const wtDir = worktreePath(originalBasePath, milestoneId);
   if (existsSync(wtDir)) {
-    console.error(
-      `[GSD] WARNING: Worktree directory still exists after teardown: ${wtDir}\n` +
-        `  This is likely an orphaned directory consuming disk space.\n` +
-        `  Remove it manually with: rm -rf "${wtDir.replaceAll("\\", "/")}"`,
+    logWarning(
+      "reconcile",
+      `Worktree directory still exists after teardown: ${wtDir}. ` +
+        `This is likely an orphaned directory consuming disk space. ` +
+        `Remove it manually with: rm -rf "${wtDir.replaceAll("\\", "/")}"`,
+      { worktree: milestoneId },
     );
     // Attempt a direct filesystem removal as a fallback
     try {

package/src/resources/extensions/gsd/auto.ts

@@ -250,9 +250,9 @@ const STATE_REBUILD_MIN_INTERVAL_MS = 30_000;
 
 export function shouldUseWorktreeIsolation(): boolean {
   const prefs = loadEffectiveGSDPreferences()?.preferences?.git;
-  if (prefs?.isolation === "none") return false;
-  if (prefs?.isolation === "branch") return false;
-  return true; // default: worktree
+  if (prefs?.isolation === "worktree") return true;
+  // Default is false — worktree isolation requires explicit opt-in
+  return false;
 }
 
 /** Crash recovery prompt — set by startAuto, consumed by the main loop */