gsd-pi 2.44.0-dev.73f2fd5 → 2.44.0-dev.8894d5b

package/src/resources/extensions/gsd/tests/completed-units-metrics-sync.test.ts

@@ -1,114 +0,0 @@
-/**
- * completed-units-metrics-sync.test.ts — Regression tests for #2313.
- *
- * 1. completed-units.json should be archived (not wiped) on milestone transition
- * 2. metrics.json should be in the worktree → project root sync file list
- */
-
-import test from "node:test";
-import assert from "node:assert/strict";
-import { readFileSync, mkdtempSync, mkdirSync, writeFileSync, existsSync, cpSync } from "node:fs";
-import { join } from "node:path";
-import { tmpdir } from "node:os";
-
-// ─── Bug 1: completed-units.json should be archived, not wiped ─────────────
-
-const phasesSrcPath = join(import.meta.dirname, "..", "auto", "phases.ts");
-const phasesSrc = readFileSync(phasesSrcPath, "utf-8");
-
-test("#2313: completed-units.json should not be blindly wiped to [] on milestone transition", () => {
-  // The milestone transition block should NOT write an empty array to completed-units.json
-  // without first archiving the existing data. Look for the archive/rename pattern.
-  const transitionIdx = phasesSrc.indexOf("Milestone transition");
-  assert.ok(transitionIdx !== -1, "Milestone transition section exists");
-
-  // Find the completed-units handling block
-  const completedUnitsIdx = phasesSrc.indexOf("completed-units", transitionIdx);
-  assert.ok(completedUnitsIdx !== -1, "completed-units handling exists in transition");
-
-  // Get a window around the completed-units handling (1200 chars to
-  // accommodate CRLF line endings on Windows which inflate byte offsets).
-  const windowStart = Math.max(0, completedUnitsIdx - 300);
-  const windowEnd = Math.min(phasesSrc.length, completedUnitsIdx + 900);
-  const window = phasesSrc.slice(windowStart, windowEnd).toLowerCase();
-
-  // Should archive/rename the old file before resetting
-  const hasArchive = window.includes("archive") ||
-    window.includes("rename") ||
-    window.includes("cpsync") ||
-    window.includes("safecopy") ||
-    window.includes("completed-units-");
-
-  assert.ok(
-    hasArchive,
-    "completed-units.json should be archived before reset during milestone transition",
-  );
-});
-
-// ─── Bug 2: metrics.json should be in the sync file lists ──────────────────
-
-test("#2313: syncStateToProjectRoot should sync metrics.json", () => {
-  const syncSrcPath = join(import.meta.dirname, "..", "auto-worktree-sync.ts");
-  const syncSrc = readFileSync(syncSrcPath, "utf-8");
-
-  // syncStateToProjectRoot should copy metrics.json from worktree to project root
-  assert.ok(
-    syncSrc.includes("metrics.json"),
-    "auto-worktree-sync.ts should reference metrics.json for sync",
-  );
-});
-
-test("#2313: syncWorktreeStateBack should include metrics.json in root files list", () => {
-  const autoWorktreeSrcPath = join(import.meta.dirname, "..", "auto-worktree.ts");
-  const autoWorktreeSrc = readFileSync(autoWorktreeSrcPath, "utf-8");
-
-  // Find the rootFiles array in syncWorktreeStateBack
-  const syncBackIdx = autoWorktreeSrc.indexOf("syncWorktreeStateBack");
-  assert.ok(syncBackIdx !== -1, "syncWorktreeStateBack exists");
-
-  const rootFilesIdx = autoWorktreeSrc.indexOf("rootFiles", syncBackIdx);
-  assert.ok(rootFilesIdx !== -1, "rootFiles list exists in syncWorktreeStateBack");
-
-  // Get the rootFiles array content
-  const arrayStart = autoWorktreeSrc.indexOf("[", rootFilesIdx);
-  const arrayEnd = autoWorktreeSrc.indexOf("]", arrayStart);
-  const rootFilesBlock = autoWorktreeSrc.slice(arrayStart, arrayEnd);
-
-  assert.ok(
-    rootFilesBlock.includes("metrics.json"),
-    "metrics.json should be in syncWorktreeStateBack rootFiles list",
-  );
-});
-
-// ─── Functional test: completed-units archive ────────────────────────────────
-
-test("#2313: functional — completed-units archive creates milestone-specific file", () => {
-  const tmpBase = mkdtempSync(join(tmpdir(), "gsd-completed-units-"));
-  const gsdDir = join(tmpBase, ".gsd");
-  mkdirSync(gsdDir, { recursive: true });
-
-  // Simulate existing completed-units.json with data
-  const existing = [
-    { type: "task", id: "T01" },
-    { type: "slice", id: "S01" },
-  ];
-  const completedKeysPath = join(gsdDir, "completed-units.json");
-  writeFileSync(completedKeysPath, JSON.stringify(existing, null, 2));
-
-  // Simulate the archive behavior: copy to milestone-specific file
-  const milestoneId = "M001";
-  const archivePath = join(gsdDir, `completed-units-${milestoneId}.json`);
-  cpSync(completedKeysPath, archivePath);
-
-  // Reset the main file
-  writeFileSync(completedKeysPath, JSON.stringify([], null, 2));
-
-  // Verify archive exists with original data
-  assert.ok(existsSync(archivePath), "archive file should exist");
-  const archived = JSON.parse(readFileSync(archivePath, "utf-8"));
-  assert.deepEqual(archived, existing, "archived data should match original");
-
-  // Verify main file is reset
-  const current = JSON.parse(readFileSync(completedKeysPath, "utf-8"));
-  assert.deepEqual(current, [], "current completed-units should be empty after transition");
-});

package/src/resources/extensions/gsd/tests/est-annotation-timeout.test.ts

@@ -1,120 +0,0 @@
-/**
- * est-annotation-timeout.test.ts — Regression tests for #2243.
- *
- * Tasks with `est: 30m` or `est: 2h` annotations should get extended
- * supervision timeouts. The parseEstimateMinutes helper should parse
- * estimate strings, and startUnitSupervision should use them.
- */
-
-import test from "node:test";
-import assert from "node:assert/strict";
-import { readFileSync } from "node:fs";
-import { join } from "node:path";
-
-const timersSrcPath = join(import.meta.dirname, "..", "auto-timers.ts");
-const timersSrc = readFileSync(timersSrcPath, "utf-8");
-
-// ─── Source analysis: parseEstimateMinutes exists and is exported ────────────
-
-test("#2243: auto-timers.ts should export parseEstimateMinutes", () => {
-  assert.ok(
-    timersSrc.includes("export function parseEstimateMinutes"),
-    "parseEstimateMinutes should be exported from auto-timers.ts",
-  );
-});
-
-// ─── Inline unit test of parseEstimateMinutes logic ─────────────────────────
-// Since importing the module pulls in heavy deps, test the parsing logic inline.
-
-function parseEstimateMinutes(estimate: string): number | null {
-  if (!estimate || typeof estimate !== "string") return null;
-  const trimmed = estimate.trim();
-  if (!trimmed) return null;
-
-  let totalMinutes = 0;
-  let matched = false;
-
-  const hoursMatch = trimmed.match(/(\d+)\s*h/i);
-  if (hoursMatch) {
-    totalMinutes += Number(hoursMatch[1]) * 60;
-    matched = true;
-  }
-
-  const minutesMatch = trimmed.match(/(\d+)\s*m/i);
-  if (minutesMatch) {
-    totalMinutes += Number(minutesMatch[1]);
-    matched = true;
-  }
-
-  return matched ? totalMinutes : null;
-}
-
-test("#2243: parseEstimateMinutes parses '30m' correctly", () => {
-  assert.equal(parseEstimateMinutes("30m"), 30);
-});
-
-test("#2243: parseEstimateMinutes parses '2h' correctly", () => {
-  assert.equal(parseEstimateMinutes("2h"), 120);
-});
-
-test("#2243: parseEstimateMinutes parses '1h30m' correctly", () => {
-  assert.equal(parseEstimateMinutes("1h30m"), 90);
-});
-
-test("#2243: parseEstimateMinutes parses '15m' correctly", () => {
-  assert.equal(parseEstimateMinutes("15m"), 15);
-});
-
-test("#2243: parseEstimateMinutes returns null for empty string", () => {
-  assert.equal(parseEstimateMinutes(""), null);
-});
-
-test("#2243: parseEstimateMinutes returns null for invalid string", () => {
-  assert.equal(parseEstimateMinutes("not a time"), null);
-});
-
-// ─── Source analysis: startUnitSupervision uses task estimates ───────────────
-
-test("#2243: startUnitSupervision should reference task estimates for timeout scaling", () => {
-  const usesEstimate =
-    timersSrc.includes("parseEstimateMinutes") &&
-    timersSrc.includes("estimateMinutes") &&
-    timersSrc.includes("taskEstimate");
-
-  assert.ok(
-    usesEstimate,
-    "startUnitSupervision should use task estimate annotations for timeout scaling",
-  );
-});
-
-test("#2243: SupervisionContext should accept an optional taskEstimate field", () => {
-  const ctxIdx = timersSrc.indexOf("SupervisionContext");
-  assert.ok(ctxIdx !== -1, "SupervisionContext interface exists");
-
-  const ctxEnd = timersSrc.indexOf("}", ctxIdx);
-  const ctxBlock = timersSrc.slice(ctxIdx, ctxEnd);
-
-  assert.ok(
-    ctxBlock.includes("taskEstimate"),
-    "SupervisionContext should include a taskEstimate field",
-  );
-});
-
-test("#2243: timeouts should be scaled by estimate (timeoutScale in source)", () => {
-  assert.ok(
-    timersSrc.includes("timeoutScale"),
-    "auto-timers.ts should use a timeoutScale factor derived from est: annotations",
-  );
-});
-
-test("#2243: idle timeout should NOT be scaled (idle is idle regardless of estimate)", () => {
-  // Find the idleTimeoutMs line
-  const idleIdx = timersSrc.indexOf("const idleTimeoutMs");
-  assert.ok(idleIdx !== -1, "idleTimeoutMs variable exists");
-  
-  const idleLine = timersSrc.slice(idleIdx, timersSrc.indexOf("\n", idleIdx));
-  assert.ok(
-    !idleLine.includes("timeoutScale"),
-    "idleTimeoutMs should NOT be scaled — idle is idle",
-  );
-});

package/src/resources/extensions/gsd/tests/mcp-status.test.ts

@@ -1,103 +0,0 @@
-import test, { describe } from "node:test";
-import assert from "node:assert/strict";
-
-import {
-  formatMcpStatusReport,
-  formatMcpServerDetail,
-  type McpServerStatus,
-} from "../commands-mcp-status.ts";
-
-// ─── formatMcpStatusReport ──────────────────────────────────────────────────
-
-describe("formatMcpStatusReport", () => {
-  test("returns no-servers message when list is empty", () => {
-    const result = formatMcpStatusReport([]);
-    assert.match(result, /no mcp servers configured/i);
-  });
-
-  test("lists all servers with connection status", () => {
-    const servers: McpServerStatus[] = [
-      { name: "railway", transport: "stdio", connected: true, toolCount: 5, error: undefined },
-      { name: "linear", transport: "http", connected: false, toolCount: 0, error: undefined },
-    ];
-    const result = formatMcpStatusReport(servers);
-    assert.match(result, /railway/);
-    assert.match(result, /linear/);
-    assert.match(result, /connected/i);
-    assert.match(result, /disconnected/i);
-    assert.match(result, /5 tools/);
-  });
-
-  test("shows error state for servers with errors", () => {
-    const servers: McpServerStatus[] = [
-      { name: "broken", transport: "stdio", connected: false, toolCount: 0, error: "Connection refused" },
-    ];
-    const result = formatMcpStatusReport(servers);
-    assert.match(result, /error/i);
-    assert.match(result, /Connection refused/);
-  });
-
-  test("includes server count in header", () => {
-    const servers: McpServerStatus[] = [
-      { name: "a", transport: "stdio", connected: true, toolCount: 3, error: undefined },
-      { name: "b", transport: "http", connected: true, toolCount: 2, error: undefined },
-    ];
-    const result = formatMcpStatusReport(servers);
-    assert.match(result, /2/);
-  });
-});
-
-// ─── formatMcpServerDetail ──────────────────────────────────────────────────
-
-describe("formatMcpServerDetail", () => {
-  test("shows server name and transport", () => {
-    const result = formatMcpServerDetail({
-      name: "railway",
-      transport: "stdio",
-      connected: true,
-      toolCount: 3,
-      tools: ["railway_list_projects", "railway_deploy", "railway_logs"],
-      error: undefined,
-    });
-    assert.match(result, /railway/);
-    assert.match(result, /stdio/);
-  });
-
-  test("lists individual tools when available", () => {
-    const result = formatMcpServerDetail({
-      name: "railway",
-      transport: "stdio",
-      connected: true,
-      toolCount: 2,
-      tools: ["railway_list_projects", "railway_deploy"],
-      error: undefined,
-    });
-    assert.match(result, /railway_list_projects/);
-    assert.match(result, /railway_deploy/);
-  });
-
-  test("shows error message for failed servers", () => {
-    const result = formatMcpServerDetail({
-      name: "broken",
-      transport: "stdio",
-      connected: false,
-      toolCount: 0,
-      tools: [],
-      error: "spawn ENOENT",
-    });
-    assert.match(result, /error/i);
-    assert.match(result, /spawn ENOENT/);
-  });
-
-  test("shows disconnected status with no tools", () => {
-    const result = formatMcpServerDetail({
-      name: "offline",
-      transport: "http",
-      connected: false,
-      toolCount: 0,
-      tools: [],
-      error: undefined,
-    });
-    assert.match(result, /disconnected/i);
-  });
-});

package/src/resources/extensions/gsd/tests/merge-conflict-stops-loop.test.ts

@@ -1,66 +0,0 @@
-/**
- * merge-conflict-stops-loop.test.ts — #2330
- *
- * When a squash merge has real code conflicts (not just .gsd/ files),
- * the merge retries forever because MergeConflictError is caught
- * silently in mergeAndExit. This test verifies that:
- * 1. worktree-resolver re-throws MergeConflictError for code conflicts
- * 2. auto/phases.ts wraps mergeAndExit calls to stop the loop on conflict
- */
-
-import { readFileSync } from "node:fs";
-import { join } from "node:path";
-import { createTestContext } from "./test-helpers.ts";
-
-const { assertTrue, report } = createTestContext();
-
-const resolverPath = join(import.meta.dirname, "..", "worktree-resolver.ts");
-const resolverSrc = readFileSync(resolverPath, "utf-8");
-
-const phasesPath = join(import.meta.dirname, "..", "auto", "phases.ts");
-const phasesSrc = readFileSync(phasesPath, "utf-8");
-
-console.log("\n=== #2330: Merge conflict stops auto loop ===");
-
-// ── Test 1: worktree-resolver re-throws MergeConflictError ──────────────
-
-const methodStart = resolverSrc.indexOf("Worktree-mode merge:");
-assertTrue(methodStart > 0, "worktree-resolver has _mergeWorktreeMode method");
-
-const methodBody = resolverSrc.slice(methodStart, methodStart + 5000);
-const rethrowsConflict =
-  methodBody.includes("MergeConflictError") &&
-  methodBody.includes("throw err");
-
-assertTrue(
-  rethrowsConflict,
-  "worktree-resolver._mergeWorktreeMode re-throws MergeConflictError (#2330)",
-);
-
-// ── Test 2: auto/phases.ts imports and uses MergeConflictError ──────────
-
-assertTrue(
-  phasesSrc.includes("MergeConflictError") && phasesSrc.includes("mergeAndExit"),
-  "auto/phases.ts handles MergeConflictError from mergeAndExit (#2330)",
-);
-
-// ── Test 3: The handler stops the loop (doesn't just warn) ──────────────
-
-// Find the instanceof MergeConflictError check (not the import line)
-const instanceofIdx = phasesSrc.indexOf("instanceof MergeConflictError");
-assertTrue(instanceofIdx > 0, "auto/phases.ts has instanceof MergeConflictError check");
-
-if (instanceofIdx > 0) {
-  const afterHandler = phasesSrc.slice(instanceofIdx, instanceofIdx + 500);
-  const stopsLoop =
-    afterHandler.includes("stopAuto") ||
-    afterHandler.includes('action: "break"') ||
-    afterHandler.includes("reason: \"merge-conflict\"");
-
-  assertTrue(
-    stopsLoop,
-    "auto/phases.ts stops the loop when merge conflict is detected (#2330)",
-  );
-}
-
-report();

package/src/resources/extensions/gsd/tests/stop-auto-merge-back.test.ts

@@ -1,67 +0,0 @@
-/**
- * stop-auto-merge-back.test.ts — Regression test for #2317.
- *
- * When auto-mode stops after a milestone is complete, stopAuto should trigger
- * merge-back (mergeAndExit) instead of just exiting the worktree with
- * preserveBranch: true. Otherwise milestone code stays stranded on the
- * worktree branch and never reaches main.
- */
-
-import test from "node:test";
-import assert from "node:assert/strict";
-import { readFileSync } from "node:fs";
-import { join } from "node:path";
-
-// ─── Source analysis: stopAuto calls mergeAndExit for complete milestones ────
-
-const autoSrcPath = join(import.meta.dirname, "..", "auto.ts");
-const autoSrc = readFileSync(autoSrcPath, "utf-8");
-
-test("#2317: stopAuto should check milestone completion status before choosing exit strategy", () => {
-  // stopAuto Step 4 should NOT unconditionally call exitMilestone(preserveBranch: true).
-  // It should check if the milestone is complete and call mergeAndExit instead.
-
-  // Find the Step 4 section
-  const step4Idx = autoSrc.indexOf("Step 4: Auto-worktree exit");
-  assert.ok(step4Idx !== -1, "Step 4 comment exists in stopAuto");
-
-  // Extract a reasonable window around Step 4 (up to Step 5)
-  const step5Idx = autoSrc.indexOf("Step 5:", step4Idx);
-  const step4Block = autoSrc.slice(step4Idx, step5Idx);
-
-  // The fix: Step 4 should call mergeAndExit when milestone is complete
-  assert.ok(
-    step4Block.includes("mergeAndExit"),
-    "Step 4 should call mergeAndExit for completed milestones",
-  );
-});
-
-test("#2317: stopAuto should detect milestone completion via SUMMARY file or DB", () => {
-  const step4Idx = autoSrc.indexOf("Step 4: Auto-worktree exit");
-  const step5Idx = autoSrc.indexOf("Step 5:", step4Idx);
-  const step4Block = autoSrc.slice(step4Idx, step5Idx);
-
-  // Should check completion status — either via SUMMARY file, DB getMilestone, or phase
-  const checksCompletion =
-    step4Block.includes("SUMMARY") ||
-    step4Block.includes("getMilestone") ||
-    step4Block.includes("complete") ||
-    step4Block.includes("isMilestoneComplete");
-
-  assert.ok(
-    checksCompletion,
-    "Step 4 should check if milestone is complete before deciding exit strategy",
-  );
-});
-
-test("#2317: stopAuto still preserves branch for incomplete milestones", () => {
-  const step4Idx = autoSrc.indexOf("Step 4: Auto-worktree exit");
-  const step5Idx = autoSrc.indexOf("Step 5:", step4Idx);
-  const step4Block = autoSrc.slice(step4Idx, step5Idx);
-
-  // preserveBranch should still be used as fallback for non-complete milestones
-  assert.ok(
-    step4Block.includes("preserveBranch"),
-    "Step 4 should still preserve branch for incomplete milestones (fallback path)",
-  );
-});

package/src/resources/extensions/gsd/tests/terminated-transient.test.ts

@@ -1,49 +0,0 @@
-/**
- * terminated-transient.test.ts — Regression test for #2309.
- *
- * classifyProviderError should treat 'terminated' errors (process killed,
- * connection reset) as transient with auto-resume, not permanent.
- */
-
-import test from "node:test";
-import assert from "node:assert/strict";
-import { classifyProviderError } from "../provider-error-pause.ts";
-
-test("#2309: 'terminated' errors should be classified as transient", () => {
-  const result = classifyProviderError("terminated");
-  assert.equal(result.isTransient, true, "'terminated' should be transient");
-  assert.equal(result.isRateLimit, false, "'terminated' is not a rate limit");
-  assert.ok(result.suggestedDelayMs > 0, "'terminated' should have a retry delay");
-});
-
-test("#2309: 'connection reset' errors should be classified as transient", () => {
-  const result = classifyProviderError("connection reset by peer");
-  assert.equal(result.isTransient, true, "'connection reset' should be transient");
-});
-
-test("#2309: 'other side closed' errors should be classified as transient", () => {
-  const result = classifyProviderError("other side closed the connection");
-  assert.equal(result.isTransient, true, "'other side closed' should be transient");
-});
-
-test("#2309: 'fetch failed' errors should be classified as transient", () => {
-  const result = classifyProviderError("fetch failed: network error");
-  assert.equal(result.isTransient, true, "'fetch failed' should be transient");
-});
-
-test("#2309: 'connection refused' errors should be classified as transient", () => {
-  const result = classifyProviderError("ECONNREFUSED: connection refused");
-  assert.equal(result.isTransient, true, "'connection refused' should be transient");
-});
-
-test("#2309: permanent errors are still permanent", () => {
-  const authResult = classifyProviderError("unauthorized: invalid API key");
-  assert.equal(authResult.isTransient, false, "auth errors should stay permanent");
-  assert.equal(authResult.suggestedDelayMs, 0, "permanent errors have no delay");
-});
-
-test("#2309: rate limits are still transient", () => {
-  const rlResult = classifyProviderError("rate limit exceeded (429)");
-  assert.equal(rlResult.isTransient, true, "rate limits are still transient");
-  assert.equal(rlResult.isRateLimit, true, "rate limits are flagged as rate limits");
-});

package/src/resources/extensions/gsd/tools/validate-milestone.ts

@@ -1,127 +0,0 @@
-/**
- * validate-milestone handler — the core operation behind gsd_validate_milestone.
- *
- * Persists milestone validation results to the assessments table,
- * renders VALIDATION.md to disk, and invalidates caches.
- */
-
-import { join } from "node:path";
-
-import {
-  transaction,
-  _getAdapter,
-} from "../gsd-db.js";
-import { resolveMilestonePath, clearPathCache } from "../paths.js";
-import { saveFile, clearParseCache } from "../files.js";
-import { invalidateStateCache } from "../state.js";
-
-export interface ValidateMilestoneParams {
-  milestoneId: string;
-  verdict: "pass" | "needs-attention" | "needs-remediation";
-  remediationRound: number;
-  successCriteriaChecklist: string;
-  sliceDeliveryAudit: string;
-  crossSliceIntegration: string;
-  requirementCoverage: string;
-  verdictRationale: string;
-  remediationPlan?: string;
-}
-
-export interface ValidateMilestoneResult {
-  milestoneId: string;
-  verdict: string;
-  validationPath: string;
-}
-
-function renderValidationMarkdown(params: ValidateMilestoneParams): string {
-  let md = `---
-verdict: ${params.verdict}
-remediation_round: ${params.remediationRound}
----
-
-# Milestone Validation: ${params.milestoneId}
-
-## Success Criteria Checklist
-${params.successCriteriaChecklist}
-
-## Slice Delivery Audit
-${params.sliceDeliveryAudit}
-
-## Cross-Slice Integration
-${params.crossSliceIntegration}
-
-## Requirement Coverage
-${params.requirementCoverage}
-
-## Verdict Rationale
-${params.verdictRationale}
-`;
-
-  if (params.verdict === "needs-remediation" && params.remediationPlan) {
-    md += `\n## Remediation Plan\n${params.remediationPlan}\n`;
-  }
-
-  return md;
-}
-
-export async function handleValidateMilestone(
-  params: ValidateMilestoneParams,
-  basePath: string,
-): Promise<ValidateMilestoneResult | { error: string }> {
-  if (!params.milestoneId || typeof params.milestoneId !== "string" || params.milestoneId.trim() === "") {
-    return { error: "milestoneId is required and must be a non-empty string" };
-  }
-  const validVerdicts = ["pass", "needs-attention", "needs-remediation"];
-  if (!validVerdicts.includes(params.verdict)) {
-    return { error: `verdict must be one of: ${validVerdicts.join(", ")}` };
-  }
-
-  // ── Filesystem render ──────────────────────────────────────────────────
-  const validationMd = renderValidationMarkdown(params);
-
-  let validationPath: string;
-  const milestoneDir = resolveMilestonePath(basePath, params.milestoneId);
-  if (milestoneDir) {
-    validationPath = join(milestoneDir, `${params.milestoneId}-VALIDATION.md`);
-  } else {
-    const gsdDir = join(basePath, ".gsd");
-    const manualDir = join(gsdDir, "milestones", params.milestoneId);
-    validationPath = join(manualDir, `${params.milestoneId}-VALIDATION.md`);
-  }
-
-  try {
-    await saveFile(validationPath, validationMd);
-  } catch (renderErr) {
-    process.stderr.write(
-      `gsd-db: validate_milestone — disk render failed: ${(renderErr as Error).message}\n`,
-    );
-    return { error: `disk render failed: ${(renderErr as Error).message}` };
-  }
-
-  // ── DB write — store in assessments table ──────────────────────────────
-  const validatedAt = new Date().toISOString();
-
-  transaction(() => {
-    const adapter = _getAdapter()!;
-    adapter.prepare(
-      `INSERT OR REPLACE INTO assessments (path, milestone_id, slice_id, task_id, status, scope, full_content, created_at)
-       VALUES (:path, :mid, NULL, NULL, :verdict, 'milestone-validation', :content, :created_at)`,
-    ).run({
-      ":path": validationPath,
-      ":mid": params.milestoneId,
-      ":verdict": params.verdict,
-      ":content": validationMd,
-      ":created_at": validatedAt,
-    });
-  });
-
-  invalidateStateCache();
-  clearPathCache();
-  clearParseCache();
-
-  return {
-    milestoneId: params.milestoneId,
-    verdict: params.verdict,
-    validationPath,
-  };
-}