gsd-pi 2.44.0-dev.62b5d6c → 2.44.0-dev.848dd4c

package/src/resources/extensions/gsd/tests/files-loadfile-eisdir.test.ts

@@ -6,15 +6,13 @@ import fs from "node:fs";
 
 import { loadFile } from "../files.ts";
 
-test("loadFile returns null for directory paths instead of throwing EISDIR", async () => {
+test("loadFile returns null for directory paths instead of throwing EISDIR", async (t) => {
   const tmp = fs.mkdtempSync(path.join(os.tmpdir(), "gsd-loadfile-eisdir-"));
   const dirPath = path.join(tmp, "tasks");
   fs.mkdirSync(dirPath);
 
-  try {
-    const result = await loadFile(dirPath);
-    assert.equal(result, null);
-  } finally {
-    fs.rmSync(tmp, { recursive: true, force: true });
-  }
+  t.after(() => { fs.rmSync(tmp, { recursive: true, force: true }); });
+
+  const result = await loadFile(dirPath);
+  assert.equal(result, null);
 });

package/src/resources/extensions/gsd/tests/flag-file-db.test.ts

@@ -1,3 +1,5 @@
+import { describe, test } from 'node:test';
+import assert from 'node:assert/strict';
 /**
  * flag-file-db.test.ts — Verify that REPLAN.md and REPLAN-TRIGGER.md
  * flag-file detection in deriveStateFromDb() works from DB-only data
@@ -24,10 +26,6 @@ import {
   insertReplanHistory,
   _getAdapter,
 } from '../gsd-db.ts';
-import { createTestContext } from './test-helpers.ts';
-
-const { assertEq, assertTrue, report } = createTestContext();
-
 // ─── Fixture Helpers ───────────────────────────────────────────────────────
 
 function createFixtureBase(): string {
@@ -78,11 +76,10 @@ const TASK_SUMMARY_STUB = `---\nblocker_discovered: false\n---\n# T01 Summary\nD
 // Tests
 // ═══════════════════════════════════════════════════════════════════════════
 
-async function main(): Promise<void> {
+describe('flag-file-db', async () => {
 
   // ─── Test 1: blocker_discovered + no replan_history → replanning-slice ──
-  console.log('\n=== flag-file-db: blocker + no history → replanning ===');
-  {
+  test('flag-file-db: blocker + no history → replanning', async () => {
     const base = createFixtureBase();
     try {
       // Write disk files needed by deriveStateFromDb (roadmap check, task dir check)
@@ -91,7 +88,7 @@ async function main(): Promise<void> {
       writeFile(base, 'milestones/M001/slices/S01/tasks/T02-PLAN.md', TASK_PLAN_STUB);
 
       openDatabase(':memory:');
-      assertTrue(isDbAvailable(), 'test1: DB is available');
+      assert.ok(isDbAvailable(), 'test1: DB is available');
 
       insertMilestone({ id: 'M001', title: 'Flag-File DB Test', status: 'active' });
       insertSlice({ id: 'S01', milestoneId: 'M001', title: 'Test Slice', status: 'active', risk: 'low', depends: [] });
@@ -102,20 +99,19 @@ async function main(): Promise<void> {
       invalidateStateCache();
       const state = await deriveStateFromDb(base);
 
-      assertEq(state.phase, 'replanning-slice', 'test1: phase is replanning-slice');
-      assertTrue(state.blockers.length > 0, 'test1: has blockers');
-      assertTrue(state.blockers[0]?.includes('blocker'), 'test1: blocker message mentions blocker');
+      assert.deepStrictEqual(state.phase, 'replanning-slice', 'test1: phase is replanning-slice');
+      assert.ok(state.blockers.length > 0, 'test1: has blockers');
+      assert.ok(state.blockers[0]?.includes('blocker'), 'test1: blocker message mentions blocker');
 
       closeDatabase();
     } finally {
       closeDatabase();
       cleanup(base);
     }
-  }
+  });
 
   // ─── Test 2: blocker_discovered + replan_history exists → loop protection → executing ──
-  console.log('\n=== flag-file-db: blocker + history → loop protection ===');
-  {
+  test('flag-file-db: blocker + history → loop protection', async () => {
     const base = createFixtureBase();
     try {
       writeFile(base, 'milestones/M001/M001-ROADMAP.md', ROADMAP_CONTENT);
@@ -139,18 +135,17 @@ async function main(): Promise<void> {
       invalidateStateCache();
       const state = await deriveStateFromDb(base);
 
-      assertEq(state.phase, 'executing', 'test2: phase is executing (loop protection)');
+      assert.deepStrictEqual(state.phase, 'executing', 'test2: phase is executing (loop protection)');
 
       closeDatabase();
     } finally {
       closeDatabase();
       cleanup(base);
     }
-  }
+  });
 
   // ─── Test 3: replan_triggered_at set + no replan_history → replanning-slice ──
-  console.log('\n=== flag-file-db: trigger column + no history → replanning ===');
-  {
+  test('flag-file-db: trigger column + no history → replanning', async () => {
     const base = createFixtureBase();
     try {
       writeFile(base, 'milestones/M001/M001-ROADMAP.md', ROADMAP_CONTENT);
@@ -173,20 +168,19 @@ async function main(): Promise<void> {
       invalidateStateCache();
       const state = await deriveStateFromDb(base);
 
-      assertEq(state.phase, 'replanning-slice', 'test3: phase is replanning-slice');
-      assertTrue(state.blockers.length > 0, 'test3: has blockers');
-      assertTrue(state.blockers[0]?.includes('Triage replan trigger'), 'test3: blocker message mentions triage trigger');
+      assert.deepStrictEqual(state.phase, 'replanning-slice', 'test3: phase is replanning-slice');
+      assert.ok(state.blockers.length > 0, 'test3: has blockers');
+      assert.ok(state.blockers[0]?.includes('Triage replan trigger'), 'test3: blocker message mentions triage trigger');
 
       closeDatabase();
     } finally {
       closeDatabase();
       cleanup(base);
     }
-  }
+  });
 
   // ─── Test 4: replan_triggered_at set + replan_history exists → loop protection ──
-  console.log('\n=== flag-file-db: trigger column + history → loop protection ===');
-  {
+  test('flag-file-db: trigger column + history → loop protection', async () => {
     const base = createFixtureBase();
     try {
       writeFile(base, 'milestones/M001/M001-ROADMAP.md', ROADMAP_CONTENT);
@@ -216,18 +210,17 @@ async function main(): Promise<void> {
       invalidateStateCache();
       const state = await deriveStateFromDb(base);
 
-      assertEq(state.phase, 'executing', 'test4: phase is executing (loop protection)');
+      assert.deepStrictEqual(state.phase, 'executing', 'test4: phase is executing (loop protection)');
 
       closeDatabase();
     } finally {
       closeDatabase();
       cleanup(base);
     }
-  }
+  });
 
   // ─── Test 5: no blocker, no trigger → phase is executing ──────────────
-  console.log('\n=== flag-file-db: no blocker, no trigger → executing ===');
-  {
+  test('flag-file-db: no blocker, no trigger → executing', async () => {
     const base = createFixtureBase();
     try {
       writeFile(base, 'milestones/M001/M001-ROADMAP.md', ROADMAP_CONTENT);
@@ -245,20 +238,19 @@ async function main(): Promise<void> {
       invalidateStateCache();
       const state = await deriveStateFromDb(base);
 
-      assertEq(state.phase, 'executing', 'test5: phase is executing');
-      assertEq(state.activeTask?.id, 'T02', 'test5: activeTask is T02');
-      assertEq(state.blockers.length, 0, 'test5: no blockers');
+      assert.deepStrictEqual(state.phase, 'executing', 'test5: phase is executing');
+      assert.deepStrictEqual(state.activeTask?.id, 'T02', 'test5: activeTask is T02');
+      assert.deepStrictEqual(state.blockers.length, 0, 'test5: no blockers');
 
       closeDatabase();
     } finally {
       closeDatabase();
       cleanup(base);
     }
-  }
+  });
 
   // ─── Diagnostic test: DB column inspection ──────────────────────────
-  console.log('\n=== flag-file-db: replan_triggered_at column is queryable ===');
-  {
+  test('flag-file-db: replan_triggered_at column is queryable', () => {
     openDatabase(':memory:');
 
     insertMilestone({ id: 'M001', title: 'Diagnostic', status: 'active' });
@@ -269,7 +261,7 @@ async function main(): Promise<void> {
     const before = adapter!.prepare(
       "SELECT id, replan_triggered_at FROM slices WHERE milestone_id = :mid",
     ).get({ ":mid": "M001" }) as Record<string, unknown>;
-    assertEq(before["replan_triggered_at"], null, 'diagnostic: replan_triggered_at initially null');
+    assert.deepStrictEqual(before["replan_triggered_at"], null, 'diagnostic: replan_triggered_at initially null');
 
     // After setting
     adapter!.prepare(
@@ -279,12 +271,8 @@ async function main(): Promise<void> {
     const after = adapter!.prepare(
       "SELECT id, replan_triggered_at FROM slices WHERE milestone_id = :mid",
     ).get({ ":mid": "M001" }) as Record<string, unknown>;
-    assertEq(after["replan_triggered_at"], "2025-01-01T00:00:00Z", 'diagnostic: replan_triggered_at is set');
+    assert.deepStrictEqual(after["replan_triggered_at"], "2025-01-01T00:00:00Z", 'diagnostic: replan_triggered_at is set');
 
     closeDatabase();
-  }
-
-  report();
-}
-
-main();
+  });
+});

package/src/resources/extensions/gsd/tests/freeform-decisions.test.ts

@@ -1,4 +1,5 @@
-import { createTestContext } from './test-helpers.ts';
+import { describe, test } from 'node:test';
+import assert from 'node:assert/strict';
 import * as path from 'node:path';
 import * as os from 'node:os';
 import * as fs from 'node:fs';
@@ -13,8 +14,6 @@ import {
   saveDecisionToDb,
 } from '../db-writer.ts';
 
-const { assertEq, assertTrue, report } = createTestContext();
-
 // ═══════════════════════════════════════════════════════════════════════════
 // Helpers
 // ═══════════════════════════════════════════════════════════════════════════
@@ -35,206 +34,199 @@ function cleanupDir(dir: string): void {
 // Bug reproduction: freeform DECISIONS.md content destroyed (#2301)
 // ═══════════════════════════════════════════════════════════════════════════
 
-console.log('\n── parseDecisionsTable silently drops freeform content ──');
-
-{
-  const freeform = `# Project Decisions
-
-## Architecture
-We decided to use a microservices architecture because monoliths don't scale.
-
-## Database
-PostgreSQL was chosen for its reliability and JSONB support.
-
-## Deployment
-- Kubernetes for orchestration
-- Helm charts for packaging
-`;
-
-  const parsed = parseDecisionsTable(freeform);
-  assertEq(parsed.length, 0, 'freeform content yields zero parsed decisions (expected — it is not a table)');
-}
-
-console.log('\n── saveDecisionToDb destroys freeform DECISIONS.md content ──');
-
-{
-  const tmpDir = makeTmpDir();
-  const dbPath = path.join(tmpDir, '.gsd', 'gsd.db');
-  const mdPath = path.join(tmpDir, '.gsd', 'DECISIONS.md');
-  openDatabase(dbPath);
-
-  const freeformContent = `# Project Decisions
-
-## Architecture
-We decided to use a microservices architecture because monoliths don't scale.
-
-## Database
-PostgreSQL was chosen for its reliability and JSONB support.
-
-## Deployment
-- Kubernetes for orchestration
-- Helm charts for packaging
-`;
-
-  // Pre-populate DECISIONS.md with freeform content
-  fs.writeFileSync(mdPath, freeformContent, 'utf-8');
-
-  try {
-    // Save a new decision — this should NOT destroy the freeform content
-    const result = await saveDecisionToDb({
-      scope: 'testing',
-      decision: 'Use Jest for unit tests',
-      choice: 'Jest',
-      rationale: 'Well-known, good DX',
-      when_context: 'M001',
-    }, tmpDir);
-
-    assertEq(result.id, 'D001', 'decision ID assigned correctly');
-
-    // Read back the file
-    const afterContent = fs.readFileSync(mdPath, 'utf-8');
-
-    // The freeform content MUST still be present
-    assertTrue(
-      afterContent.includes('microservices architecture'),
-      'freeform architecture section preserved after saveDecisionToDb',
-    );
-    assertTrue(
-      afterContent.includes('PostgreSQL was chosen'),
-      'freeform database section preserved after saveDecisionToDb',
-    );
-    assertTrue(
-      afterContent.includes('Kubernetes for orchestration'),
-      'freeform deployment section preserved after saveDecisionToDb',
-    );
-
-    // The new decision MUST also be present
-    assertTrue(
-      afterContent.includes('D001'),
-      'new decision D001 present in file',
-    );
-    assertTrue(
-      afterContent.includes('Use Jest for unit tests'),
-      'new decision text present in file',
-    );
-
-    // Save a second decision — freeform content must still survive
-    const result2 = await saveDecisionToDb({
-      scope: 'ci',
-      decision: 'Use GitHub Actions for CI',
-      choice: 'GitHub Actions',
-      rationale: 'Native integration',
-      when_context: 'M001',
-    }, tmpDir);
-
-    assertEq(result2.id, 'D002', 'second decision ID assigned correctly');
-
-    const afterContent2 = fs.readFileSync(mdPath, 'utf-8');
-
-    assertTrue(
-      afterContent2.includes('microservices architecture'),
-      'freeform content still preserved after second save',
-    );
-    assertTrue(
-      afterContent2.includes('D001'),
-      'first decision still present after second save',
-    );
-    assertTrue(
-      afterContent2.includes('D002'),
-      'second decision present after second save',
-    );
-    assertTrue(
-      afterContent2.includes('Use GitHub Actions for CI'),
-      'second decision text present in file',
-    );
-  } finally {
-    closeDatabase();
-    cleanupDir(tmpDir);
-  }
-}
-
-console.log('\n── saveDecisionToDb with table-format DECISIONS.md still regenerates normally ──');
-
-{
-  const tmpDir = makeTmpDir();
-  const dbPath = path.join(tmpDir, '.gsd', 'gsd.db');
-  const mdPath = path.join(tmpDir, '.gsd', 'DECISIONS.md');
-  openDatabase(dbPath);
-
-  // Pre-populate with canonical table format
-  const tableContent = `# Decisions Register
-
-<!-- Append-only. Never edit or remove existing rows.
-     To reverse a decision, add a new row that supersedes it.
-     Read this file at the start of any planning or research phase. -->
-
-| # | When | Scope | Decision | Choice | Rationale | Revisable? | Made By |
-|---|------|-------|----------|--------|-----------|------------|---------|
-| D001 | M001 | arch | Use REST API | REST | Simpler | Yes | human |
-`;
-
-  fs.writeFileSync(mdPath, tableContent, 'utf-8');
-
-  try {
-    const result = await saveDecisionToDb({
-      scope: 'testing',
-      decision: 'Use Vitest',
-      choice: 'Vitest',
-      rationale: 'Fast',
-      when_context: 'M001',
-    }, tmpDir);
-
-    // The pre-existing table decision was NOT in DB, so it won't appear after regen.
-    // But the new decision should be there.
-    assertEq(result.id, 'D001', 'gets D001 since DB was empty');
-
-    const afterContent = fs.readFileSync(mdPath, 'utf-8');
-    // Table-format file gets fully regenerated — this is the normal path
-    assertTrue(
-      afterContent.includes('# Decisions Register'),
-      'table-format file still has header after save',
-    );
-    assertTrue(
-      afterContent.includes('Use Vitest'),
-      'new decision present in regenerated table',
-    );
-  } finally {
-    closeDatabase();
-    cleanupDir(tmpDir);
-  }
-}
-
-console.log('\n── saveDecisionToDb with no existing DECISIONS.md creates table ──');
-
-{
-  const tmpDir = makeTmpDir();
-  const dbPath = path.join(tmpDir, '.gsd', 'gsd.db');
-  const mdPath = path.join(tmpDir, '.gsd', 'DECISIONS.md');
-  openDatabase(dbPath);
-
-  // No DECISIONS.md exists at all
-  assertTrue(!fs.existsSync(mdPath), 'DECISIONS.md does not exist initially');
-
-  try {
-    const result = await saveDecisionToDb({
-      scope: 'arch',
-      decision: 'Brand new decision',
-      choice: 'Option A',
-      rationale: 'Best fit',
-    }, tmpDir);
-
-    assertEq(result.id, 'D001', 'first decision gets D001');
-    assertTrue(fs.existsSync(mdPath), 'DECISIONS.md created');
-
-    const content = fs.readFileSync(mdPath, 'utf-8');
-    assertTrue(content.includes('# Decisions Register'), 'new file has header');
-    assertTrue(content.includes('Brand new decision'), 'new file has decision');
-  } finally {
-    closeDatabase();
-    cleanupDir(tmpDir);
-  }
-}
-
-// ═══════════════════════════════════════════════════════════════════════════
-
-report();
+describe('freeform-decisions', () => {
+  test('parseDecisionsTable silently drops freeform content', () => {
+    const freeform = `# Project Decisions
+
+  ## Architecture
+  We decided to use a microservices architecture because monoliths don't scale.
+
+  ## Database
+  PostgreSQL was chosen for its reliability and JSONB support.
+
+  ## Deployment
+  - Kubernetes for orchestration
+  - Helm charts for packaging
+  `;
+
+    const parsed = parseDecisionsTable(freeform);
+    assert.deepStrictEqual(parsed.length, 0, 'freeform content yields zero parsed decisions (expected — it is not a table)');
+  });
+
+  test('saveDecisionToDb destroys freeform DECISIONS.md content', async () => {
+    const tmpDir = makeTmpDir();
+    const dbPath = path.join(tmpDir, '.gsd', 'gsd.db');
+    const mdPath = path.join(tmpDir, '.gsd', 'DECISIONS.md');
+    openDatabase(dbPath);
+
+    const freeformContent = `# Project Decisions
+
+  ## Architecture
+  We decided to use a microservices architecture because monoliths don't scale.
+
+  ## Database
+  PostgreSQL was chosen for its reliability and JSONB support.
+
+  ## Deployment
+  - Kubernetes for orchestration
+  - Helm charts for packaging
+  `;
+
+    // Pre-populate DECISIONS.md with freeform content
+    fs.writeFileSync(mdPath, freeformContent, 'utf-8');
+
+    try {
+      // Save a new decision — this should NOT destroy the freeform content
+      const result = await saveDecisionToDb({
+        scope: 'testing',
+        decision: 'Use Jest for unit tests',
+        choice: 'Jest',
+        rationale: 'Well-known, good DX',
+        when_context: 'M001',
+      }, tmpDir);
+
+      assert.deepStrictEqual(result.id, 'D001', 'decision ID assigned correctly');
+
+      // Read back the file
+      const afterContent = fs.readFileSync(mdPath, 'utf-8');
+
+      // The freeform content MUST still be present
+      assert.ok(
+        afterContent.includes('microservices architecture'),
+        'freeform architecture section preserved after saveDecisionToDb',
+      );
+      assert.ok(
+        afterContent.includes('PostgreSQL was chosen'),
+        'freeform database section preserved after saveDecisionToDb',
+      );
+      assert.ok(
+        afterContent.includes('Kubernetes for orchestration'),
+        'freeform deployment section preserved after saveDecisionToDb',
+      );
+
+      // The new decision MUST also be present
+      assert.ok(
+        afterContent.includes('D001'),
+        'new decision D001 present in file',
+      );
+      assert.ok(
+        afterContent.includes('Use Jest for unit tests'),
+        'new decision text present in file',
+      );
+
+      // Save a second decision — freeform content must still survive
+      const result2 = await saveDecisionToDb({
+        scope: 'ci',
+        decision: 'Use GitHub Actions for CI',
+        choice: 'GitHub Actions',
+        rationale: 'Native integration',
+        when_context: 'M001',
+      }, tmpDir);
+
+      assert.deepStrictEqual(result2.id, 'D002', 'second decision ID assigned correctly');
+
+      const afterContent2 = fs.readFileSync(mdPath, 'utf-8');
+
+      assert.ok(
+        afterContent2.includes('microservices architecture'),
+        'freeform content still preserved after second save',
+      );
+      assert.ok(
+        afterContent2.includes('D001'),
+        'first decision still present after second save',
+      );
+      assert.ok(
+        afterContent2.includes('D002'),
+        'second decision present after second save',
+      );
+      assert.ok(
+        afterContent2.includes('Use GitHub Actions for CI'),
+        'second decision text present in file',
+      );
+    } finally {
+      closeDatabase();
+      cleanupDir(tmpDir);
+    }
+  });
+
+  test('saveDecisionToDb with table-format DECISIONS.md still regenerates normally', async () => {
+    const tmpDir = makeTmpDir();
+    const dbPath = path.join(tmpDir, '.gsd', 'gsd.db');
+    const mdPath = path.join(tmpDir, '.gsd', 'DECISIONS.md');
+    openDatabase(dbPath);
+
+    // Pre-populate with canonical table format
+    const tableContent = `# Decisions Register
+
+  <!-- Append-only. Never edit or remove existing rows.
+       To reverse a decision, add a new row that supersedes it.
+       Read this file at the start of any planning or research phase. -->
+
+  | # | When | Scope | Decision | Choice | Rationale | Revisable? | Made By |
+  |---|------|-------|----------|--------|-----------|------------|---------|
+  | D001 | M001 | arch | Use REST API | REST | Simpler | Yes | human |
+  `;
+
+    fs.writeFileSync(mdPath, tableContent, 'utf-8');
+
+    try {
+      const result = await saveDecisionToDb({
+        scope: 'testing',
+        decision: 'Use Vitest',
+        choice: 'Vitest',
+        rationale: 'Fast',
+        when_context: 'M001',
+      }, tmpDir);
+
+      // The pre-existing table decision was NOT in DB, so it won't appear after regen.
+      // But the new decision should be there.
+      assert.deepStrictEqual(result.id, 'D001', 'gets D001 since DB was empty');
+
+      const afterContent = fs.readFileSync(mdPath, 'utf-8');
+      // Table-format file gets fully regenerated — this is the normal path
+      assert.ok(
+        afterContent.includes('# Decisions Register'),
+        'table-format file still has header after save',
+      );
+      assert.ok(
+        afterContent.includes('Use Vitest'),
+        'new decision present in regenerated table',
+      );
+    } finally {
+      closeDatabase();
+      cleanupDir(tmpDir);
+    }
+  });
+
+  test('saveDecisionToDb with no existing DECISIONS.md creates table', async () => {
+    const tmpDir = makeTmpDir();
+    const dbPath = path.join(tmpDir, '.gsd', 'gsd.db');
+    const mdPath = path.join(tmpDir, '.gsd', 'DECISIONS.md');
+    openDatabase(dbPath);
+
+    // No DECISIONS.md exists at all
+    assert.ok(!fs.existsSync(mdPath), 'DECISIONS.md does not exist initially');
+
+    try {
+      const result = await saveDecisionToDb({
+        scope: 'arch',
+        decision: 'Brand new decision',
+        choice: 'Option A',
+        rationale: 'Best fit',
+      }, tmpDir);
+
+      assert.deepStrictEqual(result.id, 'D001', 'first decision gets D001');
+      assert.ok(fs.existsSync(mdPath), 'DECISIONS.md created');
+
+      const content = fs.readFileSync(mdPath, 'utf-8');
+      assert.ok(content.includes('# Decisions Register'), 'new file has header');
+      assert.ok(content.includes('Brand new decision'), 'new file has decision');
+    } finally {
+      closeDatabase();
+      cleanupDir(tmpDir);
+    }
+  });
+
+  // ═══════════════════════════════════════════════════════════════════════════
+
+});