gsd-pi 2.43.0 → 2.44.0-dev.62b5d6c

package/src/resources/extensions/gsd/tools/complete-milestone.ts

@@ -0,0 +1,176 @@
+/**
+ * complete-milestone handler — the core operation behind gsd_complete_milestone.
+ *
+ * Validates all slices are complete, updates milestone status in DB,
+ * renders MILESTONE-SUMMARY.md to disk, stores rendered markdown in DB
+ * for recovery, and invalidates caches.
+ */
+
+import { join } from "node:path";
+import { mkdirSync } from "node:fs";
+
+import {
+  transaction,
+  getMilestoneSlices,
+  _getAdapter,
+} from "../gsd-db.js";
+import { resolveMilestonePath, clearPathCache } from "../paths.js";
+import { saveFile, clearParseCache } from "../files.js";
+import { invalidateStateCache } from "../state.js";
+
+export interface CompleteMilestoneParams {
+  milestoneId: string;
+  title: string;
+  oneLiner: string;
+  narrative: string;
+  successCriteriaResults: string;
+  definitionOfDoneResults: string;
+  requirementOutcomes: string;
+  keyDecisions: string[];
+  keyFiles: string[];
+  lessonsLearned: string[];
+  followUps: string;
+  deviations: string;
+}
+
+export interface CompleteMilestoneResult {
+  milestoneId: string;
+  summaryPath: string;
+}
+
+function renderMilestoneSummaryMarkdown(params: CompleteMilestoneParams): string {
+  const now = new Date().toISOString();
+
+  const keyDecisionsYaml = params.keyDecisions.length > 0
+    ? params.keyDecisions.map(d => `  - ${d}`).join("\n")
+    : "  - (none)";
+
+  const keyFilesYaml = params.keyFiles.length > 0
+    ? params.keyFiles.map(f => `  - ${f}`).join("\n")
+    : "  - (none)";
+
+  const lessonsYaml = params.lessonsLearned.length > 0
+    ? params.lessonsLearned.map(l => `  - ${l}`).join("\n")
+    : "  - (none)";
+
+  return `---
+id: ${params.milestoneId}
+title: "${params.title}"
+status: complete
+completed_at: ${now}
+key_decisions:
+${keyDecisionsYaml}
+key_files:
+${keyFilesYaml}
+lessons_learned:
+${lessonsYaml}
+---
+
+# ${params.milestoneId}: ${params.title}
+
+**${params.oneLiner}**
+
+## What Happened
+
+${params.narrative}
+
+## Success Criteria Results
+
+${params.successCriteriaResults}
+
+## Definition of Done Results
+
+${params.definitionOfDoneResults}
+
+## Requirement Outcomes
+
+${params.requirementOutcomes}
+
+## Deviations
+
+${params.deviations || "None."}
+
+## Follow-ups
+
+${params.followUps || "None."}
+`;
+}
+
+export async function handleCompleteMilestone(
+  params: CompleteMilestoneParams,
+  basePath: string,
+): Promise<CompleteMilestoneResult | { error: string }> {
+  // ── Validate required fields ────────────────────────────────────────────
+  if (!params.milestoneId || typeof params.milestoneId !== "string" || params.milestoneId.trim() === "") {
+    return { error: "milestoneId is required and must be a non-empty string" };
+  }
+  if (!params.title || typeof params.title !== "string" || params.title.trim() === "") {
+    return { error: "title is required and must be a non-empty string" };
+  }
+
+  // ── Verify all slices are complete ───────────────────────────────────────
+  const slices = getMilestoneSlices(params.milestoneId);
+  if (slices.length === 0) {
+    return { error: `no slices found for milestone ${params.milestoneId}` };
+  }
+
+  const incompleteSlices = slices.filter(s => s.status !== "complete" && s.status !== "done");
+  if (incompleteSlices.length > 0) {
+    const incompleteIds = incompleteSlices.map(s => `${s.id} (status: ${s.status})`).join(", ");
+    return { error: `incomplete slices: ${incompleteIds}` };
+  }
+
+  // ── DB writes inside a transaction ──────────────────────────────────────
+  const completedAt = new Date().toISOString();
+
+  transaction(() => {
+    const adapter = _getAdapter()!;
+    adapter.prepare(
+      `UPDATE milestones SET status = 'complete', completed_at = :completed_at WHERE id = :mid`,
+    ).run({
+      ":completed_at": completedAt,
+      ":mid": params.milestoneId,
+    });
+  });
+
+  // ── Filesystem operations (outside transaction) ─────────────────────────
+  const summaryMd = renderMilestoneSummaryMarkdown(params);
+
+  let summaryPath: string;
+  const milestoneDir = resolveMilestonePath(basePath, params.milestoneId);
+  if (milestoneDir) {
+    summaryPath = join(milestoneDir, `${params.milestoneId}-SUMMARY.md`);
+  } else {
+    const gsdDir = join(basePath, ".gsd");
+    const manualDir = join(gsdDir, "milestones", params.milestoneId);
+    mkdirSync(manualDir, { recursive: true });
+    summaryPath = join(manualDir, `${params.milestoneId}-SUMMARY.md`);
+  }
+
+  try {
+    await saveFile(summaryPath, summaryMd);
+  } catch (renderErr) {
+    // Disk render failed — roll back DB status so state stays consistent
+    process.stderr.write(
+      `gsd-db: complete_milestone — disk render failed, rolling back DB status: ${(renderErr as Error).message}\n`,
+    );
+    const rollbackAdapter = _getAdapter();
+    if (rollbackAdapter) {
+      rollbackAdapter.prepare(
+        `UPDATE milestones SET status = 'active', completed_at = NULL WHERE id = :mid`,
+      ).run({ ":mid": params.milestoneId });
+    }
+    invalidateStateCache();
+    return { error: `disk render failed: ${(renderErr as Error).message}` };
+  }
+
+  // Invalidate all caches
+  invalidateStateCache();
+  clearPathCache();
+  clearParseCache();
+
+  return {
+    milestoneId: params.milestoneId,
+    summaryPath,
+  };
+}

package/src/resources/extensions/gsd/tools/complete-slice.ts

@@ -0,0 +1,300 @@
+/**
+ * complete-slice handler — the core operation behind gsd_slice_complete.
+ *
+ * Validates inputs, checks all tasks are complete, writes slice row to DB in
+ * a transaction, then (outside the transaction) renders SUMMARY.md + UAT.md
+ * to disk, toggles the roadmap checkbox, stores rendered markdown in DB for
+ * D004 recovery, and invalidates caches.
+ */
+
+import { join } from "node:path";
+import { mkdirSync } from "node:fs";
+
+import type { CompleteSliceParams } from "../types.js";
+import {
+  transaction,
+  insertMilestone,
+  insertSlice,
+  getSliceTasks,
+  updateSliceStatus,
+  _getAdapter,
+} from "../gsd-db.js";
+import { resolveSliceFile, resolveSlicePath, clearPathCache } from "../paths.js";
+import { saveFile, clearParseCache } from "../files.js";
+import { invalidateStateCache } from "../state.js";
+import { renderRoadmapCheckboxes } from "../markdown-renderer.js";
+
+export interface CompleteSliceResult {
+  sliceId: string;
+  milestoneId: string;
+  summaryPath: string;
+  uatPath: string;
+}
+
+/**
+ * Render slice summary markdown matching the template format.
+ * YAML frontmatter uses snake_case keys for parseSummary() compatibility.
+ */
+function renderSliceSummaryMarkdown(params: CompleteSliceParams): string {
+  const now = new Date().toISOString();
+
+  const providesYaml = params.provides.length > 0
+    ? params.provides.map(p => `  - ${p}`).join("\n")
+    : "  - (none)";
+
+  const requiresYaml = params.requires.length > 0
+    ? params.requires.map(r => `  - slice: ${r.slice}\n    provides: ${r.provides}`).join("\n")
+    : "  []";
+
+  const affectsYaml = params.affects.length > 0
+    ? params.affects.map(a => `  - ${a}`).join("\n")
+    : "  []";
+
+  const keyFilesYaml = params.keyFiles.length > 0
+    ? params.keyFiles.map(f => `  - ${f}`).join("\n")
+    : "  - (none)";
+
+  const keyDecisionsYaml = params.keyDecisions.length > 0
+    ? params.keyDecisions.map(d => `  - ${d}`).join("\n")
+    : "  - (none)";
+
+  const patternsYaml = params.patternsEstablished.length > 0
+    ? params.patternsEstablished.map(p => `  - ${p}`).join("\n")
+    : "  - (none)";
+
+  const observabilityYaml = params.observabilitySurfaces.length > 0
+    ? params.observabilitySurfaces.map(o => `  - ${o}`).join("\n")
+    : "  - none";
+
+  const drillDownYaml = params.drillDownPaths.length > 0
+    ? params.drillDownPaths.map(d => `  - ${d}`).join("\n")
+    : "  []";
+
+  // Requirements sections
+  const reqAdvanced = params.requirementsAdvanced.length > 0
+    ? params.requirementsAdvanced.map(r => `- ${r.id} — ${r.how}`).join("\n")
+    : "None.";
+
+  const reqValidated = params.requirementsValidated.length > 0
+    ? params.requirementsValidated.map(r => `- ${r.id} — ${r.proof}`).join("\n")
+    : "None.";
+
+  const reqSurfaced = params.requirementsSurfaced.length > 0
+    ? params.requirementsSurfaced.map(r => `- ${r}`).join("\n")
+    : "None.";
+
+  const reqInvalidated = params.requirementsInvalidated.length > 0
+    ? params.requirementsInvalidated.map(r => `- ${r.id} — ${r.what}`).join("\n")
+    : "None.";
+
+  // Files modified
+  const filesMod = params.filesModified.length > 0
+    ? params.filesModified.map(f => `- \`${f.path}\` — ${f.description}`).join("\n")
+    : "None.";
+
+  return `---
+id: ${params.sliceId}
+parent: ${params.milestoneId}
+milestone: ${params.milestoneId}
+provides:
+${providesYaml}
+requires:
+${requiresYaml}
+affects:
+${affectsYaml}
+key_files:
+${keyFilesYaml}
+key_decisions:
+${keyDecisionsYaml}
+patterns_established:
+${patternsYaml}
+observability_surfaces:
+${observabilityYaml}
+drill_down_paths:
+${drillDownYaml}
+duration: ""
+verification_result: passed
+completed_at: ${now}
+blocker_discovered: false
+---
+
+# ${params.sliceId}: ${params.sliceTitle}
+
+**${params.oneLiner}**
+
+## What Happened
+
+${params.narrative}
+
+## Verification
+
+${params.verification}
+
+## Requirements Advanced
+
+${reqAdvanced}
+
+## Requirements Validated
+
+${reqValidated}
+
+## New Requirements Surfaced
+
+${reqSurfaced}
+
+## Requirements Invalidated or Re-scoped
+
+${reqInvalidated}
+
+## Deviations
+
+${params.deviations || "None."}
+
+## Known Limitations
+
+${params.knownLimitations || "None."}
+
+## Follow-ups
+
+${params.followUps || "None."}
+
+## Files Created/Modified
+
+${filesMod}
+`;
+}
+
+/**
+ * Render UAT markdown matching the template format.
+ */
+function renderUatMarkdown(params: CompleteSliceParams): string {
+  return `# ${params.sliceId}: ${params.sliceTitle} — UAT
+
+**Milestone:** ${params.milestoneId}
+**Written:** ${new Date().toISOString()}
+
+${params.uatContent}
+`;
+}
+
+/**
+ * Handle the complete_slice operation end-to-end.
+ *
+ * 1. Validate required fields
+ * 2. Verify all tasks are complete
+ * 3. Write DB in a transaction (milestone, slice upsert, status update)
+ * 4. Render SUMMARY.md + UAT.md to disk
+ * 5. Toggle roadmap checkbox
+ * 6. Store rendered markdown back in DB (for D004 recovery)
+ * 7. Invalidate caches
+ */
+export async function handleCompleteSlice(
+  params: CompleteSliceParams,
+  basePath: string,
+): Promise<CompleteSliceResult | { error: string }> {
+  // ── Validate required fields ────────────────────────────────────────────
+  if (!params.sliceId || typeof params.sliceId !== "string" || params.sliceId.trim() === "") {
+    return { error: "sliceId is required and must be a non-empty string" };
+  }
+  if (!params.milestoneId || typeof params.milestoneId !== "string" || params.milestoneId.trim() === "") {
+    return { error: "milestoneId is required and must be a non-empty string" };
+  }
+
+  // ── Verify all tasks are complete ───────────────────────────────────────
+  const tasks = getSliceTasks(params.milestoneId, params.sliceId);
+  if (tasks.length === 0) {
+    return { error: `no tasks found for slice ${params.sliceId} in milestone ${params.milestoneId}` };
+  }
+
+  const incompleteTasks = tasks.filter(t => t.status !== "complete");
+  if (incompleteTasks.length > 0) {
+    const incompleteIds = incompleteTasks.map(t => `${t.id} (status: ${t.status})`).join(", ");
+    return { error: `incomplete tasks: ${incompleteIds}` };
+  }
+
+  // ── DB writes inside a transaction ──────────────────────────────────────
+  const completedAt = new Date().toISOString();
+
+  transaction(() => {
+    insertMilestone({ id: params.milestoneId });
+    insertSlice({ id: params.sliceId, milestoneId: params.milestoneId });
+    updateSliceStatus(params.milestoneId, params.sliceId, "complete", completedAt);
+  });
+
+  // ── Filesystem operations (outside transaction) ─────────────────────────
+  // If disk render fails, roll back the DB status so deriveState() and
+  // verifyExpectedArtifact() stay consistent (both say "not done").
+
+  // Render summary markdown
+  const summaryMd = renderSliceSummaryMarkdown(params);
+
+  // Resolve and write summary to disk
+  let summaryPath: string;
+  const sliceDir = resolveSlicePath(basePath, params.milestoneId, params.sliceId);
+  if (sliceDir) {
+    summaryPath = join(sliceDir, `${params.sliceId}-SUMMARY.md`);
+  } else {
+    // Slice dir doesn't exist on disk yet — build path manually and ensure dirs
+    const gsdDir = join(basePath, ".gsd");
+    const manualSliceDir = join(gsdDir, "milestones", params.milestoneId, "slices", params.sliceId);
+    mkdirSync(manualSliceDir, { recursive: true });
+    summaryPath = join(manualSliceDir, `${params.sliceId}-SUMMARY.md`);
+  }
+
+  const uatMd = renderUatMarkdown(params);
+  const uatPath = summaryPath.replace(/-SUMMARY\.md$/, "-UAT.md");
+
+  try {
+    await saveFile(summaryPath, summaryMd);
+    await saveFile(uatPath, uatMd);
+
+    // Toggle roadmap checkbox via renderer module
+    const roadmapToggled = await renderRoadmapCheckboxes(basePath, params.milestoneId);
+    if (!roadmapToggled) {
+      process.stderr.write(
+        `gsd-db: complete_slice — could not find roadmap for ${params.milestoneId}, skipping checkbox toggle\n`,
+      );
+    }
+  } catch (renderErr) {
+    // Disk render failed — roll back DB status so state stays consistent
+    process.stderr.write(
+      `gsd-db: complete_slice — disk render failed, rolling back DB status: ${(renderErr as Error).message}\n`,
+    );
+    const rollbackAdapter = _getAdapter();
+    if (rollbackAdapter) {
+      rollbackAdapter.prepare(
+        `UPDATE slices SET status = 'pending' WHERE milestone_id = :mid AND id = :sid`,
+      ).run({
+        ":mid": params.milestoneId,
+        ":sid": params.sliceId,
+      });
+    }
+    invalidateStateCache();
+    return { error: `disk render failed: ${(renderErr as Error).message}` };
+  }
+
+  // Store rendered markdown in DB for D004 recovery
+  const adapter = _getAdapter();
+  if (adapter) {
+    adapter.prepare(
+      `UPDATE slices SET full_summary_md = :summary_md, full_uat_md = :uat_md WHERE milestone_id = :mid AND id = :sid`,
+    ).run({
+      ":summary_md": summaryMd,
+      ":uat_md": uatMd,
+      ":mid": params.milestoneId,
+      ":sid": params.sliceId,
+    });
+  }
+
+  // Invalidate all caches
+  invalidateStateCache();
+  clearPathCache();
+  clearParseCache();
+
+  return {
+    sliceId: params.sliceId,
+    milestoneId: params.milestoneId,
+    summaryPath,
+    uatPath,
+  };
+}