gsd-pi 2.38.0-dev.63ad7e5 → 2.38.0-dev.785052f

package/src/resources/extensions/gsd/tests/skill-activation.test.ts

@@ -0,0 +1,140 @@
+import test from "node:test";
+import assert from "node:assert/strict";
+import { mkdtempSync, mkdirSync, rmSync, writeFileSync } from "node:fs";
+import { join } from "node:path";
+import { tmpdir } from "node:os";
+import { loadSkills } from "@gsd/pi-coding-agent";
+import { buildSkillActivationBlock } from "../auto-prompts.js";
+import type { GSDPreferences } from "../preferences.js";
+
+function makeTempBase(): string {
+  return mkdtempSync(join(tmpdir(), "gsd-skill-activation-"));
+}
+
+function cleanup(base: string): void {
+  rmSync(base, { recursive: true, force: true });
+}
+
+function writeSkill(base: string, name: string, description: string): void {
+  const dir = join(base, "skills", name);
+  mkdirSync(dir, { recursive: true });
+  writeFileSync(join(dir, "SKILL.md"), `---\nname: ${name}\ndescription: ${description}\n---\n\n# ${name}\n`);
+}
+
+function loadOnlyTestSkills(base: string): void {
+  loadSkills({ cwd: base, includeDefaults: false, skillPaths: [join(base, "skills")] });
+}
+
+function buildBlock(
+  base: string,
+  params: Partial<Parameters<typeof buildSkillActivationBlock>[0]> = {},
+  preferences: GSDPreferences = {},
+): string {
+  return buildSkillActivationBlock({
+    base,
+    milestoneId: "M001",
+    sliceId: "S01",
+    ...params,
+    preferences,
+  });
+}
+
+test("buildSkillActivationBlock matches installed skills from task context", () => {
+  const base = makeTempBase();
+  try {
+    writeSkill(base, "react", "Use for React components, hooks, JSX, and frontend UI work.");
+    writeSkill(base, "swiftui", "Use for SwiftUI views, iOS layout, and Apple platform UI work.");
+    loadOnlyTestSkills(base);
+
+    const result = buildBlock(base, {
+      sliceTitle: "Build React dashboard",
+      taskId: "T01",
+      taskTitle: "Implement React settings panel",
+    });
+
+    assert.match(result, /<skill_activation>/);
+    assert.match(result, /Call Skill\('react'\)/);
+    assert.doesNotMatch(result, /swiftui/);
+  } finally {
+    cleanup(base);
+  }
+});
+
+test("buildSkillActivationBlock includes always_use_skills from preferences", () => {
+  const base = makeTempBase();
+  try {
+    writeSkill(base, "testing", "Use for test setup, assertions, and verification patterns.");
+    loadOnlyTestSkills(base);
+
+    const result = buildBlock(base, { taskTitle: "Unrelated task title" }, {
+      always_use_skills: ["testing"],
+    });
+
+    assert.match(result, /Call Skill\('testing'\)/);
+  } finally {
+    cleanup(base);
+  }
+});
+
+test("buildSkillActivationBlock includes skill_rules matches and task-plan skills_used", () => {
+  const base = makeTempBase();
+  try {
+    writeSkill(base, "prisma", "Use for Prisma schema, migrations, and ORM queries.");
+    writeSkill(base, "accessibility", "Use for accessibility, aria attributes, and keyboard support.");
+    loadOnlyTestSkills(base);
+
+    const taskPlan = [
+      "---",
+      "skills_used:",
+      "  - accessibility",
+      "---",
+      "# T01: Example",
+    ].join("\n");
+
+    const result = buildBlock(base, {
+      taskTitle: "Update prisma schema",
+      taskPlanContent: taskPlan,
+    }, {
+      skill_rules: [{ when: "prisma database schema", use: ["prisma"] }],
+    });
+
+    assert.match(result, /Call Skill\('accessibility'\)/);
+    assert.match(result, /Call Skill\('prisma'\)/);
+  } finally {
+    cleanup(base);
+  }
+});
+
+test("buildSkillActivationBlock honors avoid_skills", () => {
+  const base = makeTempBase();
+  try {
+    writeSkill(base, "react", "Use for React components and frontend UI work.");
+    loadOnlyTestSkills(base);
+
+    const result = buildBlock(base, {
+      taskTitle: "Implement React settings panel",
+    }, {
+      avoid_skills: ["react"],
+    });
+
+    assert.equal(result, "");
+  } finally {
+    cleanup(base);
+  }
+});
+
+test("buildSkillActivationBlock falls back cleanly when nothing matches", () => {
+  const base = makeTempBase();
+  try {
+    writeSkill(base, "swiftui", "Use for SwiftUI apps.");
+    loadOnlyTestSkills(base);
+
+    const result = buildBlock(base, {
+      taskTitle: "Plain text docs task",
+    });
+
+    assert.equal(result, "");
+  } finally {
+    cleanup(base);
+  }
+});

package/src/resources/extensions/gsd/types.ts

@@ -61,6 +61,16 @@ export interface TaskPlanEntry {
   verify?: string; // e.g. "run tests" — extracted from "- Verify:" subline
 }
 
+export interface TaskPlanFrontmatter {
+  estimated_steps?: number; // optional scope estimate for plan quality validator
+  estimated_files?: number; // optional file-count estimate for scope warning heuristics
+  skills_used: string[]; // installed skill slugs/names to hand off to execute-task prompts
+}
+
+export interface TaskPlanFile {
+  frontmatter: TaskPlanFrontmatter;
+}
+
 // ─── Verification Gate ─────────────────────────────────────────────────────
 
 /** Result of a single verification command execution */
@@ -478,3 +488,11 @@ export interface ReactiveExecutionState {
   };
   updatedAt: string;
 }
+
+export interface BrowserFlowResult {
+  url: string;
+  passed: boolean;
+  checksTotal: number;
+  checksPassed: number;
+  duration: number;
+}

package/src/resources/extensions/gsd/verification-evidence.ts

@@ -37,6 +37,21 @@ export interface AuditWarningJSON {
   fixAvailable: boolean;
 }
 
+export interface BrowserEvidenceCheckJSON {
+  description: string;
+  passed: boolean;
+  actual?: string;
+  evidence?: string;
+  error?: string;
+}
+
+export interface BrowserEvidenceJSON {
+  url: string;
+  passed: boolean;
+  checks: BrowserEvidenceCheckJSON[];
+  duration: number;
+}
+
 export interface EvidenceJSON {
   schemaVersion: 1;
   taskId: string;
@@ -49,6 +64,7 @@ export interface EvidenceJSON {
   maxRetries?: number;
   runtimeErrors?: RuntimeErrorJSON[];
   auditWarnings?: AuditWarningJSON[];
+  browser?: BrowserEvidenceJSON;
 }
 
 /**

package/src/resources/extensions/mcp-client/index.ts

@@ -114,6 +114,22 @@ function getServerConfig(name: string): McpServerConfig | undefined {
 	return readConfigs().find((s) => s.name === name);
 }
 
+/** Resolve ${VAR} references in env values against process.env. */
+function resolveEnv(env: Record<string, string>): Record<string, string> {
+	const resolved: Record<string, string> = {};
+	for (const [key, value] of Object.entries(env)) {
+		if (typeof value === "string") {
+			resolved[key] = value.replace(
+				/\$\{([^}]+)\}/g,
+				(_match, varName) => process.env[varName] ?? "",
+			);
+		} else {
+			resolved[key] = value;
+		}
+	}
+	return resolved;
+}
+
 async function getOrConnect(name: string, signal?: AbortSignal): Promise<Client> {
 	const existing = connections.get(name);
 	if (existing) return existing.client;
@@ -128,7 +144,7 @@ async function getOrConnect(name: string, signal?: AbortSignal): Promise<Client>
 		transport = new StdioClientTransport({
 			command: config.command,
 			args: config.args,
-			env: config.env ? { ...process.env, ...config.env } as Record<string, string> : undefined,
+			env: config.env ? { ...process.env, ...resolveEnv(config.env) } as Record<string, string> : undefined,
 			cwd: config.cwd,
 			stderr: "pipe",
 		});

package/src/resources/extensions/remote-questions/status.ts

@@ -7,7 +7,9 @@ import { join } from "node:path";
 import { homedir } from "node:os";
 import { readPromptRecord } from "./store.js";
 
-const gsdHome = process.env.GSD_HOME || join(homedir(), ".gsd");
+function getGsdHome(): string {
+  return process.env.GSD_HOME || join(homedir(), ".gsd");
+}
 
 export interface LatestPromptSummary {
   id: string;
@@ -16,7 +18,7 @@ export interface LatestPromptSummary {
 }
 
 export function getLatestPromptSummary(): LatestPromptSummary | null {
-  const runtimeDir = join(gsdHome, "runtime", "remote-questions");
+  const runtimeDir = join(getGsdHome(), "runtime", "remote-questions");
   if (!existsSync(runtimeDir)) return null;
   const files = readdirSync(runtimeDir).filter((f) => f.endsWith(".json"));
   if (files.length === 0) return null;

package/src/resources/extensions/remote-questions/store.ts

@@ -7,10 +7,12 @@ import { join } from "node:path";
 import { homedir } from "node:os";
 import type { RemotePrompt, RemotePromptRecord, RemotePromptRef, RemoteAnswer, RemotePromptStatus } from "./types.js";
 
-const gsdHome = process.env.GSD_HOME || join(homedir(), ".gsd");
+function getGsdHome(): string {
+  return process.env.GSD_HOME || join(homedir(), ".gsd");
+}
 
 function runtimeDir(): string {
-  return join(gsdHome, "runtime", "remote-questions");
+  return join(getGsdHome(), "runtime", "remote-questions");
 }
 
 function recordPath(id: string): string {

package/src/resources/extensions/shared/frontmatter.ts

@@ -50,7 +50,7 @@ export function parseFrontmatterMap(lines: string[]): Record<string, unknown> {
     }
 
     // Array item (2-space indent)
-    const arrayMatch = line.match(/^  - (.*)$/);
+    const arrayMatch = line.match(/^  - ?(.*)$/);
     if (arrayMatch && currentKey) {
       // If there's a pending nested object, push it
       if (currentObj && Object.keys(currentObj).length > 0) {