gsd-pi 2.37.1-dev.d3ace49 → 2.38.0-dev.29edcdc

package/src/resources/extensions/github-sync/templates.ts

@@ -0,0 +1,183 @@
+/**
+ * Markdown formatters for GitHub issue bodies, PR descriptions,
+ * and summary comments.
+ *
+ * All functions produce GitHub-flavored markdown strings ready
+ * for the `gh` CLI body parameters.
+ */
+
+// ─── Milestone Issue Body ───────────────────────────────────────────────────
+
+export interface MilestoneData {
+  id: string;
+  title: string;
+  vision?: string;
+  successCriteria?: string[];
+  slices?: Array<{ id: string; title: string; taskCount?: number }>;
+}
+
+export function formatMilestoneIssueBody(data: MilestoneData): string {
+  const lines: string[] = [];
+
+  lines.push(`# ${data.id}: ${data.title}`);
+  lines.push("");
+
+  if (data.vision) {
+    lines.push("## Vision");
+    lines.push(data.vision);
+    lines.push("");
+  }
+
+  if (data.successCriteria?.length) {
+    lines.push("## Success Criteria");
+    for (const criterion of data.successCriteria) {
+      lines.push(`- [ ] ${criterion}`);
+    }
+    lines.push("");
+  }
+
+  if (data.slices?.length) {
+    lines.push("## Slices");
+    lines.push("");
+    lines.push("| Slice | Title | Tasks |");
+    lines.push("|-------|-------|-------|");
+    for (const slice of data.slices) {
+      lines.push(`| ${slice.id} | ${slice.title} | ${slice.taskCount ?? "—"} |`);
+    }
+    lines.push("");
+  }
+
+  lines.push("---");
+  lines.push("*Auto-generated by GSD GitHub Sync*");
+
+  return lines.join("\n");
+}
+
+// ─── Slice PR Body ──────────────────────────────────────────────────────────
+
+export interface SliceData {
+  id: string;
+  title: string;
+  goal?: string;
+  mustHaves?: string[];
+  demoCriterion?: string;
+  tasks?: Array<{ id: string; title: string; issueNumber?: number }>;
+}
+
+export function formatSlicePRBody(data: SliceData): string {
+  const lines: string[] = [];
+
+  lines.push(`## ${data.id}: ${data.title}`);
+  lines.push("");
+
+  if (data.goal) {
+    lines.push("### Goal");
+    lines.push(data.goal);
+    lines.push("");
+  }
+
+  if (data.mustHaves?.length) {
+    lines.push("### Must-Haves");
+    for (const item of data.mustHaves) {
+      lines.push(`- ${item}`);
+    }
+    lines.push("");
+  }
+
+  if (data.demoCriterion) {
+    lines.push("### Demo Criterion");
+    lines.push(data.demoCriterion);
+    lines.push("");
+  }
+
+  if (data.tasks?.length) {
+    lines.push("### Tasks");
+    for (const task of data.tasks) {
+      const ref = task.issueNumber ? ` (#${task.issueNumber})` : "";
+      lines.push(`- [ ] ${task.id}: ${task.title}${ref}`);
+    }
+    lines.push("");
+  }
+
+  lines.push("---");
+  lines.push("*Auto-generated by GSD GitHub Sync*");
+
+  return lines.join("\n");
+}
+
+// ─── Task Issue Body ────────────────────────────────────────────────────────
+
+export interface TaskData {
+  id: string;
+  title: string;
+  description?: string;
+  files?: string[];
+  verifyCriteria?: string[];
+}
+
+export function formatTaskIssueBody(data: TaskData): string {
+  const lines: string[] = [];
+
+  lines.push(`## ${data.id}: ${data.title}`);
+  lines.push("");
+
+  if (data.description) {
+    lines.push(data.description);
+    lines.push("");
+  }
+
+  if (data.files?.length) {
+    lines.push("### Files");
+    for (const file of data.files) {
+      lines.push(`- \`${file}\``);
+    }
+    lines.push("");
+  }
+
+  if (data.verifyCriteria?.length) {
+    lines.push("### Verification");
+    for (const criterion of data.verifyCriteria) {
+      lines.push(`- [ ] ${criterion}`);
+    }
+    lines.push("");
+  }
+
+  return lines.join("\n");
+}
+
+// ─── Summary Comment ────────────────────────────────────────────────────────
+
+export interface SummaryData {
+  oneLiner?: string;
+  body?: string;
+  frontmatter?: Record<string, unknown>;
+}
+
+export function formatSummaryComment(data: SummaryData): string {
+  const lines: string[] = [];
+
+  if (data.oneLiner) {
+    lines.push(`**Summary:** ${data.oneLiner}`);
+    lines.push("");
+  }
+
+  if (data.body) {
+    lines.push(data.body);
+    lines.push("");
+  }
+
+  if (data.frontmatter && Object.keys(data.frontmatter).length > 0) {
+    lines.push("<details>");
+    lines.push("<summary>Metadata</summary>");
+    lines.push("");
+    lines.push("```yaml");
+    for (const [key, value] of Object.entries(data.frontmatter)) {
+      lines.push(`${key}: ${JSON.stringify(value)}`);
+    }
+    lines.push("```");
+    lines.push("");
+    lines.push("</details>");
+  }
+
+  return lines.join("\n");
+}

package/src/resources/extensions/github-sync/tests/cli.test.ts

@@ -0,0 +1,20 @@
+import test, { describe, it, beforeEach } from "node:test";
+import assert from "node:assert/strict";
+import { ghIsAvailable, _resetGhCache } from "../cli.ts";
+
+describe("cli", () => {
+  beforeEach(() => {
+    _resetGhCache();
+  });
+
+  it("ghIsAvailable returns boolean", () => {
+    const result = ghIsAvailable();
+    assert.equal(typeof result, "boolean");
+  });
+
+  it("ghIsAvailable caches result", () => {
+    const first = ghIsAvailable();
+    const second = ghIsAvailable();
+    assert.equal(first, second);
+  });
+});

package/src/resources/extensions/github-sync/tests/commit-linking.test.ts

@@ -0,0 +1,39 @@
+import { describe, it } from "node:test";
+import assert from "node:assert/strict";
+import { buildTaskCommitMessage } from "../../gsd/git-service.ts";
+
+describe("commit linking", () => {
+  it("appends Resolves #N when issueNumber is set", () => {
+    const msg = buildTaskCommitMessage({
+      taskId: "S01/T02",
+      taskTitle: "implement auth",
+      issueNumber: 43,
+    });
+    assert.ok(msg.includes("Resolves #43"), "should include Resolves trailer");
+    assert.ok(msg.startsWith("feat(S01/T02):"), "subject line unchanged");
+  });
+
+  it("includes both key files and Resolves #N", () => {
+    const msg = buildTaskCommitMessage({
+      taskId: "S01/T02",
+      taskTitle: "implement auth",
+      keyFiles: ["src/auth.ts"],
+      issueNumber: 43,
+    });
+    assert.ok(msg.includes("- src/auth.ts"), "key files present");
+    assert.ok(msg.includes("Resolves #43"), "Resolves trailer present");
+    // Resolves should come after key files
+    const keyFilesIdx = msg.indexOf("- src/auth.ts");
+    const resolvesIdx = msg.indexOf("Resolves #43");
+    assert.ok(resolvesIdx > keyFilesIdx, "Resolves after key files");
+  });
+
+  it("no Resolves trailer when issueNumber is not set", () => {
+    const msg = buildTaskCommitMessage({
+      taskId: "S01/T02",
+      taskTitle: "implement auth",
+    });
+    assert.ok(!msg.includes("Resolves"), "no Resolves when no issueNumber");
+    assert.ok(!msg.includes("\n"), "no body when no issueNumber or keyFiles");
+  });
+});

package/src/resources/extensions/github-sync/tests/mapping.test.ts

@@ -0,0 +1,104 @@
+import { describe, it, beforeEach, afterEach } from "node:test";
+import assert from "node:assert/strict";
+import { mkdtempSync, mkdirSync, rmSync } from "node:fs";
+import { join } from "node:path";
+import { tmpdir } from "node:os";
+import {
+  loadSyncMapping,
+  saveSyncMapping,
+  createEmptyMapping,
+  getMilestoneRecord,
+  getSliceRecord,
+  getTaskRecord,
+  getTaskIssueNumber,
+  setMilestoneRecord,
+  setSliceRecord,
+  setTaskRecord,
+} from "../mapping.ts";
+import type { SyncMapping, MilestoneSyncRecord, SliceSyncRecord, SyncEntityRecord } from "../types.ts";
+
+describe("mapping", () => {
+  let tmpDir: string;
+
+  beforeEach(() => {
+    tmpDir = mkdtempSync(join(tmpdir(), "gsd-sync-test-"));
+    mkdirSync(join(tmpDir, ".gsd"), { recursive: true });
+  });
+
+  afterEach(() => {
+    rmSync(tmpDir, { recursive: true, force: true });
+  });
+
+  it("loadSyncMapping returns null when no file exists", () => {
+    const result = loadSyncMapping(tmpDir);
+    assert.equal(result, null);
+  });
+
+  it("round-trips save/load", () => {
+    const mapping = createEmptyMapping("owner/repo");
+    saveSyncMapping(tmpDir, mapping);
+    const loaded = loadSyncMapping(tmpDir);
+    assert.deepEqual(loaded, mapping);
+  });
+
+  it("createEmptyMapping has correct structure", () => {
+    const mapping = createEmptyMapping("owner/repo");
+    assert.equal(mapping.version, 1);
+    assert.equal(mapping.repo, "owner/repo");
+    assert.deepEqual(mapping.milestones, {});
+    assert.deepEqual(mapping.slices, {});
+    assert.deepEqual(mapping.tasks, {});
+  });
+
+  it("milestone record accessors work", () => {
+    const mapping = createEmptyMapping("owner/repo");
+    assert.equal(getMilestoneRecord(mapping, "M001"), null);
+
+    const record: MilestoneSyncRecord = {
+      issueNumber: 42,
+      ghMilestoneNumber: 1,
+      lastSyncedAt: "2025-01-01T00:00:00Z",
+      state: "open",
+    };
+    setMilestoneRecord(mapping, "M001", record);
+    assert.deepEqual(getMilestoneRecord(mapping, "M001"), record);
+  });
+
+  it("slice record accessors work", () => {
+    const mapping = createEmptyMapping("owner/repo");
+    assert.equal(getSliceRecord(mapping, "M001", "S01"), null);
+
+    const record: SliceSyncRecord = {
+      issueNumber: 0,
+      prNumber: 50,
+      branch: "milestone/M001/S01",
+      lastSyncedAt: "2025-01-01T00:00:00Z",
+      state: "open",
+    };
+    setSliceRecord(mapping, "M001", "S01", record);
+    assert.deepEqual(getSliceRecord(mapping, "M001", "S01"), record);
+  });
+
+  it("task record accessors work", () => {
+    const mapping = createEmptyMapping("owner/repo");
+    assert.equal(getTaskRecord(mapping, "M001", "S01", "T01"), null);
+    assert.equal(getTaskIssueNumber(mapping, "M001", "S01", "T01"), null);
+
+    const record: SyncEntityRecord = {
+      issueNumber: 43,
+      lastSyncedAt: "2025-01-01T00:00:00Z",
+      state: "open",
+    };
+    setTaskRecord(mapping, "M001", "S01", "T01", record);
+    assert.deepEqual(getTaskRecord(mapping, "M001", "S01", "T01"), record);
+    assert.equal(getTaskIssueNumber(mapping, "M001", "S01", "T01"), 43);
+  });
+
+  it("rejects mapping with wrong version", () => {
+    const mapping = createEmptyMapping("owner/repo");
+    (mapping as any).version = 2;
+    saveSyncMapping(tmpDir, mapping);
+    const loaded = loadSyncMapping(tmpDir);
+    assert.equal(loaded, null);
+  });
+});

package/src/resources/extensions/github-sync/tests/templates.test.ts

@@ -0,0 +1,110 @@
+import { describe, it } from "node:test";
+import assert from "node:assert/strict";
+import {
+  formatMilestoneIssueBody,
+  formatSlicePRBody,
+  formatTaskIssueBody,
+  formatSummaryComment,
+} from "../templates.ts";
+
+describe("templates", () => {
+  describe("formatMilestoneIssueBody", () => {
+    it("includes title and vision", () => {
+      const body = formatMilestoneIssueBody({
+        id: "M001",
+        title: "Build Auth",
+        vision: "Secure authentication for all users",
+      });
+      assert.ok(body.includes("M001: Build Auth"));
+      assert.ok(body.includes("Secure authentication"));
+    });
+
+    it("renders success criteria as checkboxes", () => {
+      const body = formatMilestoneIssueBody({
+        id: "M001",
+        title: "Auth",
+        successCriteria: ["Users can log in", "OAuth works"],
+      });
+      assert.ok(body.includes("- [ ] Users can log in"));
+      assert.ok(body.includes("- [ ] OAuth works"));
+    });
+
+    it("renders slice table", () => {
+      const body = formatMilestoneIssueBody({
+        id: "M001",
+        title: "Auth",
+        slices: [
+          { id: "S01", title: "Core types", taskCount: 3 },
+          { id: "S02", title: "OAuth", taskCount: 5 },
+        ],
+      });
+      assert.ok(body.includes("| S01 | Core types | 3 |"));
+      assert.ok(body.includes("| S02 | OAuth | 5 |"));
+    });
+  });
+
+  describe("formatSlicePRBody", () => {
+    it("includes goal and must-haves", () => {
+      const body = formatSlicePRBody({
+        id: "S01",
+        title: "Core Auth Types",
+        goal: "Define all auth types",
+        mustHaves: ["User type", "Session type"],
+      });
+      assert.ok(body.includes("Define all auth types"));
+      assert.ok(body.includes("- User type"));
+      assert.ok(body.includes("- Session type"));
+    });
+
+    it("renders task checklist with issue links", () => {
+      const body = formatSlicePRBody({
+        id: "S01",
+        title: "Auth",
+        tasks: [
+          { id: "T01", title: "Types", issueNumber: 43 },
+          { id: "T02", title: "Schema" },
+        ],
+      });
+      assert.ok(body.includes("- [ ] T01: Types (#43)"));
+      assert.ok(body.includes("- [ ] T02: Schema"));
+      assert.ok(!body.includes("T02: Schema (#"));
+    });
+  });
+
+  describe("formatTaskIssueBody", () => {
+    it("includes files and verification", () => {
+      const body = formatTaskIssueBody({
+        id: "T01",
+        title: "Add types",
+        files: ["src/types.ts"],
+        verifyCriteria: ["Types compile"],
+      });
+      assert.ok(body.includes("`src/types.ts`"));
+      assert.ok(body.includes("- [ ] Types compile"));
+    });
+  });
+
+  describe("formatSummaryComment", () => {
+    it("includes one-liner and body", () => {
+      const comment = formatSummaryComment({
+        oneLiner: "Added retry logic",
+        body: "Implemented exponential backoff",
+      });
+      assert.ok(comment.includes("**Summary:** Added retry logic"));
+      assert.ok(comment.includes("Implemented exponential backoff"));
+    });
+
+    it("wraps frontmatter in details block", () => {
+      const comment = formatSummaryComment({
+        frontmatter: { duration: "45m", key_files: ["a.ts"] },
+      });
+      assert.ok(comment.includes("<details>"));
+      assert.ok(comment.includes("duration:"));
+    });
+
+    it("handles empty data gracefully", () => {
+      const comment = formatSummaryComment({});
+      assert.equal(typeof comment, "string");
+    });
+  });
+});

package/src/resources/extensions/github-sync/types.ts

@@ -0,0 +1,47 @@
+/**
+ * Type definitions for the GitHub Sync extension.
+ *
+ * Config shape (stored in GSD preferences under `github` key) and
+ * sync mapping records (stored in `.gsd/github-sync.json`).
+ */
+
+// ─── Configuration ──────────────────────────────────────────────────────────
+
+export interface GitHubSyncConfig {
+  enabled: boolean;
+  /** "owner/repo" — auto-detected from git remote if omitted. */
+  repo?: string;
+  /** GitHub Projects v2 number (optional). */
+  project?: number;
+  /** Labels applied to all created issues. */
+  labels?: string[];
+  /** Append "Resolves #N" to task commits. Default: true. */
+  auto_link_commits?: boolean;
+  /** Create per-slice draft PRs. Default: true. */
+  slice_prs?: boolean;
+}
+
+// ─── Sync Mapping ───────────────────────────────────────────────────────────
+
+export interface SyncEntityRecord {
+  issueNumber: number;
+  lastSyncedAt: string;
+  state: "open" | "closed";
+}
+
+export interface MilestoneSyncRecord extends SyncEntityRecord {
+  ghMilestoneNumber: number;
+}
+
+export interface SliceSyncRecord extends SyncEntityRecord {
+  prNumber: number;
+  branch: string;
+}
+
+export interface SyncMapping {
+  version: 1;
+  repo: string;
+  milestones: Record<string, MilestoneSyncRecord>;
+  slices: Record<string, SliceSyncRecord>;
+  tasks: Record<string, SyncEntityRecord>;
+}

package/src/resources/extensions/gsd/auto/session.ts

@@ -124,6 +124,9 @@ export class AutoSession {
   // ── Sidecar queue ─────────────────────────────────────────────────────
   sidecarQueue: SidecarItem[] = [];
 
+  // ── Dispatch circuit breakers ──────────────────────────────────────
+  rewriteAttemptCount = 0;
+
   // ── Metrics ──────────────────────────────────────────────────────────────
   autoStartTime = 0;
   lastPromptCharCount: number | undefined;
@@ -134,27 +137,8 @@ export class AutoSession {
   sigtermHandler: (() => void) | null = null;
 
   // ── Loop promise state ──────────────────────────────────────────────────
-  /**
-   * True only while runUnit is rotating into a fresh session. agent_end events
-   * emitted from the previous session's abort during this window must be
-   * ignored; they do not belong to the new unit.
-   */
-  sessionSwitchInFlight = false;
-
-  /**
-   * One-shot resolver for the current unit's agent_end promise.
-   * Non-null only while a unit is in-flight (between sendMessage and agent_end).
-   * Scoped to the session to prevent concurrent session corruption.
-   */
-  pendingResolve: ((result: { status: "completed" | "cancelled" | "error"; event?: { messages: unknown[] } }) => void) | null = null;
-
-  /**
-   * Queue for agent_end events that arrive when no pendingResolve exists.
-   * This happens when error-recovery sendMessage retries produce agent_end
-   * events between loop iterations. The next runUnit drains this queue
-   * instead of waiting for a new event.
-   */
-  pendingAgentEndQueue: Array<{ messages: unknown[] }> = [];
+  // Per-unit resolve function and session-switch guard live at module level
+  // in auto-loop.ts (_currentResolve, _sessionSwitchInFlight).
 
   // ── Methods ──────────────────────────────────────────────────────────────
 
@@ -228,14 +212,12 @@ export class AutoSession {
     this.lastBaselineCharCount = undefined;
     this.pendingQuickTasks = [];
     this.sidecarQueue = [];
+    this.rewriteAttemptCount = 0;
 
     // Signal handler
     this.sigtermHandler = null;
 
-    // Loop promise state
-    this.sessionSwitchInFlight = false;
-    this.pendingResolve = null;
-    this.pendingAgentEndQueue = [];
+    // Loop promise state lives in auto-loop.ts module scope
   }
 
   toJSON(): Record<string, unknown> {

package/src/resources/extensions/gsd/auto-dispatch.ts

@@ -62,6 +62,7 @@ export interface DispatchContext {
   midTitle: string;
   state: GSDState;
   prefs: GSDPreferences | undefined;
+  session?: import("./auto/session.js").AutoSession;
 }
 
 interface DispatchRule {
@@ -82,26 +83,23 @@ function missingSliceStop(mid: string, phase: string): DispatchAction {
 // ─── Rewrite Circuit Breaker ──────────────────────────────────────────────
 
 const MAX_REWRITE_ATTEMPTS = 3;
-let rewriteAttemptCount = 0;
-export function resetRewriteCircuitBreaker(): void {
-  rewriteAttemptCount = 0;
-}
 
 // ─── Rules ────────────────────────────────────────────────────────────────
 
 const DISPATCH_RULES: DispatchRule[] = [
   {
     name: "rewrite-docs (override gate)",
-    match: async ({ mid, midTitle, state, basePath }) => {
+    match: async ({ mid, midTitle, state, basePath, session }) => {
       const pendingOverrides = await loadActiveOverrides(basePath);
       if (pendingOverrides.length === 0) return null;
-      if (rewriteAttemptCount >= MAX_REWRITE_ATTEMPTS) {
+      const count = session?.rewriteAttemptCount ?? 0;
+      if (count >= MAX_REWRITE_ATTEMPTS) {
         const { resolveAllOverrides } = await import("./files.js");
         await resolveAllOverrides(basePath);
-        rewriteAttemptCount = 0;
+        if (session) session.rewriteAttemptCount = 0;
         return null;
       }
-      rewriteAttemptCount++;
+      if (session) session.rewriteAttemptCount++;
       const unitId = state.activeSlice ? `${mid}/${state.activeSlice.id}` : mid;
       return {
         action: "dispatch",
@@ -157,7 +155,7 @@ const DISPATCH_RULES: DispatchRule[] = [
           uatContent ?? "",
           basePath,
         ),
-        pauseAfterDispatch: uatType !== "artifact-driven",
+        pauseAfterDispatch: uatType !== "artifact-driven" && uatType !== "browser-executable" && uatType !== "runtime-executable",
       };
     },
   },