gsd-pi 2.35.0-dev.4bbf377 → 2.35.0-dev.6179610

package/packages/pi-coding-agent/src/core/agent-session.ts

@@ -1171,14 +1171,11 @@ export class AgentSession {
 		if (images) {
 			content.push(...images);
 		}
-		this.agent.steer(
-			{
-				role: "user",
-				content,
-				timestamp: Date.now(),
-			},
-			"user",
-		);
+		this.agent.steer({
+			role: "user",
+			content,
+			timestamp: Date.now(),
+		});
 	}
 
 	/**
@@ -1190,14 +1187,11 @@ export class AgentSession {
 		if (images) {
 			content.push(...images);
 		}
-		this.agent.followUp(
-			{
-				role: "user",
-				content,
-				timestamp: Date.now(),
-			},
-			"user",
-		);
+		this.agent.followUp({
+			role: "user",
+			content,
+			timestamp: Date.now(),
+		});
 	}
 
 	/**
@@ -1310,28 +1304,10 @@ export class AgentSession {
 	 * @returns Object with steering and followUp arrays
 	 */
 	clearQueue(): { steering: string[]; followUp: string[] } {
-		// Drain user-origin messages from agent queues before clearing.
-		// This preserves messages the user explicitly typed during streaming,
-		// while system-generated messages (extension notifications, etc.) are discarded.
-		const userMessages = this.agent.drainUserMessages();
-
-		// Extract text content from preserved user messages
-		const extractText = (m: AgentMessage): string => {
-			if (!("content" in m) || !Array.isArray(m.content)) return "";
-			const textPart = m.content.find((c: { type: string }) => c.type === "text");
-			return textPart && "text" in textPart ? (textPart as { text: string }).text : "";
-		};
-		const preservedSteering = userMessages.steering.map(extractText).filter((t) => t.length > 0);
-		const preservedFollowUp = userMessages.followUp.map(extractText).filter((t) => t.length > 0);
-
-		// Session-level string arrays track what was queued for display purposes.
-		// Return the full set (session-tracked + any agent-only user messages).
-		const steering = [...this._steeringMessages, ...preservedSteering];
-		const followUp = [...this._followUpMessages, ...preservedFollowUp];
+		const steering = [...this._steeringMessages];
+		const followUp = [...this._followUpMessages];
 		this._steeringMessages = [];
 		this._followUpMessages = [];
-
-		// Clear remaining system messages from agent queues
 		this.agent.clearAllQueues();
 		return { steering, followUp };
 	}

package/src/resources/extensions/gsd/auto-loop.ts

@@ -456,7 +456,6 @@ export interface LoopDeps {
     prefs: GSDPreferences | undefined,
     verbose: boolean,
     startModel: { provider: string; id: string } | null,
-    retryContext?: { isRetry: boolean; previousTier?: string },
   ) => Promise<{ routing: { tier: string; modelDowngraded: boolean } | null }>;
   startUnitSupervision: (sctx: {
     s: AutoSession;
@@ -1183,14 +1182,6 @@ export async function autoLoop(
         unitId,
       });
 
-      // Detect retry and capture previous tier for escalation
-      const isRetry = !!(
-        s.currentUnit &&
-        s.currentUnit.type === unitType &&
-        s.currentUnit.id === unitId
-      );
-      const previousTier = s.currentUnitRouting?.tier;
-
       // Closeout previous unit
       if (s.currentUnit) {
         await deps.closeoutUnit(
@@ -1344,7 +1335,7 @@ export async function autoLoop(
         );
       }
 
-      // Select and apply model (with tier escalation on retry)
+      // Select and apply model
       const modelResult = await deps.selectAndApplyModel(
         ctx,
         pi,
@@ -1354,7 +1345,6 @@ export async function autoLoop(
         prefs,
         s.verbose,
         s.autoModeStartModel,
-        { isRetry, previousTier },
       );
       s.currentUnitRouting =
         modelResult.routing as AutoSession["currentUnitRouting"];

package/src/resources/extensions/gsd/auto-model-selection.ts

@@ -7,9 +7,8 @@
 import type { ExtensionAPI, ExtensionContext } from "@gsd/pi-coding-agent";
 import type { GSDPreferences } from "./preferences.js";
 import { resolveModelWithFallbacksForUnit, resolveDynamicRoutingConfig } from "./preferences.js";
-import type { ComplexityTier } from "./complexity-classifier.js";
 import { classifyUnitComplexity, tierLabel } from "./complexity-classifier.js";
-import { resolveModelForComplexity, escalateTier } from "./model-router.js";
+import { resolveModelForComplexity } from "./model-router.js";
 import { getLedger, getProjectTotals } from "./metrics.js";
 import { unitPhaseLabel } from "./auto-dashboard.js";
 
@@ -34,7 +33,6 @@ export async function selectAndApplyModel(
   prefs: GSDPreferences | undefined,
   verbose: boolean,
   autoModeStartModel: { provider: string; id: string } | null,
-  retryContext?: { isRetry: boolean; previousTier?: string },
 ): Promise<ModelSelectionResult> {
   const modelConfig = resolveModelWithFallbacksForUnit(unitType);
   let routing: { tier: string; modelDowngraded: boolean } | null = null;
@@ -62,27 +60,8 @@ export async function selectAndApplyModel(
       const shouldClassify = !isHook || routingConfig.hooks !== false;
 
       if (shouldClassify) {
-        let classification = classifyUnitComplexity(unitType, unitId, basePath, budgetPct);
+        const classification = classifyUnitComplexity(unitType, unitId, basePath, budgetPct);
         const availableModelIds = availableModels.map(m => m.id);
-
-        // Escalate tier on retry when escalate_on_failure is enabled (default: true)
-        if (
-          retryContext?.isRetry &&
-          retryContext.previousTier &&
-          routingConfig.escalate_on_failure !== false
-        ) {
-          const escalated = escalateTier(retryContext.previousTier as ComplexityTier);
-          if (escalated) {
-            classification = { ...classification, tier: escalated, reason: "escalated after failure" };
-            if (verbose) {
-              ctx.ui.notify(
-                `Tier escalation: ${retryContext.previousTier} → ${escalated} (retry after failure)`,
-                "info",
-              );
-            }
-          }
-        }
-
         const routingResult = resolveModelForComplexity(classification, modelConfig, routingConfig, availableModelIds);
 
         if (routingResult.wasDowngraded) {

package/src/resources/extensions/gsd/commands.ts

@@ -48,7 +48,6 @@ import { computeProgressScore, formatProgressLine } from "./progress-score.js";
 import { runEnvironmentChecks } from "./doctor-environment.js";
 import { handleLogs } from "./commands-logs.js";
 import { handleStart, handleTemplates, getTemplateCompletions } from "./commands-workflow-templates.js";
-import { readSessionLockData, isSessionLockProcessAlive } from "./session-lock.js";
 
 
 /** Resolve the effective project root, accounting for worktree paths. */
@@ -70,39 +69,6 @@ export function projectRoot(): string {
   return root;
 }
 
-/**
- * Check if another process holds the auto-mode session lock.
- * Returns the lock data if a remote session is alive, null otherwise.
- */
-function getRemoteAutoSession(basePath: string): { pid: number } | null {
-  const lockData = readSessionLockData(basePath);
-  if (!lockData) return null;
-  if (lockData.pid === process.pid) return null;
-  if (!isSessionLockProcessAlive(lockData)) return null;
-  return { pid: lockData.pid };
-}
-
-/**
- * Show a steering menu when auto-mode is running in another process.
- * Returns true if a remote session was detected (caller should return early).
- */
-function notifyRemoteAutoActive(ctx: ExtensionCommandContext, basePath: string): boolean {
-  const remote = getRemoteAutoSession(basePath);
-  if (!remote) return false;
-  ctx.ui.notify(
-    `Auto-mode is running in another process (PID ${remote.pid}).\n` +
-    `Use these commands to interact with it:\n` +
-    `  /gsd status   — check progress\n` +
-    `  /gsd discuss  — discuss architecture decisions\n` +
-    `  /gsd queue    — queue the next milestone\n` +
-    `  /gsd steer    — apply an override to active work\n` +
-    `  /gsd capture  — fire-and-forget thought\n` +
-    `  /gsd stop     — stop auto-mode`,
-    "warning",
-  );
-  return true;
-}
-
 export function registerGSDCommand(pi: ExtensionAPI): void {
   pi.registerCommand("gsd", {
     description: "GSD — Get Shit Done: /gsd help|start|templates|next|auto|stop|pause|status|visualize|queue|quick|capture|triage|dispatch|history|undo|skip|export|cleanup|mode|prefs|config|keys|hooks|run-hook|skill-health|doctor|forensics|changelog|migrate|remote|steer|knowledge|new-milestone|parallel|update",
@@ -546,7 +512,6 @@ export async function handleGSDCommand(
           await handleDryRun(ctx, projectRoot());
           return;
         }
-        if (notifyRemoteAutoActive(ctx, projectRoot())) return;
         const verboseMode = trimmed.includes("--verbose");
         const debugMode = trimmed.includes("--debug");
         if (debugMode) enableDebug(projectRoot());
@@ -941,7 +906,7 @@ Examples:
       }
 
       if (trimmed === "") {
-        if (notifyRemoteAutoActive(ctx, projectRoot())) return;
+        // Bare /gsd defaults to step mode
         await startAuto(ctx, pi, projectRoot(), false, { step: true });
         return;
       }

package/src/resources/extensions/gsd/guided-flow.ts

@@ -23,7 +23,6 @@ import {
 } from "./paths.js";
 import { join } from "node:path";
 import { readFileSync, existsSync, mkdirSync, readdirSync, rmSync, unlinkSync } from "node:fs";
-import { readSessionLockData, isSessionLockProcessAlive } from "./session-lock.js";
 import { nativeIsRepo, nativeInit } from "./native-git-bridge.js";
 import { ensureGitignore, ensurePreferences, untrackRuntimeFiles } from "./gitignore.js";
 import { loadEffectiveGSDPreferences } from "./preferences.js";
@@ -517,13 +516,8 @@ export async function showDiscuss(
     // If all pending slices are discussed, notify and exit instead of looping
     const allDiscussed = pendingSlices.every(s => discussedMap.get(s.id));
     if (allDiscussed) {
-      const lockData = readSessionLockData(basePath);
-      const remoteAutoRunning = lockData && lockData.pid !== process.pid && isSessionLockProcessAlive(lockData);
-      const nextStep = remoteAutoRunning
-        ? "Auto-mode is already running — use /gsd status to check progress."
-        : "Run /gsd to start planning.";
       ctx.ui.notify(
-        `All ${pendingSlices.length} slices discussed. ${nextStep}`,
+        `All ${pendingSlices.length} slices discussed. Run /gsd to start planning.`,
         "info",
       );
       return;

package/src/resources/skills/core-web-vitals/SKILL.md

@@ -438,4 +438,4 @@ startTransition(() => setExpensiveState(newValue));
 - [web.dev LCP](https://web.dev/articles/lcp)
 - [web.dev INP](https://web.dev/articles/inp)
 - [web.dev CLS](https://web.dev/articles/cls)
-- [Code Optimizer skill](../code-optimizer/SKILL.md)
+- [Performance skill](../performance/SKILL.md)

package/src/resources/skills/create-gsd-extension/workflows/debug-extension.md

@@ -42,7 +42,7 @@ The file must `export default function(pi: ExtensionAPI) { ... }`.
 
 ## Step 4: Check for Common Mistakes
 
-Read `../references/key-rules-gotchas.md` and verify each rule against the extension code.
+Read `references/key-rules-gotchas.md` and verify each rule against the extension code.
 
 ## Step 5: Add Debugging
 

package/src/resources/skills/github-workflows/SKILL.md

@@ -88,3 +88,5 @@ EVIDENCE: [output from ci_monitor.cjs]
 ## References
 
 - `references/gh/SKILL.md` — gh CLI reference
+- `scripts/ci_monitor.cjs` — CI monitoring tool
+- `scripts/ci_monitor.md` — Tool usage documentation

package/src/resources/skills/swiftui/SKILL.md

@@ -0,0 +1,208 @@
+---
+name: swiftui
+description: SwiftUI apps from scratch through App Store. Full lifecycle - create, debug, test, optimize, ship.
+---
+
+<essential_principles>
+## How We Work
+
+**The user is the product owner. Claude is the developer.**
+
+The user does not write code. The user does not read code. The user describes what they want and judges whether the result is acceptable. Claude implements, verifies, and reports outcomes.
+
+### 1. Prove, Don't Promise
+
+Never say "this should work." Prove it:
+```bash
+xcodebuild build 2>&1 | xcsift  # Build passes
+xcodebuild test                  # Tests pass
+open .../App.app                 # App launches
+```
+If you didn't run it, you don't know it works.
+
+### 2. Tests for Correctness, Eyes for Quality
+
+| Question | How to Answer |
+|----------|---------------|
+| Does the logic work? | Write test, see it pass |
+| Does it look right? | Launch app, user looks at it |
+| Does it feel right? | User uses it |
+| Does it crash? | Test + launch |
+| Is it fast enough? | Profiler |
+
+Tests verify *correctness*. The user verifies *desirability*.
+
+### 3. Report Outcomes, Not Code
+
+**Bad:** "I refactored the view model to use @Observable with environment injection"
+**Good:** "Fixed the state bug. App now updates correctly when you add items. Ready for you to verify."
+
+The user doesn't care what you changed. The user cares what's different.
+
+### 4. Small Steps, Always Verified
+
+```
+Change → Verify → Report → Next change
+```
+
+Never batch up work. Never say "I made several changes." Each change is verified before the next. If something breaks, you know exactly what caused it.
+
+### 5. Ask Before, Not After
+
+Unclear requirement? Ask now.
+Multiple valid approaches? Ask which.
+Scope creep? Ask if wanted.
+Big refactor needed? Ask permission.
+
+Wrong: Build for 30 minutes, then "is this what you wanted?"
+Right: "Before I start, does X mean Y or Z?"
+
+### 6. Always Leave It Working
+
+Every stopping point = working state. Tests pass, app launches, changes committed. The user can walk away anytime and come back to something that works.
+</essential_principles>
+
+<swiftui_principles>
+## SwiftUI Framework Principles
+
+### Declarative Mindset
+Describe what the UI should look like for a given state, not how to mutate it. Let SwiftUI manage the rendering. Never force updates - change the state and let the framework react.
+
+### Single Source of Truth
+Every piece of data has one authoritative location. Use the right property wrapper: @State for view-local, @Observable for shared objects, @Environment for app-wide. Derived data should be computed, not stored.
+
+### Composition Over Inheritance
+Build complex UIs by composing small, focused views. Extract reusable components when patterns emerge. Prefer many small views over few large ones.
+
+### Platform-Adaptive Design
+Write once but respect platform idioms. Use native navigation patterns, respect safe areas, adapt to screen sizes. Test on all target platforms.
+</swiftui_principles>
+
+<intake>
+**What would you like to do?**
+
+1. Build a new SwiftUI app
+2. Debug an existing SwiftUI app
+3. Add a feature to an existing app
+4. Write/run tests
+5. Optimize performance
+6. Ship/release to App Store
+7. Something else
+
+**Then read the matching workflow from `workflows/` and follow it.**
+</intake>
+
+<routing>
+| Response | Workflow |
+|----------|----------|
+| 1, "new", "create", "build", "start" | `workflows/build-new-app.md` |
+| 2, "broken", "fix", "debug", "crash", "bug" | `workflows/debug-swiftui.md` |
+| 3, "add", "feature", "implement", "change" | `workflows/add-feature.md` |
+| 4, "test", "tests", "TDD", "coverage" | `workflows/write-tests.md` |
+| 5, "slow", "optimize", "performance", "fast" | `workflows/optimize-performance.md` |
+| 6, "ship", "release", "deploy", "publish", "app store" | `workflows/ship-app.md` |
+| 7, other | Clarify, then select workflow or references |
+</routing>
+
+<verification_loop>
+## After Every Change
+
+```bash
+# 1. Does it build?
+xcodebuild -scheme AppName build 2>&1 | xcsift
+
+# 2. Do tests pass? (use Core scheme for SwiftUI apps to avoid @main hang)
+xcodebuild -scheme AppNameCore test
+
+# 3. Does it launch?
+# macOS:
+open ./build/Build/Products/Debug/AppName.app
+
+# iOS Simulator:
+xcrun simctl boot "iPhone 15 Pro" 2>/dev/null || true
+xcrun simctl install booted ./build/Build/Products/Debug-iphonesimulator/AppName.app
+xcrun simctl launch booted com.yourcompany.appname
+```
+
+Note: If tests hang, the test target likely depends on the app target which has `@main`. Extract testable code to a framework target. See `../macos-apps/references/testing-tdd.md` for the pattern.
+
+Report to the user:
+- "Build: ✓"
+- "Tests: 12 pass, 0 fail"
+- "App launches, ready for you to check [specific thing]"
+</verification_loop>
+
+<cli_infrastructure>
+## CLI Workflow References
+
+For building, debugging, testing, and shipping from CLI without opening Xcode, read these from `../macos-apps/references/`:
+
+| Reference | Use For |
+|-----------|---------|
+| `cli-workflow.md` | Build, run, test commands; xcodebuild usage; code signing |
+| `cli-observability.md` | Log streaming, crash analysis, memory debugging, LLDB |
+| `project-scaffolding.md` | XcodeGen project.yml templates, file structure, entitlements |
+| `testing-tdd.md` | Test patterns that work from CLI, avoiding @main hangs |
+
+These docs are platform-agnostic. For iOS, change destinations:
+```bash
+# iOS Simulator
+xcodebuild -scheme AppName -destination 'platform=iOS Simulator,name=iPhone 15 Pro' build
+
+# macOS
+xcodebuild -scheme AppName build
+```
+</cli_infrastructure>
+
+<reference_index>
+## Domain Knowledge
+
+All in `references/`:
+
+**Core:**
+- architecture.md - MVVM patterns, project structure, dependency injection
+- state-management.md - Property wrappers, @Observable, data flow
+- layout-system.md - Stacks, grids, GeometryReader, custom layouts
+
+**Navigation & Animation:**
+- navigation.md - NavigationStack, sheets, tabs, deep linking
+- animations.md - Built-in animations, transitions, matchedGeometryEffect
+
+**Data & Platform:**
+- swiftdata.md - Persistence, @Model, @Query, CloudKit sync
+- platform-integration.md - iOS/macOS/watchOS/visionOS specifics
+- uikit-appkit-interop.md - UIViewRepresentable, hosting controllers
+
+**Support:**
+- networking-async.md - async/await, .task modifier, API clients
+- testing-debugging.md - Previews, unit tests, UI tests, debugging
+- performance.md - Profiling, lazy loading, view identity
+</reference_index>
+
+<workflows_index>
+## Workflows
+
+All in `workflows/`:
+
+| Workflow | Purpose |
+|----------|---------|
+| build-new-app.md | Create new SwiftUI app from scratch |
+| debug-swiftui.md | Find and fix SwiftUI bugs |
+| add-feature.md | Add functionality to existing app |
+| write-tests.md | Write UI and unit tests |
+| optimize-performance.md | Profile and improve performance |
+| ship-app.md | App Store submission, TestFlight, distribution |
+</workflows_index>
+
+<canonical_terminology>
+## Terminology
+
+Use these terms consistently:
+- **view** (not: widget, component, element)
+- **@Observable** (not: ObservableObject, @Published for new iOS 17+ code)
+- **NavigationStack** (not: NavigationView - deprecated)
+- **SwiftData** (not: Core Data for new projects)
+- **@Environment** (not: @EnvironmentObject for new code)
+- **modifier** (not: method/function when describing view modifiers)
+- **body** (not: render/build when describing view body)
+</canonical_terminology>