gsd-pi 2.35.0-dev.39eee32 → 2.35.0-dev.4bbf377

package/dist/resources/skills/swiftui/workflows/write-tests.md

@@ -1,235 +0,0 @@
-<required_reading>
-**Read these reference files NOW before starting:**
-1. `../macos-apps/references/cli-workflow.md` - Test commands from CLI
-2. `../macos-apps/references/testing-tdd.md` - TDD patterns, avoiding @main hangs
-3. `references/testing-debugging.md` - SwiftUI-specific testing and debugging
-</required_reading>
-
-<process>
-## Step 1: Identify Testing Scope
-
-**Test business logic in view models, not views:**
-```swift
-// Testable view model
-@Observable
-final class LoginViewModel {
-    var email = ""
-    var password = ""
-    var isLoading = false
-
-    var isValidInput: Bool {
-        !email.isEmpty && password.count >= 8
-    }
-}
-
-// View is just presentation
-struct LoginView: View {
-    let viewModel: LoginViewModel
-    var body: some View {
-        Form {
-            TextField("Email", text: $viewModel.email)
-            Button("Login") { }
-                .disabled(!viewModel.isValidInput)
-        }
-    }
-}
-```
-
-## Step 2: Write Unit Tests
-
-**Using Swift Testing (@Test):**
-```swift
-import Testing
-@testable import MyApp
-
-@Test("Email validation")
-func emailValidation() {
-    let viewModel = LoginViewModel()
-
-    viewModel.email = ""
-    viewModel.password = "password123"
-    #expect(!viewModel.isValidInput)
-
-    viewModel.email = "user@example.com"
-    #expect(viewModel.isValidInput)
-}
-
-@Test("Async loading")
-func asyncLoading() async {
-    let mockService = MockService()
-    let viewModel = TaskViewModel(service: mockService)
-
-    await viewModel.load()
-
-    #expect(!viewModel.tasks.isEmpty)
-}
-```
-
-## Step 3: Add Accessibility Identifiers
-
-```swift
-TextField("Email", text: $email)
-    .accessibilityIdentifier("emailField")
-
-SecureField("Password", text: $password)
-    .accessibilityIdentifier("passwordField")
-
-Button("Login") { }
-    .accessibilityIdentifier("loginButton")
-```
-
-## Step 4: Write UI Tests
-
-```swift
-import XCTest
-
-final class LoginUITests: XCTestCase {
-    var app: XCUIApplication!
-
-    override func setUp() {
-        continueAfterFailure = false
-        app = XCUIApplication()
-        app.launch()
-    }
-
-    func testLoginFlow() {
-        let emailField = app.textFields["emailField"]
-        let passwordField = app.secureTextFields["passwordField"]
-        let loginButton = app.buttons["loginButton"]
-
-        XCTAssertTrue(emailField.waitForExistence(timeout: 5))
-
-        emailField.tap()
-        emailField.typeText("user@example.com")
-
-        passwordField.tap()
-        passwordField.typeText("password123")
-
-        XCTAssertTrue(loginButton.isEnabled)
-        loginButton.tap()
-
-        let welcomeText = app.staticTexts["welcomeMessage"]
-        XCTAssertTrue(welcomeText.waitForExistence(timeout: 5))
-    }
-}
-```
-
-## Step 5: Create Previews for Visual Testing
-
-```swift
-#Preview("Empty") { LoginView(viewModel: LoginViewModel()) }
-
-#Preview("Filled") {
-    let viewModel = LoginViewModel()
-    viewModel.email = "user@example.com"
-    viewModel.password = "password123"
-    return LoginView(viewModel: viewModel)
-}
-
-#Preview("Error") {
-    let viewModel = LoginViewModel()
-    viewModel.errorMessage = "Invalid credentials"
-    return LoginView(viewModel: viewModel)
-}
-
-#Preview("Dark Mode") {
-    LoginView(viewModel: LoginViewModel())
-        .preferredColorScheme(.dark)
-}
-```
-
-## Step 6: Run Tests from CLI
-
-```bash
-# Run all tests with parsed output
-xcodebuild test -scheme AppName -destination 'platform=iOS Simulator,name=iPhone 15 Pro' 2>&1 | xcsift
-
-# Run only unit tests
-xcodebuild test -scheme AppName -only-testing:AppNameTests 2>&1 | xcsift
-
-# Run only UI tests
-xcodebuild test -scheme AppName -only-testing:AppNameUITests 2>&1 | xcsift
-
-# Run specific test class
-xcodebuild test -scheme AppName -only-testing:AppNameTests/LoginViewModelTests 2>&1 | xcsift
-
-# Run specific test method
-xcodebuild test -scheme AppName -only-testing:AppNameTests/LoginViewModelTests/testEmailValidation 2>&1 | xcsift
-
-# Generate test coverage
-xcodebuild test -scheme AppName -enableCodeCoverage YES -resultBundlePath TestResults.xcresult 2>&1 | xcsift
-xcrun xccov view --report TestResults.xcresult
-```
-
-**If tests hang:** The test target likely depends on the app target with `@main`. Extract testable code to a Core framework target. See `../macos-apps/references/testing-tdd.md`.
-
-Report to user:
-- "Tests: X pass, Y fail"
-- "Coverage: Z% of lines"
-- If failures: "Failed tests: [list]. Investigating..."
-</process>
-
-<anti_patterns>
-## Avoid These Mistakes
-
-**Testing view bodies:**
-```swift
-// Wrong: can't test views directly
-func testView() {
-    let view = LoginView()
-    // Can't inspect SwiftUI view
-}
-
-// Right: test view model
-@Test func emailInput() {
-    let viewModel = LoginViewModel()
-    viewModel.email = "test@example.com"
-    #expect(viewModel.email == "test@example.com")
-}
-```
-
-**Missing accessibility identifiers:**
-```swift
-// Wrong: using text
-let button = app.buttons["Login"]
-
-// Right: stable identifier
-let button = app.buttons["loginButton"]
-```
-
-**No dependency injection:**
-```swift
-// Wrong: can't mock
-@Observable
-class ViewModel {
-    private let service = RealService()
-}
-
-// Right: injectable
-@Observable
-class ViewModel {
-    private let service: ServiceProtocol
-    init(service: ServiceProtocol) {
-        self.service = service
-    }
-}
-```
-
-**No edge case testing:**
-```swift
-// Test empty, invalid, error states
-@Test func emptyEmail() { }
-@Test func shortPassword() { }
-@Test func networkError() { }
-```
-</anti_patterns>
-
-<success_criteria>
-This workflow is complete when:
-- [ ] Unit tests verify view model business logic
-- [ ] UI tests verify user flows using accessibility identifiers
-- [ ] All tests pass: `xcodebuild test -scheme YourApp`
-- [ ] Edge cases and error states have coverage
-- [ ] Dependencies use protocols for testability
-- [ ] Previews exist for major UI states
-</success_criteria>

package/src/resources/skills/swiftui/SKILL.md

@@ -1,208 +0,0 @@
----
-name: swiftui
-description: SwiftUI apps from scratch through App Store. Full lifecycle - create, debug, test, optimize, ship.
----
-
-<essential_principles>
-## How We Work
-
-**The user is the product owner. Claude is the developer.**
-
-The user does not write code. The user does not read code. The user describes what they want and judges whether the result is acceptable. Claude implements, verifies, and reports outcomes.
-
-### 1. Prove, Don't Promise
-
-Never say "this should work." Prove it:
-```bash
-xcodebuild build 2>&1 | xcsift  # Build passes
-xcodebuild test                  # Tests pass
-open .../App.app                 # App launches
-```
-If you didn't run it, you don't know it works.
-
-### 2. Tests for Correctness, Eyes for Quality
-
-| Question | How to Answer |
-|----------|---------------|
-| Does the logic work? | Write test, see it pass |
-| Does it look right? | Launch app, user looks at it |
-| Does it feel right? | User uses it |
-| Does it crash? | Test + launch |
-| Is it fast enough? | Profiler |
-
-Tests verify *correctness*. The user verifies *desirability*.
-
-### 3. Report Outcomes, Not Code
-
-**Bad:** "I refactored the view model to use @Observable with environment injection"
-**Good:** "Fixed the state bug. App now updates correctly when you add items. Ready for you to verify."
-
-The user doesn't care what you changed. The user cares what's different.
-
-### 4. Small Steps, Always Verified
-
-```
-Change → Verify → Report → Next change
-```
-
-Never batch up work. Never say "I made several changes." Each change is verified before the next. If something breaks, you know exactly what caused it.
-
-### 5. Ask Before, Not After
-
-Unclear requirement? Ask now.
-Multiple valid approaches? Ask which.
-Scope creep? Ask if wanted.
-Big refactor needed? Ask permission.
-
-Wrong: Build for 30 minutes, then "is this what you wanted?"
-Right: "Before I start, does X mean Y or Z?"
-
-### 6. Always Leave It Working
-
-Every stopping point = working state. Tests pass, app launches, changes committed. The user can walk away anytime and come back to something that works.
-</essential_principles>
-
-<swiftui_principles>
-## SwiftUI Framework Principles
-
-### Declarative Mindset
-Describe what the UI should look like for a given state, not how to mutate it. Let SwiftUI manage the rendering. Never force updates - change the state and let the framework react.
-
-### Single Source of Truth
-Every piece of data has one authoritative location. Use the right property wrapper: @State for view-local, @Observable for shared objects, @Environment for app-wide. Derived data should be computed, not stored.
-
-### Composition Over Inheritance
-Build complex UIs by composing small, focused views. Extract reusable components when patterns emerge. Prefer many small views over few large ones.
-
-### Platform-Adaptive Design
-Write once but respect platform idioms. Use native navigation patterns, respect safe areas, adapt to screen sizes. Test on all target platforms.
-</swiftui_principles>
-
-<intake>
-**What would you like to do?**
-
-1. Build a new SwiftUI app
-2. Debug an existing SwiftUI app
-3. Add a feature to an existing app
-4. Write/run tests
-5. Optimize performance
-6. Ship/release to App Store
-7. Something else
-
-**Then read the matching workflow from `workflows/` and follow it.**
-</intake>
-
-<routing>
-| Response | Workflow |
-|----------|----------|
-| 1, "new", "create", "build", "start" | `workflows/build-new-app.md` |
-| 2, "broken", "fix", "debug", "crash", "bug" | `workflows/debug-swiftui.md` |
-| 3, "add", "feature", "implement", "change" | `workflows/add-feature.md` |
-| 4, "test", "tests", "TDD", "coverage" | `workflows/write-tests.md` |
-| 5, "slow", "optimize", "performance", "fast" | `workflows/optimize-performance.md` |
-| 6, "ship", "release", "deploy", "publish", "app store" | `workflows/ship-app.md` |
-| 7, other | Clarify, then select workflow or references |
-</routing>
-
-<verification_loop>
-## After Every Change
-
-```bash
-# 1. Does it build?
-xcodebuild -scheme AppName build 2>&1 | xcsift
-
-# 2. Do tests pass? (use Core scheme for SwiftUI apps to avoid @main hang)
-xcodebuild -scheme AppNameCore test
-
-# 3. Does it launch?
-# macOS:
-open ./build/Build/Products/Debug/AppName.app
-
-# iOS Simulator:
-xcrun simctl boot "iPhone 15 Pro" 2>/dev/null || true
-xcrun simctl install booted ./build/Build/Products/Debug-iphonesimulator/AppName.app
-xcrun simctl launch booted com.yourcompany.appname
-```
-
-Note: If tests hang, the test target likely depends on the app target which has `@main`. Extract testable code to a framework target. See `../macos-apps/references/testing-tdd.md` for the pattern.
-
-Report to the user:
-- "Build: ✓"
-- "Tests: 12 pass, 0 fail"
-- "App launches, ready for you to check [specific thing]"
-</verification_loop>
-
-<cli_infrastructure>
-## CLI Workflow References
-
-For building, debugging, testing, and shipping from CLI without opening Xcode, read these from `../macos-apps/references/`:
-
-| Reference | Use For |
-|-----------|---------|
-| `cli-workflow.md` | Build, run, test commands; xcodebuild usage; code signing |
-| `cli-observability.md` | Log streaming, crash analysis, memory debugging, LLDB |
-| `project-scaffolding.md` | XcodeGen project.yml templates, file structure, entitlements |
-| `testing-tdd.md` | Test patterns that work from CLI, avoiding @main hangs |
-
-These docs are platform-agnostic. For iOS, change destinations:
-```bash
-# iOS Simulator
-xcodebuild -scheme AppName -destination 'platform=iOS Simulator,name=iPhone 15 Pro' build
-
-# macOS
-xcodebuild -scheme AppName build
-```
-</cli_infrastructure>
-
-<reference_index>
-## Domain Knowledge
-
-All in `references/`:
-
-**Core:**
-- architecture.md - MVVM patterns, project structure, dependency injection
-- state-management.md - Property wrappers, @Observable, data flow
-- layout-system.md - Stacks, grids, GeometryReader, custom layouts
-
-**Navigation & Animation:**
-- navigation.md - NavigationStack, sheets, tabs, deep linking
-- animations.md - Built-in animations, transitions, matchedGeometryEffect
-
-**Data & Platform:**
-- swiftdata.md - Persistence, @Model, @Query, CloudKit sync
-- platform-integration.md - iOS/macOS/watchOS/visionOS specifics
-- uikit-appkit-interop.md - UIViewRepresentable, hosting controllers
-
-**Support:**
-- networking-async.md - async/await, .task modifier, API clients
-- testing-debugging.md - Previews, unit tests, UI tests, debugging
-- performance.md - Profiling, lazy loading, view identity
-</reference_index>
-
-<workflows_index>
-## Workflows
-
-All in `workflows/`:
-
-| Workflow | Purpose |
-|----------|---------|
-| build-new-app.md | Create new SwiftUI app from scratch |
-| debug-swiftui.md | Find and fix SwiftUI bugs |
-| add-feature.md | Add functionality to existing app |
-| write-tests.md | Write UI and unit tests |
-| optimize-performance.md | Profile and improve performance |
-| ship-app.md | App Store submission, TestFlight, distribution |
-</workflows_index>
-
-<canonical_terminology>
-## Terminology
-
-Use these terms consistently:
-- **view** (not: widget, component, element)
-- **@Observable** (not: ObservableObject, @Published for new iOS 17+ code)
-- **NavigationStack** (not: NavigationView - deprecated)
-- **SwiftData** (not: Core Data for new projects)
-- **@Environment** (not: @EnvironmentObject for new code)
-- **modifier** (not: method/function when describing view modifiers)
-- **body** (not: render/build when describing view body)
-</canonical_terminology>