gsd-pi 2.35.0-dev.30eec3f → 2.35.0-dev.640d5c7

package/dist/resources/extensions/gsd/roadmap-mutations.js

@@ -1,55 +0,0 @@
-/**
- * Roadmap Mutations — shared utilities for modifying roadmap checkbox state.
- *
- * Extracts the duplicated "flip slice checkbox" pattern that existed in
- * doctor.ts, mechanical-completion.ts, and auto-recovery.ts.
- */
-import { readFileSync } from "node:fs";
-import { atomicWriteSync } from "./atomic-write.js";
-import { resolveMilestoneFile } from "./paths.js";
-import { clearParseCache } from "./files.js";
-/**
- * Mark a slice as done ([x]) in the milestone roadmap.
- * Idempotent — no-op if already checked or if the slice isn't found.
- *
- * @returns true if the roadmap was modified, false if no change was needed
- */
-export function markSliceDoneInRoadmap(basePath, mid, sid) {
-    const roadmapFile = resolveMilestoneFile(basePath, mid, "ROADMAP");
-    if (!roadmapFile)
-        return false;
-    let content;
-    try {
-        content = readFileSync(roadmapFile, "utf-8");
-    }
-    catch {
-        return false;
-    }
-    const updated = content.replace(new RegExp(`^(\\s*-\\s+)\\[ \\]\\s+\\*\\*${sid}:`, "m"), `$1[x] **${sid}:`);
-    if (updated === content)
-        return false;
-    atomicWriteSync(roadmapFile, updated);
-    clearParseCache();
-    return true;
-}
-/**
- * Mark a task as done ([x]) in the slice plan.
- * Idempotent — no-op if already checked or if the task isn't found.
- *
- * @returns true if the plan was modified, false if no change was needed
- */
-export function markTaskDoneInPlan(basePath, planPath, tid) {
-    let content;
-    try {
-        content = readFileSync(planPath, "utf-8");
-    }
-    catch {
-        return false;
-    }
-    const updated = content.replace(new RegExp(`^(\\s*-\\s+)\\[ \\]\\s+\\*\\*${tid}:`, "m"), `$1[x] **${tid}:`);
-    if (updated === content)
-        return false;
-    atomicWriteSync(planPath, updated);
-    clearParseCache();
-    return true;
-}

package/src/resources/extensions/gsd/health-widget-core.ts

@@ -1,129 +0,0 @@
-/**
- * Pure GSD health widget logic.
- *
- * Separates project-state detection and line rendering from the widget's
- * runtime integrations so the regressions can be tested directly.
- */
-
-import { existsSync, readdirSync } from "node:fs";
-import { gsdRoot } from "./paths.js";
-import { join } from "node:path";
-import type { GSDState, Phase } from "./types.js";
-
-export type HealthWidgetProjectState = "none" | "initialized" | "active";
-
-export interface HealthWidgetData {
-  projectState: HealthWidgetProjectState;
-  budgetCeiling: number | undefined;
-  budgetSpent: number;
-  providerIssue: string | null;
-  environmentErrorCount: number;
-  environmentWarningCount: number;
-  lastRefreshed: number;
-  executionPhase?: Phase;
-  executionStatus?: string;
-  executionTarget?: string;
-  nextAction?: string;
-  blocker?: string | null;
-  activeMilestoneId?: string;
-  activeSliceId?: string;
-  activeTaskId?: string;
-  progress?: GSDState["progress"];
-  eta?: string | null;
-}
-
-export function detectHealthWidgetProjectState(basePath: string): HealthWidgetProjectState {
-  const root = gsdRoot(basePath);
-  if (!existsSync(root)) return "none";
-
-  // Lightweight milestone count — avoids the full detectProjectState() scan
-  // (CI markers, Makefile targets, etc.) that is unnecessary on the 60s refresh.
-  try {
-    const milestonesDir = join(root, "milestones");
-    if (existsSync(milestonesDir)) {
-      const entries = readdirSync(milestonesDir, { withFileTypes: true });
-      if (entries.some(e => e.isDirectory())) return "active";
-    }
-  } catch { /* non-fatal */ }
-
-  return "initialized";
-}
-
-function formatCost(n: number): string {
-  return n >= 1 ? `$${n.toFixed(2)}` : `${(n * 100).toFixed(1)}¢`;
-}
-
-function formatProgress(progress?: GSDState["progress"]): string | null {
-  if (!progress) return null;
-
-  const parts: string[] = [];
-  parts.push(`M ${progress.milestones.done}/${progress.milestones.total}`);
-  if (progress.slices) parts.push(`S ${progress.slices.done}/${progress.slices.total}`);
-  if (progress.tasks) parts.push(`T ${progress.tasks.done}/${progress.tasks.total}`);
-  return parts.length > 0 ? `Progress: ${parts.join(" · ")}` : null;
-}
-
-function formatEnvironmentSummary(errorCount: number, warningCount: number): string | null {
-  if (errorCount <= 0 && warningCount <= 0) return null;
-
-  const parts: string[] = [];
-  if (errorCount > 0) parts.push(`${errorCount} error${errorCount > 1 ? "s" : ""}`);
-  if (warningCount > 0) parts.push(`${warningCount} warning${warningCount > 1 ? "s" : ""}`);
-  return `Env: ${parts.join(", ")}`;
-}
-
-function formatBudgetSummary(data: HealthWidgetData): string | null {
-  if (data.budgetCeiling !== undefined && data.budgetCeiling > 0) {
-    const pct = Math.min(100, (data.budgetSpent / data.budgetCeiling) * 100);
-    return `Budget: ${formatCost(data.budgetSpent)}/${formatCost(data.budgetCeiling)} (${pct.toFixed(0)}%)`;
-  }
-  if (data.budgetSpent > 0) {
-    return `Spent: ${formatCost(data.budgetSpent)}`;
-  }
-  return null;
-}
-
-function buildExecutionHeadline(data: HealthWidgetData): string {
-  const status = data.executionStatus ?? "Active project";
-  const target = data.executionTarget ?? data.blocker ?? "loading status…";
-  return `  GSD  ${status}${target ? ` - ${target}` : ""}`;
-}
-
-/**
- * Build compact health lines for the widget.
- * Returns a string array suitable for setWidget().
- */
-export function buildHealthLines(data: HealthWidgetData): string[] {
-  if (data.projectState === "none") {
-    return ["  GSD  No project loaded — run /gsd to start"];
-  }
-
-  if (data.projectState === "initialized") {
-    return ["  GSD  Project initialized — run /gsd to continue setup"];
-  }
-
-  const lines = [buildExecutionHeadline(data)];
-  const details: string[] = [];
-
-  const progress = formatProgress(data.progress);
-  if (progress) details.push(progress);
-
-  if (data.providerIssue) details.push(data.providerIssue);
-
-  const environment = formatEnvironmentSummary(
-    data.environmentErrorCount,
-    data.environmentWarningCount,
-  );
-  if (environment) details.push(environment);
-
-  const budget = formatBudgetSummary(data);
-  if (budget) details.push(budget);
-
-  if (data.eta) details.push(data.eta);
-
-  if (details.length > 0) {
-    lines.push(`  ${details.join("  │  ")}`);
-  }
-
-  return lines;
-}

package/src/resources/extensions/gsd/roadmap-mutations.ts

@@ -1,66 +0,0 @@
-/**
- * Roadmap Mutations — shared utilities for modifying roadmap checkbox state.
- *
- * Extracts the duplicated "flip slice checkbox" pattern that existed in
- * doctor.ts, mechanical-completion.ts, and auto-recovery.ts.
- */
-
-import { readFileSync } from "node:fs";
-import { atomicWriteSync } from "./atomic-write.js";
-import { resolveMilestoneFile } from "./paths.js";
-import { clearParseCache } from "./files.js";
-
-/**
- * Mark a slice as done ([x]) in the milestone roadmap.
- * Idempotent — no-op if already checked or if the slice isn't found.
- *
- * @returns true if the roadmap was modified, false if no change was needed
- */
-export function markSliceDoneInRoadmap(basePath: string, mid: string, sid: string): boolean {
-  const roadmapFile = resolveMilestoneFile(basePath, mid, "ROADMAP");
-  if (!roadmapFile) return false;
-
-  let content: string;
-  try {
-    content = readFileSync(roadmapFile, "utf-8");
-  } catch {
-    return false;
-  }
-
-  const updated = content.replace(
-    new RegExp(`^(\\s*-\\s+)\\[ \\]\\s+\\*\\*${sid}:`, "m"),
-    `$1[x] **${sid}:`,
-  );
-
-  if (updated === content) return false;
-
-  atomicWriteSync(roadmapFile, updated);
-  clearParseCache();
-  return true;
-}
-
-/**
- * Mark a task as done ([x]) in the slice plan.
- * Idempotent — no-op if already checked or if the task isn't found.
- *
- * @returns true if the plan was modified, false if no change was needed
- */
-export function markTaskDoneInPlan(basePath: string, planPath: string, tid: string): boolean {
-  let content: string;
-  try {
-    content = readFileSync(planPath, "utf-8");
-  } catch {
-    return false;
-  }
-
-  const updated = content.replace(
-    new RegExp(`^(\\s*-\\s+)\\[ \\]\\s+\\*\\*${tid}:`, "m"),
-    `$1[x] **${tid}:`,
-  );
-
-  if (updated === content) return false;
-
-  atomicWriteSync(planPath, updated);
-  clearParseCache();
-  return true;
-}

package/src/resources/extensions/gsd/tests/gitignore-tracked-gsd.test.ts

@@ -1,214 +0,0 @@
-/**
- * gitignore-tracked-gsd.test.ts — Regression tests for #1364.
- *
- * Verifies that ensureGitignore() does NOT add ".gsd" to .gitignore
- * when .gsd/ contains git-tracked files, and that migrateToExternalState()
- * aborts migration for tracked .gsd/ directories.
- *
- * Uses real temporary git repos — no mocks.
- */
-
-import test from "node:test";
-import assert from "node:assert/strict";
-import { execFileSync } from "node:child_process";
-import {
-  existsSync,
-  mkdirSync,
-  mkdtempSync,
-  readFileSync,
-  rmSync,
-  writeFileSync,
-} from "node:fs";
-import { join } from "node:path";
-import { tmpdir } from "node:os";
-
-import { ensureGitignore, hasGitTrackedGsdFiles } from "../gitignore.ts";
-import { migrateToExternalState } from "../migrate-external.ts";
-
-// ─── Helpers ─────────────────────────────────────────────────────────
-
-function git(dir: string, ...args: string[]): string {
-  return execFileSync("git", args, { cwd: dir, stdio: "pipe", encoding: "utf-8" }).trim();
-}
-
-function makeTempRepo(): string {
-  const dir = mkdtempSync(join(tmpdir(), "gsd-gitignore-test-"));
-  git(dir, "init");
-  git(dir, "config", "user.email", "test@test.com");
-  git(dir, "config", "user.name", "Test");
-  writeFileSync(join(dir, "README.md"), "# init\n");
-  git(dir, "add", "-A");
-  git(dir, "commit", "-m", "init");
-  git(dir, "branch", "-M", "main");
-  return dir;
-}
-
-function cleanup(dir: string): void {
-  try {
-    rmSync(dir, { recursive: true, force: true });
-  } catch {
-    // ignore
-  }
-}
-
-// ─── hasGitTrackedGsdFiles ───────────────────────────────────────────
-
-test("hasGitTrackedGsdFiles returns false when .gsd/ does not exist", () => {
-  const dir = makeTempRepo();
-  try {
-    assert.equal(hasGitTrackedGsdFiles(dir), false);
-  } finally {
-    cleanup(dir);
-  }
-});
-
-test("hasGitTrackedGsdFiles returns true when .gsd/ has tracked files", () => {
-  const dir = makeTempRepo();
-  try {
-    mkdirSync(join(dir, ".gsd", "milestones"), { recursive: true });
-    writeFileSync(join(dir, ".gsd", "PROJECT.md"), "# Test Project\n");
-    git(dir, "add", ".gsd/PROJECT.md");
-    git(dir, "commit", "-m", "add gsd");
-    assert.equal(hasGitTrackedGsdFiles(dir), true);
-  } finally {
-    cleanup(dir);
-  }
-});
-
-test("hasGitTrackedGsdFiles returns false when .gsd/ exists but is untracked", () => {
-  const dir = makeTempRepo();
-  try {
-    mkdirSync(join(dir, ".gsd"), { recursive: true });
-    writeFileSync(join(dir, ".gsd", "STATE.md"), "state\n");
-    // Not git-added — should return false
-    assert.equal(hasGitTrackedGsdFiles(dir), false);
-  } finally {
-    cleanup(dir);
-  }
-});
-
-// ─── ensureGitignore — tracked .gsd/ protection ─────────────────────
-
-test("ensureGitignore does NOT add .gsd when .gsd/ has tracked files (#1364)", () => {
-  const dir = makeTempRepo();
-  try {
-    // Set up .gsd/ with tracked files
-    mkdirSync(join(dir, ".gsd", "milestones"), { recursive: true });
-    writeFileSync(join(dir, ".gsd", "PROJECT.md"), "# Test Project\n");
-    writeFileSync(join(dir, ".gsd", "DECISIONS.md"), "# Decisions\n");
-    git(dir, "add", ".gsd/");
-    git(dir, "commit", "-m", "track gsd state");
-
-    // Run ensureGitignore
-    ensureGitignore(dir);
-
-    // Verify .gsd is NOT in .gitignore
-    const gitignore = readFileSync(join(dir, ".gitignore"), "utf-8");
-    const lines = gitignore.split("\n").map((l) => l.trim());
-    assert.ok(
-      !lines.includes(".gsd"),
-      `Expected .gsd NOT to appear in .gitignore, but it does:\n${gitignore}`,
-    );
-
-    // Other baseline patterns should still be present
-    assert.ok(lines.includes(".DS_Store"), "Expected .DS_Store in .gitignore");
-    assert.ok(lines.includes("node_modules/"), "Expected node_modules/ in .gitignore");
-  } finally {
-    cleanup(dir);
-  }
-});
-
-test("ensureGitignore adds .gsd when .gsd/ has NO tracked files", () => {
-  const dir = makeTempRepo();
-  try {
-    // Run ensureGitignore (no .gsd/ at all)
-    ensureGitignore(dir);
-
-    // Verify .gsd IS in .gitignore
-    const gitignore = readFileSync(join(dir, ".gitignore"), "utf-8");
-    const lines = gitignore.split("\n").map((l) => l.trim());
-    assert.ok(
-      lines.includes(".gsd"),
-      `Expected .gsd in .gitignore, but it's missing:\n${gitignore}`,
-    );
-  } finally {
-    cleanup(dir);
-  }
-});
-
-test("ensureGitignore respects manageGitignore: false", () => {
-  const dir = makeTempRepo();
-  try {
-    const result = ensureGitignore(dir, { manageGitignore: false });
-    assert.equal(result, false);
-    assert.ok(!existsSync(join(dir, ".gitignore")), "Should not create .gitignore");
-  } finally {
-    cleanup(dir);
-  }
-});
-
-// ─── ensureGitignore — verify no tracked files become invisible ─────
-
-test("ensureGitignore with tracked .gsd/ does not cause git to see files as deleted", () => {
-  const dir = makeTempRepo();
-  try {
-    // Create tracked .gsd/ files
-    mkdirSync(join(dir, ".gsd", "milestones", "M001"), { recursive: true });
-    writeFileSync(join(dir, ".gsd", "PROJECT.md"), "# Project\n");
-    writeFileSync(
-      join(dir, ".gsd", "milestones", "M001", "M001-CONTEXT.md"),
-      "# M001\n",
-    );
-    git(dir, "add", ".gsd/");
-    git(dir, "commit", "-m", "track gsd state");
-
-    // Run ensureGitignore
-    ensureGitignore(dir);
-
-    // git status should show NO deleted files under .gsd/
-    const status = git(dir, "status", "--porcelain", ".gsd/");
-
-    // Filter for deletions (lines starting with " D" or "D ")
-    const deletions = status
-      .split("\n")
-      .filter((l) => l.match(/^\s*D\s/) || l.match(/^D\s/));
-
-    assert.equal(
-      deletions.length,
-      0,
-      `Expected no deleted .gsd/ files, but found:\n${deletions.join("\n")}`,
-    );
-  } finally {
-    cleanup(dir);
-  }
-});
-
-// ─── migrateToExternalState — tracked .gsd/ protection ──────────────
-
-test("migrateToExternalState aborts when .gsd/ has tracked files (#1364)", () => {
-  const dir = makeTempRepo();
-  try {
-    // Create tracked .gsd/ files
-    mkdirSync(join(dir, ".gsd", "milestones"), { recursive: true });
-    writeFileSync(join(dir, ".gsd", "PROJECT.md"), "# Project\n");
-    git(dir, "add", ".gsd/");
-    git(dir, "commit", "-m", "track gsd state");
-
-    // Attempt migration — should abort without moving anything
-    const result = migrateToExternalState(dir);
-
-    assert.equal(result.migrated, false, "Should NOT migrate tracked .gsd/");
-    assert.equal(result.error, undefined, "Should not report an error — just skip");
-
-    // .gsd/ should still be a real directory, not a symlink
-    assert.ok(existsSync(join(dir, ".gsd", "PROJECT.md")), ".gsd/PROJECT.md should still exist");
-
-    // No .gsd.migrating should exist
-    assert.ok(
-      !existsSync(join(dir, ".gsd.migrating")),
-      ".gsd.migrating should not exist",
-    );
-  } finally {
-    cleanup(dir);
-  }
-});

package/src/resources/extensions/gsd/tests/health-widget.test.ts

@@ -1,158 +0,0 @@
-import test from "node:test";
-import assert from "node:assert/strict";
-import { mkdirSync, rmSync, writeFileSync } from "node:fs";
-import { join } from "node:path";
-import { tmpdir } from "node:os";
-import {
-  buildHealthLines,
-  detectHealthWidgetProjectState,
-  type HealthWidgetData,
-} from "../health-widget-core.ts";
-
-function makeTempDir(prefix: string): string {
-  const dir = join(
-    tmpdir(),
-    `gsd-health-widget-test-${prefix}-${Date.now()}-${Math.random().toString(36).slice(2, 8)}`,
-  );
-  mkdirSync(dir, { recursive: true });
-  return dir;
-}
-
-function cleanup(dir: string): void {
-  try {
-    rmSync(dir, { recursive: true, force: true });
-  } catch {
-    // best-effort
-  }
-}
-
-function activeData(overrides: Partial<HealthWidgetData> = {}): HealthWidgetData {
-  return {
-    projectState: "active",
-    budgetCeiling: undefined,
-    budgetSpent: 0,
-    providerIssue: null,
-    environmentErrorCount: 0,
-    environmentWarningCount: 0,
-    lastRefreshed: Date.now(),
-    ...overrides,
-  };
-}
-
-test("detectHealthWidgetProjectState: no .gsd returns none", () => {
-  const dir = makeTempDir("none");
-  try {
-    assert.equal(detectHealthWidgetProjectState(dir), "none");
-  } finally {
-    cleanup(dir);
-  }
-});
-
-test("detectHealthWidgetProjectState: bootstrapped .gsd without milestones returns initialized", () => {
-  const dir = makeTempDir("initialized");
-  try {
-    mkdirSync(join(dir, ".gsd"), { recursive: true });
-    assert.equal(detectHealthWidgetProjectState(dir), "initialized");
-  } finally {
-    cleanup(dir);
-  }
-});
-
-test("detectHealthWidgetProjectState: milestone without metrics returns active", () => {
-  const dir = makeTempDir("active");
-  try {
-    mkdirSync(join(dir, ".gsd", "milestones", "M001"), { recursive: true });
-    assert.equal(detectHealthWidgetProjectState(dir), "active");
-  } finally {
-    cleanup(dir);
-  }
-});
-
-test("buildHealthLines: none state shows onboarding copy", () => {
-  assert.deepEqual(buildHealthLines(activeData({ projectState: "none" })), [
-    "  GSD  No project loaded — run /gsd to start",
-  ]);
-});
-
-test("buildHealthLines: initialized state shows continue setup copy", () => {
-  assert.deepEqual(buildHealthLines(activeData({ projectState: "initialized" })), [
-    "  GSD  Project initialized — run /gsd to continue setup",
-  ]);
-});
-
-test("buildHealthLines: active state leads with execution summary", () => {
-  const lines = buildHealthLines(activeData({
-    executionStatus: "Executing",
-    executionTarget: "Plan S01",
-    progress: {
-      milestones: { done: 0, total: 1 },
-      slices: { done: 0, total: 3 },
-      tasks: { done: 0, total: 5 },
-    },
-  }));
-
-  assert.equal(lines.length, 2);
-  assert.equal(lines[0], "  GSD  Executing - Plan S01");
-  assert.match(lines[1]!, /Progress: M 0\/1 · S 0\/3 · T 0\/5/);
-});
-
-test("buildHealthLines: active state keeps issues secondary", () => {
-  const lines = buildHealthLines(activeData({
-    executionStatus: "Planning",
-    executionTarget: "Execute T03",
-    providerIssue: "✗ Anthropic (Claude) key missing",
-    environmentWarningCount: 1,
-    budgetSpent: 0.42,
-  }));
-
-  assert.equal(lines.length, 2);
-  assert.equal(lines[0], "  GSD  Planning - Execute T03");
-  assert.match(lines[1]!, /✗ Anthropic \(Claude\) key missing/);
-  assert.match(lines[1]!, /Env: 1 warning/);
-  assert.match(lines[1]!, /Spent: 42\.0¢/);
-});
-
-test("buildHealthLines: blocked state explains wait reason", () => {
-  const lines = buildHealthLines(activeData({
-    executionStatus: "Blocked",
-    executionTarget: "waiting on unmet deps: M001",
-    blocker: "M002 is waiting on unmet deps: M001",
-  }));
-
-  assert.equal(lines[0], "  GSD  Blocked - waiting on unmet deps: M001");
-});
-
-test("buildHealthLines: paused state can omit secondary line", () => {
-  const lines = buildHealthLines(activeData({
-    executionStatus: "Paused",
-    executionTarget: "waiting to resume",
-  }));
-
-  assert.deepEqual(lines, ["  GSD  Paused - waiting to resume"]);
-});
-
-test("buildHealthLines: active state with budget ceiling shows percent summary", () => {
-  const lines = buildHealthLines(activeData({
-    executionStatus: "Executing",
-    executionTarget: "Plan S01",
-    budgetSpent: 2.5,
-    budgetCeiling: 10,
-  }));
-  assert.equal(lines.length, 2);
-  assert.match(lines[1]!, /Budget: \$2\.50\/\$10\.00 \(25%\)/);
-});
-
-test("detectHealthWidgetProjectState: metrics file alone does not imply project", () => {
-  const dir = makeTempDir("metrics-only");
-  try {
-    mkdirSync(join(dir, ".gsd"), { recursive: true });
-    writeFileSync(
-      join(dir, ".gsd", "metrics.json"),
-      JSON.stringify({ version: 1, projectStartedAt: Date.now(), units: [] }),
-      "utf-8",
-    );
-    assert.equal(detectHealthWidgetProjectState(dir), "initialized");
-  } finally {
-    cleanup(dir);
-  }
-});