gsd-pi 2.35.0-dev.30eec3f → 2.35.0-dev.39eee32

package/dist/resources/extensions/gsd/milestone-ids.js

@@ -67,8 +67,9 @@ export function findMilestoneIds(basePath) {
             .filter((d) => d.isDirectory())
             .map((d) => {
             const match = d.name.match(/^(M\d+(?:-[a-z0-9]{6})?)/);
-            return match ? match[1] : d.name;
-        });
+            return match ? match[1] : null;
+        })
+            .filter((id) => id !== null);
         // Apply custom queue order if available, else fall back to numeric sort
         const customOrder = loadQueueOrder(basePath);
         return sortByQueueOrder(ids, customOrder);

package/dist/resources/extensions/gsd/state.js

@@ -33,11 +33,12 @@ export function isValidationTerminal(validationContent) {
     const verdict = match[1].match(/verdict:\s*(\S+)/);
     if (!verdict)
         return false;
+    const v = verdict[1] === 'passed' ? 'pass' : verdict[1];
     // 'pass' and 'needs-attention' are always terminal.
     // 'needs-remediation' is treated as terminal to prevent infinite loops
     // when no remediation slices exist in the roadmap (#832). The validation
     // report is preserved on disk for manual review.
-    return verdict[1] === 'pass' || verdict[1] === 'needs-attention' || verdict[1] === 'needs-remediation';
+    return v === 'pass' || v === 'needs-attention' || v === 'needs-remediation';
 }
 const CACHE_TTL_MS = 100;
 let _stateCache = null;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "gsd-pi",
-  "version": "2.35.0-dev.30eec3f",
+  "version": "2.35.0-dev.39eee32",
   "description": "GSD — Get Shit Done coding agent",
   "license": "MIT",
   "repository": {

package/src/resources/extensions/gsd/milestone-ids.ts

@@ -80,8 +80,9 @@ export function findMilestoneIds(basePath: string): string[] {
       .filter((d) => d.isDirectory())
       .map((d) => {
         const match = d.name.match(/^(M\d+(?:-[a-z0-9]{6})?)/);
-        return match ? match[1] : d.name;
-      });
+        return match ? match[1] : null;
+      })
+      .filter((id): id is string => id !== null);
 
     // Apply custom queue order if available, else fall back to numeric sort
     const customOrder = loadQueueOrder(basePath);

package/src/resources/extensions/gsd/state.ts

@@ -64,11 +64,12 @@ export function isValidationTerminal(validationContent: string): boolean {
   if (!match) return false;
   const verdict = match[1].match(/verdict:\s*(\S+)/);
   if (!verdict) return false;
+  const v = verdict[1] === 'passed' ? 'pass' : verdict[1];
   // 'pass' and 'needs-attention' are always terminal.
   // 'needs-remediation' is treated as terminal to prevent infinite loops
   // when no remediation slices exist in the roadmap (#832). The validation
   // report is preserved on disk for manual review.
-  return verdict[1] === 'pass' || verdict[1] === 'needs-attention' || verdict[1] === 'needs-remediation';
+  return v === 'pass' || v === 'needs-attention' || v === 'needs-remediation';
 }
 
 // ─── State Derivation ──────────────────────────────────────────────────────

package/src/resources/extensions/gsd/tests/queue-reorder-e2e.test.ts

@@ -244,6 +244,32 @@ console.log('\n=== E2E: backward compat without QUEUE-ORDER.json ===');
   }
 }
 
+// ═══════════════════════════════════════════════════════════════════════════
+// Test: non-milestone directories are filtered out (#1494)
+// ═══════════════════════════════════════════════════════════════════════════
+
+console.log('\n=== E2E: non-milestone directories filtered from findMilestoneIds (#1494) ===');
+{
+  const base = createFixtureBase();
+  try {
+    writeContext(base, 'M001', '', 'First');
+    writeContext(base, 'M002', '', 'Second');
+    // Create a rogue non-milestone directory
+    mkdirSync(join(base, '.gsd', 'milestones', 'slices'), { recursive: true });
+    mkdirSync(join(base, '.gsd', 'milestones', 'temp-backup'), { recursive: true });
+
+    invalidateStateCache();
+    const ids = findMilestoneIds(base);
+    assertEq(ids.length, 2, 'only M001 and M002 returned');
+    assertTrue(!ids.includes('slices'), 'slices directory excluded');
+    assertTrue(!ids.includes('temp-backup'), 'temp-backup directory excluded');
+    assertTrue(ids.includes('M001'), 'M001 included');
+    assertTrue(ids.includes('M002'), 'M002 included');
+  } finally {
+    cleanup(base);
+  }
+}
+
 // ═══════════════════════════════════════════════════════════════════════════
 // Test: depends_on inline array format removal
 // ═══════════════════════════════════════════════════════════════════════════

package/src/resources/extensions/gsd/tests/validate-milestone.test.ts

@@ -104,6 +104,11 @@ test("isValidationTerminal returns true for verdict: needs-remediation (#832)",
   assert.equal(isValidationTerminal(content), true);
 });
 
+test("isValidationTerminal returns true for verdict: passed (#1429)", () => {
+  const content = "---\nverdict: passed\nremediation_round: 0\n---\n\n# Validation";
+  assert.equal(isValidationTerminal(content), true);
+});
+
 test("isValidationTerminal returns false for missing frontmatter", () => {
   const content = "# Validation\nNo frontmatter here.";
   assert.equal(isValidationTerminal(content), false);