gsd-pi 2.33.1 → 2.34.0-dev.6769913

package/packages/pi-coding-agent/src/core/lsp/client.ts

@@ -618,76 +618,6 @@ export async function ensureFileOpen(client: LspClient, filePath: string, signal
 	}
 }
 
-/**
- * Sync in-memory content to the LSP client without reading from disk.
- */
-export async function syncContent(
-	client: LspClient,
-	filePath: string,
-	content: string,
-	signal?: AbortSignal,
-): Promise<void> {
-	const uri = fileToUri(filePath);
-	const lockKey = `${client.name}:${uri}`;
-	throwIfAborted(signal);
-
-	const existingLock = fileOperationLocks.get(lockKey);
-	if (existingLock) {
-		await untilAborted(signal, () => existingLock);
-	}
-
-	const syncPromise = (async () => {
-		client.diagnostics.delete(uri);
-
-		const info = client.openFiles.get(uri);
-
-		if (!info) {
-			const languageId = detectLanguageId(filePath);
-			throwIfAborted(signal);
-			await sendNotification(client, "textDocument/didOpen", {
-				textDocument: {
-					uri,
-					languageId,
-					version: 1,
-					text: content,
-				},
-			});
-			client.openFiles.set(uri, { version: 1, languageId });
-			client.lastActivity = Date.now();
-			return;
-		}
-
-		const version = ++info.version;
-		throwIfAborted(signal);
-		await sendNotification(client, "textDocument/didChange", {
-			textDocument: { uri, version },
-			contentChanges: [{ text: content }],
-		});
-		client.lastActivity = Date.now();
-	})();
-
-	fileOperationLocks.set(lockKey, syncPromise);
-	try {
-		await syncPromise;
-	} finally {
-		fileOperationLocks.delete(lockKey);
-	}
-}
-
-/**
- * Notify LSP that a file was saved.
- */
-export async function notifySaved(client: LspClient, filePath: string, signal?: AbortSignal): Promise<void> {
-	const uri = fileToUri(filePath);
-	const info = client.openFiles.get(uri);
-	if (!info) return;
-
-	throwIfAborted(signal);
-	await sendNotification(client, "textDocument/didSave", {
-		textDocument: { uri },
-	});
-	client.lastActivity = Date.now();
-}
 
 /**
  * Refresh a file in the LSP client.
@@ -761,7 +691,7 @@ export function notifyFileChanged(filePath: string): void {
 /**
  * Shutdown a specific client by key.
  */
-export function shutdownClient(key: string): void {
+function shutdownClient(key: string): void {
 	const client = clients.get(key);
 	if (!client) return;
 
@@ -865,7 +795,7 @@ export async function sendRequest(
 	return promise;
 }
 
-export async function sendNotification(client: LspClient, method: string, params: unknown): Promise<void> {
+async function sendNotification(client: LspClient, method: string, params: unknown): Promise<void> {
 	const notification: LspJsonRpcNotification = {
 		jsonrpc: "2.0",
 		method,
@@ -889,7 +819,7 @@ export async function sendNotification(client: LspClient, method: string, params
 /**
  * Shutdown all LSP clients.
  */
-export function shutdownAll(): void {
+function shutdownAll(): void {
 	const clientsToShutdown = Array.from(clients.values());
 	clients.clear();
 

package/packages/pi-coding-agent/src/core/lsp/config.ts

@@ -319,14 +319,3 @@ export function getServersForFile(config: LspConfig, filePath: string): Array<[s
 	});
 }
 
-export function getServerForFile(config: LspConfig, filePath: string): [string, ServerConfig] | null {
-	const servers = getServersForFile(config, filePath);
-	return servers.length > 0 ? servers[0] : null;
-}
-
-export function hasCapability(
-	config: ServerConfig,
-	capability: keyof NonNullable<ServerConfig["capabilities"]>,
-): boolean {
-	return config.capabilities?.[capability] === true;
-}

package/packages/pi-coding-agent/src/core/lsp/edits.ts

@@ -11,7 +11,7 @@ import { uriToFile } from "./utils.js";
  * Apply text edits to a string in-memory.
  * Edits are applied in reverse order (bottom-to-top) to preserve line/character indices.
  */
-export function applyTextEditsToString(content: string, edits: TextEdit[]): string {
+function applyTextEditsToString(content: string, edits: TextEdit[]): string {
 	const lines = content.split("\n");
 
 	// Sort edits in reverse order (bottom-to-top, right-to-left)

package/packages/pi-coding-agent/src/core/lsp/lspmux.ts

@@ -172,7 +172,7 @@ export interface LspmuxWrappedCommand {
 	env?: Record<string, string>;
 }
 
-export function wrapWithLspmux(
+function wrapWithLspmux(
 	originalCommand: string,
 	originalArgs: string[] | undefined,
 	state: LspmuxState,

package/packages/pi-coding-agent/src/core/lsp/utils.ts

@@ -192,7 +192,7 @@ const SEVERITY_NAMES: Record<DiagnosticSeverity, string> = {
 	4: "hint",
 };
 
-export function severityToString(severity?: DiagnosticSeverity): string {
+function severityToString(severity?: DiagnosticSeverity): string {
 	return SEVERITY_NAMES[severity ?? 1] ?? "unknown";
 }
 
@@ -211,21 +211,6 @@ export function sortDiagnostics(diagnostics: Diagnostic[]): Diagnostic[] {
 	});
 }
 
-export function severityToIcon(severity?: DiagnosticSeverity): string {
-	switch (severity ?? 1) {
-		case 1:
-			return "[E]";
-		case 2:
-			return "[W]";
-		case 3:
-			return "[I]";
-		case 4:
-			return "[H]";
-		default:
-			return "[E]";
-	}
-}
-
 function stripDiagnosticNoise(message: string): string {
 	return message
 		.split("\n")
@@ -353,10 +338,6 @@ export function formatLocation(location: Location, cwd: string): string {
 	return `${file}:${line}:${col}`;
 }
 
-export function formatPosition(line: number, col: number): string {
-	return `${line}:${col}`;
-}
-
 // =============================================================================
 // WorkspaceEdit Formatting
 // =============================================================================
@@ -397,15 +378,6 @@ export function formatWorkspaceEdit(edit: WorkspaceEdit, cwd: string): string[]
 	return results;
 }
 
-export function formatTextEdit(edit: TextEdit, maxLength = 50): string {
-	const range = `${edit.range.start.line + 1}:${edit.range.start.character + 1}`;
-	const preview =
-		edit.newText.length > maxLength
-			? `${edit.newText.slice(0, maxLength).replace(/\n/g, "\\n")}…`
-			: edit.newText.replace(/\n/g, "\\n");
-	return `line ${range} -> "${preview}"`;
-}
-
 // =============================================================================
 // Symbol Formatting
 // =============================================================================
@@ -443,10 +415,6 @@ export function symbolKindToIcon(kind: SymbolKind): string {
 	return `[${SYMBOL_KIND_LABELS[kind] ?? "?"}]`;
 }
 
-export function symbolKindToName(kind: SymbolKind): string {
-	return SYMBOL_KIND_LABELS[kind] ?? "Unknown";
-}
-
 export function formatDocumentSymbol(symbol: DocumentSymbol, indent = 0): string[] {
 	const prefix = "  ".repeat(indent);
 	const icon = symbolKindToIcon(symbol.kind);

package/packages/pi-coding-agent/src/core/messages.ts

@@ -8,20 +8,20 @@
 import type { AgentMessage } from "@gsd/pi-agent-core";
 import type { ImageContent, Message, TextContent } from "@gsd/pi-ai";
 
-export const COMPACTION_SUMMARY_PREFIX = `The conversation history before this point was compacted into the following summary:
+const COMPACTION_SUMMARY_PREFIX = `The conversation history before this point was compacted into the following summary:
 
 <summary>
 `;
 
-export const COMPACTION_SUMMARY_SUFFIX = `
+const COMPACTION_SUMMARY_SUFFIX = `
 </summary>`;
 
-export const BRANCH_SUMMARY_PREFIX = `The following is a summary of a branch that this conversation came back from:
+const BRANCH_SUMMARY_PREFIX = `The following is a summary of a branch that this conversation came back from:
 
 <summary>
 `;
 
-export const BRANCH_SUMMARY_SUFFIX = `</summary>`;
+const BRANCH_SUMMARY_SUFFIX = `</summary>`;
 
 /**
  * Message type for bash executions via the ! command.
@@ -79,7 +79,7 @@ declare module "@gsd/pi-agent-core" {
 /**
  * Convert a BashExecutionMessage to user message text for LLM context.
  */
-export function bashExecutionToText(msg: BashExecutionMessage): string {
+function bashExecutionToText(msg: BashExecutionMessage): string {
 	let text = `Ran \`${msg.command}\`\n`;
 	if (msg.output) {
 		text += `\`\`\`\n${msg.output}\n\`\`\``;

package/packages/pi-coding-agent/src/core/model-registry.ts

@@ -216,8 +216,6 @@ function applyModelOverride(model: Model<Api>, override: ModelOverride): Model<A
 	return result;
 }
 
-/** Clear the config value command cache. Exported for testing. */
-export const clearApiKeyCache = clearConfigValueCache;
 
 /**
  * Model registry - loads and manages models, resolves API keys via AuthStorage.

package/packages/pi-coding-agent/src/core/model-resolver.ts

@@ -11,7 +11,7 @@ import { DEFAULT_THINKING_LEVEL } from "./defaults.js";
 import type { ModelRegistry } from "./model-registry.js";
 
 /** Default model IDs for each known provider */
-export const defaultModelPerProvider: Record<KnownProvider, string> = {
+const defaultModelPerProvider: Record<KnownProvider, string> = {
 	"amazon-bedrock": "us.anthropic.claude-opus-4-6-v1",
 	anthropic: "claude-opus-4-6[1m]",
 	openai: "gpt-5.4",
@@ -143,9 +143,9 @@ function buildFallbackModel(provider: string, modelId: string, availableModels:
  *    - If suffix is valid thinking level, use it and recurse on prefix
  *    - If suffix is invalid, warn and recurse on prefix with "off"
  *
- * @internal Exported for testing
+ * @internal
  */
-export function parseModelPattern(
+function parseModelPattern(
 	pattern: string,
 	availableModels: Model<Api>[],
 	options?: { allowInvalidThinkingLevelFallback?: boolean },
@@ -546,77 +546,3 @@ export async function findInitialModel(options: {
 	// 5. No model found
 	return { model: undefined, thinkingLevel: DEFAULT_THINKING_LEVEL, fallbackMessage: undefined };
 }
-
-/**
- * Restore model from session, with fallback to available models
- */
-export async function restoreModelFromSession(
-	savedProvider: string,
-	savedModelId: string,
-	currentModel: Model<Api> | undefined,
-	shouldPrintMessages: boolean,
-	modelRegistry: ModelRegistry,
-): Promise<{ model: Model<Api> | undefined; fallbackMessage: string | undefined }> {
-	const restoredModel = modelRegistry.find(savedProvider, savedModelId);
-
-	// Check if restored model exists and has a valid API key
-	const hasApiKey = restoredModel ? !!(await modelRegistry.getApiKey(restoredModel)) : false;
-
-	if (restoredModel && hasApiKey) {
-		if (shouldPrintMessages) {
-			console.log(chalk.dim(`Restored model: ${savedProvider}/${savedModelId}`));
-		}
-		return { model: restoredModel, fallbackMessage: undefined };
-	}
-
-	// Model not found or no API key - fall back
-	const reason = !restoredModel ? "model no longer exists" : "no API key available";
-
-	if (shouldPrintMessages) {
-		console.error(chalk.yellow(`Warning: Could not restore model ${savedProvider}/${savedModelId} (${reason}).`));
-	}
-
-	// If we already have a model, use it as fallback
-	if (currentModel) {
-		if (shouldPrintMessages) {
-			console.log(chalk.dim(`Falling back to: ${currentModel.provider}/${currentModel.id}`));
-		}
-		return {
-			model: currentModel,
-			fallbackMessage: `Could not restore model ${savedProvider}/${savedModelId} (${reason}). Using ${currentModel.provider}/${currentModel.id}.`,
-		};
-	}
-
-	// Try to find any available model
-	const availableModels = await modelRegistry.getAvailable();
-
-	if (availableModels.length > 0) {
-		// Try to find a default model from known providers
-		let fallbackModel: Model<Api> | undefined;
-		for (const provider of Object.keys(defaultModelPerProvider) as KnownProvider[]) {
-			const defaultId = defaultModelPerProvider[provider];
-			const match = availableModels.find((m) => m.provider === provider && m.id === defaultId);
-			if (match) {
-				fallbackModel = match;
-				break;
-			}
-		}
-
-		// If no default found, use first available
-		if (!fallbackModel) {
-			fallbackModel = availableModels[0];
-		}
-
-		if (shouldPrintMessages) {
-			console.log(chalk.dim(`Falling back to: ${fallbackModel.provider}/${fallbackModel.id}`));
-		}
-
-		return {
-			model: fallbackModel,
-			fallbackMessage: `Could not restore model ${savedProvider}/${savedModelId} (${reason}). Using ${fallbackModel.provider}/${fallbackModel.id}.`,
-		};
-	}
-
-	// No models available
-	return { model: undefined, fallbackMessage: undefined };
-}

package/packages/pi-coding-agent/src/core/prompt-templates.ts

@@ -19,7 +19,7 @@ export interface PromptTemplate {
  * Parse command arguments respecting quoted strings (bash-style)
  * Returns array of arguments
  */
-export function parseCommandArgs(argsString: string): string[] {
+function parseCommandArgs(argsString: string): string[] {
 	const args: string[] = [];
 	let current = "";
 	let inQuote: string | null = null;
@@ -63,7 +63,7 @@ export function parseCommandArgs(argsString: string): string[] {
  * Note: Replacement happens on the template string only. Argument values
  * containing patterns like $1, $@, or $ARGUMENTS are NOT recursively substituted.
  */
-export function substituteArgs(content: string, args: string[]): string {
+function substituteArgs(content: string, args: string[]): string {
 	let result = content;
 
 	// Replace $1, $2, etc. with positional args FIRST (before wildcards)

package/packages/pi-coding-agent/src/core/session-manager.ts

@@ -577,8 +577,7 @@ function resolveBlobRefsInEntries(entries: FileEntry[], blobStore: BlobStore): v
 	}
 }
 
-/** Exported for testing */
-export function loadEntriesFromFile(filePath: string): FileEntry[] {
+function loadEntriesFromFile(filePath: string): FileEntry[] {
 	if (!existsSync(filePath)) return [];
 
 	const content = readFileSync(filePath, "utf8");
@@ -620,8 +619,7 @@ function isValidSessionFile(filePath: string): boolean {
 	}
 }
 
-/** Exported for testing */
-export function findMostRecentSession(sessionDir: string): string | null {
+function findMostRecentSession(sessionDir: string): string | null {
 	try {
 		const files = readdirSync(sessionDir)
 			.filter((f) => f.endsWith(".jsonl"))