gsd-pi 2.33.1 → 2.34.0-dev.0150ae9

package/dist/resources/extensions/gsd/tests/doctor-proactive.test.ts

@@ -1,278 +0,0 @@
-/**
- * doctor-proactive.test.ts — Tests for proactive healing layer.
- *
- * Tests:
- *   - Pre-dispatch health gate (stale lock, merge state)
- *   - Health score tracking (snapshots, trends)
- *   - Auto-heal escalation (consecutive errors, threshold)
- */
-
-import { mkdtempSync, mkdirSync, writeFileSync, rmSync, existsSync, realpathSync } from "node:fs";
-import { join } from "node:path";
-import { tmpdir } from "node:os";
-import { execSync } from "node:child_process";
-
-import {
-  preDispatchHealthGate,
-  recordHealthSnapshot,
-  getHealthTrend,
-  getConsecutiveErrorUnits,
-  getHealthHistory,
-  checkHealEscalation,
-  resetProactiveHealing,
-  formatHealthSummary,
-} from "../doctor-proactive.ts";
-import { createTestContext } from "./test-helpers.ts";
-
-const { assertEq, assertTrue, report } = createTestContext();
-
-function run(cmd: string, cwd: string): string {
-  return execSync(cmd, { cwd, stdio: ["ignore", "pipe", "pipe"], encoding: "utf-8" }).trim();
-}
-
-function createGitRepo(): string {
-  const dir = realpathSync(mkdtempSync(join(tmpdir(), "doc-proactive-")));
-  run("git init", dir);
-  run("git config user.email test@test.com", dir);
-  run("git config user.name Test", dir);
-  writeFileSync(join(dir, "README.md"), "# test\n");
-  run("git add .", dir);
-  run("git commit -m init", dir);
-  run("git branch -M main", dir);
-  mkdirSync(join(dir, ".gsd"), { recursive: true });
-  return dir;
-}
-
-async function main(): Promise<void> {
-  const cleanups: string[] = [];
-
-  try {
-    // ─── Health Score Tracking ─────────────────────────────────────────
-    console.log("\n=== health tracking: initial state ===");
-    {
-      resetProactiveHealing();
-      assertEq(getHealthTrend(), "unknown", "trend is unknown with no data");
-      assertEq(getConsecutiveErrorUnits(), 0, "no consecutive errors initially");
-      assertEq(getHealthHistory().length, 0, "no history initially");
-    }
-
-    console.log("\n=== health tracking: recording snapshots ===");
-    {
-      resetProactiveHealing();
-      recordHealthSnapshot(0, 2, 1);
-      recordHealthSnapshot(0, 1, 0);
-      recordHealthSnapshot(0, 0, 0);
-
-      assertEq(getHealthHistory().length, 3, "3 snapshots recorded");
-      assertEq(getConsecutiveErrorUnits(), 0, "no consecutive errors after clean units");
-    }
-
-    console.log("\n=== health tracking: consecutive error counting ===");
-    {
-      resetProactiveHealing();
-      recordHealthSnapshot(2, 1, 0); // errors
-      recordHealthSnapshot(1, 0, 0); // errors
-      recordHealthSnapshot(1, 0, 0); // errors
-      assertEq(getConsecutiveErrorUnits(), 3, "3 consecutive error units");
-
-      recordHealthSnapshot(0, 0, 0); // clean
-      assertEq(getConsecutiveErrorUnits(), 0, "streak reset on clean unit");
-    }
-
-    console.log("\n=== health tracking: trend detection ===");
-    {
-      resetProactiveHealing();
-      // Record 5 older snapshots with low issues
-      for (let i = 0; i < 5; i++) {
-        recordHealthSnapshot(0, 1, 0);
-      }
-      // Record 5 recent snapshots with high issues
-      for (let i = 0; i < 5; i++) {
-        recordHealthSnapshot(3, 5, 0);
-      }
-      assertEq(getHealthTrend(), "degrading", "detects degrading trend");
-    }
-
-    console.log("\n=== health tracking: improving trend ===");
-    {
-      resetProactiveHealing();
-      // Record 5 older snapshots with high issues
-      for (let i = 0; i < 5; i++) {
-        recordHealthSnapshot(3, 5, 0);
-      }
-      // Record 5 recent snapshots with low issues
-      for (let i = 0; i < 5; i++) {
-        recordHealthSnapshot(0, 0, 0);
-      }
-      assertEq(getHealthTrend(), "improving", "detects improving trend");
-    }
-
-    console.log("\n=== health tracking: stable trend ===");
-    {
-      resetProactiveHealing();
-      for (let i = 0; i < 10; i++) {
-        recordHealthSnapshot(1, 1, 0);
-      }
-      assertEq(getHealthTrend(), "stable", "detects stable trend");
-    }
-
-    // ─── Auto-Heal Escalation ─────────────────────────────────────────
-    console.log("\n=== escalation: below threshold ===");
-    {
-      resetProactiveHealing();
-      recordHealthSnapshot(1, 0, 0);
-      recordHealthSnapshot(1, 0, 0);
-      recordHealthSnapshot(1, 0, 0);
-      const result = checkHealEscalation(1, [{ code: "test", message: "test error", unitId: "M001/S01" }]);
-      assertEq(result.shouldEscalate, false, "no escalation below threshold");
-      assertTrue(result.reason.includes("3/5"), "reason shows progress toward threshold");
-    }
-
-    console.log("\n=== escalation: at threshold ===");
-    {
-      resetProactiveHealing();
-      // Need 5+ consecutive error units AND degrading/stable trend
-      for (let i = 0; i < 5; i++) {
-        recordHealthSnapshot(0, 0, 0); // older clean snapshots
-      }
-      for (let i = 0; i < 5; i++) {
-        recordHealthSnapshot(2, 1, 0); // recent error snapshots
-      }
-      const result = checkHealEscalation(2, [{ code: "test", message: "test error", unitId: "M001/S01" }]);
-      assertEq(result.shouldEscalate, true, "escalates at threshold with degrading trend");
-      assertTrue(result.reason.includes("5 consecutive"), "reason mentions consecutive count");
-    }
-
-    console.log("\n=== escalation: no double escalation ===");
-    {
-      // Don't reset — should already be escalated from previous test
-      recordHealthSnapshot(2, 0, 0);
-      const result = checkHealEscalation(2, [{ code: "test", message: "test error", unitId: "M001/S01" }]);
-      assertEq(result.shouldEscalate, false, "no double escalation in same session");
-      assertTrue(result.reason.includes("already escalated"), "reason explains why no escalation");
-    }
-
-    console.log("\n=== escalation: deferred when improving ===");
-    {
-      resetProactiveHealing();
-      // 5 older snapshots with high errors
-      for (let i = 0; i < 5; i++) {
-        recordHealthSnapshot(5, 5, 0);
-      }
-      // 5 recent snapshots with fewer errors (still > 0)
-      for (let i = 0; i < 5; i++) {
-        recordHealthSnapshot(1, 0, 0);
-      }
-      const result = checkHealEscalation(1, [{ code: "test", message: "test error", unitId: "M001/S01" }]);
-      assertEq(result.shouldEscalate, false, "no escalation when trend is improving");
-      assertTrue(result.reason.includes("improving"), "reason mentions improving trend");
-    }
-
-    // ─── Health Summary Formatting ────────────────────────────────────
-    console.log("\n=== formatHealthSummary ===");
-    {
-      resetProactiveHealing();
-      assertEq(formatHealthSummary(), "No health data yet.", "empty summary when no data");
-
-      recordHealthSnapshot(2, 3, 1);
-      const summary = formatHealthSummary();
-      assertTrue(summary.includes("2E/3W"), "summary includes error/warning counts");
-      assertTrue(summary.includes("fixes:1"), "summary includes fix count");
-      assertTrue(summary.includes("streak:1/5"), "summary includes error streak");
-    }
-
-    // ─── Pre-Dispatch Health Gate ─────────────────────────────────────
-    console.log("\n=== health gate: clean state ===");
-    {
-      const dir = realpathSync(mkdtempSync(join(tmpdir(), "doc-proactive-")));
-      cleanups.push(dir);
-      mkdirSync(join(dir, ".gsd"), { recursive: true });
-
-      const result = await preDispatchHealthGate(dir);
-      assertTrue(result.proceed, "gate passes on clean state");
-      assertEq(result.issues.length, 0, "no issues on clean state");
-    }
-
-    console.log("\n=== health gate: missing STATE.md does NOT block dispatch (#889) ===");
-    {
-      const dir = realpathSync(mkdtempSync(join(tmpdir(), "doc-proactive-")));
-      cleanups.push(dir);
-      // Create milestones dir but no STATE.md — mimics fresh worktree
-      mkdirSync(join(dir, ".gsd", "milestones", "M001"), { recursive: true });
-      writeFileSync(join(dir, ".gsd", "milestones", "M001", "M001-ROADMAP.md"), "# Roadmap\n");
-
-      const result = await preDispatchHealthGate(dir);
-      assertTrue(result.proceed, "gate must NOT block when STATE.md is missing (deadlock #889)");
-      assertEq(result.issues.length, 0, "missing STATE.md is not a blocking issue");
-      assertTrue(result.fixesApplied.some((f: string) => f.includes("STATE.md")), "reports STATE.md status as info");
-    }
-
-    console.log("\n=== health gate: stale crash lock auto-cleared ===");
-    {
-      const dir = realpathSync(mkdtempSync(join(tmpdir(), "doc-proactive-")));
-      cleanups.push(dir);
-      mkdirSync(join(dir, ".gsd"), { recursive: true });
-
-      // Write a stale lock
-      writeFileSync(join(dir, ".gsd", "auto.lock"), JSON.stringify({
-        pid: 9999999, startedAt: "2026-03-10T00:00:00Z",
-        unitType: "execute-task", unitId: "M001/S01/T01",
-        unitStartedAt: "2026-03-10T00:01:00Z", completedUnits: 3,
-      }));
-
-      const result = await preDispatchHealthGate(dir);
-      assertTrue(result.proceed, "gate passes after auto-clearing stale lock");
-      assertTrue(result.fixesApplied.some(f => f.includes("cleared stale auto.lock")), "reports lock cleared");
-      assertTrue(!existsSync(join(dir, ".gsd", "auto.lock")), "lock file removed");
-    }
-
-    console.log("\n=== health gate: corrupt merge state auto-healed ===");
-    if (process.platform !== "win32") {
-    {
-      const dir = createGitRepo();
-      cleanups.push(dir);
-
-      // Inject MERGE_HEAD
-      const headHash = run("git rev-parse HEAD", dir);
-      writeFileSync(join(dir, ".git", "MERGE_HEAD"), headHash + "\n");
-
-      const result = await preDispatchHealthGate(dir);
-      assertTrue(result.proceed, "gate passes after auto-healing merge state");
-      assertTrue(result.fixesApplied.some(f => f.includes("cleaned merge state")), "reports merge state cleaned");
-      assertTrue(!existsSync(join(dir, ".git", "MERGE_HEAD")), "MERGE_HEAD removed");
-    }
-    } else {
-      console.log("  (skipped on Windows)");
-    }
-
-    console.log("\n=== health gate: STATE.md missing — auto-healed ===");
-    {
-      const dir = realpathSync(mkdtempSync(join(tmpdir(), "doc-proactive-")));
-      cleanups.push(dir);
-      // Minimal .gsd structure: milestones dir exists but no STATE.md
-      mkdirSync(join(dir, ".gsd", "milestones"), { recursive: true });
-
-      const stateFile = join(dir, ".gsd", "STATE.md");
-      assertTrue(!existsSync(stateFile), "STATE.md does not exist before gate");
-
-      const result = await preDispatchHealthGate(dir);
-      assertTrue(result.proceed, "gate passes after rebuilding STATE.md");
-      assertTrue(
-        result.fixesApplied.some(f => f.includes("rebuilt missing STATE.md")),
-        "reports STATE.md rebuilt",
-      );
-      assertTrue(existsSync(stateFile), "STATE.md created by auto-heal");
-      assertTrue(result.issues.length === 0, "no blocking issues after heal");
-    }
-
-  } finally {
-    resetProactiveHealing();
-    for (const dir of cleanups) {
-      try { rmSync(dir, { recursive: true, force: true }); } catch { /* ignore */ }
-    }
-  }
-
-  report();
-}
-
-main();

package/dist/resources/extensions/gsd/tests/doctor-providers.test.ts

@@ -1,298 +0,0 @@
-/**
- * doctor-providers.test.ts — Tests for provider & integration health checks.
- *
- * Tests:
- *   - LLM provider key detection from env vars
- *   - LLM provider key detection from auth.json
- *   - Missing required provider → error status
- *   - Backed-off credentials → warning status
- *   - Remote questions channel check (configured vs missing token)
- *   - Optional provider unconfigured status
- *   - formatProviderReport output
- *   - summariseProviderIssues compaction
- */
-
-import test from "node:test";
-import assert from "node:assert/strict";
-import { mkdtempSync, mkdirSync, writeFileSync, rmSync, realpathSync } from "node:fs";
-import { join } from "node:path";
-import { tmpdir } from "node:os";
-
-import {
-  runProviderChecks,
-  formatProviderReport,
-  summariseProviderIssues,
-  type ProviderCheckResult,
-} from "../doctor-providers.ts";
-
-// ─── Helpers ──────────────────────────────────────────────────────────────────
-
-function withEnv(vars: Record<string, string | undefined>, fn: () => void): void {
-  const saved: Record<string, string | undefined> = {};
-  for (const [k, v] of Object.entries(vars)) {
-    saved[k] = process.env[k];
-    if (v === undefined) {
-      delete process.env[k];
-    } else {
-      process.env[k] = v;
-    }
-  }
-  try {
-    fn();
-  } finally {
-    for (const [k, v] of Object.entries(saved)) {
-      if (v === undefined) delete process.env[k];
-      else process.env[k] = v;
-    }
-  }
-}
-
-// ─── formatProviderReport ─────────────────────────────────────────────────────
-
-test("formatProviderReport returns fallback for empty results", () => {
-  const out = formatProviderReport([]);
-  assert.equal(out, "No provider checks run.");
-});
-
-test("formatProviderReport shows ok icon for ok status", () => {
-  const results: ProviderCheckResult[] = [{
-    name: "anthropic",
-    label: "Anthropic (Claude)",
-    category: "llm",
-    status: "ok",
-    message: "Anthropic (Claude) — key present (env)",
-    required: true,
-  }];
-  const out = formatProviderReport(results);
-  assert.ok(out.includes("✓"), "should include checkmark for ok");
-  assert.ok(out.includes("Anthropic"), "should include provider name");
-});
-
-test("formatProviderReport shows error icon and detail for error status", () => {
-  const results: ProviderCheckResult[] = [{
-    name: "anthropic",
-    label: "Anthropic (Claude)",
-    category: "llm",
-    status: "error",
-    message: "Anthropic (Claude) — no API key found",
-    detail: "Set ANTHROPIC_API_KEY or run /gsd keys",
-    required: true,
-  }];
-  const out = formatProviderReport(results);
-  assert.ok(out.includes("✗"), "should include cross for error");
-  assert.ok(out.includes("ANTHROPIC_API_KEY"), "should include detail");
-});
-
-test("formatProviderReport shows warning icon for warning status", () => {
-  const results: ProviderCheckResult[] = [{
-    name: "slack_bot",
-    label: "Slack Bot",
-    category: "remote",
-    status: "warning",
-    message: "Slack Bot — channel configured but token not found",
-    required: true,
-  }];
-  const out = formatProviderReport(results);
-  assert.ok(out.includes("⚠"), "should include warning icon");
-});
-
-test("formatProviderReport groups by category", () => {
-  const results: ProviderCheckResult[] = [
-    { name: "anthropic", label: "Anthropic", category: "llm", status: "ok", message: "ok", required: true },
-    { name: "brave", label: "Brave Search", category: "search", status: "unconfigured", message: "not configured", required: false },
-  ];
-  const out = formatProviderReport(results);
-  assert.ok(out.includes("LLM Providers"), "should have LLM section");
-  assert.ok(out.includes("Search"), "should have Search section");
-});
-
-test("formatProviderReport omits detail for ok status", () => {
-  const results: ProviderCheckResult[] = [{
-    name: "openai",
-    label: "OpenAI",
-    category: "llm",
-    status: "ok",
-    message: "OpenAI — key present (env)",
-    detail: "should not appear",
-    required: true,
-  }];
-  const out = formatProviderReport(results);
-  assert.ok(!out.includes("should not appear"), "detail should not show for ok");
-});
-
-// ─── summariseProviderIssues ──────────────────────────────────────────────────
-
-test("summariseProviderIssues returns null when no required issues", () => {
-  const results: ProviderCheckResult[] = [
-    { name: "anthropic", label: "Anthropic", category: "llm", status: "ok", message: "ok", required: true },
-    { name: "brave", label: "Brave", category: "search", status: "unconfigured", message: "not configured", required: false },
-  ];
-  assert.equal(summariseProviderIssues(results), null);
-});
-
-test("summariseProviderIssues returns error summary for missing required key", () => {
-  const results: ProviderCheckResult[] = [{
-    name: "anthropic",
-    label: "Anthropic (Claude)",
-    category: "llm",
-    status: "error",
-    message: "no key",
-    required: true,
-  }];
-  const summary = summariseProviderIssues(results);
-  assert.ok(summary !== null, "should return a summary");
-  assert.ok(summary!.includes("Anthropic"), "should name the provider");
-  assert.ok(summary!.includes("✗"), "should use error icon");
-});
-
-test("summariseProviderIssues returns warning for backed-off required provider", () => {
-  const results: ProviderCheckResult[] = [{
-    name: "anthropic",
-    label: "Anthropic (Claude)",
-    category: "llm",
-    status: "warning",
-    message: "backed off",
-    required: true,
-  }];
-  const summary = summariseProviderIssues(results);
-  assert.ok(summary !== null, "should return summary");
-  assert.ok(summary!.includes("⚠"), "should use warning icon");
-});
-
-test("summariseProviderIssues appends count when multiple issues", () => {
-  const results: ProviderCheckResult[] = [
-    { name: "anthropic", label: "Anthropic", category: "llm", status: "error", message: "err", required: true },
-    { name: "openai",    label: "OpenAI",    category: "llm", status: "error", message: "err", required: true },
-    { name: "google",    label: "Google",    category: "llm", status: "error", message: "err", required: true },
-  ];
-  const summary = summariseProviderIssues(results);
-  assert.ok(summary!.includes("+2 more"), "should show overflow count");
-});
-
-test("summariseProviderIssues ignores unconfigured optional providers", () => {
-  const results: ProviderCheckResult[] = [
-    { name: "anthropic", label: "Anthropic", category: "llm",    status: "ok",           message: "ok", required: true },
-    { name: "brave",     label: "Brave",     category: "search", status: "unconfigured", message: "nc", required: false },
-    { name: "tavily",    label: "Tavily",    category: "search", status: "unconfigured", message: "nc", required: false },
-  ];
-  assert.equal(summariseProviderIssues(results), null, "optional missing providers should not raise issue");
-});
-
-// ─── runProviderChecks — env var detection ────────────────────────────────────
-
-test("runProviderChecks detects Anthropic key from ANTHROPIC_API_KEY env var", () => {
-  // Isolate from real HOME so loadEffectiveGSDPreferences returns null (default → anthropic)
-  // and auth.json lookups hit an empty directory.
-  const tmpHome = realpathSync(mkdtempSync(join(tmpdir(), "gsd-providers-env-test-")));
-  withEnv({ ANTHROPIC_API_KEY: "sk-ant-test-key", HOME: tmpHome }, () => {
-    try {
-      const results = runProviderChecks();
-      const anthropic = results.find(r => r.name === "anthropic");
-      assert.ok(anthropic, "anthropic result should exist");
-      assert.equal(anthropic!.status, "ok", "should be ok when env var set");
-      assert.ok(anthropic!.message.includes("env"), "should report env source");
-    } finally {
-      rmSync(tmpHome, { recursive: true, force: true });
-    }
-  });
-});
-
-test("runProviderChecks returns error for Anthropic when no key present", () => {
-  const tmpHome = realpathSync(mkdtempSync(join(tmpdir(), "gsd-providers-test-")));
-  withEnv({ ANTHROPIC_API_KEY: undefined, HOME: tmpHome }, () => {
-    try {
-      const results = runProviderChecks();
-      const anthropic = results.find(r => r.name === "anthropic");
-      assert.ok(anthropic, "anthropic should be present (default required)");
-      assert.equal(anthropic!.status, "error", "should be error when no key");
-    } finally {
-      rmSync(tmpHome, { recursive: true, force: true });
-    }
-  });
-});
-
-test("runProviderChecks optional providers have required=false", () => {
-  const results = runProviderChecks();
-  const optional = results.filter(r => ["brave", "tavily", "jina", "context7"].includes(r.name));
-  for (const r of optional) {
-    assert.equal(r.required, false, `${r.name} should not be required`);
-  }
-});
-
-test("runProviderChecks optional providers show unconfigured when no key", () => {
-  withEnv(
-    { BRAVE_API_KEY: undefined, TAVILY_API_KEY: undefined, JINA_API_KEY: undefined, CONTEXT7_API_KEY: undefined },
-    () => {
-      const origHome = process.env.HOME;
-      process.env.HOME = mkdtempSync(join(tmpdir(), "gsd-providers-test-"));
-      try {
-        const results = runProviderChecks();
-        const brave = results.find(r => r.name === "brave");
-        assert.ok(brave, "brave should be present");
-        assert.equal(brave!.status, "unconfigured", "should be unconfigured");
-      } finally {
-        rmSync(process.env.HOME!, { recursive: true, force: true });
-        process.env.HOME = origHome;
-      }
-    }
-  );
-});
-
-test("runProviderChecks optional providers show ok when key set", () => {
-  withEnv({ BRAVE_API_KEY: "test-brave-key" }, () => {
-    const results = runProviderChecks();
-    const brave = results.find(r => r.name === "brave");
-    assert.ok(brave, "brave should be present");
-    assert.equal(brave!.status, "ok", "should be ok when env var set");
-  });
-});
-
-// ─── runProviderChecks — auth.json detection ─────────────────────────────────
-
-test("runProviderChecks detects key from auth.json", () => {
-  withEnv({ ANTHROPIC_API_KEY: undefined }, () => {
-    const tmpHome = realpathSync(mkdtempSync(join(tmpdir(), "gsd-providers-test-")));
-    const agentDir = join(tmpHome, ".gsd", "agent");
-    mkdirSync(agentDir, { recursive: true });
-
-    // AuthStorage persists credentials with provider ID as the top-level key:
-    // { "anthropic": { "type": "api_key", "key": "..." } }
-    const authData = {
-      anthropic: { type: "api_key", key: "sk-ant-from-auth-json" },
-    };
-    writeFileSync(join(agentDir, "auth.json"), JSON.stringify(authData));
-
-    withEnv({ HOME: tmpHome }, () => {
-      const results = runProviderChecks();
-      const anthropic = results.find(r => r.name === "anthropic");
-      assert.ok(anthropic, "anthropic should be present");
-      assert.equal(anthropic!.status, "ok", "should be ok with auth.json key");
-      assert.ok(anthropic!.message.includes("auth.json"), "should report auth.json source");
-    });
-
-    rmSync(tmpHome, { recursive: true, force: true });
-  });
-});
-
-test("runProviderChecks ignores empty placeholder keys in auth.json", () => {
-  withEnv({ ANTHROPIC_API_KEY: undefined }, () => {
-    const tmpHome = realpathSync(mkdtempSync(join(tmpdir(), "gsd-providers-test-")));
-    const agentDir = join(tmpHome, ".gsd", "agent");
-    mkdirSync(agentDir, { recursive: true });
-
-    // Empty key — what onboarding writes when user skips
-    const authData = {
-      anthropic: { type: "api_key", key: "" },
-    };
-    writeFileSync(join(agentDir, "auth.json"), JSON.stringify(authData));
-
-    withEnv({ HOME: tmpHome }, () => {
-      const results = runProviderChecks();
-      const anthropic = results.find(r => r.name === "anthropic");
-      assert.ok(anthropic, "anthropic should be present");
-      assert.equal(anthropic!.status, "error", "empty placeholder key should count as not configured");
-    });
-
-    rmSync(tmpHome, { recursive: true, force: true });
-  });
-});