gsd-pi 2.33.1-dev.ee47f1b → 2.34.0-dev.bbb5216

package/src/resources/extensions/gsd/tests/auto-reentrancy-guard.test.ts

@@ -1,127 +0,0 @@
-/**
- * auto-reentrancy-guard.test.ts — Tests for the unconditional reentrancy guard.
- *
- * Regression for #1272: auto-mode stuck-loop where gap watchdog or
- * pendingAgentEndRetry could enter dispatchNextUnit concurrently during
- * recursive skip chains because the reentrancy guard was bypassed when
- * skipDepth > 0.
- *
- * The fix makes the guard unconditional (`if (s.dispatching)` without
- * `&& s.skipDepth === 0`), and defers recursive re-dispatch via
- * setImmediate/setTimeout so s.dispatching is released first.
- */
-
-import {
-  _getDispatching,
-  _setDispatching,
-  _getSkipDepth,
-  _setSkipDepth,
-} from "../auto.ts";
-import { createTestContext } from "./test-helpers.ts";
-
-const { assertEq, assertTrue, report } = createTestContext();
-
-async function main(): Promise<void> {
-  // ─── Test-only accessors work ───────────────────────────────────────────
-  console.log("\n=== reentrancy guard: test accessors round-trip ===");
-  {
-    _setDispatching(false);
-    assertEq(_getDispatching(), false, "dispatching starts false");
-
-    _setDispatching(true);
-    assertEq(_getDispatching(), true, "dispatching set to true");
-
-    _setDispatching(false);
-    assertEq(_getDispatching(), false, "dispatching reset to false");
-  }
-
-  // ─── skipDepth accessors ────────────────────────────────────────────────
-  console.log("\n=== reentrancy guard: skipDepth accessors round-trip ===");
-  {
-    _setSkipDepth(0);
-    assertEq(_getSkipDepth(), 0, "skipDepth starts at 0");
-
-    _setSkipDepth(3);
-    assertEq(_getSkipDepth(), 3, "skipDepth set to 3");
-
-    _setSkipDepth(0);
-    assertEq(_getSkipDepth(), 0, "skipDepth reset to 0");
-  }
-
-  // ─── Guard blocks even when skipDepth > 0 (#1272 regression) ───────────
-  console.log("\n=== reentrancy guard: blocks when dispatching=true regardless of skipDepth ===");
-  {
-    // Simulate the scenario from #1272: dispatching=true + skipDepth>0
-    // The old guard (`if (s.dispatching && s.skipDepth === 0)`) would allow
-    // concurrent entry when skipDepth > 0. The fix makes the check
-    // unconditional on skipDepth.
-    _setDispatching(true);
-    _setSkipDepth(2);
-
-    // Verify dispatching is true — guard should block regardless of skipDepth
-    assertTrue(
-      _getDispatching() === true,
-      "dispatching flag is true during skip chain"
-    );
-
-    // The actual reentrancy guard in dispatchNextUnit checks:
-    //   if (s.dispatching) { return; }
-    // We verify the state that would trigger the guard:
-    const wouldBlock = _getDispatching(); // unconditional check
-    const wouldBlockOld = _getDispatching() && _getSkipDepth() === 0; // old check
-
-    assertTrue(wouldBlock === true, "new guard blocks when dispatching=true, skipDepth=2");
-    assertTrue(wouldBlockOld === false, "old guard WOULD NOT block when dispatching=true, skipDepth=2 (the bug)");
-
-    // Clean up
-    _setDispatching(false);
-    _setSkipDepth(0);
-  }
-
-  // ─── Guard allows entry when dispatching=false ──────────────────────────
-  console.log("\n=== reentrancy guard: allows entry when dispatching=false ===");
-  {
-    _setDispatching(false);
-    _setSkipDepth(0);
-    assertTrue(!_getDispatching(), "guard allows entry when dispatching=false, skipDepth=0");
-
-    _setDispatching(false);
-    _setSkipDepth(3);
-    assertTrue(!_getDispatching(), "guard allows entry when dispatching=false, skipDepth=3");
-
-    _setSkipDepth(0);
-  }
-
-  // ─── skipDepth does not affect guard decision (the fix) ─────────────────
-  console.log("\n=== reentrancy guard: skipDepth is irrelevant to guard decision ===");
-  {
-    for (const depth of [0, 1, 2, 5]) {
-      _setDispatching(true);
-      _setSkipDepth(depth);
-      assertTrue(
-        _getDispatching() === true,
-        `guard blocks at skipDepth=${depth} when dispatching=true`
-      );
-    }
-
-    for (const depth of [0, 1, 2, 5]) {
-      _setDispatching(false);
-      _setSkipDepth(depth);
-      assertTrue(
-        _getDispatching() === false,
-        `guard allows at skipDepth=${depth} when dispatching=false`
-      );
-    }
-
-    // Clean up
-    _setDispatching(false);
-    _setSkipDepth(0);
-  }
-
-  report();
-}
-
-main().catch((err) => {
-  console.error(err);
-  process.exit(1);
-});

package/src/resources/extensions/gsd/tests/auto-skip-loop.test.ts

@@ -1,123 +0,0 @@
-/**
- * auto-skip-loop.test.ts — Tests for the consecutive-skip loop breaker.
- *
- * Regression for #728: auto-mode infinite skip loop on previously completed
- * plan-slice units when deriveState keeps returning the same unit.
- *
- * The skip paths in dispatchNextUnit track consecutive skips per unit via
- * unitConsecutiveSkips. When the same unit is skipped > MAX_CONSECUTIVE_SKIPS
- * times without a real dispatch in between, the completion record is evicted
- * so deriveState can reconcile.
- */
-
-import { mkdtempSync, mkdirSync, writeFileSync, rmSync } from "node:fs";
-import { join } from "node:path";
-import { tmpdir } from "node:os";
-
-import {
-  _getUnitConsecutiveSkips,
-  _resetUnitConsecutiveSkips,
-} from "../auto.ts";
-import { MAX_CONSECUTIVE_SKIPS } from "../auto/session.ts";
-import { persistCompletedKey, removePersistedKey, loadPersistedKeys } from "../auto-recovery.ts";
-import { createTestContext } from "./test-helpers.ts";
-
-const { assertEq, assertTrue, report } = createTestContext();
-
-function makeTmpBase(): string {
-  const dir = mkdtempSync(join(tmpdir(), "gsd-skip-loop-test-"));
-  mkdirSync(join(dir, ".gsd"), { recursive: true });
-  return dir;
-}
-
-async function main(): Promise<void> {
-  // ─── Counter starts at zero ────────────────────────────────────────────
-  console.log("\n=== skip loop counter: initial state ===");
-  {
-    _resetUnitConsecutiveSkips();
-    const map = _getUnitConsecutiveSkips();
-    assertEq(map.size, 0, "counter map starts empty after reset");
-  }
-
-  // ─── Counter increments correctly ────────────────────────────────────
-  console.log("\n=== skip loop counter: increments on repeated calls ===");
-  {
-    _resetUnitConsecutiveSkips();
-    const map = _getUnitConsecutiveSkips();
-    const key = "plan-slice/M001/S04";
-
-    for (let i = 1; i <= MAX_CONSECUTIVE_SKIPS; i++) {
-      const prev = map.get(key) ?? 0;
-      map.set(key, prev + 1);
-    }
-
-    assertEq(map.get(key), MAX_CONSECUTIVE_SKIPS, `counter reaches MAX_CONSECUTIVE_SKIPS (${MAX_CONSECUTIVE_SKIPS})`);
-  }
-
-  // ─── Threshold constant is sane ──────────────────────────────────────
-  console.log("\n=== skip loop counter: threshold is reasonable ===");
-  {
-    assertTrue(MAX_CONSECUTIVE_SKIPS >= 3, "threshold allows a few legitimate skips");
-    assertTrue(MAX_CONSECUTIVE_SKIPS <= 10, "threshold catches loops quickly");
-  }
-
-  // ─── Reset clears all keys ────────────────────────────────────────────
-  console.log("\n=== skip loop counter: reset clears all keys ===");
-  {
-    _resetUnitConsecutiveSkips();
-    const map = _getUnitConsecutiveSkips();
-    map.set("plan-slice/M001/S01", 2);
-    map.set("plan-slice/M001/S02", 1);
-    assertEq(map.size, 2, "map has 2 entries before reset");
-
-    _resetUnitConsecutiveSkips();
-    assertEq(_getUnitConsecutiveSkips().size, 0, "map empty after reset");
-  }
-
-  // ─── Eviction path: persistCompletedKey + removePersistedKey round-trip
-  //     (simulates what the loop-breaker does) ───────────────────────────
-  console.log("\n=== skip loop counter: eviction removes persisted key ===");
-  {
-    _resetUnitConsecutiveSkips();
-    const base = makeTmpBase();
-    try {
-      const key = "plan-slice/M001/S04";
-      const keySet = new Set<string>();
-
-      persistCompletedKey(base, key);
-      loadPersistedKeys(base, keySet);
-      assertTrue(keySet.has(key), "key persisted before eviction");
-
-      // Simulate loop-breaker eviction
-      keySet.delete(key);
-      removePersistedKey(base, key);
-      const keySet2 = new Set<string>();
-      loadPersistedKeys(base, keySet2);
-      assertTrue(!keySet2.has(key), "key absent after eviction");
-    } finally {
-      rmSync(base, { recursive: true, force: true });
-    }
-  }
-
-  // ─── Counter resets per-key, not globally ─────────────────────────────
-  console.log("\n=== skip loop counter: per-key isolation ===");
-  {
-    _resetUnitConsecutiveSkips();
-    const map = _getUnitConsecutiveSkips();
-    map.set("plan-slice/M001/S04", MAX_CONSECUTIVE_SKIPS + 1);
-    map.set("plan-slice/M001/S05", 1);
-
-    // Deleting S04 (eviction) should not affect S05
-    map.delete("plan-slice/M001/S04");
-    assertTrue(!map.has("plan-slice/M001/S04"), "S04 evicted");
-    assertEq(map.get("plan-slice/M001/S05"), 1, "S05 counter unaffected");
-  }
-
-  _resetUnitConsecutiveSkips();
-  report();
-}
-
-main().catch((err) => {
-  console.error(err);
-  process.exit(1);
-});

package/src/resources/extensions/gsd/tests/dispatch-stall-guard.test.ts

@@ -1,126 +0,0 @@
-/**
- * dispatch-stall-guard.test.ts — Verifies defensive guards against dispatch stalls (#1073).
- *
- * After a slice completes, dispatchNextUnit must reliably dispatch the next unit.
- * These tests verify:
- * 1. newSession() has timeout protection (prevents permanent hang if session creation stalls)
- * 2. handleAgentEnd has a dispatch hang guard (catches dispatchNextUnit itself hanging)
- * 3. Session timeout constants are exported for configurability
- */
-
-import test from "node:test";
-import assert from "node:assert/strict";
-import { readFileSync } from "node:fs";
-import { join, dirname } from "node:path";
-import { fileURLToPath } from "node:url";
-
-const __dirname = dirname(fileURLToPath(import.meta.url));
-const AUTO_TS_PATH = join(__dirname, "..", "auto.ts");
-const SESSION_TS_PATH = join(__dirname, "..", "auto", "session.ts");
-
-function getAutoTsSource(): string {
-  return readFileSync(AUTO_TS_PATH, "utf-8");
-}
-
-function getSessionTsSource(): string {
-  return readFileSync(SESSION_TS_PATH, "utf-8");
-}
-
-// ── Session timeout constants ───────────────────────────────────────────────
-
-test("AutoSession exports NEW_SESSION_TIMEOUT_MS constant", () => {
-  const source = getSessionTsSource();
-  assert.ok(
-    source.includes("NEW_SESSION_TIMEOUT_MS"),
-    "auto/session.ts must export NEW_SESSION_TIMEOUT_MS for newSession() timeout",
-  );
-});
-
-test("AutoSession exports DISPATCH_HANG_TIMEOUT_MS constant", () => {
-  const source = getSessionTsSource();
-  assert.ok(
-    source.includes("DISPATCH_HANG_TIMEOUT_MS"),
-    "auto/session.ts must export DISPATCH_HANG_TIMEOUT_MS for dispatch hang detection",
-  );
-});
-
-test("NEW_SESSION_TIMEOUT_MS is a reasonable value (15-120 seconds)", () => {
-  const source = getSessionTsSource();
-  const match = source.match(/NEW_SESSION_TIMEOUT_MS\s*=\s*(\d[\d_]*)/);
-  assert.ok(match, "NEW_SESSION_TIMEOUT_MS must have a numeric value");
-  const value = parseInt(match![1]!.replace(/_/g, ""), 10);
-  assert.ok(value >= 15_000 && value <= 120_000,
-    `NEW_SESSION_TIMEOUT_MS must be 15-120s, got ${value}ms`,
-  );
-});
-
-test("DISPATCH_HANG_TIMEOUT_MS is greater than NEW_SESSION_TIMEOUT_MS", () => {
-  const source = getSessionTsSource();
-  const sessionMatch = source.match(/NEW_SESSION_TIMEOUT_MS\s*=\s*(\d[\d_]*)/);
-  const dispatchMatch = source.match(/DISPATCH_HANG_TIMEOUT_MS\s*=\s*(\d[\d_]*)/);
-  assert.ok(sessionMatch && dispatchMatch, "Both timeout constants must exist");
-  const sessionTimeout = parseInt(sessionMatch![1]!.replace(/_/g, ""), 10);
-  const dispatchTimeout = parseInt(dispatchMatch![1]!.replace(/_/g, ""), 10);
-  assert.ok(dispatchTimeout > sessionTimeout,
-    `DISPATCH_HANG_TIMEOUT_MS (${dispatchTimeout}) must be > NEW_SESSION_TIMEOUT_MS (${sessionTimeout})`,
-  );
-});
-
-// ── newSession() timeout in dispatchNextUnit ─────────────────────────────────
-
-test("dispatchNextUnit wraps newSession() with Promise.race timeout", () => {
-  const source = getAutoTsSource();
-  // Search the full file — dispatchNextUnit is very large
-  assert.ok(
-    source.includes("Promise.race") && source.includes("NEW_SESSION_TIMEOUT_MS"),
-    "dispatchNextUnit must use Promise.race with NEW_SESSION_TIMEOUT_MS to timeout newSession() (#1073)",
-  );
-});
-
-test("dispatchNextUnit handles newSession() timeout gracefully", () => {
-  const source = getAutoTsSource();
-  // Must notify user when session times out
-  assert.ok(
-    source.includes("Session creation timed out") || source.includes("Session creation failed"),
-    "dispatchNextUnit must notify user when newSession() times out or fails (#1073)",
-  );
-});
-
-// ── Dispatch hang guard in handleAgentEnd ────────────────────────────────────
-
-test("handleAgentEnd has a dispatch hang guard before dispatchNextUnit", () => {
-  const source = getAutoTsSource();
-  const fnIdx = source.indexOf("export async function handleAgentEnd");
-  assert.ok(fnIdx > -1, "handleAgentEnd must exist");
-
-  // Find the section between step mode check and dispatchNextUnit call
-  const fnBlock = source.slice(fnIdx, source.indexOf("\n// ─── Step Mode", fnIdx + 100));
-  assert.ok(
-    fnBlock.includes("DISPATCH_HANG_TIMEOUT_MS") || fnBlock.includes("dispatchHangGuard"),
-    "handleAgentEnd must have a dispatch hang guard before calling dispatchNextUnit (#1073)",
-  );
-});
-
-test("dispatch hang guard is cleared in finally block", () => {
-  const source = getAutoTsSource();
-  const fnIdx = source.indexOf("export async function handleAgentEnd");
-  const fnBlock = source.slice(fnIdx, source.indexOf("\n// ─── Step Mode", fnIdx + 100));
-  assert.ok(
-    fnBlock.includes("clearTimeout(dispatchHangGuard)"),
-    "dispatch hang guard must be cleared in finally block to prevent false alarms (#1073)",
-  );
-});
-
-// ── Constants are imported in auto.ts ────────────────────────────────────────
-
-test("auto.ts imports NEW_SESSION_TIMEOUT_MS and DISPATCH_HANG_TIMEOUT_MS", () => {
-  const source = getAutoTsSource();
-  assert.ok(
-    source.includes("NEW_SESSION_TIMEOUT_MS"),
-    "auto.ts must import NEW_SESSION_TIMEOUT_MS from session.ts",
-  );
-  assert.ok(
-    source.includes("DISPATCH_HANG_TIMEOUT_MS"),
-    "auto.ts must import DISPATCH_HANG_TIMEOUT_MS from session.ts",
-  );
-});