gsd-pi 2.33.1-dev.ee47f1b → 2.34.0-dev.0150ae9

package/dist/resources/extensions/gsd/auto-prompts.js

@@ -44,6 +44,44 @@ function formatExecutorConstraints() {
         `- Keep individual tasks completable within a single context window — if a task needs more context than fits, split it`,
     ].join("\n");
 }
+function buildSourceFilePaths(base, mid, sid) {
+    const paths = [];
+    const projectPath = resolveGsdRootFile(base, "PROJECT");
+    if (existsSync(projectPath)) {
+        paths.push(`- **Project**: \`${relGsdRootFile("PROJECT")}\``);
+    }
+    const requirementsPath = resolveGsdRootFile(base, "REQUIREMENTS");
+    if (existsSync(requirementsPath)) {
+        paths.push(`- **Requirements**: \`${relGsdRootFile("REQUIREMENTS")}\``);
+    }
+    const decisionsPath = resolveGsdRootFile(base, "DECISIONS");
+    if (existsSync(decisionsPath)) {
+        paths.push(`- **Decisions**: \`${relGsdRootFile("DECISIONS")}\``);
+    }
+    const contextPath = resolveMilestoneFile(base, mid, "CONTEXT");
+    if (contextPath) {
+        paths.push(`- **Milestone Context**: \`${relMilestoneFile(base, mid, "CONTEXT")}\``);
+    }
+    const roadmapPath = resolveMilestoneFile(base, mid, "ROADMAP");
+    if (roadmapPath) {
+        paths.push(`- **Roadmap**: \`${relMilestoneFile(base, mid, "ROADMAP")}\``);
+    }
+    if (sid) {
+        const researchPath = resolveSliceFile(base, mid, sid, "RESEARCH");
+        if (researchPath) {
+            paths.push(`- **Slice Research**: \`${relSliceFile(base, mid, sid, "RESEARCH")}\``);
+        }
+    }
+    else {
+        const researchPath = resolveMilestoneFile(base, mid, "RESEARCH");
+        if (researchPath) {
+            paths.push(`- **Milestone Research**: \`${relMilestoneFile(base, mid, "RESEARCH")}\``);
+        }
+    }
+    return paths.length > 0
+        ? paths.join("\n")
+        : "- Use `rg --files` and targeted reads to identify the relevant source files before planning.";
+}
 // ─── Inline Helpers ───────────────────────────────────────────────────────
 /**
  * Load a file and format it for inlining into a prompt.
@@ -159,46 +197,29 @@ export async function inlineGsdRootFile(base, filename, label) {
 }
 // ─── DB-Aware Inline Helpers ──────────────────────────────────────────────
 /**
- * Shared DB-fallback pattern: attempt a DB query via the context-store, format
- * the result, and fall back to the filesystem file when the DB is unavailable
- * or the query yields no results.
- *
- * @param base       Project root for filesystem fallback
- * @param label      Section heading (e.g. "Decisions")
- * @param filename   Filesystem fallback file (e.g. "decisions.md")
- * @param queryDb    Async callback receiving the dynamically-imported
- *                   context-store module. Returns formatted markdown or null.
+ * Inline decisions with optional milestone scoping from the DB.
+ * Falls back to filesystem via inlineGsdRootFile when DB unavailable or empty.
  */
-async function inlineFromDbOrFile(base, label, filename, queryDb) {
+export async function inlineDecisionsFromDb(base, milestoneId, scope, level) {
+    const inlineLevel = level ?? resolveInlineLevel();
     try {
         const { isDbAvailable } = await import("./gsd-db.js");
         if (isDbAvailable()) {
-            const contextStore = await import("./context-store.js");
-            const content = queryDb(contextStore);
-            if (content) {
-                return `### ${label}\nSource: \`.gsd/${filename.toUpperCase().replace(/\.MD$/i, "")}.md\`\n\n${content}`;
+            const { queryDecisions, formatDecisionsForPrompt } = await import("./context-store.js");
+            const decisions = queryDecisions({ milestoneId, scope });
+            if (decisions.length > 0) {
+                // Use compact format for non-full levels to save ~35% tokens
+                const formatted = inlineLevel !== "full"
+                    ? formatDecisionsCompact(decisions)
+                    : formatDecisionsForPrompt(decisions);
+                return `### Decisions\nSource: \`.gsd/DECISIONS.md\`\n\n${formatted}`;
             }
         }
     }
     catch {
         // DB not available — fall through to filesystem
     }
-    return inlineGsdRootFile(base, filename, label);
-}
-/**
- * Inline decisions with optional milestone scoping from the DB.
- * Falls back to filesystem via inlineGsdRootFile when DB unavailable or empty.
- */
-export async function inlineDecisionsFromDb(base, milestoneId, scope, level) {
-    const inlineLevel = level ?? resolveInlineLevel();
-    return inlineFromDbOrFile(base, "Decisions", "decisions.md", (cs) => {
-        const decisions = cs.queryDecisions({ milestoneId, scope });
-        if (decisions.length === 0)
-            return null;
-        return inlineLevel !== "full"
-            ? formatDecisionsCompact(decisions)
-            : cs.formatDecisionsForPrompt(decisions);
-    });
+    return inlineGsdRootFile(base, "decisions.md", "Decisions");
 }
 /**
  * Inline requirements with optional slice scoping from the DB.
@@ -206,23 +227,44 @@ export async function inlineDecisionsFromDb(base, milestoneId, scope, level) {
  */
 export async function inlineRequirementsFromDb(base, sliceId, level) {
     const inlineLevel = level ?? resolveInlineLevel();
-    return inlineFromDbOrFile(base, "Requirements", "requirements.md", (cs) => {
-        const requirements = cs.queryRequirements({ sliceId });
-        if (requirements.length === 0)
-            return null;
-        return inlineLevel !== "full"
-            ? formatRequirementsCompact(requirements)
-            : cs.formatRequirementsForPrompt(requirements);
-    });
+    try {
+        const { isDbAvailable } = await import("./gsd-db.js");
+        if (isDbAvailable()) {
+            const { queryRequirements, formatRequirementsForPrompt } = await import("./context-store.js");
+            const requirements = queryRequirements({ sliceId });
+            if (requirements.length > 0) {
+                // Use compact format for non-full levels to save ~40% tokens
+                const formatted = inlineLevel !== "full"
+                    ? formatRequirementsCompact(requirements)
+                    : formatRequirementsForPrompt(requirements);
+                return `### Requirements\nSource: \`.gsd/REQUIREMENTS.md\`\n\n${formatted}`;
+            }
+        }
+    }
+    catch {
+        // DB not available — fall through to filesystem
+    }
+    return inlineGsdRootFile(base, "requirements.md", "Requirements");
 }
 /**
  * Inline project context from the DB.
  * Falls back to filesystem via inlineGsdRootFile when DB unavailable or empty.
  */
 export async function inlineProjectFromDb(base) {
-    return inlineFromDbOrFile(base, "Project", "project.md", (cs) => {
-        return cs.queryProject();
-    });
+    try {
+        const { isDbAvailable } = await import("./gsd-db.js");
+        if (isDbAvailable()) {
+            const { queryProject } = await import("./context-store.js");
+            const content = queryProject();
+            if (content) {
+                return `### Project\nSource: \`.gsd/PROJECT.md\`\n\n${content}`;
+            }
+        }
+    }
+    catch {
+        // DB not available — fall through to filesystem
+    }
+    return inlineGsdRootFile(base, "project.md", "Project");
 }
 // ─── Skill Discovery ──────────────────────────────────────────────────────
 /**
@@ -274,25 +316,6 @@ export function escapeRegExp(value) {
 function oneLine(text) {
     return text.replace(/\s+/g, " ").trim();
 }
-/** Build the standard inlined-context section used by all prompt builders. */
-function buildInlinedContextSection(inlined) {
-    return `## Inlined Context (preloaded — do not re-read these files)\n\n${inlined.join("\n\n---\n\n")}`;
-}
-/** Build the formatted list of available GSD source files for planners to read on demand. */
-function buildSourceFileList(base, opts) {
-    const paths = [];
-    if (opts?.includeProject && existsSync(resolveGsdRootFile(base, "PROJECT")))
-        paths.push(`- **Project**: \`${relGsdRootFile("PROJECT")}\``);
-    if (existsSync(resolveGsdRootFile(base, "REQUIREMENTS")))
-        paths.push(`- **Requirements**: \`${relGsdRootFile("REQUIREMENTS")}\``);
-    if (existsSync(resolveGsdRootFile(base, "DECISIONS")))
-        paths.push(`- **Decisions**: \`${relGsdRootFile("DECISIONS")}\``);
-    if (paths.length === 0) {
-        const types = opts?.includeProject ? "project/requirements/decisions" : "requirements/decisions";
-        return `_No ${types} files found._`;
-    }
-    return paths.join("\n");
-}
 // ─── Section Builders ──────────────────────────────────────────────────────
 export function buildResumeSection(continueContent, legacyContinueContent, continueRelPath, legacyContinueRelPath) {
     const resolvedContent = continueContent ?? legacyContinueContent;
@@ -419,17 +442,6 @@ export async function checkNeedsReassessment(base, mid, state) {
     const hasAssessment = !!(assessmentFile && await loadFile(assessmentFile));
     if (hasAssessment)
         return null;
-    // Fallback: check the expected path directly via existsSync.
-    // resolveSliceFile relies on directory listing (readdirSync) which may not
-    // reflect a freshly written file in git worktree directories on some
-    // filesystems (observed on macOS APFS). A direct existsSync on the
-    // constructed path bypasses directory listing entirely. (#1112)
-    const sliceDir = resolveSlicePath(base, mid, lastCompleted.id);
-    if (sliceDir) {
-        const directPath = join(sliceDir, `${lastCompleted.id}-ASSESSMENT.md`);
-        if (existsSync(directPath))
-            return null;
-    }
     // Also need a summary to reassess against
     const summaryFile = resolveSliceFile(base, mid, lastCompleted.id, "SUMMARY");
     const hasSummary = !!(summaryFile && await loadFile(summaryFile));
@@ -475,22 +487,15 @@ export async function checkNeedsRunUat(base, mid, state, prefs) {
     const uatContent = await loadFile(uatFile);
     if (!uatContent)
         return null;
-    // If a UAT result already exists, the UAT unit has already run and must not
-    // be re-dispatched. PASS means progression can continue; any non-PASS verdict
-    // must be handled by the dispatch table's verdict gate, which stops progression
-    // with a human-action message instead of replaying the same run-uat unit.
+    // If UAT result already exists, skip (idempotent)
     const uatResultFile = resolveSliceFile(base, mid, sid, "UAT-RESULT");
     if (uatResultFile) {
-        const resultContent = await loadFile(uatResultFile);
-        if (resultContent)
+        const hasResult = !!(await loadFile(uatResultFile));
+        if (hasResult)
             return null;
     }
-    // Classify UAT type; skip non-artifact-driven types — auto-mode can only
-    // execute mechanical checks. Non-artifact UATs are tracked in the dashboard
-    // but don't block auto-mode progression.
+    // Classify UAT type; unknown type → treat as human-experience (human review)
     const uatType = extractUatType(uatContent) ?? "human-experience";
-    if (uatType !== "artifact-driven")
-        return null;
     return { sliceId: sid, uatType };
 }
 // ─── Prompt Builders ──────────────────────────────────────────────────────
@@ -512,7 +517,7 @@ export async function buildResearchMilestonePrompt(mid, midTitle, base) {
     if (knowledgeInlineRM)
         inlined.push(knowledgeInlineRM);
     inlined.push(inlineTemplate("research", "Research"));
-    const inlinedContext = buildInlinedContextSection(inlined);
+    const inlinedContext = `## Inlined Context (preloaded — do not re-read these files)\n\n${inlined.join("\n\n---\n\n")}`;
     const outputRelPath = relMilestoneFile(base, mid, "RESEARCH");
     return loadPrompt("research-milestone", {
         workingDirectory: base,
@@ -539,7 +544,17 @@ export async function buildPlanMilestonePrompt(mid, midTitle, base, level) {
     const priorSummaryInline = await inlinePriorMilestoneSummary(mid, base);
     if (priorSummaryInline)
         inlined.push(priorSummaryInline);
-    const sourceFilePaths = buildSourceFileList(base, { includeProject: true });
+    if (inlineLevel !== "minimal") {
+        const projectInline = await inlineProjectFromDb(base);
+        if (projectInline)
+            inlined.push(projectInline);
+        const requirementsInline = await inlineRequirementsFromDb(base, undefined, inlineLevel);
+        if (requirementsInline)
+            inlined.push(requirementsInline);
+        const decisionsInline = await inlineDecisionsFromDb(base, mid, undefined, inlineLevel);
+        if (decisionsInline)
+            inlined.push(decisionsInline);
+    }
     const knowledgeInlinePM = await inlineGsdRootFile(base, "knowledge.md", "Project Knowledge");
     if (knowledgeInlinePM)
         inlined.push(knowledgeInlinePM);
@@ -555,21 +570,21 @@ export async function buildPlanMilestonePrompt(mid, midTitle, base, level) {
         inlined.push(inlineTemplate("plan", "Slice Plan"));
         inlined.push(inlineTemplate("task-plan", "Task Plan"));
     }
-    const inlinedContext = buildInlinedContextSection(inlined);
+    const inlinedContext = `## Inlined Context (preloaded — do not re-read these files)\n\n${inlined.join("\n\n---\n\n")}`;
     const outputRelPath = relMilestoneFile(base, mid, "ROADMAP");
+    const researchOutputPath = join(base, relMilestoneFile(base, mid, "RESEARCH"));
     const secretsOutputPath = join(base, relMilestoneFile(base, mid, "SECRETS"));
-    const researchOutputRelPath = relMilestoneFile(base, mid, "RESEARCH");
     return loadPrompt("plan-milestone", {
         workingDirectory: base,
         milestoneId: mid, milestoneTitle: midTitle,
         milestonePath: relMilestonePath(base, mid),
         contextPath: contextRel,
         researchPath: researchRel,
+        researchOutputPath,
         outputPath: join(base, outputRelPath),
         secretsOutputPath,
         inlinedContext,
-        sourceFilePaths,
-        researchOutputPath: join(base, researchOutputRelPath),
+        sourceFilePaths: buildSourceFilePaths(base, mid),
         ...buildSkillDiscoveryVars(),
     });
 }
@@ -603,7 +618,7 @@ export async function buildResearchSlicePrompt(mid, _midTitle, sid, sTitle, base
     const overridesInline = formatOverridesSection(activeOverrides);
     if (overridesInline)
         inlined.unshift(overridesInline);
-    const inlinedContext = buildInlinedContextSection(inlined);
+    const inlinedContext = `## Inlined Context (preloaded — do not re-read these files)\n\n${inlined.join("\n\n---\n\n")}`;
     const outputRelPath = relSliceFile(base, mid, sid, "RESEARCH");
     return loadPrompt("research-slice", {
         workingDirectory: base,
@@ -629,7 +644,14 @@ export async function buildPlanSlicePrompt(mid, _midTitle, sid, sTitle, base, le
     const researchInline = await inlineFileOptional(researchPath, researchRel, "Slice Research");
     if (researchInline)
         inlined.push(researchInline);
-    const sliceSourceFilePaths = buildSourceFileList(base);
+    if (inlineLevel !== "minimal") {
+        const decisionsInline = await inlineDecisionsFromDb(base, mid, undefined, inlineLevel);
+        if (decisionsInline)
+            inlined.push(decisionsInline);
+        const requirementsInline = await inlineRequirementsFromDb(base, sid, inlineLevel);
+        if (requirementsInline)
+            inlined.push(requirementsInline);
+    }
     const knowledgeInlinePS = await inlineGsdRootFile(base, "knowledge.md", "Project Knowledge");
     if (knowledgeInlinePS)
         inlined.push(knowledgeInlinePS);
@@ -642,11 +664,15 @@ export async function buildPlanSlicePrompt(mid, _midTitle, sid, sTitle, base, le
     const planOverridesInline = formatOverridesSection(planActiveOverrides);
     if (planOverridesInline)
         inlined.unshift(planOverridesInline);
-    const inlinedContext = buildInlinedContextSection(inlined);
+    const inlinedContext = `## Inlined Context (preloaded — do not re-read these files)\n\n${inlined.join("\n\n---\n\n")}`;
     // Build executor context constraints from the budget engine
     const executorContextConstraints = formatExecutorConstraints();
     const outputRelPath = relSliceFile(base, mid, sid, "PLAN");
-    const commitInstruction = "Do not commit planning artifacts — .gsd/ is managed externally.";
+    const prefs = loadEffectiveGSDPreferences();
+    const commitDocsEnabled = prefs?.preferences?.git?.commit_docs !== false;
+    const commitInstruction = commitDocsEnabled
+        ? `Commit the plan files only: \`git add ${relSlicePath(base, mid, sid)}/ .gsd/DECISIONS.md .gitignore && git commit -m "docs(${sid}): add slice plan"\`. Do not stage .gsd/STATE.md or other runtime files — the system manages those.`
+        : "Do not commit — planning docs are not tracked in git for this project.";
     return loadPrompt("plan-slice", {
         workingDirectory: base,
         milestoneId: mid, sliceId: sid, sliceTitle: sTitle,
@@ -656,9 +682,9 @@ export async function buildPlanSlicePrompt(mid, _midTitle, sid, sTitle, base, le
         outputPath: join(base, outputRelPath),
         inlinedContext,
         dependencySummaries: depContent,
+        sourceFilePaths: buildSourceFilePaths(base, mid, sid),
         executorContextConstraints,
         commitInstruction,
-        sourceFilePaths: sliceSourceFilePaths,
     });
 }
 export async function buildExecuteTaskPrompt(mid, sid, sTitle, tid, tTitle, base, level) {
@@ -785,7 +811,7 @@ export async function buildCompleteSlicePrompt(mid, _midTitle, sid, sTitle, base
     const completeOverridesInline = formatOverridesSection(completeActiveOverrides);
     if (completeOverridesInline)
         inlined.unshift(completeOverridesInline);
-    const inlinedContext = buildInlinedContextSection(inlined);
+    const inlinedContext = `## Inlined Context (preloaded — do not re-read these files)\n\n${inlined.join("\n\n---\n\n")}`;
     const sliceRel = relSlicePath(base, mid, sid);
     const sliceSummaryPath = join(base, `${sliceRel}/${sid}-SUMMARY.md`);
     const sliceUatPath = join(base, `${sliceRel}/${sid}-UAT.md`);
@@ -841,7 +867,7 @@ export async function buildCompleteMilestonePrompt(mid, midTitle, base, level) {
     if (contextInline)
         inlined.push(contextInline);
     inlined.push(inlineTemplate("milestone-summary", "Milestone Summary"));
-    const inlinedContext = buildInlinedContextSection(inlined);
+    const inlinedContext = `## Inlined Context (preloaded — do not re-read these files)\n\n${inlined.join("\n\n---\n\n")}`;
     const milestoneSummaryPath = join(base, `${relMilestonePath(base, mid)}/${mid}-SUMMARY.md`);
     return loadPrompt("complete-milestone", {
         workingDirectory: base,
@@ -908,7 +934,7 @@ export async function buildValidateMilestonePrompt(mid, midTitle, base, level) {
     const contextInline = await inlineFileOptional(contextPath, contextRel, "Milestone Context");
     if (contextInline)
         inlined.push(contextInline);
-    const inlinedContext = buildInlinedContextSection(inlined);
+    const inlinedContext = `## Inlined Context (preloaded — do not re-read these files)\n\n${inlined.join("\n\n---\n\n")}`;
     const validationOutputPath = join(base, `${relMilestonePath(base, mid)}/${mid}-VALIDATION.md`);
     const roadmapOutputPath = `${relMilestonePath(base, mid)}/${mid}-ROADMAP.md`;
     return loadPrompt("validate-milestone", {
@@ -956,7 +982,7 @@ export async function buildReplanSlicePrompt(mid, midTitle, sid, sTitle, base) {
     const replanOverridesInline = formatOverridesSection(replanActiveOverrides);
     if (replanOverridesInline)
         inlined.unshift(replanOverridesInline);
-    const inlinedContext = buildInlinedContextSection(inlined);
+    const inlinedContext = `## Inlined Context (preloaded — do not re-read these files)\n\n${inlined.join("\n\n---\n\n")}`;
     const replanPath = join(base, `${relSlicePath(base, mid, sid)}/${sid}-REPLAN.md`);
     // Build capture context for replan prompt (captures that triggered this replan)
     let captureContext = "(none)";
@@ -983,7 +1009,7 @@ export async function buildReplanSlicePrompt(mid, midTitle, sid, sTitle, base) {
         captureContext,
     });
 }
-export async function buildRunUatPrompt(mid, sliceId, uatPath, base) {
+export async function buildRunUatPrompt(mid, sliceId, uatPath, uatContent, base) {
     const inlined = [];
     inlined.push(await inlineFile(resolveSliceFile(base, mid, sliceId, "UAT"), uatPath, `${sliceId} UAT`));
     const summaryPath = resolveSliceFile(base, mid, sliceId, "SUMMARY");
@@ -996,14 +1022,16 @@ export async function buildRunUatPrompt(mid, sliceId, uatPath, base) {
     const projectInline = await inlineProjectFromDb(base);
     if (projectInline)
         inlined.push(projectInline);
-    const inlinedContext = buildInlinedContextSection(inlined);
+    const inlinedContext = `## Inlined Context (preloaded — do not re-read these files)\n\n${inlined.join("\n\n---\n\n")}`;
     const uatResultPath = join(base, relSliceFile(base, mid, sliceId, "UAT-RESULT"));
+    const uatType = extractUatType(uatContent) ?? "human-experience";
     return loadPrompt("run-uat", {
         workingDirectory: base,
         milestoneId: mid,
         sliceId,
         uatPath,
         uatResultPath,
+        uatType,
         inlinedContext,
     });
 }
@@ -1030,7 +1058,7 @@ export async function buildReassessRoadmapPrompt(mid, midTitle, completedSliceId
     const knowledgeInlineRA = await inlineGsdRootFile(base, "knowledge.md", "Project Knowledge");
     if (knowledgeInlineRA)
         inlined.push(knowledgeInlineRA);
-    const inlinedContext = buildInlinedContextSection(inlined);
+    const inlinedContext = `## Inlined Context (preloaded — do not re-read these files)\n\n${inlined.join("\n\n---\n\n")}`;
     const assessmentPath = join(base, relSliceFile(base, mid, completedSliceId, "ASSESSMENT"));
     // Build deferred captures context for reassess prompt
     let deferredCaptures = "(none)";
@@ -1044,7 +1072,11 @@ export async function buildReassessRoadmapPrompt(mid, midTitle, completedSliceId
     catch {
         // Non-fatal — captures module may not be available
     }
-    const reassessCommitInstruction = "Do not commit planning artifacts — .gsd/ is managed externally.";
+    const reassessPrefs = loadEffectiveGSDPreferences();
+    const reassessCommitDocsEnabled = reassessPrefs?.preferences?.git?.commit_docs !== false;
+    const reassessCommitInstruction = reassessCommitDocsEnabled
+        ? `Commit: \`docs(${mid}): reassess roadmap after ${completedSliceId}\`. Stage only the .gsd/milestones/ files you changed — do not stage .gsd/STATE.md or other runtime files.`
+        : "Do not commit — planning docs are not tracked in git for this project.";
     return loadPrompt("reassess-roadmap", {
         workingDirectory: base,
         milestoneId: mid,