gsd-pi 2.33.1-dev.29a8268 → 2.33.1-dev.9bafd68

package/dist/resources/extensions/gsd/tests/skill-lifecycle.test.ts

@@ -1,126 +0,0 @@
-/**
- * Tests for skill telemetry and skill health (#599).
- * Tests the pure functions — no file I/O, no extension context.
- */
-
-import { describe, it, beforeEach } from "node:test";
-import assert from "node:assert/strict";
-import type { UnitMetrics } from "../metrics.js";
-
-// ─── Test helpers ─────────────────────────────────────────────────────────────
-
-function makeUnit(overrides: Partial<UnitMetrics> = {}): UnitMetrics {
-  return {
-    type: "execute-task",
-    id: "M001/S01/T01",
-    model: "claude-sonnet-4-20250514",
-    startedAt: 1000,
-    finishedAt: 2000,
-    tokens: { input: 1000, output: 500, cacheRead: 200, cacheWrite: 100, total: 1800 },
-    cost: 0.05,
-    toolCalls: 3,
-    assistantMessages: 5,
-    userMessages: 2,
-    ...overrides,
-  };
-}
-
-// ─── Skill Telemetry ──────────────────────────────────────────────────────────
-
-describe("skill-telemetry", () => {
-  // Note: captureAvailableSkills/getAndClearSkills depend on filesystem (getAgentDir)
-  // so we test the data flow via getSkillLastUsed and detectStaleSkills which are pure
-
-  it("getSkillLastUsed returns most recent timestamp per skill", async () => {
-    const { getSkillLastUsed } = await import("../skill-telemetry.js");
-
-    const units = [
-      makeUnit({ finishedAt: 1000, skills: ["rust-core", "axum-web-framework"] }),
-      makeUnit({ finishedAt: 2000, skills: ["rust-core"] }),
-      makeUnit({ finishedAt: 3000, skills: ["axum-web-framework"] }),
-    ];
-
-    const result = getSkillLastUsed(units);
-    assert.equal(result.get("rust-core"), 2000);
-    assert.equal(result.get("axum-web-framework"), 3000);
-  });
-
-  it("getSkillLastUsed returns empty map for units without skills", async () => {
-    const { getSkillLastUsed } = await import("../skill-telemetry.js");
-
-    const units = [makeUnit(), makeUnit()];
-    const result = getSkillLastUsed(units);
-    assert.equal(result.size, 0);
-  });
-});
-
-// ─── Skill Health ─────────────────────────────────────────────────────────────
-
-describe("skill-health", () => {
-  it("buildHealSkillPrompt includes unit ID", async () => {
-    const { buildHealSkillPrompt } = await import("../skill-health.js");
-    const prompt = buildHealSkillPrompt("M001/S01/T01");
-    assert.ok(prompt.includes("M001/S01/T01"));
-    assert.ok(prompt.includes("Skill Heal Analysis"));
-    assert.ok(prompt.includes("skill-review-queue.md"));
-  });
-
-  it("computeStaleAvoidList excludes already-avoided skills", async () => {
-    // This test requires filesystem access for loadLedgerFromDisk
-    // so we test the filtering logic conceptually
-    const { computeStaleAvoidList } = await import("../skill-health.js");
-
-    // With no metrics file, should return empty
-    const result = computeStaleAvoidList("/nonexistent/path", ["some-skill"]);
-    assert.ok(Array.isArray(result));
-  });
-});
-
-// ─── UnitMetrics skills field ─────────────────────────────────────────────────
-
-describe("UnitMetrics skills field", () => {
-  it("skills field is optional and accepts string array", () => {
-    const unit = makeUnit({ skills: ["rust-core", "axum-web-framework"] });
-    assert.deepEqual(unit.skills, ["rust-core", "axum-web-framework"]);
-  });
-
-  it("skills field is undefined when not provided", () => {
-    const unit = makeUnit();
-    assert.equal(unit.skills, undefined);
-  });
-});
-
-// ─── Preferences ──────────────────────────────────────────────────────────────
-
-describe("skill_staleness_days preference", () => {
-  it("validates valid staleness days", async () => {
-    const { validatePreferences } = await import("../preferences.js");
-
-    const result = validatePreferences({ skill_staleness_days: 30 });
-    assert.equal(result.preferences.skill_staleness_days, 30);
-    assert.equal(result.errors.length, 0);
-  });
-
-  it("validates zero (disabled) staleness days", async () => {
-    const { validatePreferences } = await import("../preferences.js");
-
-    const result = validatePreferences({ skill_staleness_days: 0 });
-    assert.equal(result.preferences.skill_staleness_days, 0);
-    assert.equal(result.errors.length, 0);
-  });
-
-  it("rejects negative staleness days", async () => {
-    const { validatePreferences } = await import("../preferences.js");
-
-    const result = validatePreferences({ skill_staleness_days: -5 });
-    assert.equal(result.preferences.skill_staleness_days, undefined);
-    assert.ok(result.errors.some(e => e.includes("skill_staleness_days")));
-  });
-
-  it("floors fractional days", async () => {
-    const { validatePreferences } = await import("../preferences.js");
-
-    const result = validatePreferences({ skill_staleness_days: 30.7 });
-    assert.equal(result.preferences.skill_staleness_days, 30);
-  });
-});

package/dist/resources/extensions/gsd/tests/smart-entry-draft.test.ts

@@ -1,123 +0,0 @@
-import { mkdtempSync, mkdirSync, rmSync, writeFileSync, readFileSync } from "node:fs";
-import { join } from "node:path";
-import { tmpdir } from "node:os";
-
-import { deriveState } from "../state.js";
-import { resolveMilestoneFile } from "../paths.js";
-
-let passed = 0;
-let failed = 0;
-
-function assert(condition: boolean, message: string): void {
-  if (condition) {
-    passed++;
-  } else {
-    failed++;
-    console.error(`  FAIL: ${message}`);
-  }
-}
-
-// ─── Fixture: milestone with only CONTEXT-DRAFT.md ──────────────────────
-
-const tmpBase = mkdtempSync(join(tmpdir(), "gsd-smart-entry-draft-test-"));
-const gsd = join(tmpBase, ".gsd");
-
-mkdirSync(join(gsd, "milestones", "M001"), { recursive: true });
-
-const draftContent = `# M001: Test Milestone — Context\n\n**Status:** Draft\n\nSeed material from a prior discussion.\n`;
-writeFileSync(
-  join(gsd, "milestones", "M001", "M001-CONTEXT-DRAFT.md"),
-  draftContent,
-);
-
-// ─── Test: deriveState returns 'needs-discussion' for draft-only milestone ───
-
-const state = await deriveState(tmpBase);
-
-assert(
-  state.phase === "needs-discussion",
-  `phase should be 'needs-discussion' for draft-only milestone, got: "${state.phase}"`,
-);
-
-assert(
-  state.activeMilestone?.id === "M001",
-  `active milestone should be M001, got: "${state.activeMilestone?.id}"`,
-);
-
-// ─── Test: resolveMilestoneFile resolves CONTEXT-DRAFT ─────────────────────
-
-const draftFile = resolveMilestoneFile(tmpBase, "M001", "CONTEXT-DRAFT");
-
-assert(
-  draftFile !== null && draftFile !== undefined,
-  `resolveMilestoneFile should resolve CONTEXT-DRAFT, got: ${draftFile}`,
-);
-
-assert(
-  draftFile!.endsWith("M001-CONTEXT-DRAFT.md"),
-  `resolved path should end with M001-CONTEXT-DRAFT.md, got: "${draftFile}"`,
-);
-
-// ─── Test: CONTEXT.md is NOT resolved (only draft exists) ──────────────────
-
-const contextFile = resolveMilestoneFile(tmpBase, "M001", "CONTEXT");
-
-assert(
-  contextFile === null || contextFile === undefined,
-  `resolveMilestoneFile should NOT resolve CONTEXT when only CONTEXT-DRAFT exists, got: "${contextFile}"`,
-);
-
-// ─── Static: guided-flow.ts has 'needs-discussion' branch ─────────────────
-
-const guidedFlowSource = readFileSync(
-  join(import.meta.dirname, "..", "guided-flow.ts"),
-  "utf-8",
-);
-
-assert(
-  guidedFlowSource.includes('state.phase === "needs-discussion"'),
-  "guided-flow.ts should have 'needs-discussion' phase check in showSmartEntry",
-);
-
-// Check the branch has draft-aware menu options
-const branchIdx = guidedFlowSource.indexOf('state.phase === "needs-discussion"');
-const branchChunk = guidedFlowSource.slice(branchIdx, branchIdx + 4000);
-
-assert(
-  branchChunk.includes("discuss_draft"),
-  "needs-discussion branch should have 'discuss_draft' option",
-);
-
-assert(
-  branchChunk.includes("discuss_fresh"),
-  "needs-discussion branch should have 'discuss_fresh' option",
-);
-
-assert(
-  branchChunk.includes("skip_milestone"),
-  "needs-discussion branch should have 'skip_milestone' option",
-);
-
-assert(
-  branchChunk.includes("CONTEXT-DRAFT"),
-  "needs-discussion branch should load CONTEXT-DRAFT via resolveMilestoneFile",
-);
-
-assert(
-  branchChunk.includes("Draft Seed") || branchChunk.includes("draftContent"),
-  "discuss_draft path should include draft content as seed in the dispatched prompt",
-);
-
-assert(
-  branchChunk.includes("return"),
-  "needs-discussion branch should return early (not fall through to generic no-roadmap menu)",
-);
-
-// ─── Cleanup ──────────────────────────────────────────────────────────────
-
-rmSync(tmpBase, { recursive: true, force: true });
-
-// ─── Results ──────────────────────────────────────────────────────────────
-
-console.log(`\nsmart-entry-draft: ${passed} passed, ${failed} failed`);
-if (failed > 0) process.exit(1);

package/dist/resources/extensions/gsd/tests/stale-worktree-cwd.test.ts

@@ -1,142 +0,0 @@
-/**
- * stale-worktree-cwd.test.ts — Tests for #608 fix.
- *
- * Verifies that when process.cwd() is inside a stale .gsd/worktrees/ path,
- * startAuto escapes back to the project root before proceeding.
- */
-
-import test from "node:test";
-import assert from "node:assert/strict";
-import { mkdtempSync, mkdirSync, rmSync, existsSync, realpathSync, writeFileSync } from "node:fs";
-import { join, sep } from "node:path";
-import { tmpdir } from "node:os";
-import { execSync } from "node:child_process";
-
-import {
-  createAutoWorktree,
-  teardownAutoWorktree,
-  mergeMilestoneToMain,
-} from "../auto-worktree.ts";
-
-function run(command: string, cwd: string): string {
-  return execSync(command, { cwd, stdio: ["ignore", "pipe", "pipe"], encoding: "utf-8" }).trim();
-}
-
-function createTempRepo(): string {
-  const dir = realpathSync(mkdtempSync(join(tmpdir(), "stale-wt-test-")));
-  run("git init", dir);
-  run("git config user.email test@test.com", dir);
-  run("git config user.name Test", dir);
-  writeFileSync(join(dir, "README.md"), "# test\n");
-  // Mirror production: .gsd/worktrees/ is gitignored so autoCommitDirtyState
-  // doesn't pick up the worktrees directory as dirty state (#1127 fix).
-  writeFileSync(join(dir, ".gitignore"), ".gsd/worktrees/\n");
-  run("git add .", dir);
-  run("git commit -m init", dir);
-  run("git branch -M main", dir);
-  return dir;
-}
-
-// ─── escapeStaleWorktree is called by startAuto, test the detection logic ────
-
-test("detects stale worktree path and extracts project root", () => {
-  // Simulate the path pattern: /project/.gsd/worktrees/M004/...
-  const projectRoot = "/Users/test/myproject";
-  const stalePath = `${projectRoot}${sep}.gsd${sep}worktrees${sep}M004`;
-
-  const marker = `${sep}.gsd${sep}worktrees${sep}`;
-  const idx = stalePath.indexOf(marker);
-
-  assert.ok(idx !== -1, "marker found in stale path");
-  assert.equal(stalePath.slice(0, idx), projectRoot, "project root extracted correctly");
-});
-
-test("does not trigger on normal project path", () => {
-  const normalPath = "/Users/test/myproject";
-  const marker = `${sep}.gsd${sep}worktrees${sep}`;
-  const idx = normalPath.indexOf(marker);
-
-  assert.equal(idx, -1, "marker not found in normal path");
-});
-
-// ─── Integration: mergeMilestoneToMain restores cwd ─────────────────────────
-
-test("mergeMilestoneToMain restores cwd to project root", () => {
-  const savedCwd = process.cwd();
-  let tempDir = "";
-
-  try {
-    tempDir = createTempRepo();
-
-    // Create milestone planning artifacts
-    const msDir = join(tempDir, ".gsd", "milestones", "M050");
-    mkdirSync(msDir, { recursive: true });
-    writeFileSync(join(msDir, "CONTEXT.md"), "# M050 Context\n");
-    const roadmap = [
-      "# M050: Test Milestone",
-      "**Vision**: testing",
-      "## Success Criteria",
-      "- It works",
-      "## Slices",
-      "- [x] S01 — First slice",
-    ].join("\n");
-    writeFileSync(join(msDir, "ROADMAP.md"), roadmap);
-    run("git add .", tempDir);
-    run("git commit -m \"add milestone\"", tempDir);
-
-    // Create auto-worktree (enters the worktree dir)
-    const wtPath = createAutoWorktree(tempDir, "M050");
-    assert.equal(process.cwd(), wtPath, "cwd is in worktree after create");
-
-    // Add a change in the worktree
-    writeFileSync(join(wtPath, "feature.txt"), "new feature\n");
-    run("git add .", wtPath);
-    run("git commit -m \"feat: add feature\"", wtPath);
-
-    // Merge back — should restore cwd to tempDir
-    mergeMilestoneToMain(tempDir, "M050", roadmap);
-
-    assert.equal(process.cwd(), tempDir, "cwd restored to project root after merge");
-    assert.ok(!existsSync(wtPath), "worktree directory removed after merge");
-  } finally {
-    process.chdir(savedCwd);
-    if (tempDir && existsSync(tempDir)) {
-      rmSync(tempDir, { recursive: true, force: true });
-    }
-  }
-});
-
-// ─── Integration: stale worktree directory is detectable ────────────────────
-
-test("process.cwd() inside removed worktree is recoverable", () => {
-  const savedCwd = process.cwd();
-  let tempDir = "";
-
-  try {
-    tempDir = createTempRepo();
-
-    // Create a .gsd/worktrees/M099 directory to simulate stale state
-    const staleWtDir = join(tempDir, ".gsd", "worktrees", "M099");
-    mkdirSync(staleWtDir, { recursive: true });
-
-    // Enter the stale directory
-    process.chdir(staleWtDir);
-    const cwdBefore = process.cwd();
-    assert.ok(cwdBefore.includes(`${sep}.gsd${sep}worktrees${sep}`), "cwd is inside worktree dir");
-
-    // Simulate escapeStaleWorktree logic
-    const marker = `${sep}.gsd${sep}worktrees${sep}`;
-    const idx = cwdBefore.indexOf(marker);
-    assert.ok(idx !== -1, "marker found");
-
-    const projectRoot = cwdBefore.slice(0, idx);
-    process.chdir(projectRoot);
-
-    assert.equal(process.cwd(), tempDir, "successfully escaped to project root");
-  } finally {
-    process.chdir(savedCwd);
-    if (tempDir && existsSync(tempDir)) {
-      rmSync(tempDir, { recursive: true, force: true });
-    }
-  }
-});

package/dist/resources/extensions/gsd/tests/stop-auto-remote.test.ts

@@ -1,156 +0,0 @@
-import test from "node:test";
-import assert from "node:assert/strict";
-import { mkdirSync, rmSync } from "node:fs";
-import { join } from "node:path";
-import { tmpdir } from "node:os";
-import { randomUUID } from "node:crypto";
-import { spawn, type ChildProcess } from "node:child_process";
-
-import { writeFileSync } from "node:fs";
-import {
-  writeLock,
-  readCrashLock,
-  clearLock,
-  isLockProcessAlive,
-} from "../crash-recovery.ts";
-import { stopAutoRemote } from "../auto.ts";
-
-function makeTmpBase(): string {
-  const base = join(tmpdir(), `gsd-test-${randomUUID()}`);
-  mkdirSync(join(base, ".gsd"), { recursive: true });
-  return base;
-}
-
-function cleanup(base: string): void {
-  try { rmSync(base, { recursive: true, force: true }); } catch { /* */ }
-}
-
-function waitForChildExit(child: ChildProcess, timeoutMs = 5000): Promise<number | null> {
-  return new Promise((resolve) => {
-    if (child.exitCode !== null) {
-      resolve(child.exitCode);
-      return;
-    }
-
-    const timeout = setTimeout(() => {
-      child.off("exit", onExit);
-      resolve(child.exitCode);
-    }, timeoutMs);
-
-    const onExit = (code: number | null) => {
-      clearTimeout(timeout);
-      resolve(code);
-    };
-
-    child.once("exit", onExit);
-  });
-}
-
-// ─── stopAutoRemote ──────────────────────────────────────────────────────
-
-test("stopAutoRemote returns found:false when no lock file exists", () => {
-  const base = makeTmpBase();
-  try {
-    const result = stopAutoRemote(base);
-    assert.equal(result.found, false);
-    assert.equal(result.pid, undefined);
-    assert.equal(result.error, undefined);
-  } finally {
-    cleanup(base);
-  }
-});
-
-test("stopAutoRemote cleans up stale lock (dead PID) and returns found:false", () => {
-  const base = makeTmpBase();
-  try {
-    // Write a lock with a PID that doesn't exist
-    writeLock(base, "execute-task", "M001/S01/T01", 3);
-    // Overwrite PID to a dead one
-    const lock = readCrashLock(base)!;
-    const staleData = { ...lock, pid: 999999999 };
-    writeFileSync(join(base, ".gsd", "auto.lock"), JSON.stringify(staleData, null, 2), "utf-8");
-
-    const result = stopAutoRemote(base);
-    assert.equal(result.found, false, "stale lock should not be found as running");
-
-    // Lock should be cleaned up
-    assert.equal(readCrashLock(base), null, "stale lock should be removed");
-  } finally {
-    cleanup(base);
-  }
-});
-
-test("stopAutoRemote sends SIGTERM to a live process and returns found:true", async () => {
-  const base = makeTmpBase();
-
-  // Spawn a child process that prints "ready" then sleeps, acting as a fake auto-mode session
-  const child = spawn(
-    process.execPath,
-    ["-e", "process.on('SIGTERM', () => process.exit(0)); process.stdout.write('ready'); setTimeout(() => process.exit(1), 30000);"],
-    { stdio: ["ignore", "pipe", "ignore"], detached: false },
-  );
-
-  if (!child.pid) {
-    throw new Error("failed to spawn child process for stopAutoRemote test");
-  }
-
-  try {
-    // Wait for child to signal readiness via stdout
-    await new Promise<void>((resolve) => {
-      child.stdout!.once("data", () => resolve());
-      setTimeout(resolve, 2000); // fallback timeout
-    });
-
-    // Write lock with child's PID
-    const lockData = {
-      pid: child.pid,
-      startedAt: new Date().toISOString(),
-      unitType: "execute-task",
-      unitId: "M001/S01/T01",
-      unitStartedAt: new Date().toISOString(),
-      completedUnits: 0,
-    };
-    writeFileSync(join(base, ".gsd", "auto.lock"), JSON.stringify(lockData, null, 2), "utf-8");
-
-    const exitPromise = waitForChildExit(child);
-    const result = stopAutoRemote(base);
-    assert.equal(result.found, true, "should find running auto-mode");
-    assert.equal(result.pid, child.pid, "should return the PID");
-
-    // Wait for child to exit (it should receive SIGTERM)
-    const exitCode = await exitPromise;
-    // On Windows, SIGTERM is not interceptable — the process exits with code 1
-    // rather than running the handler. Accept either clean exit (0) or forced (1).
-    assert.ok(exitCode !== null, "child should have exited after SIGTERM");
-    if (process.platform !== "win32") {
-      assert.equal(exitCode, 0, "child should have exited cleanly via SIGTERM");
-    }
-  } finally {
-    try { child.kill("SIGKILL"); } catch { /* already dead */ }
-    cleanup(base);
-  }
-});
-
-// ─── Lock path: original project root vs worktree ────────────────────────
-
-test("lock file should be discoverable at project root, not worktree path", () => {
-  const projectRoot = makeTmpBase();
-  const worktreePath = join(projectRoot, ".gsd", "worktrees", "M001");
-  mkdirSync(join(worktreePath, ".gsd"), { recursive: true });
-
-  try {
-    // Simulate: auto-mode writes lock to project root (the fix)
-    writeLock(projectRoot, "execute-task", "M001/S01/T01", 0);
-
-    // Second terminal checks project root — should find the lock
-    const lock = readCrashLock(projectRoot);
-    assert.ok(lock, "lock should be found at project root");
-    assert.equal(lock!.unitType, "execute-task");
-
-    // Worktree path should NOT have a lock
-    const worktreeLock = readCrashLock(worktreePath);
-    assert.equal(worktreeLock, null, "lock should NOT exist at worktree path");
-  } finally {
-    cleanup(projectRoot);
-  }
-});