gsd-pi 2.33.0-dev.69bff0f → 2.33.0-dev.bafba33

package/dist/resources/extensions/gsd/tests/session-lock-regression.test.ts

@@ -1,216 +0,0 @@
-/**
- * session-lock-regression.test.ts — Regression tests for session lock lifecycle.
- *
- * Regression coverage for:
- *   #1257  False-positive "Session lock lost" during auto-mode
- *   #1245  Stranded .gsd.lock/ directory preventing new sessions
- *   #1251  Same root cause as #1245
- *
- * Tests the acquire → validate → release lifecycle and edge cases
- * without requiring concurrent processes.
- */
-
-import { mkdtempSync, mkdirSync, writeFileSync, rmSync, existsSync, readFileSync } from 'node:fs';
-import { join } from 'node:path';
-import { tmpdir } from 'node:os';
-
-import {
-  acquireSessionLock,
-  validateSessionLock,
-  releaseSessionLock,
-  readSessionLockData,
-  updateSessionLock,
-  isSessionLockHeld,
-} from '../session-lock.ts';
-import { gsdRoot } from '../paths.ts';
-import { createTestContext } from './test-helpers.ts';
-
-const { assertEq, assertTrue, report } = createTestContext();
-
-async function main(): Promise<void> {
-
-  // ─── 1. Basic acquire/release lifecycle ───────────────────────────────
-  console.log('\n=== 1. acquire → validate → release lifecycle ===');
-  {
-    const base = mkdtempSync(join(tmpdir(), 'gsd-session-lock-'));
-    mkdirSync(join(base, '.gsd'), { recursive: true });
-
-    try {
-      const result = acquireSessionLock(base);
-      assertTrue(result.acquired, 'lock acquired successfully');
-
-      const valid = validateSessionLock(base);
-      assertTrue(valid, 'lock validates after acquisition');
-
-      assertTrue(isSessionLockHeld(base), 'isSessionLockHeld returns true');
-
-      releaseSessionLock(base);
-
-      // After release, the lock file should be cleaned up
-      const lockFile = join(gsdRoot(base), 'auto.lock');
-      assertTrue(!existsSync(lockFile), 'lock file removed after release');
-
-      // The .gsd.lock/ directory should be cleaned up
-      const lockDir = gsdRoot(base) + '.lock';
-      assertTrue(!existsSync(lockDir), '.gsd.lock/ directory removed after release (#1245)');
-    } finally {
-      rmSync(base, { recursive: true, force: true });
-    }
-  }
-
-  // ─── 2. Double release is safe ────────────────────────────────────────
-  console.log('\n=== 2. double release does not throw ===');
-  {
-    const base = mkdtempSync(join(tmpdir(), 'gsd-session-lock-'));
-    mkdirSync(join(base, '.gsd'), { recursive: true });
-
-    try {
-      acquireSessionLock(base);
-      releaseSessionLock(base);
-      // Second release should not throw
-      let threw = false;
-      try {
-        releaseSessionLock(base);
-      } catch {
-        threw = true;
-      }
-      assertTrue(!threw, 'double release does not throw');
-    } finally {
-      rmSync(base, { recursive: true, force: true });
-    }
-  }
-
-  // ─── 3. updateSessionLock preserves lock data ─────────────────────────
-  console.log('\n=== 3. updateSessionLock writes metadata ===');
-  {
-    const base = mkdtempSync(join(tmpdir(), 'gsd-session-lock-'));
-    mkdirSync(join(base, '.gsd'), { recursive: true });
-
-    try {
-      acquireSessionLock(base);
-
-      updateSessionLock(base, 'execute-task', 'M001/S01/T01', 5, '/tmp/session.json');
-
-      const data = readSessionLockData(base);
-      assertTrue(data !== null, 'lock data readable after update');
-      if (data) {
-        assertEq(data.pid, process.pid, 'lock data has correct PID');
-        assertEq(data.unitType, 'execute-task', 'lock data has correct unit type');
-        assertEq(data.unitId, 'M001/S01/T01', 'lock data has correct unit ID');
-        assertEq(data.completedUnits, 5, 'lock data has correct completed count');
-        assertEq(data.sessionFile, '/tmp/session.json', 'lock data has session file');
-      }
-
-      releaseSessionLock(base);
-    } finally {
-      rmSync(base, { recursive: true, force: true });
-    }
-  }
-
-  // ─── 4. Stale lock from dead PID → re-acquirable (#1245) ─────────────
-  console.log('\n=== 4. stale lock from dead PID → re-acquirable ===');
-  {
-    const base = mkdtempSync(join(tmpdir(), 'gsd-session-lock-'));
-    mkdirSync(join(base, '.gsd'), { recursive: true });
-
-    try {
-      // Write a lock file with a definitely-dead PID
-      const lockFile = join(gsdRoot(base), 'auto.lock');
-      const staleLock = {
-        pid: 99999999, // extremely unlikely to be alive
-        startedAt: new Date(Date.now() - 3600000).toISOString(),
-        unitType: 'execute-task',
-        unitId: 'M001/S01/T01',
-        unitStartedAt: new Date(Date.now() - 3600000).toISOString(),
-        completedUnits: 3,
-      };
-      writeFileSync(lockFile, JSON.stringify(staleLock, null, 2));
-
-      // Should be able to acquire despite the stale lock
-      const result = acquireSessionLock(base);
-      assertTrue(result.acquired, '#1245: stale lock from dead PID → re-acquirable');
-
-      releaseSessionLock(base);
-    } finally {
-      rmSync(base, { recursive: true, force: true });
-    }
-  }
-
-  // ─── 5. readSessionLockData with no lock → null ───────────────────────
-  console.log('\n=== 5. readSessionLockData with no lock → null ===');
-  {
-    const base = mkdtempSync(join(tmpdir(), 'gsd-session-lock-'));
-    mkdirSync(join(base, '.gsd'), { recursive: true });
-
-    try {
-      const data = readSessionLockData(base);
-      assertEq(data, null, 'no lock file → null');
-    } finally {
-      rmSync(base, { recursive: true, force: true });
-    }
-  }
-
-  // ─── 6. validateSessionLock after own acquisition → true ──────────────
-  console.log('\n=== 6. validateSessionLock after own acquisition → true ===');
-  {
-    const base = mkdtempSync(join(tmpdir(), 'gsd-session-lock-'));
-    mkdirSync(join(base, '.gsd'), { recursive: true });
-
-    try {
-      acquireSessionLock(base);
-
-      // Multiple validations should all return true (regression for #1257)
-      for (let i = 0; i < 5; i++) {
-        const valid = validateSessionLock(base);
-        assertTrue(valid, `#1257: validation ${i + 1} returns true for own lock`);
-      }
-
-      releaseSessionLock(base);
-    } finally {
-      rmSync(base, { recursive: true, force: true });
-    }
-  }
-
-  // ─── 7. readSessionLockData with corrupt JSON → null ──────────────────
-  console.log('\n=== 7. corrupt lock file → null ===');
-  {
-    const base = mkdtempSync(join(tmpdir(), 'gsd-session-lock-'));
-    mkdirSync(join(base, '.gsd'), { recursive: true });
-
-    try {
-      const lockFile = join(gsdRoot(base), 'auto.lock');
-      writeFileSync(lockFile, 'NOT VALID JSON {{{');
-
-      const data = readSessionLockData(base);
-      assertEq(data, null, 'corrupt JSON → null');
-    } finally {
-      rmSync(base, { recursive: true, force: true });
-    }
-  }
-
-  // ─── 8. Acquire after release is possible ─────────────────────────────
-  console.log('\n=== 8. acquire after release → re-acquirable ===');
-  {
-    const base = mkdtempSync(join(tmpdir(), 'gsd-session-lock-'));
-    mkdirSync(join(base, '.gsd'), { recursive: true });
-
-    try {
-      const r1 = acquireSessionLock(base);
-      assertTrue(r1.acquired, 'first acquisition');
-      releaseSessionLock(base);
-
-      const r2 = acquireSessionLock(base);
-      assertTrue(r2.acquired, 're-acquisition after release');
-      releaseSessionLock(base);
-    } finally {
-      rmSync(base, { recursive: true, force: true });
-    }
-  }
-
-  report();
-}
-
-main().catch((error) => {
-  console.error(error);
-  process.exit(1);
-});

package/dist/resources/extensions/gsd/tests/worktree-sync-milestones.test.ts

@@ -1,206 +0,0 @@
-/**
- * worktree-sync-milestones.test.ts — Regression test for #1311.
- *
- * Verifies that syncGsdStateToWorktree copies missing milestones,
- * milestone files, and slice directories from the main repo's .gsd/
- * into the worktree's .gsd/.
- *
- * Covers:
- *   - Entirely missing milestone directory
- *   - Milestone exists but missing CONTEXT/ROADMAP files
- *   - Missing slices within an existing milestone
- *   - No-op when directories are identical (symlinked)
- *   - Root-level files (DECISIONS, REQUIREMENTS, etc.)
- */
-
-import { mkdtempSync, mkdirSync, writeFileSync, rmSync, existsSync, readFileSync, symlinkSync, realpathSync } from 'node:fs';
-import { join } from 'node:path';
-import { tmpdir } from 'node:os';
-
-import { syncGsdStateToWorktree } from '../auto-worktree.ts';
-import { createTestContext } from './test-helpers.ts';
-
-const { assertEq, assertTrue, report } = createTestContext();
-
-function createBase(name: string): string {
-  const base = mkdtempSync(join(tmpdir(), `gsd-wt-sync-${name}-`));
-  mkdirSync(join(base, '.gsd', 'milestones'), { recursive: true });
-  return base;
-}
-
-function cleanup(base: string): void {
-  rmSync(base, { recursive: true, force: true });
-}
-
-async function main(): Promise<void> {
-
-  // ─── 1. Missing milestone directory is synced ─────────────────────────
-  console.log('\n=== 1. missing milestone directory is copied from main ===');
-  {
-    const mainBase = createBase('main');
-    const wtBase = createBase('wt');
-
-    try {
-      // Main repo has M001 and M002
-      const m001Dir = join(mainBase, '.gsd', 'milestones', 'M001');
-      mkdirSync(m001Dir, { recursive: true });
-      writeFileSync(join(m001Dir, 'M001-CONTEXT.md'), '# M001\nDone.');
-      writeFileSync(join(m001Dir, 'M001-ROADMAP.md'), '# Roadmap');
-
-      const m002Dir = join(mainBase, '.gsd', 'milestones', 'M002');
-      mkdirSync(m002Dir, { recursive: true });
-      writeFileSync(join(m002Dir, 'M002-CONTEXT.md'), '# M002\nNew milestone.');
-      writeFileSync(join(m002Dir, 'M002-ROADMAP.md'), '# Roadmap');
-
-      // Worktree only has M001
-      const wtM001Dir = join(wtBase, '.gsd', 'milestones', 'M001');
-      mkdirSync(wtM001Dir, { recursive: true });
-      writeFileSync(join(wtM001Dir, 'M001-CONTEXT.md'), '# M001\nDone.');
-
-      // M002 is missing from worktree
-      assertTrue(!existsSync(join(wtBase, '.gsd', 'milestones', 'M002')), 'M002 missing before sync');
-
-      const result = syncGsdStateToWorktree(mainBase, wtBase);
-
-      assertTrue(existsSync(join(wtBase, '.gsd', 'milestones', 'M002')), '#1311: M002 synced to worktree');
-      assertTrue(existsSync(join(wtBase, '.gsd', 'milestones', 'M002', 'M002-CONTEXT.md')), 'M002 CONTEXT synced');
-      assertTrue(existsSync(join(wtBase, '.gsd', 'milestones', 'M002', 'M002-ROADMAP.md')), 'M002 ROADMAP synced');
-      assertTrue(result.synced.length > 0, 'sync reported files');
-    } finally {
-      cleanup(mainBase);
-      cleanup(wtBase);
-    }
-  }
-
-  // ─── 2. Missing files within existing milestone ───────────────────────
-  console.log('\n=== 2. missing files within existing milestone are synced ===');
-  {
-    const mainBase = createBase('main');
-    const wtBase = createBase('wt');
-
-    try {
-      // Main repo M001 has CONTEXT, ROADMAP, RESEARCH
-      const m001Dir = join(mainBase, '.gsd', 'milestones', 'M001');
-      mkdirSync(m001Dir, { recursive: true });
-      writeFileSync(join(m001Dir, 'M001-CONTEXT.md'), '# M001 Context');
-      writeFileSync(join(m001Dir, 'M001-ROADMAP.md'), '# M001 Roadmap');
-      writeFileSync(join(m001Dir, 'M001-RESEARCH.md'), '# M001 Research');
-
-      // Worktree M001 only has CONTEXT (stale snapshot)
-      const wtM001Dir = join(wtBase, '.gsd', 'milestones', 'M001');
-      mkdirSync(wtM001Dir, { recursive: true });
-      writeFileSync(join(wtM001Dir, 'M001-CONTEXT.md'), '# M001 Context');
-
-      const result = syncGsdStateToWorktree(mainBase, wtBase);
-
-      assertTrue(existsSync(join(wtBase, '.gsd', 'milestones', 'M001', 'M001-ROADMAP.md')), 'ROADMAP synced');
-      assertTrue(existsSync(join(wtBase, '.gsd', 'milestones', 'M001', 'M001-RESEARCH.md')), 'RESEARCH synced');
-      // Existing file should NOT be overwritten
-      assertEq(
-        readFileSync(join(wtBase, '.gsd', 'milestones', 'M001', 'M001-CONTEXT.md'), 'utf-8'),
-        '# M001 Context',
-        'existing CONTEXT not overwritten',
-      );
-    } finally {
-      cleanup(mainBase);
-      cleanup(wtBase);
-    }
-  }
-
-  // ─── 3. Missing slices directory synced ───────────────────────────────
-  console.log('\n=== 3. missing slices directory synced ===');
-  {
-    const mainBase = createBase('main');
-    const wtBase = createBase('wt');
-
-    try {
-      // Main repo has M001 with slices S01–S03
-      const m001Dir = join(mainBase, '.gsd', 'milestones', 'M001');
-      mkdirSync(join(m001Dir, 'slices', 'S01'), { recursive: true });
-      mkdirSync(join(m001Dir, 'slices', 'S02'), { recursive: true });
-      mkdirSync(join(m001Dir, 'slices', 'S03'), { recursive: true });
-      writeFileSync(join(m001Dir, 'M001-ROADMAP.md'), '# Roadmap');
-      writeFileSync(join(m001Dir, 'slices', 'S01', 'S01-PLAN.md'), '# S01 Plan');
-      writeFileSync(join(m001Dir, 'slices', 'S02', 'S02-PLAN.md'), '# S02 Plan');
-      writeFileSync(join(m001Dir, 'slices', 'S03', 'S03-PLAN.md'), '# S03 Plan');
-
-      // Worktree M001 has slices S01–S02 only (S03 missing)
-      const wtM001Dir = join(wtBase, '.gsd', 'milestones', 'M001');
-      mkdirSync(join(wtM001Dir, 'slices', 'S01'), { recursive: true });
-      mkdirSync(join(wtM001Dir, 'slices', 'S02'), { recursive: true });
-      writeFileSync(join(wtM001Dir, 'M001-ROADMAP.md'), '# Roadmap');
-      writeFileSync(join(wtM001Dir, 'slices', 'S01', 'S01-PLAN.md'), '# S01 Plan');
-      writeFileSync(join(wtM001Dir, 'slices', 'S02', 'S02-PLAN.md'), '# S02 Plan');
-
-      assertTrue(!existsSync(join(wtBase, '.gsd', 'milestones', 'M001', 'slices', 'S03')), 'S03 missing before sync');
-
-      syncGsdStateToWorktree(mainBase, wtBase);
-
-      assertTrue(existsSync(join(wtBase, '.gsd', 'milestones', 'M001', 'slices', 'S03')), '#1311: S03 synced');
-      assertTrue(existsSync(join(wtBase, '.gsd', 'milestones', 'M001', 'slices', 'S03', 'S03-PLAN.md')), 'S03 PLAN synced');
-    } finally {
-      cleanup(mainBase);
-      cleanup(wtBase);
-    }
-  }
-
-  // ─── 4. No-op when both resolve to same directory (symlink) ───────────
-  console.log('\n=== 4. no-op when .gsd/ resolves to same path (symlinked) ===');
-  {
-    const sharedDir = createBase('shared');
-    const mainBase = mkdtempSync(join(tmpdir(), 'gsd-wt-sync-main-'));
-    const wtBase = mkdtempSync(join(tmpdir(), 'gsd-wt-sync-wt-'));
-
-    try {
-      // Both main and worktree symlink to the same shared directory
-      writeFileSync(join(sharedDir, '.gsd', 'milestones', 'keep'), '');
-      symlinkSync(join(sharedDir, '.gsd'), join(mainBase, '.gsd'));
-      symlinkSync(join(sharedDir, '.gsd'), join(wtBase, '.gsd'));
-
-      const result = syncGsdStateToWorktree(mainBase, wtBase);
-      assertEq(result.synced.length, 0, 'no files synced when both point to same dir');
-    } finally {
-      cleanup(sharedDir);
-      rmSync(mainBase, { recursive: true, force: true });
-      rmSync(wtBase, { recursive: true, force: true });
-    }
-  }
-
-  // ─── 5. Root-level .gsd/ files synced ─────────────────────────────────
-  console.log('\n=== 5. root-level .gsd/ files synced ===');
-  {
-    const mainBase = createBase('main');
-    const wtBase = createBase('wt');
-
-    try {
-      writeFileSync(join(mainBase, '.gsd', 'DECISIONS.md'), '# Decisions');
-      writeFileSync(join(mainBase, '.gsd', 'REQUIREMENTS.md'), '# Requirements');
-      writeFileSync(join(mainBase, '.gsd', 'PROJECT.md'), '# Project');
-
-      // Worktree has none of these
-      const result = syncGsdStateToWorktree(mainBase, wtBase);
-
-      assertTrue(existsSync(join(wtBase, '.gsd', 'DECISIONS.md')), 'DECISIONS.md synced');
-      assertTrue(existsSync(join(wtBase, '.gsd', 'REQUIREMENTS.md')), 'REQUIREMENTS.md synced');
-      assertTrue(existsSync(join(wtBase, '.gsd', 'PROJECT.md')), 'PROJECT.md synced');
-      assertTrue(result.synced.length >= 3, 'at least 3 files synced');
-    } finally {
-      cleanup(mainBase);
-      cleanup(wtBase);
-    }
-  }
-
-  // ─── 6. Non-existent directories handled gracefully ───────────────────
-  console.log('\n=== 6. non-existent directories → no-op ===');
-  {
-    const result = syncGsdStateToWorktree('/tmp/does-not-exist-main', '/tmp/does-not-exist-wt');
-    assertEq(result.synced.length, 0, 'no crash on missing directories');
-  }
-
-  report();
-}
-
-main().catch((error) => {
-  console.error(error);
-  process.exit(1);
-});