gsd-pi 2.28.0 → 2.29.0-dev.2ccf3fb

package/dist/resources/extensions/gsd/github-client.ts

@@ -1,235 +0,0 @@
-/**
- * GSD GitHub Client
- *
- * Standalone utility for interacting with GitHub's API via Octokit.
- * Provides helpers for PR creation, review reading, and issue management.
- * Can be used by other extensions that need GitHub integration.
- */
-
-import { execSync } from "node:child_process";
-import { Octokit } from "@octokit/rest";
-
-// ─── Types ─────────────────────────────────────────────────────────────────
-
-export interface RepoInfo {
-  owner: string;
-  repo: string;
-}
-
-export interface PullRequestOptions {
-  owner: string;
-  repo: string;
-  title: string;
-  body: string;
-  head: string;
-  base: string;
-}
-
-export interface PullRequestResult {
-  number: number;
-  url: string;
-}
-
-export interface PR {
-  number: number;
-  title: string;
-  body: string | null;
-  state: string;
-  head: { ref: string; sha: string };
-  base: { ref: string };
-  url: string;
-  user: { login: string } | null;
-}
-
-export interface Review {
-  id: number;
-  user: { login: string } | null;
-  state: string;
-  body: string | null;
-  submitted_at: string | null;
-}
-
-export interface IssueCommentOptions {
-  owner: string;
-  repo: string;
-  number: number;
-  body: string;
-}
-
-// ─── Remote URL Parsing ────────────────────────────────────────────────────
-
-/**
- * Parse a GitHub owner/repo from a git remote URL.
- * Supports both HTTPS and SSH formats:
- *   https://github.com/owner/repo.git
- *   git@github.com:owner/repo.git
- *   https://github.com/owner/repo
- *   ssh://git@github.com/owner/repo.git
- */
-export function parseRemoteUrl(url: string): RepoInfo | null {
-  // SSH format: git@github.com:owner/repo.git
-  const sshMatch = url.match(/^git@github\.com:([^/]+)\/([^/.]+?)(?:\.git)?$/);
-  if (sshMatch) {
-    return { owner: sshMatch[1], repo: sshMatch[2] };
-  }
-
-  // HTTPS or ssh:// format
-  const httpsMatch = url.match(
-    /(?:https?|ssh):\/\/(?:[^@]+@)?github\.com\/([^/]+)\/([^/.]+?)(?:\.git)?$/,
-  );
-  if (httpsMatch) {
-    return { owner: httpsMatch[1], repo: httpsMatch[2] };
-  }
-
-  return null;
-}
-
-// ─── Client Creation ───────────────────────────────────────────────────────
-
-/**
- * Create an authenticated Octokit client.
- * Uses the provided token, or falls back to GITHUB_TOKEN / GH_TOKEN env vars.
- * Returns null if no token is available.
- */
-export function createGitHubClient(token?: string): Octokit | null {
-  const auth = token || process.env.GITHUB_TOKEN || process.env.GH_TOKEN;
-  if (!auth) {
-    return null;
-  }
-  return new Octokit({ auth });
-}
-
-// ─── Repository Info ───────────────────────────────────────────────────────
-
-/**
- * Detect the GitHub owner/repo from the git remote in the given working directory.
- */
-export async function getRepoInfo(cwd: string): Promise<RepoInfo | null> {
-  try {
-    const url = execSync("git config --get remote.origin.url", {
-      cwd,
-      encoding: "utf-8",
-      stdio: ["ignore", "pipe", "pipe"],
-    }).trim();
-
-    if (!url) return null;
-    return parseRemoteUrl(url);
-  } catch {
-    return null;
-  }
-}
-
-// ─── Pull Request Operations ───────────────────────────────────────────────
-
-/**
- * Create a pull request on GitHub.
- */
-export async function createPullRequest(
-  client: Octokit,
-  options: PullRequestOptions,
-): Promise<PullRequestResult> {
-  try {
-    const { data } = await client.pulls.create({
-      owner: options.owner,
-      repo: options.repo,
-      title: options.title,
-      body: options.body,
-      head: options.head,
-      base: options.base,
-    });
-    return { number: data.number, url: data.html_url };
-  } catch (error: unknown) {
-    const message =
-      error instanceof Error ? error.message : "Unknown error";
-    throw new Error(
-      `Failed to create pull request for ${options.owner}/${options.repo}: ${message}`,
-    );
-  }
-}
-
-/**
- * Fetch a single pull request by number.
- */
-export async function getPullRequest(
-  client: Octokit,
-  options: { owner: string; repo: string; number: number },
-): Promise<PR> {
-  try {
-    const { data } = await client.pulls.get({
-      owner: options.owner,
-      repo: options.repo,
-      pull_number: options.number,
-    });
-    return {
-      number: data.number,
-      title: data.title,
-      body: data.body,
-      state: data.state,
-      head: { ref: data.head.ref, sha: data.head.sha },
-      base: { ref: data.base.ref },
-      url: data.html_url,
-      user: data.user ? { login: data.user.login } : null,
-    };
-  } catch (error: unknown) {
-    const message =
-      error instanceof Error ? error.message : "Unknown error";
-    throw new Error(
-      `Failed to get pull request #${options.number} for ${options.owner}/${options.repo}: ${message}`,
-    );
-  }
-}
-
-/**
- * List reviews on a pull request.
- */
-export async function listPullRequestReviews(
-  client: Octokit,
-  options: { owner: string; repo: string; number: number },
-): Promise<Review[]> {
-  try {
-    const { data } = await client.pulls.listReviews({
-      owner: options.owner,
-      repo: options.repo,
-      pull_number: options.number,
-    });
-    return data.map((review) => ({
-      id: review.id,
-      user: review.user ? { login: review.user.login } : null,
-      state: review.state,
-      body: review.body,
-      submitted_at: review.submitted_at ?? null,
-    }));
-  } catch (error: unknown) {
-    const message =
-      error instanceof Error ? error.message : "Unknown error";
-    throw new Error(
-      `Failed to list reviews for PR #${options.number} in ${options.owner}/${options.repo}: ${message}`,
-    );
-  }
-}
-
-// ─── Issue Comments ────────────────────────────────────────────────────────
-
-/**
- * Create a comment on an issue or pull request.
- */
-export async function createIssueComment(
-  client: Octokit,
-  options: IssueCommentOptions,
-): Promise<{ id: number }> {
-  try {
-    const { data } = await client.issues.createComment({
-      owner: options.owner,
-      repo: options.repo,
-      issue_number: options.number,
-      body: options.body,
-    });
-    return { id: data.id };
-  } catch (error: unknown) {
-    const message =
-      error instanceof Error ? error.message : "Unknown error";
-    throw new Error(
-      `Failed to create comment on issue #${options.number} in ${options.owner}/${options.repo}: ${message}`,
-    );
-  }
-}

package/dist/resources/extensions/gsd/tests/activity-log-prune.test.ts

@@ -1,297 +0,0 @@
-// Tests for pruneActivityLogs — age-based activity log pruning with
-// highest-seq preservation invariant — plus step-11 prompt text assertion.
-//
-// Sections:
-//   (a) Basic pruning: one old file deleted, two recent survive
-//   (b) Highest-seq preserved even when all files are old
-//   (c) retentionDays=0 boundary: all non-highest-seq deleted
-//   (d) No-op when all files are recent
-//   (e) Empty directory: no crash
-//   (f) All old files: only highest-seq survives
-//   (g) Single file: always preserved (it IS highest-seq)
-//   (h) Seq number is tie-breaker (010 beats 001 lexicographically and numerically)
-//   (i) Non-matching filenames ignored: notes.txt survives, no crash
-//   (j) Step-11 prompt text: "refresh current state if needed"
-
-import { mkdtempSync, mkdirSync, readdirSync, rmSync, utimesSync, writeFileSync } from 'node:fs';
-import { join, dirname } from 'node:path';
-import { tmpdir } from 'node:os';
-import { fileURLToPath } from 'node:url';
-
-import { pruneActivityLogs } from '../activity-log.ts';
-import { createTestContext } from './test-helpers.ts';
-
-const __dirname = dirname(fileURLToPath(import.meta.url));
-
-
-const { assertEq, assertTrue, report } = createTestContext();
-// ─── Fixture helpers ───────────────────────────────────────────────────────
-
-let tmpDirs: string[] = [];
-
-function createTmpActivityDir(): string {
-  const dir = mkdtempSync(join(tmpdir(), 'gsd-prune-test-'));
-  tmpDirs.push(dir);
-  return dir;
-}
-
-function writeActivityFile(activityDir: string, seq: string, name: string): string {
-  mkdirSync(activityDir, { recursive: true });
-  const filePath = join(activityDir, `${seq}-${name}.jsonl`);
-  writeFileSync(filePath, `{"seq":${parseInt(seq, 10)},"name":"${name}"}\n`, 'utf-8');
-  return filePath;
-}
-
-/** Set mtime to daysAgo days in the past. */
-function backdateFile(filePath: string, daysAgo: number): void {
-  const pastMs = Date.now() - daysAgo * 24 * 60 * 60 * 1000;
-  const pastDate = new Date(pastMs);
-  utimesSync(filePath, pastDate, pastDate);
-}
-
-function cleanup(): void {
-  for (const dir of tmpDirs) {
-    rmSync(dir, { recursive: true, force: true });
-  }
-  tmpDirs = [];
-}
-
-process.on('exit', cleanup);
-
-// ─── Helper: get sorted filenames (basenames only) in a directory ──────────
-
-function listFiles(dir: string): string[] {
-  return readdirSync(dir).sort();
-}
-
-// ═══════════════════════════════════════════════════════════════════════════
-// Tests
-// ═══════════════════════════════════════════════════════════════════════════
-
-async function main(): Promise<void> {
-
-  // ─── (a) Basic pruning ────────────────────────────────────────────────────
-  console.log('\n── (a) Basic pruning: one old file deleted, two recent survive');
-
-  {
-    const dir = createTmpActivityDir();
-    const f001 = writeActivityFile(dir, '001', 'execute-task-M001-S01-T01');
-    const _f002 = writeActivityFile(dir, '002', 'execute-task-M001-S01-T02');
-    const _f003 = writeActivityFile(dir, '003', 'execute-task-M001-S01-T03');
-
-    backdateFile(f001, 40); // older than 30-day retention
-
-    pruneActivityLogs(dir, 30);
-
-    const remaining = listFiles(dir);
-    assertTrue(
-      !remaining.includes('001-execute-task-M001-S01-T01.jsonl'),
-      '(a) file 001 deleted (40 days old, past 30-day threshold)',
-    );
-    assertTrue(
-      remaining.includes('002-execute-task-M001-S01-T02.jsonl'),
-      '(a) file 002 survives (recent)',
-    );
-    assertTrue(
-      remaining.includes('003-execute-task-M001-S01-T03.jsonl'),
-      '(a) file 003 survives (recent, also highest-seq)',
-    );
-  }
-
-  // ─── (b) Highest-seq preserved even when all files are old ───────────────
-  console.log('\n── (b) Highest-seq preserved even when all files are old');
-
-  {
-    const dir = createTmpActivityDir();
-    const f001 = writeActivityFile(dir, '001', 'execute-task-M001-S01-T01');
-    const f002 = writeActivityFile(dir, '002', 'execute-task-M001-S01-T02');
-    const f003 = writeActivityFile(dir, '003', 'execute-task-M001-S01-T03');
-
-    backdateFile(f001, 40);
-    backdateFile(f002, 40);
-    backdateFile(f003, 40); // all old, but 003 is highest-seq
-
-    pruneActivityLogs(dir, 30);
-
-    const remaining = listFiles(dir);
-    assertEq(remaining.length, 1, '(b) exactly 1 file survives when all are old');
-    assertTrue(
-      remaining.includes('003-execute-task-M001-S01-T03.jsonl'),
-      '(b) highest-seq file (003) is the survivor',
-    );
-  }
-
-  // ─── (c) retentionDays=0 boundary ────────────────────────────────────────
-  console.log('\n── (c) retentionDays=0: all non-highest-seq deleted even if brand-new');
-
-  {
-    const dir = createTmpActivityDir();
-    // All files have mtime=now (freshly written — no backdating)
-    writeActivityFile(dir, '001', 'execute-task-M002-S01-T01');
-    writeActivityFile(dir, '002', 'execute-task-M002-S01-T02');
-    writeActivityFile(dir, '003', 'execute-task-M002-S01-T03');
-
-    pruneActivityLogs(dir, 0); // cutoff = now → everything is "expired"
-
-    const remaining = listFiles(dir);
-    assertEq(remaining.length, 1, '(c) retentionDays=0: exactly 1 file survives');
-    assertTrue(
-      remaining.includes('003-execute-task-M002-S01-T03.jsonl'),
-      '(c) retentionDays=0: only highest-seq (003) survives',
-    );
-  }
-
-  // ─── (d) No-op when all files are recent ─────────────────────────────────
-  console.log('\n── (d) No-op when all files are recent');
-
-  {
-    const dir = createTmpActivityDir();
-    writeActivityFile(dir, '001', 'execute-task-M003-S01-T01');
-    writeActivityFile(dir, '002', 'execute-task-M003-S01-T02');
-    writeActivityFile(dir, '003', 'execute-task-M003-S01-T03');
-    // No backdating — all files are fresh
-
-    pruneActivityLogs(dir, 30);
-
-    const remaining = listFiles(dir);
-    assertEq(remaining.length, 3, '(d) all 3 files survive when all are recent');
-  }
-
-  // ─── (e) Empty directory: no crash ────────────────────────────────────────
-  console.log('\n── (e) Empty directory: no crash');
-
-  {
-    const dir = createTmpActivityDir();
-    // dir exists but is empty
-
-    let threw = false;
-    try {
-      pruneActivityLogs(dir, 30);
-    } catch {
-      threw = true;
-    }
-
-    assertTrue(!threw, '(e) pruneActivityLogs does not throw on empty directory');
-    assertTrue(
-      readdirSync(dir).length === 0,
-      '(e) directory still exists and is still empty after no-op',
-    );
-  }
-
-  // ─── (f) All old files: only highest-seq survives ─────────────────────────
-  console.log('\n── (f) All old files: only highest-seq survives');
-
-  {
-    const dir = createTmpActivityDir();
-    const f004 = writeActivityFile(dir, '004', 'execute-task-M004-S01-T01');
-    const f005 = writeActivityFile(dir, '005', 'execute-task-M004-S01-T02');
-    const f006 = writeActivityFile(dir, '006', 'execute-task-M004-S01-T03');
-
-    backdateFile(f004, 60);
-    backdateFile(f005, 60);
-    backdateFile(f006, 60);
-
-    pruneActivityLogs(dir, 30);
-
-    const remaining = listFiles(dir);
-    assertEq(remaining.length, 1, '(f) exactly 1 file survives when all are old');
-    assertTrue(
-      remaining[0].startsWith('006-'),
-      '(f) the surviving file starts with 006 (highest-seq)',
-    );
-  }
-
-  // ─── (g) Single file: always preserved ────────────────────────────────────
-  console.log('\n── (g) Single file: always preserved (it IS highest-seq)');
-
-  {
-    const dir = createTmpActivityDir();
-    const f001 = writeActivityFile(dir, '001', 'execute-task-M005-S01-T01');
-    backdateFile(f001, 100); // very old
-
-    pruneActivityLogs(dir, 30);
-
-    const remaining = listFiles(dir);
-    assertEq(remaining.length, 1, '(g) single file survives even when very old (it is the highest-seq)');
-    assertTrue(
-      remaining.includes('001-execute-task-M005-S01-T01.jsonl'),
-      '(g) the single file (001) is preserved',
-    );
-  }
-
-  // ─── (h) Seq tie-breaker: 010 is higher than 001 ─────────────────────────
-  console.log('\n── (h) Seq number tie-breaker: 010 beats 001 numerically');
-
-  {
-    const dir = createTmpActivityDir();
-    const f001 = writeActivityFile(dir, '001', 'execute-task-M006-S01-T01');
-    const f010 = writeActivityFile(dir, '010', 'execute-task-M006-S01-T10');
-
-    backdateFile(f001, 40);
-    backdateFile(f010, 40); // both old; 010 is numerically highest
-
-    pruneActivityLogs(dir, 30);
-
-    const remaining = listFiles(dir);
-    assertEq(remaining.length, 1, '(h) exactly 1 file survives');
-    assertTrue(
-      remaining.includes('010-execute-task-M006-S01-T10.jsonl'),
-      '(h) seq 010 (numeric 10) survives over seq 001 (numeric 1)',
-    );
-  }
-
-  // ─── (i) Non-matching filenames ignored ───────────────────────────────────
-  console.log('\n── (i) Non-matching filenames ignored: notes.txt survives, no crash');
-
-  {
-    const dir = createTmpActivityDir();
-    const f001 = writeActivityFile(dir, '001', 'execute-task-M007-S01-T01');
-    const notesPath = join(dir, 'notes.txt');
-    writeFileSync(notesPath, 'some notes\n', 'utf-8');
-
-    backdateFile(f001, 40); // eligible for pruning
-    // notes.txt never gets a seq prefix → should be ignored by pruner
-
-    let threw = false;
-    try {
-      pruneActivityLogs(dir, 30);
-    } catch {
-      threw = true;
-    }
-
-    assertTrue(!threw, '(i) no crash when non-matching file is present');
-
-    const remaining = listFiles(dir);
-    assertTrue(
-      remaining.includes('notes.txt'),
-      '(i) notes.txt (non-matching filename) survives pruning unchanged',
-    );
-    // 001 is deleted (old, and notes.txt is not counted as seq-bearing so 001 is not "highest")
-    // But wait — 001 IS the only seq file, making it highest-seq → it survives
-    assertTrue(
-      remaining.includes('001-execute-task-M007-S01-T01.jsonl'),
-      '(i) seq 001 survives (it is the highest-seq among seq files)',
-    );
-  }
-
-  // ─── (j) Step-11 prompt text assertion ────────────────────────────────────
-  console.log('\n── (j) Step-11 prompt text: "refresh current state if needed"');
-
-  {
-    const { readFileSync } = await import('node:fs');
-    const promptPath = join(__dirname, '..', 'prompts', 'complete-slice.md');
-    const content = readFileSync(promptPath, 'utf-8');
-
-    assertTrue(
-      content.includes('refresh current state if needed'),
-      '(j) complete-slice.md step 11 contains "refresh current state if needed"',
-    );
-  }
-
-  report();
-}
-
-main().catch((error) => {
-  console.error(error);
-  process.exit(1);
-});

package/dist/resources/extensions/gsd/tests/activity-log-save.test.ts

@@ -1,127 +0,0 @@
-// Tests for saveActivityLog performance behavior:
-// - cache next sequence per activity directory instead of rescanning every save
-// - skip rewriting identical snapshots for the same unit
-// - recover safely if another writer creates the cached next sequence
-
-import { existsSync, mkdtempSync, readdirSync, rmSync, writeFileSync } from "node:fs";
-import { tmpdir } from "node:os";
-import { join } from "node:path";
-
-import { saveActivityLog } from "../activity-log.ts";
-import { createTestContext } from "./test-helpers.ts";
-
-const { assertEq, assertTrue, report } = createTestContext();
-
-let tmpDirs: string[] = [];
-
-function createBaseDir(): string {
-  const dir = mkdtempSync(join(tmpdir(), "gsd-activity-save-test-"));
-  tmpDirs.push(dir);
-  return dir;
-}
-
-function activityDir(baseDir: string): string {
-  return join(baseDir, ".gsd", "activity");
-}
-
-function listActivityFiles(baseDir: string): string[] {
-  const dir = activityDir(baseDir);
-  return existsSync(dir) ? readdirSync(dir).sort() : [];
-}
-
-function createCtx(entries: unknown[]) {
-  return {
-    sessionManager: {
-      getEntries: () => entries,
-    },
-  };
-}
-
-function cleanup(): void {
-  for (const dir of tmpDirs) {
-    rmSync(dir, { recursive: true, force: true });
-  }
-  tmpDirs = [];
-}
-
-process.on("exit", cleanup);
-
-async function main(): Promise<void> {
-  console.log("\n── (a) cache next sequence instead of rescanning every save");
-  {
-    const baseDir = createBaseDir();
-    saveActivityLog(createCtx([{ kind: "first", n: 1 }]) as any, baseDir, "execute-task", "M001/S01/T01");
-
-    writeFileSync(
-      join(activityDir(baseDir), "999-external-manual.jsonl"),
-      '{"external":true}\n',
-      "utf-8",
-    );
-
-    saveActivityLog(createCtx([{ kind: "second", n: 2 }]) as any, baseDir, "execute-task", "M001/S01/T02");
-
-    const files = listActivityFiles(baseDir);
-    assertTrue(files.includes("001-execute-task-M001-S01-T01.jsonl"), "(a) first save uses sequence 001");
-    assertTrue(files.includes("002-execute-task-M001-S01-T02.jsonl"), "(a) second save uses cached next sequence 002");
-    assertTrue(files.includes("999-external-manual.jsonl"), "(a) externally added file remains present");
-    assertTrue(!files.some(file => file.startsWith("1000-")), "(a) second save did not rescan and jump to sequence 1000");
-  }
-
-  console.log("\n── (b) skip rewriting identical snapshots for the same unit");
-  {
-    const baseDir = createBaseDir();
-    const ctx = createCtx([{ role: "assistant", content: "same snapshot" }]);
-
-    saveActivityLog(ctx as any, baseDir, "plan-slice", "M002/S01");
-    saveActivityLog(ctx as any, baseDir, "plan-slice", "M002/S01");
-
-    let files = listActivityFiles(baseDir);
-    assertEq(files.length, 1, "(b) identical repeated save writes only one activity file");
-    assertTrue(files[0] === "001-plan-slice-M002-S01.jsonl", "(b) the original sequence is preserved");
-
-    saveActivityLog(createCtx([{ role: "assistant", content: "changed snapshot" }]) as any, baseDir, "plan-slice", "M002/S01");
-    files = listActivityFiles(baseDir);
-    assertEq(files.length, 2, "(b) changed snapshot writes a new activity file");
-    assertTrue(files.includes("002-plan-slice-M002-S01.jsonl"), "(b) deduped save did not consume the next sequence");
-  }
-
-  console.log("\n── (c) recover if another writer creates the exact cached target file");
-  {
-    const baseDir = createBaseDir();
-    saveActivityLog(createCtx([{ turn: 1 }]) as any, baseDir, "execute-task", "M003/S02/T01");
-
-    writeFileSync(
-      join(activityDir(baseDir), "002-execute-task-M003-S02-T02.jsonl"),
-      '{"collision":true}\n',
-      "utf-8",
-    );
-
-    saveActivityLog(createCtx([{ turn: 2 }]) as any, baseDir, "execute-task", "M003/S02/T02");
-
-    const files = listActivityFiles(baseDir);
-    assertTrue(files.includes("002-execute-task-M003-S02-T02.jsonl"), "(c) exact collision file is preserved");
-    assertTrue(files.includes("003-execute-task-M003-S02-T02.jsonl"), "(c) logger rescans only on collision and advances to 003");
-  }
-
-  console.log("\n── (d) dedupe is tracked per unit, not just the last write in the directory");
-  {
-    const baseDir = createBaseDir();
-    const repeatedCtx = createCtx([{ role: "assistant", content: "same-for-unit-a" }]);
-
-    saveActivityLog(repeatedCtx as any, baseDir, "execute-task", "M004/S01/T01");
-    saveActivityLog(createCtx([{ role: "assistant", content: "other-unit" }]) as any, baseDir, "execute-task", "M004/S01/T02");
-    saveActivityLog(repeatedCtx as any, baseDir, "execute-task", "M004/S01/T01");
-
-    const files = listActivityFiles(baseDir);
-    assertEq(files.length, 2, "(d) interleaving another unit does not force a duplicate rewrite for unit A");
-    assertTrue(files.includes("001-execute-task-M004-S01-T01.jsonl"), "(d) original unit A snapshot is retained");
-    assertTrue(files.includes("002-execute-task-M004-S01-T02.jsonl"), "(d) unit B snapshot is retained");
-  }
-
-  report();
-}
-
-main().catch((error) => {
-  console.error(error);
-  process.exit(1);
-});