gsd-pi 2.28.0 → 2.29.0-dev.23d50d0

package/src/resources/skills/userinterface-wiki/rules/visual-no-pure-black-shadow.md

@@ -0,0 +1,25 @@
+---
+title: Use Neutral Colors for Shadows, Not Pure Black
+impact: MEDIUM
+tags: visual, shadow, color, neutral
+---
+
+## Use Neutral Colors for Shadows, Not Pure Black
+
+Pure black shadows look harsh and artificial. Use deep neutrals or semi-transparent dark colors.
+
+**Incorrect (pure black):**
+
+```css
+.card {
+  box-shadow: 0 4px 12px rgba(0, 0, 0, 0.25);
+}
+```
+
+**Correct (neutral shadow):**
+
+```css
+.card {
+  box-shadow: 0 4px 12px rgba(17, 24, 39, 0.08);
+}
+```

package/src/resources/skills/userinterface-wiki/rules/visual-shadow-direction.md

@@ -0,0 +1,25 @@
+---
+title: Consistent Shadow Direction Across UI
+impact: HIGH
+tags: visual, shadow, direction, light-source
+---
+
+## Consistent Shadow Direction Across UI
+
+All shadows must share the same offset direction to imply a single light source. Mixed directions feel broken.
+
+**Incorrect (conflicting light sources):**
+
+```css
+.card { box-shadow: 0 4px 8px rgba(0, 0, 0, 0.1); }
+.modal { box-shadow: 4px 0 8px rgba(0, 0, 0, 0.1); }
+.tooltip { box-shadow: 0 -4px 8px rgba(0, 0, 0, 0.1); }
+```
+
+**Correct (consistent top-down light):**
+
+```css
+.card { box-shadow: 0 2px 8px rgba(0, 0, 0, 0.08); }
+.modal { box-shadow: 0 8px 24px rgba(0, 0, 0, 0.12); }
+.tooltip { box-shadow: 0 4px 12px rgba(0, 0, 0, 0.1); }
+```

package/src/resources/skills/userinterface-wiki/rules/visual-shadow-matches-elevation.md

@@ -0,0 +1,23 @@
+---
+title: Shadow Size Indicates Elevation
+impact: MEDIUM
+tags: visual, shadow, elevation, hierarchy
+---
+
+## Shadow Size Indicates Elevation
+
+Larger blur and offset means higher elevation. Use a consistent shadow scale across your UI.
+
+**Correct (elevation scale):**
+
+```css
+:root {
+  --shadow-1: 0 1px 2px rgba(0, 0, 0, 0.05);
+  --shadow-2: 0 2px 8px rgba(0, 0, 0, 0.08);
+  --shadow-3: 0 8px 24px rgba(0, 0, 0, 0.12);
+}
+
+.card { box-shadow: var(--shadow-1); }
+.dropdown { box-shadow: var(--shadow-2); }
+.modal { box-shadow: var(--shadow-3); }
+```

package/src/resources/skills/userinterface-wiki/rules/weight-duration-matches-action.md

@@ -0,0 +1,29 @@
+---
+title: Sound Duration Matches Action Duration
+impact: MEDIUM
+tags: weight, duration, action
+---
+
+## Sound Duration Matches Action Duration
+
+Sound duration should match action duration.
+
+**Incorrect (long sound for instant action):**
+
+```tsx
+function handleClick() {
+  playSound("long-whoosh"); // 2000ms
+}
+```
+
+**Correct (matched duration):**
+
+```tsx
+function handleClick() {
+  playSound("click"); // 50ms
+}
+
+function handleUpload() {
+  playSound("upload-progress"); // Matches upload duration
+}
+```

package/src/resources/skills/userinterface-wiki/rules/weight-match-action.md

@@ -0,0 +1,32 @@
+---
+title: Match Sound Weight to Action
+impact: MEDIUM
+tags: weight, action, importance
+---
+
+## Match Sound Weight to Action
+
+Sound weight should match action importance.
+
+**Incorrect (fanfare for toggle):**
+
+```tsx
+function handleToggle() {
+  playSound("triumphant-fanfare");
+  setEnabled(!enabled);
+}
+```
+
+**Correct (weight matches action):**
+
+```tsx
+function handleToggle() {
+  playSound("soft-click");
+  setEnabled(!enabled);
+}
+
+function handlePurchase() {
+  playSound("success-chime");
+  completePurchase();
+}
+```

package/src/resources/skills/web-design-guidelines/SKILL.md

@@ -0,0 +1,39 @@
+---
+name: web-design-guidelines
+description: Review UI code for Web Interface Guidelines compliance. Use when asked to "review my UI", "check accessibility", "audit design", "review UX", or "check my site against best practices".
+metadata:
+  author: vercel
+  version: "1.0.0"
+  argument-hint: <file-or-pattern>
+---
+
+# Web Interface Guidelines
+
+Review files for compliance with Web Interface Guidelines.
+
+## How It Works
+
+1. Fetch the latest guidelines from the source URL below
+2. Read the specified files (or prompt user for files/pattern)
+3. Check against all rules in the fetched guidelines
+4. Output findings in the terse `file:line` format
+
+## Guidelines Source
+
+Fetch fresh guidelines before each review:
+
+```
+https://raw.githubusercontent.com/vercel-labs/web-interface-guidelines/main/command.md
+```
+
+Use WebFetch to retrieve the latest rules. The fetched content contains all the rules and output format instructions.
+
+## Usage
+
+When a user provides a file or pattern argument:
+1. Fetch guidelines from the source URL above
+2. Read the specified files
+3. Apply all rules from the fetched guidelines
+4. Output findings using the format specified in the guidelines
+
+If no files specified, ask the user which files to review.

package/src/resources/skills/web-quality-audit/SKILL.md

@@ -0,0 +1,170 @@
+---
+name: web-quality-audit
+description: Comprehensive web quality audit covering performance, accessibility, SEO, and best practices. Use when asked to "audit my site", "review web quality", "run lighthouse audit", "check page quality", or "optimize my website".
+license: MIT
+metadata:
+  author: web-quality-skills
+  version: "1.0"
+---
+
+# Web quality audit
+
+Comprehensive quality review based on Google Lighthouse audits. Covers Performance, Accessibility, SEO, and Best Practices across 150+ checks.
+
+## How it works
+
+1. Analyze the provided code/project for quality issues
+2. Categorize findings by severity (Critical, High, Medium, Low)
+3. Provide specific, actionable recommendations
+4. Include code examples for fixes
+
+## Audit categories
+
+### Performance (40% of typical issues)
+
+**Core Web Vitals** — Must pass for good page experience:
+* **LCP (Largest Contentful Paint) < 2.5s.** The largest visible element must render quickly. Optimize images, fonts, and server response time.
+* **INP (Interaction to Next Paint) < 200ms.** User interactions must feel instant. Reduce JavaScript execution time and break up long tasks.
+* **CLS (Cumulative Layout Shift) < 0.1.** Content must not jump around. Set explicit dimensions on images, embeds, and ads.
+
+**Resource Optimization:**
+* **Compress images.** Use WebP/AVIF with fallbacks. Serve correctly sized images via `srcset`.
+* **Minimize JavaScript.** Remove unused code. Use code splitting. Defer non-critical scripts.
+* **Optimize CSS.** Extract critical CSS. Remove unused styles. Avoid `@import`.
+* **Efficient fonts.** Use `font-display: swap`. Preload critical fonts. Subset to needed characters.
+
+**Loading Strategy:**
+* **Preconnect to origins.** Add `<link rel="preconnect">` for third-party domains.
+* **Preload critical assets.** LCP images, fonts, and above-fold CSS.
+* **Lazy load below-fold content.** Images, iframes, and heavy components.
+* **Cache effectively.** Long cache TTLs for static assets. Immutable caching for hashed files.
+
+### Accessibility (30% of typical issues)
+
+**Perceivable:**
+* **Text alternatives.** Every `<img>` has meaningful `alt` text. Decorative images use `alt=""`.
+* **Color contrast.** Minimum 4.5:1 for normal text, 3:1 for large text (WCAG AA).
+* **Don't rely on color alone.** Use icons, patterns, or text alongside color indicators.
+* **Captions and transcripts.** Video has captions. Audio has transcripts.
+
+**Operable:**
+* **Keyboard accessible.** All functionality available via keyboard. No keyboard traps.
+* **Focus visible.** Clear focus indicators on all interactive elements.
+* **Skip links.** Provide "Skip to main content" for keyboard users.
+* **Sufficient time.** Users can extend time limits. No auto-advancing content without controls.
+
+**Understandable:**
+* **Page language.** Set `lang` attribute on `<html>`.
+* **Consistent navigation.** Same navigation structure across pages.
+* **Error identification.** Form errors clearly described and associated with fields.
+* **Labels and instructions.** All form inputs have associated labels.
+
+**Robust:**
+* **Valid HTML.** No duplicate IDs. Properly nested elements.
+* **ARIA used correctly.** Prefer native elements. ARIA roles match behavior.
+* **Name, role, value.** Interactive elements have accessible names and correct roles.
+
+### SEO (15% of typical issues)
+
+**Crawlability:**
+* **Valid robots.txt.** Doesn't block important resources.
+* **XML sitemap.** Lists all important pages. Submitted to Search Console.
+* **Canonical URLs.** Prevent duplicate content issues.
+* **No noindex on important pages.** Check meta robots and headers.
+
+**On-Page SEO:**
+* **Unique title tags.** 50-60 characters. Primary keyword included.
+* **Meta descriptions.** 150-160 characters. Compelling and unique.
+* **Heading hierarchy.** Single `<h1>`. Logical heading structure.
+* **Descriptive link text.** Not "click here" or "read more".
+
+**Technical SEO:**
+* **Mobile-friendly.** Responsive design. Tap targets ≥ 48px.
+* **HTTPS.** Secure connection required.
+* **Fast loading.** Performance directly impacts ranking.
+* **Structured data.** JSON-LD for rich snippets (Article, Product, FAQ, etc.).
+
+### Best practices (15% of typical issues)
+
+**Security:**
+* **HTTPS everywhere.** No mixed content. HSTS enabled.
+* **No vulnerable libraries.** Keep dependencies updated.
+* **CSP headers.** Content Security Policy to prevent XSS.
+* **No exposed source maps.** In production builds.
+
+**Modern Standards:**
+* **No deprecated APIs.** Replace `document.write`, synchronous XHR, etc.
+* **Valid doctype.** Use `<!DOCTYPE html>`.
+* **Charset declared.** `<meta charset="UTF-8">` as first element in `<head>`.
+* **No browser errors.** Clean console. No CORS issues.
+
+**UX Patterns:**
+* **No intrusive interstitials.** Especially on mobile.
+* **Clear permission requests.** Only ask when needed, with context.
+* **No misleading buttons.** Buttons do what they say.
+
+## Severity levels
+
+| Level | Description | Action |
+|-------|-------------|--------|
+| **Critical** | Security vulnerabilities, complete failures | Fix immediately |
+| **High** | Core Web Vitals failures, major a11y barriers | Fix before launch |
+| **Medium** | Performance opportunities, SEO improvements | Fix within sprint |
+| **Low** | Minor optimizations, code quality | Fix when convenient |
+
+## Audit output format
+
+When performing an audit, structure findings as:
+
+```markdown
+## Audit results
+
+### Critical issues (X found)
+- **[Category]** Issue description. File: `path/to/file.js:123`
+  - **Impact:** Why this matters
+  - **Fix:** Specific code change or recommendation
+
+### High priority (X found)
+...
+
+### Summary
+- Performance: X issues (Y critical)
+- Accessibility: X issues (Y critical)
+- SEO: X issues
+- Best Practices: X issues
+
+### Recommended priority
+1. First fix this because...
+2. Then address...
+3. Finally optimize...
+```
+
+## Quick checklist
+
+### Before every deploy
+- [ ] Core Web Vitals passing
+- [ ] No accessibility errors (axe/Lighthouse)
+- [ ] No console errors
+- [ ] HTTPS working
+- [ ] Meta tags present
+
+### Weekly review
+- [ ] Check Search Console for issues
+- [ ] Review Core Web Vitals trends
+- [ ] Update dependencies
+- [ ] Test with screen reader
+
+### Monthly deep dive
+- [ ] Full Lighthouse audit
+- [ ] Performance profiling
+- [ ] Accessibility audit with real users
+- [ ] SEO keyword review
+
+## References
+
+For detailed guidelines on specific areas:
+- [Performance Optimization](../performance/SKILL.md)
+- [Core Web Vitals](../core-web-vitals/SKILL.md)
+- [Accessibility](../accessibility/SKILL.md)
+- [SEO](../seo/SKILL.md)
+- [Best Practices](../best-practices/SKILL.md)

package/src/resources/skills/web-quality-audit/scripts/analyze.sh

@@ -0,0 +1,91 @@
+#!/bin/bash
+set -e
+
+# Web Quality Audit Script
+# Analyzes HTML files for common quality issues
+
+usage() {
+  echo "Usage: $0 <file_or_directory>" >&2
+  echo "Analyzes HTML files for web quality issues." >&2
+  exit 1
+}
+
+if [ -z "$1" ]; then
+  usage
+fi
+
+TARGET="$1"
+ISSUES=()
+WARNINGS=()
+
+analyze_html() {
+  local file="$1"
+  echo "Analyzing: $file" >&2
+
+  # Check for doctype
+  if ! grep -qi "<!doctype html>" "$file"; then
+    ISSUES+=("$file: Missing HTML5 doctype")
+  fi
+
+  # Check for charset
+  if ! grep -qi 'charset.*utf-8' "$file"; then
+    WARNINGS+=("$file: Missing or non-UTF-8 charset declaration")
+  fi
+
+  # Check for viewport
+  if ! grep -qi 'name="viewport"' "$file"; then
+    ISSUES+=("$file: Missing viewport meta tag")
+  fi
+
+  # Check for lang attribute
+  if ! grep -qi '<html.*lang=' "$file"; then
+    ISSUES+=("$file: Missing lang attribute on <html>")
+  fi
+
+  # Check for images without alt
+  if grep -qE '<img[^>]*>' "$file" && grep -qE '<img(?![^>]*alt=)[^>]*>' "$file" 2>/dev/null; then
+    WARNINGS+=("$file: Possible images without alt text")
+  fi
+
+  # Check for title tag
+  if ! grep -qi '<title>' "$file"; then
+    ISSUES+=("$file: Missing <title> tag")
+  fi
+
+  # Check for HTTPS in links
+  if grep -qE 'http://' "$file"; then
+    WARNINGS+=("$file: Contains non-HTTPS URLs")
+  fi
+}
+
+# Process files
+if [ -d "$TARGET" ]; then
+  find "$TARGET" -name "*.html" -o -name "*.htm" | while read -r file; do
+    analyze_html "$file"
+  done
+elif [ -f "$TARGET" ]; then
+  analyze_html "$TARGET"
+else
+  echo "Error: $TARGET is not a valid file or directory" >&2
+  exit 1
+fi
+
+# Output results as JSON
+echo '{'
+echo '  "issues": ['
+for i in "${!ISSUES[@]}"; do
+  if [ $i -gt 0 ]; then echo ','; fi
+  echo -n "    \"${ISSUES[$i]}\""
+done
+echo ''
+echo '  ],'
+echo '  "warnings": ['
+for i in "${!WARNINGS[@]}"; do
+  if [ $i -gt 0 ]; then echo ','; fi
+  echo -n "    \"${WARNINGS[$i]}\""
+done
+echo ''
+echo '  ],'
+echo "  \"issueCount\": ${#ISSUES[@]},"
+echo "  \"warningCount\": ${#WARNINGS[@]}"
+echo '}'

package/dist/resources/extensions/gsd/complexity.ts

@@ -1,237 +0,0 @@
-/**
- * GSD Task Complexity Classification
- *
- * Classifies task plans and unit types by complexity to enable model routing.
- * Pure heuristics + adaptive learning — no LLM calls, sub-millisecond.
- *
- * Combined approach:
- * - Task plan analysis (step count, file count, description length, signal words)
- * - Unit type defaults (complete-slice → light, replan → heavy, etc.)
- * - Budget pressure thresholds (50/75/90% graduated downgrade)
- * - Adaptive learning via routing-history (optional)
- *
- * Classification output uses our TokenProfile-aligned TaskComplexity type
- * for the simple classifier, and ComplexityTier for the full unit classifier.
- */
-
-import { existsSync, readFileSync } from "node:fs";
-import { join } from "node:path";
-import type { ComplexityTier, ClassificationResult, TaskMetadata } from "./types.js";
-
-// Re-export for convenience
-export type { ComplexityTier, ClassificationResult, TaskMetadata };
-
-// ─── Simple Task Complexity (for task plan analysis) ──────────────────────
-
-export type TaskComplexity = "simple" | "standard" | "complex";
-
-/** Words that signal non-trivial work requiring full reasoning capacity */
-const COMPLEXITY_SIGNALS = [
-  "research", "investigate", "refactor", "migrate", "integrate",
-  "complex", "architect", "redesign", "security", "performance",
-  "concurrent", "parallel", "distributed", "backward.?compat",
-  "migration", "architecture", "concurrency", "compatibility",
-];
-const COMPLEXITY_PATTERN = new RegExp(COMPLEXITY_SIGNALS.join("|"), "i");
-
-/**
- * Classify a task plan by its structural complexity.
- * Used by dispatch to select execution_simple vs execution model.
- */
-export function classifyTaskComplexity(planContent: string): TaskComplexity {
-  if (!planContent || planContent.trim().length === 0) return "standard";
-
-  const stepsMatch = planContent.match(/##\s*Steps\s*\n([\s\S]*?)(?=\n##|\n---|$)/i);
-  const stepsSection = stepsMatch?.[1] ?? "";
-  const stepCount = (stepsSection.match(/^\s*\d+\.\s/gm) ?? []).length;
-
-  if (!stepsMatch) return "standard";
-
-  const stepsIdx = planContent.search(/##\s*Steps/i);
-  const descriptionLength = stepsIdx > 0 ? planContent.slice(0, stepsIdx).length : planContent.length;
-
-  const filePatterns = planContent.match(/`[a-zA-Z0-9_/.-]+\.[a-z]{1,4}`/g) ?? [];
-  const uniqueFiles = new Set(filePatterns.map(f => f.replace(/`/g, "")));
-  const fileCount = uniqueFiles.size;
-
-  const hasComplexitySignals = COMPLEXITY_PATTERN.test(planContent);
-
-  // Count fenced code blocks (from #579 Phase 4)
-  const codeBlockCount = (planContent.match(/^```/gm) ?? []).length / 2;
-
-  if (stepCount >= 8 || fileCount >= 8 || descriptionLength > 2000 || codeBlockCount >= 5) {
-    return "complex";
-  }
-
-  if (stepCount <= 3 && descriptionLength < 500 && fileCount <= 3 && !hasComplexitySignals) {
-    return "simple";
-  }
-
-  return "standard";
-}
-
-// ─── Unit Type → Default Tier Mapping (from #579) ─────────────────────────
-
-const UNIT_TYPE_TIERS: Record<string, ComplexityTier> = {
-  // Light: structured summaries, completion, UAT
-  "complete-slice": "light",
-  "run-uat": "light",
-
-  // Standard: research, routine planning
-  "research-milestone": "standard",
-  "research-slice": "standard",
-  "plan-milestone": "standard",
-  "plan-slice": "standard",
-
-  // Heavy: execution default (upgraded by metadata), replanning
-  "execute-task": "standard",
-  "replan-slice": "heavy",
-  "reassess-roadmap": "heavy",
-  "validate-milestone": "heavy",
-  "complete-milestone": "standard",
-};
-
-/**
- * Classify unit complexity for model routing.
- * Uses unit type defaults, task metadata analysis, and budget pressure.
- *
- * @param unitType  The type of unit being dispatched
- * @param unitId    The unit ID (e.g. "M001/S01/T01")
- * @param basePath  Project base path (for reading task plans)
- * @param budgetPct Current budget usage as fraction (0.0-1.0+), or undefined
- * @param metadata  Optional pre-parsed task metadata
- */
-export function classifyUnitComplexity(
-  unitType: string,
-  unitId: string,
-  basePath: string,
-  budgetPct?: number,
-  metadata?: TaskMetadata,
-): ClassificationResult {
-  // Hook units default to light
-  if (unitType.startsWith("hook/")) {
-    return applyBudgetPressure({ tier: "light", reason: "hook unit", downgraded: false }, budgetPct);
-  }
-
-  // Triage/capture units default to light
-  if (unitType === "triage-captures" || unitType.startsWith("quick-task")) {
-    return applyBudgetPressure({ tier: "light", reason: `${unitType} unit`, downgraded: false }, budgetPct);
-  }
-
-  let tier = UNIT_TYPE_TIERS[unitType] ?? "standard";
-  let reason = `unit type: ${unitType}`;
-
-  // For execute-task, analyze task metadata for complexity signals
-  if (unitType === "execute-task") {
-    const analysis = analyzeTaskFromPlan(unitId, basePath, metadata);
-    if (analysis) {
-      tier = analysis.tier;
-      reason = analysis.reason;
-    }
-  }
-
-  return applyBudgetPressure({ tier, reason, downgraded: false }, budgetPct);
-}
-
-// ─── Tier Helpers ─────────────────────────────────────────────────────────
-
-export function tierLabel(tier: ComplexityTier): string {
-  switch (tier) {
-    case "light": return "L";
-    case "standard": return "S";
-    case "heavy": return "H";
-  }
-}
-
-export function tierOrdinal(tier: ComplexityTier): number {
-  switch (tier) {
-    case "light": return 0;
-    case "standard": return 1;
-    case "heavy": return 2;
-  }
-}
-
-export function escalateTier(currentTier: ComplexityTier): ComplexityTier | null {
-  switch (currentTier) {
-    case "light": return "standard";
-    case "standard": return "heavy";
-    case "heavy": return null;
-  }
-}
-
-// ─── Budget Pressure (from #579 — graduated thresholds) ───────────────────
-
-function applyBudgetPressure(
-  result: ClassificationResult,
-  budgetPct?: number,
-): ClassificationResult {
-  if (budgetPct === undefined || budgetPct < 0.5) return result;
-
-  const original = result.tier;
-
-  if (budgetPct >= 0.9) {
-    // >90%: almost everything goes to light
-    if (result.tier !== "heavy") {
-      result.tier = "light";
-    } else {
-      result.tier = "standard";
-    }
-  } else if (budgetPct >= 0.75) {
-    // 75-90%: only heavy stays, standard → light
-    if (result.tier === "standard") {
-      result.tier = "light";
-    }
-  } else {
-    // 50-75%: standard → light
-    if (result.tier === "standard") {
-      result.tier = "light";
-    }
-  }
-
-  if (result.tier !== original) {
-    result.downgraded = true;
-    result.reason = `${result.reason} (budget pressure: ${Math.round(budgetPct * 100)}%)`;
-  }
-
-  return result;
-}
-
-// ─── Task Plan Analysis ───────────────────────────────────────────────────
-
-interface TaskAnalysis {
-  tier: ComplexityTier;
-  reason: string;
-}
-
-function analyzeTaskFromPlan(
-  unitId: string,
-  basePath: string,
-  metadata?: TaskMetadata,
-): TaskAnalysis | null {
-  // Try to read the task plan for analysis
-  const parts = unitId.split("/");
-  if (parts.length < 3) return null;
-
-  const [mid, sid, tid] = parts;
-  const planPath = join(basePath, ".gsd", "milestones", mid, "slices", sid, "tasks", `${tid}-PLAN.md`);
-
-  let planContent = "";
-  try {
-    if (existsSync(planPath)) {
-      planContent = readFileSync(planPath, "utf-8");
-    }
-  } catch {
-    return null;
-  }
-
-  if (!planContent) return null;
-
-  const taskComplexity = classifyTaskComplexity(planContent);
-
-  // Map TaskComplexity to ComplexityTier
-  switch (taskComplexity) {
-    case "simple": return { tier: "light", reason: "task plan: simple (few steps, small scope)" };
-    case "complex": return { tier: "heavy", reason: "task plan: complex (many steps/files or signal words)" };
-    default: return { tier: "standard", reason: "task plan: standard complexity" };
-  }
-}