gsd-pi 2.28.0-dev.853dfc5 → 2.28.0-dev.a8d3050

package/src/resources/extensions/gsd/unit-runtime.ts

@@ -1,4 +1,4 @@
-import { existsSync, mkdirSync, readdirSync, readFileSync, writeFileSync, unlinkSync } from "node:fs";
+import { existsSync, readdirSync, readFileSync, unlinkSync } from "node:fs";
 import { join } from "node:path";
 import {
   gsdRoot,
@@ -8,6 +8,7 @@ import {
   resolveTaskFile,
 } from "./paths.js";
 import { loadFile, parseTaskPlanMustHaves, countMustHavesMentionedInSummary } from "./files.js";
+import { loadJsonFileOrNull, saveJsonFile } from "./json-persistence.js";
 
 export type UnitRuntimePhase =
   | "dispatched"
@@ -46,13 +47,23 @@ export interface AutoUnitRuntimeRecord {
   lastRecoveryReason?: "idle" | "hard";
 }
 
+function isAutoUnitRuntimeRecord(data: unknown): data is AutoUnitRuntimeRecord {
+  return (
+    typeof data === "object" &&
+    data !== null &&
+    (data as AutoUnitRuntimeRecord).version === 1 &&
+    typeof (data as AutoUnitRuntimeRecord).unitType === "string" &&
+    typeof (data as AutoUnitRuntimeRecord).unitId === "string"
+  );
+}
+
 function runtimeDir(basePath: string): string {
   return join(gsdRoot(basePath), "runtime", "units");
 }
 
 function runtimePath(basePath: string, unitType: string, unitId: string): string {
-  const sanitizedUnitType = unitType.replace(/[\/]/g, "-");
-  const sanitizedUnitId = unitId.replace(/[\/]/g, "-");
+  const sanitizedUnitType = unitType.replace(/[^a-zA-Z0-9._-]+/g, "-");
+  const sanitizedUnitId = unitId.replace(/[^a-zA-Z0-9._-]+/g, "-");
   return join(runtimeDir(basePath), `${sanitizedUnitType}-${sanitizedUnitId}.json`);
 }
 
@@ -63,8 +74,6 @@ export function writeUnitRuntimeRecord(
   startedAt: number,
   updates: Partial<AutoUnitRuntimeRecord> = {},
 ): AutoUnitRuntimeRecord {
-  const dir = runtimeDir(basePath);
-  mkdirSync(dir, { recursive: true });
   const path = runtimePath(basePath, unitType, unitId);
   const prev = readUnitRuntimeRecord(basePath, unitType, unitId);
   const next: AutoUnitRuntimeRecord = {
@@ -84,18 +93,12 @@ export function writeUnitRuntimeRecord(
     recoveryAttempts: updates.recoveryAttempts ?? prev?.recoveryAttempts ?? 0,
     lastRecoveryReason: updates.lastRecoveryReason ?? prev?.lastRecoveryReason,
   };
-  writeFileSync(path, JSON.stringify(next, null, 2) + "\n", "utf-8");
+  saveJsonFile(path, next);
   return next;
 }
 
 export function readUnitRuntimeRecord(basePath: string, unitType: string, unitId: string): AutoUnitRuntimeRecord | null {
-  const path = runtimePath(basePath, unitType, unitId);
-  if (!existsSync(path)) return null;
-  try {
-    return JSON.parse(readFileSync(path, "utf-8")) as AutoUnitRuntimeRecord;
-  } catch {
-    return null;
-  }
+  return loadJsonFileOrNull(runtimePath(basePath, unitType, unitId), isAutoUnitRuntimeRecord);
 }
 
 export function clearUnitRuntimeRecord(basePath: string, unitType: string, unitId: string): void {

package/src/resources/extensions/gsd/verification-evidence.ts

@@ -20,6 +20,7 @@ export interface EvidenceCheckJSON {
   exitCode: number;
   durationMs: number;
   verdict: "pass" | "fail";
+  blocking: boolean;
 }
 
 export interface RuntimeErrorJSON {
@@ -80,6 +81,7 @@ export function writeVerificationJSON(
       exitCode: check.exitCode,
       durationMs: check.durationMs,
       verdict: check.exitCode === 0 ? "pass" : "fail",
+      blocking: check.blocking,
     })),
     ...(retryAttempt !== undefined ? { retryAttempt } : {}),
     ...(maxRetries !== undefined ? { maxRetries } : {}),

package/src/resources/extensions/gsd/verification-gate.ts

@@ -112,7 +112,9 @@ const MAX_FAILURE_CONTEXT_CHARS = 10_000;
  * Returns an empty string when all checks pass or the checks array is empty.
  */
 export function formatFailureContext(result: VerificationResult): string {
-  const failures = result.checks.filter((c) => c.exitCode !== 0);
+  // Only include blocking failures in retry context — non-blocking (advisory) failures
+  // should not be injected into retry prompts to avoid noise pollution.
+  const failures = result.checks.filter((c) => c.exitCode !== 0 && c.blocking);
   if (failures.length === 0) return "";
 
   const blocks: string[] = [];
@@ -256,6 +258,10 @@ export function runVerificationGate(options: RunVerificationGateOptions): Verifi
     };
   }
 
+  // Commands from preference and task-plan sources are blocking;
+  // package-json discovered commands are advisory (non-blocking).
+  const blocking = source === "preference" || source === "task-plan";
+
   const checks: VerificationCheck[] = [];
 
   for (const command of commands) {
@@ -291,11 +297,16 @@ export function runVerificationGate(options: RunVerificationGateOptions): Verifi
       stdout: truncate(result.stdout, MAX_OUTPUT_BYTES),
       stderr,
       durationMs,
+      blocking,
     });
   }
 
+  // Gate passes if all blocking checks pass (non-blocking failures are advisory)
+  const blockingChecks = checks.filter(c => c.blocking);
+  const passed = blockingChecks.length === 0 || blockingChecks.every(c => c.exitCode === 0);
+
   return {
-    passed: checks.every(c => c.exitCode === 0),
+    passed,
     checks,
     discoverySource: source,
     timestamp,

package/src/resources/extensions/remote-questions/discord-adapter.ts

@@ -2,11 +2,11 @@
  * Remote Questions — Discord adapter
  */
 
-import type { ChannelAdapter, RemotePrompt, RemoteDispatchResult, RemoteAnswer, RemotePromptRef } from "./types.js";
+import { PER_REQUEST_TIMEOUT_MS, type ChannelAdapter, type RemotePrompt, type RemoteDispatchResult, type RemoteAnswer, type RemotePromptRef } from "./types.js";
 import { formatForDiscord, parseDiscordResponse, DISCORD_NUMBER_EMOJIS } from "./format.js";
 
 const DISCORD_API = "https://discord.com/api/v10";
-const PER_REQUEST_TIMEOUT_MS = 15_000;
+
 export class DiscordAdapter implements ChannelAdapter {
   readonly name = "discord" as const;
   private botUserId: string | null = null;

package/src/resources/extensions/remote-questions/notify.ts

@@ -9,8 +9,7 @@
 
 import { resolveRemoteConfig } from "./config.js";
 import type { ResolvedConfig } from "./config.js";
-
-const PER_REQUEST_TIMEOUT_MS = 15_000;
+import { PER_REQUEST_TIMEOUT_MS } from "./types.js";
 
 /**
  * Send a one-way notification to the configured remote channel.

package/src/resources/extensions/remote-questions/slack-adapter.ts

@@ -2,11 +2,10 @@
  * Remote Questions — Slack adapter
  */
 
-import type { ChannelAdapter, RemotePrompt, RemoteDispatchResult, RemoteAnswer, RemotePromptRef } from "./types.js";
+import { PER_REQUEST_TIMEOUT_MS, type ChannelAdapter, type RemotePrompt, type RemoteDispatchResult, type RemoteAnswer, type RemotePromptRef } from "./types.js";
 import { formatForSlack, parseSlackReply, parseSlackReactionResponse, SLACK_NUMBER_REACTION_NAMES } from "./format.js";
 
 const SLACK_API = "https://slack.com/api";
-const PER_REQUEST_TIMEOUT_MS = 15_000;
 const SLACK_ACK_REACTION = "white_check_mark";
 
 export class SlackAdapter implements ChannelAdapter {

package/src/resources/extensions/remote-questions/telegram-adapter.ts

@@ -2,11 +2,10 @@
  * Remote Questions — Telegram adapter
  */
 
-import type { ChannelAdapter, RemotePrompt, RemoteDispatchResult, RemoteAnswer, RemotePromptRef } from "./types.js";
+import { PER_REQUEST_TIMEOUT_MS, type ChannelAdapter, type RemotePrompt, type RemoteDispatchResult, type RemoteAnswer, type RemotePromptRef } from "./types.js";
 import { formatForTelegram, parseTelegramResponse } from "./format.js";
 
 const TELEGRAM_API = "https://api.telegram.org";
-const PER_REQUEST_TIMEOUT_MS = 15_000;
 
 export class TelegramAdapter implements ChannelAdapter {
   readonly name = "telegram" as const;

package/src/resources/extensions/remote-questions/types.ts

@@ -2,6 +2,9 @@
  * Remote Questions — shared types
  */
 
+/** Timeout applied to every outbound HTTP request across all channel adapters. */
+export const PER_REQUEST_TIMEOUT_MS = 15_000;
+
 export type RemoteChannel = "slack" | "discord" | "telegram";
 
 export interface RemoteQuestionOption {

package/src/resources/extensions/shared/mod.ts

@@ -28,3 +28,6 @@ export { showInterviewRound } from "./interview-ui.js";
 export type { Question, QuestionOption, RoundResult } from "./interview-ui.js";
 export { showNextAction } from "./next-action-ui.js";
 export { showConfirm } from "./confirm-ui.js";
+export { sanitizeError } from "./sanitize.js";
+export { formatDateShort, truncateWithEllipsis } from "./format-utils.js";
+export { splitFrontmatter, parseFrontmatterMap } from "./frontmatter.js";

package/dist/resources/extensions/gsd/preferences-hooks.ts

@@ -1,10 +0,0 @@
-/**
- * Focused re-export: hook-related preferences.
- *
- * Consumers that only need hook resolution can import from this module
- * instead of the monolithic preferences.ts, reducing coupling surface.
- */
-export {
-  resolvePostUnitHooks,
-  resolvePreDispatchHooks,
-} from "./preferences.js";

package/dist/resources/extensions/shared/progress-widget.ts

@@ -1,282 +0,0 @@
-/**
- * Shared persistent progress/status panel widget.
- *
- * Renders an ordered list of progress items with status glyphs, optional
- * badge, subtitle, metadata, and footer hints. Supports pulse animation
- * for active items during agent execution.
- *
- * Usage:
- *
- *   import { createProgressPanel } from "./shared/progress-widget.js";
- *
- *   const panel = createProgressPanel(ctx.ui, {
- *     widgetKey: "workflow",
- *     statusKey: "workflow",
- *     statusPrefix: "wf",
- *   });
- *
- *   panel.update(model);       // render/re-render with new model
- *   panel.startPulse();        // animate active items
- *   panel.stopPulse();         // stop animation
- *   panel.dispose();           // remove widget and status
- */
-
-import type { ExtensionUIContext, Theme } from "@gsd/pi-coding-agent";
-import type { TUI } from "@gsd/pi-tui";
-import { makeUI, type ProgressStatus } from "./ui.js";
-
-// ─── Exported types ───────────────────────────────────────────────────────────
-
-export type ProgressItemStatus = ProgressStatus;
-
-export interface ProgressItem {
-	/** Display label */
-	label: string;
-	/** Drives glyph and color */
-	status: ProgressItemStatus;
-	/** Optional text after label — e.g. artifact type, task ID */
-	detail?: string;
-	/** Optional secondary line below item — e.g. "waiting for /workflow-continue" */
-	annotation?: string;
-}
-
-export interface ProgressPanelModel {
-	/** Panel title */
-	title: string;
-	/** Optional badge next to title — e.g. "RUNNING", "PAUSED" */
-	badge?: string;
-	/** Badge color control — maps to ProgressItemStatus color */
-	badgeStatus?: ProgressItemStatus;
-	/** Optional subtitle lines below title */
-	subtitle?: string[];
-	/** Ordered progress items */
-	items: ProgressItem[];
-	/** Optional metadata lines below items */
-	meta?: string[];
-	/** Optional footer hint strings */
-	hints?: string[];
-}
-
-export interface ProgressPanelOptions {
-	/**
-	 * Widget key used with ctx.ui.setWidget(...).
-	 * Must be unique per extension.
-	 */
-	widgetKey: string;
-	/**
-	 * Status key used with ctx.ui.setStatus(...).
-	 * Must be unique per extension.
-	 */
-	statusKey: string;
-	/**
-	 * Short prefix for footer status text.
-	 * Example: "wf" produces "wf:2/3 RUNNING"
-	 */
-	statusPrefix: string;
-}
-
-export interface ProgressPanel {
-	/** Update the widget with a new model. Triggers re-render. */
-	update(model: ProgressPanelModel): void;
-	/** Start pulsing items with status "active". */
-	startPulse(): void;
-	/** Stop pulsing. Active items render at full brightness. */
-	stopPulse(): void;
-	/** Remove the widget and status from the UI. */
-	dispose(): void;
-}
-
-// ─── Internal constants ───────────────────────────────────────────────────────
-
-const PULSE_INTERVAL_MS = 500;
-
-// ─── Implementation ───────────────────────────────────────────────────────────
-
-/**
- * Create and register a persistent progress widget.
- *
- * @param ui       The `ctx.ui` object from ExtensionContext or ExtensionCommandContext
- * @param options  Widget key, status key, and status prefix
- * @returns        ProgressPanel controller
- */
-export function createProgressPanel(
-	ui: ExtensionUIContext,
-	options: ProgressPanelOptions,
-): ProgressPanel {
-	const { widgetKey, statusKey, statusPrefix } = options;
-
-	// ── Internal state ────────────────────────────────────────────────────────
-
-	let currentModel: ProgressPanelModel | null = null;
-	let stateVersion = 0;
-	let cachedLines: string[] | undefined;
-	let cachedWidth: number | undefined;
-	let cachedVersion = -1;
-	let pulseBright = true;
-	let pulseTimer: ReturnType<typeof setInterval> | null = null;
-	let widgetRef: { invalidate: () => void; requestRender: () => void } | null = null;
-
-	// ── Footer status ─────────────────────────────────────────────────────────
-
-	function updateFooterStatus(): void {
-		if (!currentModel) return;
-		const { items, badge } = currentModel;
-		const total = items.length;
-		let current = 0;
-
-		// Find first active item index (1-based)
-		const activeIdx = items.findIndex((it) => it.status === "active");
-		if (activeIdx >= 0) {
-			current = activeIdx + 1;
-		} else {
-			// Count done items + 1
-			current = items.filter((it) => it.status === "done").length + 1;
-		}
-		if (current > total) current = total;
-
-		const badgePart = badge ? ` ${badge}` : "";
-		const statusText = ui.theme.fg("accent", `${statusPrefix}:${current}/${total}${badgePart}`);
-		ui.setStatus(statusKey, statusText);
-	}
-
-	// ── Render function ───────────────────────────────────────────────────────
-
-	function renderPanel(width: number, theme: Theme): string[] {
-		// Version-based cache check
-		if (cachedLines && cachedWidth === width && cachedVersion === stateVersion) {
-			return cachedLines;
-		}
-
-		if (!currentModel) return [];
-
-		const uiHelper = makeUI(theme, width);
-		const lines: string[] = [];
-		const push = (...rows: string[][]) => { for (const r of rows) lines.push(...r); };
-		const model = currentModel;
-
-		// 1. Top bar
-		push(uiHelper.bar());
-
-		// 2. Title area — title with optional inline badge
-		if (model.badge && model.badgeStatus) {
-			const titleText = uiHelper.header(model.title)[0];
-			const badgeGlyph = uiHelper.statusGlyph(model.badgeStatus);
-			const badgeLabel = uiHelper.statusBadge(model.badge, model.badgeStatus)[0];
-			lines.push(`${titleText}  ${badgeGlyph} ${badgeLabel.trimStart()}`);
-		} else {
-			push(uiHelper.header(model.title));
-		}
-
-		// 3. Subtitle
-		if (model.subtitle?.length) {
-			for (const line of model.subtitle) {
-				push(uiHelper.meta(line));
-			}
-		}
-
-		// 4. Blank line
-		push(uiHelper.blank());
-
-		// 5. Items
-		for (const item of model.items) {
-			// Pulse: when pulseBright is false and item is active, render as pending (dimmed)
-			const renderStatus: ProgressStatus = (!pulseBright && item.status === "active")
-				? "pending"
-				: item.status;
-
-			push(uiHelper.progressItem(item.label, renderStatus, {
-				detail: item.detail,
-				emphasized: item.status === "active",
-			}));
-
-			if (item.annotation) {
-				push(uiHelper.progressAnnotation(item.annotation));
-			}
-		}
-
-		// 6. Blank line (if meta or hints follow)
-		if (model.meta?.length || model.hints?.length) {
-			push(uiHelper.blank());
-		}
-
-		// 7. Meta
-		if (model.meta?.length) {
-			for (const line of model.meta) {
-				push(uiHelper.meta(line));
-			}
-		}
-
-		// 8. Hints
-		if (model.hints?.length) {
-			push(uiHelper.hints(model.hints));
-		}
-
-		// 9. Bottom bar
-		push(uiHelper.bar());
-
-		cachedLines = lines;
-		cachedWidth = width;
-		cachedVersion = stateVersion;
-		return lines;
-	}
-
-	// ── Register widget ───────────────────────────────────────────────────────
-
-	ui.setWidget(widgetKey, (tui: TUI, theme: Theme) => {
-		widgetRef = {
-			invalidate: () => { cachedLines = undefined; },
-			requestRender: () => tui.requestRender(),
-		};
-
-		return {
-			render(width: number): string[] {
-				return renderPanel(width, theme);
-			},
-			invalidate() {
-				cachedLines = undefined;
-			},
-		};
-	});
-
-	// ── Controller ────────────────────────────────────────────────────────────
-
-	return {
-		update(model: ProgressPanelModel): void {
-			currentModel = model;
-			stateVersion++;
-			cachedLines = undefined;
-			updateFooterStatus();
-			if (widgetRef) widgetRef.requestRender();
-		},
-
-		startPulse(): void {
-			if (pulseTimer) return; // already pulsing
-			pulseTimer = setInterval(() => {
-				pulseBright = !pulseBright;
-				cachedLines = undefined;
-				if (widgetRef) widgetRef.requestRender();
-			}, PULSE_INTERVAL_MS);
-		},
-
-		stopPulse(): void {
-			if (pulseTimer) {
-				clearInterval(pulseTimer);
-				pulseTimer = null;
-			}
-			pulseBright = true;
-			cachedLines = undefined;
-			if (widgetRef) widgetRef.requestRender();
-		},
-
-		dispose(): void {
-			if (pulseTimer) {
-				clearInterval(pulseTimer);
-				pulseTimer = null;
-			}
-			ui.setWidget(widgetKey, undefined);
-			ui.setStatus(statusKey, undefined);
-			currentModel = null;
-			widgetRef = null;
-		},
-	};
-}

package/dist/resources/extensions/shared/thinking-widget.ts

@@ -1,107 +0,0 @@
-/**
- * Shared thinking/spinner widget.
- *
- * Shows an animated spinner with a label and an optional live-preview of
- * streamed text (e.g. LLM output) while a background operation is running.
- *
- * Usage:
- *
- *   import { showThinkingWidget } from "./shared/thinking-widget.js";
- *
- *   const widget = showThinkingWidget("Generating questions…", ctx);
- *
- *   // Optionally stream partial text into the preview line:
- *   widget.setText(partialLlmOutput);
- *
- *   // Always dispose when done — removes the widget from the UI:
- *   widget.dispose();
- *
- * Each call gets a unique widget key derived from a monotonic counter, so
- * multiple widgets can safely coexist without key collisions.
- */
-
-import type { ExtensionCommandContext } from "@gsd/pi-coding-agent";
-import { type Theme } from "@gsd/pi-coding-agent";
-import { truncateToWidth, type TUI } from "@gsd/pi-tui";
-
-// ─── Public API ───────────────────────────────────────────────────────────────
-
-export interface ThinkingWidget {
-	/**
-	 * Update the streamed-text preview line.
-	 * Pass the full accumulated text — the widget trims and previews the tail.
-	 */
-	setText(text: string): void;
-	/** Remove the widget from the UI. Always call this when the operation completes. */
-	dispose(): void;
-}
-
-// ─── Internal constants ───────────────────────────────────────────────────────
-
-const SPINNER_FRAMES = ["⠋", "⠙", "⠹", "⠸", "⠼", "⠴", "⠦", "⠧", "⠇", "⠏"] as const;
-const SPINNER_INTERVAL_MS = 80;
-const PREVIEW_MAX_CHARS = 120;
-
-let widgetCounter = 0;
-
-// ─── Implementation ───────────────────────────────────────────────────────────
-
-/**
- * Show an animated thinking spinner as a TUI widget.
- *
- * @param label  Short description of what is happening, e.g. "Writing PROJECT.md…"
- * @param ctx    Extension command context
- * @returns      Handle with setText() and dispose()
- */
-export function showThinkingWidget(label: string, ctx: ExtensionCommandContext): ThinkingWidget {
-	const widgetKey = `thinking-widget-${++widgetCounter}`;
-
-	let streamedText = "";
-	let widgetRef: { invalidate: () => void; requestRender: () => void } | null = null;
-
-	ctx.ui.setWidget(widgetKey, (tui: TUI, theme: Theme) => {
-		let frame = 0;
-		let cachedLines: string[] | undefined;
-
-		const interval = setInterval(() => {
-			frame = (frame + 1) % SPINNER_FRAMES.length;
-			cachedLines = undefined;
-			tui.requestRender();
-		}, SPINNER_INTERVAL_MS);
-
-		widgetRef = {
-			invalidate: () => { cachedLines = undefined; },
-			requestRender: () => tui.requestRender(),
-		};
-
-		return {
-			render(width: number): string[] {
-				if (cachedLines) return cachedLines;
-				const spinner = theme.fg("accent", SPINNER_FRAMES[frame]);
-				const lines: string[] = [];
-				lines.push(truncateToWidth(`  ${spinner} ${theme.fg("muted", label)}`, width));
-				if (streamedText) {
-					const preview = streamedText.replace(/\s+/g, " ").trim().slice(-PREVIEW_MAX_CHARS);
-					lines.push(truncateToWidth(`  ${theme.fg("dim", preview)}`, width));
-				}
-				cachedLines = lines;
-				return lines;
-			},
-			invalidate() { cachedLines = undefined; },
-			dispose() { clearInterval(interval); },
-		};
-	});
-
-	return {
-		setText(text: string) {
-			streamedText = text;
-			if (widgetRef) {
-				widgetRef.invalidate();
-				widgetRef.requestRender();
-			}
-		},
-		dispose() {
-			ctx.ui.setWidget(widgetKey, undefined);
-		},
-	};
-}

package/src/resources/extensions/gsd/preferences-hooks.ts

@@ -1,10 +0,0 @@
-/**
- * Focused re-export: hook-related preferences.
- *
- * Consumers that only need hook resolution can import from this module
- * instead of the monolithic preferences.ts, reducing coupling surface.
- */
-export {
-  resolvePostUnitHooks,
-  resolvePreDispatchHooks,
-} from "./preferences.js";