gsd-pi 2.27.0 → 2.28.0-dev.b23c118

package/src/resources/extensions/shared/format-utils.ts

@@ -11,6 +11,7 @@ import { truncateToWidth, visibleWidth } from "@gsd/pi-tui";
 
 /** Format a millisecond duration as a compact human-readable string. */
 export function formatDuration(ms: number): string {
+  if (ms < 1000) return `${ms}ms`;
   const s = Math.floor(ms / 1000);
   if (s < 60) return `${s}s`;
   const m = Math.floor(s / 60);
@@ -21,6 +22,15 @@ export function formatDuration(ms: number): string {
   return `${h}h ${rm}m`;
 }
 
+// ─── Token Count Formatting ──────────────────────────────────────────────────
+
+/** Format a token count as a compact human-readable string (e.g. 1.5k, 1.50M). */
+export function formatTokenCount(count: number): string {
+  if (count < 1000) return `${count}`;
+  if (count < 1_000_000) return `${(count / 1000).toFixed(1)}k`;
+  return `${(count / 1_000_000).toFixed(2)}M`;
+}
+
 // ─── Layout Helpers ───────────────────────────────────────────────────────────
 
 /** Pad a string with trailing spaces to fill `width` (ANSI-aware). */
@@ -60,6 +70,14 @@ export function fitColumns(parts: string[], width: number, separator = "  "): st
   return truncateToWidth(result, width);
 }
 
+// ─── Text Truncation ─────────────────────────────────────────────────────────
+
+/** Truncate a string to `maxLength` characters, replacing the last character with an ellipsis if needed. */
+export function truncateWithEllipsis(text: string, maxLength: number): string {
+  if (text.length <= maxLength) return text
+  return text.slice(0, maxLength - 1) + "…"
+}
+
 // ─── Data Visualization ───────────────────────────────────────────────────────
 
 /**
@@ -77,9 +95,44 @@ export function sparkline(values: number[]): string {
   return values.map(v => chars[Math.min(7, Math.floor((v / max) * 7))]).join("");
 }
 
+// ─── Date Formatting ─────────────────────────────────────────────────────────
+
+/** Format an ISO date string as a compact locale string (e.g. "Mar 17, 2025, 02:30 PM"). */
+export function formatDateShort(iso: string): string {
+  try {
+    const d = new Date(iso);
+    return d.toLocaleString('en-US', { month: 'short', day: 'numeric', year: 'numeric', hour: '2-digit', minute: '2-digit' });
+  } catch { return iso; }
+}
+
+// ─── Hyperlinks ──────────────────────────────────────────────────────────────
+
+/** Wrap text in an OSC 8 hyperlink for terminals that support clickable links. */
+export function fileLink(filePath: string, displayText?: string): string {
+  const uri = `file://${filePath}`;
+  const label = displayText ?? filePath;
+  return `\x1b]8;;${uri}\x07${label}\x1b]8;;\x07`;
+}
+
 // ─── ANSI Stripping ───────────────────────────────────────────────────────────
 
 /** Strip ANSI escape sequences from a string. */
 export function stripAnsi(s: string): string {
   return s.replace(/\x1b\[[0-9;]*m/g, "");
 }
+
+// ─── String Array Normalization ─────────────────────────────────────────────
+
+/**
+ * Normalize an unknown value to a string array.
+ * Filters to string items, trims whitespace, removes empty strings.
+ * Optionally deduplicates.
+ */
+export function normalizeStringArray(value: unknown, options?: { dedupe?: boolean }): string[] {
+  if (!Array.isArray(value)) return [];
+  const items = value
+    .filter((item): item is string => typeof item === "string")
+    .map(item => item.trim())
+    .filter(Boolean);
+  return options?.dedupe ? [...new Set(items)] : items;
+}

package/src/resources/extensions/shared/frontmatter.ts

@@ -0,0 +1,117 @@
+// Shared frontmatter parsing utilities
+// Canonical implementation for splitting and parsing YAML-like frontmatter.
+
+/** Strip matching single or double quotes from a string value (standard YAML scalar behavior). */
+function stripQuotes(s: string): string {
+  if (s.length >= 2 && ((s[0] === '"' && s[s.length - 1] === '"') || (s[0] === "'" && s[s.length - 1] === "'"))) {
+    return s.slice(1, -1);
+  }
+  return s;
+}
+
+/**
+ * Split markdown content into frontmatter (YAML-like) and body.
+ * Returns [frontmatterLines, body] where frontmatterLines is null if no frontmatter.
+ */
+export function splitFrontmatter(content: string): [string[] | null, string] {
+  const trimmed = content.trimStart();
+  if (!trimmed.startsWith('---')) return [null, content];
+
+  const afterFirst = trimmed.indexOf('\n');
+  if (afterFirst === -1) return [null, content];
+
+  const rest = trimmed.slice(afterFirst + 1);
+  const endIdx = rest.indexOf('\n---');
+  if (endIdx === -1) return [null, content];
+
+  const fmLines = rest.slice(0, endIdx).split('\n');
+  const body = rest.slice(endIdx + 4).replace(/^\n+/, '');
+  return [fmLines, body];
+}
+
+/**
+ * Parse YAML-like frontmatter lines into a flat key-value map.
+ * Handles simple scalars and arrays (lines starting with "  - ").
+ * Handles nested objects like requires (lines with "    key: value").
+ * Supports hyphenated keys (e.g. `tech-stack:`).
+ */
+export function parseFrontmatterMap(lines: string[]): Record<string, unknown> {
+  const result: Record<string, unknown> = {};
+  let currentKey: string | null = null;
+  let currentArray: unknown[] | null = null;
+  let currentObj: Record<string, string> | null = null;
+
+  for (const line of lines) {
+    // Nested object property (4-space indent with key: value)
+    const nestedMatch = line.match(/^    ([\w][\w_-]*)\s*:\s*(.*)$/);
+    if (nestedMatch && currentArray && currentObj) {
+      currentObj[nestedMatch[1]] = nestedMatch[2].trim();
+      continue;
+    }
+
+    // Array item (2-space indent)
+    const arrayMatch = line.match(/^  - (.*)$/);
+    if (arrayMatch && currentKey) {
+      // If there's a pending nested object, push it
+      if (currentObj && Object.keys(currentObj).length > 0) {
+        currentArray!.push(currentObj);
+      }
+      currentObj = null;
+
+      const val = arrayMatch[1].trim();
+      if (!currentArray) currentArray = [];
+
+      // Check if this array item starts a nested object (e.g. "- slice: S00")
+      const nestedStart = val.match(/^([\w][\w_-]*)\s*:\s*(.*)$/);
+      if (nestedStart) {
+        currentObj = { [nestedStart[1]]: nestedStart[2].trim() };
+      } else {
+        currentArray.push(stripQuotes(val));
+      }
+      continue;
+    }
+
+    // Flush previous key
+    if (currentKey) {
+      if (currentObj && Object.keys(currentObj).length > 0 && currentArray) {
+        currentArray.push(currentObj);
+        currentObj = null;
+      }
+      if (currentArray) {
+        result[currentKey] = currentArray;
+      }
+      currentArray = null;
+    }
+
+    // Top-level key: value (supports hyphens in key names)
+    const kvMatch = line.match(/^([\w][\w_-]*)\s*:\s*(.*)$/);
+    if (kvMatch) {
+      currentKey = kvMatch[1];
+      const val = kvMatch[2].trim();
+
+      if (val === '' || val === '[]') {
+        currentArray = [];
+      } else if (val.startsWith('[') && val.endsWith(']')) {
+        const inner = val.slice(1, -1).trim();
+        result[currentKey] = inner ? inner.split(',').map(s => s.trim()) : [];
+        currentKey = null;
+      } else {
+        result[currentKey] = stripQuotes(val);
+        currentKey = null;
+      }
+    }
+  }
+
+  // Flush final key
+  if (currentKey) {
+    if (currentObj && Object.keys(currentObj).length > 0 && currentArray) {
+      currentArray.push(currentObj);
+      currentObj = null;
+    }
+    if (currentArray) {
+      result[currentKey] = currentArray;
+    }
+  }
+
+  return result;
+}

package/src/resources/extensions/shared/mod.ts

@@ -0,0 +1,30 @@
+// Barrel file — re-exports consumed by external modules
+
+export {
+	makeUI,
+	GLYPH,
+	INDENT,
+	STATUS_GLYPH,
+	STATUS_COLOR,
+} from "./ui.js";
+export type { ProgressStatus } from "./ui.js";
+
+export {
+	stripAnsi,
+	formatTokenCount,
+	formatDuration,
+	padRight,
+	joinColumns,
+	centerLine,
+	fitColumns,
+	sparkline,
+	normalizeStringArray,
+	fileLink,
+} from "./format-utils.js";
+
+export { shortcutDesc } from "./terminal.js";
+export { toPosixPath } from "./path-display.js";
+export { showInterviewRound } from "./interview-ui.js";
+export type { Question, QuestionOption, RoundResult } from "./interview-ui.js";
+export { showNextAction } from "./next-action-ui.js";
+export { showConfirm } from "./confirm-ui.js";

package/src/resources/extensions/shared/sanitize.ts

@@ -0,0 +1,19 @@
+/**
+ * Sanitize error messages by redacting token-like strings before surfacing.
+ */
+
+const TOKEN_PATTERNS = [
+  /xoxb-[A-Za-z0-9\-]+/g,    // Slack bot tokens
+  /xoxp-[A-Za-z0-9\-]+/g,    // Slack user tokens
+  /xoxa-[A-Za-z0-9\-]+/g,    // Slack app tokens
+  /\d{8,10}:[A-Za-z0-9_-]{35}/g, // Telegram bot tokens
+  /[A-Za-z0-9_\-.]{20,}/g,   // Long opaque secrets (Discord tokens, etc.)
+];
+
+export function sanitizeError(msg: string): string {
+  let sanitized = msg;
+  for (const pattern of TOKEN_PATTERNS) {
+    sanitized = sanitized.replace(pattern, "[REDACTED]");
+  }
+  return sanitized;
+}

package/src/resources/extensions/slash-commands/create-extension.ts

@@ -1,5 +1,5 @@
 import type { ExtensionAPI } from "@gsd/pi-coding-agent";
-import { showInterviewRound, type Question, type RoundResult } from "../shared/interview-ui.js";
+import { showInterviewRound, type Question, type RoundResult } from "../shared/mod.js";
 
 export default function createExtension(pi: ExtensionAPI) {
 	pi.registerCommand("create-extension", {

package/src/resources/extensions/slash-commands/create-slash-command.ts

@@ -1,5 +1,5 @@
 import type { ExtensionAPI } from "@gsd/pi-coding-agent";
-import { showInterviewRound, type Question, type RoundResult } from "../shared/interview-ui.js";
+import { showInterviewRound, type Question, type RoundResult } from "../shared/mod.js";
 
 export default function createSlashCommand(pi: ExtensionAPI) {
 	pi.registerCommand("create-slash-command", {

package/src/resources/extensions/subagent/index.ts

@@ -23,7 +23,6 @@ import { StringEnum } from "@gsd/pi-ai";
 import { type ExtensionAPI, getMarkdownTheme } from "@gsd/pi-coding-agent";
 import { Container, Markdown, Spacer, Text } from "@gsd/pi-tui";
 import { Type } from "@sinclair/typebox";
-import { parseBundledExtensionPaths } from "../shared/bundled-extension-paths.js";
 import { type AgentConfig, type AgentScope, discoverAgents } from "./agents.js";
 import {
 	type IsolationEnvironment,
@@ -333,7 +332,7 @@ async function runSingleAgent(
 		let wasAborted = false;
 
 		const exitCode = await new Promise<number>((resolve) => {
-			const bundledPaths = parseBundledExtensionPaths(process.env.GSD_BUNDLED_EXTENSION_PATHS);
+			const bundledPaths = (process.env.GSD_BUNDLED_EXTENSION_PATHS ?? "").split(path.delimiter).map(s => s.trim()).filter(Boolean);
 			const extensionArgs = bundledPaths.flatMap(p => ["--extension", p]);
 			const proc = spawn(
 				process.execPath,

package/src/resources/extensions/ttsr/index.ts

@@ -85,6 +85,11 @@ function extractDeltaContext(
 	return null;
 }
 
+// Re-exports for external consumers
+export { TtsrManager } from "./ttsr-manager.js";
+export type { Rule, TtsrMatchContext } from "./ttsr-manager.js";
+export { loadRules } from "./rule-loader.js";
+
 export default function (pi: ExtensionAPI) {
 	let manager: TtsrManager | null = null;
 	let pendingViolation: PendingViolation | null = null;

package/src/resources/extensions/ttsr/rule-loader.ts

@@ -9,53 +9,7 @@ import { readdirSync, readFileSync, existsSync } from "node:fs";
 import { join, basename } from "node:path";
 import { homedir } from "node:os";
 import type { Rule } from "./ttsr-manager.js";
-
-const FRONTMATTER_RE = /^---\r?\n([\s\S]*?)\r?\n---\r?\n?([\s\S]*)$/;
-
-/** Minimal YAML parser for frontmatter (handles string arrays and scalars). */
-function parseFrontmatter(raw: string): Record<string, unknown> {
-	const result: Record<string, unknown> = {};
-	let currentKey: string | null = null;
-	let currentArray: string[] | null = null;
-
-	for (const line of raw.split("\n")) {
-		const trimmed = line.trimEnd();
-
-		// Array item under current key
-		if (currentKey && /^\s+-\s+/.test(trimmed)) {
-			const value = trimmed.replace(/^\s+-\s+/, "").replace(/^["']|["']$/g, "");
-			currentArray!.push(value);
-			continue;
-		}
-
-		// Flush previous array
-		if (currentKey && currentArray) {
-			result[currentKey] = currentArray;
-			currentKey = null;
-			currentArray = null;
-		}
-
-		// Key-value or key-with-array
-		const kvMatch = trimmed.match(/^(\w[\w-]*):\s*(.*)$/);
-		if (kvMatch) {
-			const [, key, value] = kvMatch;
-			if (value.length === 0) {
-				// Expect array items below
-				currentKey = key;
-				currentArray = [];
-			} else {
-				result[key] = value.replace(/^["']|["']$/g, "");
-			}
-		}
-	}
-
-	// Flush trailing array
-	if (currentKey && currentArray) {
-		result[currentKey] = currentArray;
-	}
-
-	return result;
-}
+import { splitFrontmatter, parseFrontmatterMap } from "../shared/frontmatter.js";
 
 function parseRuleFile(filePath: string): Rule | null {
 	let content: string;
@@ -65,11 +19,10 @@ function parseRuleFile(filePath: string): Rule | null {
 		return null;
 	}
 
-	const match = FRONTMATTER_RE.exec(content);
-	if (!match) return null;
+	const [fmLines, body] = splitFrontmatter(content);
+	if (!fmLines) return null;
 
-	const [, frontmatterRaw, body] = match;
-	const meta = parseFrontmatter(frontmatterRaw);
+	const meta = parseFrontmatterMap(fmLines);
 
 	const condition = meta.condition;
 	if (!Array.isArray(condition) || condition.length === 0) return null;

package/src/resources/extensions/universal-config/discovery.ts

@@ -10,6 +10,25 @@ import { TOOLS } from "./tools.js";
 import { SCANNERS } from "./scanners.js";
 import type { DiscoveryResult, DiscoveredItem, ToolDiscoveryResult } from "./types.js";
 
+/** Inline concurrency limiter to cap parallel async operations. */
+function pLimit(concurrency: number) {
+  const queue: (() => void)[] = [];
+  let active = 0;
+  return <T>(fn: () => Promise<T>): Promise<T> => {
+    return new Promise<T>((resolve, reject) => {
+      const run = () => {
+        active++;
+        fn().then(resolve, reject).finally(() => {
+          active--;
+          if (queue.length > 0) queue.shift()!();
+        });
+      };
+      if (active < concurrency) run();
+      else queue.push(run);
+    });
+  };
+}
+
 /**
  * Run universal config discovery across all supported AI coding tools.
  *
@@ -25,22 +44,25 @@ export async function discoverAllConfigs(
   const allWarnings: string[] = [];
   const toolResults: ToolDiscoveryResult[] = [];
 
-  // Run all scanners in parallel
+  // Run scanners with bounded concurrency to avoid memory spikes
+  const limit = pLimit(5);
   const results = await Promise.allSettled(
-    TOOLS.map(async (tool) => {
-      const scanner = SCANNERS[tool.id];
-      if (!scanner) return { tool, items: [] as DiscoveredItem[], warnings: [`No scanner for ${tool.id}`] };
-      try {
-        const { items, warnings } = await scanner(projectRoot, home, tool);
-        return { tool, items, warnings };
-      } catch (err) {
-        return {
-          tool,
-          items: [] as DiscoveredItem[],
-          warnings: [`Scanner error for ${tool.name}: ${err instanceof Error ? err.message : String(err)}`],
-        };
-      }
-    }),
+    TOOLS.map((tool) =>
+      limit(async () => {
+        const scanner = SCANNERS[tool.id];
+        if (!scanner) return { tool, items: [] as DiscoveredItem[], warnings: [`No scanner for ${tool.id}`] };
+        try {
+          const { items, warnings } = await scanner(projectRoot, home, tool);
+          return { tool, items, warnings };
+        } catch (err) {
+          return {
+            tool,
+            items: [] as DiscoveredItem[],
+            warnings: [`Scanner error for ${tool.name}: ${err instanceof Error ? err.message : String(err)}`],
+          };
+        }
+      }),
+    ),
   );
 
   for (const result of results) {

package/src/resources/extensions/voice/index.ts

@@ -1,5 +1,5 @@
 import type { ExtensionAPI, ExtensionContext } from "@gsd/pi-coding-agent";
-import { shortcutDesc } from "../shared/terminal.js";
+import { shortcutDesc } from "../shared/mod.js";
 import type { AssistantMessage } from "@gsd/pi-ai";
 import { isKeyRelease, Key, matchesKey, truncateToWidth, visibleWidth } from "@gsd/pi-tui";
 import { spawn, execSync, type ChildProcess } from "node:child_process";