gsd-pi 2.24.0 → 2.25.0

package/dist/resources/extensions/gsd/guided-flow.ts

@@ -29,6 +29,17 @@ import { loadEffectiveGSDPreferences } from "./preferences.js";
 import { showConfirm } from "../shared/confirm-ui.js";
 import { loadQueueOrder, sortByQueueOrder, saveQueueOrder } from "./queue-order.js";
 
+// ─── Commit Instruction Helpers ──────────────────────────────────────────────
+
+/** Build conditional commit instruction for planning prompts based on commit_docs preference. */
+function buildDocsCommitInstruction(message: string): string {
+  const prefs = loadEffectiveGSDPreferences();
+  const commitDocsEnabled = prefs?.preferences?.git?.commit_docs !== false;
+  return commitDocsEnabled
+    ? `Commit: \`${message}\``
+    : "Do not commit — planning docs are not tracked in git for this project.";
+}
+
 // ─── Auto-start after discuss ─────────────────────────────────────────────────
 
 /** Stashed context + flag for auto-starting after discuss phase completes */
@@ -198,6 +209,8 @@ function buildDiscussPrompt(nextId: string, preamble: string, _basePath: string)
     contextPath: `${milestoneRel}/${nextId}-CONTEXT.md`,
     roadmapPath: `${milestoneRel}/${nextId}-ROADMAP.md`,
     inlinedTemplates,
+    commitInstruction: buildDocsCommitInstruction(`docs(${nextId}): context, requirements, and roadmap`),
+    multiMilestoneCommitInstruction: buildDocsCommitInstruction("docs: project plan — N milestones"),
   });
 }
 
@@ -220,6 +233,8 @@ function buildHeadlessDiscussPrompt(nextId: string, seedContext: string, _basePa
     contextPath: `${milestoneRel}/${nextId}-CONTEXT.md`,
     roadmapPath: `${milestoneRel}/${nextId}-ROADMAP.md`,
     inlinedTemplates,
+    commitInstruction: buildDocsCommitInstruction(`docs(${nextId}): context, requirements, and roadmap`),
+    multiMilestoneCommitInstruction: buildDocsCommitInstruction("docs: project plan — N milestones"),
   });
 }
 
@@ -648,6 +663,7 @@ async function showQueueAdd(
     nextIdPlus1,
     existingMilestonesContext: existingContext,
     inlinedTemplates: queueInlinedTemplates,
+    commitInstruction: buildDocsCommitInstruction("docs: queue <milestone list>"),
   });
 
   pi.sendMessage(
@@ -834,6 +850,7 @@ async function buildDiscussSlicePrompt(
     contextPath: sliceContextPath,
     projectRoot: base,
     inlinedTemplates,
+    commitInstruction: buildDocsCommitInstruction(`docs(${mid}/${sid}): slice context from discuss`),
   });
 }
 
@@ -870,7 +887,7 @@ export async function showDiscuss(
     const draftFile = resolveMilestoneFile(basePath, mid, "CONTEXT-DRAFT");
     const draftContent = draftFile ? await loadFile(draftFile) : null;
 
-    const choice = await showNextAction(ctx as any, {
+    const choice = await showNextAction(ctx, {
       title: `GSD — ${mid}: ${milestoneTitle}`,
       summary: ["This milestone has a draft context from a prior discussion.", "It needs a dedicated discussion before auto-planning can begin."],
       actions: [
@@ -899,6 +916,7 @@ export async function showDiscuss(
       const structuredQuestionsAvailable = pi.getActiveTools().includes("ask_user_questions") ? "true" : "false";
       const basePrompt = loadPrompt("guided-discuss-milestone", {
         milestoneId: mid, milestoneTitle, inlinedTemplates: discussMilestoneTemplates, structuredQuestionsAvailable,
+        commitInstruction: buildDocsCommitInstruction(`docs(${mid}): milestone context from discuss`),
       });
       const seed = draftContent
         ? `${basePrompt}\n\n## Prior Discussion (Draft Seed)\n\n${draftContent}`
@@ -911,6 +929,7 @@ export async function showDiscuss(
       pendingAutoStart = { ctx, pi, basePath, milestoneId: mid, step: false };
       dispatchWorkflow(pi, loadPrompt("guided-discuss-milestone", {
         milestoneId: mid, milestoneTitle, inlinedTemplates: discussMilestoneTemplates, structuredQuestionsAvailable,
+        commitInstruction: buildDocsCommitInstruction(`docs(${mid}): milestone context from discuss`),
       }), "gsd-discuss");
     } else if (choice === "skip_milestone") {
       const milestoneIds = findMilestoneIds(basePath);
@@ -947,7 +966,7 @@ export async function showDiscuss(
       recommended: i === 0,
     }));
 
-    const choice = await showNextAction(ctx as any, {
+    const choice = await showNextAction(ctx, {
       title: "GSD — Discuss a slice",
       summary: [
         `${mid}: ${milestoneTitle}`,
@@ -1056,7 +1075,7 @@ export async function showSmartEntry(
   const crashLock = readCrashLock(basePath);
   if (crashLock) {
     clearLock(basePath);
-    const resume = await showNextAction(ctx as any, {
+    const resume = await showNextAction(ctx, {
       title: "GSD — Interrupted Session Detected",
       summary: [formatCrashInfo(crashLock)],
       actions: [
@@ -1116,7 +1135,7 @@ export async function showSmartEntry(
         basePath
       ));
     } else {
-      const choice = await showNextAction(ctx as any, {
+      const choice = await showNextAction(ctx, {
         title: "GSD — Get Shit Done",
         summary: ["No active milestone."],
         actions: [
@@ -1146,7 +1165,7 @@ export async function showSmartEntry(
 
   // ── All milestones complete → New milestone ──────────────────────────
   if (state.phase === "complete") {
-    const choice = await showNextAction(ctx as any, {
+    const choice = await showNextAction(ctx, {
       title: `GSD — ${milestoneId}: ${milestoneTitle}`,
       summary: ["All milestones complete."],
       actions: [
@@ -1187,7 +1206,7 @@ export async function showSmartEntry(
     const draftFile = resolveMilestoneFile(basePath, milestoneId, "CONTEXT-DRAFT");
     const draftContent = draftFile ? await loadFile(draftFile) : null;
 
-    const choice = await showNextAction(ctx as any, {
+    const choice = await showNextAction(ctx, {
       title: `GSD — ${milestoneId}: ${milestoneTitle}`,
       summary: ["This milestone has a draft context from a prior discussion.", "It needs a dedicated discussion before auto-planning can begin."],
       actions: [
@@ -1216,6 +1235,7 @@ export async function showSmartEntry(
       const structuredQuestionsAvailable = pi.getActiveTools().includes("ask_user_questions") ? "true" : "false";
       const basePrompt = loadPrompt("guided-discuss-milestone", {
         milestoneId, milestoneTitle, inlinedTemplates: discussMilestoneTemplates, structuredQuestionsAvailable,
+        commitInstruction: buildDocsCommitInstruction(`docs(${milestoneId}): milestone context from discuss`),
       });
       const seed = draftContent
         ? `${basePrompt}\n\n## Prior Discussion (Draft Seed)\n\n${draftContent}`
@@ -1228,6 +1248,7 @@ export async function showSmartEntry(
       pendingAutoStart = { ctx, pi, basePath, milestoneId, step: stepMode };
       dispatchWorkflow(pi, loadPrompt("guided-discuss-milestone", {
         milestoneId, milestoneTitle, inlinedTemplates: discussMilestoneTemplates, structuredQuestionsAvailable,
+        commitInstruction: buildDocsCommitInstruction(`docs(${milestoneId}): milestone context from discuss`),
       }), "gsd-discuss");
     } else if (choice === "skip_milestone") {
       const milestoneIds = findMilestoneIds(basePath);
@@ -1278,7 +1299,7 @@ export async function showSmartEntry(
         },
       ];
 
-      const choice = await showNextAction(ctx as any, {
+      const choice = await showNextAction(ctx, {
         title: `GSD — ${milestoneId}: ${milestoneTitle}`,
         summary: [hasContext ? "Context captured. Ready to create roadmap." : "New milestone — no roadmap yet."],
         actions,
@@ -1302,6 +1323,7 @@ export async function showSmartEntry(
         const structuredQuestionsAvailable = pi.getActiveTools().includes("ask_user_questions") ? "true" : "false";
         dispatchWorkflow(pi, loadPrompt("guided-discuss-milestone", {
           milestoneId, milestoneTitle, inlinedTemplates: discussMilestoneTemplates, structuredQuestionsAvailable,
+          commitInstruction: buildDocsCommitInstruction(`docs(${milestoneId}): milestone context from discuss`),
         }));
       } else if (choice === "skip_milestone") {
         const milestoneIds = findMilestoneIds(basePath);
@@ -1315,7 +1337,7 @@ export async function showSmartEntry(
       } else if (choice === "discard_milestone") {
         const mDir = resolveMilestonePath(basePath, milestoneId);
         if (!mDir) return;
-        const confirmed = await showConfirm(ctx as any, {
+        const confirmed = await showConfirm(ctx, {
           title: "Discard milestone?",
           message: `This will permanently delete ${milestoneId} and all its contents.`,
           confirmLabel: "Discard",
@@ -1342,7 +1364,7 @@ export async function showSmartEntry(
         },
       ];
 
-      const choice = await showNextAction(ctx as any, {
+      const choice = await showNextAction(ctx, {
         title: `GSD — ${milestoneId}: ${milestoneTitle}`,
         summary: ["Roadmap exists. Ready to execute."],
         actions,
@@ -1400,7 +1422,7 @@ export async function showSmartEntry(
       ? `${sliceId}: ${sliceTitle} (${summaryParts.join(", ")})`
       : `${sliceId}: ${sliceTitle} — ready for planning.`;
 
-    const choice = await showNextAction(ctx as any, {
+    const choice = await showNextAction(ctx, {
       title: `GSD — ${milestoneId} / ${sliceId}: ${sliceTitle}`,
       summary: [summaryLine],
       actions,
@@ -1431,7 +1453,7 @@ export async function showSmartEntry(
 
   // ── All tasks done → Complete slice ──────────────────────────────────
   if (state.phase === "summarizing") {
-    const choice = await showNextAction(ctx as any, {
+    const choice = await showNextAction(ctx, {
       title: `GSD — ${milestoneId} / ${sliceId}: ${sliceTitle}`,
       summary: ["All tasks complete. Ready for slice summary."],
       actions: [
@@ -1475,7 +1497,7 @@ export async function showSmartEntry(
     const hasInterrupted = !!(continueFile && await loadFile(continueFile)) ||
       !!(sDir && await loadFile(join(sDir, "continue.md")));
 
-    const choice = await showNextAction(ctx as any, {
+    const choice = await showNextAction(ctx, {
       title: `GSD — ${milestoneId} / ${sliceId}: ${sliceTitle}`,
       summary: [
         hasInterrupted

package/dist/resources/extensions/gsd/index.ts

@@ -566,6 +566,19 @@ export default function (pi: ExtensionAPI) {
       }
     }
 
+    // Inject auto-learned project memories
+    let memoryBlock = "";
+    try {
+      const { getActiveMemoriesRanked, formatMemoriesForPrompt } = await import("./memory-store.js");
+      const memories = getActiveMemoriesRanked(30);
+      if (memories.length > 0) {
+        const formatted = formatMemoriesForPrompt(memories, 2000);
+        if (formatted) {
+          memoryBlock = `\n\n${formatted}`;
+        }
+      }
+    } catch { /* non-fatal */ }
+
     // Detect skills installed during this auto-mode session
     let newSkillsBlock = "";
     if (hasSkillSnapshot()) {
@@ -625,7 +638,7 @@ export default function (pi: ExtensionAPI) {
       ].join("\n");
     }
 
-    const fullSystem = `${event.systemPrompt}\n\n[SYSTEM CONTEXT — GSD]\n\n${systemContent}${preferenceBlock}${agentInstructionsBlock}${knowledgeBlock}${newSkillsBlock}${worktreeBlock}`;
+    const fullSystem = `${event.systemPrompt}\n\n[SYSTEM CONTEXT — GSD]\n\n${systemContent}${preferenceBlock}${agentInstructionsBlock}${knowledgeBlock}${memoryBlock}${newSkillsBlock}${worktreeBlock}`;
     stopContextTimer({
       systemPromptSize: fullSystem.length,
       injectionSize: injection?.length ?? 0,

package/dist/resources/extensions/gsd/memory-extractor.ts

@@ -0,0 +1,352 @@
+// GSD Memory Extractor — Background LLM extraction from activity logs
+//
+// After each unit completes, extracts durable knowledge from the session
+// transcript and stores it as memory entries. One extraction at a time
+// (mutex guard). Fire-and-forget — never blocks auto-mode.
+
+import { readFileSync, statSync } from 'node:fs';
+import type { ExtensionContext } from '@gsd/pi-coding-agent';
+import type { Api, AssistantMessage, Model } from '@gsd/pi-ai';
+import {
+  getActiveMemories,
+  isUnitProcessed,
+  markUnitProcessed,
+  applyMemoryActions,
+  decayStaleMemories,
+} from './memory-store.js';
+import type { MemoryAction } from './memory-store.js';
+
+// ─── Types ──────────────────────────────────────────────────────────────────
+
+export type LLMCallFn = (system: string, user: string) => Promise<string>;
+
+// ─── Concurrency Guard ──────────────────────────────────────────────────────
+
+let _extracting = false;
+let _lastExtractionTime = 0;
+
+const MIN_EXTRACTION_INTERVAL_MS = 30_000;
+
+// ─── Skip Conditions ────────────────────────────────────────────────────────
+
+const SKIP_TYPES = new Set([
+  'complete-slice',
+  'rewrite-docs',
+  'triage-captures',
+]);
+
+const MIN_ACTIVITY_SIZE = 1024; // 1KB
+
+// ─── Secret Redaction ───────────────────────────────────────────────────────
+
+const SECRET_PATTERNS = [
+  /(?:sk|pk|api[_-]?key|token|secret|password|credential|auth)[_-]?\w*[\s:=]+['"]?[\w\-./+=]{20,}['"]?/gi,
+  /AKIA[0-9A-Z]{16}/g,
+  /gh[pousr]_[A-Za-z0-9_]{36,}/g,
+  /[rsp]k_(?:live|test)_[A-Za-z0-9]{20,}/g,
+  /eyJ[A-Za-z0-9_-]{20,}\.eyJ[A-Za-z0-9_-]{20,}\.[A-Za-z0-9_-]+/g,
+  /-----BEGIN (?:RSA |EC |DSA |OPENSSH )?PRIVATE KEY-----[\s\S]*?-----END (?:RSA |EC |DSA |OPENSSH )?PRIVATE KEY-----/g,
+  /(?:Bearer\s+)[A-Za-z0-9\-._~+/]+=*/gi,
+  /npm_[A-Za-z0-9]{36,}/g,
+  /sk-ant-[A-Za-z0-9\-_]{20,}/g,
+  /sk-[A-Za-z0-9]{40,}/g,
+];
+
+function redactSecrets(text: string): string {
+  let result = text;
+  for (const pattern of SECRET_PATTERNS) {
+    // Reset lastIndex for global regexes
+    pattern.lastIndex = 0;
+    result = result.replace(pattern, '[REDACTED]');
+  }
+  return result;
+}
+
+// ─── Model Selection ────────────────────────────────────────────────────────
+
+/**
+ * Build an LLM call function using the cheapest available model (preferring Haiku).
+ * Returns null if no models available.
+ */
+export function buildMemoryLLMCall(ctx: ExtensionContext): LLMCallFn | null {
+  try {
+    const available = ctx.modelRegistry.getAvailable();
+    if (!available || available.length === 0) return null;
+
+    // Prefer Haiku by ID substring match
+    let model = available.find(m =>
+      m.id.toLowerCase().includes('haiku'),
+    );
+
+    // Fallback: cheapest by input cost
+    if (!model) {
+      model = [...available].sort((a, b) => a.cost.input - b.cost.input)[0];
+    }
+
+    if (!model) return null;
+
+    const selectedModel = model as Model<Api>;
+
+    return async (system: string, user: string): Promise<string> => {
+      const { completeSimple } = await import('@gsd/pi-ai');
+      const result: AssistantMessage = await completeSimple(selectedModel, {
+        systemPrompt: system,
+        messages: [{ role: 'user', content: [{ type: 'text', text: user }], timestamp: Date.now() }],
+      }, {
+        maxTokens: 2048,
+        temperature: 0,
+      });
+
+      // Extract text from response
+      const textParts = result.content
+        .filter((c): c is { type: 'text'; text: string } => c.type === 'text')
+        .map(c => c.text);
+      return textParts.join('');
+    };
+  } catch {
+    return null;
+  }
+}
+
+// ─── Extraction Prompts ─────────────────────────────────────────────────────
+
+const EXTRACTION_SYSTEM = `You are a memory extraction agent for a software project. Analyze the session
+transcript and identify durable knowledge worth remembering for future sessions.
+
+Categories: architecture, convention, gotcha, preference, environment, pattern
+
+Actions (return JSON array):
+- CREATE: {"action": "CREATE", "category": "<cat>", "content": "<text>", "confidence": <0.6-0.95>}
+- UPDATE: {"action": "UPDATE", "id": "<MEM###>", "content": "<revised text>"}
+- REINFORCE: {"action": "REINFORCE", "id": "<MEM###>"}
+- SUPERSEDE: {"action": "SUPERSEDE", "id": "<MEM###>", "superseded_by": "<MEM###>"}
+
+Rules:
+- Don't create memories for one-off bug fixes or temporary state
+- Don't duplicate existing memories — use REINFORCE or UPDATE
+- Keep content to 1-3 sentences
+- Confidence: 0.6 tentative, 0.8 solid, 0.95 well-confirmed
+- Prefer fewer high-quality memories over many low-quality ones
+- Return empty array [] if nothing worth remembering
+- NEVER include secrets, API keys, or passwords
+
+Return ONLY a valid JSON array.`;
+
+function buildExtractionUserPrompt(
+  unitType: string,
+  unitId: string,
+  existingMemories: { id: string; category: string; content: string }[],
+  transcript: string,
+): string {
+  let memoriesSection: string;
+  if (existingMemories.length === 0) {
+    memoriesSection = '(none yet)';
+  } else {
+    memoriesSection = existingMemories
+      .map((m, i) => `${i + 1}. [${m.id}] (${m.category}) ${m.content}`)
+      .join('\n');
+  }
+
+  return `## Current Active Memories\n${memoriesSection}\n\n## Session Transcript (${unitType}: ${unitId})\n${transcript}`;
+}
+
+// ─── Activity JSONL Parsing ─────────────────────────────────────────────────
+
+/**
+ * Extract assistant message text from activity JSONL.
+ * Returns concatenated text content from assistant role entries.
+ */
+function extractTranscriptFromActivity(raw: string, maxChars = 30_000): string {
+  const lines = raw.split('\n');
+  const parts: string[] = [];
+  let totalChars = 0;
+
+  for (const line of lines) {
+    if (!line.trim()) continue;
+    try {
+      const entry = JSON.parse(line);
+      if (entry.role !== 'assistant') continue;
+
+      // Handle content array or direct text
+      if (Array.isArray(entry.content)) {
+        for (const block of entry.content) {
+          if (block.type === 'text' && block.text) {
+            const text = block.text;
+            if (totalChars + text.length > maxChars) {
+              parts.push(text.substring(0, maxChars - totalChars));
+              return parts.join('\n\n');
+            }
+            parts.push(text);
+            totalChars += text.length;
+          }
+        }
+      } else if (typeof entry.content === 'string') {
+        const text = entry.content;
+        if (totalChars + text.length > maxChars) {
+          parts.push(text.substring(0, maxChars - totalChars));
+          return parts.join('\n\n');
+        }
+        parts.push(text);
+        totalChars += text.length;
+      }
+    } catch {
+      // Skip malformed lines
+    }
+  }
+
+  return parts.join('\n\n');
+}
+
+// ─── Response Parsing ───────────────────────────────────────────────────────
+
+/**
+ * Parse the LLM response into memory actions.
+ * Strips markdown fences, validates required fields.
+ * Returns [] on any parse failure.
+ */
+export function parseMemoryResponse(raw: string): MemoryAction[] {
+  try {
+    // Strip markdown code fences
+    let cleaned = raw.trim();
+    if (cleaned.startsWith('```')) {
+      cleaned = cleaned.replace(/^```(?:json)?\s*\n?/, '').replace(/\n?```\s*$/, '');
+    }
+
+    const parsed = JSON.parse(cleaned);
+    if (!Array.isArray(parsed)) return [];
+
+    const actions: MemoryAction[] = [];
+    for (const item of parsed) {
+      if (!item || typeof item !== 'object' || !item.action) continue;
+
+      switch (item.action) {
+        case 'CREATE':
+          if (typeof item.category === 'string' && typeof item.content === 'string') {
+            actions.push({
+              action: 'CREATE',
+              category: item.category,
+              content: item.content,
+              confidence: typeof item.confidence === 'number' ? item.confidence : undefined,
+            });
+          }
+          break;
+        case 'UPDATE':
+          if (typeof item.id === 'string' && typeof item.content === 'string') {
+            actions.push({
+              action: 'UPDATE',
+              id: item.id,
+              content: item.content,
+              confidence: typeof item.confidence === 'number' ? item.confidence : undefined,
+            });
+          }
+          break;
+        case 'REINFORCE':
+          if (typeof item.id === 'string') {
+            actions.push({ action: 'REINFORCE', id: item.id });
+          }
+          break;
+        case 'SUPERSEDE':
+          if (typeof item.id === 'string' && typeof item.superseded_by === 'string') {
+            actions.push({
+              action: 'SUPERSEDE',
+              id: item.id,
+              superseded_by: item.superseded_by,
+            });
+          }
+          break;
+      }
+    }
+
+    return actions;
+  } catch {
+    return [];
+  }
+}
+
+// ─── Main Extraction Function ───────────────────────────────────────────────
+
+/**
+ * Extract memories from a completed unit's activity log.
+ * Fire-and-forget — never throws, mutex-guarded, respects rate limiting.
+ */
+export async function extractMemoriesFromUnit(
+  activityFile: string,
+  unitType: string,
+  unitId: string,
+  llmCallFn: LLMCallFn,
+): Promise<void> {
+  // Mutex guard
+  if (_extracting) return;
+
+  // Rate limit
+  const now = Date.now();
+  if (now - _lastExtractionTime < MIN_EXTRACTION_INTERVAL_MS) return;
+
+  // Skip certain unit types
+  if (SKIP_TYPES.has(unitType)) return;
+
+  const unitKey = `${unitType}/${unitId}`;
+
+  // Already processed
+  if (isUnitProcessed(unitKey)) return;
+
+  // Check file size
+  try {
+    const stat = statSync(activityFile);
+    if (stat.size < MIN_ACTIVITY_SIZE) return;
+  } catch {
+    return;
+  }
+
+  _extracting = true;
+  _lastExtractionTime = now;
+
+  try {
+    // Read and parse activity file
+    const raw = readFileSync(activityFile, 'utf-8');
+    const transcript = extractTranscriptFromActivity(raw);
+    if (!transcript.trim()) return;
+
+    // Redact secrets
+    const safeTranscript = redactSecrets(transcript);
+
+    // Get current memories for context
+    const activeMemories = getActiveMemories().map(m => ({
+      id: m.id,
+      category: m.category,
+      content: m.content,
+    }));
+
+    // Build prompts
+    const userPrompt = buildExtractionUserPrompt(unitType, unitId, activeMemories, safeTranscript);
+
+    // Call LLM
+    const response = await llmCallFn(EXTRACTION_SYSTEM, userPrompt);
+
+    // Parse response
+    const actions = parseMemoryResponse(response);
+
+    // Apply actions
+    if (actions.length > 0) {
+      applyMemoryActions(actions, unitType, unitId);
+    }
+
+    // Decay stale memories periodically
+    decayStaleMemories(20);
+
+    // Mark unit as processed
+    markUnitProcessed(unitKey, activityFile);
+  } catch {
+    // Non-fatal — memory extraction failure should never affect auto-mode
+  } finally {
+    _extracting = false;
+  }
+}
+
+// ─── Testing Helpers ────────────────────────────────────────────────────────
+
+/** Reset extraction state (testing only). */
+export function _resetExtractionState(): void {
+  _extracting = false;
+  _lastExtractionTime = 0;
+}