gsd-pi 2.22.0 → 2.24.0

package/src/resources/extensions/gsd/tests/derive-state-db.test.ts

@@ -248,31 +248,24 @@ async function main(): Promise<void> {
     }
   }
 
-  // ─── Test 5: Requirements counting from DB content ────────────────────
-  console.log('\n=== derive-state-db: requirements from DB content ===');
+  // ─── Test 5: Requirements counting from disk (DB no longer used for content) ─
+  console.log('\n=== derive-state-db: requirements from disk content ===');
   {
     const base = createFixtureBase();
     try {
       // Write minimal milestone dir (needed for milestone discovery)
       mkdirSync(join(base, '.gsd', 'milestones', 'M001'), { recursive: true });
-      // Do NOT write REQUIREMENTS.md to disk — only in DB
-
-      openDatabase(':memory:');
-      insertArtifactRow('REQUIREMENTS.md', REQUIREMENTS_CONTENT, {
-        artifact_type: 'requirements',
-      });
+      // Write REQUIREMENTS.md to disk (DB content is no longer used by deriveState)
+      writeFile(base, 'REQUIREMENTS.md', REQUIREMENTS_CONTENT);
 
       invalidateStateCache();
       const state = await deriveState(base);
 
-      // Requirements should come from DB
-      assertEq(state.requirements?.active, 2, 'req-from-db: requirements.active = 2');
-      assertEq(state.requirements?.validated, 1, 'req-from-db: requirements.validated = 1');
-      assertEq(state.requirements?.total, 3, 'req-from-db: requirements.total = 3');
-
-      closeDatabase();
+      // Requirements should come from disk
+      assertEq(state.requirements?.active, 2, 'req-from-disk: requirements.active = 2');
+      assertEq(state.requirements?.validated, 1, 'req-from-disk: requirements.validated = 1');
+      assertEq(state.requirements?.total, 3, 'req-from-disk: requirements.total = 3');
     } finally {
-      closeDatabase();
       cleanup(base);
     }
   }
@@ -310,6 +303,7 @@ async function main(): Promise<void> {
       mkdirSync(join(base, '.gsd', 'milestones', 'M001'), { recursive: true });
       mkdirSync(join(base, '.gsd', 'milestones', 'M002'), { recursive: true });
       writeFile(base, 'milestones/M001/M001-ROADMAP.md', completedRoadmap);
+      writeFile(base, 'milestones/M001/M001-VALIDATION.md', `---\nverdict: pass\nremediation_round: 0\n---\n\n# Validation\nPassed.`);
       writeFile(base, 'milestones/M001/M001-SUMMARY.md', summaryContent);
       writeFile(base, 'milestones/M002/M002-ROADMAP.md', activeRoadmap);
 

package/src/resources/extensions/gsd/tests/derive-state-deps.test.ts

@@ -26,6 +26,12 @@ function writeMilestoneSummary(base: string, mid: string, content: string): void
   writeFileSync(join(dir, `${mid}-SUMMARY.md`), content);
 }
 
+function writeMilestoneValidation(base: string, mid: string): void {
+  const dir = join(base, '.gsd', 'milestones', mid);
+  mkdirSync(dir, { recursive: true });
+  writeFileSync(join(dir, `${mid}-VALIDATION.md`), `---\nverdict: pass\nremediation_round: 0\n---\n\n# Validation\nPassed.`);
+}
+
 /**
  * Creates M00x-CONTEXT.md with a valid YAML frontmatter block.
  * frontmatter is the raw YAML lines between the --- delimiters.
@@ -120,6 +126,7 @@ async function main(): Promise<void> {
 - [x] **S01: Done** \`risk:low\` \`depends:[]\`
   > After this: Done.
 `);
+      writeMilestoneValidation(base, 'M001');
       writeMilestoneSummary(base, 'M001', '# M001 Summary\n\nFirst milestone is complete.');
 
       // M002: depends on M001, now unblocked
@@ -252,6 +259,7 @@ async function main(): Promise<void> {
 - [x] **S01: Done** \`risk:low\` \`depends:[]\`
   > After this: Done.
 `);
+      writeMilestoneValidation(base, 'M002');
       writeMilestoneSummary(base, 'M002', '# M002 Summary\n\nSecond milestone is complete.');
 
       const state = await deriveState(base);
@@ -321,6 +329,7 @@ async function main(): Promise<void> {
 - [x] **S01: Done** \`risk:low\` \`depends:[]\`
   > After this: Done.
 `);
+      writeMilestoneValidation(base, 'M004-0zjrg0');
       writeMilestoneSummary(base, 'M004-0zjrg0', '# M004-0zjrg0 Summary\n\nComplete.');
 
       // M005-b0m2hl: depends on M004-0zjrg0 (lowercase hex suffix)

package/src/resources/extensions/gsd/tests/derive-state-draft.test.ts

@@ -54,6 +54,12 @@ function writeMilestoneSummary(base: string, mid: string, content: string): void
   writeFileSync(join(dir, `${mid}-SUMMARY.md`), content);
 }
 
+function writeMilestoneValidation(base: string, mid: string): void {
+  const dir = join(base, '.gsd', 'milestones', mid);
+  mkdirSync(dir, { recursive: true });
+  writeFileSync(join(dir, `${mid}-VALIDATION.md`), `---\nverdict: pass\nremediation_round: 0\n---\n\n# Validation\nPassed.`);
+}
+
 function cleanup(base: string): void {
   rmSync(base, { recursive: true, force: true });
 }
@@ -143,6 +149,7 @@ async function main(): Promise<void> {
 - [x] **S01: Done** \`risk:low\` \`depends:[]\`
   > After this: Done.
 `);
+      writeMilestoneValidation(base, 'M001');
       writeMilestoneSummary(base, 'M001', '# M001 Summary\n\nFirst milestone complete.');
 
       // M002: only CONTEXT-DRAFT.md
@@ -178,6 +185,7 @@ async function main(): Promise<void> {
 - [x] **S01: Done** \`risk:low\` \`depends:[]\`
   > After this: Done.
 `);
+      writeMilestoneValidation(base, 'M001');
       writeMilestoneSummary(base, 'M001', '# M001 Summary\n\nComplete.');
 
       // M002: draft only — should become active with needs-discussion

package/src/resources/extensions/gsd/tests/derive-state.test.ts

@@ -38,6 +38,12 @@ function writeMilestoneSummary(base: string, mid: string, content: string): void
   writeFileSync(join(dir, `${mid}-SUMMARY.md`), content);
 }
 
+function writeMilestoneValidation(base: string, mid: string, verdict: string = 'pass'): void {
+  const dir = join(base, '.gsd', 'milestones', mid);
+  mkdirSync(dir, { recursive: true });
+  writeFileSync(join(dir, `${mid}-VALIDATION.md`), `---\nverdict: ${verdict}\nremediation_round: 0\n---\n\n# Validation\nValidated.`);
+}
+
 function writeRequirements(base: string, content: string): void {
   writeFileSync(join(base, '.gsd', 'REQUIREMENTS.md'), content);
 }
@@ -285,6 +291,7 @@ Continue from step 2.
   > After this: Done.
 `);
 
+      writeMilestoneValidation(base, 'M001');
       writeMilestoneSummary(base, 'M001', `# M001 Summary\n\nMilestone complete.`);
 
       const state = await deriveState(base);
@@ -381,6 +388,7 @@ Continue from step 2.
   > After this: Done.
 `);
 
+      writeMilestoneValidation(base, 'M001');
       writeMilestoneSummary(base, 'M001', `# M001 Summary\n\nFirst milestone complete.`);
 
       // M002: active (has incomplete slices)
@@ -486,6 +494,8 @@ Continue from step 2.
   > After this: S02 complete.
 `);
 
+      writeMilestoneValidation(base, 'M001');
+
       const state = await deriveState(base);
 
       assertEq(state.phase, 'completing-milestone', 'completing-ms: phase is completing-milestone');
@@ -521,6 +531,7 @@ Continue from step 2.
   > After this: Done.
 `);
 
+      writeMilestoneValidation(base, 'M001');
       writeMilestoneSummary(base, 'M001', `# M001 Summary\n\nMilestone is complete.`);
 
       const state = await deriveState(base);
@@ -550,6 +561,7 @@ Continue from step 2.
 - [x] **S01: Done** \`risk:low\` \`depends:[]\`
   > After this: Done.
 `);
+      writeMilestoneValidation(base, 'M001');
       writeMilestoneSummary(base, 'M001', `# M001 Summary\n\nFirst milestone complete.`);
 
       // M002: all slices done, no summary → completing-milestone
@@ -566,6 +578,8 @@ Continue from step 2.
   > After this: Done.
 `);
 
+      writeMilestoneValidation(base, 'M002');
+
       // M003: has incomplete slices → pending (M002 is active)
       writeRoadmap(base, 'M003', `# M003: Third Milestone
 

package/src/resources/extensions/gsd/tests/doctor.test.ts

@@ -585,6 +585,64 @@ Discovered an issue.
     rmSync(dtBase, { recursive: true, force: true });
   }
 
+  // ─── unresolvable_dependency: range syntax dep warns ─────────────────
+  console.log("\n=== doctor: unresolvable_dependency warns for leftover range ID ===");
+  {
+    // Simulate a roadmap where expandDependencies did NOT expand (pre-fix stored artifact)
+    // by writing a dep that looks like a range but doesn't match any real slice.
+    const base = mkdtempSync(join(tmpdir(), "gsd-doctor-udep-"));
+    const mDir2 = join(base, ".gsd", "milestones", "M001");
+    const sDir2 = join(mDir2, "slices", "S01");
+    const tDir2 = join(sDir2, "tasks");
+    mkdirSync(tDir2, { recursive: true });
+    writeFileSync(join(mDir2, "M001-ROADMAP.md"), [
+      "# M001: Test",
+      "",
+      "## Slices",
+      "- [x] **S01: Done** `risk:low` `depends:[]`",
+      "  > After this: done",
+      "- [ ] **S02: Blocked** `risk:low` `depends:[S99]`",
+      "  > After this: also done",
+    ].join("\n") + "\n");
+    writeFileSync(join(sDir2, "S01-PLAN.md"), "# S01\n\n**Goal:** g\n**Demo:** d\n\n## Tasks\n- [x] **T01: t** `est:5m`\n");
+    writeFileSync(join(tDir2, "T01-SUMMARY.md"), "---\nid: T01\nparent: S01\nmilestone: M001\n---\n# T01\n## What Happened\nDone.\n");
+
+    const r = await runGSDDoctor(base, { fix: false });
+    const udepIssues = r.issues.filter(i => i.code === "unresolvable_dependency");
+    assertTrue(udepIssues.length > 0, "unresolvable_dependency fires for unknown dep S99");
+    assertEq(udepIssues[0]?.severity, "warning", "severity is warning");
+    assertTrue(udepIssues[0]?.message.includes("S99"), "message names the bad dep");
+
+    rmSync(base, { recursive: true, force: true });
+  }
+
+  // ─── unresolvable_dependency: valid deps do not warn ─────────────────
+  console.log("\n=== doctor: no unresolvable_dependency for valid deps ===");
+  {
+    const base = mkdtempSync(join(tmpdir(), "gsd-doctor-udep-ok-"));
+    const mDir2 = join(base, ".gsd", "milestones", "M001");
+    const sDir2 = join(mDir2, "slices", "S01");
+    const tDir2 = join(sDir2, "tasks");
+    mkdirSync(tDir2, { recursive: true });
+    writeFileSync(join(mDir2, "M001-ROADMAP.md"), [
+      "# M001: Test",
+      "",
+      "## Slices",
+      "- [x] **S01: Done** `risk:low` `depends:[]`",
+      "  > After this: done",
+      "- [ ] **S02: Next** `risk:low` `depends:[S01]`",
+      "  > After this: next done",
+    ].join("\n") + "\n");
+    writeFileSync(join(sDir2, "S01-PLAN.md"), "# S01\n\n**Goal:** g\n**Demo:** d\n\n## Tasks\n- [x] **T01: t** `est:5m`\n");
+    writeFileSync(join(tDir2, "T01-SUMMARY.md"), "---\nid: T01\nparent: S01\nmilestone: M001\n---\n# T01\n## What Happened\nDone.\n");
+
+    const r = await runGSDDoctor(base, { fix: false });
+    const udepIssues = r.issues.filter(i => i.code === "unresolvable_dependency");
+    assertEq(udepIssues.length, 0, "no unresolvable_dependency for valid S01 dep");
+
+    rmSync(base, { recursive: true, force: true });
+  }
+
   report();
 }
 

package/src/resources/extensions/gsd/tests/in-flight-tool-tracking.test.ts

@@ -1,6 +1,6 @@
 /**
  * In-flight tool tracking tests — verifies that markToolStart/markToolEnd
- * correctly manage the in-flight tools set used by the idle watchdog to
+ * correctly manage the in-flight tools map used by the idle watchdog to
  * distinguish "agent waiting on long-running tool" from "agent is idle".
  *
  * Background: The idle watchdog checks every 15s for agent progress. Without
@@ -8,12 +8,15 @@
  * can run 20+ minutes for evaluations, deployments, test suites) are falsely
  * declared idle and interrupted by recovery steering messages.
  *
- * The fix hooks tool_execution_start/end events to track active tool calls.
- * When tools are in-flight, the watchdog resets lastProgressAt instead of
- * triggering idle recovery.
+ * The fix hooks tool_execution_start/end events to track active tool calls
+ * with start timestamps. When tools are in-flight and started recently
+ * (< idleTimeoutMs), the watchdog resets lastProgressAt instead of triggering
+ * idle recovery. When a tool has been in-flight for longer than idleTimeoutMs,
+ * it is treated as stuck (e.g., `command &` keeping stdout open) and recovery
+ * proceeds anyway.
  */
 
-import { markToolStart, markToolEnd, isAutoActive } from "../auto.ts";
+import { markToolStart, markToolEnd, isAutoActive, getOldestInFlightToolAgeMs } from "../auto.ts";
 import { createTestContext } from './test-helpers.ts';
 
 const { assertEq, assertTrue, report } = createTestContext();
@@ -49,9 +52,17 @@ const { assertEq, assertTrue, report } = createTestContext();
 // ═══ Integration contract: expected exports from auto.ts ═════════════════════
 
 {
-  console.log("\n=== auto.ts exports markToolStart and markToolEnd ===");
+  console.log("\n=== auto.ts exports markToolStart, markToolEnd, and getOldestInFlightToolAgeMs ===");
   assertEq(typeof markToolStart, "function", "markToolStart should be a function");
   assertEq(typeof markToolEnd, "function", "markToolEnd should be a function");
+  assertEq(typeof getOldestInFlightToolAgeMs, "function", "getOldestInFlightToolAgeMs should be a function");
+}
+
+{
+  console.log("\n=== getOldestInFlightToolAgeMs: returns 0 when no tools in-flight ===");
+  // When auto-mode is inactive, inFlightTools map is empty → age is 0
+  const age = getOldestInFlightToolAgeMs();
+  assertEq(age, 0, "should return 0 when no tools are in-flight");
 }
 
 {