gsd-pi 2.19.0 → 2.20.0

package/dist/resources/extensions/gsd/tests/unit-runtime.test.ts

@@ -1,4 +1,4 @@
-import { mkdtempSync, mkdirSync, readFileSync, rmSync, writeFileSync } from "node:fs";
+import { mkdtempSync, mkdirSync, readdirSync, readFileSync, rmSync, writeFileSync } from "node:fs";
 import { join } from "node:path";
 import { tmpdir } from "node:os";
 import {
@@ -65,6 +65,30 @@ console.log("\n=== runtime record cleanup ===");
   assertEq(loaded, null, "record removed");
 }
 
+console.log("\n=== hook unit type sanitization (slash in unitType) ===");
+{
+  // Hook units have unitType like "hook/code-review" with a slash
+  // This should NOT create a subdirectory - the slash must be sanitized
+  const hookRecord = writeUnitRuntimeRecord(base, "hook/code-review", "M100/S02/T10", 2000, { phase: "dispatched" });
+  assertEq(hookRecord.unitType, "hook/code-review", "unitType preserved in record");
+  assertEq(hookRecord.unitId, "M100/S02/T10", "unitId preserved in record");
+  
+  const loaded = readUnitRuntimeRecord(base, "hook/code-review", "M100/S02/T10");
+  assertTrue(loaded !== null, "hook record readable");
+  assertEq(loaded!.phase, "dispatched", "hook phase correct");
+  
+  // Verify the file is in the units dir, not in a subdirectory
+  const unitsDir = join(base, ".gsd", "runtime", "units");
+  const files = readdirSync(unitsDir);
+  const hookFile = files.find((f: string) => f.includes("hook-code-review"));
+  assertTrue(hookFile !== undefined, "hook file exists with sanitized name");
+  assertTrue(!files.some((f: string) => f === "hook"), "no 'hook' subdirectory created");
+  
+  clearUnitRuntimeRecord(base, "hook/code-review", "M100/S02/T10");
+  const cleared = readUnitRuntimeRecord(base, "hook/code-review", "M100/S02/T10");
+  assertEq(cleared, null, "hook record removed");
+}
+
 // ─── Must-have durability integration tests ───────────────────────────────
 
 // Create a separate temp base for must-have tests to avoid interference

package/dist/resources/extensions/gsd/tests/visualizer-critical-path.test.ts

@@ -0,0 +1,145 @@
+// Tests for critical path algorithm.
+// Tests computeCriticalPath with known DAG structures.
+
+import { computeCriticalPath } from "../visualizer-data.js";
+import type { VisualizerMilestone } from "../visualizer-data.js";
+import { createTestContext } from "./test-helpers.ts";
+
+const { assertEq, assertTrue, report } = createTestContext();
+
+function makeMs(id: string, status: "complete" | "active" | "pending", dependsOn: string[], slices: any[] = []): VisualizerMilestone {
+  return { id, title: id, status, dependsOn, slices };
+}
+
+function makeSlice(id: string, done: boolean, depends: string[] = []) {
+  return { id, title: id, done, active: false, risk: "low", depends, tasks: [] };
+}
+
+// ─── Linear chain ───────────────────────────────────────────────────────────
+
+console.log("\n=== Critical Path: Linear Chain ===");
+
+{
+  // M001 -> M002 -> M003
+  const milestones = [
+    makeMs("M001", "complete", []),
+    makeMs("M002", "active", ["M001"], [
+      makeSlice("S01", true),
+      makeSlice("S02", false, ["S01"]),
+    ]),
+    makeMs("M003", "pending", ["M002"]),
+  ];
+
+  const cp = computeCriticalPath(milestones);
+  assertTrue(cp.milestonePath.length > 0, "linear chain has critical path");
+  assertTrue(cp.milestonePath.includes("M002"), "M002 is on critical path");
+  assertTrue(cp.milestonePath.includes("M003"), "M003 is on critical path");
+  assertEq(cp.milestoneSlack.get("M002"), 0, "M002 has zero slack");
+  assertEq(cp.milestoneSlack.get("M003"), 0, "M003 has zero slack");
+}
+
+// ─── Diamond DAG ────────────────────────────────────────────────────────────
+
+console.log("\n=== Critical Path: Diamond DAG ===");
+
+{
+  // M001 -> M002 -> M004
+  // M001 -> M003 -> M004
+  // M002 has 3 incomplete slices, M003 has 1 incomplete slice
+  const milestones = [
+    makeMs("M001", "complete", []),
+    makeMs("M002", "active", ["M001"], [
+      makeSlice("S01", false),
+      makeSlice("S02", false),
+      makeSlice("S03", false),
+    ]),
+    makeMs("M003", "pending", ["M001"], [
+      makeSlice("S01", false),
+    ]),
+    makeMs("M004", "pending", ["M002", "M003"]),
+  ];
+
+  const cp = computeCriticalPath(milestones);
+  assertTrue(cp.milestonePath.length >= 2, "diamond DAG has critical path");
+  // M002 has weight 3 (3 incomplete), M003 has weight 1
+  // Critical path should go through M002 (longer)
+  assertTrue(cp.milestonePath.includes("M002"), "M002 (heavier) is on critical path");
+
+  // M003 should have non-zero slack since it's lighter
+  const m003Slack = cp.milestoneSlack.get("M003") ?? -1;
+  assertTrue(m003Slack > 0, "M003 has positive slack (lighter branch)");
+}
+
+// ─── Independent branches ───────────────────────────────────────────────────
+
+console.log("\n=== Critical Path: Independent Branches ===");
+
+{
+  // M001 (no deps), M002 (no deps), M003 (no deps)
+  const milestones = [
+    makeMs("M001", "active", [], [makeSlice("S01", false)]),
+    makeMs("M002", "pending", [], [makeSlice("S01", false), makeSlice("S02", false)]),
+    makeMs("M003", "pending", [], [makeSlice("S01", false)]),
+  ];
+
+  const cp = computeCriticalPath(milestones);
+  assertTrue(cp.milestonePath.length >= 1, "independent branches have at least one critical node");
+  // M002 has the most incomplete slices, should be critical
+  assertTrue(cp.milestonePath.includes("M002"), "M002 (longest) is on critical path");
+}
+
+// ─── Slice-level critical path ──────────────────────────────────────────────
+
+console.log("\n=== Critical Path: Slice-level ===");
+
+{
+  // Active milestone with slice dependencies: S01 -> S02 -> S04, S01 -> S03
+  const milestones = [
+    makeMs("M001", "active", [], [
+      makeSlice("S01", true),
+      makeSlice("S02", false, ["S01"]),
+      makeSlice("S03", false, ["S01"]),
+      makeSlice("S04", false, ["S02"]),
+    ]),
+  ];
+
+  const cp = computeCriticalPath(milestones);
+  assertTrue(cp.slicePath.length > 0, "has slice-level critical path");
+  assertTrue(cp.slicePath.includes("S02"), "S02 is on slice critical path");
+  assertTrue(cp.slicePath.includes("S04"), "S04 is on slice critical path");
+
+  // S03 should have non-zero slack (it's a shorter branch)
+  const s03Slack = cp.sliceSlack.get("S03") ?? -1;
+  assertTrue(s03Slack > 0, "S03 has positive slack (shorter branch)");
+}
+
+// ─── Empty milestones ───────────────────────────────────────────────────────
+
+console.log("\n=== Critical Path: Empty ===");
+
+{
+  const cp = computeCriticalPath([]);
+  assertEq(cp.milestonePath.length, 0, "empty milestones produce empty path");
+  assertEq(cp.slicePath.length, 0, "empty milestones produce empty slice path");
+}
+
+// ─── Single milestone ───────────────────────────────────────────────────────
+
+console.log("\n=== Critical Path: Single Milestone ===");
+
+{
+  const milestones = [
+    makeMs("M001", "active", [], [
+      makeSlice("S01", false),
+      makeSlice("S02", false),
+    ]),
+  ];
+
+  const cp = computeCriticalPath(milestones);
+  assertTrue(cp.milestonePath.length === 1, "single milestone is its own critical path");
+  assertEq(cp.milestonePath[0], "M001", "M001 is the critical node");
+}
+
+// ─── Report ─────────────────────────────────────────────────────────────────
+
+report();

package/dist/resources/extensions/gsd/tests/visualizer-data.test.ts

@@ -35,12 +35,38 @@ assertTrue(
   "exports VisualizerTask interface",
 );
 
+// New interfaces
+assertTrue(
+  dataSrc.includes("export interface CriticalPathInfo"),
+  "exports CriticalPathInfo interface",
+);
+
+assertTrue(
+  dataSrc.includes("export interface AgentActivityInfo"),
+  "exports AgentActivityInfo interface",
+);
+
+assertTrue(
+  dataSrc.includes("export interface ChangelogEntry"),
+  "exports ChangelogEntry interface",
+);
+
+assertTrue(
+  dataSrc.includes("export interface ChangelogInfo"),
+  "exports ChangelogInfo interface",
+);
+
 // Function export
 assertTrue(
   dataSrc.includes("export async function loadVisualizerData"),
   "exports loadVisualizerData function",
 );
 
+assertTrue(
+  dataSrc.includes("export function computeCriticalPath"),
+  "exports computeCriticalPath function",
+);
+
 // Data source usage
 assertTrue(
   dataSrc.includes("deriveState"),
@@ -62,6 +88,11 @@ assertTrue(
   "uses parsePlan for plan parsing",
 );
 
+assertTrue(
+  dataSrc.includes("parseSummary"),
+  "uses parseSummary for changelog parsing",
+);
+
 assertTrue(
   dataSrc.includes("getLedger"),
   "uses getLedger for in-memory metrics",
@@ -113,6 +144,27 @@ assertTrue(
   "VisualizerData has units array",
 );
 
+// New data model fields
+assertTrue(
+  dataSrc.includes("criticalPath: CriticalPathInfo"),
+  "VisualizerData has criticalPath field",
+);
+
+assertTrue(
+  dataSrc.includes("remainingSliceCount: number"),
+  "VisualizerData has remainingSliceCount field",
+);
+
+assertTrue(
+  dataSrc.includes("agentActivity: AgentActivityInfo | null"),
+  "VisualizerData has agentActivity field",
+);
+
+assertTrue(
+  dataSrc.includes("changelog: ChangelogInfo"),
+  "VisualizerData has changelog field",
+);
+
 // Verify overlay source exists and imports data module
 const overlayPath = join(__dirname, "..", "visualizer-overlay.ts");
 const overlaySrc = readFileSync(overlayPath, "utf-8");
@@ -149,6 +201,21 @@ assertTrue(
   "overlay delegates to renderTimelineView",
 );
 
+assertTrue(
+  overlaySrc.includes("renderAgentView"),
+  "overlay delegates to renderAgentView",
+);
+
+assertTrue(
+  overlaySrc.includes("renderChangelogView"),
+  "overlay delegates to renderChangelogView",
+);
+
+assertTrue(
+  overlaySrc.includes("renderExportView"),
+  "overlay delegates to renderExportView",
+);
+
 assertTrue(
   overlaySrc.includes("handleInput"),
   "overlay has handleInput method",
@@ -174,6 +241,31 @@ assertTrue(
   "overlay tracks per-tab scroll offsets",
 );
 
+assertTrue(
+  overlaySrc.includes("filterMode"),
+  "overlay has filterMode state",
+);
+
+assertTrue(
+  overlaySrc.includes("filterText"),
+  "overlay has filterText state",
+);
+
+assertTrue(
+  overlaySrc.includes("filterField"),
+  "overlay has filterField state",
+);
+
+assertTrue(
+  overlaySrc.includes("TAB_COUNT"),
+  "overlay defines TAB_COUNT",
+);
+
+assertTrue(
+  overlaySrc.includes("7 Export"),
+  "overlay has 7 tab labels",
+);
+
 // Verify commands.ts integration
 const commandsPath = join(__dirname, "..", "commands.ts");
 const commandsSrc = readFileSync(commandsPath, "utf-8");

package/dist/resources/extensions/gsd/tests/visualizer-overlay.test.ts

@@ -0,0 +1,120 @@
+// Tests for GSD visualizer overlay.
+// Verifies filter mode, tab switching, and export key handling.
+
+import { readFileSync } from "node:fs";
+import { join, dirname } from "node:path";
+import { fileURLToPath } from "node:url";
+import { createTestContext } from "./test-helpers.ts";
+
+const __dirname = dirname(fileURLToPath(import.meta.url));
+const { assertTrue, assertEq, report } = createTestContext();
+
+const overlaySrc = readFileSync(join(__dirname, "..", "visualizer-overlay.ts"), "utf-8");
+
+console.log("\n=== Overlay: Tab Configuration ===");
+
+assertTrue(
+  overlaySrc.includes("TAB_COUNT = 7"),
+  "TAB_COUNT is 7",
+);
+
+assertTrue(
+  overlaySrc.includes('"1 Progress"'),
+  "has Progress tab label",
+);
+
+assertTrue(
+  overlaySrc.includes('"5 Agent"'),
+  "has Agent tab label",
+);
+
+assertTrue(
+  overlaySrc.includes('"6 Changes"'),
+  "has Changes tab label",
+);
+
+assertTrue(
+  overlaySrc.includes('"7 Export"'),
+  "has Export tab label",
+);
+
+console.log("\n=== Overlay: Filter Mode ===");
+
+assertTrue(
+  overlaySrc.includes('filterMode = false'),
+  "filterMode initialized to false",
+);
+
+assertTrue(
+  overlaySrc.includes('filterText = ""'),
+  "filterText initialized to empty string",
+);
+
+assertTrue(
+  overlaySrc.includes('filterField:'),
+  "has filterField state",
+);
+
+// Filter mode entry via "/"
+assertTrue(
+  overlaySrc.includes('data === "/"') || overlaySrc.includes("data === '/'"),
+  "/ key enters filter mode",
+);
+
+// Filter field cycling via "f"
+assertTrue(
+  overlaySrc.includes('data === "f"') || overlaySrc.includes("data === 'f'"),
+  "f key cycles filter field",
+);
+
+console.log("\n=== Overlay: Tab Switching ===");
+
+// Supports 1-7 keys
+assertTrue(
+  overlaySrc.includes('"1234567"'),
+  "supports keys 1-7 for tab switching",
+);
+
+// Tab wraps with TAB_COUNT
+assertTrue(
+  overlaySrc.includes("% TAB_COUNT"),
+  "tab key wraps around TAB_COUNT",
+);
+
+console.log("\n=== Overlay: Export Key Interception ===");
+
+assertTrue(
+  overlaySrc.includes("activeTab === 6"),
+  "export key handling checks for tab 7 (index 6)",
+);
+
+assertTrue(
+  overlaySrc.includes('handleExportKey'),
+  "has handleExportKey method",
+);
+
+assertTrue(
+  overlaySrc.includes('"m"') && overlaySrc.includes('"j"') && overlaySrc.includes('"s"'),
+  "handles m, j, s keys for export",
+);
+
+console.log("\n=== Overlay: Footer ===");
+
+assertTrue(
+  overlaySrc.includes("Tab/1-7"),
+  "footer hint shows 1-7 tab range",
+);
+
+assertTrue(
+  overlaySrc.includes("/ filter"),
+  "footer hint mentions filter",
+);
+
+console.log("\n=== Overlay: Scroll Offsets ===");
+
+assertTrue(
+  overlaySrc.includes(`new Array(TAB_COUNT).fill(0)`),
+  "scroll offsets sized to TAB_COUNT",
+);
+
+report();