gsd-pi 2.14.1 → 2.14.3

package/dist/resources/extensions/gsd/auto-worktree.ts

@@ -6,7 +6,7 @@
  * manages create, enter, detect, and teardown for auto-mode worktrees.
  */
 
-import { existsSync, readFileSync, realpathSync, utimesSync } from "node:fs";
+import { existsSync, cpSync, readFileSync, realpathSync, utimesSync } from "node:fs";
 import { join, resolve } from "node:path";
 import { execSync, execFileSync } from "node:child_process";
 import {
@@ -90,6 +90,14 @@ export function autoWorktreeBranch(milestoneId: string): string {
 export function createAutoWorktree(basePath: string, milestoneId: string): string {
   const branch = autoWorktreeBranch(milestoneId);
   const info = createWorktree(basePath, milestoneId, { branch });
+
+  // Copy .gsd/ planning artifacts from the source repo into the new worktree.
+  // Worktrees are fresh git checkouts — untracked files don't carry over.
+  // Planning artifacts may be untracked if the project's .gitignore had a
+  // blanket .gsd/ rule (pre-v2.14.0). Without this copy, auto-mode loops
+  // on plan-slice because the plan file doesn't exist in the worktree.
+  copyPlanningArtifacts(basePath, info.path);
+
   const previousCwd = process.cwd();
 
   try {
@@ -107,6 +115,36 @@ export function createAutoWorktree(basePath: string, milestoneId: string): strin
   return info.path;
 }
 
+/**
+ * Copy .gsd/ planning artifacts from source repo to a new worktree.
+ * Copies milestones/, DECISIONS.md, REQUIREMENTS.md, PROJECT.md, QUEUE.md.
+ * Skips runtime files (auto.lock, metrics.json, etc.) and the worktrees/ dir.
+ * Best-effort — failures are non-fatal since auto-mode can recreate artifacts.
+ */
+function copyPlanningArtifacts(srcBase: string, wtPath: string): void {
+  const srcGsd = join(srcBase, ".gsd");
+  const dstGsd = join(wtPath, ".gsd");
+  if (!existsSync(srcGsd)) return;
+
+  // Copy milestones/ directory (planning files, roadmaps, plans, research)
+  const srcMilestones = join(srcGsd, "milestones");
+  if (existsSync(srcMilestones)) {
+    try {
+      cpSync(srcMilestones, join(dstGsd, "milestones"), { recursive: true, force: true });
+    } catch { /* non-fatal */ }
+  }
+
+  // Copy top-level planning files
+  for (const file of ["DECISIONS.md", "REQUIREMENTS.md", "PROJECT.md", "QUEUE.md"]) {
+    const src = join(srcGsd, file);
+    if (existsSync(src)) {
+      try {
+        cpSync(src, join(dstGsd, file), { force: true });
+      } catch { /* non-fatal */ }
+    }
+  }
+}
+
 /**
  * Teardown an auto-worktree: chdir back to original base, then remove
  * the worktree and its branch.

package/dist/resources/extensions/gsd/auto.ts

@@ -1520,7 +1520,7 @@ async function dispatchNextUnit(
     return; // Another dispatch is in progress — bail silently
   }
   _dispatching = true;
-
+  try {
   // Recursion depth guard: when many units are skipped in sequence (e.g., after
   // crash recovery with 10+ completed units), recursive dispatchNextUnit calls
   // can freeze the TUI or overflow the stack. Yield generously after MAX_SKIP_DEPTH.
@@ -2425,6 +2425,9 @@ async function dispatchNextUnit(
     );
     await pauseAuto(ctx, pi);
   }
+  } finally {
+    _dispatching = false;
+  }
 }
 
 // ─── Skill Discovery ──────────────────────────────────────────────────────────

package/dist/resources/extensions/gsd/gitignore.ts

@@ -87,6 +87,28 @@ export function ensureGitignore(basePath: string): boolean {
     existing = readFileSync(gitignorePath, "utf-8");
   }
 
+  // Self-heal: remove blanket ".gsd/" lines from pre-v2.14.0 projects.
+  // The blanket ignore prevented planning artifacts (.gsd/milestones/) from
+  // being tracked in git, causing artifacts to vanish in worktrees and
+  // triggering loop detection failures. Replace with explicit runtime-only
+  // ignores so planning files are tracked naturally.
+  let modified = false;
+  const lines = existing.split("\n");
+  const filteredLines = lines.filter(line => {
+    const trimmed = line.trim();
+    // Remove standalone ".gsd/" lines (blanket ignore) but keep specific
+    // .gsd/ subpath patterns like ".gsd/activity/" or ".gsd/auto.lock"
+    if (trimmed === ".gsd/" || trimmed === ".gsd") {
+      modified = true;
+      return false;
+    }
+    return true;
+  });
+  if (modified) {
+    existing = filteredLines.join("\n");
+    writeFileSync(gitignorePath, existing, "utf-8");
+  }
+
   // Parse existing lines (trimmed, ignoring comments and blanks)
   const existingLines = new Set(
     existing
@@ -98,7 +120,7 @@ export function ensureGitignore(basePath: string): boolean {
   // Find patterns not yet present
   const missing = BASELINE_PATTERNS.filter((p) => !existingLines.has(p));
 
-  if (missing.length === 0) return false;
+  if (missing.length === 0) return modified;
 
   // Build the block to append
   const block = [

package/dist/resources/extensions/gsd/prompts/discuss.md

@@ -91,13 +91,19 @@ Do not count the reflection step as a question round. Rounds start after reflect
 
 ## Depth Verification
 
-Before moving to the wrap-up gate, present a structured depth summary to the user via `ask_user_questions`. This is a checkpoint — show what you captured across the depth checklist dimensions, using the user's own terminology and framing.
+Before moving to the wrap-up gate, present a structured depth summary as a checkpoint.
 
-The question should summarize: what you understood them to be building, what shaped your understanding most (their emphasis, constraints, concerns), and any areas where you're least confident in your understanding. Frame it as: "Before we move to planning, here's what I captured — did I get the depth right?"
+**Print the summary as normal chat text first** — this is where the formatting renders properly. Structure the summary across the depth checklist dimensions using the user's own terminology and framing. Cover: what you understood them to be building, what shaped your understanding most (their emphasis, constraints, concerns), and any areas where you're least confident in your understanding.
 
-**Convention:** The question ID must contain `depth_verification` (e.g., `depth_verification_summary`). This naming convention enables downstream mechanical detection of this step.
+**Then** use `ask_user_questions` with a short confirmation question — NOT the summary itself. The question field is designed for single sentences, not multi-paragraph summaries.
 
-Offer two options: "Yes, you got it (Recommended)" and "Not quite — let me clarify." If they clarify, absorb the correction and re-verify.
+**Convention:** The question ID must contain `depth_verification` (e.g., `depth_verification_confirm`). This naming convention enables downstream mechanical detection of this step.
+
+Example flow:
+1. Print in chat: the full depth summary with markdown formatting (headers, bold, bullets)
+2. Call `ask_user_questions` with: header "Depth Check", question "Did I capture the depth right?", options "Yes, you got it (Recommended)" and "Not quite — let me clarify"
+
+If they clarify, absorb the correction and re-verify.
 
 ## Wrap-up Gate
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "gsd-pi",
-  "version": "2.14.1",
+  "version": "2.14.3",
   "description": "GSD — Get Shit Done coding agent",
   "license": "MIT",
   "repository": {

package/src/resources/extensions/gsd/auto-worktree.ts

@@ -6,7 +6,7 @@
  * manages create, enter, detect, and teardown for auto-mode worktrees.
  */
 
-import { existsSync, readFileSync, realpathSync, utimesSync } from "node:fs";
+import { existsSync, cpSync, readFileSync, realpathSync, utimesSync } from "node:fs";
 import { join, resolve } from "node:path";
 import { execSync, execFileSync } from "node:child_process";
 import {
@@ -90,6 +90,14 @@ export function autoWorktreeBranch(milestoneId: string): string {
 export function createAutoWorktree(basePath: string, milestoneId: string): string {
   const branch = autoWorktreeBranch(milestoneId);
   const info = createWorktree(basePath, milestoneId, { branch });
+
+  // Copy .gsd/ planning artifacts from the source repo into the new worktree.
+  // Worktrees are fresh git checkouts — untracked files don't carry over.
+  // Planning artifacts may be untracked if the project's .gitignore had a
+  // blanket .gsd/ rule (pre-v2.14.0). Without this copy, auto-mode loops
+  // on plan-slice because the plan file doesn't exist in the worktree.
+  copyPlanningArtifacts(basePath, info.path);
+
   const previousCwd = process.cwd();
 
   try {
@@ -107,6 +115,36 @@ export function createAutoWorktree(basePath: string, milestoneId: string): strin
   return info.path;
 }
 
+/**
+ * Copy .gsd/ planning artifacts from source repo to a new worktree.
+ * Copies milestones/, DECISIONS.md, REQUIREMENTS.md, PROJECT.md, QUEUE.md.
+ * Skips runtime files (auto.lock, metrics.json, etc.) and the worktrees/ dir.
+ * Best-effort — failures are non-fatal since auto-mode can recreate artifacts.
+ */
+function copyPlanningArtifacts(srcBase: string, wtPath: string): void {
+  const srcGsd = join(srcBase, ".gsd");
+  const dstGsd = join(wtPath, ".gsd");
+  if (!existsSync(srcGsd)) return;
+
+  // Copy milestones/ directory (planning files, roadmaps, plans, research)
+  const srcMilestones = join(srcGsd, "milestones");
+  if (existsSync(srcMilestones)) {
+    try {
+      cpSync(srcMilestones, join(dstGsd, "milestones"), { recursive: true, force: true });
+    } catch { /* non-fatal */ }
+  }
+
+  // Copy top-level planning files
+  for (const file of ["DECISIONS.md", "REQUIREMENTS.md", "PROJECT.md", "QUEUE.md"]) {
+    const src = join(srcGsd, file);
+    if (existsSync(src)) {
+      try {
+        cpSync(src, join(dstGsd, file), { force: true });
+      } catch { /* non-fatal */ }
+    }
+  }
+}
+
 /**
  * Teardown an auto-worktree: chdir back to original base, then remove
  * the worktree and its branch.

package/src/resources/extensions/gsd/auto.ts

@@ -1520,7 +1520,7 @@ async function dispatchNextUnit(
     return; // Another dispatch is in progress — bail silently
   }
   _dispatching = true;
-
+  try {
   // Recursion depth guard: when many units are skipped in sequence (e.g., after
   // crash recovery with 10+ completed units), recursive dispatchNextUnit calls
   // can freeze the TUI or overflow the stack. Yield generously after MAX_SKIP_DEPTH.
@@ -2425,6 +2425,9 @@ async function dispatchNextUnit(
     );
     await pauseAuto(ctx, pi);
   }
+  } finally {
+    _dispatching = false;
+  }
 }
 
 // ─── Skill Discovery ──────────────────────────────────────────────────────────

package/src/resources/extensions/gsd/gitignore.ts

@@ -87,6 +87,28 @@ export function ensureGitignore(basePath: string): boolean {
     existing = readFileSync(gitignorePath, "utf-8");
   }
 
+  // Self-heal: remove blanket ".gsd/" lines from pre-v2.14.0 projects.
+  // The blanket ignore prevented planning artifacts (.gsd/milestones/) from
+  // being tracked in git, causing artifacts to vanish in worktrees and
+  // triggering loop detection failures. Replace with explicit runtime-only
+  // ignores so planning files are tracked naturally.
+  let modified = false;
+  const lines = existing.split("\n");
+  const filteredLines = lines.filter(line => {
+    const trimmed = line.trim();
+    // Remove standalone ".gsd/" lines (blanket ignore) but keep specific
+    // .gsd/ subpath patterns like ".gsd/activity/" or ".gsd/auto.lock"
+    if (trimmed === ".gsd/" || trimmed === ".gsd") {
+      modified = true;
+      return false;
+    }
+    return true;
+  });
+  if (modified) {
+    existing = filteredLines.join("\n");
+    writeFileSync(gitignorePath, existing, "utf-8");
+  }
+
   // Parse existing lines (trimmed, ignoring comments and blanks)
   const existingLines = new Set(
     existing
@@ -98,7 +120,7 @@ export function ensureGitignore(basePath: string): boolean {
   // Find patterns not yet present
   const missing = BASELINE_PATTERNS.filter((p) => !existingLines.has(p));
 
-  if (missing.length === 0) return false;
+  if (missing.length === 0) return modified;
 
   // Build the block to append
   const block = [

package/src/resources/extensions/gsd/prompts/discuss.md

@@ -91,13 +91,19 @@ Do not count the reflection step as a question round. Rounds start after reflect
 
 ## Depth Verification
 
-Before moving to the wrap-up gate, present a structured depth summary to the user via `ask_user_questions`. This is a checkpoint — show what you captured across the depth checklist dimensions, using the user's own terminology and framing.
+Before moving to the wrap-up gate, present a structured depth summary as a checkpoint.
 
-The question should summarize: what you understood them to be building, what shaped your understanding most (their emphasis, constraints, concerns), and any areas where you're least confident in your understanding. Frame it as: "Before we move to planning, here's what I captured — did I get the depth right?"
+**Print the summary as normal chat text first** — this is where the formatting renders properly. Structure the summary across the depth checklist dimensions using the user's own terminology and framing. Cover: what you understood them to be building, what shaped your understanding most (their emphasis, constraints, concerns), and any areas where you're least confident in your understanding.
 
-**Convention:** The question ID must contain `depth_verification` (e.g., `depth_verification_summary`). This naming convention enables downstream mechanical detection of this step.
+**Then** use `ask_user_questions` with a short confirmation question — NOT the summary itself. The question field is designed for single sentences, not multi-paragraph summaries.
 
-Offer two options: "Yes, you got it (Recommended)" and "Not quite — let me clarify." If they clarify, absorb the correction and re-verify.
+**Convention:** The question ID must contain `depth_verification` (e.g., `depth_verification_confirm`). This naming convention enables downstream mechanical detection of this step.
+
+Example flow:
+1. Print in chat: the full depth summary with markdown formatting (headers, bold, bullets)
+2. Call `ask_user_questions` with: header "Depth Check", question "Did I capture the depth right?", options "Yes, you got it (Recommended)" and "Not quite — let me clarify"
+
+If they clarify, absorb the correction and re-verify.
 
 ## Wrap-up Gate