gscan 6.2.0 → 6.2.1

package/lib/ast-linter/rules/lint-no-unknown-custom-theme-settings.js

@@ -6,7 +6,7 @@ module.exports = class NoUnknownCustomThemeSettings extends Rule {
             const name = node.parts[1];
             if (!this.isValidCustomThemeSettingReference(name)) {
                 this.log({
-                    message: `Missing Custom Theme Setting: "${name}"`,
+                    message: `Unknown {{@custom.${name}}} on line ${node.loc && node.loc.start.line}: ${this.sourceForNode(node)}`,
                     line: node.loc && node.loc.start.line,
                     column: node.loc && node.loc.start.column,
                     source: this.sourceForNode(node)

package/lib/checks/100-custom-template-settings-usage.js

@@ -26,12 +26,12 @@ const ruleImplementations = {
             const config = Object.keys(theme.customSettings);
             const notUsedVariable = config.filter(x => !result.customThemeSettings.has(x));
 
-            if (notUsedVariable.length > 0) {
+            notUsedVariable.forEach((name) => {
                 log.failure({
-                    message: `Found unused variables: ${notUsedVariable.map(x => '@custom.' + x).join(', ')}`,
+                    message: `config.custom.${name} is declared but never referenced from a template`,
                     ref: 'package.json'
                 });
-            }
+            });
         }
     }
 };

package/lib/specs/v4.js

@@ -172,9 +172,9 @@ let rules = {
     },
     'GS090-NO-UNKNOWN-CUSTOM-THEME-SETTINGS': {
         level: 'error',
-        rule: 'An unknown custom theme setting has been used.',
         fatal: false,
-        details: oneLineTrim`The custom theme setting should all be defined in the package.json <code>config.custom</code> object.`
+        rule: 'Remove or correct the unknown <code>{{@custom}}</code> setting',
+        details: oneLineTrim`Every <code>{{@custom.<i>name</i>}}</code> reference in a template needs a matching entry in <code>config.custom</code> in <code>package.json</code>. An unrecognised setting renders as empty. See the <a href="${docsBaseUrl}custom-settings/" target=_blank>custom settings documentation</a> for details.`
     },
     'GS090-NO-UNKNOWN-CUSTOM-THEME-SELECT-VALUE-IN-MATCH': {
         level: 'error',
@@ -209,8 +209,8 @@ let rules = {
 
     'GS100-NO-UNUSED-CUSTOM-THEME-SETTING': {
         level: 'error',
-        rule: 'A custom theme setting defined in <code>package.json</code> hasn\'t been used in any theme file.',
-        details: oneLineTrim`Custom theme settings defined in <code>package.json</code> must be used at least once in the theme templates.`
+        rule: 'Use or remove the unused <code>config.custom</code> setting',
+        details: oneLineTrim`A setting declared in <code>config.custom</code> in <code>package.json</code> appears in the admin Customize panel but has no effect unless referenced from a template with <code>{{@custom.<i>name</i>}}</code>. Either use the setting from a template or drop it from <code>package.json</code>. See the <a href="${docsBaseUrl}custom-settings/" target=_blank>custom settings documentation</a> for details.`
     },
 
     'GS050-CSS-KGCO': cssCardRule('callout', 'kg-callout-card'),

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "gscan",
-  "version": "6.2.0",
+  "version": "6.2.1",
   "description": "Scans Ghost themes looking for errors, deprecations, features and compatibility",
   "keywords": [
     "ghost",
@@ -44,14 +44,14 @@
   },
   "dependencies": {
     "@sentry/node": "10.53.1",
-    "@tryghost/config": "2.2.0",
-    "@tryghost/debug": "2.2.0",
-    "@tryghost/errors": "3.2.1",
-    "@tryghost/logging": "4.2.1",
+    "@tryghost/config": "2.2.1",
+    "@tryghost/debug": "2.2.1",
+    "@tryghost/errors": "3.2.2",
+    "@tryghost/logging": "5.0.1",
     "@tryghost/nql": "0.12.10",
-    "@tryghost/pretty-cli": "3.2.0",
-    "@tryghost/server": "2.2.1",
-    "@tryghost/zip": "3.3.1",
+    "@tryghost/pretty-cli": "3.2.1",
+    "@tryghost/server": "3.0.1",
+    "@tryghost/zip": "3.3.2",
     "chalk": "5.6.2",
     "express": "5.2.1",
     "express-handlebars": "8.0.1",
@@ -59,7 +59,7 @@
     "handlebars": "4.7.9",
     "lodash": "4.18.1",
     "multer": "2.1.1",
-    "semver": "7.8.0",
+    "semver": "7.8.1",
     "validator": "^13.0.0"
   },
   "devDependencies": {
@@ -67,16 +67,11 @@
     "@eslint/eslintrc": "3.3.5",
     "@eslint/js": "10.0.1",
     "@tryghost/pro-ship": "1.0.10",
-    "@vitest/coverage-v8": "4.1.6",
+    "@vitest/coverage-v8": "4.1.7",
     "eslint": "10.4.0",
     "eslint-plugin-ghost": "3.5.0",
     "nodemon": "3.1.14",
-    "vitest": "4.1.6"
-  },
-  "resolutions": {
-    "node-loggly-bulk": "4.0.2",
-    "node-loggly-bulk/axios": "1.16.0",
-    "**/handlebars": "4.7.9"
+    "vitest": "4.1.7"
   },
   "files": [
     "lib",