gscan 5.2.5 → 5.3.0

package/app/index.js

@@ -5,35 +5,70 @@ const sentry = require('@sentry/node');
 // Require rest of the modules
 const express = require('express');
 const debug = require('@tryghost/debug')('app');
-const hbs = require('express-hbs');
+const {create} = require('express-handlebars');
 const multer = require('multer');
 const server = require('@tryghost/server');
 const config = require('@tryghost/config');
 const errors = require('@tryghost/errors');
 const gscan = require('../lib');
 const fs = require('fs-extra');
+const path = require('path');
 const logRequest = require('./middlewares/log-request');
 const uploadValidation = require('./middlewares/upload-validation');
 const ghostVer = require('./ghost-version');
-const pkgJson = require('../package.json');
 const ghostVersions = require('../lib/utils').versions;
 const upload = multer({dest: __dirname + '/uploads/'});
 const app = express();
-const scanHbs = hbs.create();
+const viewsDir = path.join(__dirname, 'tpl');
+const scanHbs = create({
+    extname: '.hbs',
+    partialsDir: path.join(viewsDir, 'partials'),
+    layoutsDir: path.join(viewsDir, 'layouts'),
+    defaultLayout: 'default',
+    helpers: {
+        block(name, options) {
+            const root = options.data && options.data.root;
+
+            if (!root) {
+                return typeof options.fn === 'function' ? options.fn(this) : '';
+            }
+
+            const blockCache = root.blockCache || {};
+            let val = blockCache[name];
+
+            if (val === undefined && typeof options.fn === 'function') {
+                val = options.fn(this);
+            }
+
+            if (Array.isArray(val)) {
+                val = val.join('\n');
+            }
+
+            return val;
+        },
+        contentFor(name, options) {
+            const root = options.data && options.data.root;
+
+            if (!root) {
+                return '';
+            }
+
+            const blockCache = root.blockCache || (root.blockCache = {});
+            const block = blockCache[name] || (blockCache[name] = []);
+            block.push(options.fn(this));
+            return '';
+        }
+    }
+});
 
 // Configure express
 app.set('x-powered-by', false);
 app.set('query parser', false);
 
-app.engine('hbs', scanHbs.express4({
-    partialsDir: __dirname + '/tpl/partials',
-    layoutsDir: __dirname + '/tpl/layouts',
-    defaultLayout: __dirname + '/tpl/layouts/default',
-    templateOptions: {data: {version: pkgJson.version}}
-}));
+app.engine('hbs', scanHbs.engine);
 
 app.set('view engine', 'hbs');
-app.set('views', __dirname + '/tpl');
+app.set('views', viewsDir);
 
 app.use(logRequest);
 app.use(express.static(__dirname + '/public'));
@@ -58,25 +93,29 @@ app.post('/',
         debug('Uploaded: ' + zip.name + ' to ' + zip.path);
         debug('Version to check: ' + options.checkVersion);
 
+        let checkError;
+
         gscan.checkZip(zip, options)
             .then(function processResult(theme) {
                 debug('Checked: ' + zip.name);
                 res.theme = theme;
-
+            }).catch(function (error) {
+                checkError = error;
+            }).finally(function () {
                 debug('attempting to remove: ' + req.file.path);
                 fs.remove(req.file.path)
-                    .then(function () {
-                        debug('Calling next');
-                        return next();
+                    .catch(function (removeError) {
+                        debug('failed to remove uploaded file', removeError);
                     })
-                    .catch(function () {
-                        // NOTE: transform to `.finally(...) once package is compatible with node >=10
+                    .then(function () {
+                        if (checkError) {
+                            debug('Calling next with error');
+                            return next(checkError);
+                        }
+
                         debug('Calling next');
                         return next();
                     });
-            }).catch(function (error) {
-                debug('Calling next with error');
-                return next(error);
             });
     },
     function doRender(req, res) {

package/app/middlewares/log-request.js

@@ -1,4 +1,4 @@
-var uuid = require('uuid'),
+var randomUUID = require('crypto').randomUUID,
     logging = require('@tryghost/logging');
 
 /**
@@ -7,7 +7,7 @@ var uuid = require('uuid'),
  */
 module.exports = function logRequest(req, res, next) {
     var startTime = Date.now(),
-        requestId = uuid.v1();
+        requestId = randomUUID();
 
     function logResponse() {
         res.responseTime = (Date.now() - startTime) + 'ms';

package/bin/cli.js

@@ -153,11 +153,14 @@ function outputResult(result, options) {
     ui.log(''); // extra line-break
 }
 
+function formatCount(word, count) {
+    return `${count} ${count === 1 ? word : `${word}s`}`;
+}
+
 function getSummary(theme, options) {
     let summaryText = '';
     const errorCount = theme.results.error.length;
     const warnCount = theme.results.warning.length;
-    const pluralize = require('pluralize');
     const checkSymbol = '\u2713';
 
     if (errorCount === 0 && warnCount === 0) {
@@ -170,7 +173,7 @@ function getSummary(theme, options) {
         summaryText = `Your theme has`;
 
         if (!_.isEmpty(theme.results.error)) {
-            summaryText += chalk.red.bold(` ${pluralize('error', theme.results.error.length, true)}`);
+            summaryText += chalk.red.bold(` ${formatCount('error', theme.results.error.length)}`);
         }
 
         if (!_.isEmpty(theme.results.error) && !_.isEmpty(theme.results.warning)) {
@@ -178,7 +181,7 @@ function getSummary(theme, options) {
         }
 
         if (!_.isEmpty(theme.results.warning)) {
-            summaryText += chalk.yellow.bold(` ${pluralize('warning', theme.results.warning.length, true)}`);
+            summaryText += chalk.yellow.bold(` ${formatCount('warning', theme.results.warning.length)}`);
         }
 
         summaryText += '!';

package/lib/ast-linter/rules/internal/scope.js

@@ -215,11 +215,7 @@ class Scope {
         let matchedFrame = null;
 
         if (this.frames && this.frames.length) {
-            matchedFrame = this.frames.find((frame) => {
-                if (frame.nodeName === context) {
-                    return true;
-                }
-            });
+            matchedFrame = this.frames.find(frame => frame.nodeName === context);
         }
 
         return matchedFrame && matchedFrame.node;

package/lib/checker.js

@@ -1,5 +1,6 @@
 const _ = require('lodash');
-const requireDir = require('require-dir');
+const nodeFs = require('fs');
+const nodePath = require('path');
 const debug = require('@tryghost/debug')('checker');
 
 const errors = require('@tryghost/errors');
@@ -10,6 +11,18 @@ const versions = require('./utils').versions;
 const labsEnabledHelpers = {
 };
 
+function loadChecks() {
+    const checksDir = nodePath.join(__dirname, 'checks');
+
+    return nodeFs.readdirSync(checksDir)
+        .filter(fileName => fileName.endsWith('.js'))
+        .reduce((checks, fileName) => {
+            const checkName = nodePath.basename(fileName, '.js');
+            checks[checkName] = require(nodePath.join(checksDir, fileName));
+            return checks;
+        }, {});
+}
+
 /**
  * Check theme
  *
@@ -25,7 +38,7 @@ const labsEnabledHelpers = {
  */
 const check = async function checkAll(themePath, options = {}) {
     // Require checks late to avoid loading all until used
-    const checks = options.skipChecks === true ? [] : requireDir('./checks');
+    const checks = options.skipChecks === true ? {} : loadChecks();
     const passedVersion = _.get(options, 'checkVersion', versions.default);
     let version = passedVersion;
 
@@ -90,18 +103,12 @@ const checkZip = async function checkZip(path, options) {
         zip = _.clone(path);
     }
 
+    let extractedZipPath;
+
     try {
         const readZip = require('./read-zip');
-        const {path: extractedZipPath} = await readZip(zip);
-        const theme = await check(extractedZipPath, Object.assign({themeName: zip.name}, options));
-
-        if (options.keepExtractedDir) {
-            return theme;
-        } else {
-            const fs = require('fs-extra');
-            await fs.remove(zip.origPath);
-            return theme;
-        }
+        ({path: extractedZipPath} = await readZip(zip));
+        return await check(extractedZipPath, Object.assign({themeName: zip.name}, options));
     } catch (error) {
         if (!errors.utils.isGhostError(error)) {
             throw new errors.ValidationError({
@@ -114,6 +121,11 @@ const checkZip = async function checkZip(path, options) {
         }
 
         throw error;
+    } finally {
+        if (!options.keepExtractedDir && zip.origPath) {
+            const fs = require('fs-extra');
+            await fs.remove(zip.origPath);
+        }
     }
 };
 

package/lib/read-zip.js

@@ -1,30 +1,32 @@
 const debug = require('@tryghost/debug')('zip');
 const path = require('path');
 const os = require('os');
-const glob = require('glob');
+const {randomUUID} = require('crypto');
+const {glob} = require('glob');
 const {extract} = require('@tryghost/zip');
 const errors = require('@tryghost/errors');
-const uuid = require('uuid');
 const _ = require('lodash');
 
-const resolveBaseDir = (zipPath) => {
-    return new Promise((resolve) => {
-        glob('**/index.hbs', {cwd: zipPath, nosort: true}, function (err, matches) {
-            var matchedPath;
+const resolveBaseDir = async (zipPath) => {
+    let matches = [];
 
-            if (!err && !_.isEmpty(matches)) {
-                debug('Found matches', matches);
-                matchedPath = matches[0].replace(/index\.hbs$/, '');
-                zipPath = path.join(zipPath, matchedPath).replace(/\/$/, '');
-            }
+    try {
+        matches = await glob('**/index.hbs', {cwd: zipPath, nosort: true});
+    } catch (err) {
+        debug('Glob match error while resolving zip base dir', err);
+    }
 
-            return resolve(zipPath);
-        });
-    });
+    if (!_.isEmpty(matches)) {
+        debug('Found matches', matches);
+        const matchedPath = matches[0].replace(/index\.hbs$/, '');
+        zipPath = path.join(zipPath, matchedPath).replace(/\/$/, '');
+    }
+
+    return zipPath;
 };
 
 const readZip = (zip) => {
-    const tempUuid = uuid.v4();
+    const tempUuid = randomUUID();
     const tempPath = os.tmpdir() + '/' + tempUuid;
 
     debug('Reading Zip', zip.path, 'into', tempPath);

package/lib/specs/v1.js

@@ -3,9 +3,9 @@
  *
  * This file contains details of the theme API spec, in a format that can be used by GScan
  */
-const oneLineTrim = require('common-tags/lib/oneLineTrim');
+const oneLineTrim = require('../utils/one-line-trim');
 const docsBaseUrl = `https://ghost.org/docs/themes/`;
-let knownHelpers, templates, rules, ruleNext; // eslint-disable-line no-unused-vars
+let knownHelpers, templates, rules, ruleNext;
 
 knownHelpers = [
     // Ghost
@@ -99,8 +99,7 @@ rules = {
         details: oneLineTrim`The <code>{{image}}</code> helper was replaced with the <code>{{img_url}}</code> helper.<br>
         Depending on the context of the <code>{{img_url}}</code> helper you would need to use e. g. <br><br><code>{{#post}}<br>&nbsp;&nbsp;&nbsp;&nbsp;{{img_url feature_image}}<br>{{/post}}</code><br><br>to render the feature image of the blog post.<br>
         <br><b>If you are using <code>{{if image}}</code></b>, then you have to replace it with e.g. <code>{{if feature_image}}.</code>
-        <br><br>Find more information about the <code>{{img_url}}</code> helper <a href="${docsBaseUrl}helpers/img_url/" target=_blank>here</a> and
-        read more about Ghost's usage of contexts <a href="${docsBaseUrl}contexts/" target=_blank>here</a>.`,
+        <br><br>Find more information about the <code>{{img_url}}</code> helper <a href="${docsBaseUrl}helpers/img_url/" target=_blank>here</a> and read more about Ghost's usage of contexts <a href="${docsBaseUrl}contexts/" target=_blank>here</a>.`,
         regex: /{{\s*?image\b[\w\s='"]*?}}/g,
         helper: '{{image}}'
     },
@@ -365,22 +364,18 @@ rules = {
         level: 'error',
         rule: 'Replace <code>{{id}}</code> with <code>{{comment_id}}</code> in Disqus embeds.',
         fatal: true,
-        details: oneLineTrim`The output of <code>{{id}}</code> has changed in v1.0.0 from an incremental ID to an ObjectID.
-        This results in Disqus comments not loading in Ghost v1.0.0 posts which were imported from earlier versions.
-        To resolve this, we've added a <code>{{comment_id}}</code> helper that will output the old ID
-        for posts that have been imported from earlier versions, and ID for new posts.
-        The Disqus embed must be updated from <code>this.page.identifier = 'ghost-{{id}}';</code> to
-        <code>this.page.identifier = 'ghost-{{comment_id}}';</code> to ensure Disqus continues to work.`,
+        details: oneLineTrim`The output of <code>{{id}}</code> has changed in v1.0.0 from an incremental ID to an ObjectID.<br>
+        This results in Disqus comments not loading in Ghost v1.0.0 posts which were imported from earlier versions.<br>
+        To resolve this, we've added a <code>{{comment_id}}</code> helper that will output the old ID for posts that have been imported from earlier versions, and ID for new posts.<br>
+        The Disqus embed must be updated from <code>this.page.identifier = 'ghost-{{id}}';</code> to <code>this.page.identifier = 'ghost-{{comment_id}}';</code> to ensure Disqus continues to work.`,
         regex: /(page\.|disqus_)identifier\s?=\s?['"].*?({{\s*?id\s*?}}).*?['"];?/g
     },
     'GS002-ID-HELPER': {
         level: 'recommendation',
         rule: 'The output of <code>{{id}}</code> changed in Ghost v1.0.0, you may need to use <code>{{comment_id}}</code> instead.',
-        details: oneLineTrim`The output of <code>{{id}}</code> has changed in v1.0.0 from an incremental ID to an ObjectID.
-        In v1.0.0 we added a <code>{{comment_id}}</code> helper that will output the old ID
-        for posts that have been imported from earlier versions, and ID for new posts.
-        If you need the old ID to be output on imported posts, then you will need to use
-        <code>{{comment_id}}</code> rather than <code>{{id}}</code>.`,
+        details: oneLineTrim`The output of <code>{{id}}</code> has changed in v1.0.0 from an incremental ID to an ObjectID.<br>
+        In v1.0.0 we added a <code>{{comment_id}}</code> helper that will output the old ID for posts that have been imported from earlier versions, and ID for new posts.<br>
+        If you need the old ID to be output on imported posts, then you will need to use <code>{{comment_id}}</code> rather than <code>{{id}}</code>.`,
         regex: /({{\s*?id\s*?}})/g
     },
     'GS005-TPL-ERR': {
@@ -400,7 +395,8 @@ rules = {
         level: 'error',
         rule: '<code>package.json</code> file can be parsed',
         details: oneLineTrim`Your <code>package.json</code> file couldn't be parsed. This is mostly caused by a missing or unnecessary <code>','</code> or the wrong usage of <code>'""'</code>.<br>
-        Check the <a href="${docsBaseUrl}structure/#package-json" target=_blank><code>package.json</code> documentation</a> for further information.`
+        Check the <a href="${docsBaseUrl}structure/#package-json" target=_blank><code>package.json</code> documentation</a> for further information.<br>
+        A good reference for your <code>package.json</code> file is always the latest version of <a href="https://github.com/TryGhost/Casper/blob/master/package.json" target=_blank>Casper</a>.`
     },
     'GS010-PJ-NAME-LC': {
         level: 'error',

package/lib/specs/v2.js

@@ -1,5 +1,5 @@
 const _ = require('lodash');
-const oneLineTrim = require('common-tags/lib/oneLineTrim');
+const oneLineTrim = require('../utils/one-line-trim');
 const previousSpec = require('./v1');
 const ghostVersions = require('../utils').versions;
 const docsBaseUrl = `https://ghost.org/docs/themes/`;
@@ -68,8 +68,7 @@ let rules = {
     'GS001-DEPR-AUTHBL': {
         level: 'error',
         rule: 'Replace <code>{{#author}}</code> with <code>{{#primary_author}}</code> or <code>{{#foreach authors}}...{{/foreach}}</code>',
-        details: oneLineTrim`The usage of <code>{{#author}}</code> block helper outside of <code>author.hbs</code> is deprecated and
-        should be replaced with <code>{{#primary_author}}</code> or <code>{{#foreach authors}}...{{/foreach}}</code>.<br>
+        details: oneLineTrim`The usage of <code>{{#author}}</code> block helper outside of <code>author.hbs</code> is deprecated and should be replaced with <code>{{#primary_author}}</code> or <code>{{#foreach authors}}...{{/foreach}}</code>.<br>
         Find more information about the <code>{{authors}}</code> helper <a href="${docsBaseUrl}helpers/authors/" target=_blank>here</a>.`,
         regex: /{{\s*?#author\s*?}}/g,
         notValidIn: 'author.hbs',
@@ -395,7 +394,7 @@ let rules = {
         level: 'error',
         rule: 'The <code>{{@blog}}</code> helper should be replaced with <code>{{@site}}</code>',
         details: oneLineTrim`With the introduction of the Content API <code>{{@blog}}</code> became deprecated in favour of <code>{{@site}}</code>.<br>
-        The <code>{{@blog}}</code> helper will be removed in next version of Ghost and should not be used.
+        The <code>{{@blog}}</code> helper will be removed in next version of Ghost and should not be used.<br>
         Find more information about the <code>@site</code> property <a href="${docsBaseUrl}helpers/site/" target=_blank>here</a>.`,
         regex: /{{\s*?@blog\.[a-zA-Z0-9_]+\s*?}}/g,
         helper: '{{@blog}}'
@@ -404,7 +403,7 @@ let rules = {
         level: 'error',
         rule: '<code>{{@blog.permalinks}}</code> was removed',
         details: oneLineTrim`With the introduction of Dynamic Routing, you can define multiple permalinks.<br>
-        The <code>{{@blog.permalinks}}</code> property will therefore no longer be used and should be removed from the theme.
+        The <code>{{@blog.permalinks}}</code> property will therefore no longer be used and should be removed from the theme.<br>
         Find more information about Ghost data helpers <a href="${docsBaseUrl}helpers/data/" target=_blank>here</a>.`,
         regex: /{{\s*?@blog\.permalinks\s*?}}/g,
         helper: '{{@blog.permalinks}}'
@@ -413,7 +412,7 @@ let rules = {
         level: 'error',
         rule: '<code>{{@site.permalinks}}</code> was removed',
         details: oneLineTrim`With the introduction of Dynamic Routing, you can define multiple permalinks.<br>
-        The <code>{{@site.permalinks}}</code> property will therefore no longer be used and should be removed from the theme.
+        The <code>{{@site.permalinks}}</code> property will therefore no longer be used and should be removed from the theme.<br>
         Find more information about the <code>@site</code> property <a href="${docsBaseUrl}helpers/site/" target=_blank>here</a>.`,
         regex: /{{\s*?@site\.permalinks\s*?}}/g,
         helper: '{{@site.permalinks}}'
@@ -422,7 +421,7 @@ let rules = {
         level: 'error',
         rule: 'Replace <code>{{@site.ghost_head}}</code> with <code>{{ghost_head}}</code>',
         details: oneLineTrim`The usage of <code>{{@site.ghost_head}}</code> is deprecated and should be replaced with <code>{{ghost_head}}</code>.<br>
-        The <code>{{@site.ghost_head}}</code> property will therefore no longer be used and should be removed from the theme.
+        The <code>{{@site.ghost_head}}</code> property will therefore no longer be used and should be removed from the theme.<br>
         Find more information about the <code>{{ghost_head}}</code> property <a href="${docsBaseUrl}helpers/ghost_head_foot/" target=_blank>here</a>.`,
         regex: /{{\s*?@site\.ghost_head\s*?}}/g,
         helper: '{{@site.ghost_head}}'
@@ -431,7 +430,7 @@ let rules = {
         level: 'error',
         rule: 'Replace <code>{{@site.ghost_foot}}</code> with <code>{{ghost_foot}}</code>',
         details: oneLineTrim`The usage of <code>{{@site.ghost_foot}}</code> is deprecated and should be replaced with <code>{{ghost_foot}}</code>.<br>
-        The <code>{{@site.ghost_foot}}</code> property will therefore no longer be used and should be removed from the theme.
+        The <code>{{@site.ghost_foot}}</code> property will therefore no longer be used and should be removed from the theme.<br>
         Find more information about the <code>{{ghost_foot}}</code> property <a href="${docsBaseUrl}helpers/ghost_head_foot/" target=_blank>here</a>.`,
         regex: /{{\s*?@site\.ghost_foot\s*?}}/g,
         helper: '{{@site.ghost_foot}}'
@@ -440,7 +439,7 @@ let rules = {
         level: 'error',
         rule: 'The <code>{{lang}}</code> helper should be replaced with <code>{{@site.lang}}</code>',
         details: oneLineTrim`The <code>{{lang}}</code> helper is a duplicate of <code>{{@site.lang}}</code>. Using <code>{{@site.lang}}</code> is preferred.<br>
-        The <code>{{lang}}</code> helper will be removed in next version of Ghost and should not be used.
+        The <code>{{lang}}</code> helper will be removed in next version of Ghost and should not be used.<br>
         Find more information about the <code>@site.lang</code> property <a href="${docsBaseUrl}helpers/site/" target=_blank>here</a>.`,
         regex: /{{\s*?lang\s*?}}/g,
         helper: '{{lang}}'
@@ -448,8 +447,8 @@ let rules = {
     'GS001-DEPR-CSS-KGMD': {
         level: 'warning',
         rule: `<code>.kg-card-markdown</code> doesn't exist in current version of Ghost, ensure your theme works without it`,
-        details: oneLineTrim`The <code>.kg-card-markdown</code> CSS class is deprecated and will no longer be used in Ghost.
-        It's recommended to add your own wrapper around the <code>{{content}}</code> helper and target that instead if needed.
+        details: oneLineTrim`The <code>.kg-card-markdown</code> CSS class is deprecated and will no longer be used in Ghost.<br>
+        It's recommended to add your own wrapper around the <code>{{content}}</code> helper and target that instead if needed.<br>
         Find out more about required theme changes for the Koenig editor <a href="${docsBaseUrl}content/" target=_blank>here</a>.`,
         regex: /\.kg-card-markdown/g,
         className: '.kg-card-markdown',

package/lib/specs/v3.js

@@ -1,5 +1,5 @@
 const _ = require('lodash');
-const oneLineTrim = require('common-tags/lib/oneLineTrim');
+const oneLineTrim = require('../utils/one-line-trim');
 const previousSpec = require('./v2');
 const ghostVersions = require('../utils').versions;
 const docsBaseUrl = `https://ghost.org/docs/themes/`;
@@ -35,7 +35,7 @@ let rules = {
         level: 'error',
         rule: 'Replace <code>{{error.code}}</code> with <code>{{error.statusCode}}</code>',
         details: oneLineTrim`The usage of <code>{{error.code}}</code> is deprecated and should be replaced with <code>{{error.statusCode}}</code>.<br>
-        When in <code>error</code> context, e. g. in the <code>error.hbs</code> template, replace <code>{{code}}</code> with <code>{{statusCode}}</code>.<br>
+        When in <code>error</code> context, e.g. in the <code>error.hbs</code> template, replace <code>{{code}}</code> with <code>{{statusCode}}</code>.<br>
         Find more information about the <code>error.hbs</code> template <a href="${docsBaseUrl}structure/#error-hbs" target=_blank>here</a>.`,
         regex: /{{\s*?(?:error\.)?(code)\s*?}}/g,
         helper: '{{error.code}}'

package/lib/specs/v4.js

@@ -1,5 +1,5 @@
 const _ = require('lodash');
-const oneLineTrim = require('common-tags/lib/oneLineTrim');
+const oneLineTrim = require('../utils/one-line-trim');
 const previousSpec = require('./v3');
 const ghostVersions = require('../utils').versions;
 const docsBaseUrl = `https://ghost.org/docs/themes/`;
@@ -109,7 +109,7 @@ let rules = {
         level: 'warning',
         rule: 'The <code>{{@labs.members}}</code> helper should not be used.',
         details: oneLineTrim`Remove <code>{{@labs.members}}</code> from the theme.<br>
-        The <code>{{@labs.members}}</code> helper will always return <code>true</code> in Ghost v4 and will be removed from Ghost v5, at which point it will return <code>null</code> and evaluate to <code>false</code>.
+        The <code>{{@labs.members}}</code> helper will always return <code>true</code> in Ghost v4 and will be removed from Ghost v5, at which point it will return <code>null</code> and evaluate to <code>false</code>.<br>
         Find more information about the <code>@labs</code> property <a href="${docsBaseUrl}helpers/labs/" target=_blank>here</a>.`,
         regex: /@labs\.members/g,
         helper: '{{@labs.members}}'
@@ -126,7 +126,7 @@ let rules = {
     'GS080-CARD-LAST4': {
         level: 'warning',
         rule: 'The <code>default_payment_card_last4</code> field now coalesces to <code>****</code> in Ghost 4.x instead of null.',
-        details: oneLineTrim`The <code>default_payment_card_last4</code> field no longer outputs a falsy(null) value in case of missing card details starting from Ghost 4.x and instead coalesces to <code>****</code>
+        details: oneLineTrim`The <code>default_payment_card_last4</code> field no longer outputs a falsy(null) value in case of missing card details starting from Ghost 4.x and instead coalesces to <code>****</code><br>
         Find more information about the <code>default_payment_card_last4</code> attribute <a href="${docsBaseUrl}members/#subscription-attributes" target=_blank>here</a>.`,
         regex: /default_payment_card_last4/g,
         helper: '{{default_payment_card_last4}}',
@@ -144,7 +144,7 @@ let rules = {
     'GS001-DEPR-CURR-SYM': {
         level: 'warning',
         rule: 'Replace <code>{{[#].currency_symbol}}</code> with <code>{{price currency=currency}}</code>.',
-        details: oneLineTrim`The hardcoded <code>currency_symbol</code> attribute was removed in favour of passing the currency to updated <code>{{price}}</code> helper.
+        details: oneLineTrim`The hardcoded <code>currency_symbol</code> attribute was removed in favour of passing the currency to updated <code>{{price}}</code> helper.<br>
         Find more information about the updated <code>{{price}}</code> helper <a href="${docsBaseUrl}members/#the-price-helper" target=_blank>here</a>.`,
         helper: '{{[#].currency_symbol}}',
         regex: /currency_symbol/g
@@ -153,7 +153,7 @@ let rules = {
         level: 'warning',
         rule: 'Replace <code>{{@site.lang}}</code> with <code>{{@site.locale}}</code>',
         details: oneLineTrim`Replace <code>{{@site.lang}}</code> helper with <code>{{@site.locale}}</code>.<br>
-        The <code>{{@site.lang}}</code> helper will be removed in next version of Ghost and should not be used.
+        The <code>{{@site.lang}}</code> helper will be removed in next version of Ghost and should not be used.<br>
         Find more information about the <code>@site</code> property <a href="${docsBaseUrl}helpers/site/" target=_blank>here</a>.`,
         regex: /@site\.lang/g,
         helper: '{{@site.lang}}'
@@ -214,17 +214,17 @@ let rules = {
     },
 
     'GS050-CSS-KGCO': cssCardRule('callout', 'kg-callout-card'),
-    'GS050-CSS-KGCOE': cssCardRule('callout', 'kg-callout-card-emoji'),
-    'GS050-CSS-KGCOT': cssCardRule('callout', 'kg-callout-card-text'),
-    'GS050-CSS-KGCOBGGY': cssCardRule('callout', 'kg-callout-card-background-grey'),
-    'GS050-CSS-KGCOBGW': cssCardRule('callout', 'kg-callout-card-background-white'),
-    'GS050-CSS-KGCOBGB': cssCardRule('callout', 'kg-callout-card-background-blue'),
-    'GS050-CSS-KGCOBGGN': cssCardRule('callout', 'kg-callout-card-background-green'),
-    'GS050-CSS-KGCOBGY': cssCardRule('callout', 'kg-callout-card-background-yellow'),
-    'GS050-CSS-KGCOBGR': cssCardRule('callout', 'kg-callout-card-background-red'),
-    'GS050-CSS-KGCOBGPK': cssCardRule('callout', 'kg-callout-card-background-pink'),
-    'GS050-CSS-KGCOBGPE': cssCardRule('callout', 'kg-callout-card-background-purple'),
-    'GS050-CSS-KGCOBGA': cssCardRule('callout', 'kg-callout-card-background-accent'),
+    'GS050-CSS-KGCOE': cssCardRule('callout', 'kg-callout-emoji'),
+    'GS050-CSS-KGCOT': cssCardRule('callout', 'kg-callout-text'),
+    'GS050-CSS-KGCOBGGY': cssCardRule('callout', 'kg-callout-card-grey'),
+    'GS050-CSS-KGCOBGW': cssCardRule('callout', 'kg-callout-card-white'),
+    'GS050-CSS-KGCOBGB': cssCardRule('callout', 'kg-callout-card-blue'),
+    'GS050-CSS-KGCOBGGN': cssCardRule('callout', 'kg-callout-card-green'),
+    'GS050-CSS-KGCOBGY': cssCardRule('callout', 'kg-callout-card-yellow'),
+    'GS050-CSS-KGCOBGR': cssCardRule('callout', 'kg-callout-card-red'),
+    'GS050-CSS-KGCOBGPK': cssCardRule('callout', 'kg-callout-card-pink'),
+    'GS050-CSS-KGCOBGPE': cssCardRule('callout', 'kg-callout-card-purple'),
+    'GS050-CSS-KGCOBGA': cssCardRule('callout', 'kg-callout-card-accent'),
 
     'GS050-CSS-KG-NFT': cssCardRule('nft', 'kg-nft-card'),
     'GS050-CSS-KG-NFTCO': cssCardRule('nft', 'kg-nft-card-container'),
@@ -232,7 +232,7 @@ let rules = {
     'GS050-CSS-KG-NFTIMG': cssCardRule('nft', 'kg-nft-image'),
     'GS050-CSS-KG-NFTHD': cssCardRule('nft', 'kg-nft-header'),
     'GS050-CSS-KG-NFTTIT': cssCardRule('nft', 'kg-nft-title'),
-    'GS050-CSS-KG-NFTLG': cssCardRule('nft', 'kg-nft-logo'),
+    'GS050-CSS-KG-NFTLG': cssCardRule('nft', 'kg-nft-opensea-logo'),
     'GS050-CSS-KG-NFTCTR': cssCardRule('nft', 'kg-nft-creator'),
     'GS050-CSS-KG-NFTDSC': cssCardRule('nft', 'kg-nft-description'),
 
@@ -264,10 +264,7 @@ let rules = {
     'GS050-CSS-KGVIDCNT': cssCardRule('video', 'kg-video-container'),
     'GS050-CSS-KGVIDOVL': cssCardRule('video', 'kg-video-overlay'),
     'GS050-CSS-KGVIDLGPLICO': cssCardRule('video', 'kg-video-large-play-icon'),
-    'GS050-CSS-KGVIDTHUMB': cssCardRule('video', 'kg-video-thumbnail'),
-    'GS050-CSS-KGVIDTHUMBPL': cssCardRule('video', 'kg-video-thumbnail.placeholder'),
     'GS050-CSS-KGVIDPLCNT': cssCardRule('video', 'kg-video-player-container'),
-    'GS050-CSS-KGVIDTI': cssCardRule('video', 'kg-video-title'),
     'GS050-CSS-KGVIDPL': cssCardRule('video', 'kg-video-player'),
     'GS050-CSS-KGVIDCURRTM': cssCardRule('video', 'kg-video-current-time'),
     'GS050-CSS-KGVIDTM': cssCardRule('video', 'kg-video-time'),

package/lib/specs/v5.js

@@ -1,5 +1,5 @@
 const _ = require('lodash');
-const oneLineTrim = require('common-tags/lib/oneLineTrim');
+const oneLineTrim = require('../utils/one-line-trim');
 const previousSpec = require('./v4');
 const ghostVersions = require('../utils').versions;
 const docsBaseUrl = `https://ghost.org/docs/themes/`;

package/lib/specs/v6.js

@@ -1,5 +1,5 @@
 const _ = require('lodash');
-const oneLineTrim = require('common-tags/lib/oneLineTrim');
+const oneLineTrim = require('../utils/one-line-trim');
 const previousSpec = require('./v5');
 const docsBaseUrl = `https://docs.ghost.org/themes/`;
 

package/lib/utils/one-line-trim.js

@@ -0,0 +1,10 @@
+function oneLineTrim(strings, ...values) {
+    const combined = strings.reduce((result, str, index) => {
+        const value = index < values.length ? values[index] : '';
+        return result + str + value;
+    }, '');
+
+    return combined.replace(/(?:\n\s*)/g, '').trim();
+}
+
+module.exports = oneLineTrim;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "gscan",
-  "version": "5.2.5",
+  "version": "5.3.0",
   "description": "Scans Ghost themes looking for errors, deprecations, features and compatibility",
   "keywords": [
     "ghost",
@@ -17,7 +17,7 @@
     "registry": "https://registry.npmjs.org/"
   },
   "engines": {
-    "node": "^14.18.0 || ^16.13.0 || ^18.12.1 || ^20.11.1 || ^22.13.1"
+    "node": "^20.11.1 || ^22.13.1 || ^24.0.0"
   },
   "bugs": {
     "url": "https://github.com/TryGhost/gscan/issues"
@@ -33,7 +33,7 @@
     "start": "node app/index.js",
     "dev": "NODE_ENV=development DEBUG=gscan:* nodemon",
     "lint": "eslint . --ext .js --cache",
-    "test": "NODE_ENV=testing c8 mocha test/*.test.js",
+    "test": "NODE_ENV=testing c8 --check-coverage --branches 95 --functions 95 --lines 95 --statements 95 mocha test/*.test.js",
     "posttest": "yarn lint",
     "preship": "yarn test",
     "ship": "pro-ship",
@@ -43,38 +43,35 @@
     "gscan": "./bin/cli.js"
   },
   "dependencies": {
-    "@sentry/node": "^9.0.0",
-    "@tryghost/config": "^0.2.18",
-    "@tryghost/debug": "^0.1.26",
-    "@tryghost/errors": "^1.2.26",
-    "@tryghost/logging": "^2.4.7",
-    "@tryghost/nql": "^0.12.5",
-    "@tryghost/pretty-cli": "^1.2.38",
-    "@tryghost/server": "^0.1.37",
-    "@tryghost/zip": "^1.1.42",
-    "chalk": "^4.1.2",
-    "common-tags": "^1.8.2",
-    "express": "^4.18.2",
-    "express-hbs": "^2.4.2",
-    "fs-extra": "^11.1.1",
-    "glob": "^8.1.0",
-    "lodash": "^4.17.21",
-    "multer": "^2.0.0",
-    "pluralize": "^8.0.0",
-    "require-dir": "^1.2.0",
-    "semver": "^7.5.4",
-    "uuid": "^9.0.1",
+    "@sentry/node": "10.40.0",
+    "@tryghost/config": "2.0.0",
+    "@tryghost/debug": "2.0.0",
+    "@tryghost/errors": "3.0.0",
+    "@tryghost/logging": "4.0.0",
+    "@tryghost/nql": "0.12.10",
+    "@tryghost/pretty-cli": "3.0.0",
+    "@tryghost/server": "2.0.0",
+    "@tryghost/zip": "3.0.0",
+    "chalk": "5.6.2",
+    "express": "5.2.1",
+    "express-handlebars": "7.1.3",
+    "fs-extra": "11.3.3",
+    "glob": "13.0.6",
+    "lodash": "4.17.23",
+    "multer": "2.1.0",
+    "semver": "7.7.4",
     "validator": "^13.0.0"
   },
   "devDependencies": {
+    "@eslint/compat": "2.0.2",
+    "@eslint/js": "10.0.1",
     "@tryghost/pro-ship": "1.0.7",
-    "c8": "8.0.1",
-    "eslint": "8.1.0",
-    "eslint-plugin-ghost": "2.1.0",
+    "c8": "11.0.0",
+    "eslint": "10.0.2",
+    "eslint-plugin-ghost": "3.4.4",
     "mocha": "11.7.5",
-    "node-fetch": "3.3.2",
-    "nodemon": "2.0.7",
-    "rewire": "6.0.0",
+    "nodemon": "3.1.14",
+    "rewire": "9.0.1",
     "should": "13.2.3",
     "sinon": "21.0.1"
   },
@@ -82,14 +79,5 @@
     "lib",
     "bin",
     "app"
-  ],
-  "renovate": {
-    "extends": [
-      "@tryghost:quietJS",
-      "@tryghost:automergeDevDependencies"
-    ],
-    "ignoreDeps": [
-      "validator"
-    ]
-  }
+  ]
 }

package/app/public/.eslintrc.js

@@ -1,7 +0,0 @@
-/* eslint-env node */
-module.exports = {
-    plugins: ['ghost'],
-    extends: [
-        'plugin:ghost/browser'
-    ]
-};