gscan 5.2.0 → 5.2.2

package/lib/ast-linter/rules/mark-used-custom-theme-settings.js

@@ -7,9 +7,36 @@ module.exports = class MarkUsedCustomThemeSettings extends Rule {
         }
     }
 
+    // `get` helpers support using handlebars expressions in their filter attribute
+    // Handlebars does not parse these expressions within StringLiterals itself,
+    // so we need to manually check for them here.
+    _checkGetHelperAttributes(node) {
+        // Only check 'get' helpers
+        if (node.path && node.path.original !== 'get') {
+            return;
+        }
+
+        // Check hash parameters (named attributes like filter="...")
+        if (node.hash && node.hash.pairs) {
+            node.hash.pairs.forEach((pair) => {
+                // Only check the 'filter' attribute
+                if (pair.key === 'filter' && pair.value.type === 'StringLiteral') {
+                    // Search for @custom.* references in the string value
+                    const customThemeSettingRegex = /@custom\.([a-z0-9_]+)/g;
+                    let match;
+                    while ((match = customThemeSettingRegex.exec(pair.value.value)) !== null) {
+                        this.scanner.context.customThemeSettings.push(match[1]);
+                    }
+                }
+            });
+        }
+    }
+
     visitor() {
         return {
-            PathExpression: this._markUsedCustomThemeSettings.bind(this)
+            PathExpression: this._markUsedCustomThemeSettings.bind(this),
+            SubExpression: this._checkGetHelperAttributes.bind(this),
+            BlockStatement: this._checkGetHelperAttributes.bind(this)
         };
     }
 };

package/lib/specs/v6.js

@@ -15,7 +15,7 @@ let rules = {
         level: 'warning',
         rule: 'Using <code>limit="all"</code> in <code>{{#get}}</code> helper is not supported',
         details: oneLineTrim`In Ghost 6.0 and later, <code>limit="all"</code> will return at most 100 results. Consider using a specific limit number or implementing pagination instead.<br>
-        Find more information about the <code>{{#get}}</code> helper <a href="${docsBaseUrl}helpers/get/" target=_blank>here</a>.`,
+        Find more information about the <code>{{#get}}</code> helper <a href="${docsBaseUrl}helpers/functional/get/" target=_blank>here</a>.`,
         helper: '{{#get}}'
     },
     'GS090-NO-LIMIT-OVER-100-IN-GET-HELPER': {
@@ -23,7 +23,7 @@ let rules = {
         rule: 'Using <code>limit</code> values greater than 100 in <code>{{#get}}</code> helper is not supported',
         details: oneLineTrim`Ghost automatically caps <code>limit</code> values at 100, so using higher values will not return more results.
         Consider using pagination or setting the limit to 100 or lower.<br>
-        Find more information about the <code>{{#get}}</code> helper <a href="${docsBaseUrl}helpers/get/" target=_blank>here</a>.`,
+        Find more information about the <code>{{#get}}</code> helper <a href="${docsBaseUrl}helpers/functional/get/" target=_blank>here</a>.`,
         helper: '{{#get}}'
     },
     'GS001-DEPR-TWITTER-URL': {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "gscan",
-  "version": "5.2.0",
+  "version": "5.2.2",
   "description": "Scans Ghost themes looking for errors, deprecations, features and compatibility",
   "keywords": [
     "ghost",
@@ -71,12 +71,12 @@
     "c8": "8.0.1",
     "eslint": "8.1.0",
     "eslint-plugin-ghost": "2.1.0",
-    "mocha": "11.7.4",
+    "mocha": "11.7.5",
     "node-fetch": "3.3.2",
     "nodemon": "2.0.7",
     "rewire": "6.0.0",
     "should": "13.2.3",
-    "sinon": "21.0.0"
+    "sinon": "21.0.1"
   },
   "files": [
     "lib",