gscan 4.49.6 → 5.0.0

package/README.md

@@ -6,7 +6,7 @@
 
 GScan is a tool for validating Ghost themes. It produces detailed reports of issues where themes need to be modified in order to be compatible with a specific version.
 
-It is actively capable of dealing with the current and last major versions of Ghost (so at the time of writing v4, v3, v2 and v1).
+It is actively capable of dealing with the current and last major versions of Ghost (v1-v6).
 
 GScan works on a system of rules. Each rule has a way to check whether it passes or fails and has help content which describes how to fix it. Each rule is also marked with an error level:
 
@@ -49,14 +49,14 @@ By default, GScan scans themes for the latest Ghost version compatibility. You c
 `--v2` or `-2`
 `--v3` or `-3`
 `--v4` or `-4`
-`--v5` or `-5` (default)
-`--v6` or `-6` or `--canary`
+`--v5` or `-5`
+`--v6` or `-6` (default) or `--canary`
 
 Examples:
 
 `gscan /path/to/theme.zip -z -1` - scan a theme in a zip file for Ghost 1.0 compatibility
 `gscan /path/to/theme/directory --v2` - can a theme in a directory for Ghost 2.0 compatibility
-`gscan /path/to/theme/directory` - scan a theme for Ghost 5.0 compatibility
+`gscan /path/to/theme/directory` - scan a theme for Ghost 6.0 compatibility
 
 ### 4. Lib usage
 
@@ -71,8 +71,8 @@ gscan.checkZip({
     // if you need to check the theme for a different
     // major Ghost version, you can pass it. Currently
     // v1, v2, v3, v4, v5 and v6 are supported. Default is
-    // the latest Ghost version 5.0:
-    // checkVersion: 'v5',
+    // the latest Ghost version 6.0:
+    // checkVersion: 'v6',
     name: 'my-theme'
 }).then(function (result) {
     console.log(result);

package/app/tpl/index.hbs

@@ -22,8 +22,8 @@
                 <span class="gh-input-icon select-arrow">{{> icon-arrow-up}}</span>
                 <span class="gh-input-icon select-arrow active">{{> icon-arrow-down}}</span>
                 <select class="gh-input gh-select" name="version" id="version">
-                    <option value="v6">{{ghostVersions.v6.major}}</option>
-                    <option value="v5" selected>{{ghostVersions.v5.major}}</option>
+                    <option value="v6" selected>{{ghostVersions.v6.major}}</option>
+                    <option value="v5">{{ghostVersions.v5.major}}</option>
                     <option value="v4">{{ghostVersions.v4.major}}</option>
                     <option value="v3">{{ghostVersions.v3.major}}</option>
                     <option value="v2">{{ghostVersions.v2.major}}</option>

package/lib/ast-linter/rules/index.js

@@ -13,6 +13,7 @@ module.exports = {
     'GS090-NO-PRICE-DATA-CURRENCY-CONTEXT': require('./lint-no-price-data-currency-context'),
     'GS090-NO-PRICE-DATA-MONTHLY-YEARLY': require('./lint-no-price-data-monthly-yearly'),
     'GS090-NO-LIMIT-ALL-IN-GET-HELPER': require('./lint-no-limit-all-in-get-helper'),
+    'GS090-NO-LIMIT-OVER-100-IN-GET-HELPER': require('./lint-no-limit-over-100-in-get-helper'),
     'GS110-NO-UNKNOWN-PAGE-BUILDER-USAGE': require('./lint-no-unknown-page-properties'),
     'GS120-NO-UNKNOWN-GLOBALS': require('./lint-no-unknown-globals'),
     'no-multi-param-conditionals': require('./lint-no-multi-param-conditionals'),

package/lib/ast-linter/rules/lint-no-limit-over-100-in-get-helper.js

@@ -0,0 +1,34 @@
+const Rule = require('./base');
+const {getNodeName} = require('../helpers');
+
+module.exports = class NoLimitOver100InGetHelper extends Rule {
+    _checkForLimitOver100(node) {
+        const nodeName = getNodeName(node);
+
+        if (nodeName === 'get' && node.hash && node.hash.pairs && node.hash.pairs.length > 0) {
+            const limitPair = node.hash.pairs.find(pair => pair.key === 'limit');
+
+            if (limitPair && limitPair.value) {
+                // Handle both string literals and quoted values
+                const limitValue = limitPair.value.value || limitPair.value.original;
+
+                // Parse the limit value as a number
+                const numericLimit = parseInt(limitValue, 10);
+
+                if (!isNaN(numericLimit) && numericLimit > 100) {
+                    this.log({
+                        line: node.loc && node.loc.start.line,
+                        column: node.loc && node.loc.start.column,
+                        source: this.sourceForNode(node)
+                    });
+                }
+            }
+        }
+    }
+
+    visitor() {
+        return {
+            BlockStatement: this._checkForLimitOver100.bind(this)
+        };
+    }
+};

package/lib/specs/v6.js

@@ -18,12 +18,20 @@ let rules = {
         Find more information about the <code>{{#get}}</code> helper <a href="${docsBaseUrl}helpers/get/" target=_blank>here</a>.`,
         helper: '{{#get}}'
     },
+    'GS090-NO-LIMIT-OVER-100-IN-GET-HELPER': {
+        level: 'warning',
+        rule: 'Using <code>limit</code> values greater than 100 in <code>{{#get}}</code> helper is not supported',
+        details: oneLineTrim`Ghost automatically caps <code>limit</code> values at 100, so using higher values will not return more results.
+        Consider using pagination or setting the limit to 100 or lower.<br>
+        Find more information about the <code>{{#get}}</code> helper <a href="${docsBaseUrl}helpers/get/" target=_blank>here</a>.`,
+        helper: '{{#get}}'
+    },
     'GS001-DEPR-AMP-TEMPLATE': {
         level: 'warning',
         rule: 'AMP templates are no longer supported in Ghost 6.0',
         details: 'AMP support was removed in Ghost 6.0. Remove AMP templates and use responsive design instead.',
         // Matches <html amp> or <html ⚡>, with or without other attributes mixed in
-        regex: /<html\s+(?:amp|⚡)(?:\s|>)|<html\s+[^>]*\s(?:amp|⚡)(?:\s|>)/i 
+        regex: /<html\s+(?:amp|⚡)(?:\s|>)|<html\s+[^>]*\s(?:amp|⚡)(?:\s|>)/i
     }
 };
 

package/lib/utils/versions.json

@@ -23,6 +23,6 @@
     "major": "6.x",
     "docs": "6.0.0"
   },
-  "default": "v5",
+  "default": "v6",
   "canary": "v6"
-}
+}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "gscan",
-  "version": "4.49.6",
+  "version": "5.0.0",
   "description": "Scans Ghost themes looking for errors, deprecations, features and compatibility",
   "keywords": [
     "ghost",