gscan 4.49.5 → 4.49.7

package/app/tpl/index.hbs

@@ -22,6 +22,7 @@
                 <span class="gh-input-icon select-arrow">{{> icon-arrow-up}}</span>
                 <span class="gh-input-icon select-arrow active">{{> icon-arrow-down}}</span>
                 <select class="gh-input gh-select" name="version" id="version">
+                    <option value="v6">{{ghostVersions.v6.major}}</option>
                     <option value="v5" selected>{{ghostVersions.v5.major}}</option>
                     <option value="v4">{{ghostVersions.v4.major}}</option>
                     <option value="v3">{{ghostVersions.v3.major}}</option>

package/lib/ast-linter/rules/index.js

@@ -12,6 +12,8 @@ module.exports = {
     'GS090-NO-PRICE-DATA-CURRENCY-GLOBAL': require('./lint-no-price-data-currency-global'),
     'GS090-NO-PRICE-DATA-CURRENCY-CONTEXT': require('./lint-no-price-data-currency-context'),
     'GS090-NO-PRICE-DATA-MONTHLY-YEARLY': require('./lint-no-price-data-monthly-yearly'),
+    'GS090-NO-LIMIT-ALL-IN-GET-HELPER': require('./lint-no-limit-all-in-get-helper'),
+    'GS090-NO-LIMIT-OVER-100-IN-GET-HELPER': require('./lint-no-limit-over-100-in-get-helper'),
     'GS110-NO-UNKNOWN-PAGE-BUILDER-USAGE': require('./lint-no-unknown-page-properties'),
     'GS120-NO-UNKNOWN-GLOBALS': require('./lint-no-unknown-globals'),
     'no-multi-param-conditionals': require('./lint-no-multi-param-conditionals'),

package/lib/ast-linter/rules/lint-no-limit-all-in-get-helper.js

@@ -0,0 +1,31 @@
+const Rule = require('./base');
+const {getNodeName} = require('../helpers');
+
+module.exports = class NoLimitAllInGetHelper extends Rule {
+    _checkForLimitAll(node) {
+        const nodeName = getNodeName(node);
+
+        if (nodeName === 'get' && node.hash && node.hash.pairs && node.hash.pairs.length > 0) {
+            const limitPair = node.hash.pairs.find(pair => pair.key === 'limit');
+
+            if (limitPair && limitPair.value) {
+                // Handle both string literals and quoted values
+                const limitValue = limitPair.value.value || limitPair.value.original;
+
+                if (limitValue === 'all') {
+                    this.log({
+                        line: node.loc && node.loc.start.line,
+                        column: node.loc && node.loc.start.column,
+                        source: this.sourceForNode(node)
+                    });
+                }
+            }
+        }
+    }
+
+    visitor() {
+        return {
+            BlockStatement: this._checkForLimitAll.bind(this)
+        };
+    }
+};

package/lib/ast-linter/rules/lint-no-limit-over-100-in-get-helper.js

@@ -0,0 +1,34 @@
+const Rule = require('./base');
+const {getNodeName} = require('../helpers');
+
+module.exports = class NoLimitOver100InGetHelper extends Rule {
+    _checkForLimitOver100(node) {
+        const nodeName = getNodeName(node);
+
+        if (nodeName === 'get' && node.hash && node.hash.pairs && node.hash.pairs.length > 0) {
+            const limitPair = node.hash.pairs.find(pair => pair.key === 'limit');
+
+            if (limitPair && limitPair.value) {
+                // Handle both string literals and quoted values
+                const limitValue = limitPair.value.value || limitPair.value.original;
+
+                // Parse the limit value as a number
+                const numericLimit = parseInt(limitValue, 10);
+
+                if (!isNaN(numericLimit) && numericLimit > 100) {
+                    this.log({
+                        line: node.loc && node.loc.start.line,
+                        column: node.loc && node.loc.start.column,
+                        source: this.sourceForNode(node)
+                    });
+                }
+            }
+        }
+    }
+
+    visitor() {
+        return {
+            BlockStatement: this._checkForLimitOver100.bind(this)
+        };
+    }
+};

package/lib/specs/v6.js

@@ -1,15 +1,39 @@
 const _ = require('lodash');
+const oneLineTrim = require('common-tags/lib/oneLineTrim');
 const previousSpec = require('./v5');
+const docsBaseUrl = `https://ghost.org/docs/themes/`;
 
 const previousKnownHelpers = previousSpec.knownHelpers;
 const previousTemplates = previousSpec.templates;
 const previousRules = previousSpec.rules;
 
 // assign new or overwrite existing knownHelpers, templates, or rules here:
-// Currently no new rules for v6
 let knownHelpers = [];
 let templates = [];
-let rules = {};
+let rules = {
+    'GS090-NO-LIMIT-ALL-IN-GET-HELPER': {
+        level: 'warning',
+        rule: 'Using <code>limit="all"</code> in <code>{{#get}}</code> helper is not supported',
+        details: oneLineTrim`In Ghost 6.0 and later, <code>limit="all"</code> will return at most 100 results. Consider using a specific limit number or implementing pagination instead.<br>
+        Find more information about the <code>{{#get}}</code> helper <a href="${docsBaseUrl}helpers/get/" target=_blank>here</a>.`,
+        helper: '{{#get}}'
+    },
+    'GS090-NO-LIMIT-OVER-100-IN-GET-HELPER': {
+        level: 'warning',
+        rule: 'Using <code>limit</code> values greater than 100 in <code>{{#get}}</code> helper is not supported',
+        details: oneLineTrim`Ghost automatically caps <code>limit</code> values at 100, so using higher values will not return more results.
+        Consider using pagination or setting the limit to 100 or lower.<br>
+        Find more information about the <code>{{#get}}</code> helper <a href="${docsBaseUrl}helpers/get/" target=_blank>here</a>.`,
+        helper: '{{#get}}'
+    },
+    'GS001-DEPR-AMP-TEMPLATE': {
+        level: 'warning',
+        rule: 'AMP templates are no longer supported in Ghost 6.0',
+        details: 'AMP support was removed in Ghost 6.0. Remove AMP templates and use responsive design instead.',
+        // Matches <html amp> or <html ⚡>, with or without other attributes mixed in
+        regex: /<html\s+(?:amp|⚡)(?:\s|>)|<html\s+[^>]*\s(?:amp|⚡)(?:\s|>)/i
+    }
+};
 
 knownHelpers = _.union(previousKnownHelpers, knownHelpers);
 templates = _.union(previousTemplates, templates);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "gscan",
-  "version": "4.49.5",
+  "version": "4.49.7",
   "description": "Scans Ghost themes looking for errors, deprecations, features and compatibility",
   "keywords": [
     "ghost",
@@ -71,7 +71,7 @@
     "c8": "8.0.1",
     "eslint": "8.1.0",
     "eslint-plugin-ghost": "2.1.0",
-    "mocha": "11.7.0",
+    "mocha": "11.7.1",
     "node-fetch": "3.3.2",
     "nodemon": "2.0.7",
     "rewire": "6.0.0",