gscan 4.45.0 → 4.46.0

package/lib/checks/051-custom-fonts-css-properties.js

@@ -0,0 +1,51 @@
+const _ = require('lodash');
+const spec = require('../specs');
+const versions = require('../utils').versions;
+
+const checkCustomFontsCssProperties = function checkCustomFontsCssProperties(theme, options) {
+    const checkVersion = _.get(options, 'checkVersion', versions.default);
+    let ruleSet = spec.get([checkVersion]);
+
+    // CASE: 051-custom-fonts-css-properties checks only needs `rules` that start with `GS051-`
+    const ruleRegex = /GS051-.*/g;
+
+    ruleSet = _.pickBy(ruleSet.rules, function (rule, ruleCode) {
+        if (ruleCode.match(ruleRegex)) {
+            return rule;
+        }
+    });
+
+    _.each(ruleSet, function (check, ruleCode) {
+        if (theme.files) {
+            // Check CSS files and HBS files for presence of the classes
+            _.each(theme.files, function (themeFile) {
+                if (!['.css', '.hbs'].includes(themeFile.ext)) {
+                    return;
+                }
+
+                try {
+                    let cssPresent = themeFile.content.match(check.regex);
+
+                    if (cssPresent && theme.results.pass.indexOf(ruleCode) === -1) {
+                        theme.results.pass.push(ruleCode);
+                    }
+                } catch (err) {
+                    // ignore for now
+                }
+            });
+        }
+
+        if (!theme.files || (theme.results.pass.indexOf(ruleCode) === -1 && !Object.prototype.hasOwnProperty.call(theme.results.fail, ruleCode))) {
+            theme.results.fail[ruleCode] = {};
+            theme.results.fail[ruleCode].failures = [
+                {
+                    ref: 'styles'
+                }
+            ];
+        }
+    });
+
+    return theme;
+};
+
+module.exports = checkCustomFontsCssProperties;

package/lib/specs/canary.js

@@ -750,6 +750,12 @@ let rules = {
         rule: 'Add a string to translate to the <code>{{t}}</code> helper',
         regex: /{{\s*t\s*(["'“”]?)\s*\1?\s*}}/g,
         details: oneLineTrim`Translate helper <code>{{t}}</code> expects a string. Example: <code>{{ t "Hello world" }}</code>. Find more information about the translate helper <a href="${docsBaseUrl}helpers/translate" target=_blank>here</a>.`
+    },
+    'GS051-CUSTOM-FONTS': {
+        level: 'warning',
+        rule: `Missing support for custom fonts`,
+        details: oneLineTrim`CSS variables for Ghost font settings are not present: <code>--gh-font-heading</code>, <code>--gh-font-body</code>`,
+        regex: /^(?=[\s\S]*--gh-font-heading)(?=[\s\S]*--gh-font-body)/
     }
 };
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "gscan",
-  "version": "4.45.0",
+  "version": "4.46.0",
   "description": "Scans Ghost themes looking for errors, deprecations, features and compatibility",
   "keywords": [
     "ghost",
@@ -72,7 +72,7 @@
     "eslint": "8.1.0",
     "eslint-plugin-ghost": "2.1.0",
     "istanbul": "0.4.5",
-    "mocha": "10.7.3",
+    "mocha": "10.8.2",
     "node-fetch": "3.3.2",
     "nodemon": "2.0.7",
     "rewire": "6.0.0",