gscan 4.37.3 → 4.37.4

package/lib/ast-linter/rules/internal/scope.js

@@ -8,7 +8,8 @@ const ghostGlobals = {
     setting: true, // TODO: we should remove this but the Journal theme is using it atm
     config: true,
     labs: true,
-    custom: true
+    custom: true,
+    page: true
 };
 
 // unless we update AST to check that we're within a foreach block, we need to allowlist all of these as they look the same as globals

package/lib/checks/110-page-builder-usage.js

@@ -116,10 +116,7 @@ function parseWithAST({theme, log, file, rules, callback}) {
 
 const ruleImplementations = {
     'GS110-NO-MISSING-PAGE-BUILDER-USAGE': {
-        isEnabled: ({options}) => {
-            // TODO: change to `isEnabled: true` when removing labs flag
-            return options && options.labs && options.labs.pageImprovements;
-        },
+        isEnabled: true,
         init: ({result}) => {
             result.pageBuilderProperties = new Set();
         },
@@ -143,16 +140,14 @@ const ruleImplementations = {
 
             notUsedProperties.forEach((property) => {
                 log.failure({
-                    ref: `@page.${property}`
+                    ref: `page.hbs`,
+                    message: `@page.${property} is not used`
                 });
             });
         }
     },
     'GS110-NO-UNKNOWN-PAGE-BUILDER-USAGE': {
-        isEnabled: ({options}) => {
-            // TODO: change to `isEnabled: true` when removing labs flag
-            return options && options.labs && options.labs.pageImprovements;
-        },
+        isEnabled: true,
         eachFile: ({file, theme, log}) => {
             const templateTest = file.file.match(/(?<!partials\/.+?)\.hbs$/);
 

package/lib/specs/canary.js

@@ -713,7 +713,19 @@ let rules = {
         details: oneLineTrim`<code>config.custom</code> entry <code>description</code> should be less than <code>100</code> characters so that it is displayed correctly.<br />
         Check the <a href="${docsBaseUrl}custom-settings" target=_blank><code>config.custom</code> documentation</a> for further information.`
     },
-
+    'GS110-NO-MISSING-PAGE-BUILDER-USAGE': {
+        level: 'warning',
+        rule: 'Not all page features are being used',
+        details: oneLineTrim`Some page features used by Ghost via the <code>{{@page}}</code> global are not implemented in this theme.&nbsp;
+        Find more information about the <code>{{@page}}</code> global <a href="${docsBaseUrl}helpers/page/" target=_blank>here</a>.`
+    },
+    'GS110-NO-UNKNOWN-PAGE-BUILDER-USAGE': {
+        level: 'error',
+        fatal: true,
+        rule: 'Unsupported page builder feature used',
+        details: oneLineTrim`A page feature used via the <code>{{@page}}</code> global was detected but it's not supported by this version of Ghost.&nbsp;
+        Find more information about the <code>{{@page}}</code> global <a href="${docsBaseUrl}helpers/page/" target=_blank>here</a>.`
+    },
     'GS120-NO-UNKNOWN-GLOBALS': {
         level: 'error',
         rule: 'Unknown global helper used',

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "gscan",
-  "version": "4.37.3",
+  "version": "4.37.4",
   "description": "Scans Ghost themes looking for errors, deprecations, features and compatibility",
   "keywords": [
     "ghost",