gscan 4.35.0 → 4.36.0

package/lib/specs/canary.js

@@ -33,7 +33,7 @@ let rules = {
     },
     'GS090-NO-AUTHOR-HELPER-IN-POST-CONTEXT': {
         level: 'error',
-        fatal: true,
+        fatal: false,
         rule: 'Replace <code>{{author}}</code> with <code>{{authors}}</code>',
         details: oneLineTrim`The <code>{{author}}</code> helper was removed in favor of <code>{{<authors>}}</code><br>
         ${multiAuthorDesc}<br>
@@ -42,7 +42,7 @@ let rules = {
     },
     'GS090-NO-PRODUCTS-HELPER': {
         level: 'error',
-        fatal: true,
+        fatal: false,
         rule: 'Replace <code>{{products}}</code> with <code>{{tiers}}</code>',
         details: oneLineTrim`The <code>{{products}}</code> helper was removed in favor of <code>{{tiers}}</code><br>
         ${tierDesc}<br>
@@ -51,7 +51,7 @@ let rules = {
     },
     'GS090-NO-PRODUCT-DATA-HELPER': {
         level: 'error',
-        fatal: true,
+        fatal: false,
         rule: 'Replace <code>{{@product}}</code> with <code>{{#get "tiers"}}</code>',
         details: oneLineTrim`The <code>{{@product}}</code> data helper was removed in favor of <code>{{#get "tiers"}}</code><br>
         ${tierDesc}<br>
@@ -60,7 +60,7 @@ let rules = {
     },
     'GS090-NO-PRODUCTS-DATA-HELPER': {
         level: 'error',
-        fatal: true,
+        fatal: false,
         rule: 'Replace <code>{{@products}}</code> with <code>{{#get "tiers"}}</code>',
         details: oneLineTrim`The <code>{{@products}}</code> data helper was removed in favor of <code>{{#get "tiers"}}</code><br>
         ${tierDesc}<br>
@@ -77,7 +77,7 @@ let rules = {
     },
     'GS090-NO-PRICE-DATA-CURRENCY-GLOBAL': {
         level: 'error',
-        fatal: true,
+        fatal: false,
         rule: 'Replace <code>{{@price.currency}}</code> with <code>{{#get "tiers"}}</code> and <code>{{currency}}</code> or <code>{{#foreach @member.subscriptions}}</code> and <code>{{plan.currency}}</code>',
         details: oneLineTrim`There is no longer a global <code>@price</code> object. You need to use either <code>{{#get "tiers"}}</code> to fetch all tiers and use the <code>{{currency}}</code> property of a tier<br>
         or use <code>{{#foreach @member.subscriptions}}</code> to fetch an individual member's subscriptions, and use the <code>{{plan.currency}}</code> property from the subscription.<br>
@@ -85,7 +85,7 @@ let rules = {
     },
     'GS090-NO-PRICE-DATA-CURRENCY-CONTEXT': {
         level: 'error',
-        fatal: true,
+        fatal: false,
         rule: 'Replace <code>{{@price.currency}}</code> with <code>{{currency}}</code> or <code>{{plan.currency}}</code>',
         details: oneLineTrim`There is no longer a global <code>@price</code> object. Instead the <code>{{currency}}</code> property can be used inside <code>{{#get "tiers"}}</code><br>
         or <code>{{plan.currency}}</code> can be used inside <code>{{#foreach @member.subscriptions}}</code><br>
@@ -93,14 +93,14 @@ let rules = {
     },
     'GS090-NO-PRICE-DATA-MONTHLY-YEARLY': {
         level: 'error',
-        fatal: true,
+        fatal: false,
         rule: 'Replace <code>{{@price.monthly}}</code> and <code>{{@price.yearly}}</code> with <code>{{price monthly_price currency=currency}}</code> and <code>{{price yearly_price currency=currency}}</code> after fetching tier data with <code>{{#get "tiers"}}</code>',
         details: oneLineTrim`There is no longer a global <code>@price</code> object. You need to use <code>{{#get "tiers"}}</code> to fetch all the tiers and get access to the <code>{{price monthly_price currency=currency}}</code> or <code>{{price yearly_price currency=currency}}</code> for each tier<br>
         Find more information about the <code>{{price}}</code> helper <a href="${docsBaseUrl}helpers/price/" target=_blank>here</a>.`
     },
     'GS090-NO-TIER-PRICE-AS-OBJECT': {
         level: 'error',
-        fatal: true,
+        fatal: false,
         rule: 'Remove usage of <code>{{monthly_price.*}}</code> and <code>{{yearly_price.*}}.</code>',
         details: oneLineTrim`The usage of <code>{{monthly_price.*}}</code> and <code>{{yearly_price.*}} is no longer supported.</code><br>
         ${tierDesc}<br>
@@ -117,19 +117,9 @@ let rules = {
         helper: '{{#get "tiers"}}'
     },
 
-    // Updated v1 & v2 rules
-    'GS001-DEPR-BLOG': {
-        level: 'error',
-        fatal: true,
-        rule: 'Replace <code>{{@blog}}</code> with <code>{{@site}}</code>',
-        details: oneLineTrim`The usage of <code>{{@blog}}</code> is no longer supported and should be replaced with<code>{{@site}}</code>.<br>
-        Find more information about the <code>@site</code> property <a href="${docsBaseUrl}helpers/site/" target=_blank>here</a>.`,
-        regex: /{{\s*?@blog\.[a-zA-Z0-9_]+\s*?}}/g,
-        helper: '{{@blog}}'
-    },
     'GS001-DEPR-AUTH-ID': {
         level: 'error',
-        fatal: true,
+        fatal: false,
         rule: 'Replace <code>{{author.id}}</code> with <code>{{primary_author.id}}</code> or <code>{{authors.[#].id}}</code>',
         details: oneLineTrim`The usage of <code>{{author.id}}</code> is no longer supported and should be replaced with either <code>{{primary_author.id}}</code>
         or <code>{{authors.[#].id}}</code>.<br>
@@ -140,7 +130,7 @@ let rules = {
     },
     'GS001-DEPR-AUTH-SLUG': {
         level: 'error',
-        fatal: true,
+        fatal: false,
         rule: 'Replace <code>{{author.slug}}</code> with <code>{{primary_author.slug}}</code> or <code>{{authors.[#].slug}}</code>',
         details: oneLineTrim`The usage of <code>{{author.slug}}</code> is no longer supported and should be replaced with either <code>{{primary_author.slug}}</code>
         or <code>{{authors.[#].slug}}</code>.<br>
@@ -151,7 +141,7 @@ let rules = {
     },
     'GS001-DEPR-AUTH-MAIL': {
         level: 'error',
-        fatal: true,
+        fatal: false,
         rule: 'Replace <code>{{author.email}}</code> with <code>{{primary_author.email}}</code> or <code>{{authors.[#].email}}</code>',
         details: oneLineTrim`The usage of <code>{{author.email}}</code> is no longer supported and should be replaced with either <code>{{primary_author.email}}</code>
         or <code>{{authors.[#].email}}</code>.<br>
@@ -162,7 +152,7 @@ let rules = {
     },
     'GS001-DEPR-AUTH-MT': {
         level: 'error',
-        fatal: true,
+        fatal: false,
         rule: 'Replace <code>{{author.meta_title}}</code> with <code>{{primary_author.meta_title}}</code> or <code>{{authors.[#].meta_title}}</code>',
         details: oneLineTrim`The usage of <code>{{author.meta_title}}</code> is no longer supported and should be replaced with either <code>{{primary_author.meta_title}}</code>
         or <code>{{authors.[#].meta_title}}</code>.<br>
@@ -173,7 +163,7 @@ let rules = {
     },
     'GS001-DEPR-AUTH-MD': {
         level: 'error',
-        fatal: true,
+        fatal: false,
         rule: 'Replace <code>{{author.meta_description}}</code> with <code>{{primary_author.meta_description}}</code> or <code>{{authors.[#].meta_description}}</code>',
         details: oneLineTrim`The usage of <code>{{author.meta_description}}</code> is no longer supported and should be replaced with either <code>{{primary_author.meta_description}}</code>
         or <code>{{authors.[#].meta_description}}</code>.<br>
@@ -184,7 +174,7 @@ let rules = {
     },
     'GS001-DEPR-AUTH-NAME': {
         level: 'error',
-        fatal: true,
+        fatal: false,
         rule: 'Replace <code>{{author.name}}</code> with <code>{{primary_author.name}}</code> or <code>{{authors.[#].name}}</code>',
         details: oneLineTrim`The usage of <code>{{author.name}}</code> is no longer supported and should be replaced with either <code>{{primary_author.name}}</code>
         or <code>{{authors.[#].name}}</code>.<br>
@@ -195,7 +185,7 @@ let rules = {
     },
     'GS001-DEPR-AUTH-BIO': {
         level: 'error',
-        fatal: true,
+        fatal: false,
         rule: 'Replace <code>{{author.bio}}</code> with <code>{{primary_author.bio}}</code> or <code>{{authors.[#].bio}}</code>',
         details: oneLineTrim`The usage of <code>{{author.bio}}</code> is no longer supported and should be replaced with either <code>{{primary_author.bio}}</code>
         or <code>{{authors.[#].bio}}</code>.<br>
@@ -206,7 +196,7 @@ let rules = {
     },
     'GS001-DEPR-AUTH-LOC': {
         level: 'error',
-        fatal: true,
+        fatal: false,
         rule: 'Replace <code>{{author.location}}</code> with <code>{{primary_author.location}}</code> or <code>{{authors.[#].location}}</code>',
         details: oneLineTrim`The usage of <code>{{author.location}}</code> is no longer supported and should be replaced with either <code>{{primary_author.location}}</code>
         or <code>{{authors.[#].location}}</code>.<br>
@@ -217,7 +207,7 @@ let rules = {
     },
     'GS001-DEPR-AUTH-WEB': {
         level: 'error',
-        fatal: true,
+        fatal: false,
         rule: 'Replace <code>{{author.website}}</code> with <code>{{primary_author.website}}</code> or <code>{{authors.[#].website}}</code>',
         details: oneLineTrim`The usage of <code>{{author.website}}</code> is no longer supported and should be replaced with either <code>{{primary_author.website}}</code>
         or <code>{{authors.[#].website}}</code>.<br>
@@ -228,7 +218,7 @@ let rules = {
     },
     'GS001-DEPR-AUTH-TW': {
         level: 'error',
-        fatal: true,
+        fatal: false,
         rule: 'Replace <code>{{author.twitter}}</code> with <code>{{primary_author.twitter}}</code> or <code>{{authors.[#].twitter}}</code>',
         details: oneLineTrim`The usage of <code>{{author.twitter}}</code> is no longer supported and should be replaced with either <code>{{primary_author.twitter}}</code>
         or <code>{{authors.[#].twitter}}</code>.<br>
@@ -239,7 +229,7 @@ let rules = {
     },
     'GS001-DEPR-AUTH-FB': {
         level: 'error',
-        fatal: true,
+        fatal: false,
         rule: 'Replace <code>{{author.facebook}}</code> with <code>{{primary_author.facebook}}</code> or <code>{{authors.[#].facebook}}</code>',
         details: oneLineTrim`The usage of <code>{{author.facebook}}</code> is no longer supported and should be replaced with either <code>{{primary_author.facebook}}</code>
         or <code>{{authors.[#].facebook}}</code>.<br>
@@ -250,7 +240,7 @@ let rules = {
     },
     'GS001-DEPR-AUTH-PIMG': {
         level: 'error',
-        fatal: true,
+        fatal: false,
         rule: 'Replace <code>{{author.profile_image}}</code> with <code>{{primary_author.profile_image}}</code> or <code>{{authors.[#].profile_image}}</code>',
         details: oneLineTrim`The usage of <code>{{author.profile_image}}</code> is no longer supported and should be replaced with either <code>{{primary_author.profile_image}}</code>
         or <code>{{authors.[#].profile_image}}</code>.<br>
@@ -261,7 +251,7 @@ let rules = {
     },
     'GS001-DEPR-AUTH-CIMG': {
         level: 'error',
-        fatal: true,
+        fatal: false,
         rule: 'Replace <code>{{author.cover_image}}</code> with <code>{{primary_author.cover_image}}</code> or <code>{{authors.[#].cover_image}}</code>',
         details: oneLineTrim`The usage of <code>{{author.cover_image}}</code> is no longer supported and should be replaced with either <code>{{primary_author.cover_image}}</code>
         or <code>{{authors.[#].cover_image}}</code>.<br>
@@ -272,7 +262,7 @@ let rules = {
     },
     'GS001-DEPR-AUTH-URL': {
         level: 'error',
-        fatal: true,
+        fatal: false,
         rule: 'Replace <code>{{author.url}}</code> with <code>{{primary_author.url}}</code> or <code>{{authors.[#].url}}</code>',
         details: oneLineTrim`The usage of <code>{{author.url}}</code> is no longer supported and should be replaced with either <code>{{primary_author.url}}</code>
         or <code>{{authors.[#].url}}</code>.<br>
@@ -469,7 +459,7 @@ let rules = {
     },
     'GS001-DEPR-IUA': {
         level: 'error',
-        fatal: true,
+        fatal: false,
         rule: 'Replace <code>{{img_url author.*}}</code> with <code>{{img_url primary_author.*}}</code> or <code>.{img_url author.[#].*}}</code>',
         details: oneLineTrim`The usage of <code>{{img_url author.*}}</code> is no longer supported and should be replaced with either <code>{{img_url primary_author.*}}</code>
         or <code>{{img_url author.[#].*}}</code>.<br>
@@ -480,7 +470,7 @@ let rules = {
     },
     'GS001-DEPR-AC': {
         level: 'error',
-        fatal: true,
+        fatal: false,
         rule: 'Replace <code>{{author.cover}}</code> with <code>{{primary_author.cover_image}}</code>',
         details: oneLineTrim`The <code>cover</code> attribute was replaced with <code>cover_image</code>.<br>
         Instead of <code>{{author.cover}}</code> you need to use
@@ -491,7 +481,7 @@ let rules = {
     },
     'GS001-DEPR-AIMG': {
         level: 'error',
-        fatal: true,
+        fatal: false,
         rule: 'Replace <code>{{author.image}}</code> with <code>{{primary_author.profile_image}}</code> or <code>{{authors.[#].profile_image}}</code>',
         details: oneLineTrim`The <code>image</code> attribute was replaced with <code>profile_image</code>.<br>
         Instead of <code>{{author.image}}</code>, you need to use
@@ -502,7 +492,7 @@ let rules = {
     },
     'GS001-DEPR-PAC': {
         level: 'error',
-        fatal: true,
+        fatal: false,
         rule: 'Replace <code>{{post.author.cover}}</code> with <code>{{post.primary_author.cover_image}}</code> or <code>{{post.authors.[#].cover_image}}</code>',
         details: oneLineTrim`The <code>cover</code> attribute was replaced with <code>cover_image</code>.<br>
         Instead of <code>{{post.author.cover}}</code>, you need to use
@@ -513,7 +503,7 @@ let rules = {
     },
     'GS001-DEPR-AUTH-INCL': {
         level: 'error',
-        fatal: true,
+        fatal: false,
         rule: `Replace <code>include="author"</code> with <code>include="authors"</code>`,
         details: oneLineTrim`The usage of <code>{{#get "posts" include="author"}}</code> is no longer supported and should be replaced with <code>{{#get "posts" include="authors"}}</code>.<br>
         Find more information about the <code>{{get}}</code> helper <a href="${docsBaseUrl}helpers/get/" target=_blank>here</a>.`,
@@ -524,7 +514,7 @@ let rules = {
     },
     'GS001-DEPR-AUTH-FIELD': {
         level: 'error',
-        fatal: true,
+        fatal: false,
         rule: `<code>fields="author"</code> should be replaced with <code>fields="authors"</code>`,
         details: oneLineTrim`The usage of <code>{{#get "posts" fields="author"}}</code> is no longer supported and should be replaced with
         <code>{{#get "posts" fields="primary_author"}}</code> or <code>{{#get "posts" fields="authors.[#]"}}</code>.<br>
@@ -536,7 +526,7 @@ let rules = {
     },
     'GS001-DEPR-AUTH-FILT': {
         level: 'error',
-        fatal: true,
+        fatal: false,
         rule: `<code>filter="author:[...]"</code> should be replaced with <code>filter="authors:[...]"</code>`,
         details: oneLineTrim`The usage of <code>{{#get "posts" filter="author:[...]"}}</code> is no longer supported and should be replaced with <code>{{#get "posts" filter="authors:[...]"}}</code>.<br>
         Find more information about the <code>{{get}}</code> helper <a href="${docsBaseUrl}helpers/get/" target=_blank>here</a>.`,
@@ -547,7 +537,7 @@ let rules = {
     },
     'GS001-DEPR-AUTHBL': {
         level: 'error',
-        fatal: true,
+        fatal: false,
         rule: 'The <code>{{#author}}</code> block helper should be replaced with <code>{{#primary_author}}</code> or <code>{{#foreach authors}}...{{/foreach}}</code>',
         details: oneLineTrim`The usage of <code>{{#author}}</code> block helper outside of <code>author.hbs</code> is no longer supported and
         should be replaced with <code>{{#primary_author}}</code> or <code>{{#foreach authors}}...{{/foreach}}</code>.<br>
@@ -559,7 +549,7 @@ let rules = {
     },
     'GS001-DEPR-PAIMG': {
         level: 'error',
-        fatal: true,
+        fatal: false,
         rule: 'Replace <code>{{post.author.image}}</code> with <code>{{post.primary_author.profile_image}}</code> or <code>{{post.authors.[#].profile_image}}</code>',
         details: oneLineTrim`The <code>image</code> attribute was replaced with <code>profile_image</code>.<br>
         Instead of <code>{{post.author.image}}</code>, you need to use
@@ -570,7 +560,7 @@ let rules = {
     },
     'GS001-DEPR-CON-AUTH': {
         level: 'error',
-        fatal: true,
+        fatal: false,
         rule: `The <code>{{#if author.*}}</code> block helper should be replaced with <code>{{#if primary_author.*}}</code>
         or <code>{{#if authors.[#].*}}</code>`,
         details: oneLineTrim`The usage of <code>{{#if author.*}}</code> is no longer supported and should be replaced with <code>{{#if primary_author.*}}</code>
@@ -582,7 +572,7 @@ let rules = {
     },
     'GS001-DEPR-CON-PAUTH': {
         level: 'error',
-        fatal: true,
+        fatal: false,
         rule: `The <code>{{#if post.author.*}}</code> block helper should be replaced with <code>{{#if post.primary_author.*}}</code>
         or <code>{{#if post.authors.[#].*}}</code>`,
         details: oneLineTrim`The usage of <code>{{#if post.author.*}}</code> is no longer supported and should be replaced with <code>{{#if post.primary_author.*}}</code>
@@ -594,7 +584,7 @@ let rules = {
     },
     'GS001-DEPR-CON-AC': {
         level: 'error',
-        fatal: true,
+        fatal: false,
         rule: 'Replace <code>{{#if author.cover}}</code> with <code>{{#if primary_author.cover_image}}</code> or <code>{{#if authors.[#].cover_image}}</code>',
         details: oneLineTrim`The <code>cover</code> attribute was replaced with <code>cover_image</code>.<br>
         Instead of <code>{{#if author.cover}}</code>, you need to use
@@ -605,7 +595,7 @@ let rules = {
     },
     'GS001-DEPR-CON-AIMG': {
         level: 'error',
-        fatal: true,
+        fatal: false,
         rule: 'Replace <code>{{#if author.image}}</code> with <code>{{#if primary_author.profile_image}}</code> or <code>{{#if authors.[#].profile_image}}</code>',
         details: oneLineTrim`The <code>image</code> attribute was replaced with <code>profile_image</code>.<br>
         Instead of <code>{{#if author.image}}</code>, you need to use
@@ -616,7 +606,7 @@ let rules = {
     },
     'GS001-DEPR-CON-PAC': {
         level: 'error',
-        fatal: true,
+        fatal: false,
         rule: 'Replace <code>{{#if post.author.cover}}</code> with <code>{{#if post.primary_author.cover_image}}</code> or <code>{{#if post.authors.[#].cover_image}}</code>',
         details: oneLineTrim`The <code>cover</code> attribute was replaced with <code>cover_image</code>.<br>
         Instead of <code>{{#if post.author.cover}}</code>, you need to use
@@ -627,7 +617,7 @@ let rules = {
     },
     'GS001-DEPR-CON-PAIMG': {
         level: 'error',
-        fatal: true,
+        fatal: false,
         rule: 'Replace <code>{{#if post.author.image}}</code> with <code>{{#if post.primary_author.profile_image}}</code> or <code>{{#if post.authors.[#].profile_image}}</code>',
         details: oneLineTrim`The <code>image</code> attribute was replaced with <code>profile_image</code>.<br>
         Instead of <code>{{#if post.author.image}}</code>, you need to use
@@ -684,7 +674,6 @@ let rules = {
     },
     'GS001-DEPR-LANG': {
         level: 'error',
-        fatal: true,
         rule: 'Replace <code>{{lang}}</code> with <code>{{@site.locale}}</code>',
         details: oneLineTrim`The usage of <code>{{lang}}</code> is no longer supported and should be replaced with <code>{{@site.locale}}</code>.<br>
         Find more information about the <code>@site.locale</code> property <a href="${docsBaseUrl}helpers/site/" target=_blank>here</a>.`,
@@ -702,26 +691,16 @@ let rules = {
     },
     'GS001-DEPR-USER-GET': {
         level: 'error',
-        fatal: true,
+        fatal: false,
         rule: `Replace <code>{{#get "users"}}</code> with <code>{{#get "authors"}}</code>`,
         details: oneLineTrim`The usage of <code>{{#get "users"}}</code> is no longer supported and should be replaced with <code>{{#get "authors"}}</code>.<br>
         Find more information about the <code>{{get}}</code> helper <a href="${docsBaseUrl}helpers/get/" target=_blank>here</a>.`,
         regex: /{{\s*?#get ("|')\s*users("|')\s*/g,
         helper: '{{#get "users"}}'
     },
-    'GS001-DEPR-ESC': {
-        level: 'error',
-        fatal: true,
-        rule: 'Replace <code>{{error.code}}</code> with <code>{{error.statusCode}}</code>',
-        details: oneLineTrim`The usage of <code>{{error.code}}</code> is no longer supported and should be replaced with <code>{{error.statusCode}}</code>.<br>
-        When in <code>error</code> context, e. g. in the <code>error.hbs</code> template, replace <code>{{code}}</code> with <code>{{statusCode}}</code>.<br>
-        Find more information about the <code>error.hbs</code> template <a href="${docsBaseUrl}structure/#errorhbs" target=_blank>here</a>.`,
-        regex: /{{\s*?(?:error\.)?(code)\s*?}}/g,
-        helper: '{{error.code}}'
-    },
     'GS001-DEPR-CURR-SYM': {
         level: 'error',
-        fatal: true,
+        fatal: false,
         rule: 'Replace <code>{{[#].currency_symbol}}</code> with <code>{{price currency=currency}}</code>.',
         details: oneLineTrim`The <code>currency_symbol</code> attribute is no longer supported in favour of passing the currency to updated <code>{{price}}</code> helper.<br>
         Find more information about the updated <code>{{price}}</code> helper <a href="${docsBaseUrl}helpers/price/" target=_blank>here</a>.`,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "gscan",
-  "version": "4.35.0",
+  "version": "4.36.0",
   "description": "Scans Ghost themes looking for errors, deprecations, features and compatibility",
   "keywords": [
     "ghost",
@@ -14,7 +14,7 @@
     "url": "git@github.com:TryGhost/gscan.git"
   },
   "engines": {
-    "node": "^14.17.0 || ^16.13.0 || ^18.12.1"
+    "node": "^14.18.0 || ^16.13.0 || ^18.12.1"
   },
   "bugs": {
     "url": "https://github.com/TryGhost/gscan/issues"
@@ -40,7 +40,7 @@
     "gscan": "./bin/cli.js"
   },
   "dependencies": {
-    "@sentry/node": "7.28.1",
+    "@sentry/node": "7.29.0",
     "@tryghost/config": "0.2.13",
     "@tryghost/debug": "0.1.21",
     "@tryghost/errors": "1.2.20",