gscan 4.28.0 → 4.29.2

package/lib/specs/v3.js

@@ -2,8 +2,9 @@ const _ = require('lodash');
 const oneLineTrim = require('common-tags/lib/oneLineTrim');
 const previousSpec = require('./v2');
 const ghostVersions = require('../utils').versions;
-const docsBaseUrl = `https://ghost.org/docs/api/handlebars-themes/`;
-const faqBaseUrl = `https://ghost.org/faq/`;
+const docsBaseUrl = `https://ghost.org/docs/themes/`;
+// TODO: we don't use versioned docs anymore and the previous rules should only contain
+// correct links. The usage of replacing the previousBaseUrl can probably be removed
 const prevDocsBaseUrl = `https://themes.ghost.org/v${ghostVersions.v2.docs}/docs/`;
 const prevDocsBaseUrlRegEx = new RegExp(prevDocsBaseUrl, 'g');
 
@@ -21,14 +22,14 @@ let rules = {
         rule: '<code>package.json</code> property <code>"engines.ghost-api"</code> is recommended. Otherwise, it falls back to "v3"',
         details: oneLineTrim`Please add <code>"ghost-api"</code> to your <code>package.json</code>. E.g. <code>{"engines": {"ghost-api": "v3"}}</code>.<br>
         If no <code>"ghost-api"</code> property is provided, Ghost will use its default setting of "v3" Ghost API.<br>
-        Check the <a href="${docsBaseUrl}packagejson/" target=_blank><code>package.json</code> documentation</a> for further information.`
+        Check the <a href="${docsBaseUrl}structure/#packagejson" target=_blank><code>package.json</code> documentation</a> for further information.`
     },
     'GS010-PJ-GHOST-API-V01': {
         level: 'error',
         rule: '<code>package.json</code> property <code>"engines.ghost-api"</code> is incompatible with current version of Ghost API and will fall back to "v3"',
         details: oneLineTrim`Please change <code>"ghost-api"</code> in your <code>package.json</code> to higher version. E.g. <code>{"engines": {"ghost-api": "v3"}}</code>.<br>
         If <code>"ghost-api"</code> property is left at "v0.1", Ghost will use its default setting of "v3".<br>
-        Check the <a href="${docsBaseUrl}packagejson/" target=_blank><code>package.json</code> documentation</a> for further information.`
+        Check the <a href="${docsBaseUrl}structure/#packagejson" target=_blank><code>package.json</code> documentation</a> for further information.`
     },
     'GS001-DEPR-ESC': {
         level: 'error',
@@ -43,7 +44,7 @@ let rules = {
         level: 'error',
         rule: 'The v0.1 API and <code>ghost.url.api()</code> JavaScript helper have been removed.',
         details: oneLineTrim`The v0.1 API & Public API Beta have been removed, along with the <code>public/ghost-sdk.min.js</code> file & the <code>ghost.url.api()</code> helper.<br>
-        All code relying on the v0.1 API must be upgraded to use the <a href="${faqBaseUrl}upgrades/" target=_blank>new API</a>.`,
+        All code relying on the v0.1 API must be upgraded to use the <a href="https://ghost.org/docs/changes/" target=_blank>new API</a>.`,
         regex: /ghost\.url\.api/g
     },
     'GS070-VALID-TRANSLATIONS': {
@@ -68,5 +69,6 @@ rules = _.each(_.merge({}, previousRules, rules), function replaceDocsUrl(value)
 module.exports = {
     knownHelpers: knownHelpers,
     templates: templates,
-    rules: rules
+    rules: rules,
+    defaultPackageJSON: previousSpec.defaultPackageJSON
 };

package/lib/specs/v4.js

@@ -3,6 +3,8 @@ const oneLineTrim = require('common-tags/lib/oneLineTrim');
 const previousSpec = require('./v3');
 const ghostVersions = require('../utils').versions;
 const docsBaseUrl = `https://ghost.org/docs/themes/`;
+// TODO: we don't use versioned docs anymore and the previous rules should only contain
+// correct links. The usage of replacing the previousBaseUrl can probably be removed
 const prevDocsBaseUrl = `https://themes.ghost.org/v${ghostVersions.v3.docs}/docs/`;
 const prevDocsBaseUrlRegEx = new RegExp(prevDocsBaseUrl, 'g');
 
@@ -15,7 +17,7 @@ function cssCardRule(cardName, className) {
         level: 'warning',
         rule: `The <code>.${className}</code> CSS class is required to appear styled in your theme`,
         details: oneLineTrim`The <code>.${className}</code> CSS class is required otherwise the ${cardName} card will appear unstyled.
-        Find out more about required theme changes for the Koenig editor <a href="${docsBaseUrl}editor/" target=_blank>here</a>.`,
+        Find out more about required theme changes for the Koenig editor <a href="${docsBaseUrl}content/" target=_blank>here</a>.`,
         regex: new RegExp(`\\.${className}`, 'g'),
         className: `.${className}`,
         css: true,
@@ -33,75 +35,75 @@ let rules = {
         rule: '<code>package.json</code> property <code>"engines.ghost-api"</code> is deprecated.',
         details: oneLineTrim`Remove <code>"ghost-api"</code> from your <code>package.json</code>.<br>
         The <code>ghost-api</code> support will be removed in next major version of Ghost and should not be used.
-        Check the <a href="${docsBaseUrl}packagejson/" target=_blank><code>package.json</code> documentation</a> for further information.`
+        Check the <a href="${docsBaseUrl}structure/#packagejson" target=_blank><code>package.json</code> documentation</a> for further information.`
     },
     'GS010-PJ-GHOST-API-V01': {
         level: 'error',
         rule: '<code>package.json</code> property <code>"engines.ghost-api"</code> is incompatible with current version of Ghost API and will fall back to "v4"',
         details: oneLineTrim`Change <code>"ghost-api"</code> in your <code>package.json</code> to higher version. E.g. <code>{"engines": {"ghost-api": "v4"}}</code>.<br>
         If <code>"ghost-api"</code> property is left at "v0.1", Ghost will use its default setting of "v4".<br>
-        Check the <a href="${docsBaseUrl}packagejson/" target=_blank><code>package.json</code> documentation</a> for further information.`
+        Check the <a href="${docsBaseUrl}structure/#packagejson" target=_blank><code>package.json</code> documentation</a> for further information.`
     },
     'GS010-PJ-GHOST-API-V2': {
         level: 'warning',
         rule: '<code>package.json</code> property <code>"engines.ghost-api"</code> is using a deprecated version of Ghost API',
         details: oneLineTrim`Change <code>"ghost-api"</code> in your <code>package.json</code> to higher version. E.g. <code>{"engines": {"ghost-api": "v4"}}</code>.<br>
         If <code>"ghost-api"</code> property is left at "v2", it will stop working with next major version upgrade and default to v5.<br>
-        Check the <a href="${docsBaseUrl}packagejson/" target=_blank><code>package.json</code> documentation</a> for further information.`
+        Check the <a href="${docsBaseUrl}structure/#packagejson" target=_blank><code>package.json</code> documentation</a> for further information.`
     },
     'GS010-PJ-CUST-THEME-TOTAL-SETTINGS': {
         level: 'error',
         rule: '<code>package.json</code> property <code>"config.custom"</code> contains too many settings',
         details: oneLineTrim`Remove key from <code>"config.custom"</code> in your <code>package.json</code> to have less than or exactly 15 settings.<br>
-        Check the <a href="${docsBaseUrl}packagejson/" target=_blank><code>package.json</code> documentation</a> for further information.`
+        Check the <a href="${docsBaseUrl}structure/#packagejson" target=_blank><code>package.json</code> documentation</a> for further information.`
     },
     'GS010-PJ-CUST-THEME-SETTINGS-CASE': {
         level: 'error',
         rule: '<code>package.json</code> property <code>"config.custom"</code> contains a property that isn\'t snake-cased',
         details: oneLineTrim`Rewrite all property in <code>"config.custom"</code> in your <code>package.json</code> in snake case.<br>
-        Check the <a href="${docsBaseUrl}packagejson/" target=_blank><code>package.json</code> documentation</a> for further information.`
+        Check the <a href="${docsBaseUrl}structure/#packagejson" target=_blank><code>package.json</code> documentation</a> for further information.`
     },
     'GS010-PJ-CUST-THEME-SETTINGS-TYPE': {
         level: 'error',
         rule: '<code>package.json</code> objects defined in <code>"config.custom"</code> should have a known <code>"type"</code>.',
         details: oneLineTrim`Only use the following types: <code>"select"</code>, <code>"boolean"</code>, <code>"color"</code>, <code>"image"</code>, <code>"text"</code>.<br>
-        Check the <a href="${docsBaseUrl}packagejson/" target=_blank><code>package.json</code> documentation</a> for further information.`
+        Check the <a href="${docsBaseUrl}structure/#packagejson" target=_blank><code>package.json</code> documentation</a> for further information.`
     },
     'GS010-PJ-CUST-THEME-SETTINGS-GROUP': {
         level: 'recommendation',
         rule: '<code>package.json</code> objects defined in <code>"config.custom"</code> should have a known <code>"group"</code>.',
         details: oneLineTrim`Only use the following groups: <code>"post"</code>, <code>"homepage"</code>.<br>
-        Check the <a href="${docsBaseUrl}packagejson/" target=_blank><code>package.json</code> documentation</a> for further information.`
+        Check the <a href="${docsBaseUrl}structure/#packagejson" target=_blank><code>package.json</code> documentation</a> for further information.`
     },
     'GS010-PJ-CUST-THEME-SETTINGS-SELECT-OPTIONS': {
         level: 'error',
         rule: '<code>package.json</code> objects defined in <code>"config.custom"</code> of type <code>"select"</code> need to have at least 2 <code>"options"</code>.',
         details: oneLineTrim`Make sure there is at least 2 <code>"options"</code> in each <code>"select"</code> custom theme property.<br>
-        Check the <a href="${docsBaseUrl}packagejson/" target=_blank><code>package.json</code> documentation</a> for further information.`
+        Check the <a href="${docsBaseUrl}structure/#packagejson" target=_blank><code>package.json</code> documentation</a> for further information.`
     },
     'GS010-PJ-CUST-THEME-SETTINGS-SELECT-DEFAULT': {
         level: 'error',
         rule: '<code>package.json</code> objects defined in <code>"config.custom"</code> of type <code>"select"</code> need to have a valid <code>"default"</code>.',
         details: oneLineTrim`Make sure the <code>"default"</code> property matches a value in <code>"options"</code> of the same <code>"select"</code>.<br>
-        Check the <a href="${docsBaseUrl}packagejson/" target=_blank><code>package.json</code> documentation</a> for further information.`
+        Check the <a href="${docsBaseUrl}structure/#packagejson" target=_blank><code>package.json</code> documentation</a> for further information.`
     },
     'GS010-PJ-CUST-THEME-SETTINGS-BOOLEAN-DEFAULT': {
         level: 'error',
         rule: '<code>package.json</code> objects defined in <code>"config.custom"</code> of type <code>"boolean"</code> need to have a valid <code>"default"</code>.',
         details: oneLineTrim`Make sure the <code>"default"</code> property is either <code>true</code> or <code>false</code>.<br>
-        Check the <a href="${docsBaseUrl}packagejson/" target=_blank><code>package.json</code> documentation</a> for further information.`
+        Check the <a href="${docsBaseUrl}structure/#packagejson" target=_blank><code>package.json</code> documentation</a> for further information.`
     },
     'GS010-PJ-CUST-THEME-SETTINGS-COLOR-DEFAULT': {
         level: 'error',
         rule: '<code>package.json</code> objects defined in <code>"config.custom"</code> of type <code>"color"</code> need to have a valid <code>"default"</code>.',
         details: oneLineTrim`Make sure the <code>"default"</code> property is a valid 6-hexadecimal-digit color code like <code>#15171a</code>.<br>
-        Check the <a href="${docsBaseUrl}packagejson/" target=_blank><code>package.json</code> documentation</a> for further information.`
+        Check the <a href="${docsBaseUrl}structure/#packagejson" target=_blank><code>package.json</code> documentation</a> for further information.`
     },
     'GS010-PJ-CUST-THEME-SETTINGS-IMAGE-DEFAULT': {
         level: 'error',
         rule: '<code>package.json</code> objects defined in <code>"config.custom"</code> of type <code>"image"</code> can\'t have a <code>"default"</code> value.',
         details: oneLineTrim`Make sure the <code>"default"</code> property is either <code>null</code>, an empty string <code>''</code> or isn't present.<br>
-        Check the <a href="${docsBaseUrl}packagejson/" target=_blank><code>package.json</code> documentation</a> for further information.`
+        Check the <a href="${docsBaseUrl}structure/#packagejson" target=_blank><code>package.json</code> documentation</a> for further information.`
     },
     'GS001-DEPR-LABS-MEMBERS': {
         level: 'warning',
@@ -114,8 +116,8 @@ let rules = {
     },
     'GS080-FEACH-POSTS': {
         level: 'warning',
-        rule: 'The default visibility for posts in <code>{{#foreach}}</code> block helper has changed in v4.',
-        details: oneLineTrim`The default visibility for posts in <code>{{#foreach}}</code> block helper has changed from <code>public</code> to <code>all</code> in Ghost v4.
+        rule: 'The default visibility for posts in <code>{{#foreach}}</code> block helper changed in Ghost v4.',
+        details: oneLineTrim`The default visibility for posts in <code>{{#foreach}}</code> block helper changed from <code>public</code> to <code>all</code>.<br>
         Find more information about the <code>{{foreach}}</code> helper <a href="${docsBaseUrl}helpers/foreach/" target=_blank>here</a>.`,
         regex: /{{\s*?#foreach\s*?\w*?\s*?}}/g,
         helper: '{{#foreach}}',
@@ -133,7 +135,7 @@ let rules = {
     'GS080-FEACH-PV': {
         level: 'recommendation',
         rule: 'The use of <code>visibility="all"</code> is no longer required for posts in <code>{{#foreach}}</code> helper.',
-        details: oneLineTrim`The default visibility in <code>{{#foreach}}</code> helper for posts has changed in v4 from "public" to "all" and is no longer required when looping over posts.
+        details: oneLineTrim`The default visibility in <code>{{#foreach}}</code> helper for posts changed in v4 from <code>public</code> to <code>all</code> and is no longer required when looping over posts.<br>
         Check out the documentation for <code>{{#foreach}}</code> <a href="${docsBaseUrl}helpers/foreach/" target=_blank>here</a>.`,
         regex: /{{\s*?#foreach\b[\w\s='"]*?visibility=("|')all("|')[\w\s='"]*?}}/g,
         helper: '{{#foreach}}',
@@ -149,7 +151,7 @@ let rules = {
     },
     'GS001-DEPR-SITE-LANG': {
         level: 'warning',
-        rule: 'The <code>{{@site.lang}}</code> helper should be replaced with <code>{{@site.locale}}</code>',
+        rule: 'Replace <code>{{@site.lang}}</code> with <code>{{@site.locale}}</code>',
         details: oneLineTrim`Replace <code>{{@site.lang}}</code> helper with <code>{{@site.locale}}</code>.<br>
         The <code>{{@site.lang}}</code> helper will be removed in next version of Ghost and should not be used.
         Find more information about the <code>@site</code> property <a href="${docsBaseUrl}helpers/site/" target=_blank>here</a>.`,
@@ -182,7 +184,7 @@ let rules = {
     },
     'GS090-NO-PRODUCTS-HELPER': {
         level: 'warning',
-        rule: 'The <code>{{products}}</code> helper should be replaces with <code>{{tiers}}</code>',
+        rule: 'Replace <code>{{products}}</code> with <code>{{tiers}}</code>',
         details: oneLineTrim`The <code>{{products}}</code> helper has been deprecated in favor of <code>{{tiers}}</code><br>
         The <code>{{products}}</code> helper will be removed in Ghost v5 and should not be used.
         Find more information about the <code>{{tiers}}</code> property <a href="${docsBaseUrl}helpers/tiers/" target=_blank>here</a>.`,
@@ -190,7 +192,7 @@ let rules = {
     },
     'GS090-NO-PRODUCT-DATA-HELPER': {
         level: 'warning',
-        rule: 'The <code>{{@product}}</code> data helper should be replaces with <code>{{#get "tiers"}}</code>',
+        rule: 'Replace <code>{{@product}}</code> with <code>{{#get "tiers"}}</code>',
         details: oneLineTrim`The <code>{{@product}}</code> data helper has been deprecated in favor of <code>{{#get "tiers"}}</code><br>
         The <code>{{@product}}</code> data helper will be removed in Ghost v5 and should not be used.
         Find more information about the <code>{{#get "tiers"}}</code> property <a href="${docsBaseUrl}helpers/tiers/" target=_blank>here</a>.`,
@@ -198,7 +200,7 @@ let rules = {
     },
     'GS090-NO-PRODUCTS-DATA-HELPER': {
         level: 'warning',
-        rule: 'The <code>{{@products}}</code> data helper should be replaces with <code>{{#get "tiers"}}</code>',
+        rule: 'Replace <code>{{@products}}</code> with <code>{{#get "tiers"}}</code>',
         details: oneLineTrim`The <code>{{@products}}</code> data helper has been deprecated in favor of <code>{{#get "tiers"}}</code><br>
         The <code>{{@products}}</code> data helper will be removed in Ghost v5 and should not be used.
         Find more information about the <code>{{#get "tiers"}}</code> property <a href="${docsBaseUrl}helpers/tiers/" target=_blank>here</a>.`,
@@ -331,5 +333,6 @@ rules = _.each(rules, function replaceDocsUrl(value) {
 module.exports = {
     knownHelpers: knownHelpers,
     templates: templates,
-    rules: rules
+    rules: rules,
+    defaultPackageJSON: previousSpec.defaultPackageJSON
 };

package/lib/utils/package-json.js

@@ -1,22 +1,13 @@
-/**
- * Copy of Ghost defaults for https://github.com/TryGhost/Ghost/blob/e25f1df0ae551c447da0d319bae06eadf9665444/core/frontend/services/theme-engine/config/defaults.json
- */
-const defaultConfig = {
-    posts_per_page: 5,
-    card_assets: {
-        exclude: ['bookmark', 'gallery']
-    }
-};
-
 /**
  * Extracts the package.json JSON content. Note that this function never throws,
  * even when there is a JSON parsing error.
  * This function uses the default `config` property to match Ghost implementation.
  * @param {Object} theme The theme to extract package.json from.
+ * @param {Object} defaultConfig JSON matching the default theme configuration for the checked Ghost version
  * @returns {Object} The content of the package.json file, or `null` if
  * something happened (no file, JSON parsing error...).
  */
-function getJSON(theme) {
+function getJSON(theme, defaultConfig) {
     let packageJSON = theme.files.find(item => item.file === 'package.json');
     if (packageJSON && packageJSON.content) {
         try {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "gscan",
-  "version": "4.28.0",
+  "version": "4.29.2",
   "description": "Scans Ghost themes looking for errors, deprecations, features and compatibility",
   "keywords": [
     "ghost",
@@ -8,7 +8,7 @@
     "validator",
     "lint"
   ],
-  "homepage": "https://ghost.org",
+  "homepage": "https://ghost.org/",
   "repository": {
     "type": "git",
     "url": "git@github.com:TryGhost/gscan.git"
@@ -22,7 +22,7 @@
   "author": {
     "name": "Ghost Foundation",
     "email": "hello@ghost.org",
-    "web": "https://ghost.org"
+    "web": "https://ghost.org/"
   },
   "main": "lib",
   "license": "MIT",
@@ -54,7 +54,7 @@
     "express": "4.18.1",
     "express-hbs": "2.4.0",
     "fs-extra": "10.1.0",
-    "glob": "7.2.2",
+    "glob": "7.2.3",
     "lodash": "4.17.21",
     "multer": "1.4.4",
     "pluralize": "8.0.0",