gscan 4.26.1 → 4.29.0

package/lib/specs/v4.js

@@ -24,7 +24,7 @@ function cssCardRule(cardName, className) {
 }
 
 // assign new or overwrite existing knownHelpers, templates, or rules here:
-let knownHelpers = ['match'];
+let knownHelpers = ['match', 'tiers'];
 let templates = [];
 let rules = {
     // New rules
@@ -149,7 +149,7 @@ let rules = {
     },
     'GS001-DEPR-SITE-LANG': {
         level: 'warning',
-        rule: 'The <code>{{@site.lang}}</code> helper should be replaced with <code>{{@site.locale}}</code>',
+        rule: 'Replace <code>{{@site.lang}}</code> with <code>{{@site.locale}}</code>',
         details: oneLineTrim`Replace <code>{{@site.lang}}</code> helper with <code>{{@site.locale}}</code>.<br>
         The <code>{{@site.lang}}</code> helper will be removed in next version of Ghost and should not be used.
         Find more information about the <code>@site</code> property <a href="${docsBaseUrl}helpers/site/" target=_blank>here</a>.`,
@@ -182,7 +182,7 @@ let rules = {
     },
     'GS090-NO-PRODUCTS-HELPER': {
         level: 'warning',
-        rule: 'The <code>{{products}}</code> helper should be replaces with <code>{{tiers}}</code>',
+        rule: 'Replace <code>{{products}}</code> with <code>{{tiers}}</code>',
         details: oneLineTrim`The <code>{{products}}</code> helper has been deprecated in favor of <code>{{tiers}}</code><br>
         The <code>{{products}}</code> helper will be removed in Ghost v5 and should not be used.
         Find more information about the <code>{{tiers}}</code> property <a href="${docsBaseUrl}helpers/tiers/" target=_blank>here</a>.`,
@@ -190,7 +190,7 @@ let rules = {
     },
     'GS090-NO-PRODUCT-DATA-HELPER': {
         level: 'warning',
-        rule: 'The <code>{{@product}}</code> data helper should be replaces with <code>{{#get "tiers"}}</code>',
+        rule: 'Replace <code>{{@product}}</code> with <code>{{#get "tiers"}}</code>',
         details: oneLineTrim`The <code>{{@product}}</code> data helper has been deprecated in favor of <code>{{#get "tiers"}}</code><br>
         The <code>{{@product}}</code> data helper will be removed in Ghost v5 and should not be used.
         Find more information about the <code>{{#get "tiers"}}</code> property <a href="${docsBaseUrl}helpers/tiers/" target=_blank>here</a>.`,
@@ -198,7 +198,7 @@ let rules = {
     },
     'GS090-NO-PRODUCTS-DATA-HELPER': {
         level: 'warning',
-        rule: 'The <code>{{@products}}</code> data helper should be replaces with <code>{{#get "tiers"}}</code>',
+        rule: 'Replace <code>{{@products}}</code> with <code>{{#get "tiers"}}</code>',
         details: oneLineTrim`The <code>{{@products}}</code> data helper has been deprecated in favor of <code>{{#get "tiers"}}</code><br>
         The <code>{{@products}}</code> data helper will be removed in Ghost v5 and should not be used.
         Find more information about the <code>{{#get "tiers"}}</code> property <a href="${docsBaseUrl}helpers/tiers/" target=_blank>here</a>.`,
@@ -331,5 +331,6 @@ rules = _.each(rules, function replaceDocsUrl(value) {
 module.exports = {
     knownHelpers: knownHelpers,
     templates: templates,
-    rules: rules
+    rules: rules,
+    defaultPackageJSON: previousSpec.defaultPackageJSON
 };

package/lib/utils/package-json.js

@@ -1,22 +1,13 @@
-/**
- * Copy of Ghost defaults for https://github.com/TryGhost/Ghost/blob/e25f1df0ae551c447da0d319bae06eadf9665444/core/frontend/services/theme-engine/config/defaults.json
- */
-const defaultConfig = {
-    posts_per_page: 5,
-    card_assets: {
-        exclude: ['bookmark', 'gallery']
-    }
-};
-
 /**
  * Extracts the package.json JSON content. Note that this function never throws,
  * even when there is a JSON parsing error.
  * This function uses the default `config` property to match Ghost implementation.
  * @param {Object} theme The theme to extract package.json from.
+ * @param {Object} defaultConfig JSON matching the default theme configuration for the checked Ghost version
  * @returns {Object} The content of the package.json file, or `null` if
  * something happened (no file, JSON parsing error...).
  */
-function getJSON(theme) {
+function getJSON(theme, defaultConfig) {
     let packageJSON = theme.files.find(item => item.file === 'package.json');
     if (packageJSON && packageJSON.content) {
         try {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "gscan",
-  "version": "4.26.1",
+  "version": "4.29.0",
   "description": "Scans Ghost themes looking for errors, deprecations, features and compatibility",
   "keywords": [
     "ghost",
@@ -14,7 +14,7 @@
     "url": "git@github.com:TryGhost/gscan.git"
   },
   "engines": {
-    "node": "^12.22.1 || ^14.17.0 || ^16.13.0"
+    "node": "^14.17.0 || ^16.13.0"
   },
   "bugs": {
     "url": "https://github.com/TryGhost/gscan/issues"
@@ -40,26 +40,26 @@
     "gscan": "./bin/cli.js"
   },
   "dependencies": {
-    "@sentry/node": "6.19.3",
+    "@sentry/node": "6.19.7",
     "@tryghost/config": "0.2.2",
     "@tryghost/debug": "0.1.11",
-    "@tryghost/errors": "1.2.7",
-    "@tryghost/logging": "2.1.2",
-    "@tryghost/pretty-cli": "1.2.24",
+    "@tryghost/errors": "1.2.12",
+    "@tryghost/logging": "2.1.8",
+    "@tryghost/pretty-cli": "1.2.27",
     "@tryghost/server": "0.1.4",
-    "@tryghost/zip": "1.1.22",
+    "@tryghost/zip": "1.1.25",
     "bluebird": "3.7.2",
     "chalk": "4.1.2",
     "common-tags": "1.8.2",
-    "express": "4.17.3",
+    "express": "4.18.1",
     "express-hbs": "2.4.0",
-    "fs-extra": "10.0.1",
-    "glob": "7.2.0",
+    "fs-extra": "10.1.0",
+    "glob": "7.2.3",
     "lodash": "4.17.21",
     "multer": "1.4.4",
     "pluralize": "8.0.0",
     "require-dir": "1.2.0",
-    "semver": "7.3.5",
+    "semver": "7.3.7",
     "uuid": "8.3.2",
     "validator": "13.0.0"
   },
@@ -67,11 +67,11 @@
     "eslint": "8.1.0",
     "eslint-plugin-ghost": "2.1.0",
     "istanbul": "0.4.5",
-    "mocha": "9.0.2",
+    "mocha": "10.0.0",
     "nodemon": "2.0.7",
     "rewire": "6.0.0",
     "should": "13.2.3",
-    "sinon": "13.0.0"
+    "sinon": "14.0.0"
   },
   "files": [
     "lib",